| *** edmondsw has quit IRC | 00:00 | |
| *** edmondsw has joined #openstack-powervm | 01:44 | |
| *** edmondsw has quit IRC | 01:48 | |
| *** esberglu has quit IRC | 04:10 | |
| *** chhavi__ has joined #openstack-powervm | 04:46 | |
| *** edmondsw has joined #openstack-powervm | 05:20 | |
| *** edmondsw has quit IRC | 05:24 | |
| *** edmondsw has joined #openstack-powervm | 07:08 | |
| *** edmondsw has quit IRC | 07:13 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 08:08 | |
| *** edmondsw has joined #openstack-powervm | 08:56 | |
| *** edmondsw has quit IRC | 09:01 | |
| *** edmondsw has joined #openstack-powervm | 10:44 | |
| *** edmondsw has quit IRC | 10:49 | |
| *** AlexeyAbashkin has quit IRC | 11:06 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 11:25 | |
| *** edmondsw has joined #openstack-powervm | 12:33 | |
| *** edmondsw has quit IRC | 12:38 | |
| *** chas has joined #openstack-powervm | 13:21 | |
| *** apearson__ has joined #openstack-powervm | 13:41 | |
| *** efried has joined #openstack-powervm | 13:53 | |
| *** edmondsw has joined #openstack-powervm | 14:21 | |
| *** edmondsw_ has joined #openstack-powervm | 14:24 | |
| *** esberglu has joined #openstack-powervm | 14:28 | |
| *** edmondsw has quit IRC | 14:28 | |
| *** edmondsw_ is now known as edmondsw | 14:45 | |
| edmondsw | efried is there a reason not to autospec nova mocks? | 14:46 |
|---|---|---|
| edmondsw | esberglu thought we should only autospec pypowervm and not nova | 14:46 |
| edmondsw | I thought we should autospec pretty much everything | 14:46 |
| efried | There were some bugs in mock around autospec that made that impractical, but I think they're fixed now, at least some of them. claudiub was working that. | 14:52 |
| efried | It would be ambitious to autospec *everything*. But a good goal long term. | 14:52 |
| edmondsw | I meant more in new code, like in the pypowervm patches | 14:52 |
| efried | We can. It tends to be a fair bit of overhead, but sure helps flush out bugs. | 14:53 |
| esberglu | Okay, I can add autospec to the new vscsi test code. I didnt autospec everything in OVS/SEA, but I will leave that since were up to core reviews there | 14:58 |
| esberglu | edmondsw: https://review.openstack.org/#/c/526094/19/nova/tests/unit/virt/powervm/volume/test_vscsi.py@218 | 14:59 |
| esberglu | Why do I need to set the return value there first? | 14:59 |
| edmondsw | esberglu we could also add autospecing later. I don't want to hold things up for that. Sounds like it's not done as widely in nova as I thought | 14:59 |
| edmondsw | esberglu what's the point of checking the return value against what you got back if you didn't set what you were supposed to get back? | 15:00 |
| *** gman-tx has joined #openstack-powervm | 15:02 | |
| esberglu | I don't see the functional difference between | 15:07 |
| esberglu | a) self.assertEqual(mock_add_map.return_value, add_func(mock_vios)) | 15:07 |
| esberglu | b) mock_add_map.return_value = 'add_map" | 15:07 |
| esberglu | self.assertEqual('add_map', add_func(mock_vios)) | 15:07 |
| esberglu | Either way it's just checking that what is returned from the add_func method is the return value of add_map right? | 15:07 |
| efried | esberglu is right. You don't need to set a return value to compare against it. If you don't set the return value, it returns a mock, which is unique and comparable. | 15:07 |
| edmondsw | esberglu yeah, that's not what I meant | 15:07 |
| edmondsw | let me take another look | 15:08 |
| edmondsw | esberglu ok yeah, I must have misread that. That line is fine | 15:11 |
| esberglu | edmondsw: It is supposed to be wtsk though. But I think that keeping the checks in test_afs that are part of the add_func method is more clear. Thoughts? | 15:13 |
| edmondsw | esberglu keeping them in there means that if that's never called (as they weren't because you had ftsk instead of wtsk), they're skipped and nobody notices | 15:14 |
| edmondsw | I didn't think it would be any less clear to have them outside that... but if you put some other protection in place to make sure the method is called I'll be fine | 15:15 |
| esberglu | edmondsw: Yeah I already added a check that its actually called | 15:16 |
| edmondsw | cool | 15:17 |
| edmondsw | brb, have to reboot | 15:18 |
| *** edmondsw has quit IRC | 15:18 | |
| *** edmondsw has joined #openstack-powervm | 15:24 | |
| *** chas has quit IRC | 15:39 | |
| *** gman-tx has quit IRC | 15:45 | |
| esberglu | efried: edmondsw: Latest vSCSI patch is up | 15:51 |
| esberglu | My turn to reboot | 15:51 |
| edmondsw | esberglu ack | 15:52 |
| *** esberglu has quit IRC | 15:52 | |
| *** csky has joined #openstack-powervm | 15:59 | |
| *** esberglu has joined #openstack-powervm | 16:26 | |
| edmondsw | esberglu few easy comments on vscsi and then I think we're done | 16:28 |
| esberglu | ack | 16:29 |
| *** AlexeyAbashkin has quit IRC | 16:53 | |
| esberglu | edmondsw: New patch is up | 17:10 |
| edmondsw | esberglu ack | 17:16 |
| esberglu | edmondsw: Do we want to port the new test_vscsi tests to the OOT driver? | 17:22 |
| edmondsw | yes | 17:22 |
| *** chhavi__ has quit IRC | 17:26 | |
| edmondsw | esberglu I was wrong about the log asserts... better put them back | 17:32 |
| edmondsw | sorry bout that | 17:32 |
| esberglu | edmondsw: Yeah I had them in there to test the various numbers of vio_modified. Thought that maybe it was bad to assert on logs though? Will switch back | 17:33 |
| edmondsw | yeah, you were right to begin with, and I just misread going over it too fast | 17:33 |
| edmondsw | or misassumed something | 17:33 |
| efried | I'm not a fan of asserting log text, though I've seen it done in nova. Asserting log args is nicer, though still not wonderful. | 17:38 |
| esberglu | efried: I didn't like it either, just didn't see any alternative since that's the only variation in the different cases | 17:42 |
| efried | shrug | 17:42 |
| esberglu | edmondsw: Done | 17:47 |
| -openstackstatus- NOTICE: Due to an unexpected issue with zuulv3.o.o, we were not able to preserve running jobs for a restart. As a result, you'll need to recheck your previous patchsets | 17:47 | |
| esberglu | Cool the vSCSI patch got to the top of the zuul queue from that lol | 17:49 |
| esberglu | efried: edmondsw: I'm looking into a test that is sometimes failing for IT CI. | 18:01 |
| esberglu | http://184.172.12.213/87/521187/18/check/nova-in-tree-pvm/f19b415/powervm_os_ci.html | 18:01 |
| esberglu | http://184.172.12.213/87/521187/18/check/nova-in-tree-pvm/f19b415/logs/n-cpu.txt.gz | 18:01 |
| esberglu | The test in question updates the server name to non-ascii characters | 18:01 |
| esberglu | Then there's an error trying to delete the server because the non-ascii chars can't be decoded. Seems like an issue with the test, except for the fact that it is not hitting OOT | 18:01 |
| efried | We should be sanitizing those away, I would have thought. | 18:01 |
| efried | Perhaps we didn't bring the sanitizing code over properly. | 18:02 |
| esberglu | efried: Looks like the sanitize is done in the update here for OOT | 18:07 |
| esberglu | https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/vm.py#L598-L622 | 18:07 |
| esberglu | But we don't even have that update method IT. So now I'm confused as to how the name is being updated at all | 18:07 |
| esberglu | Here's the test https://github.com/openstack/tempest/blob/master/tempest/api/compute/servers/test_servers.py#L115 | 18:13 |
| *** AlexeyAbashkin has joined #openstack-powervm | 18:20 | |
| *** AlexeyAbashkin has quit IRC | 18:24 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 18:57 | |
| *** AlexeyAbashkin has quit IRC | 19:01 | |
| edmondsw | esberglu anything more to test with vSCSI before we ask cores to review? | 19:19 |
| edmondsw | efried I gave my +1 on vscsi... give it a look when you get a chance | 19:19 |
| edmondsw | we'll want your +1 before asking cores | 19:19 |
| efried | ack (in both senses) | 19:19 |
| esberglu | edmondsw: Nope I'm ready for cores | 19:21 |
| edmondsw | great, that's what I thought | 19:22 |
| edmondsw | efried fyi ^ | 19:22 |
| efried | esberglu edmondsw Is [storage.block] right? | 19:35 |
| efried | I thought that was localdisk | 19:35 |
| edmondsw | efried pretty sure [storage.block] is correct here | 19:42 |
| efried | ight. | 19:42 |
| *** edmondsw_ has joined #openstack-powervm | 19:48 | |
| *** edmonds__ has joined #openstack-powervm | 19:48 | |
| *** edmondsw has quit IRC | 19:52 | |
| *** edmondsw_ has quit IRC | 19:52 | |
| esberglu | edmondsw: efried: I was asked to provide release versions for 1.4.0 FP1. Nothing has changed since last tag in ceilometer and networking. | 19:54 |
| esberglu | nova-powervm only has 1 change | 19:55 |
| esberglu | https://github.com/openstack/nova-powervm/commit/9e553a8 | 19:55 |
| esberglu | I'm gonna cut another release with that and provide those unless there's any objections | 19:55 |
| efried | ight | 19:57 |
| *** apearson__ has quit IRC | 20:03 | |
| *** apearson__ has joined #openstack-powervm | 20:05 | |
| efried | esberglu One-character fix on vSCSI and I'll be +1. | 20:23 |
| esberglu | efried: Done | 20:28 |
| efried | Thanks, +1 | 20:28 |
| *** apearson__ has quit IRC | 20:42 | |
| *** apearson__ has joined #openstack-powervm | 20:59 | |
| edmonds__ | efried good catch... I made the same comment back in PS17 and guess I didn't check that it was fixed | 21:07 |
| edmonds__ | or snuck back in | 21:07 |
| *** edmonds__ is now known as edmondsw | 21:07 | |
| esberglu | edmondsw: Saw you poked the nova guys on vscsi. I updated that etherpad | 21:25 |
| esberglu | Would you mind posting on the ML? I use verse and you'll be able to send it before I figure out how to make it plaintext | 21:26 |
| esberglu | on Notes | 21:26 |
| edmondsw | esberglu tx | 21:26 |
| edmondsw | esberglu sure... it's easy in notes, impossible in verse | 21:27 |
| edmondsw | note sent | 21:34 |
| esberglu | edmondsw: efried: FYI I may or may not take some or all of tomorrow off. Might take advantage of the snowstorm and get some snowboarding in this weekend | 21:46 |
| esberglu | Not expecting reviews to gain traction by tomorrow anyways | 21:46 |
| efried | Ahh, snowboarding. I remember my teens and 20s. | 21:47 |
| efried | haha! Traction joke | 21:47 |
| esberglu | lol | 21:47 |
| edmondsw | have fun! | 21:48 |
| edmondsw | esberglu I loved skiing from the moment I tried it, but hated snowboarding. To each their own :) | 21:50 |
| esberglu | Thanks! And I have yet to try skiing, I guess I just like snowboarding too much | 21:52 |
| edmondsw | do what ya love | 21:52 |
| efried | I skied for years before trying snowboarding. I love 'em both, like you could love driving a sports car and riding a motorcycle. | 21:57 |
| efried | But, as with the analogy, not both at the same time. | 21:57 |
| *** csky has quit IRC | 22:33 | |
| *** esberglu has quit IRC | 22:36 | |
| *** edmondsw has quit IRC | 22:54 | |
| *** edmondsw has joined #openstack-powervm | 22:55 | |
| *** edmondsw has quit IRC | 22:59 | |
| *** csky has joined #openstack-powervm | 23:06 | |
| *** chhavi__ has joined #openstack-powervm | 23:22 | |
| *** chhavi__ has quit IRC | 23:26 | |
| *** apearson__ has quit IRC | 23:29 | |
| *** csky has quit IRC | 23:48 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!