| *** _k0da has joined #openstack-powervm | 00:00 | |
| *** esberglu has quit IRC | 00:24 | |
| *** edmondsw has joined #openstack-powervm | 00:35 | |
| *** _k0da has quit IRC | 00:35 | |
| *** edmondsw has quit IRC | 00:40 | |
| *** openstackstatus has quit IRC | 01:55 | |
| *** toanster has quit IRC | 01:55 | |
| *** toan has joined #openstack-powervm | 01:56 | |
| *** openstackstatus has joined #openstack-powervm | 01:56 | |
| *** ChanServ sets mode: +v openstackstatus | 01:56 | |
| *** edmondsw has joined #openstack-powervm | 02:24 | |
| *** edmondsw has quit IRC | 02:28 | |
| *** csky has joined #openstack-powervm | 02:41 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 02:46 | |
| *** csky has quit IRC | 02:46 | |
| *** AlexeyAbashkin has quit IRC | 02:50 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/networking-powervm master: Updated from global requirements https://review.openstack.org/535024 | 03:07 |
|---|---|---|
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova-powervm master: Updated from global requirements https://review.openstack.org/535033 | 03:12 |
| *** AndyWojo has quit IRC | 03:30 | |
| *** AndyWojo has joined #openstack-powervm | 03:31 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 03:46 | |
| *** AlexeyAbashkin has quit IRC | 03:51 | |
| *** csky has joined #openstack-powervm | 04:28 | |
| *** _k0da has joined #openstack-powervm | 06:18 | |
| *** csky has quit IRC | 07:01 | |
| *** edmondsw has joined #openstack-powervm | 07:06 | |
| *** _k0da has quit IRC | 07:06 | |
| *** edmondsw has quit IRC | 07:11 | |
| *** _k0da has joined #openstack-powervm | 08:03 | |
| *** _k0da has quit IRC | 08:19 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 08:26 | |
| *** edmondsw has joined #openstack-powervm | 08:54 | |
| *** edmondsw has quit IRC | 08:59 | |
| *** csky has joined #openstack-powervm | 09:01 | |
| *** csky has quit IRC | 09:06 | |
| *** _k0da has joined #openstack-powervm | 09:31 | |
| *** edmondsw has joined #openstack-powervm | 10:42 | |
| *** edmondsw has quit IRC | 10:47 | |
| *** csky has joined #openstack-powervm | 12:01 | |
| *** csky has quit IRC | 12:06 | |
| *** edmondsw has joined #openstack-powervm | 12:30 | |
| *** edmondsw has quit IRC | 12:35 | |
| openstackgerrit | Merged openstack/networking-powervm master: Updated from global requirements https://review.openstack.org/535024 | 13:19 |
| *** edmondsw has joined #openstack-powervm | 13:23 | |
| *** apearson has joined #openstack-powervm | 13:57 | |
| *** apearson has quit IRC | 14:00 | |
| *** csky has joined #openstack-powervm | 14:06 | |
| *** svenkat has joined #openstack-powervm | 14:08 | |
| *** csky has quit IRC | 14:09 | |
| svenkat | efried: edmondsw: I want to start a conversation on max_capacity for VNIC back devs for SR-IOV in pypowervm and nova_powervm. | 14:09 |
| edmondsw | svenkat sure, though efried may be pretty busy today (nova feature freeze) | 14:10 |
| *** apearson has joined #openstack-powervm | 14:10 | |
| svenkat | i will propose a change to pypowervm : to add max_capacity parameter to set_vnic_back_devs method in tasks/sriov.py. and in that method will pass it to card.VNICBackDev.bld method along with existing capacity… | 14:10 |
| svenkat | edmondsw : i will propose my changes and we can continue later on… | 14:11 |
| edmondsw | sounds good | 14:11 |
| svenkat | and as VNICBackDev already supports max_capacity, no more pypowervm changes are needed.. and i will also propose a change to nova_powervm - sriov plug method - will pass max_capacity to set_vnic_back_devs method call in it. | 14:12 |
| svenkat | thanks, i will propose these changes and proceed from there. | 14:12 |
| efried | svenkat Yup, sounds like a good plan. | 14:20 |
| efried | svenkat I suspect some interesting stuff will shake out in the implementation. | 14:21 |
| svenkat | efried : yes.. definetely ! i will also propose a change to sriov mechanism driver in networking_powervm as well. (gather max capacity from qos attached to port and pass it onto to vif object to nova-powervm…). more details later… | 14:25 |
| efried | svenkat *that* is where I think the trickiness will come in. | 14:26 |
| *** esberglu has joined #openstack-powervm | 14:26 | |
| svenkat | efreid: yes. | 14:26 |
| *** esberglu has quit IRC | 14:30 | |
| *** esberglu has joined #openstack-powervm | 14:33 | |
| esberglu | edmondsw: efried: Can one of you hit 6238 when you get a chance? Remove ovs from the skip list | 14:33 |
| edmondsw | esberglu ack | 14:33 |
| *** tjakobs has joined #openstack-powervm | 14:33 | |
| efried | Done | 14:34 |
| esberglu | tx | 14:34 |
| esberglu | The patching logic still isn't quite perfect, it doesn't handle the patches if they are merged | 14:34 |
| efried | Because we're only backtracing to master | 14:35 |
| edmondsw | efried is just too quick | 14:35 |
| edmondsw | :) | 14:35 |
| esberglu | I ended up restacking the undercloud yesterday afternoon. Run times are back to normal | 14:37 |
| esberglu | The compute nodes were having trouble communicating with the rabbitmq server on the control | 14:37 |
| esberglu | I thought it was network related, but every once in a while it seems rabbitmq just goes haywire | 14:37 |
| esberglu | And restacking the control is the only way I've found that resets it | 14:38 |
| esberglu | Still not sure what the underlying issue is | 14:38 |
| *** tjakobs has quit IRC | 14:40 | |
| *** tjakobs has joined #openstack-powervm | 14:46 | |
| *** csky has joined #openstack-powervm | 14:49 | |
| *** csky has quit IRC | 14:49 | |
| *** csky has joined #openstack-powervm | 14:50 | |
| edmondsw | esberglu I saw some pok network issues unrelated to CI yesterday, and some others did as well, so I do think we can probably blame the network | 14:57 |
| edmondsw | though maybe it caused rabbitmq to go haywire | 14:57 |
| *** AlexeyAbashkin has quit IRC | 16:13 | |
| esberglu | edmondsw: Network issues seem to be persisting. Pretty much every CI run is failing before stacking today | 16:37 |
| esberglu | Failing to access github | 16:37 |
| edmondsw | :( | 16:37 |
| efried | esberglu What'd you do here? https://review.openstack.org/#/c/524658/3 | 16:57 |
| esberglu | efried: Just pulled the latest patch off the logserver and uploaded | 16:57 |
| esberglu | I'm trying to figure out the best way to carry that forward, a logserver redeploy will wipe it | 16:58 |
| efried | esberglu Oh, yeah, so that ain't right. | 16:58 |
| efried | Gotcha - appreciate the effort. But that stuff was for a different change: https://review.openstack.org/#/c/524744/ | 16:58 |
| efried | ...which I think should match what's on the log server as is. | 16:59 |
| efried | If you could confirm that, and revert the other patch set... | 16:59 |
| efried | I'll get back to these eventually :) | 16:59 |
| esberglu | efried: We're never gonna be able to merge those correct? | 17:00 |
| efried | I think the color themes have a good chance. | 17:01 |
| efried | Just needs polish, and pestering reviewers. | 17:01 |
| efried | I've been frying bigger fish lately tho. | 17:01 |
| esberglu | efried: Reverted, sorry bout that | 17:04 |
| esberglu | Yeah looks like the logserver actually has | 17:06 |
| esberglu | https://review.openstack.org/#/c/524731/ | 17:07 |
| esberglu | and https://review.openstack.org/#/c/524744/ | 17:07 |
| efried | mm | 17:19 |
| *** _k0da has quit IRC | 17:24 | |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: Autospeccing: Tasks https://review.openstack.org/535420 | 17:35 |
| *** esberglu has quit IRC | 17:41 | |
| *** csky_ has joined #openstack-powervm | 17:54 | |
| *** esberglu has joined #openstack-powervm | 17:56 | |
| *** csky has quit IRC | 17:57 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 17:58 | |
| *** AlexeyAbashkin has quit IRC | 18:03 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 18:14 | |
| *** AlexeyAbashkin has quit IRC | 18:19 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 18:22 | |
| *** AlexeyAbashkin has quit IRC | 18:26 | |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: Autospeccing: NVRAM https://review.openstack.org/535442 | 18:27 |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: Remove unsupported nova-networking https://review.openstack.org/535448 | 18:55 |
| openstackgerrit | Merged openstack/nova-powervm master: Remove unsupported nova-networking https://review.openstack.org/535448 | 19:25 |
| edmondsw | esberglu why the change to assertEqual(0, ...call_count) instead of assert_not_called? | 19:39 |
| esberglu | edmondsw: I was getting attribute errors | 19:41 |
| esberglu | AttributeError: 'function' object has no attribute 'assert_not_called' | 19:41 |
| edmondsw | oh, because that's not part of the autospec | 19:42 |
| edmondsw | I thought mock must handle those special, but I guess not | 19:42 |
| edmondsw | esberglu what about https://review.openstack.org/#/c/535420/1/nova_powervm/tests/virt/powervm/tasks/test_vm.py@46 ? | 19:43 |
| esberglu | Another attribute error, the mock stg_ftsk needs a name attribute | 19:44 |
| esberglu | https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/tasks/vm.py#L115 | 19:45 |
| esberglu | Otherwise it fails there | 19:45 |
| *** AlexeyAbashkin has joined #openstack-powervm | 20:45 | |
| *** AlexeyAbashkin has quit IRC | 20:49 | |
| *** _k0da has joined #openstack-powervm | 21:04 | |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: Autospeccing: Tasks https://review.openstack.org/535420 | 21:11 |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: Autospeccing: NVRAM https://review.openstack.org/535442 | 21:11 |
| edmondsw | esberglu I would have +2d PS2 on 535420 if you hadn't -2d... do you want me to remove my +2 on 535442 then? | 21:29 |
| edmondsw | and I should be clear, I'm not saying we have to autospec everything we could possibly autospec. Was just pointing out that we *could* | 21:30 |
| esberglu | edmondsw: I was just thinking it would be easier to do in 1 pass than 2 | 21:30 |
| esberglu | However it is really easy to just roll through the files hitting the @mock.patch, finding everything else not as much | 21:31 |
| edmondsw | yeah, that's why I thought you might want to just do what you've done as a first pass (which may end up being the only pass) | 21:32 |
| edmondsw | and not try to bite it all off at once | 21:32 |
| edmondsw | but I'd be interested in efried's thoughts on this | 21:32 |
| esberglu | edmondsw: Yeah lets just move forward, I'll pull my -2. I don't really want to spend a ton of time on this, would rather knock out the easy ones | 21:33 |
| *** openstackgerrit has quit IRC | 21:33 | |
| edmondsw | ++ | 21:33 |
| edmondsw | as long as efried agrees, I think that's a good plan | 21:33 |
| efried | Far as I'm concerned, any patch that imposes any number of autospec improvements and passes tests can be merged. We don't have to be anal about making sure we cover entire modules at once, or whatever. | 21:33 |
| edmondsw | ++ | 21:34 |
| edmondsw | esberglu +2, just please hold off merging until CI passes | 21:39 |
| esberglu | edmondsw: Yep. CI still being plagued with git pull failures | 21:40 |
| edmondsw | esberglu actually, this is just UT changes, I don't think we care about CI... just zuul | 21:41 |
| *** AlexeyAbashkin has joined #openstack-powervm | 21:45 | |
| *** AlexeyAbashkin has quit IRC | 21:50 | |
| esberglu | edmondsw: Yeah just UT, I'll go ahead and merge | 21:50 |
| *** openstackgerrit has joined #openstack-powervm | 22:08 | |
| openstackgerrit | Merged openstack/nova-powervm master: Autospeccing: Tasks https://review.openstack.org/535420 | 22:08 |
| openstackgerrit | Merged openstack/nova-powervm master: Autospeccing: NVRAM https://review.openstack.org/535442 | 22:11 |
| *** apearson has quit IRC | 22:15 | |
| *** edmondsw has quit IRC | 22:24 | |
| *** csky_ has quit IRC | 22:48 | |
| efried | esberglu For these, I'm good with a fast approve; but it's not good form to +2 your own patch | 22:48 |
| *** csky has joined #openstack-powervm | 22:49 | |
| *** esberglu has quit IRC | 22:49 | |
| *** csky has quit IRC | 22:54 | |
| *** svenkat has quit IRC | 23:00 | |
| *** csky has joined #openstack-powervm | 23:12 | |
| *** csky has quit IRC | 23:17 | |
| *** tjakobs has quit IRC | 23:23 | |
| *** edmondsw has joined #openstack-powervm | 23:23 | |
| *** edmondsw has quit IRC | 23:29 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!