| *** toan has quit IRC | 03:24 | |
| *** toan has joined #openstack-powervm | 03:26 | |
| *** zerick_ has quit IRC | 05:13 | |
| *** zerick has joined #openstack-powervm | 05:15 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 07:51 | |
| *** AlexeyAbashkin has quit IRC | 07:51 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 07:52 | |
| *** edmondsw has joined #openstack-powervm | 08:50 | |
| *** edmondsw has quit IRC | 08:54 | |
| *** AlexeyAbashkin has quit IRC | 11:09 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 11:15 | |
| *** edmondsw has joined #openstack-powervm | 13:22 | |
| *** apearson has joined #openstack-powervm | 13:28 | |
| *** svenkat has joined #openstack-powervm | 14:17 | |
| *** svenkat_ has joined #openstack-powervm | 14:22 | |
| *** svenkat has quit IRC | 14:23 | |
| *** svenkat_ is now known as svenkat | 14:23 | |
| *** esberglu has joined #openstack-powervm | 14:30 | |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: Add missing capabilities https://review.openstack.org/539344 | 14:57 |
|---|---|---|
| *** esberglu_ has joined #openstack-powervm | 15:36 | |
| *** esberglu has quit IRC | 15:40 | |
| *** esberglu_ is now known as esberglu | 15:48 | |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: Update the SEA local.conf https://review.openstack.org/539311 | 16:08 |
| *** efried_hexchat has quit IRC | 16:08 | |
| esberglu | edmondsw: Regarding the etcd version for devstack. The devstack default is currently 3.1.10. The closest version to that for power is 3.2.3 | 16:25 |
| *** cjvolzka has joined #openstack-powervm | 16:25 | |
| esberglu | The latest release is 3.2.15 | 16:25 |
| esberglu | I think we should go latest, but thought I would get your opinion | 16:25 |
| *** cjvolzka has quit IRC | 16:25 | |
| efried | wasn't there some reason we needed to go older? | 16:27 |
| edmondsw | esberglu we needed at least 3.2.0 | 16:27 |
| edmondsw | I mean efried | 16:27 |
| esberglu | efried: I don't think we needed to go older. The problem was that the version devstack defaults to doesn't support power | 16:27 |
| efried | okay. | 16:27 |
| edmondsw | esberglu if 3.2.0 has released, can we just propose devstack move up to that as a min? | 16:28 |
| efried | If we have passing test runs at the latest, go with the latest. | 16:28 |
| efried | edmondsw: Not now. | 16:28 |
| efried | edmondsw: Not until Rocky at this point. | 16:28 |
| edmondsw | efried right, not for queens... but very soon | 16:28 |
| efried | Is there something broken about whatever we're using right now, or is this just because you happened to be touching it in your local.conf change set? | 16:29 |
| edmondsw | efried it was just that I noticed there was something newer when looking at the TODO comment... not really related to this change | 16:29 |
| edmondsw | though it's odd to be using a rc when there's been a release | 16:30 |
| efried | So let's leave the version whatever it is in this change set, wait for Rocky to open up, propose the latest to g-r, and then we can remove that line entirely, right? | 16:31 |
| esberglu | We can move up to 3.2.0 now, or we can just leave it alone until we can get the devstack min bumped | 16:31 |
| esberglu | Yeah | 16:31 |
| edmondsw | fine | 16:32 |
| esberglu | Added it to the pad | 16:33 |
| edmondsw | was just about to do that... tx | 16:34 |
| edmondsw | efried is there a way to have git realize the file was renamed instead of deleted and a new file added? | 16:41 |
| edmondsw | referring to https://review.openstack.org/#/c/539311 | 16:42 |
| edmondsw | it notices the rename on the ovs file, but not for sea | 16:42 |
| efried | edmondsw: It usually does, whether you tell it so or not. In this case it did, but it only "recognized" one of them. | 16:42 |
| efried | edmondsw: In this case because we created a new copy of the same file. | 16:42 |
| efried | There's a 'git mv' but I suspect it's just an alias for mv + git add | 16:43 |
| efried | i.e. I don't think it does anything special metadata-wise to indicate the origin of the file. | 16:43 |
| efried | I think git figures that out on the fly. | 16:43 |
| efried | based on how similar the files were. | 16:44 |
| edmondsw | yeah... esberglu did you create a new file and delete the old one, or rename? | 16:44 |
| edmondsw | would be nice to have it recognize rename for history and diffs | 16:44 |
| esberglu | I renamed both today. I might have created a new file in the first patch yesterday though? No idea | 16:46 |
| efried | edmondsw: If you look at 3..4, you can see they both show up as renamed. | 16:47 |
| efried | edmondsw: But if you look against base, you can see one rename, one add. | 16:48 |
| efried | Which is all as it should be. | 16:48 |
| edmondsw | yep, so that proves you can both rename and change the file contents in the same patch | 16:48 |
| edmondsw | efried i.e. it's not all as it should be | 16:48 |
| edmondsw | should be 2 renames | 16:48 |
| efried | edmondsw: From base? No. | 16:48 |
| edmondsw | why not? | 16:49 |
| efried | From base, we renamed one file and added another. | 16:49 |
| efried | oh, I think I see what you're saying. | 16:49 |
| edmondsw | right... and deleted one. Whereas we should have renamed that one instead of deleting it and adding another | 16:49 |
| efried | Right, so you can't rename a file *and* edit the contents and have it show up as a rename *and* a diff. | 16:49 |
| efried | ...in the same patch set. | 16:50 |
| edmondsw | seems like you can, based on 3..4 diff | 16:50 |
| efried | If you do it across multiple patch sets, that would work. | 16:50 |
| efried | mm, okay. | 16:50 |
| edmondsw | 3..4 shows a rename and changes in the same file | 16:50 |
| efried | yeah. | 16:50 |
| efried | Well, whatever. I'm not gonna lose sleep over it. | 16:50 |
| edmondsw | yeah :) | 16:50 |
| *** efried is now known as efried_rollin | 17:02 | |
| openstackgerrit | Merged openstack/nova-powervm master: Update the SEA local.conf https://review.openstack.org/539311 | 17:22 |
| *** AlexeyAbashkin has quit IRC | 17:23 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 18:17 | |
| *** AlexeyAbashkin has quit IRC | 18:51 | |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: Add missing capabilities https://review.openstack.org/539344 | 20:23 |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: Add missing capabilities https://review.openstack.org/539344 | 20:25 |
| *** efried_rollin is now known as efried | 20:42 | |
| *** svenkat has quit IRC | 22:16 | |
| *** edmondsw has quit IRC | 22:32 | |
| *** edmondsw has joined #openstack-powervm | 22:33 | |
| *** edmondsw has quit IRC | 22:37 | |
| *** esberglu has quit IRC | 23:07 | |
| *** svenkat has joined #openstack-powervm | 23:09 | |
| openstackgerrit | Merged openstack/nova-powervm master: Add missing capabilities https://review.openstack.org/539344 | 23:10 |
| *** apearson has quit IRC | 23:18 | |
| *** svenkat has quit IRC | 23:52 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!