*** edmondsw has joined #openstack-powervm | 02:25 | |
*** edmondsw has quit IRC | 02:51 | |
*** chhagarw has joined #openstack-powervm | 05:03 | |
*** AlexeyAbashkin has joined #openstack-powervm | 06:38 | |
openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: WIP: Having iSCSI Initiator locks per VIOS https://review.openstack.org/557800 | 07:53 |
---|---|---|
*** edmondsw has joined #openstack-powervm | 12:37 | |
*** chhavi__ has joined #openstack-powervm | 12:40 | |
*** chhagarw has quit IRC | 12:42 | |
*** tjakobs has joined #openstack-powervm | 13:43 | |
*** esberglu has joined #openstack-powervm | 13:45 | |
openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: WIP: Having iSCSI Initiator locks per VIOS https://review.openstack.org/557800 | 13:52 |
openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: WIP: Having iSCSI Initiator locks per VIOS https://review.openstack.org/557800 | 14:49 |
edmondsw | esberglu efried I posted some comments in the localdisk commit | 15:32 |
edmondsw | might be easier to just do caching in there than to split it out as a follow-on | 15:32 |
edmondsw | thoughts? | 15:33 |
edmondsw | I don't think doing caching from the get-go adds many LOC | 15:33 |
edmondsw | https://review.openstack.org/#/c/549300/ | 15:34 |
*** openstackgerrit has quit IRC | 15:34 | |
edmondsw | esberglu I also threw a comment in the resize commit that you're not covering localdisk there | 15:36 |
edmondsw | in at least one place | 15:36 |
edmondsw | doesn't seem like y'all are here atm, so I'm gonna get some lunch and we can talk later | 15:38 |
efried | edmondsw: ack | 15:48 |
efried | edmondsw: Not sure what you mean by "adds many LOC". | 15:51 |
efried | imagecache.py and its test suite will add a couple hundred. | 15:53 |
efried | which certainly seems worthwhile leaving out, considering this patch is already 700+ | 15:53 |
*** efried has quit IRC | 15:56 | |
*** efried has joined #openstack-powervm | 16:07 | |
*** AlexeyAbashkin has quit IRC | 16:10 | |
*** esberglu_ has joined #openstack-powervm | 16:22 | |
edmondsw | efried oh I missed that file :( doesn't add many elsewhere, but I see what you mean | 16:23 |
efried | yuh | 16:23 |
esberglu_ | https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/driver.py#L1234-L1240 | 16:24 |
esberglu_ | https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/driver.py#L1126-L1132 | 16:24 |
esberglu_ | ^ Since boot from volume isn't working, resize/mig only covers ssp | 16:24 |
esberglu_ | not localdisk | 16:24 |
esberglu_ | edmondsw: ^ | 16:24 |
edmondsw | so the extend_disk method in localdisk.py is never actually used OOT? | 16:25 |
*** esberglu has quit IRC | 16:25 | |
esberglu_ | edmondsw: Does boot from volume works for other volume types? Just not vSCSI? | 16:26 |
esberglu_ | I don't know the answer to that | 16:26 |
edmondsw | I doubt it | 16:27 |
edmondsw | I would have expected it to work for vscsi and npiv if it worked for anything | 16:27 |
esberglu_ | Could be possible that I have cinder misconfigured I guess | 16:27 |
edmondsw | could be this worked at some point and got broken, or that it was started and not finished | 16:27 |
edmondsw | or that | 16:27 |
edmondsw | at any rate I guess we can do that later if/when we figure out bfv... tx for pointing me to that | 16:28 |
esberglu_ | But until we can confirm that boot from volume works, we shouldn't include localdisk resize | 16:28 |
esberglu_ | And I honestly won't have time to do so | 16:28 |
edmondsw | yep, s'fine | 16:29 |
edmondsw | didn't plan on you figuring out bfv | 16:29 |
edmondsw | esberglu_ are you planning to do a follow-on for image caching, or will that fall to me/efried? | 16:31 |
edmondsw | I thought the plan was to do it in Rocky even if it was a separate commit | 16:31 |
esberglu_ | edmondsw: Yeah Rocky was the plan initially, but I thought I had until July. Would be great if one of you could pick it up | 16:33 |
esberglu_ | I'm starting to get pressured from the AI folks already | 16:33 |
edmondsw | ack | 16:33 |
esberglu_ | edmondsw: I'll throw a todo up for it | 16:33 |
edmondsw | tx | 16:33 |
esberglu_ | edmondsw: efried: Either of you have a system I can test localdisk snapshot on? | 16:37 |
esberglu_ | https://review.openstack.org/#/c/549300/17/nova/virt/powervm/disk/localdisk.py@64 | 16:37 |
esberglu_ | That would just be SDE install right? | 16:37 |
efried | My stack is super old. And I don't think it's SDE. | 16:37 |
esberglu_ | I can reinstall neo40 in SDE probably, was having install issues last I tried though | 16:38 |
edmondsw | esberglu_ got nothing atm | 16:39 |
esberglu_ | ack. I'll try to get 40 working then | 16:39 |
edmondsw | esberglu_ shouldn't have to have SDE for localdisk, should you? | 16:41 |
esberglu_ | Isn't that what the line I linked above implies? | 16:41 |
edmondsw | looking | 16:41 |
edmondsw | oh, right... don't have to have SDE for localdisk, but you do for localdisk snapshot | 16:42 |
esberglu_ | Yeah, localdisk boot has been tested and is working | 16:42 |
esberglu_ | though I need to retest, quite a few changes since I last did that | 16:43 |
esberglu_ | edmondsw: efried: See 6445. Bumps zuul to the latest version | 16:53 |
edmondsw | ack | 16:54 |
*** openstackgerrit has joined #openstack-powervm | 16:59 | |
openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm master: Remove network_attach_strategy option https://review.openstack.org/559131 | 16:59 |
edmondsw | I can modify ^ to deprecate if we think that's necessary, but since the option has had no effect since newton I'm not sure that would mean much | 17:00 |
esberglu_ | I don't think deprecation is needed | 17:01 |
esberglu_ | +2 | 17:01 |
esberglu_ | Hmm interesting results now that I have staging CI deployed with ocata again. Still seeing jenkins drop connections to the nodepool instances | 17:09 |
esberglu_ | Meaning it probably isn't related to the queens upgrade at all | 17:09 |
esberglu_ | And is instead environmental | 17:10 |
esberglu_ | Still need to figure out this issue before I feel comfortable deploying production with queens | 17:11 |
*** AlexeyAbashkin has joined #openstack-powervm | 17:34 | |
*** AlexeyAbashkin has quit IRC | 17:38 | |
edmondsw | network hotplug merged :) | 18:47 |
*** efried1 has joined #openstack-powervm | 18:53 | |
*** efried has quit IRC | 18:54 | |
*** efried1 is now known as efried | 18:54 | |
*** chhavi__ has quit IRC | 19:14 | |
*** tjakobs has quit IRC | 21:25 | |
*** edmondsw has quit IRC | 21:27 | |
*** esberglu_ has quit IRC | 21:57 | |
*** esberglu has joined #openstack-powervm | 21:58 | |
*** esberglu has quit IRC | 22:03 | |
*** mdrabe has quit IRC | 23:24 | |
*** mdrabe has joined #openstack-powervm | 23:29 | |
*** mdrabe has quit IRC | 23:34 | |
*** mdrabe has joined #openstack-powervm | 23:37 | |
*** mdrabe has quit IRC | 23:49 | |
*** mdrabe has joined #openstack-powervm | 23:53 | |
*** mdrabe has quit IRC | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!