| *** tjakobs has quit IRC | 01:08 | |
| *** chhagarw has joined #openstack-powervm | 04:34 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 06:54 | |
| *** AlexeyAbashkin has quit IRC | 06:55 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 06:56 | |
| *** AlexeyAbashkin has quit IRC | 06:57 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 06:57 | |
| *** AlexeyAbashkin has quit IRC | 09:44 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 10:40 | |
| openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: Having iSCSI Initiator locks per VIOS https://review.openstack.org/557800 | 12:01 |
|---|---|---|
| *** edmondsw has joined #openstack-powervm | 12:08 | |
| *** AlexeyAbashkin has quit IRC | 12:25 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 12:25 | |
| *** AlexeyAbashkin has quit IRC | 12:30 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 12:34 | |
| chhagarw | edmondsw: https://review.openstack.org/#/c/557800/ its giving POST UT failure | 12:48 |
| *** apearson has joined #openstack-powervm | 12:48 | |
| chhagarw | for the import error for powervm | 12:48 |
| edmondsw | chhagarw yep, we'll get that fixed this morning and recheck | 12:48 |
| edmondsw | not related to your patch | 12:48 |
| chhagarw | ImportError: cannot import name powervm | 12:49 |
| chhagarw | ok | 12:49 |
| edmondsw | we just merged something in nova and need a corresponding change to merge in nova-powervm | 12:49 |
| chhagarw | sure no problem | 12:49 |
| edmondsw | efried I don't suppose we can merge https://review.openstack.org/#/c/558890/ until esberglu removes his -W, can we? | 12:51 |
| efried | edmondsw: I sorta doubt it, yeah. | 13:03 |
| efried | edmondsw: We could cheat. | 13:03 |
| efried | ... | 13:04 |
| openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Remove proc_units_factor from nova-powervm conf https://review.openstack.org/558890 | 13:04 |
| efried | edmondsw: Done. | 13:04 |
| openstackgerrit | Merged openstack/nova-powervm master: Remove proc_units_factor from nova-powervm conf https://review.openstack.org/558890 | 13:20 |
| *** esberglu has joined #openstack-powervm | 13:35 | |
| edmondsw | efried cool tx | 13:56 |
| edmondsw | chhagarw please see Gerald's comments on https://review.openstack.org/#/c/557800/20 | 13:57 |
| *** tjakobs has joined #openstack-powervm | 14:04 | |
| chhagarw | @edmondsw i answered to gerald caching query, we had a discussion in the scrum | 14:46 |
| chhagarw | for this change he is fine. | 14:46 |
| edmondsw | k | 14:46 |
| edmondsw | and the chap question? | 14:46 |
| chhagarw | chap question, chap is optional property. | 14:47 |
| chhagarw | it depends upon how iSCSI is configured, if user provides auth_method, it uses. | 14:48 |
| edmondsw | chhagarw I understand that... but the point was we should have UT testing both with and without it | 14:48 |
| edmondsw | unless you can show that is done somewhere else so it doesn't have to also be done here | 14:48 |
| chhagarw | code does not specifically checks for CHAP, its been internally used by the REST | 14:50 |
| chhagarw | I will add one | 14:51 |
| edmondsw | tx | 14:52 |
| *** apearson has quit IRC | 15:05 | |
| esberglu | edmondsw: efried: Localdisk snapshot isn't working yet. The find_maps call is returning an empty list here. | 15:07 |
| esberglu | https://review.openstack.org/#/c/549300/19/nova/virt/powervm/disk/driver.py@144 | 15:07 |
| esberglu | I think it must be a problem with the match_func, the scsi mapping definitely exist. I'll keep ya updated on my progress | 15:07 |
| *** apearson has joined #openstack-powervm | 15:08 | |
| efried | ack | 15:09 |
| *** edmondsw has quit IRC | 15:39 | |
| *** apearson has quit IRC | 16:01 | |
| *** apearson has joined #openstack-powervm | 16:04 | |
| *** tjakobs has quit IRC | 16:19 | |
| *** AlexeyAbashkin has quit IRC | 16:22 | |
| esberglu | efried: Ended up being an issue with how the vdisk was being named since we don't have caching yet. Fix incoming | 16:55 |
| esberglu | Snapshot is working for localdisk | 16:55 |
| *** AlexeyAbashkin has joined #openstack-powervm | 17:07 | |
| openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: Having iSCSI Initiator locks per VIOS https://review.openstack.org/557800 | 17:26 |
| *** edmondsw has joined #openstack-powervm | 17:59 | |
| chhagarw | edmondsw: code is ready for review looking for +2 | 18:00 |
| chhagarw | once u approve i need to cherry pick to queens | 18:01 |
| edmondsw | +2 from me, but please get +1 from gfm and +2 from efried before merging | 18:07 |
| chhagarw | nova-powervm-out-of-tree-pvmFAILURE | 18:22 |
| chhagarw | what is this failure | 18:22 |
| chhagarw | edmondsw the CI failure does not look due to my changs, | 18:26 |
| edmondsw | chhagarw doesn't look like an issue with your patch... I just added a powervm:recheck | 18:28 |
| chhagarw | sure | 18:28 |
| chhagarw | thanks | 18:28 |
| chhagarw | https://review.openstack.org/#/c/555003/ | 18:29 |
| chhagarw | this needs to be cherry picked to queen, creating a cherry pick for the same | 18:29 |
| openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm stable/queens: Use vios_uuids to process required vioses for iSCSI https://review.openstack.org/560576 | 18:30 |
| chhagarw | https://review.openstack.org/#/c/560576/ | 18:30 |
| esberglu | edmondsw: You were offline when I posted before. A new patch for localdisk is up. It was a problem with how we were naming the vdisk since we don't have image cache yet | 18:54 |
| esberglu | Snapshot is working | 18:54 |
| edmondsw | esberglu ack | 18:55 |
| edmondsw | esberglu efried remember I'm technically on vacation, so I'll be off and on and may or may not get a chance to review things before next week | 18:56 |
| esberglu | edmondsw: Oh I was thinking that was tomorrow for some reason I'll leave you be then :) | 18:57 |
| esberglu | Have fun | 18:57 |
| edmondsw | tx | 18:57 |
| *** chhagarw has quit IRC | 18:58 | |
| efried | esberglu: I'm still showing a merge conflict on the localdisk patch. | 19:28 |
| efried | esberglu: It'd be because of the conf stuff that merged this morning. | 19:28 |
| efried | You need a rebase. | 19:29 |
| efried | (manual) | 19:29 |
| esberglu | efried: Yeah I haven't rebased that one yet, rebased everything underneath that wasn't manual | 19:29 |
| efried | Have I told you about git restack? | 19:29 |
| efried | You can basically rebase and/or edit a whole series at once. | 19:30 |
| efried | At this point I guess you're just going to rebase it manually onto the DiskAdapter patch. | 19:30 |
| efried | Say, are you going to be using gerrit in your new gig? If not, I guess it doesn't matter for you to know about git restack :) | 19:31 |
| esberglu | efried: Yeah you have, I tried it but just messed up everything and got annoyed lol | 19:31 |
| efried | sigh | 19:31 |
| esberglu | Github enterprise I believe | 19:32 |
| *** edmondsw has quit IRC | 19:47 | |
| esberglu | efried: Merge conflict is fixed on that, ready for your review whenever you have a chance | 20:19 |
| efried | esberglu: Ack. | 20:19 |
| efried | I don't see too much of a hurry since it has a handful of predecessors not merged. | 20:19 |
| efried | But at this point you could put it into the runway queue | 20:20 |
| efried | though I guess they're all separate bps technically now :( | 20:20 |
| efried | oh, I see most of 'em are already there. You could probably sneak the localdisk patch into that list. | 20:22 |
| *** toanster has joined #openstack-powervm | 20:24 | |
| *** toan has quit IRC | 20:28 | |
| esberglu | efried: Easy review 6469. Stops patching proc_units_factor | 20:31 |
| esberglu | efried: Done | 20:32 |
| efried | esberglu: +2 | 20:34 |
| efried | (don't bother to wait for a second) | 20:34 |
| esberglu | tx | 20:35 |
| *** edmondsw has joined #openstack-powervm | 20:54 | |
| *** edmondsw has quit IRC | 20:59 | |
| *** AlexeyAbashkin has quit IRC | 21:10 | |
| *** esberglu has quit IRC | 21:47 | |
| -openstackstatus- NOTICE: zuul was restarted to updated to the latest code; you may need to recheck changes uploaded or approvals added between 21:30 and 21:45 | 22:30 | |
| *** apearson has quit IRC | 22:32 | |
| openstackgerrit | Eric Fried proposed openstack/networking-powervm master: Update requirements https://review.openstack.org/560680 | 22:41 |
| openstackgerrit | Eric Fried proposed openstack/networking-powervm master: uncap eventlet https://review.openstack.org/560519 | 22:41 |
| *** edmondsw has joined #openstack-powervm | 22:43 | |
| *** edmondsw has quit IRC | 22:48 | |
| openstackgerrit | Merged openstack/nova-powervm stable/queens: Use vios_uuids to process required vioses for iSCSI https://review.openstack.org/560576 | 22:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!