| *** edmondsw has joined #openstack-powervm | 00:56 | |
| *** apearson has joined #openstack-powervm | 00:56 | |
| *** edmondsw has quit IRC | 01:33 | |
| *** edmondsw has joined #openstack-powervm | 01:33 | |
| *** apearson has quit IRC | 01:34 | |
| *** edmondsw has quit IRC | 01:38 | |
| *** edmondsw has joined #openstack-powervm | 02:48 | |
| *** edmondsw has quit IRC | 02:52 | |
| *** prashkre has joined #openstack-powervm | 04:13 | |
| *** prashkre has quit IRC | 04:31 | |
| *** prashkre has joined #openstack-powervm | 04:32 | |
| *** edmondsw has joined #openstack-powervm | 04:36 | |
| *** edmondsw has quit IRC | 04:40 | |
| *** openstackgerrit has joined #openstack-powervm | 05:04 | |
| openstackgerrit | prashkre proposed openstack/nova-powervm master: Return iSCSI Initiator for VIOSes https://review.openstack.org/557800 | 05:04 |
|---|---|---|
| openstackgerrit | prashkre proposed openstack/nova-powervm master: Refactor connection data for iSCSI properties https://review.openstack.org/561022 | 05:08 |
| openstackgerrit | prashkre proposed openstack/nova-powervm master: Return iSCSI Initiator for VIOSes https://review.openstack.org/557800 | 06:20 |
| *** prashkre_ has joined #openstack-powervm | 06:24 | |
| *** prashkre has quit IRC | 06:24 | |
| *** edmondsw has joined #openstack-powervm | 06:24 | |
| *** edmondsw has quit IRC | 06:28 | |
| *** prashkre_ has quit IRC | 07:24 | |
| *** prashkre_ has joined #openstack-powervm | 07:24 | |
| *** prashkre_ has quit IRC | 07:36 | |
| *** prashkre_ has joined #openstack-powervm | 07:37 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 07:58 | |
| *** edmondsw has joined #openstack-powervm | 08:13 | |
| *** edmondsw has quit IRC | 08:17 | |
| *** prashkre_ has quit IRC | 09:49 | |
| *** prashkre_ has joined #openstack-powervm | 09:50 | |
| *** prashkre_ has quit IRC | 10:32 | |
| *** edmondsw has joined #openstack-powervm | 12:21 | |
| *** prashkre has joined #openstack-powervm | 12:24 | |
| *** apearson has joined #openstack-powervm | 12:56 | |
| prashkre | efried: Hi Good morning! Could you please review on latest patches at https://review.openstack.org/#/c/561022/, https://review.openstack.org/#/c/557800/ | 13:14 |
| efried | prashkre: Roger that | 13:14 |
| *** tjakobs has joined #openstack-powervm | 13:35 | |
| *** esberglu has joined #openstack-powervm | 13:42 | |
| esberglu | edmondsw: efried: The IT stuff is now one of the runways with target date of 4/30 | 13:45 |
| efried | nod | 13:45 |
| esberglu | Also quick update on multinode CI. I've got it mostly working on the powervm-ci side of things | 13:45 |
| esberglu | But the jenkins connection issues to the nodepool slaves is still hitting the staging environment | 13:46 |
| esberglu | Which is blocking everything on the neo-os-ci side of things | 13:46 |
| esberglu | I can spawn instances and do manual runs on the staging env, so the undercloud seems to be working fine | 13:47 |
| esberglu | So it seems to be a jenkins issue. But I completely reinstalled jenkins and all of the plugins so that they are the exact version from production | 13:48 |
| esberglu | No luck there | 13:48 |
| efried | firewall / switch config ? | 13:48 |
| esberglu | Maybe, I wouldn't even know where to start if that's the issue | 13:51 |
| efried | Sounds like a job for superthorst | 13:53 |
| edmondsw | esberglu did you look at what tests were added when you enable neutron-tempest-plugin? Look useful? | 14:45 |
| esberglu | edmondsw: I think so, it makes our networking testing more robust without increasing overall runtimes much | 14:48 |
| edmondsw | wfm | 14:48 |
| esberglu | Plus it will look good to have those enabled if we want to start publishing CI on neutron | 14:48 |
| edmondsw | yep | 14:49 |
| edmondsw | +2 | 14:49 |
| esberglu | tx | 14:49 |
| *** apearson has quit IRC | 14:59 | |
| *** apearson has joined #openstack-powervm | 15:03 | |
| *** prashkre has quit IRC | 15:24 | |
| *** prashkre has joined #openstack-powervm | 15:25 | |
| *** apearson has quit IRC | 15:57 | |
| *** apearson has joined #openstack-powervm | 16:09 | |
| *** mmedvede has joined #openstack-powervm | 16:25 | |
| edmondsw | prashkre I am -1 on https://review.openstack.org/#/c/561022 until at least the commit message is updated | 17:01 |
| edmondsw | efried are you ok with lumping those 4 changes into a single commit as long as the commit makes that clearer? | 17:02 |
| edmondsw | they're all kinda small misc stuff, so I think I'm ok with it | 17:02 |
| edmondsw | prashkre there was also a UT change that I don't understand, may not be necessary | 17:02 |
| prashkre | edmondsw: thanks for your comments. will take care of them in the next commit. | 17:04 |
| edmondsw | tx | 17:04 |
| efried | edmondsw: three and one, possibly. See response. | 17:07 |
| edmondsw | efried yeah, I'd kinda like that bug one to be separate as well | 17:10 |
| edmondsw | prashkre ^ | 17:10 |
| prashkre | edmondsw: sure. | 17:11 |
| edmondsw | prashkre the UT change that goes along with that bugfix was where you now look for VolumeAttachFailed instead of MultipleExceptionsInFeedTask | 17:12 |
| edmondsw | so make sure you pull that out to the same commit | 17:12 |
| *** AlexeyAbashkin has quit IRC | 17:17 | |
| *** manous has joined #openstack-powervm | 17:33 | |
| *** manous has quit IRC | 18:05 | |
| prashkre | efried: Didn't understand your comment "random mysterious floating orphaned backtick" at https://review.openstack.org/#/c/557800/27/nova_powervm/virt/powervm/volume/iscsi.py | 18:34 |
| efried | prashkre: I saw a backtick floating in the middle of the indent whitespace in that docstring. | 18:35 |
| efried | I thought it might be dust on my screen, but no, it wouldn't wipe off. | 18:35 |
| prashkre | efried: got it. thank you :) | 18:36 |
| *** AlexeyAbashkin has joined #openstack-powervm | 18:44 | |
| *** AlexeyAbashkin has quit IRC | 18:49 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 18:49 | |
| openstackgerrit | prashkre proposed openstack/nova-powervm master: Return iSCSI Initiator for VIOSes https://review.openstack.org/557800 | 18:50 |
| *** AlexeyAbashkin has quit IRC | 18:59 | |
| *** apearson has quit IRC | 19:01 | |
| *** apearson has joined #openstack-powervm | 19:04 | |
| *** openstackgerrit has quit IRC | 19:05 | |
| prashkre | efried: edmondsw: please review https://review.openstack.org/#/c/557800/, I have taken care of all your review comments. | 19:05 |
| prashkre | in lastest patch. | 19:05 |
| prashkre | latest* | 19:05 |
| efried | prashkre: Getting real close. I wouldn't have bothered -1ing if not for Gerald's notes. Quick fixes and I'm +2. | 19:13 |
| prashkre | efried: sorry missed some copyright updates. will take care in the next patch. | 19:14 |
| efried | prashkre: Might as well fix up my nits while you're ati t. | 19:15 |
| efried | at it | 19:15 |
| edmondsw | prashkre efried I wouldn't update the copyright in the files that we only removed things from | 19:23 |
| edmondsw | isn't copyright supposed to indicate we wrote something... not just removed stuff | 19:23 |
| edmondsw | that's why I didn't flag those 2 files before | 19:23 |
| efried | fahhk, I don't know. It won't be the first time we've mis-dated a copyright notice. | 19:25 |
| efried | The community's copyright notices, some of 'em don't even have years anymore. | 19:26 |
| efried | I guess they figure (rightly) that if it comes to question, you can look at the commit history to get all the date info you need, down to the second. | 19:26 |
| edmondsw | yeah :) | 19:26 |
| prashkre | efried edmondsw: I don't see copyright year itself on other projects like keystone, nova. What do you suggest whether to update the year or not on files which Gerald pointed out? | 19:46 |
| efried | Might as well. Doesn't hurt. | 19:46 |
| edmondsw | prashkre that's what we were just discussing... I don't care if you do, but I wouldn't have bothered | 19:46 |
| efried | Even though you're only deleting, you're changing the content, which changes the meaning, which changes the thing. | 19:47 |
| *** openstackgerrit has joined #openstack-powervm | 19:51 | |
| openstackgerrit | prashkre proposed openstack/nova-powervm master: Return iSCSI Initiator for VIOSes https://review.openstack.org/557800 | 19:51 |
| *** edmondsw_ has joined #openstack-powervm | 20:00 | |
| *** edmondsw has quit IRC | 20:03 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 20:41 | |
| *** AlexeyAbashkin has quit IRC | 20:45 | |
| *** edmondsw_ has quit IRC | 20:56 | |
| *** esberglu has quit IRC | 20:58 | |
| *** edmondsw has joined #openstack-powervm | 20:59 | |
| *** edmondsw has quit IRC | 21:03 | |
| *** tjakobs has quit IRC | 21:34 | |
| *** esberglu has joined #openstack-powervm | 21:42 | |
| *** apearson has quit IRC | 22:04 | |
| *** apearson has joined #openstack-powervm | 22:06 | |
| *** tjakobs has joined #openstack-powervm | 22:18 | |
| *** tjakobs has quit IRC | 22:24 | |
| *** apearson has quit IRC | 22:26 | |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: DNM: ci check https://review.openstack.org/328315 | 23:37 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!