| *** edmondsw has quit IRC | 01:51 | |
| *** edmondsw has joined #openstack-powervm | 02:56 | |
| *** edmondsw has quit IRC | 03:01 | |
| *** edmondsw has joined #openstack-powervm | 04:45 | |
| *** edmondsw has quit IRC | 04:50 | |
| *** adreznec has quit IRC | 05:56 | |
| *** adreznec has joined #openstack-powervm | 06:02 | |
| *** edmondsw has joined #openstack-powervm | 06:33 | |
| *** edmondsw has quit IRC | 06:38 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 07:46 | |
| *** edmondsw has joined #openstack-powervm | 10:10 | |
| *** edmondsw has quit IRC | 10:14 | |
| *** prashkre has joined #openstack-powervm | 10:28 | |
| *** chhagarw has joined #openstack-powervm | 11:15 | |
| *** chhagarw has quit IRC | 11:21 | |
| *** edmondsw has joined #openstack-powervm | 11:26 | |
| *** esberglu has joined #openstack-powervm | 13:25 | |
| *** tjakobs has joined #openstack-powervm | 13:59 | |
| *** csky has joined #openstack-powervm | 14:07 | |
| esberglu | efried: edmondsw: 6572 when you have a minute | 14:18 |
|---|---|---|
| openstackgerrit | Taylor Jakobson proposed openstack/nova-powervm master: Add support to extend rbd cinder volumes https://review.openstack.org/569430 | 14:30 |
| esberglu | efried: edmondsw: https://review.openstack.org/#/c/549300/31/nova/virt/powervm/disk/localdisk.py@173 ?? | 14:37 |
| edmondsw | esberglu was that lock only necessary when we had image caching? | 15:09 |
| edmondsw | I really wish we'd just included caching to begin with... | 15:10 |
| esberglu | edmondsw: Yeah looks like it https://github.com/openstack/nova-powervm/commit/976a8df57a04828ae2cecd42d5b6a96478578871 | 15:12 |
| efried | esberglu: Right, if you look at the oot code, it's so we can access the cache. | 15:12 |
| efried | So we don't need it here. | 15:12 |
| *** prashkre has quit IRC | 15:15 | |
| *** efried is now known as fried_rice | 15:17 | |
| *** prashkre has joined #openstack-powervm | 15:18 | |
| edmondsw | esberglu comments on localdisk | 15:41 |
| edmondsw | think you mistunderstood https://review.openstack.org/#/c/549300/31/nova/tests/unit/virt/powervm/disk/test_localdisk.py@268 | 15:42 |
| edmondsw | esberglu are you working on updating https://docs.openstack.org/nova/latest/admin/configuration/hypervisor-powervm.html or should I take a swing at that? | 15:44 |
| *** prashkre has quit IRC | 16:00 | |
| *** AlexeyAbashkin has quit IRC | 16:06 | |
| esberglu | edmondsw: Fixed up localdisk | 16:40 |
| esberglu | edmondsw: I haven't touched it | 16:40 |
| edmondsw | esberglu k I'm working on the docs | 16:40 |
| *** esberglu has quit IRC | 18:46 | |
| edmondsw | fried_rice esberglu before I push this up, tell me if I've done this right... | 18:47 |
| edmondsw | I want to base a commit I'm writing on esberglu's localdisk commit | 18:47 |
| edmondsw | so I pulled that down with `git-review -d 549300` | 18:47 |
| edmondsw | then I checked out the branch where I have my commit | 18:47 |
| edmondsw | and I am about to do `git rebase review/eric_berglund/bp/powervm-localdisk` | 18:48 |
| edmondsw | if I do that, and then git-review, is it going to create a new ps for localdisk, or only for my new commit? | 18:48 |
| *** esberglu has joined #openstack-powervm | 18:49 | |
| edmondsw | ha, I missed that esberglu just dropped before I started... | 18:49 |
| edmondsw | slacked it to him | 18:50 |
| esberglu | edmondsw: Yeah that should be right | 18:51 |
| esberglu | Before submitting for review run | 18:52 |
| esberglu | git review -n | 18:52 |
| esberglu | It will ask you something like "are you sure you want to submit multiple" | 18:52 |
| esberglu | As long as the id next to the localdisk is the current localdisk commit id you're fine | 18:53 |
| esberglu | If it isn't the same, it will submit a new one | 18:53 |
| esberglu | edmondsw: You can also use "git rebase --onto <commit id>" instead of specifying the branch | 18:54 |
| edmondsw | wow, this rebase is messed up | 18:55 |
| edmondsw | having trouble with a file neither of us touched | 18:55 |
| edmondsw | maybe I'll just stash my change and do it on your branch | 18:56 |
| edmondsw | yeah, that worked | 19:06 |
| edmondsw | tx | 19:06 |
| edmondsw | esberglu the bit about checking the commit id was what I didn't know | 19:06 |
| *** csky has quit IRC | 19:10 | |
| *** csky has joined #openstack-powervm | 19:11 | |
| edmondsw | fried_rice esberglu https://review.openstack.org/#/c/569497/ | 19:53 |
| edmondsw | in-tree doc updates ^ | 19:53 |
| fried_rice | ack | 19:53 |
| edmondsw | if you want to see how they render, toggle CI and click build-openstack-sphinx-docs under zuul | 19:54 |
| edmondsw | the only difference from ps1 is a spelling correction | 19:54 |
| esberglu | ack | 19:54 |
| fried_rice | edmondsw: reviewed | 21:25 |
| fried_rice | hate to be the guy to -1 after a mriedem +2 | 21:25 |
| fried_rice | Okay, that's a lie. Love that. | 21:25 |
| fried_rice | sweet, sweet revenge. | 21:25 |
| fried_rice | turnabout is fair play | 21:25 |
| fried_rice | and all that. | 21:25 |
| fried_rice | course the patch owner is the one who suffers | 21:26 |
| edmondsw | :) | 21:36 |
| edmondsw | fried_rice you nitpicky... | 21:46 |
| edmondsw | I don't think I agree with any of those... | 21:46 |
| edmondsw | lol | 21:46 |
| fried_rice | edmondsw: I thought the one about adding the section name was totally legit. | 21:47 |
| edmondsw | it's not done elsewhere | 21:47 |
| edmondsw | it's the Default section | 21:47 |
| edmondsw | I'll see if I can find somewhere else doing it | 21:47 |
| edmondsw | fried_rice I can't find anywhere else doing it, but I kinda think it is a good idea, so sure | 21:53 |
| *** esberglu has quit IRC | 21:53 | |
| edmondsw | and I can use a note for that last comment | 21:53 |
| *** edmondsw has quit IRC | 22:54 | |
| *** tjakobs has quit IRC | 22:54 | |
| *** tjakobs has joined #openstack-powervm | 23:03 | |
| *** tjakobs has quit IRC | 23:29 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!