| *** edmondsw has joined #openstack-powervm | 01:29 | |
| *** edmondsw has quit IRC | 01:34 | |
| *** openstackgerrit has quit IRC | 01:49 | |
| *** shyama has quit IRC | 02:35 | |
| *** edmondsw has joined #openstack-powervm | 03:17 | |
| *** edmondsw has quit IRC | 03:22 | |
| *** edmondsw has joined #openstack-powervm | 05:06 | |
| *** edmondsw has quit IRC | 05:11 | |
| *** edmondsw has joined #openstack-powervm | 06:55 | |
| *** edmondsw has quit IRC | 07:00 | |
| *** edmondsw has joined #openstack-powervm | 08:43 | |
| *** edmondsw has quit IRC | 08:47 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 09:23 | |
| *** AlexeyAbashkin has quit IRC | 09:32 | |
| *** edmondsw has joined #openstack-powervm | 11:14 | |
| edmondsw | efried I got two +2s on https://review.openstack.org/#/c/579292/ but no +W... want to push that? | 11:33 |
|---|---|---|
| edmondsw | mdrabe when you get a chance, please check https://review.openstack.org/#/c/579277/ and https://review.openstack.org/#/c/579294 | 11:34 |
| *** openstackgerrit has joined #openstack-powervm | 11:53 | |
| openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm master: Bump pypowervm min 1.1.16 https://review.openstack.org/579248 | 11:53 |
| openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm master: Add support for rbd user https://review.openstack.org/573837 | 11:53 |
| *** chhagarw has joined #openstack-powervm | 13:07 | |
| *** chhavi__ has joined #openstack-powervm | 13:10 | |
| *** chhagarw has quit IRC | 13:12 | |
| efried | edmondsw: done | 13:33 |
| edmondsw | efried tx | 13:33 |
| chhavi__ | edmondsw: did you got a chance to look athe review: https://review.openstack.org/#/c/576034/ | 13:43 |
| openstackgerrit | Merged openstack/nova-powervm master: Move to stestr https://review.openstack.org/579292 | 13:49 |
| mdrabe | edmondsw: fyi I'm not a networking-powervm core | 14:35 |
| edmondsw | mdrabe oh right, sorry | 14:37 |
| edmondsw | chhavi__ I'm confused as to what you want me to look at... it hasn't changed | 14:39 |
| chhavi__ | edmondsw: the comments which was there to have SaveBDM in post_live_migration is already incorporated | 15:35 |
| chhavi__ | so the patchset is incorporated with the comments already | 15:35 |
| chhavi__ | edmondsw: do you still see any missing comments ? | 16:08 |
| edmondsw | chhavi__ Yes, absolutely. I will try to clarify that for you when I get a chance | 16:10 |
| chhavi__ | sure | 16:10 |
| efried | edmondsw: Did this meeting get rescheduled/canceled? | 16:35 |
| edmondsw | not to my knowledge | 16:35 |
| openstackgerrit | Merged openstack/networking-powervm master: Cleanup tox.ini https://review.openstack.org/579277 | 17:14 |
| openstackgerrit | Merged openstack/networking-powervm master: docs: Modernize build process https://review.openstack.org/579294 | 17:18 |
| *** chhavi__ has quit IRC | 17:34 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 18:57 | |
| *** AlexeyAbashkin has quit IRC | 19:17 | |
| efried | mdrabe: The question is gonna get asked: We don't have lpm support in tree, so why do we need to be mucking with this object in tree? (and why is it here in the first place?) | 21:45 |
| efried | mdrabe: Just be prepared to answer that question. | 21:45 |
| efried | edmondsw: You and/or thorst might have to help us remember how to word that answer, actually. | 21:46 |
| efried | something to do with not needing to install nova-powervm on the conductor? | 21:46 |
| edmondsw | efried from the 198d1668fdee3e331cc8859e7a27ee5c2c030af1 commit message: "This allows consumers using the external nova-powervm driver to install that driver *only* on compute nodes." | 21:51 |
| edmondsw | I do believe I read somewhere that previously nova-powervm had to be installed on the conductor | 21:51 |
| edmondsw | I think it was in our docs somewhere | 21:52 |
| efried | Yeah, I remember now. | 21:52 |
| openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm master: Fix requirements and lower constraints https://review.openstack.org/579701 | 21:56 |
| efried | mdrabe: Is this not something we could just shove into host_mig_data ? | 21:56 |
| edmondsw | @efried ^ that review should address the lower-constraints issue that I've been dealing with on https://review.openstack.org/#/c/579248/ | 21:58 |
| efried | edmondsw: And then you're going to rebase ^ on top of it? | 21:58 |
| edmondsw | if you can help me figure out how to rebase onto that | 21:58 |
| efried | to bump the l-c for pypowervm to .16 | 21:58 |
| efried | oh, yeah, that should be easy. You have both branches downloaded locally? | 21:58 |
| edmondsw | yes, I'm not sure how to do that so need your help there | 21:58 |
| edmondsw | yes | 21:58 |
| efried | git checkout <the branch for 579701> | 21:59 |
| efried | git rebase <the branch for 579248> | 21:59 |
| edmondsw | not the opposite? | 21:59 |
| edmondsw | I want 579248 based on top of 579701 | 21:59 |
| efried | yes, you're right, the opposite. | 22:00 |
| efried | see, you didn't need my "help". | 22:00 |
| edmondsw | I thought I'd tried that before with something else and it didn't work, though | 22:00 |
| edmondsw | I'll try | 22:00 |
| efried | You'll get merge conflicts, and whatnot, but you just need to finagle it until the second patch is a one-char delta on the pypowervm l-c. | 22:03 |
| edmondsw | yeah, that's easy | 22:03 |
| openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm master: Bump pypowervm min 1.1.16 https://review.openstack.org/579248 | 22:03 |
| edmondsw | ok there, that seemed pretty easy | 22:04 |
| edmondsw | not sure what I did differently last time... | 22:04 |
| openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm master: Add support for rbd user https://review.openstack.org/573837 | 22:04 |
| efried | edmondsw: If you ever have trouble with a rebase, let me know. As long as the artifacts are in gerrit, you can't eff up unrecoverably, and I can also try stuff out on my end. | 22:05 |
| edmondsw | efried tx | 22:05 |
| efried | edmondsw: I'm pretty decent at rebases of basic-to-moderate complexity at this point. | 22:05 |
| edmondsw | yeah, I've seen you doing a lot of those | 22:06 |
| edmondsw | 's why I asked | 22:06 |
| efried | And I gave you the wrong answer, blithely, glibly, and immediately. | 22:06 |
| efried | I was really just testing you. You passed. Congratulations. | 22:06 |
| edmondsw | lol | 22:27 |
| edmondsw | efried https://review.openstack.org/#/c/579701 passed zuul | 23:01 |
| efried | woot | 23:02 |
| edmondsw | on that note... Happy 4th and I'll catch you next week | 23:02 |
| efried | edmondsw: Do we still need amqp in l-c? | 23:03 |
| efried | is it in nova's test-requirements or something? | 23:04 |
| edmondsw | I left it because nova has it. I believe l-c is supposed to have more than what you list in requirements/test-req because it includes things those things prereq | 23:04 |
| efried | eek | 23:04 |
| efried | okay. | 23:04 |
| edmondsw | nova has it in l-c, not in req/test-req | 23:04 |
| efried | +2 | 23:04 |
| *** edmondsw has quit IRC | 23:05 | |
| *** edmondsw has joined #openstack-powervm | 23:06 | |
| *** edmondsw has quit IRC | 23:11 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!