*** esberglu has joined #openstack-powervm | 00:48 | |
*** esberglu has quit IRC | 00:54 | |
*** esberglu has joined #openstack-powervm | 00:59 | |
*** esberglu has quit IRC | 01:24 | |
*** chhagarw has joined #openstack-powervm | 03:43 | |
*** chhagarw has quit IRC | 04:05 | |
*** chhagarw has joined #openstack-powervm | 05:00 | |
*** chhagarw has quit IRC | 05:41 | |
*** chhagarw has joined #openstack-powervm | 05:42 | |
*** adreznec has quit IRC | 06:37 | |
*** adreznec has joined #openstack-powervm | 07:00 | |
*** k0da has joined #openstack-powervm | 09:32 | |
*** chhagarw has quit IRC | 11:01 | |
*** chhagarw has joined #openstack-powervm | 11:02 | |
*** edmondsw has joined #openstack-powervm | 11:33 | |
*** k0da has quit IRC | 11:43 | |
*** k0da has joined #openstack-powervm | 11:44 | |
*** esberglu has joined #openstack-powervm | 11:52 | |
*** k0da has quit IRC | 12:00 | |
*** k0da has joined #openstack-powervm | 12:17 | |
*** chhagarw has quit IRC | 12:54 | |
*** efried is now known as fried_rice | 14:11 | |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Make specs build https://review.openstack.org/582398 | 16:01 |
---|---|---|
*** fried_rice is now known as fried_rolls | 16:18 | |
*** k0da has quit IRC | 17:48 | |
*** fried_rolls is now known as fried_rice | 18:15 | |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Make specs build https://review.openstack.org/582398 | 18:19 |
openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm master: cleanup HACKING.rst https://review.openstack.org/582658 | 18:50 |
fried_rice | edmondsw: Perhaps I should reorder that series so we can merge the specs building and then still iterate on the passthrough design. | 18:56 |
edmondsw | fried_rice yeah | 18:57 |
fried_rice | Will do in a sec. Lemme finish bailing Jay out. | 18:57 |
edmondsw | I wonder if moving things under doc/ is going to affect readthedocs... | 18:59 |
edmondsw | fried_rice I learned today that our readthedocs builds are broken since the changes that stephenfin made | 19:00 |
edmondsw | I tried a few things, but didn't get it working... notes in our todo etherpad | 19:00 |
fried_rice | edmondsw: Did our rtt include specs? | 19:00 |
edmondsw | it didn't before... it may now, is what I'm thinking | 19:00 |
fried_rice | oh, you're saying now it will. | 19:00 |
fried_rice | right. | 19:00 |
edmondsw | and maybe that's a good thing? | 19:00 |
fried_rice | is that bad? | 19:00 |
fried_rice | yeah | 19:00 |
edmondsw | we need to restructure those doc so they make more sense | 19:01 |
fried_rice | edmondsw: What we *could* do is create a nova-powervm-specs repo... | 19:01 |
fried_rice | but I think that's way overkill. | 19:01 |
edmondsw | and I suspect that we may have to move off rtt and onto docs.o.o to get the build working unless we revert some of what stephenfin changed | 19:01 |
edmondsw | fried_rice I don't think we've had any specs since i started working on nova-powervm :) | 19:02 |
fried_rice | there aren't any in the queens directory if that's when you started. | 19:02 |
*** k0da has joined #openstack-powervm | 19:03 | |
edmondsw | queens was the first full release for me anyway | 19:03 |
edmondsw | fried_rice thoughts on requiring specs for more things going forward? | 19:04 |
fried_rice | edmondsw: I think we should require specs for things that deserve specs and not for things that don't. Have we been letting things slide by that should have had specs? | 19:07 |
edmondsw | iSCSI? | 19:07 |
fried_rice | I guess some of the rbd and iscsi stuff would probably have been helped by ... yeah | 19:08 |
edmondsw | rbd too | 19:08 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Make specs build https://review.openstack.org/582398 | 19:18 |
fried_rice | edmondsw: How are we going to find out what it looks like on rtt if rtt build is busted? | 19:19 |
fried_rice | edmondsw: And are you expecting it to be different from how it looks http://logs.openstack.org/98/582398/3/check/build-openstack-sphinx-docs/01c42e7/html/ here? | 19:19 |
edmondsw | that's what I was looking for. Should be same on rtt, once we get that fixed | 19:21 |
edmondsw | fried_rice don't love that we have "Contents:" 4 times... | 19:22 |
fried_rice | edmondsw: Yeah, I didn't want to go too deep into editing the content of anything, cause that's a deep hole. | 19:22 |
edmondsw | looks like we're missing some headers that make those make more sense... see http://nova-powervm.readthedocs.io/en/latest/ | 19:22 |
edmondsw | (that's an older build since newer ones are failing) | 19:23 |
edmondsw | so this problem was probably introduced before your change | 19:23 |
fried_rice | yeah | 19:23 |
fried_rice | edmondsw: fixing. | 19:24 |
edmondsw | tx | 19:24 |
fried_rice | Mind if I remove the "Nova-PowerVM" prefix from all those sections? | 19:26 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Make specs build https://review.openstack.org/582398 | 19:28 |
fried_rice | edmondsw: ^ | 19:28 |
edmondsw | fried_rice please do | 19:29 |
fried_rice | done | 19:29 |
fried_rice | oh, lemme reorder the series now. | 19:30 |
edmondsw | fried_rice, wow, literally everyone seems to keep their specs in a separate project: https://specs.openstack.org/openstack/ | 19:32 |
fried_rice | edmondsw: except cyborg | 19:33 |
fried_rice | also, that doesn't look close to "everyone" | 19:34 |
edmondsw | yeah, "literally" was too much | 19:36 |
fried_rice | edmondsw: What stuff about API changes? | 19:37 |
fried_rice | edmondsw: You want me to copy the API changes section from the nova template? | 19:37 |
edmondsw | fried_rice e.g. http://paste.openstack.org/show/725852/ | 19:40 |
edmondsw | that was one of the first differences when I diffed against nova's rocky template | 19:40 |
edmondsw | I didn't look past it yet | 19:40 |
fried_rice | edmondsw: Right. I deliberately left that out because we can't propose anything that changes the nova API. | 19:42 |
edmondsw | fried_rice I would argue that any new extra spec we support falls into the purvue of that paragraph | 19:42 |
fried_rice | nope | 19:42 |
edmondsw | I definitely don't think we need what is in the "REST API impact" section that nova has | 19:44 |
edmondsw | maybe I'm just being over sensitive because I know there's more to an API than what most people think | 19:45 |
edmondsw | e.g. if we renamed an existing extra spec to something else, that is a backward-incompatible API change | 19:46 |
fried_rice | edmondsw: You want to do the APIImpact-in-the-commit-message thing too? | 19:48 |
edmondsw | I think so | 19:49 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Update specs template https://review.openstack.org/579352 | 19:54 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Make specs build https://review.openstack.org/582398 | 19:54 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Spec: Device Passthrough https://review.openstack.org/579359 | 19:54 |
fried_rice | edmondsw: Okay, that restack had some things I've actually never done before, hope I got it right ^ | 19:54 |
openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm master: cleanup HACKING.rst https://review.openstack.org/582658 | 19:54 |
fried_rice | yup, looks legit. | 19:56 |
edmondsw | fried_rice minor comment on https://review.openstack.org/#/c/579352 | 20:02 |
edmondsw | fried_rice fyi, I've been trying to help chhagarw with devstack, and others have asked for help there as well, so I'm trying to update our nova-powervm/devstack directory as I figure things out | 20:04 |
fried_rice | ight | 20:04 |
edmondsw | not ready to push a review yet, but will be coming | 20:04 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Update specs template https://review.openstack.org/579352 | 20:05 |
openstackgerrit | Merged openstack/nova-powervm master: cleanup HACKING.rst https://review.openstack.org/582658 | 20:17 |
openstackgerrit | Merged openstack/nova-powervm master: Update specs template https://review.openstack.org/579352 | 20:28 |
openstackgerrit | Eric Fried proposed openstack/networking-powervm master: Use tox 3.1.1 and basepython fix https://review.openstack.org/582404 | 20:40 |
openstackgerrit | Eric Fried proposed openstack/networking-powervm master: Match neutron's version of hacking https://review.openstack.org/582686 | 20:40 |
fried_rice | wtf, merge conflict? How? | 20:42 |
fried_rice | oh | 20:42 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Make specs build https://review.openstack.org/582398 | 20:46 |
fried_rice | edmondsw: Wanna re+A this guy ^ | 20:46 |
edmondsw | how did that happen? | 20:46 |
fried_rice | I didn't restack when I made that last change, so the file move freaked itself out. | 20:47 |
edmondsw | this a case where rebase -i isn't enough? | 20:48 |
edmondsw | I haven't tried restack yet, still wondering what it's purpose reallyl is | 20:48 |
fried_rice | edmondsw: restack is when you want to make changes to multiple patches and/or the non-top patch in a series. It automatically commits and rebases as appropriate as you go. | 20:50 |
fried_rice | edmondsw: It's essentially rebase -i, but it automates some of the interim bits. | 20:51 |
edmondsw | if you can do it all with rebase -i, I'll probably just stick with that for now | 20:52 |
edmondsw | still trying to get comfortable there | 20:52 |
fried_rice | You can do it with rebase -i as long as you remember to do your commits at the right places (and not at the other places) in the process. If you mess that up, you end up accidentally creating new commits or branching your series or leaving patches behind or whatever. | 20:52 |
fried_rice | In this case, I was a) editing the bottom patch and b) reordering patches, where c) the previously-top-now-middle patch was renaming a bunch of files, including some of those involved in the bottom and previously-middle-now-top patches. | 20:53 |
fried_rice | there's no tool that makes that easy :) | 20:54 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Spec: Device Passthrough https://review.openstack.org/579359 | 20:58 |
-openstackstatus- NOTICE: logs.openstack.org is offline, causing POST_FAILURE results from Zuul. Cause and resolution timeframe currently unknown. | 21:51 | |
*** ChanServ changes topic to "logs.openstack.org is offline, causing POST_FAILURE results from Zuul. Cause and resolution timeframe currently unknown." | 21:51 | |
edmondsw | fried_rice I'd help look at the pep8 issues on https://review.openstack.org/#/c/582686 but the logs don't seem to be accessible | 22:25 |
fried_rice | edmondsw: yeah, everything is down, see above. | 22:26 |
edmondsw | I did leave a couple comments | 22:26 |
edmondsw | oh, there you go | 22:26 |
edmondsw | any idea why neutron bumped flake8 min to 2.6.2? | 22:26 |
edmondsw | well, I think I'm outta here for the day... have a good weekend | 22:30 |
*** edmondsw has quit IRC | 22:31 | |
*** fried_rice is now known as efried | 22:36 | |
*** k0da has quit IRC | 23:22 | |
*** edmondsw has joined #openstack-powervm | 23:26 | |
*** edmondsw has quit IRC | 23:31 | |
*** ChanServ changes topic to "This channel is for PowerVM-related development and discussion. For general OpenStack support, please use #openstack." | 23:35 | |
-openstackstatus- NOTICE: logs.openstack.org is back on-line. Changes with "POST_FAILURE" job results should be rechecked. | 23:35 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!