Friday, 2018-07-13

*** esberglu has joined #openstack-powervm00:48
*** esberglu has quit IRC00:54
*** esberglu has joined #openstack-powervm00:59
*** esberglu has quit IRC01:24
*** chhagarw has joined #openstack-powervm03:43
*** chhagarw has quit IRC04:05
*** chhagarw has joined #openstack-powervm05:00
*** chhagarw has quit IRC05:41
*** chhagarw has joined #openstack-powervm05:42
*** adreznec has quit IRC06:37
*** adreznec has joined #openstack-powervm07:00
*** k0da has joined #openstack-powervm09:32
*** chhagarw has quit IRC11:01
*** chhagarw has joined #openstack-powervm11:02
*** edmondsw has joined #openstack-powervm11:33
*** k0da has quit IRC11:43
*** k0da has joined #openstack-powervm11:44
*** esberglu has joined #openstack-powervm11:52
*** k0da has quit IRC12:00
*** k0da has joined #openstack-powervm12:17
*** chhagarw has quit IRC12:54
*** efried is now known as fried_rice14:11
openstackgerritEric Fried proposed openstack/nova-powervm master: Make specs build  https://review.openstack.org/58239816:01
*** fried_rice is now known as fried_rolls16:18
*** k0da has quit IRC17:48
*** fried_rolls is now known as fried_rice18:15
openstackgerritEric Fried proposed openstack/nova-powervm master: Make specs build  https://review.openstack.org/58239818:19
openstackgerritMatthew Edmonds proposed openstack/nova-powervm master: cleanup HACKING.rst  https://review.openstack.org/58265818:50
fried_riceedmondsw: Perhaps I should reorder that series so we can merge the specs building and then still iterate on the passthrough design.18:56
edmondswfried_rice yeah18:57
fried_riceWill do in a sec. Lemme finish bailing Jay out.18:57
edmondswI wonder if moving things under doc/ is going to affect readthedocs...18:59
edmondswfried_rice I learned today that our readthedocs builds are broken since the changes that stephenfin made19:00
edmondswI tried a few things, but didn't get it working... notes in our todo etherpad19:00
fried_riceedmondsw: Did our rtt include specs?19:00
edmondswit didn't before... it may now, is what I'm thinking19:00
fried_riceoh, you're saying now it will.19:00
fried_riceright.19:00
edmondswand maybe that's a good thing?19:00
fried_riceis that bad?19:00
fried_riceyeah19:00
edmondswwe need to restructure those doc so they make more sense19:01
fried_riceedmondsw: What we *could* do is create a nova-powervm-specs repo...19:01
fried_ricebut I think that's way overkill.19:01
edmondswand I suspect that we may have to move off rtt and onto docs.o.o to get the build working unless we revert some of what stephenfin changed19:01
edmondswfried_rice I don't think we've had any specs since i started working on nova-powervm :)19:02
fried_ricethere aren't any in the queens directory if that's when you started.19:02
*** k0da has joined #openstack-powervm19:03
edmondswqueens was the first full release for me anyway19:03
edmondswfried_rice thoughts on requiring specs for more things going forward?19:04
fried_riceedmondsw: I think we should require specs for things that deserve specs and not for things that don't.  Have we been letting things slide by that should have had specs?19:07
edmondswiSCSI?19:07
fried_riceI guess some of the rbd and iscsi stuff would probably have been helped by ... yeah19:08
edmondswrbd too19:08
openstackgerritEric Fried proposed openstack/nova-powervm master: Make specs build  https://review.openstack.org/58239819:18
fried_riceedmondsw: How are we going to find out what it looks like on rtt if rtt build is busted?19:19
fried_riceedmondsw: And are you expecting it to be different from how it looks http://logs.openstack.org/98/582398/3/check/build-openstack-sphinx-docs/01c42e7/html/ here?19:19
edmondswthat's what I was looking for. Should be same on rtt, once we get that fixed19:21
edmondswfried_rice don't love that we have "Contents:" 4 times...19:22
fried_riceedmondsw: Yeah, I didn't want to go too deep into editing the content of anything, cause that's a deep hole.19:22
edmondswlooks like we're missing some headers that make those make more sense... see http://nova-powervm.readthedocs.io/en/latest/19:22
edmondsw(that's an older build since newer ones are failing)19:23
edmondswso this problem was probably introduced before your change19:23
fried_riceyeah19:23
fried_riceedmondsw: fixing.19:24
edmondswtx19:24
fried_riceMind if I remove the "Nova-PowerVM" prefix from all those sections?19:26
openstackgerritEric Fried proposed openstack/nova-powervm master: Make specs build  https://review.openstack.org/58239819:28
fried_riceedmondsw: ^19:28
edmondswfried_rice please do19:29
fried_ricedone19:29
fried_riceoh, lemme reorder the series now.19:30
edmondswfried_rice, wow, literally everyone seems to keep their specs in a separate project: https://specs.openstack.org/openstack/19:32
fried_riceedmondsw: except cyborg19:33
fried_ricealso, that doesn't look close to "everyone"19:34
edmondswyeah, "literally" was too much19:36
fried_riceedmondsw: What stuff about API changes?19:37
fried_riceedmondsw: You want me to copy the API changes section from the nova template?19:37
edmondswfried_rice e.g. http://paste.openstack.org/show/725852/19:40
edmondswthat was one of the first differences when I diffed against nova's rocky template19:40
edmondswI didn't look past it yet19:40
fried_riceedmondsw: Right.  I deliberately left that out because we can't propose anything that changes the nova API.19:42
edmondswfried_rice I would argue that any new extra spec we support falls into the purvue of that paragraph19:42
fried_ricenope19:42
edmondswI definitely don't think we need what is in the "REST API impact" section that nova has19:44
edmondswmaybe I'm just being over sensitive because I know there's more to an API than what most people think19:45
edmondswe.g. if we renamed an existing extra spec to something else, that is a backward-incompatible API change19:46
fried_riceedmondsw: You want to do the APIImpact-in-the-commit-message thing too?19:48
edmondswI think so19:49
openstackgerritEric Fried proposed openstack/nova-powervm master: Update specs template  https://review.openstack.org/57935219:54
openstackgerritEric Fried proposed openstack/nova-powervm master: Make specs build  https://review.openstack.org/58239819:54
openstackgerritEric Fried proposed openstack/nova-powervm master: Spec: Device Passthrough  https://review.openstack.org/57935919:54
fried_riceedmondsw: Okay, that restack had some things I've actually never done before, hope I got it right ^19:54
openstackgerritMatthew Edmonds proposed openstack/nova-powervm master: cleanup HACKING.rst  https://review.openstack.org/58265819:54
fried_riceyup, looks legit.19:56
edmondswfried_rice minor comment on https://review.openstack.org/#/c/57935220:02
edmondswfried_rice fyi, I've been trying to help chhagarw with devstack, and others have asked for help there as well, so I'm trying to update our nova-powervm/devstack directory as I figure things out20:04
fried_riceight20:04
edmondswnot ready to push a review yet, but will be coming20:04
openstackgerritEric Fried proposed openstack/nova-powervm master: Update specs template  https://review.openstack.org/57935220:05
openstackgerritMerged openstack/nova-powervm master: cleanup HACKING.rst  https://review.openstack.org/58265820:17
openstackgerritMerged openstack/nova-powervm master: Update specs template  https://review.openstack.org/57935220:28
openstackgerritEric Fried proposed openstack/networking-powervm master: Use tox 3.1.1 and basepython fix  https://review.openstack.org/58240420:40
openstackgerritEric Fried proposed openstack/networking-powervm master: Match neutron's version of hacking  https://review.openstack.org/58268620:40
fried_ricewtf, merge conflict? How?20:42
fried_riceoh20:42
openstackgerritEric Fried proposed openstack/nova-powervm master: Make specs build  https://review.openstack.org/58239820:46
fried_riceedmondsw: Wanna re+A this guy ^20:46
edmondswhow did that happen?20:46
fried_riceI didn't restack when I made that last change, so the file move freaked itself out.20:47
edmondswthis a case where rebase -i isn't enough?20:48
edmondswI haven't tried restack yet, still wondering what it's purpose reallyl is20:48
fried_riceedmondsw: restack is when you want to make changes to multiple patches and/or the non-top patch in a series. It automatically commits and rebases as appropriate as you go.20:50
fried_riceedmondsw: It's essentially rebase -i, but it automates some of the interim bits.20:51
edmondswif you can do it all with rebase -i, I'll probably just stick with that for now20:52
edmondswstill trying to get comfortable there20:52
fried_riceYou can do it with rebase -i as long as you remember to do your commits at the right places (and not at the other places) in the process.  If you mess that up, you end up accidentally creating new commits or branching your series or leaving patches behind or whatever.20:52
fried_riceIn this case, I was a) editing the bottom patch and b) reordering patches, where c) the previously-top-now-middle patch was renaming a bunch of files, including some of those involved in the bottom and previously-middle-now-top patches.20:53
fried_ricethere's no tool that makes that easy :)20:54
openstackgerritEric Fried proposed openstack/nova-powervm master: Spec: Device Passthrough  https://review.openstack.org/57935920:58
-openstackstatus- NOTICE: logs.openstack.org is offline, causing POST_FAILURE results from Zuul. Cause and resolution timeframe currently unknown.21:51
*** ChanServ changes topic to "logs.openstack.org is offline, causing POST_FAILURE results from Zuul. Cause and resolution timeframe currently unknown."21:51
edmondswfried_rice I'd help look at the pep8 issues on https://review.openstack.org/#/c/582686 but the logs don't seem to be accessible22:25
fried_riceedmondsw: yeah, everything is down, see above.22:26
edmondswI did leave a couple comments22:26
edmondswoh, there you go22:26
edmondswany idea why neutron bumped flake8 min to 2.6.2?22:26
edmondswwell, I think I'm outta here for the day... have a good weekend22:30
*** edmondsw has quit IRC22:31
*** fried_rice is now known as efried22:36
*** k0da has quit IRC23:22
*** edmondsw has joined #openstack-powervm23:26
*** edmondsw has quit IRC23:31
*** ChanServ changes topic to "This channel is for PowerVM-related development and discussion. For general OpenStack support, please use #openstack."23:35
-openstackstatus- NOTICE: logs.openstack.org is back on-line. Changes with "POST_FAILURE" job results should be rechecked.23:35

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!