*** tonyb has quit IRC | 06:50 | |
*** mujahidali has joined #openstack-powervm | 13:49 | |
edmondsw | #startmeeting PowerVM Driver Meeting | 14:01 |
---|---|---|
openstack | Meeting started Tue Oct 30 14:01:03 2018 UTC and is due to finish in 60 minutes. The chair is edmondsw. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:01 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:01 |
*** openstack changes topic to " (Meeting topic: PowerVM Driver Meeting)" | 14:01 | |
openstack | The meeting name has been set to 'powervm_driver_meeting' | 14:01 |
efried | o/ | 14:01 |
edmondsw | #link agenda: https://etherpad.openstack.org/p/powervm_driver_meeting_agenda | 14:01 |
edmondsw | #topic In-Tree Driver | 14:01 |
*** openstack changes topic to "In-Tree Driver (Meeting topic: PowerVM Driver Meeting)" | 14:01 | |
edmondsw | I'm waiting for a 2nd +2/+A on https://review.openstack.org/#/c/610174/ | 14:01 |
edmondsw | I think that's the only thing we've currently got going in-tree | 14:02 |
efried | https://review.openstack.org/#/c/468560/ | 14:02 |
efried | It was +A but then got bumped for the uuidsentinel change. | 14:02 |
efried | I might try to convince Jay to fast-approve it since the rebase was trivial. | 14:02 |
efried | But this patch deserves a bit of a closer look since... | 14:03 |
efried | https://review.openstack.org/#/c/613126/ | 14:03 |
efried | ...where it is now officially the responsibility of the virt driver to set allocation ratios and reserved values. | 14:03 |
efried | Because https://review.openstack.org/#/c/613991/ is ripping out the bits where the resource tracker sets those outside of the virt driver, for the update_provider_tree path. | 14:03 |
edmondsw | i.e. we have to merge 468560 before those others can merge? | 14:04 |
efried | nope. Turns out I "predicted" the future here, and the powervm patch is already copacetic. | 14:04 |
efried | Once that second one merges, we'll get to do an optional optimization to call the base ComputeDriver method to calculate the disk reserve | 14:05 |
efried | this: https://review.openstack.org/#/c/613126/4/nova/virt/driver.py@860 | 14:05 |
efried | right now that's inlined: https://review.openstack.org/#/c/468560/4/nova/virt/powervm/driver.py@203 | 14:06 |
efried | In other in-tree news, don't forget to vote for the T release name. | 14:06 |
edmondsw | not sure I'm following, but I'll take a look after the meeting and it'll probably all come together | 14:06 |
edmondsw | I don't think I got an email about the T name vote yet... | 14:06 |
efried | http://lists.openstack.org/pipermail/openstack-dev/2018-October/136127.html | 14:07 |
efried | it's a public poll. So you can vote once per IP address. (but obviously just vote once) | 14:07 |
edmondsw | ah, that explains it | 14:07 |
efried | Are you on the Train train? | 14:07 |
edmondsw | yeah... though I also liked Thomas (the tank engine) | 14:08 |
edmondsw | and would have been cool to have suggested the name that got picked | 14:08 |
efried | Oh, was that your suggestion? | 14:08 |
edmondsw | yeah | 14:08 |
edmondsw | but I'll vote for Train | 14:08 |
efried | Thomas is on there | 14:08 |
efried | and it's ordered, and you can have ties | 14:08 |
edmondsw | yep | 14:09 |
edmondsw | #topic Out-of-Tree Driver | 14:10 |
*** openstack changes topic to "Out-of-Tree Driver (Meeting topic: PowerVM Driver Meeting)" | 14:10 | |
edmondsw | similar to IT, we have https://review.openstack.org/#/c/613342/ needing a 2nd +2/+A | 14:10 |
edmondsw | mdrabe ^ | 14:10 |
edmondsw | mdrabe I assume that's an easy test with PowerVC (for the bug you requested earlier) and then you can +2 | 14:11 |
edmondsw | (looking at the code as well, of course) | 14:12 |
mdrabe | thnx will look | 14:12 |
mdrabe | edmondsw: Did we wanna backport that? | 14:12 |
edmondsw | tx | 14:12 |
edmondsw | I don't think I'll push backporting... I view it more as hardening than as a vulnerability | 14:12 |
efried | (Update: Success convincing Jay to fast-approve https://review.openstack.org/#/c/468560/) | 14:13 |
mdrabe | Sounds good | 14:13 |
edmondsw | #topic Device Passthrough | 14:13 |
*** openstack changes topic to "Device Passthrough (Meeting topic: PowerVM Driver Meeting)" | 14:13 | |
efried | Oh, there was one more OOT thing... | 14:13 |
edmondsw | #topic OOT part 2 | 14:14 |
*** openstack changes topic to "OOT part 2 (Meeting topic: PowerVM Driver Meeting)" | 14:14 | |
efried | (edmondsw: there's also #undo) | 14:14 |
edmondsw | ah, nice | 14:14 |
efried | Got an email to our pypowervm github account, assume y'all got it too. | 14:14 |
efried | About requests <=2.19 having a security vulnerability. | 14:15 |
edmondsw | yeah, I got that | 14:15 |
efried | I checked the nova project, since we usually try to align with that. | 14:15 |
edmondsw | we should not be affected because pypowervm is only used with localhost | 14:15 |
edmondsw | removing the MITM concern | 14:15 |
efried | And it's at 2.14.2 | 14:15 |
efried | okay, I didn't look into the vulnerability itself. | 14:16 |
efried | Just whether it was feasible for us to bump. | 14:16 |
efried | We're behind openstack anyway there. | 14:16 |
edmondsw | glad you brought it up | 14:16 |
efried | requirements project has upper constraint at 2.20 | 14:16 |
efried | .0 | 14:16 |
edmondsw | I don't know that we need to keep up with other OpenStack projects... kind of the point of having l-c in each project now instead of global like it used to be | 14:17 |
edmondsw | u-c will always be the latest available that we haven't found an issue with | 14:17 |
edmondsw | but l-c should be the oldest available that we don't have an issue with | 14:17 |
efried | yeah, sure | 14:17 |
efried | well, we don't have l-c in pypowervm | 14:17 |
efried | and we at least need to make sure we don't have conflicts. | 14:18 |
edmondsw | l-c for pypowervm is essential the lower bound listed in requirements.txt | 14:18 |
efried | but in this case it would let us clean up that req a bit. Right now it's a three-parter. | 14:18 |
edmondsw | efried so what exactly are you suggesting? | 14:19 |
efried | What I don't see is any patches bumping l-c in nova at large. Wonder if it just hasn't percolated down there yet. | 14:19 |
efried | sorry, s/nova/openstack/ | 14:19 |
edmondsw | efried I'm guessing that it's still percolating | 14:19 |
efried | I'm not really suggesting anything yet. I kinda want to find out if anyone in openstack is concerned. | 14:19 |
efried | if so, we should bump our req to 2.20.0 just to align. | 14:20 |
efried | if not... I guess if you think the vulnerability is n/a for us, we could leave it. | 14:20 |
edmondsw | there I disagree... we don't need to align, any more than openstack projects need to align with each other | 14:20 |
edmondsw | this is why they moved l-c into individual projects, so that they don't have to align | 14:20 |
efried | Sorry, I didn't mean align for the sake of alignment. | 14:21 |
edmondsw | you meant specifically for this bug? | 14:21 |
efried | But if there's a known vulnerability and it's concerning enough that openstack bumps minimum to 2.20.0, then it's probably a good idea if we do too, even if it's not strictly necessary (at the moment). | 14:21 |
efried | But don't we have people consuming pypowervm in a remote fashion? | 14:21 |
edmondsw | I didn't think it supported that, without hacking | 14:22 |
edmondsw | maybe I need to take a closer look at what local2remote does | 14:22 |
edmondsw | I thought vanilla pypowervm could only be used locally | 14:22 |
efried | possibly | 14:23 |
efried | even so | 14:23 |
efried | from the other side, any harm in bumping the minimum? | 14:23 |
edmondsw | ok, the more I think of it, and just confirmed... local2remote isn't changing pypowervm code to make remote possible | 14:24 |
edmondsw | pypowervm does support remote | 14:24 |
edmondsw | so... yeah... we might want to bump | 14:24 |
edmondsw | we could leave it the way it is, and say that you're welcome to update requests but we just won't make you do it | 14:24 |
edmondsw | but probably better to bump | 14:25 |
edmondsw | let me make sure there is a python-requests 2.20.0 on both RHEL and Ubuntu 16.04 and 18.04 first | 14:26 |
edmondsw | #topic Device Passthrough | 14:27 |
*** openstack changes topic to "Device Passthrough (Meeting topic: PowerVM Driver Meeting)" | 14:27 | |
edmondsw | efried ^ | 14:27 |
efried | okay, the new file format spec got a couple reviews since last week. I was kinda waiting for more, but at this point I guess I'll incorporate those changes and push another rev soon. | 14:28 |
efried | https://review.openstack.org/#/c/612497/ | 14:29 |
efried | otherwise, no progress. | 14:29 |
efried | also will need to respin the actual dev passthrough spec to account for having factored out --^ | 14:30 |
efried | but haven't started that yet either. | 14:30 |
efried | EOM unless questions | 14:30 |
edmondsw | no questions. Haven't gotten to the spec yet | 14:30 |
edmondsw | #topic PowerVM CI | 14:31 |
*** openstack changes topic to "PowerVM CI (Meeting topic: PowerVM Driver Meeting)" | 14:31 | |
edmondsw | mujahidali ^ | 14:31 |
mujahidali | After redeploying the neos CI looks quite good that earlier but there is some problem in accesing the http://ci-watch.tintri.com/ | 14:32 |
mujahidali | *than | 14:32 |
edmondsw | as long as the CI is working :) | 14:34 |
edmondsw | any update on other things? | 14:35 |
mujahidali | We are able to stack IT for py-3devstack(tempest was failing) | 14:35 |
edmondsw | you figured out the issues? I haven't seen any commit proposals for fixes | 14:35 |
mujahidali | the issue was in OOT | 14:36 |
edmondsw | I thought you were also looking at a pypowervm issue | 14:36 |
mujahidali | and I didn't get chance to test pypowervm changes. | 14:36 |
edmondsw | mujahidali are you going to propose a commit for an OOT fix? | 14:37 |
mujahidali | yes | 14:37 |
mujahidali | I need to test it first. | 14:37 |
edmondsw | +1 | 14:37 |
mujahidali | and I will be pulled for some time as a backup for Bharath until he is back(for PVC-build). | 14:38 |
edmondsw | yep, understood | 14:39 |
edmondsw | anything else? | 14:39 |
mujahidali | that's it. | 14:39 |
edmondsw | #topic Open Discussion | 14:40 |
*** openstack changes topic to "Open Discussion (Meeting topic: PowerVM Driver Meeting)" | 14:40 | |
edmondsw | I'm only seeing python-requests 2.9.1 on Ubuntu 16.04.... :( | 14:41 |
efried | that wouldn't even satisfy our minimum, would it? | 14:41 |
efried | no | 14:41 |
edmondsw | true | 14:41 |
edmondsw | I'll keep looking into that | 14:42 |
mujahidali | any idea why it's http://ci-watch.tintri.com/ not working ? | 14:43 |
edmondsw | mujahidali no clue | 14:43 |
mujahidali | okay | 14:43 |
edmondsw | efried looks like Ubuntu didn't bump 2.9.1 to 2.20.0... they just patched 2.9.1 with the fix for this issue | 14:44 |
edmondsw | https://usn.ubuntu.com/3790-1/ | 14:44 |
edmondsw | come to think of it, that kind of thing is common, and explains why you're not seeing other projects bumping versions | 14:44 |
efried | mm, interesting. | 14:44 |
efried | I'll see if anyone in -infra knows about ci-watch | 14:45 |
mujahidali | thanks | 14:45 |
edmondsw | alright, thanks everyone | 14:47 |
edmondsw | #endmeeting | 14:47 |
*** openstack changes topic to "This channel is for PowerVM-related development and discussion. For general OpenStack support, please use #openstack." | 14:47 | |
openstack | Meeting ended Tue Oct 30 14:47:06 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:47 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/powervm_driver_meeting/2018/powervm_driver_meeting.2018-10-30-14.01.html | 14:47 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/powervm_driver_meeting/2018/powervm_driver_meeting.2018-10-30-14.01.txt | 14:47 |
openstack | Log: http://eavesdrop.openstack.org/meetings/powervm_driver_meeting/2018/powervm_driver_meeting.2018-10-30-14.01.log.html | 14:47 |
*** mujahidali has quit IRC | 14:54 | |
edmondsw | efried I looked over the stuff you brought up above when we were talking about IT... all LGTM | 15:28 |
efried | roger that | 15:54 |
efried | edmondsw: Mr. The Tuba Guy approved the tempfile patch. | 16:10 |
edmondsw | great, tx | 16:10 |
efried | edmondsw: and mdrabe +2'd the oot one. Do we +W our own around here, or should we ask him to do it? | 16:11 |
edmondsw | I'm fine doing it myself, but it does look nicer if you do it :) | 16:12 |
*** chhagarw has joined #openstack-powervm | 16:39 | |
efried | edmondsw: Done. | 16:51 |
efried | And in other news, mmedvede sent an email to the maintainers of tintri asking if they're continuing to support it. | 16:51 |
efried | I know the nova team uses it, so there should be more motivation than just us. | 16:51 |
*** chhagarw has quit IRC | 17:29 | |
efried | edmondsw: The oot patch is broke. References to those consts. You got a fup patch coming quick? | 21:29 |
efried | edmondsw: We might could be a little clever about this. We can make the CreateAndConnectCfgDrive job output the cfg drive name, then pull it in from the PowerOn job. Instead of duplicating the name gen logic, just pass the conf option to the job (or reference the conf option directly from within the job, but that's kind of dirty). | 21:33 |
efried | The tricky part is figuring out how to make that input optional, so we can ignore if CreateAndConnectCfgDrive didn't run. My taskflow is a bit rusty, not sure offhand how to do that. | 21:34 |
efried | but for now you could just put the consts back. | 21:35 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Use tempfile for powervm config drive https://review.openstack.org/613342 | 21:36 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Use tempfile for powervm config drive https://review.openstack.org/613342 | 21:37 |
efried | edmondsw, mdrabe: Rebased to yank it out of the gate ^ | 21:38 |
efried | Fortunately the IT patch didn't have that problem. (I guess we must have a TODO to port that delete-cfg-drive functionality in-tree?) | 21:40 |
mdrabe | Yea probably | 21:45 |
*** tonyb has joined #openstack-powervm | 23:03 | |
*** chhagarw has joined #openstack-powervm | 23:25 | |
*** chhagarw has quit IRC | 23:30 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!