openstackgerrit | Nachi Ueno proposed a change to openstack-dev/devstack: Support neturon multi-host https://review.openstack.org/43212 | 00:03 |
---|---|---|
*** weshay has quit IRC | 00:05 | |
*** hemna is now known as hemnafk | 00:06 | |
*** jhenner has quit IRC | 00:17 | |
*** dtroyer has quit IRC | 00:37 | |
*** dtroyer has joined #openstack-qa | 00:37 | |
*** ivanzhu has joined #openstack-qa | 01:32 | |
*** mriedem has joined #openstack-qa | 01:40 | |
*** sthaha has joined #openstack-qa | 01:51 | |
*** sthaha has joined #openstack-qa | 01:51 | |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "ssh-login server" method https://review.openstack.org/42569 | 02:23 |
*** ivanzhu has quit IRC | 02:25 | |
*** ivanzhu has joined #openstack-qa | 02:26 | |
openstackgerrit | A change was merged to openstack-dev/grenade: add nova v3 api support in upgrade https://review.openstack.org/40134 | 02:36 |
openstackgerrit | A change was merged to openstack-dev/grenade: Preserve devstack/accrc files https://review.openstack.org/43040 | 02:37 |
*** LiangZheng has joined #openstack-qa | 02:45 | |
openstackgerrit | Ivan-Zhu proposed a change to openstack/tempest: port test_extensions into nova v3 part2 https://review.openstack.org/43236 | 02:54 |
*** mriedem has quit IRC | 03:01 | |
*** ivanzhu has quit IRC | 03:05 | |
openstackgerrit | Ivan-Zhu proposed a change to openstack/tempest: port test_extensions into v3 part1 https://review.openstack.org/43238 | 03:06 |
openstackgerrit | Ivan-Zhu proposed a change to openstack/tempest: port test_extensions into nova v3 part2 https://review.openstack.org/43236 | 03:06 |
openstackgerrit | Ivan-Zhu proposed a change to openstack/tempest: port test_extensions into nova v3 part2 https://review.openstack.org/43236 | 03:21 |
*** HenryG_ has joined #openstack-qa | 03:54 | |
*** cyeoh has quit IRC | 03:54 | |
*** soren has quit IRC | 03:54 | |
openstackgerrit | afazekas proposed a change to openstack-dev/devstack: Configure bash completion https://review.openstack.org/41928 | 03:54 |
*** soren has joined #openstack-qa | 03:55 | |
*** cyeoh has joined #openstack-qa | 03:55 | |
*** HenryG has quit IRC | 03:57 | |
*** anteaya has quit IRC | 04:03 | |
openstackgerrit | afazekas proposed a change to openstack-dev/devstack: Configure the ec2 credentials explicitly in tempest https://review.openstack.org/39525 | 04:07 |
*** dtroyer has quit IRC | 04:23 | |
*** dtroyer has joined #openstack-qa | 04:23 | |
*** samalba has quit IRC | 04:23 | |
*** comstud has quit IRC | 04:23 | |
*** mberwanger has joined #openstack-qa | 04:24 | |
*** comstud has joined #openstack-qa | 04:25 | |
*** samalba has joined #openstack-qa | 04:27 | |
openstackgerrit | Jiajun Liu proposed a change to openstack-dev/devstack: add new options to config vnc/spice server https://review.openstack.org/41609 | 04:28 |
Anju | cyeoh : gm | 04:30 |
cyeoh | Anju: hi | 04:30 |
Anju | cyoh : do u have any idea https://github.com/openstack/tempest/blob/master/tempest/services/image/v1/json/image_client.py#L41 | 04:31 |
Anju | of this test | 04:31 |
Anju | I mean how can i see the response of this | 04:32 |
Anju | cyeoh : do u have any idea https://github.com/openstack/tempest/blob/master/tempest/services/image/v1/json/image_client.py#L41 | 04:34 |
cyeoh | um, not sure what you're asking | 04:34 |
Anju | i dont know how to check its response | 04:34 |
Anju | how this is implemented in json | 04:35 |
Anju | using which cli | 04:35 |
Anju | cyeoh : usually the tests are using cli and implemented according to the request /response | 04:36 |
cyeoh | that's just an internal function. DO you mean get_image_meta()? | 04:37 |
Anju | yeah that is internal functions | 04:38 |
Anju | but without knowing the response in json | 04:38 |
Anju | how this is implemented | 04:38 |
cyeoh | it looks to me that its just creating a json formatted response so it easier to handle from the test side. The actual response from glance is contained in the headers | 04:40 |
cyeoh | well its not even really json, its just a dictionary. | 04:40 |
Anju | so one can implement it same in xml | 04:41 |
Anju | cyeoh : https://github.com/openstack/tempest/blob/master/tempest/services/image/v1/json/image_client.py#L116 | 04:48 |
Anju | for create_with_data | 04:48 |
Anju | what is the cli for this one | 04:48 |
cyeoh | you'll need to check the glance doco or code for what it expects with xml | 04:50 |
Anju | in cglanc ehelp : i am not findin this one | 04:50 |
cyeoh | you'll need to look at the glance source code then if its not in the docs | 04:51 |
Anju | ok cyeoh : thanks | 04:51 |
*** SergeyLukjanov has joined #openstack-qa | 04:53 | |
*** ivanzhu has joined #openstack-qa | 04:57 | |
*** jhenner has joined #openstack-qa | 05:05 | |
*** jhenner has quit IRC | 05:10 | |
openstackgerrit | A change was merged to openstack/tempest: Cleanup: Add common "create keypair" method https://review.openstack.org/42555 | 05:13 |
*** mberwanger has quit IRC | 05:16 | |
openstackgerrit | A change was merged to openstack/tempest: Add tenant isolation to the swift tests https://review.openstack.org/42169 | 05:21 |
*** yfried has joined #openstack-qa | 05:23 | |
openstackgerrit | A change was merged to openstack/tempest: Adding network api xml support https://review.openstack.org/41673 | 05:24 |
*** guest_____ has joined #openstack-qa | 06:04 | |
*** yfried has quit IRC | 06:06 | |
*** SergeyLukjanov has quit IRC | 06:15 | |
*** HenryG_ has quit IRC | 06:30 | |
openstackgerrit | A change was merged to openstack/tempest: Remove identity race condition https://review.openstack.org/42351 | 06:34 |
*** raies has joined #openstack-qa | 06:50 | |
openstackgerrit | A change was merged to openstack/tempest: Mismatch dictionary key in the process of parsing XML https://review.openstack.org/42797 | 06:50 |
openstackgerrit | A change was merged to openstack-dev/devstack: .conf suffix for the horizon config on Fedora https://review.openstack.org/40352 | 06:50 |
raies | will someone please check https://review.openstack.org/#/c/42624/ | 06:52 |
*** yfried has joined #openstack-qa | 06:58 | |
*** SergeyLukjanov has joined #openstack-qa | 07:05 | |
*** guest_____ has quit IRC | 07:16 | |
*** fbo_away is now known as fbo | 07:16 | |
*** guest_____ has joined #openstack-qa | 07:21 | |
*** tkammer has joined #openstack-qa | 07:33 | |
*** SergeyLukjanov has quit IRC | 07:40 | |
*** afazekas has joined #openstack-qa | 07:52 | |
openstackgerrit | Ivan-Zhu proposed a change to openstack/tempest: port test_images and test_server_actions into v3 part2 https://review.openstack.org/39609 | 07:55 |
*** giulivo has joined #openstack-qa | 07:57 | |
*** ivanzhu has quit IRC | 08:25 | |
*** ivanzhu has joined #openstack-qa | 08:27 | |
*** jhenner has joined #openstack-qa | 08:33 | |
*** prekarat has joined #openstack-qa | 08:36 | |
*** prekarat has left #openstack-qa | 08:37 | |
raies | mkoderer: patch3 uploaded please check | 08:45 |
*** ivanzhu has quit IRC | 08:55 | |
*** mkollaro has joined #openstack-qa | 09:11 | |
openstackgerrit | Roman Prykhodchenko proposed a change to openstack-dev/devstack: Basic support of Ironic https://review.openstack.org/41053 | 09:31 |
mkoderer | afazekas: ping | 09:46 |
mkoderer | afazekas: regarding https://review.openstack.org/#/c/43155/1 | 09:47 |
mkoderer | is it a good idea to call assert without self. ? | 09:47 |
mkoderer | I mean both will raise an exception but what is the drawback if you call directly? | 09:48 |
afazekas | in a test_ method it is not ok IMHO | 09:49 |
afazekas | outside to a test method it can be ok | 09:50 |
mkoderer | yes that's what I thought | 09:50 |
afazekas | assertTrue chacks more than the previous version | 09:51 |
mkoderer | but why it is not ok? ;) is there a special assert logic implemented and that why it necessary to use the object methods? | 09:51 |
mkoderer | ok so the correct solution would be self.assertTrue | 09:52 |
afazekas | https://github.com/testing-cabal/testtools/blob/master/testtools/matchers/_basic.py#L117 | 09:52 |
afazekas | assertTrue checks the same thing as the proposed assert change | 09:53 |
afazekas | The python assert statement raises an error which probbaly will be considered as ERROR instead of FAIL | 09:55 |
mkoderer | afazekas: ok thanks :) | 09:55 |
afazekas | https://github.com/openstack/tempest/blob/master/tempest/exceptions.py#L56 exceptions are FAILs | 09:56 |
openstackgerrit | Ionut Artarisi proposed a change to openstack/tempest: raise assertion error if output is falsy https://review.openstack.org/43155 | 10:01 |
*** afazekas has quit IRC | 10:07 | |
*** thomasbiege has joined #openstack-qa | 10:10 | |
openstackgerrit | Avishay Traeger proposed a change to openstack-dev/grenade: Update Cinder's policy.json file for migration https://review.openstack.org/42971 | 10:26 |
*** thomasbiege has quit IRC | 10:28 | |
*** weshay has joined #openstack-qa | 10:29 | |
*** thomasbiege has joined #openstack-qa | 10:38 | |
*** LiangZheng has quit IRC | 10:40 | |
openstackgerrit | A change was merged to openstack/tempest: Cleanup: Add common "create security rule" method https://review.openstack.org/42303 | 10:43 |
*** openstack has joined #openstack-qa | 15:12 | |
mtreinish | oh fun, looks like parallel doesn't work with neutron... | 15:14 |
mtreinish | mlavalle: ping | 15:22 |
*** thomasbiege has quit IRC | 15:22 | |
mlavalle | mtreinish: pong | 15:22 |
mtreinish | mlavalle: hey so I'm looking at the neutron jobs for running in parallel. There are 2 things I see that need to be fixed | 15:22 |
openstackgerrit | Zhi Kun Liu proposed a change to openstack/tempest: add expired tokens tests https://review.openstack.org/43301 | 15:23 |
mtreinish | first we don't run tenant isolation on tempest with neutron | 15:23 |
*** thomasbiege has joined #openstack-qa | 15:24 | |
mtreinish | and the second is: http://logs.openstack.org/97/41797/1/check/gate-tempest-devstack-vm-neutron/0b9a9ee/console.html.gz | 15:24 |
mtreinish | which might be related to tenant isolation | 15:24 |
mtreinish | mlavalle: do you have any ideas on why we don't run with tenant isolation with neutron? | 15:24 |
mlavalle | mtreinish:nope. It's been a fact for me since I started with Tempest | 15:25 |
mlavalle | I can help researching, though | 15:25 |
mtreinish | mlavalle: ok, there is a comment in devstack about it: https://github.com/openstack-dev/devstack/blob/master/lib/tempest#L234 | 15:26 |
mtreinish | it's something we need to change | 15:27 |
mlavalle | ok | 15:27 |
mlavalle | We can ping Nachi regarding this. Most likely he knows the reason behind this | 15:29 |
mtreinish | mlavalle: well, how hard is it to create a network per tenant (the comment implies that's what's required for tenant isolation on neutron) | 15:31 |
*** thomasbiege has quit IRC | 15:32 | |
mlavalle | not very hard…. I just want to know the reason. It doesn't hurt to be careful…. | 15:33 |
mlavalle | there must be a reason behind this | 15:34 |
*** Anju has joined #openstack-qa | 15:51 | |
*** raies_ has joined #openstack-qa | 16:03 | |
*** dkranz has quit IRC | 16:07 | |
*** SergeyLukjanov has quit IRC | 16:14 | |
*** yfried has joined #openstack-qa | 16:23 | |
*** dkranz has joined #openstack-qa | 16:25 | |
*** SergeyLukjanov has joined #openstack-qa | 16:28 | |
*** giulivo has quit IRC | 16:39 | |
*** krtaylor has quit IRC | 16:50 | |
*** fbo is now known as fbo_away | 16:56 | |
*** SergeyLukjanov has quit IRC | 17:00 | |
mtreinish | meeting time | 17:00 |
raies_ | dkranz: will you please check https://review.openstack.org/#/c/42624/ | 17:00 |
*** dkranz has quit IRC | 17:01 | |
*** dkranz has joined #openstack-qa | 17:01 | |
raies_ | dkranz: will you please check https://review.openstack.org/#/c/42624/ | 17:02 |
dkranz | Hi | 17:02 |
dkranz | Any one else here? | 17:02 |
raies_ | dkranz: will you please check https://review.openstack.org/#/c/42624/ I have added in api documentation | 17:03 |
dkranz | mtreinish: You still here? | 17:04 |
mtreinish | dkranz: yeah it's meeting time | 17:04 |
dkranz | mtreinish: No one else seems to be on. | 17:04 |
dkranz | Except raies | 17:05 |
dkranz | mtreinish: I've been socked in all week. | 17:05 |
*** SergeyLukjanov has joined #openstack-qa | 17:05 | |
*** thomasbiege has joined #openstack-qa | 17:08 | |
dkranz | mtreinish: Should we cancel the meeting? | 17:08 |
mtreinish | dkranz: it's going on now in the openstack-meeting channel | 17:09 |
dkranz | mtreinish: Duh. I'm an idiot. | 17:09 |
*** thomasbiege has quit IRC | 17:20 | |
*** SergeyLukjanov has quit IRC | 17:22 | |
openstackgerrit | Ravi Chunduru proposed a change to openstack-dev/devstack: Adds support for Openstack Networking FWaaS (Firewall) https://review.openstack.org/37147 | 17:22 |
openstackgerrit | Kyle Mestery proposed a change to openstack-dev/devstack: Add support for setting Neutron DHCP agent options. https://review.openstack.org/43212 | 17:26 |
*** yfried has quit IRC | 17:27 | |
*** thomasbiege has joined #openstack-qa | 17:33 | |
*** fbo_away is now known as fbo | 17:38 | |
raies_ | annegentle: please check https://review.openstack.org/#/c/42624/ on api-site | 17:41 |
raies_ | annegentle: you are there ? | 17:43 |
*** SergeyLukjanov has joined #openstack-qa | 17:46 | |
*** thomasbiege2 has joined #openstack-qa | 17:47 | |
*** thomasbiege has quit IRC | 17:51 | |
*** thomasbiege2 is now known as thomasbiege | 17:58 | |
mtreinish | mkollaro: so we normally no one has posted that level detail for planning tests ahead of time | 18:01 |
mkollaro | so, forward from #openstack-meeting: we are planning to put some test plans we are writing for new havanna features into a github repo in some nice .rst or .md format | 18:01 |
mtreinish | but we normally don't put planned feature documentation in the project repo | 18:01 |
mkollaro | nobody wants to use blueprints for this somehow and since the test plans are a kind of pseudocode, we'd prefer to use git | 18:01 |
mkollaro | mtreinish: well I see you don't, that's why I'm asking | 18:02 |
mkollaro | so the question is, should we put them into the tempest repo or create another? | 18:02 |
mtreinish | mkollaro: I think a separate repo is the answer here | 18:02 |
mtreinish | and link to it from a blueprint | 18:03 |
mkollaro | mtreinish: ok | 18:03 |
mtreinish | mlavalle: ok so on your neutron bug | 18:06 |
*** tkammer has quit IRC | 18:06 | |
mtreinish | the issue with the sec group tests is that neutron returns 400 with an id and 404 with a uuid | 18:06 |
mtreinish | ? | 18:06 |
openstackgerrit | A change was merged to openstack-dev/devstack: Remove useless sources.list https://review.openstack.org/42652 | 18:09 |
afazekas | if is_neutron then diff error code check ; can be ok | 18:10 |
mtreinish | afazekas: I don't think special casing every difference for neutron is the right way to do it | 18:12 |
mtreinish | because these are coming from nova I think | 18:12 |
*** prekarat has quit IRC | 18:13 | |
mlavalle | mtreinish: I steeped away for a bit. I am back | 18:31 |
raies_ | mlavalle: who looks for api-site | 18:32 |
raies_ | mlavalle: I have added https://review.openstack.org/#/c/42624/ need review | 18:32 |
mlavalle | raies_: I don't know shoe reviews that | 18:35 |
raies_ | mlavalle: ok | 18:35 |
*** krtaylor has joined #openstack-qa | 18:37 | |
*** raies_ has quit IRC | 18:40 | |
mkoderer | dkranz: mtreinish: jfyi http://www.openstack.org/rate/Presentation/stress-testing-openstack-chuck-norris-style | 18:43 |
mkoderer | feel free to vote for it :) | 18:43 |
*** thomasbiege has quit IRC | 18:48 | |
*** Anju has quit IRC | 19:11 | |
*** thomasbiege has joined #openstack-qa | 19:21 | |
*** SergeyLukjanov has quit IRC | 19:23 | |
*** thomasbiege has quit IRC | 19:27 | |
*** malini is now known as malini_afk | 19:30 | |
*** HenryG has quit IRC | 19:36 | |
openstackgerrit | Avishay Traeger proposed a change to openstack-dev/grenade: Update Cinder's policy.json file for migration https://review.openstack.org/42971 | 19:47 |
mtreinish | mlavalle: sorry I had some meetings | 19:49 |
mlavalle | mterinish: np. I also stepped out after the IRC meeting | 19:50 |
*** SergeyLukjanov has joined #openstack-qa | 19:51 | |
mlavalle | so, with neutron, if you specify the sec group with id, you get a 400 | 19:51 |
mlavalle | if you specify the sec group with uuid, and the sec group doesn't exist you get 404 | 19:51 |
mtreinish | so the issue I'm seeing with that bug is do we special case it in tempest or make the sec group responses with neutron behave the same way as nova network | 19:52 |
mlavalle | my position is to create special cases in tempest | 19:52 |
mlavalle | because both neutron and nova net are doing what they are supposed to do | 19:52 |
mlavalle | in other words, we don't have a bug | 19:53 |
mtreinish | mlavalle: I have 2 problems with doing it that way. 1. It's a published api doing 2 different things depending on whats doing the work on the backend | 19:53 |
mtreinish | 2. I have a feeling this will come up with more then just sec groups and I don't think special cases everything network related is really the right way to do things | 19:54 |
mlavalle | mhhhhh… bear with me for a minute. In principle, I agree with you. an api should behave the same regardless of the backend | 19:54 |
mlavalle | the situation can be characterized as follows: if you present the api with a valid id for a sec group (id or uuid) and the sec group doesn't exist, you get back a 404, not found | 19:55 |
mlavalle | if you present the api with an invalid id (id or uuid) you get back a 400. | 19:56 |
mlavalle | so you are getting the same behavior, regardless of the backend | 19:56 |
mtreinish | mlavalle: the issue is what determines whether its valid or not | 19:57 |
mtreinish | because based on the bug it looks like neutron checks to make sure it's in the uuid format | 19:57 |
mlavalle | neutron expects an uuid | 19:57 |
mtreinish | and nova just wants a string | 19:57 |
mlavalle | correct, nova wants a string convertible to inetger | 19:58 |
mlavalle | the alternative is to implement uuid for sec groups in nova | 19:59 |
mlavalle | or implement id's for sectroups in neutron | 20:00 |
mtreinish | mlavalle: or somehow map between them | 20:00 |
mtreinish | either way I'd call it a bug in the nova<->neutron layer if it causes different behavior in an api | 20:01 |
mlavalle | ok…. any suggestions on this last alternative? | 20:01 |
mtreinish | mlavalle: not really, it was just a hypothetical 3rd option | 20:01 |
mlavalle | look, if the solution is implement uuid's in nova for sec groups, i'm ready to start doing it. I just want to know this is how we ant to move forward | 20:02 |
mtreinish | mlavalle: I'm not really the right person to ask about how to handle it in nova. I'm just saying looking at it from the tempest side the nova api shouldn't change behavior whether you're running neutron or not. | 20:03 |
mtreinish | I mean that's why we have the negative tests to prevent those kind of changes/ | 20:05 |
mlavalle | mtreinish: agree. i'll ping some people on the nova and neutron side and see what i come up with. i'll keep you posted | 20:06 |
mtreinish | mlavalle: ok, another thing that might be a problem is api stability on the nova side forcing uuid with secgroups might not be doable with v2, but you should be able to require it with v3. | 20:07 |
mtreinish | cyeoh: would be the right person to ask about the api stability and v3 api in general | 20:08 |
mlavalle | good point. let's see where I get there | 20:08 |
*** SergeyLukjanov has quit IRC | 20:25 | |
*** mkollaro has quit IRC | 20:33 | |
openstackgerrit | Pavel Sedlák proposed a change to openstack/tempest: cli: add messages to assertTrue https://review.openstack.org/43350 | 20:41 |
*** woodspa has quit IRC | 20:44 | |
openstackgerrit | Mike Perez proposed a change to openstack-dev/grenade: Add Cinder API v2 to Keystone catalog https://review.openstack.org/43352 | 20:48 |
*** dkranz has quit IRC | 20:51 | |
*** thomasbiege has joined #openstack-qa | 20:57 | |
*** thomasbiege has quit IRC | 20:57 | |
*** mkollaro has joined #openstack-qa | 21:01 | |
cyeoh | mlavalle: which secgroup calls are you talking about? | 21:25 |
cyeoh | mlavalle: for the v3 api most of the security group interface is going away since it just proxies to neutron anyway. About the only thing left is being able to specific the security group on instance creation | 21:26 |
mlavalle | cyeoh: thanks…. Is there a place where I can read the V3 specification for sec groups? | 21:27 |
openstackgerrit | Steve Baker proposed a change to openstack/tempest: Heat autoscaling scenario test https://review.openstack.org/36367 | 21:28 |
*** jasondotstar has quit IRC | 21:29 | |
cyeoh | mlavalle: unfortunately not really. docs still in progress. | 21:29 |
cyeoh | this is the best I can offer :-( https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/plugins/v3/security_groups.py | 21:29 |
cyeoh | however, SecurityGroupsActionController is in the process of being removed | 21:30 |
cyeoh | since adding/removing secuirty groups to instances can be done direct to neutron as well | 21:30 |
mlavalle | thanks… let me take a look at it. I'll get back to you if I have questions | 21:30 |
*** krtaylor has quit IRC | 21:31 | |
*** krtaylor has joined #openstack-qa | 21:33 | |
*** mriedem has quit IRC | 21:36 | |
*** weshay has quit IRC | 22:10 | |
*** mkollaro has quit IRC | 22:13 | |
*** burt has quit IRC | 22:16 | |
openstackgerrit | Kui Shi proposed a change to openstack/tempest: emit warning while running flake8 without virtual env https://review.openstack.org/43367 | 22:42 |
*** mlavalle has quit IRC | 22:46 | |
*** mriedem has joined #openstack-qa | 23:18 | |
*** fbo is now known as fbo_away | 23:46 | |
*** sthaha has joined #openstack-qa | 23:49 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!