*** sungju has joined #openstack-qa | 00:21 | |
*** anteaya has quit IRC | 02:12 | |
*** ivanzhu has joined #openstack-qa | 02:32 | |
*** cyeoh_ is now known as cyeoh | 03:13 | |
*** ivanzhu has quit IRC | 03:16 | |
*** bnemec_ is now known as bnemec_away | 04:00 | |
Anju | yfried : if u want to make any canges | 04:47 |
---|---|---|
Anju | in the current aptch | 04:47 |
Anju | patch | 04:47 |
Anju | then click on the checkout which is first option in the gerrit page and use the same url | 04:47 |
yfried | Anju: i accidentally created to parallel patches, but i manged to update the later. any way to "merge" them (or delete the first)? | 04:50 |
*** SergeyLukjanov has joined #openstack-qa | 04:51 | |
Anju | can u plaese show me | 04:58 |
Anju | i can try | 04:58 |
Anju | to tell u | 04:58 |
yfried | Anju: that's the first one: https://review.openstack.org/#/c/44601/ | 05:14 |
yfried | Anju: that's the second one with the fixed pep8: https://review.openstack.org/#/c/44607/ | 05:14 |
*** sungju has quit IRC | 05:15 | |
*** ken1ohmichi has joined #openstack-qa | 05:19 | |
Anju | yfried : but jenkins have already given + 1 | 05:27 |
Anju | if the code is same in both patches | 05:28 |
Anju | then click on the abandon button in the gerrit page https://review.openstack.org/#/c/44601/ | 05:29 |
Anju | yfried: ^^^ | 05:29 |
Anju | one thing more from the next tim e | 05:29 |
Anju | time | 05:29 |
Anju | use the checkout url for amking any changes in the committed code | 05:30 |
yfried | Anju: how do i do that? what are the command i use? | 05:30 |
yfried | Anju: i tried 'git commit --amend' and then 'git review' | 05:31 |
Anju | after using the url | 05:31 |
Anju | 1.go to checkout | 05:31 |
Anju | copy the link given below | 05:32 |
Anju | 2. mkae the changes | 05:32 |
Anju | make the changes in the committed code | 05:32 |
Anju | and then use git commit -a --amend | 05:32 |
Anju | and no need to mention like (pep8 fix) | 05:33 |
yfried | Anju: cope the whole line? 'git fetch <url> && git checkout FETCH_HEAD'? | 05:33 |
Anju | in the meaages | 05:33 |
Anju | yfried: yeah the complete | 05:33 |
yfried | Anju: BEFORE making the changes, right? | 05:34 |
Anju | yes | 05:34 |
Anju | after that | 05:34 |
Anju | make the changes | 05:34 |
yfried | Anju: tnx. i will try that once i get feed back | 05:34 |
Anju | for ex.u remove the spaces here | 05:34 |
Anju | and u can check the git status also | 05:35 |
Anju | before committing | 05:35 |
Anju | yeah | 05:35 |
Anju | :) | 05:35 |
*** SergeyLukjanov has quit IRC | 05:42 | |
*** ken1ohmichi has quit IRC | 06:13 | |
*** prekarat has joined #openstack-qa | 06:29 | |
*** jhenner has quit IRC | 07:12 | |
*** thomasbiege has joined #openstack-qa | 07:23 | |
*** woodspa has joined #openstack-qa | 07:25 | |
*** woodspa has left #openstack-qa | 07:25 | |
*** thomasbiege has quit IRC | 07:26 | |
*** jhenner has joined #openstack-qa | 07:52 | |
*** yassine has joined #openstack-qa | 07:58 | |
*** SergeyLukjanov has joined #openstack-qa | 08:06 | |
*** fbo_away is now known as fbo | 08:39 | |
*** prekarat has quit IRC | 09:03 | |
*** prekarat has joined #openstack-qa | 09:04 | |
*** yassine has quit IRC | 09:41 | |
*** prekarat1 has joined #openstack-qa | 09:45 | |
*** prekarat has quit IRC | 09:45 | |
*** dosaboy_ has joined #openstack-qa | 09:45 | |
*** thomasbiege1 has joined #openstack-qa | 09:47 | |
*** dosaboy has quit IRC | 09:48 | |
*** prekarat1 has quit IRC | 09:51 | |
*** prekarat has joined #openstack-qa | 09:51 | |
*** thomasbiege1 has quit IRC | 09:52 | |
*** mkollaro has joined #openstack-qa | 10:09 | |
*** jhenner has quit IRC | 10:53 | |
*** jhenner has joined #openstack-qa | 10:55 | |
*** jhenner has quit IRC | 11:06 | |
*** yassine_ has joined #openstack-qa | 11:29 | |
*** prekarat has quit IRC | 11:58 | |
yfried | Anju: if i submitted 3 files in patch and fixed one of them according to comments, do i need to resubmit all 3? | 12:01 |
rahmu | hello, in tempest's api Swift client, is there a way to set metadata on a container? | 12:12 |
Anju | yfried : hi | 12:17 |
Anju | when u will copy the url of git checkout | 12:18 |
Anju | then the changes will reflect in the current code also | 12:18 |
Anju | i mean on ut local branch | 12:18 |
Anju | and when u will do git commit -a --amend | 12:18 |
Anju | then the former changes of ur patch and the changes u will do | 12:19 |
Anju | will commit also | 12:19 |
Anju | do need to type message again | 12:20 |
Anju | if u dont want to commit the message | 12:20 |
Anju | yfried :^^^ | 12:25 |
*** adalbas has joined #openstack-qa | 13:05 | |
rahmu | mkollaro: thanks for your review on swift tempurl. I'll work on uploading a new patch set accordingly :) | 13:11 |
mkollaro | rahmu: thanks for the nice commit :) | 13:11 |
rahmu | mkollaro: I'm currently working on covering the staticweb middleware in tempest. Do you want me to assign you as a reviewer on it? | 13:13 |
mkollaro | rahmu: is that a feature in swift? | 13:13 |
rahmu | yes | 13:13 |
mkollaro | rahmu: feel free to assign any review concerning swift to me :) | 13:14 |
rahmu | awesome, will do as soon as I commit for review | 13:14 |
*** adalbas has quit IRC | 13:17 | |
*** sthaha has quit IRC | 13:17 | |
*** yfried has quit IRC | 13:22 | |
*** krtaylor has quit IRC | 13:22 | |
*** adalbas has joined #openstack-qa | 13:29 | |
Anju | mtreinish : ping | 14:02 |
*** EmilienM has quit IRC | 14:02 | |
*** EmilienM has joined #openstack-qa | 14:02 | |
*** anteaya has joined #openstack-qa | 14:03 | |
*** yassine_ has quit IRC | 14:40 | |
*** yassine_ has joined #openstack-qa | 14:56 | |
*** thomasbiege1 has joined #openstack-qa | 15:26 | |
*** thomasbiege1 has quit IRC | 15:28 | |
*** openstackgerrit has joined #openstack-qa | 15:29 | |
openstackgerrit | Zhi Kun Liu proposed a change to openstack/tempest: dd server resizing tests https://review.openstack.org/44732 | 15:36 |
*** adalbas has quit IRC | 15:39 | |
*** marun has joined #openstack-qa | 15:50 | |
*** fbo is now known as fbo_away | 15:51 | |
openstackgerrit | Jorge Valderrama Romero proposed a change to openstack-dev/devstack: Fix deprecated params user_id, role_id, tenant_id https://review.openstack.org/44725 | 15:57 |
*** fbo_away is now known as fbo | 16:01 | |
openstackgerrit | Zhi Kun Liu proposed a change to openstack/tempest: add server resizing tests https://review.openstack.org/44732 | 16:04 |
*** anteaya has quit IRC | 16:14 | |
*** yassine_ has quit IRC | 16:22 | |
*** fbo is now known as fbo_away | 16:25 | |
*** anteaya has joined #openstack-qa | 16:26 | |
openstackgerrit | Swapnil Kulkarni proposed a change to openstack/tempest: Restrict Volume type deletion with volumes assoc https://review.openstack.org/44743 | 16:29 |
*** thomasbiege1 has joined #openstack-qa | 16:30 | |
*** thomasbiege1 has quit IRC | 16:30 | |
*** SergeyLukjanov has quit IRC | 16:33 | |
openstackgerrit | Zhi Kun Liu proposed a change to openstack/tempest: add flavor creation tests https://review.openstack.org/44746 | 16:40 |
openstackgerrit | Swapnil Kulkarni proposed a change to openstack/tempest: Restrict Volume type deletion with volumes assoc https://review.openstack.org/44743 | 16:41 |
openstackgerrit | Zhi Kun Liu proposed a change to openstack/tempest: add server resizing tests https://review.openstack.org/44732 | 16:46 |
*** mkollaro has quit IRC | 16:58 | |
*** SergeyLukjanov has joined #openstack-qa | 16:59 | |
*** adalbas has joined #openstack-qa | 17:00 | |
*** EmilienM has quit IRC | 17:04 | |
*** EmilienM has joined #openstack-qa | 17:05 | |
openstackgerrit | Swapnil Kulkarni proposed a change to openstack/tempest: Restrict Volume type deletion with volumes assoc https://review.openstack.org/44743 | 17:26 |
*** yfried has joined #openstack-qa | 18:43 | |
*** krtaylor has joined #openstack-qa | 18:57 | |
*** yfried has quit IRC | 18:58 | |
*** fbo_away is now known as fbo | 19:15 | |
openstackgerrit | Nikolay Sobolevsky proposed a change to openstack-dev/devstack: Add my_ip option in cinder.conf https://review.openstack.org/44508 | 19:17 |
*** yfried has joined #openstack-qa | 19:41 | |
*** adalbas has quit IRC | 19:45 | |
*** adalbas has joined #openstack-qa | 19:50 | |
*** fbo is now known as fbo_away | 21:02 | |
*** SergeyLukjanov has quit IRC | 21:03 | |
*** HenryG has joined #openstack-qa | 21:41 | |
*** yfried has quit IRC | 21:52 | |
*** HenryG has quit IRC | 23:15 | |
*** HenryG has joined #openstack-qa | 23:16 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!