Friday, 2014-08-15

*** evgenyf has joined #openstack-qa00:01
mtreinishmkoderer: ^^^ sorry it looks like that bounced one of your patches...00:01
*** rhsu has joined #openstack-qa00:03
*** cpallares has quit IRC00:03
openstackgerritA change was merged to openstack/tempest: Enable E128 ignore E129  https://review.openstack.org/9890900:03
*** cpallares has joined #openstack-qa00:04
*** yamahata has joined #openstack-qa00:05
*** yamahata has quit IRC00:05
*** yamahata has joined #openstack-qa00:05
openstackgerritLakshmi N Sampath proposed a change to openstack/tempest: Glance Metadata Definitions Catalog - Tempest tests  https://review.openstack.org/11363200:15
*** aimon has quit IRC00:19
*** atiwari has quit IRC00:19
*** cpallares has quit IRC00:26
openstackgerritLakshmi N Sampath proposed a change to openstack/tempest: Glance Metadata Definitions Catalog - Tempest tests  https://review.openstack.org/11363200:27
*** evgenyf has quit IRC00:43
*** lordd_ has quit IRC00:44
*** lordd_ has joined #openstack-qa00:45
*** suneelb has quit IRC00:47
openstackgerritA change was merged to openstack-dev/devstack: Modify `glance image-create` commands to use openstackclient  https://review.openstack.org/11153800:50
*** flwang_ has joined #openstack-qa00:55
*** flwang_ has quit IRC00:59
*** rhsu has quit IRC01:05
openstackgerritJim Rollenhagen proposed a change to openstack-dev/devstack: Allow devstack to build ironic agent ramdisk  https://review.openstack.org/11440801:09
*** salv-orlando has quit IRC01:13
*** jyuso has joined #openstack-qa01:14
*** nosnos has joined #openstack-qa01:15
*** dims has quit IRC01:22
*** nosnos has quit IRC01:22
*** dims has joined #openstack-qa01:22
*** nosnos has joined #openstack-qa01:23
*** dims_ has joined #openstack-qa01:25
*** dims has quit IRC01:25
*** zz_dimtruck is now known as dimtruck01:35
*** Sukhdev has quit IRC01:36
*** Sukhdev has joined #openstack-qa01:36
*** Sukhdev_ has joined #openstack-qa01:39
*** jaypipes has quit IRC01:42
*** Sukhdev has quit IRC01:42
*** jaypipes has joined #openstack-qa01:43
*** ChanServ sets mode: +o jaypipes01:43
*** marun has quit IRC01:44
*** Sukhdev_ has quit IRC01:44
*** marun has joined #openstack-qa01:44
*** aimon has joined #openstack-qa01:45
*** krtaylor has joined #openstack-qa01:54
*** jaypipes has quit IRC01:55
*** dims_ has quit IRC02:04
*** dims has joined #openstack-qa02:05
*** jaypipes has joined #openstack-qa02:06
*** ChanServ sets mode: +o jaypipes02:06
*** Krast has joined #openstack-qa02:33
*** dustins has joined #openstack-qa02:43
*** dustins has quit IRC02:48
*** dustins has joined #openstack-qa02:48
*** dims has quit IRC02:53
*** flwang_ has joined #openstack-qa02:56
*** flwang_ has quit IRC03:00
*** annegentle_ has quit IRC03:02
*** Krast has quit IRC03:10
*** Krast has joined #openstack-qa03:10
*** adalbas has quit IRC03:13
*** nosnos has quit IRC03:28
jrollianw: around?03:29
ianwjroll: hi03:29
jrollianw: hey, I saw you left a -1 on 114408, not sure what you mean by "pkg install fns" but assuming that's a devstack-ism03:31
jrollbetter link, https://review.openstack.org/#/c/114408/1/lib/ironic03:31
*** yfried__ has quit IRC03:31
ianwjroll: there's install_package functions, that are platform independent03:31
jrollianw: since I finally caught you, can I ask you to review the patches that depends on? https://review.openstack.org/112095 and https://review.openstack.org/10845703:32
jroll^ they've been hanging for a wihle03:32
ianwbut there's also files/apts/ironic which may be appropriate03:32
jrollianw: ok, cool, I assumed there was something, that one is somewhat of a wip03:32
jrollyeah03:32
jrollI don't know devstack too well, I got that working and put it up to make sure I didn't lose it :P03:33
*** dimtruck is now known as zz_dimtruck03:34
ianwjroll: can you give me the 2-second version of why https://review.openstack.org/#/c/112095/3 is needed?03:36
ianwjroll: it looks ok, but i have no context03:36
jrollianw: the other patch relies on swift temp urls being a thing03:37
jrollwe don't want any credentials being passed to the deploy ramdisk (aka agent)03:37
jrollthis allows that ramdisk to download images without creds03:37
ianwjroll: right, so that would have been a better description :)03:39
jrollianw: I mean, it's a supported feature in swift, so chancs are someone might use it with devstack :P03:40
*** nosnos has joined #openstack-qa03:41
*** harlowja is now known as harlowja_away03:42
jrollianw: to be honest, I've just had a really hard time getting a hold of devstack cores, which is why I'm bugging you. if you don't like anything about these patches, I'm happy to do someback-and-forth as long as I get your +2 with it :)03:44
ianwjroll: i assume you're ok if I put you down against ironic in MAINTAINERS.rst?03:44
jrolllol, no please don't credit me03:44
jroll:P03:44
jrollthat's fine with me03:45
jrollI'm an ironic core, please hold me accountable if needed03:45
*** Sukhdev has joined #openstack-qa03:46
jrollianw: I'm also happy to throw others under that bus as needed :)03:47
jrollugh03:52
jrollianw: thank you for the +A's, apparently there is a merge conflict03:52
ianwjroll: ok, thanks ... nothing jumps out at me worth holding those up for.  i might have jumped on them earlier if the change descriptions were more in depth.  personally i feel you can not have too much info in there03:53
ianwi have no special knowledge of swift/ironic, so details really help! :)03:53
*** chandankumar has joined #openstack-qa03:54
ianwjroll: bummer, yeah i guess you have to rebase03:54
jrollianw: yeah, I hear you on the commit messages03:55
jrollwill ping you if I rebase tonight, may wait until morning03:55
ianwjroll: ok, i'm in sydney/austraila tz03:56
*** amotoki has joined #openstack-qa03:56
*** dustins has quit IRC04:02
jrollianw: aha, everything makes so much more sense :P04:03
*** pcrews has quit IRC04:04
*** chandankumar has quit IRC04:06
openstackgerritJim Rollenhagen proposed a change to openstack-dev/devstack: Add ironic-python-agent support to devstack  https://review.openstack.org/10845704:08
jrollianw: ^^ theoretically that should work?04:08
jrollI'm much more confident than that ? seems :P04:09
jrollianw: and if I just get your +2 that's fine... I can catch dtroyer in the morning (pacific time)04:09
*** amotoki has quit IRC04:10
* jroll will be back tomorroww04:13
jrollthanks ianw04:13
ianwjroll: ok, i'll keep an eye on jenkins04:15
*** amotoki has joined #openstack-qa04:33
openstackgerritSteve Baker proposed a change to openstack-dev/devstack: A service to install diskimage-builder  https://review.openstack.org/9225604:47
openstackgerritSteve Baker proposed a change to openstack-dev/devstack: WIP enable building test image  https://review.openstack.org/9561704:47
openstackgerritSteve Baker proposed a change to openstack-dev/devstack: Utility functions for building test images  https://review.openstack.org/9561604:47
openstackgerritSteve Baker proposed a change to openstack-dev/devstack: Build an image for heat functional tests  https://review.openstack.org/11081904:47
*** ildikov has quit IRC04:51
openstackgerritA change was merged to openstack-dev/devstack: Add swift tempurl support to devstack  https://review.openstack.org/11209504:51
*** rfolco has quit IRC04:54
*** flwang_ has joined #openstack-qa04:57
*** yfried__ has joined #openstack-qa04:59
*** flwang_ has quit IRC05:01
openstackgerritA change was merged to openstack-dev/devstack: Work around pip installed pkgs on Rackspace image  https://review.openstack.org/11164605:07
*** Krast has quit IRC05:31
*** zz_dimtruck is now known as dimtruck05:34
*** jamielennox is now known as jamielennox|away05:35
*** rfolco has joined #openstack-qa05:38
*** Longgeek has joined #openstack-qa05:40
*** dimtruck is now known as zz_dimtruck05:44
*** Sukhdev has quit IRC05:46
*** ildikov has joined #openstack-qa05:53
*** dims has joined #openstack-qa05:54
*** dims has quit IRC05:58
*** Krast has joined #openstack-qa06:09
openstackgerritA change was merged to openstack-dev/devstack: Add keepalived, conntrackd as dependencies  https://review.openstack.org/11067906:16
*** marun has quit IRC06:20
*** marun has joined #openstack-qa06:20
*** pcrews has joined #openstack-qa06:40
openstackgerritMarc Koderer proposed a change to openstack/tempest: Allow dict's as schema definitions  https://review.openstack.org/11256606:43
openstackgerritMarc Koderer proposed a change to openstack/tempest: Convert request schema (flavors)  https://review.openstack.org/11257006:46
openstackgerritMarc Koderer proposed a change to openstack/tempest: Convert request schema (flavors_admin)  https://review.openstack.org/11278306:46
openstackgerritMarc Koderer proposed a change to openstack/tempest: Convert request schema (servers)  https://review.openstack.org/11378706:46
mkodererandreaf: good morning.. did you ever tried the rebase button in gerrit?06:47
*** salv-orlando has joined #openstack-qa06:56
*** salv-orlando has quit IRC06:57
*** flwang_ has joined #openstack-qa06:58
*** salv-orlando has joined #openstack-qa07:02
*** flwang_ has quit IRC07:02
*** salv-orlando has quit IRC07:03
*** marun has quit IRC07:03
*** wuhg has joined #openstack-qa07:03
*** markus_z has joined #openstack-qa07:12
*** salv-orlando has joined #openstack-qa07:13
*** salv-orlando has quit IRC07:13
*** salv-orlando has joined #openstack-qa07:14
*** salv-orlando has quit IRC07:16
openstackgerritA change was merged to openstack-dev/devstack: Hide output when configuring apt retry  https://review.openstack.org/10353907:16
*** tkammer has joined #openstack-qa07:16
*** gszasz has joined #openstack-qa07:26
*** gszasz has quit IRC07:29
*** gszasz has joined #openstack-qa07:29
andreafmkoderer: I did some time ago - and it seemed to work, but I usually prefer to do rebase from my workstation07:31
*** zz_dimtruck is now known as dimtruck07:34
*** andreaf_ has joined #openstack-qa07:35
*** jlanoux has joined #openstack-qa07:35
*** andreaf_ has quit IRC07:36
*** Longgeek has quit IRC07:37
*** Longgeek has joined #openstack-qa07:37
*** andreaf_ has joined #openstack-qa07:38
*** andreaf has quit IRC07:38
*** andreaf_ is now known as andreaf07:38
*** andreaf has quit IRC07:39
*** andreaf has joined #openstack-qa07:39
*** Longgeek has quit IRC07:42
*** dimtruck is now known as zz_dimtruck07:44
*** markus_z has quit IRC07:47
*** Longgeek has joined #openstack-qa07:51
*** jpich has joined #openstack-qa08:00
*** qba73 has joined #openstack-qa08:10
*** jlibosva has joined #openstack-qa08:22
openstackgerritLakshmi N Sampath proposed a change to openstack/tempest: Glance Metadata Definitions Catalog - Tempest tests  https://review.openstack.org/11363208:26
*** yamahata has quit IRC08:43
mkodererandreaf: ok so I had to rebase https://review.openstack.org/#/c/112566/08:43
mkodererjenkins is already through08:43
*** Longgeek has quit IRC08:48
*** Dafna has quit IRC08:49
*** Longgeek has joined #openstack-qa08:50
*** Longgeek has quit IRC08:52
*** dmellado has quit IRC08:52
*** Longgeek has joined #openstack-qa08:53
*** Dafna has joined #openstack-qa08:59
*** flwang_ has joined #openstack-qa08:59
*** flwang_ has quit IRC09:03
shardymtreinish: I gave up on https://review.openstack.org/#/c/90143 because of slow reviews, the fact that it kept breaking between constant rebases, and the fact that it should have an easier and less frustrating path via stevebaker's proposal for in-tree functional tests09:10
shardyI have to say, it's been a hugely demotivating process with that particular patch09:10
mkoderershardy: did we discuss about this patch in a qa meeting before?09:14
shardymkoderer: I guess not, I didn't know I had to show up to the meeting to get reviews :\09:14
shardyAnyway, IMO the move to scenario tests in project trees will work out better for everyone :)09:15
mkoderershardy: so usualy you don't need to be in the qa meeting but if you have such patches it's might the fastest way09:15
mkoderersince many cores are around during that time09:15
shardymkoderer: Ok, useful info, thanks09:16
mkoderershardy: https://wiki.openstack.org/wiki/Meetings/QATeamMeeting09:16
mkodererwe usualy have a topic called "critical reviews"09:16
mkoderershardy: sry that the review time is sometimes quite high..09:18
*** jyuso has quit IRC09:18
shardymkoderer: No worries, we have the same issue with Heat review backlog, so I do understand09:18
shardyMy frustration with that patch is that it was designed to catch a real regression which happened, which then happened again09:19
openstackgerritYair Fried proposed a change to openstack/tempest: Adds status check for FloatingIP in scenarios  https://review.openstack.org/10270009:22
yfried__andreaf: do you have a better idea instead of copy-pasting those waiters https://review.openstack.org/#/c/102700/9/tempest/common/waiters.py,cm ?09:23
yfried__andreaf: or is this outside of the scope for now?09:23
*** Longgeek has quit IRC09:35
*** gmann has quit IRC09:37
openstackgerritChristian Berendt proposed a change to openstack-dev/devstack: Remove code tagged as "can be removed after Icehouse"  https://review.openstack.org/11170309:44
*** Longgeek has joined #openstack-qa09:47
*** cdent has joined #openstack-qa09:48
*** tosky has joined #openstack-qa09:51
*** Krast has quit IRC09:56
*** salv-orlando has joined #openstack-qa10:17
*** dims has joined #openstack-qa10:25
*** jhenner has joined #openstack-qa10:27
*** Longgeek has quit IRC10:30
*** dims has quit IRC10:32
*** asselin has quit IRC10:34
*** kmartin has quit IRC10:41
coolsvapyfried__, hi u thr?10:50
yfried__coolsvap: for now10:51
coolsvapyfried__, just need a min regarding your comments for cinder qos patch10:51
coolsvapyfried__, the expected status comment10:51
*** dmellado has joined #openstack-qa10:51
coolsvapyfried__, i checked the patch before updating the client10:52
coolsvapyfried__,  https://review.openstack.org/#/c/101310/3/tempest/services/image/v1/json/image_client.py10:52
yfried__coolsvap: yeah?10:52
yfried__coolsvap: I'm sorry10:53
yfried__coolsvap: I talked with dkranz and he said they are ok with how you did it (for now) so ignore that one10:53
openstackgerritSwapnil Kulkarni proposed a change to openstack/tempest: Adds the clients and tests for CINDER QoS V1 & V2 APIs  https://review.openstack.org/9030610:54
*** jlanoux has quit IRC10:55
coolsvapyfried__, is the dvsm-large-ops issue sorted out?10:56
coolsvapcouple of my patches failed due to not able to download packages on node10:57
coolsvapyfried__, do you have any update10:57
*** gszasz has quit IRC10:57
*** flwang_ has joined #openstack-qa11:00
*** Longgeek has joined #openstack-qa11:00
*** flwang_ has quit IRC11:04
*** dims has joined #openstack-qa11:06
*** dims has quit IRC11:12
*** dims has joined #openstack-qa11:12
openstackgerritIhar Hrachyshka proposed a change to openstack-dev/devstack: Install sqlalchemy-migrate from master if requested  https://review.openstack.org/11422411:22
openstackgerritIhar Hrachyshka proposed a change to openstack-dev/devstack: (DO NOT MERGE) test run using mysqlconnector  https://review.openstack.org/11420711:22
openstackgerritIhar Hrachyshka proposed a change to openstack-dev/devstack: Add ability to switch database driver  https://review.openstack.org/10520911:22
*** SridharG has joined #openstack-qa11:27
*** lordd_ has quit IRC11:27
*** Longgeek_ has joined #openstack-qa11:34
*** Longgeek has quit IRC11:37
*** SridharG has quit IRC11:37
*** aix has joined #openstack-qa11:38
*** aix has quit IRC11:40
*** aix has joined #openstack-qa11:40
openstackgerritDaniel Berrange proposed a change to openstack-dev/devstack: libvirt: display warning message if firewalld is enabled  https://review.openstack.org/11451311:56
*** ildikov has quit IRC11:56
*** ildikov has joined #openstack-qa11:58
*** nmagnezi has joined #openstack-qa12:05
*** yfried__ has quit IRC12:17
*** amotoki has quit IRC12:17
*** afazekas has joined #openstack-qa12:19
*** rfolco has quit IRC12:26
*** rfolco has joined #openstack-qa12:26
*** adalbas has joined #openstack-qa12:26
*** dkranz has joined #openstack-qa12:31
*** nosnos has quit IRC12:37
ianwjroll: looks like that merge failed, i'll try to check on it tomorrow if you get it past jenkins12:39
*** gszasz has joined #openstack-qa12:45
*** aysyd has joined #openstack-qa12:51
*** aix has quit IRC12:55
openstackgerritAndrea Frittoli  proposed a change to openstack/tempest: Add Credentials Provider factory  https://review.openstack.org/10768512:56
*** aix has joined #openstack-qa12:57
*** nmagnezi has quit IRC13:00
*** andreaf_ has joined #openstack-qa13:01
*** flwang_ has joined #openstack-qa13:01
*** jaypipes is now known as leakypipes13:03
*** andreaf has quit IRC13:03
*** dpaterson has joined #openstack-qa13:03
*** dustins has joined #openstack-qa13:04
*** timello_ has joined #openstack-qa13:05
*** flwang_ has quit IRC13:05
*** andreaf_ has quit IRC13:06
*** andreaf_ has joined #openstack-qa13:06
*** wuhg has quit IRC13:08
*** johnthetubaguy has quit IRC13:09
*** wuhg has joined #openstack-qa13:10
*** dims_ has joined #openstack-qa13:13
*** pcrews_ has joined #openstack-qa13:15
openstackgerritgordon chung proposed a change to openstack-dev/devstack: enable multiple collector workers  https://review.openstack.org/10905813:18
*** dims has quit IRC13:20
*** jpich has quit IRC13:20
*** pcrews has quit IRC13:20
*** mriedem has joined #openstack-qa13:23
*** zz_johnthetubagu has joined #openstack-qa13:25
*** zz_johnthetubagu is now known as johnthetubaguy13:25
*** jpich has joined #openstack-qa13:26
*** dansmith is now known as superdan13:31
*** timello_ has quit IRC13:32
*** timello_ has joined #openstack-qa13:33
*** jlanoux has joined #openstack-qa13:35
*** mkollaro has joined #openstack-qa13:37
*** andreaf_ is now known as andreaf13:42
*** tkammer has quit IRC13:42
andreafsalv-orlando: hi - have you seen this failure on neutron full before? http://paste.openstack.org/show/95572/13:43
*** cdent_ has joined #openstack-qa13:43
*** cdent has quit IRC13:45
*** cdent_ is now known as cdent13:45
salv-orlandoandreaf: yes it was fixed on Aug 13th -> https://review.openstack.org/#/c/113554/13:47
andreafsalv-orlando: ok thanks - so on rebase it should go away from here: https://review.openstack.org/#/c/101381/813:48
openstackgerritIhar Hrachyshka proposed a change to openstack-dev/devstack: Install sqlalchemy-migrate from master if requested  https://review.openstack.org/11422413:48
openstackgerritIhar Hrachyshka proposed a change to openstack-dev/devstack: (DO NOT MERGE) test run using mysqlconnector  https://review.openstack.org/11420713:48
openstackgerritIhar Hrachyshka proposed a change to openstack-dev/devstack: Add ability to switch database driver  https://review.openstack.org/10520913:48
andreafsalv-orlando: I was about to approve the change when I saw the failure and I was worried - it should be fine then, thank you13:48
*** rbak has joined #openstack-qa13:53
openstackgerritChoonho Son proposed a change to openstack/tempest: Fix QuotaClassesAdminTest to call V3 API  https://review.openstack.org/11453713:59
*** cpallares has joined #openstack-qa14:00
*** jgrimm has joined #openstack-qa14:01
*** markmcclain has joined #openstack-qa14:03
*** yfried__ has joined #openstack-qa14:07
yfried__coolsvap: no idea what you were talking about14:07
yfried__salv-orlando: don't bother with the gate on the Floating IP status. it's based on a few unstable patches that need to be merged first14:08
*** dpaterson has quit IRC14:11
*** markmcclain1 has joined #openstack-qa14:13
salv-orlandoyfried__: it was not about the gate, but about minesweeper CI. I found a bug related to that -> https://review.openstack.org/#/c/114504/14:13
salv-orlandoonce that merges, vmware CI should pass.14:13
*** zz_dimtruck is now known as dimtruck14:14
*** markmcclain has quit IRC14:15
*** jecarey has joined #openstack-qa14:26
*** mitz has quit IRC14:27
*** tkammer has joined #openstack-qa14:30
andreafmtreinish: https://review.openstack.org/#/c/107685/ for test-accounts is now passing CI14:32
*** dimtruck is now known as zz_dimtruck14:32
mtreinishandreaf: ok I'll take a look14:33
andreafmtreinish: thanks14:34
mtreinishI'm thinking it might be worthwhile to put a hardcoded test patch on top of it just to see how if it will work at all14:34
andreafmtreinish: uhm right with a yaml file and config settings?14:34
mtreinishyeah something like that, it might be too tricky todo14:35
mtreinishI'm just thinking we've written all this code14:35
andreafmtreinish: config settings won't be enough as devstack sets allow_tenant_isolation true, but I can change the code if allow_tenant_isolation true use the new approach14:35
mtreinishand only unit tested it14:35
mtreinishandreaf: yeah that, or you could just inline setting the value of allow_tenant_isolation to false14:36
openstackgerritafazekas proposed a change to openstack-infra/devstack-gate: Fix ssh key specification in the README.rst  https://review.openstack.org/11455314:36
andreafmtreinish: ok - good idea14:36
andreafmtreinish: is the periodic job running with tenant_isolation off?14:37
mtreinishandreaf: I believe we have one or 2 periodic jobs that run without tenant isolation14:38
*** dims_ is now known as dimsum14:40
*** dimsum is now known as dimsum_14:40
openstackgerritChristian Berendt proposed a change to openstack-dev/devstack: Remove code tagged as "can be removed after Icehouse"  https://review.openstack.org/11170314:40
andreafmtreinish: so I would need to create some more accounts on the fly - else it won't work very well14:42
*** ildikov has quit IRC14:43
ShrewsAny possibility of getting one more tempest core to review https://review.openstack.org/94439 today? andreaf? dkranz?14:45
ShrewsWould love to see that merged before vacation next week  :)14:45
openstackgerritJim Rollenhagen proposed a change to openstack-dev/devstack: Add ironic-python-agent support to devstack  https://review.openstack.org/10845714:45
mtreinishandreaf: yeah that's what I figured which is why I thought it might be too complicated to do in a test patch14:45
jrolldtroyer, ianw, ^^ not sure how I messed up that rebase last night :P14:45
mtreinishtoo many other pieces are missing14:45
andreafShrews: nice test - I'll take a look later today14:46
Shrewsandreaf: thank you very much14:46
*** rbak has quit IRC14:47
openstackgerritgordon chung proposed a change to openstack-dev/devstack: enable multiple collector workers  https://review.openstack.org/10905814:51
*** rbak has joined #openstack-qa14:52
*** zhiyan has quit IRC14:53
*** zhiyan has joined #openstack-qa14:54
openstackgerritA change was merged to openstack/tempest: Allow dict's as schema definitions  https://review.openstack.org/11256614:54
*** atiwari has joined #openstack-qa14:54
*** zz_dimtruck is now known as dimtruck14:58
*** flwang_ has joined #openstack-qa15:02
*** ildikov has joined #openstack-qa15:06
*** atiwari has quit IRC15:06
*** flwang_ has quit IRC15:06
*** mestery is now known as mestery_afk15:10
dkranzShrews: I found two small things to fix and will then +215:13
openstackgerritDolph Mathews proposed a change to openstack-infra/elastic-recheck: ade query for nova quota reservation deadlock  https://review.openstack.org/11456615:14
Shrewsdkranz: ok, thx15:14
openstackgerritDolph Mathews proposed a change to openstack-infra/elastic-recheck: add query for bug 1316926  https://review.openstack.org/10293215:16
coolsvapdkranz, hi15:18
dkranzcoolsvap: hi15:19
coolsvapdkranz, can you have a look at https://review.openstack.org/#/c/90306/15:19
*** mkollaro has quit IRC15:19
openstackgerritIhar Hrachyshka proposed a change to openstack-dev/devstack: (DO NOT MERGE) test run using mysqlconnector  https://review.openstack.org/11420715:19
dkranzcoolsvap: ok15:20
openstackgerritDolph Mathews proposed a change to openstack-infra/elastic-recheck: Add query for bin/pip suddenly missing  https://review.openstack.org/11136115:23
*** atiwari has joined #openstack-qa15:27
*** yfried__ has quit IRC15:31
Shrewsdkranz: good comments. however, can i get you to clarify "parameter default should not be mutable" ?15:32
mtreinishShrews: I think he was referring to: https://review.openstack.org/#/c/100132/15:33
dkranzShrews: I only learned this recently, but apparently when you say x={} in a function signature, Python treats the {} as a module global15:33
mtreinishor something like that15:33
Shrewsah15:34
dkranzShrews: so if any code that receives this value were to modify it, it would change the meaning of the signature15:34
dkranzShrews: I consider this to be a bug in Python15:34
dkranzShrews: BUt others obviously differ :)15:34
*** andreaf has quit IRC15:35
*** andreaf has joined #openstack-qa15:36
*** andreaf has quit IRC15:36
*** andreaf has joined #openstack-qa15:37
openstackgerritAndrea Frittoli  proposed a change to openstack/tempest: Force use of Accounts for test purposes  https://review.openstack.org/11457815:39
*** mriedem is now known as mattykins15:41
openstackgerritDavid Shrewsbury proposed a change to openstack/tempest: Add ironic instance rebuild test  https://review.openstack.org/9443915:41
andreafmtreinish: first attempt https://review.openstack.org/#/c/11457815:41
*** mattykins is now known as matty_kins15:41
*** jpich has quit IRC15:42
Shrewsdkranz: mtreinish: ^^^ that should address dkranz's comments on 94439. thanks!15:43
*** jpich has joined #openstack-qa15:43
mtreinishandreaf: heh, that's a clever approach if the yaml doesn't exist generate one with 8 accounts using tenant isolation15:44
mtreinishI like that15:44
*** dpaterson has joined #openstack-qa15:45
andreafmtreinish: hopefully it works :)15:46
*** jlanoux has quit IRC15:47
*** markmcclain1 has quit IRC15:48
andreafdkranz, are you already on https://review.openstack.org/94439 ?15:49
*** aix has quit IRC15:49
dkranzandreaf: Yes, I found a few issues and there is a new patch up.15:49
dkranzandreaf: I'm looking at it now15:49
andreafdkranz, ok thanks15:50
*** wuhg has quit IRC15:52
*** dustins has quit IRC15:57
dkranzandreaf: I am also reviewing https://review.openstack.org/#/c/90306/27/tempest/api/volume/base.py,unified which will collide with the multi-user auth stuff. Should this patch go in before yours? You will have to change the new Base class in this file.15:59
*** dustins has joined #openstack-qa15:59
*** asselin has joined #openstack-qa16:00
*** bnemec is now known as beekneemech16:01
*** aix has joined #openstack-qa16:02
andreafdkranz: yes I have seen this one but could not complete a full review yet :) I think it can go first - only I don't like the fact that it reads CONF for account details, it shouldn't do that anyways - but I suppose we could leave that as it is, I will have to change it anyways with the test-accounts stuff16:04
dkranzandreaf: Agreed16:05
dkranzandreaf: Are you going to finish reviewing it?16:05
dkranzandreaf: A cinder domain-expert review might be useful16:06
andreafdkranz: I reviewed it in the past, I'm going to have a look at the new patchset - I would not define myself a cinder expert though16:08
*** jlibosva has quit IRC16:09
*** leakypipes is now known as leakypipes-codin16:14
*** leakypipes-codin is now known as leakypipes16:15
coolsvapdkranz, I am picking up the client status changes for volume clients, I will push some patches over the weekend16:17
coolsvaps/patches/reviews16:17
openstackgerritafazekas proposed a change to openstack/tempest: Remove not used server creation from test_server_rescue  https://review.openstack.org/11459216:20
*** markmcclain has joined #openstack-qa16:22
*** comstud is now known as bearhands16:26
*** markmcclain has quit IRC16:27
*** jogo is now known as flashgordon16:28
*** aimon has quit IRC16:32
*** jpich has quit IRC16:37
*** dimtruck is now known as zz_dimtruck16:40
*** aix has quit IRC16:41
*** zz_dimtruck is now known as dimtruck16:42
*** markmcclain has joined #openstack-qa16:44
*** markmcclain has quit IRC16:47
*** markmcclain has joined #openstack-qa16:47
*** markmcclain has quit IRC16:48
*** markmcclain has joined #openstack-qa16:49
*** aimon has joined #openstack-qa16:49
*** markmcclain has quit IRC16:51
*** dimsum_ has quit IRC16:55
*** aix has joined #openstack-qa16:56
andreafmtreinish: something's wrong with lock_path16:56
andreafmtreinish: http://logs.openstack.org/78/114578/1/check/check-tempest-dsvm-full/df8d8e6/logs/testr_results.html.gz16:57
andreafmtreinish: until now lock_path has only been used in unit tests, and there a default value is set in fake_config16:57
*** dims has joined #openstack-qa16:58
*** openstackgerrit has quit IRC17:02
*** openstackgerrit has joined #openstack-qa17:02
*** flwang_ has joined #openstack-qa17:03
openstackgerritAndrea Frittoli  proposed a change to openstack/tempest: Add Credentials Provider factory  https://review.openstack.org/10768517:03
openstackgerritAndrea Frittoli  proposed a change to openstack/tempest: Force use of Accounts for test purposes  https://review.openstack.org/11457817:03
*** harlowja_away is now known as harlowja17:03
andreafmtreinish: addressed your comments and fixed pep8 in 114578 - but until the lock_path issue is solved the test change won't tell us much more17:04
*** suneelb has joined #openstack-qa17:05
*** flwang_ has quit IRC17:07
*** dustins has quit IRC17:09
*** gszasz has quit IRC17:14
*** dustins has joined #openstack-qa17:15
*** dustins has quit IRC17:16
*** dustins has joined #openstack-qa17:17
*** dustins has quit IRC17:22
*** qba73 has quit IRC17:22
*** qba73 has joined #openstack-qa17:23
*** aix has quit IRC17:23
andreafmtreinish: I think it's related to the config proxy - as far as I can tell the additional lock options are only loaded when the lock utils are imported - but they are not registered in the TempestConfigPrivate object17:24
*** qba73 has quit IRC17:25
*** qba73 has joined #openstack-qa17:28
*** qba73 has quit IRC17:28
*** matty_kins is now known as mriedem17:32
*** dustins has joined #openstack-qa17:34
*** dustins has quit IRC17:34
*** aix has joined #openstack-qa17:36
mtreinishandreaf: oh, yeah it's the proxy17:37
mtreinishwe've never accessed lock_path directly through the proxy before17:37
andreafmtreinish: so I am preparing a one line change that adds that to Private config17:37
mtreinishoslo lock uses it, but it doesn't go through the proxy17:38
mtreinishandreaf: ok cool17:38
andreafbut I wonder why the fixture works in aggregate tests17:38
andreafah ok you answered already17:38
openstackgerritAndrea Frittoli  proposed a change to openstack/tempest: Force use of Accounts for test purposes  https://review.openstack.org/11457817:40
openstackgerritAndrea Frittoli  proposed a change to openstack/tempest: Add lock_path to TempestPrivateConfig  https://review.openstack.org/11460917:40
andreafmtreinish: ^^^17:40
openstackgerritafazekas proposed a change to openstack-infra/elastic-recheck: Add query for 1357476  https://review.openstack.org/11461017:40
andreafmtreinish: actually I should have put the lock one on the bottom of the chain so it can merge alone but hopefully the whole thing will merge soon17:41
andreafmtreinish: so the test change was useful already17:42
mtreinishyep, and actually writing unit tests caught that17:42
mtreinishbut I hacked around it17:42
mtreinishandreaf: I'm wondering if it would be better to have a getattr fallback to the cfg.CONF object if the proxy returns AttributeError17:45
mtreinishbecause the next time we need to access an option in the default group this will pop up again17:45
*** krtaylor is now known as krtaylor_away17:46
*** dustins has joined #openstack-qa17:47
andreafmtreinish: yep makes sense I was a bit lazy wanted to see if it would work17:50
mtreinishthat's fine, but I'lll probably -1 it when the time for review comes :)17:51
mtreinishbut for testing in the meantime it's fine17:51
*** dims is now known as dimsum_17:52
*** dpaterson has quit IRC17:53
openstackgerritAndrea Frittoli  proposed a change to openstack/tempest: Add Credentials Provider factory  https://review.openstack.org/10768517:59
openstackgerritAndrea Frittoli  proposed a change to openstack/tempest: Force use of Accounts for test purposes  https://review.openstack.org/11457817:59
openstackgerritAndrea Frittoli  proposed a change to openstack/tempest: Supports DEFAULT group opts in TempestPrivateConfig  https://review.openstack.org/11460917:59
andreafmtreinish: ok I saw your message too late - I made a new patch-set18:00
openstackgerritgordon chung proposed a change to openstack-dev/devstack: enable multiple collector workers  https://review.openstack.org/10905818:00
*** catohornet has joined #openstack-qa18:00
*** dustins has quit IRC18:02
jrollso, a devstack patch broke ironic's gate, I'm pushing a fix now but just a heads up that it needs to be fast tracked: https://bugs.launchpad.net/devstack/+bug/135749518:03
*** catohornet has quit IRC18:03
openstackgerritJim Rollenhagen proposed a change to openstack-dev/devstack: Fix image create functions for Ironic  https://review.openstack.org/11461918:05
jroll^ there's the fix18:05
*** aix has quit IRC18:05
openstackgerritJim Rollenhagen proposed a change to openstack-dev/devstack: Add ironic-python-agent support to devstack  https://review.openstack.org/10845718:09
*** Longgeek_ has quit IRC18:12
*** marun has joined #openstack-qa18:15
*** dimtruck is now known as zz_dimtruck18:15
adam_gdid gate-tempest-pep8 only just recently start enforcing H305?18:16
*** marun has quit IRC18:17
mtreinishadam_g: yeah, sort of18:17
mtreinishwait which one is h30518:17
adam_gimport grouping (stdlib, thirdparty)18:18
*** marun has joined #openstack-qa18:18
mtreinishyeah, that one was baked into a larger fix I had re-enabling a bunch of rules we turned off after the hacking 0.9 update18:18
adam_gah18:18
adam_gmtreinish, any idea why i wouldnt be able to catch it locally?18:18
mtreinishI'm thinking I need to push through a patch to disable it18:18
mtreinishpython3 vs 2.7 in the gate?18:18
mtreinishthe patch also just landed yesterday18:19
mtreinishso you might not have had it in your tree18:19
adam_gdah18:21
adam_grebase fail18:21
openstackgerritMatthew Treinish proposed a change to openstack/tempest: Disable hacking rule H305  https://review.openstack.org/11462218:23
mtreinishadam_g, dkranz: ^^^18:23
openstackgerritAdam Gandelman proposed a change to openstack/tempest: Add new snapshot compute feature flag  https://review.openstack.org/10138118:23
adam_gdah!18:23
adam_gmtreinish, fixes H305 failures that just showed up ^ :)18:23
adam_gandreaf, ^18:24
*** andreaf_ has joined #openstack-qa18:27
andreaf_adam_g: +A18:29
adam_gandreaf, gratzi18:29
*** andreaf has quit IRC18:30
*** dustins has joined #openstack-qa18:30
adam_gdkranz, dtroyer anyone around to help fix a gate breaker? https://review.openstack.org/#/c/114619/18:34
dkranzadam_g: Sorry I don't have +2 on devstack18:35
adam_gdkranz, oh, sorry, thought you did18:36
dtroyeradam_g: +218:37
dkranzmtreinish: Gave +2. I guess the theoretical turned practical pretty fast...18:38
mtreinishheh, well I've see 3 things bounce off the gate because of it already18:38
dkranzmtreinish: ouch18:38
dkranzmtreinish, adam_g : I actually have to leave the keyboard now so will not be able to zap anything else today18:39
mtreinishdkranz: no worries, I'll also have to call it an early day myself shortly18:40
Shrewsmtreinish: one more look at 94439 before you leave today? the ironic job is failing due to the broken gate (passed in previous runs)18:41
mtreinishShrews: heh, sure18:42
Shrewsmtreinish: thx! simple change from previous patchset18:42
mtreinishShrews: +A18:43
Shrewsmtreinish: awesome! may your weekend be filled with rainbows and bunnies  :)18:44
Shrewsheck, even unicorns18:44
mtreinishthanks18:44
andreaf_mtreinish: question re extensions discovery vs. feature flags18:45
andreaf_mtreinish: e.g. https://review.openstack.org/#/c/98235 or https://review.openstack.org/#/c/112474/18:46
andreaf_mtreinish: tests may check if an extension is loaded and skip if not - or we may rely on extension discovery - what's your opinion on this?18:47
mtreinishandreaf_: we should never poll the api to make a decision regarding skipping a test18:48
mtreinishwe should use the config file to specify whether the extension exists or not18:48
andreaf_mtreinish: what is the rationale?18:49
andreaf_for instance in https://review.openstack.org/#/c/112474/ it's not about skipping the whole test, it's about allowing additional quota items18:49
andreaf_while in https://review.openstack.org/#/c/98235 it's about skipping the test18:50
andreaf_are you worried about the discovery being broken?18:50
mtreinishthe api for feature discovery could have bugs (it's happened several times before) in which case we skip when we didn't mean to18:50
mtreinishandreaf_: yeah, it used to happen more than we realized18:50
mtreinishand we were just skipping tests and didn't realize it18:50
mtreinishand bugs slipped through18:50
andreaf_ok thanks18:51
mtreinishactually I need to add this point to https://review.openstack.org/#/c/99451/2/REVIEWING.rst18:51
andreaf_mtreinish: yes please18:52
andreaf_mtreinish: btw, another issue found by the test change for test-accounts http://logs.openstack.org/78/114578/4/check/check-tempest-dsvm-full/0d168ac/logs/testr_results.html.gz18:52
mtreinishdoh, s/self.credentials/self.isolated_creds18:54
mtreinishthis stack of fixes is getting larger and larger18:54
mtreinishandreaf_: oops you beat me to the comment on 9823518:55
*** aysyd has quit IRC18:56
andreaf_mtreinish: I was almost done reviewing it anyways18:58
andreaf_mtreinish: week-end time for me18:58
openstackgerritA change was merged to openstack-infra/elastic-recheck: Add query for test_postgresql_opportunistically bug 1355929  https://review.openstack.org/11358118:58
andreaf_mtreinish: if you have time for test-accounts for scenario migration patches reviews it would be great18:58
andreaf_mtreinish: have a great weekend18:58
mtreinishsure, I'll try to take a look18:59
mtreinishyeah you too, enjoy18:59
*** cdent has quit IRC19:00
*** jhenner has quit IRC19:02
openstackgerritMatthew Treinish proposed a change to openstack/tempest: Add REVIEWING.rst  https://review.openstack.org/9945119:03
mtreinishandreaf_: ^^^19:03
*** flwang_ has joined #openstack-qa19:04
*** zz_dimtruck is now known as dimtruck19:05
*** tosky has quit IRC19:07
*** tkammer has quit IRC19:07
*** flwang_ has quit IRC19:08
*** jhenner has joined #openstack-qa19:09
*** jhenner has quit IRC19:12
openstackgerritDean Troyer proposed a change to openstack-dev/devstack: Remove firewalld on Fedora 20 by default  https://review.openstack.org/11385619:22
openstackgerritDean Troyer proposed a change to openstack-dev/devstack: Source fixup_stuff...  https://review.openstack.org/11463519:22
openstackgerritMatthew Treinish proposed a change to openstack/tempest: Add Credentials Provider factory  https://review.openstack.org/10768519:28
openstackgerritMatthew Treinish proposed a change to openstack/tempest: Force use of Accounts for test purposes  https://review.openstack.org/11457819:28
openstackgerritMatthew Treinish proposed a change to openstack/tempest: Fix use of nonexistent class variable in accounts.py  https://review.openstack.org/11463619:28
openstackgerritLakshmi N Sampath proposed a change to openstack/tempest: Glance Metadata Definitions Catalog - Tempest tests  https://review.openstack.org/11363219:45
*** mlavalle has joined #openstack-qa19:45
mriedemafazekas: https://review.openstack.org/#/c/114610/ needs a small tweak, then i'll approve19:46
*** SergeyLukjanov has quit IRC19:52
*** DinaBelova has quit IRC19:52
openstackgerritafazekas proposed a change to openstack-infra/elastic-recheck: Add query for 1357476  https://review.openstack.org/11461019:52
afazekasmriedem: ok19:52
mriedemafazekas: thanks19:53
*** danfinch has quit IRC19:53
*** chmouel has quit IRC19:57
*** DinaBelova has joined #openstack-qa19:58
*** chmouel has joined #openstack-qa19:58
*** SergeyLukjanov has joined #openstack-qa20:00
*** DinaBelova has quit IRC20:07
*** DinaBelova has joined #openstack-qa20:09
*** notmyname has quit IRC20:10
*** chmouel has quit IRC20:10
*** mriedem1 has joined #openstack-qa20:11
*** notmyname has joined #openstack-qa20:11
*** mriedem1 has quit IRC20:11
*** mriedem1 has joined #openstack-qa20:12
*** mriedem has quit IRC20:13
*** chmouel has joined #openstack-qa20:15
openstackgerritJoe Gordon proposed a change to openstack-infra/elastic-recheck: Add query for bin/pip suddenly missing  https://review.openstack.org/11136120:20
openstackgerritA change was merged to openstack-infra/elastic-recheck: Add query for 1357476  https://review.openstack.org/11461020:21
*** cpallares has quit IRC20:21
flashgordonmtreinish: https://review.openstack.org/#/c/109144/ want to an e-r review?20:22
Shrewsjeblair: around?20:26
Shrewsor ianw?20:27
Shrewsor chmouel?  :)  we need a devstack change approved to fix ironic gate: https://review.openstack.org/11461920:27
jeblairShrews: hullo20:28
Shrewshowdy20:28
Shrewsjeblair: tl;dr ... a recent devstack change broke us (never passed ironic test). that change above fixes us20:29
jeblairShrews: can you point me to the breaking devstack change?20:29
Shrewscertainly. 1 sec20:29
Shrewsjeblair: https://review.openstack.org/#/c/111538/20:30
jrollwe need voting jobs already :(20:30
openstackgerritA change was merged to openstack-infra/elastic-recheck: Add query for neutron subnet delete race bug 1357055  https://review.openstack.org/11435920:30
*** danfinch has joined #openstack-qa20:30
jeblairShrews: so there's a behavior change between glance image-create and openstack image create?20:31
Shrewsjeblair: apparently  :(20:31
jrolljeblair: afaict, glance client will guess the container format, openstack client will not20:31
*** dustins has quit IRC20:32
jeblairShrews, jroll: why did the ironic-nv and ironic-postgres-nv jobs pass?20:32
chmouelShrews: will look20:32
Shrewsjeblair: iirc, they only test ironic API behavior while still using libvirt20:33
Shrewsjeblair: we are merging these tests, fwiw20:33
chmoueli was indeed thinkin the same question as jeblair20:33
adam_ghttps://review.openstack.org/#/c/112134/ should clarify all that20:34
Shrewsthx adam_g20:34
jeblairoh neat20:34
chmouelcool adam_g20:34
chmouelShrews: +2A20:35
Shrewsawesome-sauce. muchas gracias20:35
jrollthanks chmouel and jeblair :)20:35
jeblairnp20:36
jeblairianw, dtroyer: probably worth drawing your attention to https://review.openstack.org/#/c/111538/1 which had an actual failure on a non-voting job20:36
openstackgerritA change was merged to openstack-infra/elastic-recheck: Add query for bin/pip suddenly missing  https://review.openstack.org/11136120:37
jrolljeblair: that made me especially sad since it was lib/ironic being changed there20:40
jroll:(20:40
dtroyerjroll, jeblair: yes, very unfortunate, I should have caught that.  especially since the behaviour change is in OSC where it sets default values for —container-format and —disk-format…   my apologies20:42
jrollit happens, luckily the ironic team is super quiet today :P20:43
openstackgerritLakshmi N Sampath proposed a change to openstack/tempest: Glance Metadata Definitions Catalog - Tempest tests  https://review.openstack.org/11363220:43
jrolldtroyer: mind re-reviewing this while you're around? had to rebase https://review.openstack.org/#/c/108457/20:43
dtroyerjroll: sure...20:45
jrollnice, thank you! :)20:46
openstackgerritA change was merged to openstack-infra/elastic-recheck: Add query for a rescue related failure  https://review.openstack.org/11254920:47
*** rwsu has quit IRC20:51
openstackgerritDean Troyer proposed a change to openstack-dev/devstack: Fix missing --container-format options  https://review.openstack.org/11465820:55
dtroyerchmouel: if you're still around, https://review.openstack.org/114658 completes the fix for the image create command changes for baremetal20:57
*** flwang_ has joined #openstack-qa21:05
*** flwang_ has quit IRC21:09
*** leakypipes has quit IRC21:15
*** atiwari has quit IRC21:16
andreaf_mtreinish: ping - are you still around? I'm back online for a couple of minutes - I left a comment on https://review.openstack.org/#/c/114636 with another fix to be added21:27
*** andreaf_ has quit IRC21:37
*** jecarey has quit IRC21:38
openstackgerritClark Boylan proposed a change to openstack-infra/devstack-gate: Allow for grenade upgrades within a release  https://review.openstack.org/11109421:39
*** mriedem1 has quit IRC21:41
*** catohornet has joined #openstack-qa21:43
*** arnaud__ has joined #openstack-qa21:45
*** coolsvap has quit IRC21:50
openstackgerritDanny Al-Gaaf proposed a change to openstack/tempest: Use python abc in StressAction class  https://review.openstack.org/11382021:54
openstackgerritA change was merged to openstack-infra/elastic-recheck: add query for lbaas create member fail AttributeError  https://review.openstack.org/11432522:02
openstackgerritJoe Gordon proposed a change to openstack-infra/elastic-recheck: Remove fingerprint for bug 1333410  https://review.openstack.org/11467422:03
flashgordonmtreinish: ^22:03
*** coolsvap has joined #openstack-qa22:05
openstackgerritJoe Gordon proposed a change to openstack-infra/elastic-recheck: Remove queries for fixed bugs  https://review.openstack.org/11467622:08
openstackgerritDanny Al-Gaaf proposed a change to openstack/tempest: Use python abc in DeletableResource class  https://review.openstack.org/11385022:10
*** dimsum_ has quit IRC22:16
*** dimsum_ has joined #openstack-qa22:16
*** markmcclain has joined #openstack-qa22:19
*** dimsum_ has quit IRC22:20
*** dimsum_ has joined #openstack-qa22:26
*** dimsum_ has quit IRC22:26
*** dimsum_ has joined #openstack-qa22:26
*** dimsum_ has quit IRC22:28
*** dimsum_ has joined #openstack-qa22:28
openstackgerritJoe Gordon proposed a change to openstack-infra/elastic-recheck: Add fingerprint for nova unit test bug 1357578  https://review.openstack.org/11468022:30
*** dimsum_ has quit IRC22:30
*** dimsum_ has joined #openstack-qa22:30
openstackgerritA change was merged to openstack/tempest: Add ironic instance rebuild test  https://review.openstack.org/9443922:33
*** dimsum_ has quit IRC22:46
*** dimsum_ has joined #openstack-qa22:47
*** dimsum_ has quit IRC22:51
*** Sukhdev has joined #openstack-qa22:57
*** dimsum_ has joined #openstack-qa23:04
*** flwang_ has joined #openstack-qa23:05
*** rwsu has joined #openstack-qa23:06
*** morganfainberg is now known as morganfainberg_Z23:07
*** dimsum_ has quit IRC23:10
*** dimsum_ has joined #openstack-qa23:10
*** flwang_ has quit IRC23:10
*** tkammer has joined #openstack-qa23:12
ianwjeblair: mea culpa on that, i didn't notice that failure sorry23:13
*** dimsum_ has quit IRC23:15
openstackgerritRamy Asselin proposed a change to openstack-dev/devstack: Allow cinder types to be created without be file  https://review.openstack.org/11469323:22
*** dimtruck is now known as zz_dimtruck23:33
*** markmcclain has quit IRC23:35
*** rwsu has quit IRC23:35
*** tkammer has quit IRC23:50

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!