| *** asalkeld has quit IRC | 00:00 | |
| openstackgerrit | Brant Knudson proposed a change to openstack-dev/devstack: Change httpd Keystone access log to keystone_access.log https://review.openstack.org/116133 | 00:02 |
|---|---|---|
| openstackgerrit | Brant Knudson proposed a change to openstack-dev/devstack: Include Keystone access log in key screen https://review.openstack.org/116134 | 00:02 |
| openstackgerrit | Brant Knudson proposed a change to openstack-infra/devstack-gate: Stash Apache httpd logs https://review.openstack.org/116404 | 00:10 |
| *** dmorita has joined #openstack-qa | 00:24 | |
| *** mitz has joined #openstack-qa | 00:37 | |
| *** nosnos has joined #openstack-qa | 00:45 | |
| *** nosnos has quit IRC | 00:58 | |
| *** nosnos has joined #openstack-qa | 01:01 | |
| *** mitz has quit IRC | 01:01 | |
| *** mitz has joined #openstack-qa | 01:04 | |
| *** lordd_ has joined #openstack-qa | 01:05 | |
| *** lordd_ has quit IRC | 01:09 | |
| *** mitz has quit IRC | 01:13 | |
| *** mitz has joined #openstack-qa | 01:16 | |
| *** masayukig has quit IRC | 01:16 | |
| *** nosnos has quit IRC | 01:19 | |
| *** masayukig has joined #openstack-qa | 01:21 | |
| *** dimtruck is now known as zz_dimtruck | 01:21 | |
| *** nosnos has joined #openstack-qa | 01:22 | |
| *** nosnos has quit IRC | 01:24 | |
| openstackgerrit | Liping Mao proposed a change to openstack-dev/devstack: neutron metering default driver is noop https://review.openstack.org/116537 | 01:27 |
| *** jhenner has quit IRC | 01:35 | |
| *** jhenner has joined #openstack-qa | 01:35 | |
| *** yamahata has joined #openstack-qa | 01:44 | |
| *** nosnos has joined #openstack-qa | 01:51 | |
| *** oomichi has joined #openstack-qa | 01:52 | |
| *** topshare has joined #openstack-qa | 01:56 | |
| *** Poornima_ has joined #openstack-qa | 01:58 | |
| *** nosnos has quit IRC | 01:58 | |
| *** nosnos has joined #openstack-qa | 01:58 | |
| openstackgerrit | Liping Mao proposed a change to openstack-dev/devstack: neutron metering default driver is noop https://review.openstack.org/116537 | 01:58 |
| *** rbak has joined #openstack-qa | 02:04 | |
| *** adalbas has quit IRC | 02:04 | |
| *** rbak has quit IRC | 02:15 | |
| *** topshare has quit IRC | 02:16 | |
| *** jhenner has quit IRC | 02:26 | |
| *** jhenner has joined #openstack-qa | 02:26 | |
| *** SridharG has joined #openstack-qa | 02:32 | |
| openstackgerrit | Liping Mao proposed a change to openstack-dev/devstack: neutron metering default driver is noop https://review.openstack.org/116537 | 02:38 |
| *** dims has quit IRC | 02:44 | |
| *** dims has joined #openstack-qa | 02:47 | |
| *** dims has quit IRC | 02:47 | |
| *** Poornima_ has quit IRC | 02:51 | |
| *** topshare has joined #openstack-qa | 02:57 | |
| *** lordd_ has joined #openstack-qa | 03:05 | |
| *** lordd_ has quit IRC | 03:10 | |
| *** topshare has quit IRC | 03:13 | |
| *** cmyster has joined #openstack-qa | 03:15 | |
| *** zz_dimtruck is now known as dimtruck | 03:18 | |
| *** Poornima_ has joined #openstack-qa | 03:24 | |
| *** dimtruck is now known as zz_dimtruck | 03:28 | |
| *** dims has joined #openstack-qa | 03:48 | |
| *** jecarey has joined #openstack-qa | 03:50 | |
| *** dims has quit IRC | 03:53 | |
| *** SridharG has quit IRC | 04:05 | |
| *** cnesa7 has quit IRC | 04:14 | |
| *** Santosh has joined #openstack-qa | 04:25 | |
| openstackgerrit | Daisuke Morita proposed a change to openstack/tempest: Add a test for inline parameter of TempURL https://review.openstack.org/116546 | 04:28 |
| openstackgerrit | Daisuke Morita proposed a change to openstack/tempest: Add a test for deleting multiple objects by POST method https://review.openstack.org/116547 | 04:28 |
| openstackgerrit | Daisuke Morita proposed a change to openstack/tempest: Add a test for object PUT API with If-None-Match https://review.openstack.org/116548 | 04:28 |
| openstackgerrit | Daisuke Morita proposed a change to openstack/tempest: Add a test for new-style container-sync https://review.openstack.org/116549 | 04:28 |
| *** amotoki has joined #openstack-qa | 04:29 | |
| *** yfried has quit IRC | 04:31 | |
| *** nosnos has quit IRC | 04:32 | |
| *** nosnos has joined #openstack-qa | 04:33 | |
| *** Madan has joined #openstack-qa | 04:35 | |
| *** torandu has quit IRC | 04:39 | |
| *** torandu has joined #openstack-qa | 04:40 | |
| *** dims has joined #openstack-qa | 04:53 | |
| *** dims has quit IRC | 04:59 | |
| *** lordd_ has joined #openstack-qa | 05:06 | |
| *** flaper87|afk is now known as flaper87 | 05:10 | |
| *** lordd_ has quit IRC | 05:11 | |
| *** jecarey has quit IRC | 05:15 | |
| *** zz_dimtruck is now known as dimtruck | 05:19 | |
| openstackgerrit | Preethi Dsilva proposed a change to openstack/tempest: Added test to check DVR interface add using subnet https://review.openstack.org/113440 | 05:22 |
| *** dimtruck is now known as zz_dimtruck | 05:29 | |
| *** lordd_ has joined #openstack-qa | 05:33 | |
| *** yfried has joined #openstack-qa | 05:35 | |
| openstackgerrit | Swami Reddy proposed a change to openstack/tempest: Add "reboot_instance" EC2 API test case https://review.openstack.org/115944 | 05:40 |
| *** topshare has joined #openstack-qa | 05:42 | |
| *** topshare has quit IRC | 05:50 | |
| *** topshare has joined #openstack-qa | 06:00 | |
| *** k4n0 has joined #openstack-qa | 06:05 | |
| *** afazekas has joined #openstack-qa | 06:11 | |
| openstackgerrit | Daisuke Morita proposed a change to openstack/tempest: Improve the selectability of Swift tests https://review.openstack.org/116557 | 06:14 |
| *** cnesa7 has joined #openstack-qa | 06:20 | |
| *** Poornima_ has quit IRC | 06:23 | |
| *** topshare has quit IRC | 06:25 | |
| *** nmagnezi has joined #openstack-qa | 06:25 | |
| afazekas | andreaf, mkoderer: looking for non redhat reviewer : https://review.openstack.org/#/c/114186/11 | 06:26 |
| yfried | masayukig: ping | 06:32 |
| openstackgerrit | afazekas proposed a change to openstack-infra/devstack-gate: Fix ssh key specification in the README.rst https://review.openstack.org/114553 | 06:33 |
| yfried | masayukig: these are ready for review: https://review.openstack.org/#/c/111719/ https://review.openstack.org/#/c/112199/ https://review.openstack.org/113124 | 06:34 |
| yfried | andreaf: ^ | 06:34 |
| *** cmyster has quit IRC | 06:36 | |
| openstackgerrit | A change was merged to openstack/tempest: Add network's status check after creation of network https://review.openstack.org/112831 | 06:41 |
| openstackgerrit | Jaume Devesa proposed a change to openstack-dev/devstack: [WIP] Add dr-agent service. https://review.openstack.org/111311 | 06:41 |
| *** dims has joined #openstack-qa | 06:42 | |
| *** dims has quit IRC | 06:47 | |
| *** jlibosva has joined #openstack-qa | 06:59 | |
| *** nmagnezi has quit IRC | 07:08 | |
| openstackgerrit | Jaume Devesa proposed a change to openstack-dev/devstack: [WIP] Add dr-agent service. https://review.openstack.org/111311 | 07:13 |
| *** markus_z has joined #openstack-qa | 07:13 | |
| *** Longgeek has joined #openstack-qa | 07:16 | |
| openstackgerrit | Jakub Libosvar proposed a change to openstack/tempest: javelin: add network and secgroup resources https://review.openstack.org/100169 | 07:16 |
| openstackgerrit | Jakub Libosvar proposed a change to openstack-dev/grenade: TEST: Run grenade with tempest change 100169 https://review.openstack.org/115910 | 07:17 |
| *** zz_dimtruck is now known as dimtruck | 07:18 | |
| *** Poornima_ has joined #openstack-qa | 07:20 | |
| *** marun has quit IRC | 07:20 | |
| *** bkopilov has joined #openstack-qa | 07:20 | |
| *** nmagnezi has joined #openstack-qa | 07:24 | |
| *** flaper87 is now known as flaper87|afk | 07:26 | |
| *** SridharG has joined #openstack-qa | 07:26 | |
| *** dimtruck is now known as zz_dimtruck | 07:28 | |
| *** jordanP has joined #openstack-qa | 07:31 | |
| *** cmyster has joined #openstack-qa | 07:33 | |
| *** jamielennox is now known as jamielennox|away | 07:33 | |
| *** luqas has joined #openstack-qa | 07:36 | |
| *** ildikov has joined #openstack-qa | 07:40 | |
| *** jpich has joined #openstack-qa | 07:57 | |
| *** lordd_ has quit IRC | 07:59 | |
| *** SridharG has quit IRC | 08:02 | |
| *** lordd_ has joined #openstack-qa | 08:03 | |
| *** SridharG has joined #openstack-qa | 08:05 | |
| *** tkammer has joined #openstack-qa | 08:09 | |
| kashyap | afazekas, Heya, when you're around - do you see this with current Fedora 20 cloud images? - https://bugzilla.redhat.com/show_bug.cgi?id=1082030 | 08:12 |
| *** yfried_ has joined #openstack-qa | 08:14 | |
| *** yfried has quit IRC | 08:15 | |
| openstackgerrit | Udi Kalifon proposed a change to openstack/tempest: keystone sanity test, creating a user in a domain and uses his credentials https://review.openstack.org/115279 | 08:20 |
| openstackgerrit | Udi Kalifon proposed a change to openstack/tempest: using credentials of users created on-the-fly https://review.openstack.org/114951 | 08:20 |
| openstackgerrit | afazekas proposed a change to openstack-dev/devstack: use_unicode=0 for mysql connections https://review.openstack.org/116570 | 08:22 |
| *** enikanorov has quit IRC | 08:26 | |
| *** enikanorov has joined #openstack-qa | 08:26 | |
| *** yfried_ has quit IRC | 08:29 | |
| *** dims has joined #openstack-qa | 08:31 | |
| *** yfried_ has joined #openstack-qa | 08:34 | |
| *** dims has quit IRC | 08:36 | |
| *** k4n0 has quit IRC | 08:39 | |
| openstackgerrit | Jaume Devesa proposed a change to openstack-dev/devstack: [WIP] Add dr-agent service. https://review.openstack.org/111311 | 08:41 |
| *** Poornima_ has quit IRC | 08:45 | |
| *** yfried_ has quit IRC | 08:50 | |
| *** k4n0 has joined #openstack-qa | 08:52 | |
| openstackgerrit | afazekas proposed a change to openstack-dev/devstack: use_unicode=0 for mysql connections https://review.openstack.org/116570 | 08:54 |
| openstackgerrit | afazekas proposed a change to openstack-dev/devstack: use_unicode=0 for mysql connections https://review.openstack.org/116570 | 08:54 |
| *** yfried has joined #openstack-qa | 09:02 | |
| *** mkollaro has joined #openstack-qa | 09:05 | |
| *** mkollaro has quit IRC | 09:09 | |
| *** mkollaro1 has joined #openstack-qa | 09:09 | |
| *** SridharGaddam has joined #openstack-qa | 09:17 | |
| *** qba73 has joined #openstack-qa | 09:17 | |
| *** dmellado has quit IRC | 09:23 | |
| *** marun has joined #openstack-qa | 09:24 | |
| *** lordd_ has quit IRC | 09:28 | |
| *** lordd_ has joined #openstack-qa | 09:29 | |
| *** lordd_ has quit IRC | 09:30 | |
| *** lordd_ has joined #openstack-qa | 09:30 | |
| *** wuhg has joined #openstack-qa | 09:32 | |
| jordanP | hi guys, is there's work in progress or a blueprint that says we should have test comments in the docstring format ? | 09:35 |
| jordanP | ie use """ instead of # for instance ? | 09:36 |
| *** SridharGaddam has quit IRC | 09:39 | |
| *** swartulv has quit IRC | 09:42 | |
| *** yamahata has quit IRC | 09:43 | |
| *** sdmonov has joined #openstack-qa | 09:44 | |
| openstackgerrit | Neeti Dahiya proposed a change to openstack/tempest: Adds api schema for NEUTRON APIs https://review.openstack.org/116576 | 09:45 |
| *** swartulv has joined #openstack-qa | 09:46 | |
| rahmu | jordanP: you mean something like doctest? (https://docs.python.org/2/library/doctest.html) | 09:47 |
| jordanP | I don't know, could be. have you read a mail or a bp related to this in tempest ? | 09:48 |
| *** luqas has quit IRC | 09:52 | |
| rahmu | jordanP: I don't recall reading anything like that | 09:53 |
| *** tosky has joined #openstack-qa | 09:54 | |
| *** luqas has joined #openstack-qa | 09:54 | |
| *** luqas has quit IRC | 09:58 | |
| *** tkammer has quit IRC | 10:02 | |
| *** sdmonov has quit IRC | 10:04 | |
| *** tkammer has joined #openstack-qa | 10:05 | |
| *** e0ne has joined #openstack-qa | 10:05 | |
| *** luqas has joined #openstack-qa | 10:06 | |
| *** e0ne has quit IRC | 10:08 | |
| *** marun has quit IRC | 10:11 | |
| *** e0ne has joined #openstack-qa | 10:12 | |
| *** marun has joined #openstack-qa | 10:12 | |
| *** qba73 has quit IRC | 10:12 | |
| *** tkammer has quit IRC | 10:13 | |
| openstackgerrit | A change was merged to openstack/tempest: Use list comprehension in create_bulk_networks https://review.openstack.org/113879 | 10:14 |
| *** qba73 has joined #openstack-qa | 10:14 | |
| *** tnurlygayanov has joined #openstack-qa | 10:15 | |
| *** e0ne has quit IRC | 10:15 | |
| openstackgerrit | A change was merged to openstack-infra/devstack-gate: Add glance.store to the list of projects https://review.openstack.org/115299 | 10:16 |
| *** qba73 has quit IRC | 10:19 | |
| *** e0ne has joined #openstack-qa | 10:20 | |
| *** e0ne has quit IRC | 10:21 | |
| openstackgerrit | enikanorov proposed a change to openstack/tempest: Use ipv6 subnet with /64 prefix in ipv6 network API test https://review.openstack.org/116581 | 10:24 |
| *** e0ne has joined #openstack-qa | 10:26 | |
| *** e0ne has quit IRC | 10:28 | |
| *** qba73 has joined #openstack-qa | 10:29 | |
| *** qba73 has quit IRC | 10:31 | |
| *** neeti has joined #openstack-qa | 10:32 | |
| afazekas | kashyap: I am using this image http://dl.fedoraproject.org/pub/alt/openstack/20/x86_64/Fedora-x86_64-20-20140618-sda.qcow2 | 10:32 |
| *** e0ne has joined #openstack-qa | 10:32 | |
| *** qba73 has joined #openstack-qa | 10:33 | |
| *** tkammer has joined #openstack-qa | 10:33 | |
| * gmann is away: | 10:33 | |
| *** qba73 has quit IRC | 10:34 | |
| *** qba73 has joined #openstack-qa | 10:34 | |
| afazekas | kashyap: you can link this bug(https://bugzilla.redhat.com/show_bug.cgi?id=1102592) and the image to that bug, and you can ask is he using kvm or qemu | 10:36 |
| yfried | adam_g: Shrews: ping | 10:37 |
| *** qba73 has quit IRC | 10:37 | |
| *** e0ne has quit IRC | 10:39 | |
| *** neeti_ has joined #openstack-qa | 10:39 | |
| *** neeti has quit IRC | 10:42 | |
| *** e0ne has joined #openstack-qa | 10:43 | |
| *** qba73 has joined #openstack-qa | 10:44 | |
| *** e0ne has quit IRC | 10:44 | |
| *** qba73 has quit IRC | 10:44 | |
| *** k4n0 has quit IRC | 10:47 | |
| kashyap | afazekas, Thanks. Yeah, will check. (Sorry the delay, was out running an errand.) | 10:47 |
| kashyap | coolsvap, you already commented there. | 10:48 |
| *** bkopilov has quit IRC | 10:48 | |
| kashyap | (Err, wrong tab completion, ^ Swapnil, please disregard me.) | 10:48 |
| *** flaper87|afk is now known as flaper87 | 10:48 | |
| *** e0ne has joined #openstack-qa | 10:48 | |
| *** bkopilov has joined #openstack-qa | 10:49 | |
| *** e0ne has quit IRC | 10:53 | |
| *** Poornima_ has joined #openstack-qa | 10:54 | |
| openstackgerrit | Udi Kalifon proposed a change to openstack/tempest: Using credentials of users created on-the-fly https://review.openstack.org/115279 | 10:54 |
| *** dmorita has quit IRC | 10:55 | |
| *** jecarey has joined #openstack-qa | 10:55 | |
| *** e0ne has joined #openstack-qa | 10:56 | |
| openstackgerrit | Cedric Brandily proposed a change to openstack/tempest: Add provider extension positive test cases https://review.openstack.org/103498 | 10:58 |
| *** k4n0 has joined #openstack-qa | 10:59 | |
| openstackgerrit | Cedric Brandily proposed a change to openstack/tempest: Add multi-provider extension positive test cases https://review.openstack.org/104526 | 11:00 |
| openstackgerrit | Cedric Brandily proposed a change to openstack/tempest: Add partial specs (multi-)provider extension positive test cases https://review.openstack.org/105234 | 11:00 |
| *** e0ne has quit IRC | 11:03 | |
| *** e0ne has joined #openstack-qa | 11:07 | |
| *** e0ne has quit IRC | 11:09 | |
| *** luqas has quit IRC | 11:12 | |
| *** e0ne has joined #openstack-qa | 11:12 | |
| *** e0ne has quit IRC | 11:15 | |
| *** yamahata has joined #openstack-qa | 11:16 | |
| *** e0ne has joined #openstack-qa | 11:19 | |
| *** mkollaro has joined #openstack-qa | 11:22 | |
| *** Poornima_ has quit IRC | 11:24 | |
| *** mkollaro1 has quit IRC | 11:24 | |
| *** SridharG has left #openstack-qa | 11:24 | |
| *** adalbas has joined #openstack-qa | 11:25 | |
| *** e0ne has quit IRC | 11:27 | |
| *** dims has joined #openstack-qa | 11:29 | |
| *** e0ne has joined #openstack-qa | 11:32 | |
| openstackgerrit | Mh Raies proposed a change to openstack/tempest: Provide support for non admin CLI tests https://review.openstack.org/111241 | 11:33 |
| *** Poornima_ has joined #openstack-qa | 11:45 | |
| *** e0ne has quit IRC | 11:49 | |
| *** tkammer has quit IRC | 11:50 | |
| openstackgerrit | enikanorov proposed a change to openstack/tempest: Use ipv6 subnet with /64 prefix in ipv6 network API test https://review.openstack.org/116581 | 11:52 |
| *** e0ne has joined #openstack-qa | 11:54 | |
| *** lordd_ has quit IRC | 11:54 | |
| *** lordd_ has joined #openstack-qa | 11:55 | |
| *** rfolco has joined #openstack-qa | 11:58 | |
| *** e0ne has quit IRC | 11:58 | |
| *** lordd_ has quit IRC | 11:59 | |
| *** eezhova has quit IRC | 12:01 | |
| *** lordd_ has joined #openstack-qa | 12:01 | |
| *** e0ne has joined #openstack-qa | 12:02 | |
| *** tkammer has joined #openstack-qa | 12:04 | |
| *** flaper87 is now known as flaper87|afk | 12:04 | |
| *** dkranz has joined #openstack-qa | 12:06 | |
| *** flaper87|afk is now known as flaper87 | 12:07 | |
| openstackgerrit | prabhu murthy proposed a change to openstack/tempest: Added test for DVR device owner check using port https://review.openstack.org/113455 | 12:09 |
| openstackgerrit | prabhu murthy proposed a change to openstack/tempest: Add API tests for Neutron DVR extension https://review.openstack.org/98235 | 12:09 |
| openstackgerrit | Jakub Libosvar proposed a change to openstack/tempest: javelin: add network and secgroup resources https://review.openstack.org/100169 | 12:09 |
| *** e0ne has quit IRC | 12:09 | |
| *** mkollaro has quit IRC | 12:14 | |
| *** mkollaro1 has joined #openstack-qa | 12:14 | |
| *** aysyd has joined #openstack-qa | 12:16 | |
| *** tkammer has quit IRC | 12:18 | |
| *** jaypipes has joined #openstack-qa | 12:22 | |
| *** ChanServ sets mode: +o jaypipes | 12:22 | |
| *** e0ne has joined #openstack-qa | 12:24 | |
| openstackgerrit | Sergey Lukjanov proposed a change to openstack-dev/devstack: Move sahara client installation to lib/sahara https://review.openstack.org/112000 | 12:28 |
| *** e0ne has quit IRC | 12:28 | |
| openstackgerrit | Sergey Lukjanov proposed a change to openstack-dev/devstack: Remove sahara-dashboard installation https://review.openstack.org/112001 | 12:28 |
| *** zz_dimtruck is now known as dimtruck | 12:29 | |
| *** tkammer has joined #openstack-qa | 12:32 | |
| *** weshay has joined #openstack-qa | 12:34 | |
| *** jecarey has quit IRC | 12:35 | |
| *** timello has quit IRC | 12:43 | |
| yfried | Shrews: adam_g: you guys around? | 12:48 |
| yfried | andreaf: ? | 12:48 |
| *** gmann_ has joined #openstack-qa | 12:50 | |
| gmann_ | mtreinish: hi | 12:52 |
| gmann_ | mtreinish: Can you please have a look into https://review.openstack.org/#/c/100132/ | 12:53 |
| gmann_ | need to decide the direction on this whether we need to go for if else condition or condition statement for default param values | 12:53 |
| yfried | mtreinish: dkranz: this patch is constantly failing on various gates without even running tempest. could you please take a look? I could do "recheck" untill it passes but it feels wrong to me. there's either a problem in the gate, or a problem in the patch (seems unlikely since the failure is without tempest run) | 12:54 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/tempest: Updated from global requirements https://review.openstack.org/110110 | 12:57 |
| gmann_ | it need rebase, i will it tomorrow. meanwhile if we can decide on which way we should go. | 13:00 |
| *** ildikov has quit IRC | 13:01 | |
| Shrews | yfried: hi | 13:02 |
| *** gordc has joined #openstack-qa | 13:05 | |
| *** dims has quit IRC | 13:06 | |
| *** dims has joined #openstack-qa | 13:06 | |
| *** ildikov_ has joined #openstack-qa | 13:07 | |
| yfried | Shrews: hi, about https://review.openstack.org/#/c/112660/ | 13:09 |
| *** mestery has quit IRC | 13:10 | |
| *** SridharG has joined #openstack-qa | 13:13 | |
| *** mestery has joined #openstack-qa | 13:17 | |
| *** timello has joined #openstack-qa | 13:17 | |
| *** dustins has joined #openstack-qa | 13:17 | |
| mtreinish | gmann_: did you ever get a reason from marun about why an if was better? Or was it just consistency? | 13:20 |
| *** chandankumar has joined #openstack-qa | 13:20 | |
| yfried | Shrews: available for a chat now? | 13:20 |
| marun | mtreinish: I said a conditional or a ternary operator was preferable | 13:20 |
| marun | mtreinish: the use of [this or that] is problematic in some instances and I'm not sure why it would be preferable to if or ternary | 13:21 |
| Shrews | yfried: i'm waiting to hear what you need :) | 13:21 |
| *** mestery_ has joined #openstack-qa | 13:21 | |
| *** Madan has quit IRC | 13:21 | |
| mtreinish | marun: ok, I think gmann_ was looking for the reason... | 13:21 |
| marun | mtreinish: in any case, my concern with his patch at this point is mainly that he's trying to fix mutable argumements and change how defaults for non-mutable arguments in the same patch | 13:22 |
| *** mestery has quit IRC | 13:22 | |
| marun | mtreinish: I think those changes are logically distinct and should be submitted separately, regardless of the merit of changing how defaults are assigned | 13:23 |
| gmann_ | marun: mtreinish: Agree, actually patch is end up with mixed changes due to review comments :) | 13:23 |
| *** timello has quit IRC | 13:23 | |
| yfried | Shrews: I am really against you "destroying" setUp method | 13:24 |
| marun | gmann_: I see that yfried was the one calling for consistency | 13:24 |
| mtreinish | marun: ok, yeah that makes sense to me | 13:24 |
| *** mriedem has joined #openstack-qa | 13:24 | |
| yfried | Shrews: and I don't really understand the Ironic part | 13:24 |
| yfried | marun: ? | 13:24 |
| marun | yfried: https://review.openstack.org/#/c/100132/6/tempest/scenario/manager.py | 13:25 |
| marun | yfried: you asked gmann_ to change existing code for consistency rather than requiring him to follow existing convention | 13:25 |
| marun | yfried: I don't agree with that approach | 13:26 |
| Shrews | yfried: so, setUp() will be called even if test is skipped. the setUp code creates an instances, which is time consuming. if a test is skipped, this makes the test run much longer than necessary. ironic skips many of these tests, so the tempest run takes longer than necessary. | 13:26 |
| gmann_ | marun: yfried: lets separate out the changes. so in this patch we will go for if condition to set default param value and separate patch to follow consistency if needed. | 13:26 |
| gmann_ | does that looks good? | 13:26 |
| marun | gmann_: +1 | 13:26 |
| marun | gmann_: I'm not tempest core so it's not my place to decide how defaults are set, but separating out those changes is definitely a good idea. | 13:28 |
| mtreinish | marun: heh, well my rule of thumb is explicit is better. So checking for None (if that is what the default is) is better than just not True. | 13:29 |
| marun | mtreinish: we are in violent agreement. | 13:31 |
| marun | mtreinish: which is why it makes sense to separate the fixes for mutable arguments from changes to how defaults are set, so that the latter change can get the attention it deserves without distraction. | 13:32 |
| mtreinish | marun: yep, agreed | 13:33 |
| yfried | mtreinish: marun: gmann_'s way seems more elegant to me, but I understand consistency and explicity | 13:34 |
| openstackgerrit | Rohan Kanade proposed a change to openstack/tempest: Move API response success check to Neutron client https://review.openstack.org/114186 | 13:35 |
| *** k4n0 has quit IRC | 13:35 | |
| *** pcrews has joined #openstack-qa | 13:36 | |
| kashyap | Hmm, SSH failures in Grenade test jobs, despite a patch in https://bugs.launchpad.net/grenade/+bug/1349617 -- http://logs.openstack.org/82/116082/1/check/check-grenade-dsvm-partial-ncpu/faa71db/console.html | 13:37 |
| *** nosnos has quit IRC | 13:38 | |
| yfried | Shrews: do you want network_basic_ops tests to run on Ironic? | 13:38 |
| *** nosnos has joined #openstack-qa | 13:38 | |
| openstackgerrit | enikanorov proposed a change to openstack/tempest: Use ipv6 subnet with /64 prefix in ipv6 network API test https://review.openstack.org/116581 | 13:38 |
| yfried | Shrews: where is the skip decision maid? | 13:38 |
| yfried | made | 13:38 |
| *** sabeen has joined #openstack-qa | 13:40 | |
| *** timello has joined #openstack-qa | 13:40 | |
| *** jgrimm has quit IRC | 13:40 | |
| gmann_ | marun: mtreinish: yfried: from less LOC point of view that's looks good to me too (thats y i preferred that) but if we go for code readability, explicit is better way. | 13:41 |
| *** malini has joined #openstack-qa | 13:41 | |
| yfried | Shrews: I'm confused. are network tests skipped for Ironic, or just done differently? | 13:42 |
| Shrews | yfried: one of the network_basic_ops tests is skipped. see the @skipUnless and @skipIf decorators | 13:42 |
| *** nosnos has quit IRC | 13:43 | |
| yfried | Shrews: and the rest of the modules? secgroup? advanced? | 13:43 |
| Shrews | yfried: what about them? | 13:43 |
| *** sballe has joined #openstack-qa | 13:43 | |
| Shrews | several of those tests have skip decorators | 13:43 |
| Shrews | and most (if not all) that do will be skipped by ironic | 13:44 |
| Shrews | yfried: i really don't understand your objection. perhaps you should outline why you want to keep instance creation in setUp (which i believe should never be done) | 13:44 |
| Shrews | mtreinish: perhaps you have some input on that ^^^^ ? | 13:45 |
| yfried | Shrews: well, if the setUp/tearDown is being called regardless of skip, that's a Tempest bug. | 13:45 |
| Shrews | yfried: i doubt that's a tempest bug. possibly a bug in unit test library, but more likely just the way it works | 13:46 |
| *** chandankumar has quit IRC | 13:46 | |
| yfried | Shrews: setUp/tearDown are operations common to all tests. so explicitly calling methods at the beginning of each test is refusing to use the unit-test framework and increasing the chance for erros | 13:47 |
| yfried | erros | 13:47 |
| yfried | errors | 13:47 |
| *** bkopilov has quit IRC | 13:48 | |
| Shrews | yfried: i would agree, except for the fact that skipped tests still call setUp | 13:48 |
| Shrews | yfried: so present me an alternative | 13:48 |
| *** cmyster has quit IRC | 13:50 | |
| yfried | Shrews: I'm not sure I have an alternative. this still seems like a bug, either in tempest or in unittest, and this is both problematic and too specific a fix | 13:51 |
| openstackgerrit | Jakub Libosvar proposed a change to openstack-dev/grenade: TEST: Run grenade with tempest change 100169 https://review.openstack.org/115910 | 13:51 |
| yfried | Shrews: the best I have in mind currently, is adding explicit skip inside setUp | 13:52 |
| Shrews | yfried: that doesn't fix it. setUp() is still executed | 13:52 |
| Shrews | oh, wait... i read that as "inside test" | 13:53 |
| Shrews | but, that's still not a good fix | 13:53 |
| yfried | Shrews: I believe it's better. but yeah. it's not "good" | 13:53 |
| *** cmyster has joined #openstack-qa | 13:54 | |
| *** cmyster has quit IRC | 13:54 | |
| *** cmyster has joined #openstack-qa | 13:54 | |
| yfried | Shrews: I think we need to take a better look at testtools.skipUnless decorator | 13:54 |
| Shrews | not better. contradicting skip parameters could cause breakage | 13:54 |
| yfried | Shrews: "contradicting"? | 13:55 |
| yfried | Shrews: your problem is that it's wasting test time, right? there are no actual errors?\ | 13:56 |
| Shrews | correct | 13:56 |
| yfried | Shrews: then IMO if we don't have a "good" solution, we shouldn't do anything. | 13:57 |
| openstackgerrit | A change was merged to openstack-dev/devstack: Set suspend feature flag in tempest for ironic https://review.openstack.org/113846 | 13:58 |
| Shrews | yfried: that is not acceptable. having a common method called from the tests is not horrible, and it's done in other modules | 13:59 |
| Shrews | i must now attend to a large backlog of email waiting for me from my vacation. feel free to leave comments on the review | 13:59 |
| yfried | Shrews: well, that was MY opinion. I'm not god of tempest :) | 13:59 |
| openstackgerrit | A change was merged to openstack-dev/devstack: Sahara script modified with notification configuration https://review.openstack.org/113238 | 14:05 |
| openstackgerrit | A change was merged to openstack-dev/devstack: Migrate from using glance image-list to openstackclient https://review.openstack.org/111534 | 14:05 |
| *** lordd_ has quit IRC | 14:05 | |
| openstackgerrit | Jordan Pittier proposed a change to openstack/tempest: Heat SwiftResources : only count containers created by Tempest https://review.openstack.org/116622 | 14:06 |
| mtreinish | Shrews: sorry, stepped away for a sec. Input on what in particular, doing instance creation in setup? | 14:08 |
| mtreinish | yfried: qq, did you ever get that secgroup test fixed up so it would work with ping before ssh change? | 14:08 |
| openstackgerrit | Jordan Pittier proposed a change to openstack/tempest: Heat SwiftResources : only count containers created by Tempest https://review.openstack.org/116622 | 14:08 |
| *** lordd_ has joined #openstack-qa | 14:08 | |
| openstackgerrit | Cedric Brandily proposed a change to openstack/tempest: Add provider extension positive test cases https://review.openstack.org/103498 | 14:09 |
| openstackgerrit | Cedric Brandily proposed a change to openstack/tempest: Add multi-provider extension positive test cases https://review.openstack.org/104526 | 14:09 |
| openstackgerrit | Cedric Brandily proposed a change to openstack/tempest: Add partial specs (multi-)provider extension positive test cases https://review.openstack.org/105234 | 14:10 |
| *** rbak has joined #openstack-qa | 14:11 | |
| *** oomichi has quit IRC | 14:12 | |
| *** amotoki has quit IRC | 14:14 | |
| coolsvap | yfried, hi | 14:16 |
| coolsvap | yfried, do you agree with the comment response on https://review.openstack.org/#/c/90306/ ? | 14:16 |
| *** ArxCruz has joined #openstack-qa | 14:18 | |
| *** tkammer has quit IRC | 14:19 | |
| *** gmann_ has quit IRC | 14:20 | |
| yfried | mtreinish: my colleague had a very nice patch ready for it, but he had problem pushing it (rhel issues) and he's now pto | 14:21 |
| yfried | mtreinish: how urgent is this?\ | 14:21 |
| *** yamahata has quit IRC | 14:22 | |
| mtreinish | yfried: it's not super urgent, but I was holding up that patch for the secgroup fix. It'd be nice to land it soon | 14:23 |
| *** enikanorov__ has joined #openstack-qa | 14:27 | |
| *** lordd_ has quit IRC | 14:28 | |
| *** malini1 has joined #openstack-qa | 14:28 | |
| *** cnesa8 has joined #openstack-qa | 14:29 | |
| *** nmagnezi_ has joined #openstack-qa | 14:31 | |
| *** tristanC_ has joined #openstack-qa | 14:31 | |
| *** pleia2_ has joined #openstack-qa | 14:31 | |
| *** mgagne_ has joined #openstack-qa | 14:32 | |
| openstackgerrit | Udi Kalifon proposed a change to openstack/tempest: Using credentials of users created on-the-fly https://review.openstack.org/115279 | 14:32 |
| *** mgagne has quit IRC | 14:32 | |
| *** dimtruck has quit IRC | 14:32 | |
| *** freyes has quit IRC | 14:32 | |
| *** malini has quit IRC | 14:32 | |
| *** dtroyer has quit IRC | 14:32 | |
| *** tristanC has quit IRC | 14:32 | |
| *** nmagnezi has quit IRC | 14:32 | |
| *** cnesa7 has quit IRC | 14:32 | |
| *** mtreinish has quit IRC | 14:32 | |
| *** maurosr has quit IRC | 14:32 | |
| *** enikanorov_ has quit IRC | 14:32 | |
| *** jroll has quit IRC | 14:32 | |
| *** pleia2 has quit IRC | 14:32 | |
| *** mtreinish has joined #openstack-qa | 14:32 | |
| *** dimtruck has joined #openstack-qa | 14:32 | |
| *** maurosr- has joined #openstack-qa | 14:32 | |
| *** dtroyer has joined #openstack-qa | 14:32 | |
| *** maurosr- is now known as maurosr | 14:32 | |
| *** tristanC_ is now known as tristanC | 14:33 | |
| *** jroll has joined #openstack-qa | 14:33 | |
| *** freyes has joined #openstack-qa | 14:33 | |
| *** lordd_ has joined #openstack-qa | 14:33 | |
| yfried | mtreinish: did you get my PM? | 14:34 |
| *** jgrimm has joined #openstack-qa | 14:34 | |
| yfried | coolsvap: not sure. please ping me tomorrow. I'll take a closer look at your link | 14:36 |
| *** lordd_ has quit IRC | 14:37 | |
| coolsvap | yfried, okay I wish you could have had a look, but will ping you, thx@ | 14:37 |
| yfried | coolsvap: it's late for me and I have a lot of stuff to finish. sorry | 14:39 |
| openstackgerrit | A change was merged to openstack-dev/devstack: Adds xiv_ds8k cinder driver support https://review.openstack.org/110783 | 14:42 |
| openstackgerrit | A change was merged to openstack-dev/devstack: Don't try to regenerate existing ssl certificates https://review.openstack.org/102535 | 14:42 |
| *** eezhova has joined #openstack-qa | 14:43 | |
| yfried | Shrews: https://docs.python.org/2/library/unittest.html#skipping-tests-and-expected-failures | 14:46 |
| yfried | Shrews: TestCase.setUp() can also skip the test. This is useful when a resource that needs to be set up is not available. | 14:46 |
| *** Santosh has quit IRC | 14:46 | |
| *** nmagnezi_ has quit IRC | 14:47 | |
| Shrews | yfried: how is that helpful? | 14:49 |
| *** rahmu_ has joined #openstack-qa | 14:50 | |
| yfried | Shrews: not sure | 14:50 |
| *** mtreinish_ has joined #openstack-qa | 14:50 | |
| *** jgrimm has quit IRC | 14:50 | |
| *** dtroyer has quit IRC | 14:50 | |
| *** dimtruck has quit IRC | 14:50 | |
| *** mtreinish has quit IRC | 14:50 | |
| *** rahmu has quit IRC | 14:50 | |
| *** dimtruck has joined #openstack-qa | 14:50 | |
| *** dtroyer has joined #openstack-qa | 14:50 | |
| *** rahmu_ is now known as rahmu | 14:50 | |
| *** jgrimm has joined #openstack-qa | 14:50 | |
| *** mtreinish_ is now known as mtreinish | 14:51 | |
| openstackgerrit | afazekas proposed a change to openstack-dev/devstack: Allow installing tempest only with keystone https://review.openstack.org/115307 | 14:53 |
| *** lordd_ has joined #openstack-qa | 14:53 | |
| openstackgerrit | Jakub Libosvar proposed a change to openstack/tempest: javelin: add network and secgroup resources https://review.openstack.org/100169 | 14:54 |
| openstackgerrit | Jakub Libosvar proposed a change to openstack-dev/grenade: TEST: Run grenade with tempest change 100169 https://review.openstack.org/115910 | 14:54 |
| *** lordd_ has quit IRC | 14:54 | |
| *** ildikov has joined #openstack-qa | 14:55 | |
| *** lordd_ has joined #openstack-qa | 14:56 | |
| *** ildikov_ has quit IRC | 14:58 | |
| *** lordd_ has quit IRC | 15:03 | |
| *** mestery_ is now known as mestery | 15:06 | |
| *** atiwari has joined #openstack-qa | 15:10 | |
| *** markmcclain has joined #openstack-qa | 15:10 | |
| *** lordd_ has joined #openstack-qa | 15:11 | |
| *** Longgeek has quit IRC | 15:16 | |
| *** markmcclain has quit IRC | 15:19 | |
| *** markmcclain has joined #openstack-qa | 15:21 | |
| *** atiwari has quit IRC | 15:27 | |
| *** coolsvap has quit IRC | 15:30 | |
| *** ildikov has quit IRC | 15:30 | |
| *** yfried_ has joined #openstack-qa | 15:31 | |
| *** yfried has quit IRC | 15:33 | |
| *** torandu has quit IRC | 15:33 | |
| *** amotoki has joined #openstack-qa | 15:33 | |
| *** torandu has joined #openstack-qa | 15:33 | |
| *** samuelbercovici has joined #openstack-qa | 15:35 | |
| *** sballe_ has joined #openstack-qa | 15:35 | |
| *** yfried_ has quit IRC | 15:36 | |
| *** coolsvap has joined #openstack-qa | 15:37 | |
| *** sballe has quit IRC | 15:37 | |
| *** atiwari has joined #openstack-qa | 15:44 | |
| *** masayukig has quit IRC | 15:46 | |
| *** neeti_ has quit IRC | 15:46 | |
| *** markmcclain has quit IRC | 15:46 | |
| openstackgerrit | Mathieu Rohon proposed a change to openstack-dev/devstack: Detect when Debian is used to launch libvirtd https://review.openstack.org/116657 | 15:48 |
| *** hemna_ is now known as hemna | 15:50 | |
| *** flaper87 is now known as flaper87|afk | 15:52 | |
| *** masayukig has joined #openstack-qa | 15:52 | |
| *** sballe_ has quit IRC | 16:01 | |
| *** samuelbercovici has quit IRC | 16:01 | |
| *** sballe_ has joined #openstack-qa | 16:01 | |
| *** markus_z has quit IRC | 16:05 | |
| *** qba73 has joined #openstack-qa | 16:11 | |
| *** markmcclain has joined #openstack-qa | 16:15 | |
| *** timello has quit IRC | 16:18 | |
| *** markmcclain has quit IRC | 16:20 | |
| *** qba73 has quit IRC | 16:22 | |
| *** dims_ has joined #openstack-qa | 16:23 | |
| *** dims has quit IRC | 16:24 | |
| *** pleia2_ is now known as pleia2 | 16:24 | |
| openstackgerrit | Zhi Yan Liu proposed a change to openstack-dev/devstack: Setup notification properly for Trove https://review.openstack.org/116671 | 16:24 |
| *** mlavalle has joined #openstack-qa | 16:25 | |
| *** timello has joined #openstack-qa | 16:26 | |
| *** amotoki has quit IRC | 16:27 | |
| *** ildikov has joined #openstack-qa | 16:34 | |
| *** dims has joined #openstack-qa | 16:35 | |
| *** jordanP has quit IRC | 16:35 | |
| *** Poornima_ has quit IRC | 16:35 | |
| *** dims_ has quit IRC | 16:35 | |
| *** sabeen has quit IRC | 16:36 | |
| *** markmcclain has joined #openstack-qa | 16:37 | |
| *** weshay has quit IRC | 16:41 | |
| *** suneelb has joined #openstack-qa | 16:41 | |
| *** weshay has joined #openstack-qa | 16:46 | |
| *** dimtruck is now known as zz_dimtruck | 16:51 | |
| *** afazekas has quit IRC | 16:53 | |
| *** yamahata has joined #openstack-qa | 16:58 | |
| *** jlibosva has quit IRC | 16:59 | |
| *** openstackgerrit has quit IRC | 17:00 | |
| *** marun is now known as marun_afk | 17:01 | |
| *** harlowja has joined #openstack-qa | 17:01 | |
| *** SridharG has quit IRC | 17:03 | |
| *** mgagne_ has quit IRC | 17:11 | |
| *** mgagne_ has joined #openstack-qa | 17:11 | |
| *** jpich has quit IRC | 17:12 | |
| *** openstackgerrit has joined #openstack-qa | 17:13 | |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack-infra/devstack-gate: Add Ironic-python-agent support to devstack-gate https://review.openstack.org/112143 | 17:16 |
| *** yfried_ has joined #openstack-qa | 17:16 | |
| *** SridharG has joined #openstack-qa | 17:18 | |
| *** yamahata has quit IRC | 17:21 | |
| *** esmute has quit IRC | 17:24 | |
| *** aix has quit IRC | 17:24 | |
| *** markmcclain has quit IRC | 17:25 | |
| openstackgerrit | Swami Reddy proposed a change to openstack/tempest: Add "reboot_instance" EC2 API test case https://review.openstack.org/115944 | 17:26 |
| *** yfried_ has quit IRC | 17:30 | |
| *** aimon has quit IRC | 17:32 | |
| *** yfried_ has joined #openstack-qa | 17:35 | |
| *** esmute has joined #openstack-qa | 17:37 | |
| *** e0ne has joined #openstack-qa | 17:39 | |
| *** mgagne_ is now known as mgagne | 17:39 | |
| *** wuhg has quit IRC | 17:42 | |
| *** aimon has joined #openstack-qa | 17:44 | |
| *** esmute has quit IRC | 18:00 | |
| *** esmute has joined #openstack-qa | 18:00 | |
| *** SridharG has left #openstack-qa | 18:17 | |
| *** e0ne has quit IRC | 18:19 | |
| *** e0ne has joined #openstack-qa | 18:20 | |
| *** e0ne has quit IRC | 18:25 | |
| *** e0ne has joined #openstack-qa | 18:26 | |
| *** e0ne has quit IRC | 18:26 | |
| *** lordd_ has quit IRC | 18:29 | |
| *** lordd_ has joined #openstack-qa | 18:29 | |
| *** lordd_ has quit IRC | 18:31 | |
| *** lordd_ has joined #openstack-qa | 18:31 | |
| *** lordd_ has quit IRC | 18:33 | |
| *** tosky has quit IRC | 18:42 | |
| openstackgerrit | Adam Gandelman proposed a change to openstack-dev/devstack: Set flavor id for Ironic's baremetal flavor https://review.openstack.org/107814 | 18:52 |
| *** e0ne has joined #openstack-qa | 18:57 | |
| dkranz | mtreinish: I was looking at https://review.openstack.org/#/c/115683/1/tempest/api/telemetry/base.py,unified which adds a call to set_network_resources() to the telemetry base class. But I see many other service base classes that do not do this. I'm not sure exactly when this is required. Is this change necessary? Should the other base classes have it? | 19:01 |
| *** suneelb has quit IRC | 19:01 | |
| *** suneelb has joined #openstack-qa | 19:02 | |
| dkranz | mtreinish: I guess maybe it is just an optimization and does not impact correctness whether there or not. | 19:02 |
| *** suneelb has quit IRC | 19:02 | |
| gordc | dkranz: that was a question i probably should've asked but i found it worked so i went with it. | 19:03 |
| *** suneelb has joined #openstack-qa | 19:03 | |
| mtreinish | dkranz: that should be added if by default the tests under that base class don't require networking for the guests being created | 19:03 |
| *** suneelb has quit IRC | 19:03 | |
| mtreinish | you can always override it on a per test class basis | 19:03 |
| gordc | dkranz: wasn't sure if it was a recent change but i assume it something happened in past month or so since we disabled that test | 19:04 |
| dkranz | mtreinish: so if the tests pass with that call, the call should be there | 19:04 |
| dkranz | mtreinish: which means several of the others where it is missing should have it too | 19:04 |
| mtreinish | dkranz: it was added originally because neutron couldn't handle the load of every tempest class creating it's own network (it literally crashed) | 19:04 |
| *** suneelb has joined #openstack-qa | 19:04 | |
| mtreinish | dkranz: it's just an optimization at this point, I think neutron can handle the load now | 19:04 |
| dkranz | mtreinish: that was what I recall but could not remember if it was strictly an optimization | 19:04 |
| mtreinish | salv-orlando: ^^^ correct me if I'm wrong | 19:04 |
| *** suneelb has quit IRC | 19:04 | |
| *** suneelb has joined #openstack-qa | 19:05 | |
| mtreinish | gordc: the set_network_resource() call dates back to Jan. | 19:05 |
| *** suneelb has quit IRC | 19:05 | |
| mtreinish | it really isn't an issue there because there are so few test classes there | 19:06 |
| *** suneelb has joined #openstack-qa | 19:06 | |
| *** suneelb has quit IRC | 19:06 | |
| mtreinish | so it doesn't generate a lot of load on neutron | 19:06 |
| mtreinish | gordc: I actually just reviewed it with what I think was the real fix to that bug | 19:06 |
| gordc | mtreinish: yeah, i dug into it and that call existed when we had tests originally enabled... | 19:06 |
| *** suneelb has joined #openstack-qa | 19:06 | |
| gordc | mtreinish: reading through your comment now. am i just hiding another bug by adding that call in? | 19:07 |
| mtreinish | maybe, since those tests are skipped we won't know until they're re-enabled. | 19:07 |
| dkranz | gordc: I'm not sure this change is good because at some point telemetry tests should be looking at neutron, no? | 19:07 |
| mtreinish | but we can fix that by adding another set_etwork_resource() call on that notification tests file with the required resources | 19:08 |
| mtreinish | dkranz: but in those cases it should be done manually right? | 19:08 |
| gordc | mtreinish: yeah. Dina has a dependent patch on mine that reenables it but i can't get it to pass (getting cinder bugs) | 19:08 |
| dkranz | mtreinish: ok, this is a bit tricky | 19:09 |
| gordc | dkranz: yes, we'd eventaully be looking at neutron... not sure what the time schedule is for that. | 19:09 |
| dkranz | gordc: I guess this is ok because a test that needs the network will just fail | 19:09 |
| dkranz | gordc: so it is not really an invisible landmine | 19:09 |
| gordc | dkranz: cool cool. i'll make a note of it in case this comes up when we add neutron tests. | 19:10 |
| *** krtaylor has quit IRC | 19:13 | |
| *** Sukhdev has joined #openstack-qa | 19:16 | |
| *** mestery has quit IRC | 19:20 | |
| *** mestery has joined #openstack-qa | 19:20 | |
| *** marun_afk is now known as marun | 19:24 | |
| openstackgerrit | Matt Riedemann proposed a change to openstack-infra/elastic-recheck: Add query for keystone unit test xml hash bug 1361337 https://review.openstack.org/116705 | 19:25 |
| mriedem | sdague: mtreinish: jogo: ^ easy pickins | 19:25 |
| *** e0ne has quit IRC | 19:26 | |
| mtreinish | mriedem: soft -0 | 19:28 |
| openstackgerrit | Matt Riedemann proposed a change to openstack-infra/elastic-recheck: Add query for keystone unit test xml hash bug 1361337 https://review.openstack.org/116705 | 19:29 |
| mriedem | mtreinish: because | 19:29 |
| *** jamielennox|away has quit IRC | 19:30 | |
| mtreinish | mriedem: ok that's good enough for me :) | 19:30 |
| mtreinish | +A | 19:30 |
| *** ianw has quit IRC | 19:32 | |
| *** jamielennox|away has joined #openstack-qa | 19:32 | |
| *** ianw has joined #openstack-qa | 19:33 | |
| *** malini1 has quit IRC | 19:34 | |
| *** krtaylor has joined #openstack-qa | 19:45 | |
| *** suneelb has quit IRC | 19:47 | |
| salv-orlando | mtreinish: We’ve enable tenant isolation for a while now | 19:48 |
| mtreinish | salv-orlando: yeah I know that, it was more a question about whether neutron could handle the load if we enabled that everywhere, not just where it's actually needed? | 19:49 |
| mtreinish | because we only added that set_network_resources() method because things fell apart from the extra load | 19:50 |
| salv-orlando | mtreinish: ah you mean removing the thing we did in Montreal? | 19:50 |
| mtreinish | yeah, not saying we should, but I was just curious | 19:50 |
| openstackgerrit | Kevin Benton proposed a change to openstack/tempest: Catch BadRequest exception from correct module https://review.openstack.org/115851 | 19:51 |
| salv-orlando | we can try. However, what causes excessive load is the creation of logical routers. They put a lot of strain on the l3 agent. This is something which has no equivalent in nova-network. I think we did the work in a way that we would be able to skip the creation of a router if we wanted? | 19:52 |
| salv-orlando | because unless you need a floating IP for your test you really don’t need a router | 19:52 |
| salv-orlando | mtreinish: I seem to recall we were asking neutron to create and wire something like 50 logical routers per minute. Considering that the l3 agent took 5-10 seconds for doing that for a single routers, it’s understandable that it might cause delays | 19:53 |
| mtreinish | salv-orlando: yeah, that's how we did it IIRC. I don't think we really need to try it, it was just a hypothetical that I was thinking about as I was explaining the method earlier | 19:54 |
| mtreinish | salv-orlando: yeah 50/sec sounds about right. (it would probably be even more now) | 19:54 |
| salv-orlando | mtreinish: if someone pushes a few patches to add a job in the exp queue that won’t make any harm | 19:54 |
| mtreinish | salv-orlando: heh, well I might remember to give that a try, but it's not like it's really a priority :) | 19:57 |
| *** zz_dimtruck is now known as dimtruck | 20:03 | |
| *** suneelb has joined #openstack-qa | 20:04 | |
| sdague | mriedem: why is https://review.openstack.org/#/c/116705/2 limitted to the gate queue? | 20:07 |
| mriedem | sdague: it's unit tests | 20:07 |
| mriedem | sdague: and we've generally restricted unit test failures that key off the test name to the gate queue | 20:08 |
| sdague | ok | 20:08 |
| mriedem | since i could break the test in the check queue with my dumb patch | 20:08 |
| mriedem | and then when the current regime is disposed and people get auto-rechecks, it'd be an infinite recursion recheck fiasco :) | 20:09 |
| *** pcrews has quit IRC | 20:14 | |
| openstackgerrit | Adam Gandelman proposed a change to openstack-dev/grenade: Source all devstack service libs for Tempest https://review.openstack.org/114087 | 20:17 |
| *** marun has quit IRC | 20:21 | |
| *** weshay has quit IRC | 20:24 | |
| *** masayukig has quit IRC | 20:27 | |
| *** suneelb has quit IRC | 20:27 | |
| *** suneelb has joined #openstack-qa | 20:28 | |
| *** suneelb has quit IRC | 20:28 | |
| *** suneelb has joined #openstack-qa | 20:29 | |
| *** masayukig has joined #openstack-qa | 20:34 | |
| *** marun has joined #openstack-qa | 20:39 | |
| *** pcrews has joined #openstack-qa | 20:53 | |
| *** ajo|mac has joined #openstack-qa | 21:07 | |
| *** ajo|mac is now known as ajo__ | 21:07 | |
| mtreinish | adam_g: on https://review.openstack.org/#/c/116147/ did you test this with a random hashseed? | 21:10 |
| *** andreaf has quit IRC | 21:10 | |
| adam_g | mtreinish, yeah | 21:10 |
| *** andreaf has joined #openstack-qa | 21:11 | |
| mtreinish | adam_g: ok cool | 21:11 |
| adam_g | mtreinish, tho i didnt really see any instances of anything in tempest passing in extra attributes (or any attributes at all, for that matter). may just want to hard code it instead? | 21:14 |
| mtreinish | adam_g: yeah, that's probably the case, I'm not even sure any of the xml apis understand how to use those args... | 21:16 |
| *** Sukhdev has quit IRC | 21:16 | |
| mtreinish | but if you got it working, I don't see any reason to hard code it :) | 21:16 |
| *** Sukhdev has joined #openstack-qa | 21:18 | |
| mtreinish | adam_g: anyway it LGTM, but you need to add unit tests... | 21:18 |
| adam_g | mtreinish, sure | 21:18 |
| adam_g | mtreinish, ima push a dependent patch that removes PYTHONHASHSEED from tox.ini and see if thats all we needed | 21:19 |
| *** dkranz has quit IRC | 21:19 | |
| mtreinish | adam_g: heh, well I know the unit tests will still fail | 21:20 |
| mtreinish | and I think there was one heat test that failed with a random hashseed too | 21:20 |
| adam_g | doh | 21:20 |
| mtreinish | but yeah that's a good idea, just to get an inventory of what else needs to be fixed... | 21:20 |
| mtreinish | adam_g: heh, the unit test failures look like the same xml thing :http://paste.openstack.org/show/100115/ | 21:24 |
| adam_g | ah, cool | 21:24 |
| mtreinish | hmm, nm there are still other failures if I run with your patch applied | 21:25 |
| adam_g | mtreinish, body_item = xml.Element("item", **self.item_expected) | 21:26 |
| adam_g | its the same problem, but not fixed byt he patch | 21:26 |
| adam_g | thats local to the test | 21:26 |
| adam_g | (i think) | 21:27 |
| mtreinish | adam_g: well, I ran the unit tests with your patch applied I got different fails, and those tests passed | 21:28 |
| mtreinish | so you did something right :) | 21:28 |
| adam_g | hehe | 21:29 |
| *** ekhugen has quit IRC | 21:30 | |
| *** maurosr has quit IRC | 21:30 | |
| *** markmcclain has joined #openstack-qa | 21:30 | |
| *** ekhugen has joined #openstack-qa | 21:31 | |
| *** maurosr has joined #openstack-qa | 21:31 | |
| *** jgrimm has quit IRC | 21:32 | |
| *** jgrimm has joined #openstack-qa | 21:32 | |
| adam_g | mtreinish, what are the failures with the patch? | 21:32 |
| adam_g | MismatchError: ['not_fake', 'fake1', 'fake2'] != ['fake1', 'not_fake', 'fake2'] | 21:33 |
| adam_g | ? | 21:33 |
| mtreinish | yeah, that, a failure on the credentials object tests, and a failure in the custom dict matcher test | 21:34 |
| mtreinish | I've got a fix for that first one already | 21:35 |
| mtreinish | just sorting the lists... | 21:35 |
| *** dimtruck is now known as zz_dimtruck | 21:35 | |
| adam_g | yeah | 21:36 |
| adam_g | dict matcher test is breaking my brain | 21:36 |
| *** suneelb has quit IRC | 21:36 | |
| *** suneelb has joined #openstack-qa | 21:37 | |
| mtreinish | heh, blame andreaf. It's basically leveraging: https://github.com/testing-cabal/testtools/blob/master/testtools/tests/matchers/helpers.py#L6 | 21:37 |
| mtreinish | but figuring out exactly what's being compared is definitely not easy... | 21:37 |
| *** mriedem has quit IRC | 21:42 | |
| *** jgrimm has quit IRC | 21:47 | |
| *** zz_dimtruck is now known as dimtruck | 21:48 | |
| *** dims has quit IRC | 21:50 | |
| *** dims has joined #openstack-qa | 21:50 | |
| *** dims has quit IRC | 21:55 | |
| *** enikanorov_ has joined #openstack-qa | 21:57 | |
| *** ildikov_ has joined #openstack-qa | 21:57 | |
| *** enikanorov has quit IRC | 21:58 | |
| *** dims has joined #openstack-qa | 21:59 | |
| *** dims_ has joined #openstack-qa | 21:59 | |
| openstackgerrit | A change was merged to openstack-dev/devstack: Centralize neutron config file argument generation https://review.openstack.org/113377 | 21:59 |
| *** ildikov has quit IRC | 22:00 | |
| openstackgerrit | yunhong-jiang proposed a change to openstack/tempest: Passing parameter to create image https://review.openstack.org/116738 | 22:01 |
| openstackgerrit | yunhong-jiang proposed a change to openstack/tempest: Test boot from volume checking https://review.openstack.org/116739 | 22:01 |
| *** jamielennox|away has quit IRC | 22:01 | |
| mtreinish | adam_g: I finally think that I understand why that test fails. It's converting a dict into a string for the error message and comparing that with the error msg generated from running the matcher. | 22:02 |
| mtreinish | but if the dict order changes the strings aren't equal | 22:02 |
| adam_g | mtreinish, sounds about right, and similar to the xml issue | 22:02 |
| *** dims has quit IRC | 22:03 | |
| *** jamielennox|away has joined #openstack-qa | 22:03 | |
| mtreinish | I'm just not sure how to best fix it. An ordered dict doesn't work because the __str__() isn't the same as a dict. | 22:04 |
| *** ajo__ has quit IRC | 22:04 | |
| *** ajo|mac has joined #openstack-qa | 22:05 | |
| *** dims has joined #openstack-qa | 22:05 | |
| mtreinish | oh nm, we just shouldn't print the raw dict and format it in a sorted order | 22:06 |
| *** dims_ has quit IRC | 22:06 | |
| *** gordc has quit IRC | 22:06 | |
| *** mitz has quit IRC | 22:06 | |
| *** zz_johnthetubagu has quit IRC | 22:06 | |
| openstackgerrit | Clark Boylan proposed a change to openstack-infra/devstack-gate: Simplify multinode setup https://review.openstack.org/114972 | 22:06 |
| openstackgerrit | Clark Boylan proposed a change to openstack-infra/devstack-gate: multi-node dg setup https://review.openstack.org/106043 | 22:06 |
| *** ajo|mac is now known as ajo__ | 22:07 | |
| *** timello has quit IRC | 22:08 | |
| *** dims has quit IRC | 22:08 | |
| *** dims has joined #openstack-qa | 22:09 | |
| *** jgrimm has joined #openstack-qa | 22:09 | |
| *** dims has quit IRC | 22:10 | |
| *** dims_ has joined #openstack-qa | 22:10 | |
| *** zz_johnthetubagu has joined #openstack-qa | 22:10 | |
| *** zz_johnthetubagu is now known as johnthetubaguy | 22:10 | |
| *** ajo__ has quit IRC | 22:12 | |
| *** HenryG_ has joined #openstack-qa | 22:12 | |
| *** marun_ has joined #openstack-qa | 22:13 | |
| *** timello has joined #openstack-qa | 22:13 | |
| *** cmyster has quit IRC | 22:14 | |
| *** rfolco has quit IRC | 22:14 | |
| openstackgerrit | A change was merged to openstack/tempest: Add compute tags to tempest/api/database/flavors test https://review.openstack.org/110975 | 22:15 |
| *** marun has quit IRC | 22:15 | |
| *** HenryG has quit IRC | 22:15 | |
| openstackgerrit | Adam Gandelman proposed a change to openstack/tempest: Ensure proper ordering of XML arguments https://review.openstack.org/116147 | 22:16 |
| *** sballe__ has joined #openstack-qa | 22:16 | |
| *** sballe_ has quit IRC | 22:19 | |
| openstackgerrit | Adam Gandelman proposed a change to openstack/tempest: Ensure proper ordering of XML arguments https://review.openstack.org/116147 | 22:20 |
| *** markmcclain has quit IRC | 22:21 | |
| adam_g | sdague, this got bit by the marconi rename https://review.openstack.org/#/c/114087/ | 22:21 |
| openstackgerrit | Liping Mao proposed a change to openstack-dev/devstack: neutron metering default driver is noop https://review.openstack.org/116537 | 22:23 |
| *** dustins has quit IRC | 22:26 | |
| *** ArxCruz has quit IRC | 22:27 | |
| *** rfolco has joined #openstack-qa | 22:28 | |
| *** cmyster has joined #openstack-qa | 22:28 | |
| *** cmyster has quit IRC | 22:28 | |
| *** cmyster has joined #openstack-qa | 22:28 | |
| *** aysyd has quit IRC | 22:32 | |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack-dev/devstack: Allow devstack to build ironic agent ramdisk https://review.openstack.org/114408 | 22:34 |
| *** rbak_ has joined #openstack-qa | 22:35 | |
| openstackgerrit | Matthew Treinish proposed a change to openstack/tempest: Make unit tests not depend on random hash seed https://review.openstack.org/116741 | 22:36 |
| mtreinish | adam_g: ^^^ I think that should fix all the unit test issues | 22:36 |
| *** rbak has quit IRC | 22:37 | |
| adam_g | mtreinish, nice | 22:45 |
| openstackgerrit | Matthew Treinish proposed a change to openstack/tempest: Make unit tests not depend on random hash seed https://review.openstack.org/116741 | 22:46 |
| openstackgerrit | Adam Gandelman proposed a change to openstack/tempest: Remove PYTHONHASHSEED=0 (do not merge) https://review.openstack.org/116744 | 22:47 |
| *** weshay has joined #openstack-qa | 22:48 | |
| *** krtaylor has quit IRC | 22:48 | |
| mtreinish | adam_g: ^^^ heh, you need to rebase that :) | 22:48 |
| adam_g | :) | 22:49 |
| openstackgerrit | Adam Gandelman proposed a change to openstack/tempest: Remove PYTHONHASHSEED=0 (do not merge) https://review.openstack.org/116744 | 22:50 |
| openstackgerrit | A change was merged to openstack-infra/elastic-recheck: Add query for keystone unit test xml hash bug 1361337 https://review.openstack.org/116705 | 22:50 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack-dev/devstack: Allow devstack to build ironic agent ramdisk https://review.openstack.org/114408 | 22:53 |
| *** jgrimm is now known as zz_jgrimm | 22:54 | |
| *** zul has quit IRC | 22:57 | |
| *** rbak_ has quit IRC | 22:58 | |
| *** dimtruck is now known as zz_dimtruck | 23:00 | |
| clarkb | is mriedem afk already? | 23:01 |
| clarkb | dtroyer: mtreinish sdague does https://review.openstack.org/#/c/115999/ need to be backported to icehouse and havana? | 23:01 |
| clarkb | there is a corresponding d-g change that required ^ to merge first but d-g runs against all branches so want to make sure before I merge the d-g change. 116001 is the d-g change | 23:02 |
| *** sabeen has joined #openstack-qa | 23:02 | |
| clarkb | it does look like havana and icehouse need that devstack change backported | 23:03 |
| *** markmcclain1 has joined #openstack-qa | 23:04 | |
| dtroyer | clarkb: yeah, if d-g is going to drop it it should be backported….we seem to be doing a lot of this lately…this one changes the default to be more permissive so I don't think it'll bite anyone else | 23:05 |
| clarkb | dtroyer: I am happy to -2 the d-g change and leave it as is until juno is the oldest supported branch | 23:06 |
| clarkb | dtroyer: its a bit of a lazy alternative but keeps from messing with stable devstack | 23:06 |
| dtroyer | clarkb: that's fine with me, it isn't an actual bug fix | 23:08 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack-dev/devstack: Allow devstack to build ironic agent ramdisk https://review.openstack.org/114408 | 23:09 |
| *** zul has joined #openstack-qa | 23:09 | |
| clarkb | dtroyer: maybe I will start with a -1 then upgrade to -2/abandon if there aren't any good reasons for backporting | 23:11 |
| *** oomichi has joined #openstack-qa | 23:16 | |
| *** oomichi is now known as oomichi_away | 23:17 | |
| *** jamielennox|away is now known as jamielennox | 23:17 | |
| *** Sukhdev has quit IRC | 23:17 | |
| *** sabeen has quit IRC | 23:17 | |
| *** sabeen has joined #openstack-qa | 23:18 | |
| *** krtaylor has joined #openstack-qa | 23:34 | |
| *** hemna is now known as hemna_ | 23:36 | |
| *** atiwari has quit IRC | 23:41 | |
| * gmann is back (gone 13:12:17) | 23:45 | |
| *** dims_ has quit IRC | 23:48 | |
| *** dims has joined #openstack-qa | 23:48 | |
| *** dims has quit IRC | 23:52 | |
| *** dims has joined #openstack-qa | 23:52 | |
| *** lyxus has joined #openstack-qa | 23:52 | |
| lyxus | Hello folks, I am running a CI and I am having some issue, the way that I do the patching is by specifying the NEUTRON_REPO and NEUTRON_BRANCH. I am seeing that some of the commit from github are not retrieved. Does anyone is experiencing the same issue ? | 23:53 |
| *** ildikov_ has quit IRC | 23:58 | |
| openstackgerrit | A change was merged to openstack/tempest: Add sec-group rules for ping6 and ssh -6 https://review.openstack.org/115927 | 23:59 |
| openstackgerrit | A change was merged to openstack/tempest: Add cases for Swift scenario test https://review.openstack.org/99514 | 23:59 |
| openstackgerrit | A change was merged to openstack-dev/devstack: Change httpd Keystone log level to default https://review.openstack.org/116132 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!