*** dustins has quit IRC | 00:02 | |
*** dhellmann has joined #openstack-qa | 00:07 | |
*** cshen has joined #openstack-qa | 00:12 | |
*** cshen has quit IRC | 00:16 | |
openstackgerrit | Felipe Monteiro proposed openstack/tempest master: Fix required projects for sanity plugin check job https://review.openstack.org/616059 | 00:24 |
---|---|---|
openstackgerrit | Felipe Monteiro proposed openstack/patrole master: Fix error codes for test_delete_flavor_service_profile https://review.openstack.org/616385 | 00:45 |
*** felipemonteiro has joined #openstack-qa | 01:19 | |
felipemonteiro | gmann: Replying to Neutron RBAC email you put in ML a while ago... I didn't have time to respond yet but I did file this bug: https://storyboard.openstack.org/#!/story/2004301 | 01:21 |
gmann | felipemonteiro: cool. so we will test it with [403, 404] right | 01:24 |
felipemonteiro | gmann: Maybe something like this: "expected_error_codes=[403, 404 if not rbac_rule_validation.allowed("delete_port") else None])" | 01:25 |
felipemonteiro | Because 404 is only raised if "delete" fails AND "get" fails | 01:26 |
felipemonteiro | And because if "get" is not allowed but "delete" is allowed, then for delete case it should pass.... | 01:27 |
felipemonteiro | Patrole will say it fails though | 01:27 |
*** brinzhang has joined #openstack-qa | 01:29 | |
gmann | felipemonteiro: does delete API enforce get policy also in neutron or just does get on DB ? | 01:30 |
gmann | felipemonteiro: if delete just check if resource there in DB then proceed with delete policy enforcement etc otherwise 404 | 01:31 |
gmann | then it will be different case. | 01:31 |
gmann | so we need to confirm first that 404 is because of resource not found or it can be from GET policy enforcement also | 01:33 |
felipemonteiro | gmann: It's explained in the bug pretty carefully. But Neutron will 1) check delete => if it fails => check get => if it fails 404; 2) check delete => if it fails => check get => if it passes => 403 | 01:34 |
felipemonteiro | gmann: here is example of neutron raising 404 on policy failure: https://github.com/openstack/neutron/blob/02edde5cbfe04208e9ecafea87e80b0a1a05c86f/neutron/api/v2/base.py#L593 | 01:36 |
felipemonteiro | But yes.... Neutron can also raise 404 if resource is not found | 01:36 |
gmann | felipemonteiro: ah i see. get check is to hide the resource existence info | 01:38 |
felipemonteiro | gmann: yes, it is quite tricky | 01:39 |
*** yamamoto has joined #openstack-qa | 01:45 | |
gmann | felipemonteiro: can we make like this - expected_error_codes=[403, 404 if not rbac_rule_validation.allowed("delete_port") else 403]) | 01:48 |
gmann | felipemonteiro: in that case we do not need to handle None hack in rbac_rule_validation | 01:49 |
*** mriedem has quit IRC | 01:50 | |
felipemonteiro | gmann: We need to handle case where 1) "delete" is allowed 2) "get" is *not* allowed => in this case Neutron will check "delete" and return 204. It will not perform "get" policy check. | 01:54 |
felipemonteiro | But then Patrole will still check 1) AND 2) and will say "delete" (allowed) + "get" (not allowed) => not allowed | 01:54 |
felipemonteiro | But... it is highly unlikely someone would configure RBAC to say delete is allowed, but get is not allowed... that would be pretty dumb... but still | 01:55 |
gmann | felipemonteiro: yeah so in that case patrole except 403 right | 01:57 |
gmann | felipemonteiro: as you wrote "delete" (allowed) + "get" (not allowed) => not allowed. but in story "Though this would require updating rbac_rule_validation slightly to account for None basically being success case" | 01:59 |
gmann | None was basically not allowed case right so check 403 in that case should pass the test | 01:59 |
felipemonteiro | Yeah I can make that change | 02:03 |
gmann | felipemonteiro: ok, other part looks good. only thing i am concern is we are testing via code checking :) not from policy doc etc. but for neutron that is ok i think | 02:05 |
gmann | we can bug amotoki again for neutron policy doc :) | 02:05 |
felipemonteiro | gmann: yeah neutron has no policy in code :( | 02:10 |
felipemonteiro | Or policy documentation in the policy in code I mean | 02:10 |
*** hongbin has joined #openstack-qa | 02:13 | |
openstackgerrit | Felipe Monteiro proposed openstack/tempest master: WIP: Whitelist for tempest-plugin-sanity job https://review.openstack.org/616393 | 02:25 |
openstackgerrit | Felipe Monteiro proposed openstack/tempest master: WIP: Whitelist for tempest-plugin-sanity job https://review.openstack.org/616393 | 02:25 |
*** felipemonteiro has quit IRC | 02:33 | |
*** markvoelker has joined #openstack-qa | 02:45 | |
*** markvoelker has quit IRC | 02:45 | |
*** markvoelker has joined #openstack-qa | 02:45 | |
*** yamamoto has quit IRC | 02:49 | |
*** markvoelker has quit IRC | 02:50 | |
*** felipemonteiro has joined #openstack-qa | 02:55 | |
*** markvoelker has joined #openstack-qa | 02:55 | |
*** fungi has quit IRC | 03:06 | |
*** fungi has joined #openstack-qa | 03:09 | |
*** fungi has quit IRC | 03:10 | |
*** larainema has joined #openstack-qa | 03:12 | |
*** felipemonteiro has quit IRC | 03:35 | |
*** felipemonteiro has joined #openstack-qa | 03:36 | |
*** fungi has joined #openstack-qa | 03:40 | |
*** fungi has quit IRC | 03:41 | |
*** fungi has joined #openstack-qa | 03:45 | |
*** felipemonteiro has quit IRC | 04:11 | |
openstackgerrit | zhufl proposed openstack/tempest master: Add response schema validation for volume manage https://review.openstack.org/608875 | 05:06 |
*** munimeha1 has quit IRC | 05:28 | |
*** yamamoto has joined #openstack-qa | 05:45 | |
openstackgerrit | Liron Kuchlani proposed openstack/tempest master: [Negative] Extend volume over quota limit https://review.openstack.org/612277 | 05:46 |
openstackgerrit | Ghanshyam Mann proposed openstack-dev/devstack master: DNM: Testing system-scope https://review.openstack.org/616415 | 05:48 |
openstackgerrit | Ghanshyam Mann proposed openstack-dev/devstack master: DNM: Testing system-scope-2 https://review.openstack.org/616416 | 05:54 |
openstackgerrit | Ghanshyam Mann proposed openstack-dev/devstack master: DNM: Testing system-scope-3 https://review.openstack.org/614486 | 05:56 |
openstackgerrit | Felipe Monteiro proposed openstack/patrole master: RequirementsAuthority multi role support enhancement https://review.openstack.org/614386 | 05:56 |
*** cshen has joined #openstack-qa | 05:56 | |
openstackgerrit | Ghanshyam Mann proposed openstack-dev/devstack master: DNM: Testing system-scope-1 https://review.openstack.org/616415 | 05:57 |
*** hongbin has quit IRC | 06:02 | |
*** cshen has quit IRC | 06:11 | |
openstackgerrit | Felipe Monteiro proposed openstack/patrole master: requirements authority: Use better exception/return code https://review.openstack.org/616422 | 06:17 |
openstackgerrit | Liron Kuchlani proposed openstack/tempest master: [Negative] Extend volume over quota limit https://review.openstack.org/612277 | 06:19 |
*** cshen has joined #openstack-qa | 06:24 | |
*** cshen has quit IRC | 06:28 | |
openstackgerrit | zhufl proposed openstack/tempest master: Add response schema validation for volume backups https://review.openstack.org/616429 | 06:36 |
*** ccamposr has joined #openstack-qa | 06:53 | |
*** brinzhang has quit IRC | 06:54 | |
*** brinzhang has joined #openstack-qa | 06:54 | |
*** ccamposr__ has joined #openstack-qa | 06:55 | |
*** ccamposr has quit IRC | 06:59 | |
*** gfidente has joined #openstack-qa | 07:13 | |
*** aojea has quit IRC | 07:15 | |
*** agurenko has joined #openstack-qa | 07:18 | |
*** aojea has joined #openstack-qa | 07:20 | |
*** brinzhang has quit IRC | 07:20 | |
*** brinzhang has joined #openstack-qa | 07:20 | |
*** agurenko has quit IRC | 07:20 | |
gmann | No office hour today and so for next week due to Summit. i will be around on IRC for query/discussions. | 07:23 |
*** cshen has joined #openstack-qa | 07:30 | |
amotoki | I don't think we can cover all things in policy-in-code documentation. | 07:32 |
amotoki | is it what you think? | 07:32 |
amotoki | gmann: ^ (felipe looks not online) | 07:33 |
*** pcaruana has joined #openstack-qa | 07:34 | |
*** slaweq has joined #openstack-qa | 07:39 | |
*** yamamoto has quit IRC | 07:46 | |
*** yamamoto has joined #openstack-qa | 07:46 | |
*** yamamoto has quit IRC | 07:47 | |
openstackgerrit | zhufl proposed openstack/tempest master: Add api ref link for import_backup https://review.openstack.org/616448 | 08:08 |
*** Luzi has joined #openstack-qa | 08:30 | |
*** yamamoto has joined #openstack-qa | 08:34 | |
*** jpena|off is now known as jpena | 08:36 | |
*** noama has joined #openstack-qa | 08:38 | |
*** yamamoto has quit IRC | 08:40 | |
*** yamamoto has joined #openstack-qa | 08:46 | |
*** yamamoto has quit IRC | 08:47 | |
*** yamamoto has joined #openstack-qa | 08:49 | |
*** sshnaidm|afk is now known as sshnaidm|rover | 08:54 | |
*** yamamoto has quit IRC | 09:13 | |
openstackgerrit | zhufl proposed openstack/tempest master: Add response schema validation for volume backups https://review.openstack.org/616429 | 09:17 |
*** shardy has joined #openstack-qa | 09:22 | |
*** lucasagomes has joined #openstack-qa | 09:35 | |
openstackgerrit | zhufl proposed openstack/tempest master: Add response schema validation for volume backups https://review.openstack.org/616429 | 09:47 |
*** CrayZee has joined #openstack-qa | 09:48 | |
*** CrayZee is now known as Guest31212 | 09:48 | |
*** Guest31212 has quit IRC | 09:49 | |
*** e0ne has joined #openstack-qa | 09:50 | |
*** snapiri- has joined #openstack-qa | 09:52 | |
*** yamamoto has joined #openstack-qa | 09:54 | |
*** dtantsur|afk is now known as dtantsur | 09:55 | |
*** mvkr has quit IRC | 09:58 | |
*** CrayZee- has joined #openstack-qa | 09:59 | |
*** CrayZee- has quit IRC | 09:59 | |
*** yamamoto has quit IRC | 10:00 | |
*** yamamoto has joined #openstack-qa | 10:04 | |
*** shardy has quit IRC | 10:07 | |
*** shardy has joined #openstack-qa | 10:09 | |
*** shardy has quit IRC | 10:14 | |
*** shardy has joined #openstack-qa | 10:19 | |
*** snapiri- has quit IRC | 10:19 | |
*** snapiri- has joined #openstack-qa | 10:20 | |
*** mvkr has joined #openstack-qa | 10:26 | |
*** brinzhang has quit IRC | 10:28 | |
*** CrayZee has joined #openstack-qa | 10:29 | |
*** snapiri- has quit IRC | 10:32 | |
*** shardy has quit IRC | 10:38 | |
*** shardy has joined #openstack-qa | 10:39 | |
*** shardy has quit IRC | 10:44 | |
*** CrayZee_ has joined #openstack-qa | 11:00 | |
*** CrayZee has quit IRC | 11:02 | |
*** larainema has quit IRC | 11:05 | |
*** yamamoto has quit IRC | 11:10 | |
*** yamamoto has joined #openstack-qa | 11:14 | |
*** cshen has quit IRC | 11:29 | |
*** CrayZee_ has quit IRC | 11:31 | |
*** ondrejme has joined #openstack-qa | 11:44 | |
ondrejme | Hello, has this bug been resolved in Tempest yet? https://review.openstack.org/#/c/511493/ | 11:47 |
ondrejme | According to the comments, it was wrongly reported to tripleo instead to Tempest project | 11:48 |
*** cshen has joined #openstack-qa | 12:02 | |
*** jpena is now known as jpena|lunch | 12:03 | |
*** Luzi has quit IRC | 12:05 | |
*** cshen has quit IRC | 12:07 | |
*** raildo has joined #openstack-qa | 12:17 | |
*** Luzi has joined #openstack-qa | 12:20 | |
*** cshen has joined #openstack-qa | 12:23 | |
*** dtantsur is now known as dtantsur|brb | 12:32 | |
gmann | ondrejme: orchestration tests are no longer in Tempest since long. what version of Tempest you are using ? | 12:58 |
gmann | amotoki: kind of yes, but as many as possible is good for us | 12:59 |
*** e0ne has quit IRC | 13:03 | |
*** yamamoto has quit IRC | 13:07 | |
*** yamamoto has joined #openstack-qa | 13:09 | |
ondrejme | I see, guess i'll just skip this test as well. Thanks | 13:13 |
*** yamamoto has quit IRC | 13:14 | |
*** jpena|lunch is now known as jpena | 13:24 | |
*** dustins has joined #openstack-qa | 13:35 | |
gmann | ondrejme: yeah, that is good options. | 13:36 |
*** e0ne has joined #openstack-qa | 13:37 | |
*** aojea_ has joined #openstack-qa | 13:48 | |
*** rh-jelabarre has joined #openstack-qa | 13:51 | |
*** yamamoto has joined #openstack-qa | 13:58 | |
*** aojea_ has quit IRC | 14:02 | |
*** aojea has quit IRC | 14:02 | |
*** irclogbot_2 has quit IRC | 14:02 | |
*** witek has quit IRC | 14:02 | |
*** artom has quit IRC | 14:02 | |
*** pleia2 has quit IRC | 14:02 | |
*** tonyb has quit IRC | 14:02 | |
*** FrankZhang has quit IRC | 14:02 | |
*** dmellado has quit IRC | 14:02 | |
*** mattoliverau has quit IRC | 14:02 | |
*** cshen has quit IRC | 14:03 | |
*** yamamoto has quit IRC | 14:03 | |
*** aojea has joined #openstack-qa | 14:03 | |
*** dmellado has joined #openstack-qa | 14:04 | |
*** witek has joined #openstack-qa | 14:04 | |
*** aojea has quit IRC | 14:04 | |
*** aojea_ has joined #openstack-qa | 14:04 | |
*** aojea has joined #openstack-qa | 14:04 | |
*** pleia2 has joined #openstack-qa | 14:07 | |
*** tonyb has joined #openstack-qa | 14:07 | |
*** mriedem has joined #openstack-qa | 14:13 | |
*** aojea has quit IRC | 14:20 | |
openstackgerrit | Felipe Monteiro proposed openstack/patrole master: RequirementsAuthority multi role support enhancement https://review.openstack.org/614386 | 14:42 |
openstackgerrit | Felipe Monteiro proposed openstack/patrole master: RequirementsAuthority multi role support enhancement https://review.openstack.org/614386 | 14:44 |
*** awaugama has joined #openstack-qa | 14:54 | |
*** aojea has joined #openstack-qa | 14:57 | |
*** dtantsur|brb is now known as dtantsur | 15:02 | |
*** mvkr has quit IRC | 15:04 | |
openstackgerrit | Sorin Sbarnea proposed openstack-infra/elastic-recheck master: Preparatory fixes for py3 https://review.openstack.org/616578 | 15:07 |
*** shardy has joined #openstack-qa | 15:08 | |
*** shardy has quit IRC | 15:09 | |
*** shardy has joined #openstack-qa | 15:09 | |
*** shardy has quit IRC | 15:09 | |
*** shardy has joined #openstack-qa | 15:11 | |
openstackgerrit | Sorin Sbarnea proposed openstack-infra/elastic-recheck master: Move all zull jobs definitions inside repo https://review.openstack.org/616582 | 15:17 |
*** mvkr has joined #openstack-qa | 15:20 | |
*** agurenko has joined #openstack-qa | 15:22 | |
*** agurenko has quit IRC | 15:23 | |
*** shardy has quit IRC | 15:40 | |
*** rajinir has joined #openstack-qa | 15:42 | |
*** artom has joined #openstack-qa | 15:54 | |
*** aojea_ has quit IRC | 15:56 | |
*** aojea_ has joined #openstack-qa | 15:56 | |
*** aojea_ has quit IRC | 15:58 | |
*** aojea_ has joined #openstack-qa | 15:58 | |
*** aojea_ has quit IRC | 16:03 | |
*** noama has quit IRC | 16:06 | |
*** ccamposr__ has quit IRC | 16:08 | |
*** aojea_ has joined #openstack-qa | 16:09 | |
*** pcaruana has quit IRC | 16:14 | |
*** mvkr has quit IRC | 16:16 | |
*** Luzi has quit IRC | 16:22 | |
*** mvkr has joined #openstack-qa | 16:28 | |
*** yamamoto has joined #openstack-qa | 16:40 | |
*** slaweq has quit IRC | 16:40 | |
*** yamamoto has quit IRC | 16:44 | |
*** sshnaidm|rover is now known as sshnaidm|notrove | 16:46 | |
*** e0ne has quit IRC | 16:48 | |
openstackgerrit | Sorin Sbarnea proposed openstack-infra/elastic-recheck master: Add check for failed to connect to mirror.*.openstack.org https://review.openstack.org/608968 | 16:49 |
*** sshnaidm|notrove is now known as sshnaidm|wknd | 16:53 | |
*** slaweq has joined #openstack-qa | 16:58 | |
*** michael-beaver has joined #openstack-qa | 17:01 | |
*** ondrejme has quit IRC | 17:15 | |
*** gfidente has quit IRC | 17:19 | |
*** aojea_ has quit IRC | 17:35 | |
*** mvkr has quit IRC | 17:35 | |
*** sshnaidm|wknd is now known as sshnaidm|off | 17:42 | |
*** jpena is now known as jpena|off | 17:51 | |
*** irclogbot_2 has joined #openstack-qa | 18:00 | |
*** pcaruana has joined #openstack-qa | 18:10 | |
*** aojea_ has joined #openstack-qa | 18:15 | |
*** aojea_ has quit IRC | 18:44 | |
*** Michael_Beaver has joined #openstack-qa | 18:47 | |
*** michael-beaver has quit IRC | 18:51 | |
*** Michael_Beaver has quit IRC | 18:52 | |
*** aojea_ has joined #openstack-qa | 19:17 | |
*** dustins has quit IRC | 19:26 | |
*** dustins has joined #openstack-qa | 19:26 | |
*** mriedem has quit IRC | 19:32 | |
*** aojea has quit IRC | 19:44 | |
*** aojea_ has quit IRC | 19:49 | |
*** awaugama has quit IRC | 19:49 | |
*** dave-mccowan has joined #openstack-qa | 19:56 | |
*** mriedem has joined #openstack-qa | 19:59 | |
*** e0ne has joined #openstack-qa | 20:19 | |
*** e0ne has quit IRC | 20:22 | |
*** awaugama has joined #openstack-qa | 20:23 | |
*** cshen has joined #openstack-qa | 20:28 | |
*** dave-mccowan has quit IRC | 20:33 | |
*** cshen has quit IRC | 20:36 | |
*** raildo has quit IRC | 20:37 | |
*** aojea has joined #openstack-qa | 20:41 | |
*** mriedem has quit IRC | 20:41 | |
*** cshen has joined #openstack-qa | 20:45 | |
*** mriedem has joined #openstack-qa | 20:45 | |
*** rh-jelabarre has quit IRC | 20:48 | |
openstackgerrit | Mykola Yakovliev proposed openstack/patrole master: Add tests to cover service_profile https://review.openstack.org/597216 | 20:50 |
*** cshen has quit IRC | 20:54 | |
*** cshen has joined #openstack-qa | 20:57 | |
*** aojea has quit IRC | 21:14 | |
*** mriedem has left #openstack-qa | 21:18 | |
*** aojea has joined #openstack-qa | 21:47 | |
*** artom has quit IRC | 21:53 | |
*** aojea has quit IRC | 21:58 | |
*** aojea has joined #openstack-qa | 21:59 | |
*** manjeets has quit IRC | 22:00 | |
*** mattoliverau has joined #openstack-qa | 22:07 | |
*** cshen has quit IRC | 22:29 | |
*** dustins has quit IRC | 22:36 | |
*** mriedem has joined #openstack-qa | 22:36 | |
*** mriedem has quit IRC | 22:46 | |
*** manjeets has joined #openstack-qa | 22:54 | |
*** awaugama has quit IRC | 23:02 | |
*** artom has joined #openstack-qa | 23:14 | |
*** slaweq has quit IRC | 23:15 | |
*** cshen has joined #openstack-qa | 23:33 | |
*** cshen has quit IRC | 23:38 | |
*** aojea has quit IRC | 23:50 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!