| *** rh-jelabarre has joined #openstack-qa | 00:05 | |
| *** mattw4 has quit IRC | 00:06 | |
| aspiers | gmann: I'm writing my first ever tempest tests :) | 00:19 |
|---|---|---|
| aspiers | but I'm getting "Failures during discovery" | 00:20 |
| aspiers | "The above traceback was encountered during test discovery which imports all the found test modules in the specified test_path." | 00:20 |
| aspiers | but there is no traceback listed | 00:20 |
| aspiers | mtreinish, masayukig: could this be an stestr issue? | 00:20 |
| clarkb | aspiers: probably is a stestr issuem One way to figure it out is to import the modules that changed yourself outside of stestr | 00:21 |
| aspiers | good idea | 00:21 |
| aspiers | clarkb: import succeeds | 00:22 |
| aspiers | ahhh found it via tox -e py36 | 00:23 |
| aspiers | Unhandled error: ValueError: Duplicate test ids detected: ... | 00:23 |
| aspiers | even though check-uuid passes | 00:24 |
| aspiers | bah | 00:24 |
| aspiers | and actually I see no duplicate | 00:25 |
| aspiers | ohhh | 00:25 |
| aspiers | I guess I can't inherit a scenario from another scenario? | 00:26 |
| aspiers | bah | 00:26 |
| gmann | aspiers: you can run the tox -e uuidgen to fix the test id | 00:28 |
| aspiers | gmann: I already tried that | 00:28 |
| aspiers | gmann: my test ids are fine, I think it's because I was inheriting a scenario from a scenario | 00:29 |
| gmann | aspiers: you can inherit but the test case will be separate so deos the test id | 00:29 |
| gmann | i did not get you are adding new scenario test class inherited from exiting ? | 00:29 |
| aspiers | yes | 00:29 |
| gmann | that should work fine | 00:30 |
| aspiers | I'm scrapping the inheritance to see if it fixes it | 00:30 |
| gmann | you have patch up or pastelink ? | 00:30 |
| aspiers | not yet | 00:31 |
| aspiers | OK now it works | 00:32 |
| aspiers | Yes that was the problem | 00:32 |
| aspiers | Inheriting duplicates ids | 00:32 |
| aspiers | gmann: how do I create a flavor from a scenario? | 00:33 |
| aspiers | I want to use BaseV2ComputeAdminTest.create_flavor() | 00:34 |
| aspiers | since that has the cleanup built-in | 00:34 |
| gmann | aspiers: nice. for base function you can find all base method in scenario/manager.py | 00:35 |
| gmann | let me check if we have create flavor gthere | 00:35 |
| gmann | there | 00:35 |
| aspiers | gmann: yes I found them but there is no create_flavor | 00:35 |
| aspiers | only flavors_client | 00:35 |
| aspiers | perhaps methods like that could be moved to a mixin? | 00:36 |
| aspiers | so they can be used by scenarios and API tests | 00:36 |
| aspiers | anyway gotta sleep | 00:37 |
| aspiers | let me know if there is a good solution to this :) | 00:37 |
| gmann | aspiers: yeah that is i was thinking to move to common/compute.py | 00:37 |
| gmann | aspiers: here - https://github.com/openstack/tempest/blob/master/tempest/common/compute.py | 00:38 |
| *** artom has quit IRC | 00:38 | |
| gmann | aspiers: you can do in your patch also or if you want i can move that in separate patch and make it ready for you | 00:38 |
| aspiers | great thanks! | 00:41 |
| aspiers | gmann: ah wait, I can't use addCleanup in common/compute.py | 00:42 |
| aspiers | I think a mixin would be better | 00:42 |
| aspiers | well, OK the mixin could be in common/compute | 00:42 |
| gmann | oh yeah cleanup has to be done on base class side. | 00:42 |
| aspiers | I can move create_flavor into a new mixin in common/compute.py, and then BaseV2ComputeAdminTest and manager.ScenarioTest can both use that mixin | 00:43 |
| aspiers | makes sense? | 00:43 |
| gmann | and d the cleanu in BaseV2ComputeAdminTest and manager.ScenarioTest ? | 00:44 |
| aspiers | no create_flavor in the mixin will do addCleanup | 00:44 |
| gmann | but that would give much benefit | 00:44 |
| gmann | mixin will be more complex in this. | 00:44 |
| aspiers | I think it will be simple ;-) but I can submit a patch and you can review | 00:45 |
| gmann | i mean just for create_flavor | 00:45 |
| aspiers | it's not just create_flavor | 00:45 |
| aspiers | I need other methods | 00:45 |
| aspiers | e.g. set_flavor_extra_spec | 00:45 |
| aspiers | create_image | 00:45 |
| aspiers | etc. | 00:45 |
| aspiers | I think this code sharing is better than duplication | 00:46 |
| gmann | ok, let's see on review how much it save. ping me link once you are ready | 00:47 |
| *** markvoelker has joined #openstack-qa | 00:51 | |
| *** markvoelker has quit IRC | 00:56 | |
| *** brinzhang_ has joined #openstack-qa | 00:57 | |
| *** brinzhang has quit IRC | 01:00 | |
| *** bigdogstl has joined #openstack-qa | 01:05 | |
| *** bigdogstl has quit IRC | 01:08 | |
| *** slaweq has joined #openstack-qa | 01:11 | |
| *** mattw4 has joined #openstack-qa | 01:11 | |
| *** slaweq has quit IRC | 01:16 | |
| *** spsurya has joined #openstack-qa | 01:28 | |
| *** hongbin has joined #openstack-qa | 02:13 | |
| *** dave-mccowan has quit IRC | 02:38 | |
| *** rh-jelabarre has quit IRC | 02:55 | |
| *** larainema has joined #openstack-qa | 03:01 | |
| *** slaweq has joined #openstack-qa | 03:11 | |
| *** slaweq has quit IRC | 03:16 | |
| openstackgerrit | Masayuki Igawa proposed openstack/tempest master: [DNM] testing https://review.opendev.org/680563 | 03:28 |
| *** slaweq has joined #openstack-qa | 03:32 | |
| *** mvkr has joined #openstack-qa | 03:34 | |
| *** rfolco has quit IRC | 03:38 | |
| *** soniya29 has joined #openstack-qa | 03:44 | |
| *** ramishra has joined #openstack-qa | 04:04 | |
| *** igordc has joined #openstack-qa | 04:10 | |
| *** early has quit IRC | 04:12 | |
| *** early has joined #openstack-qa | 04:15 | |
| *** igordc has quit IRC | 04:23 | |
| *** hongbin has quit IRC | 04:35 | |
| *** Luzi has joined #openstack-qa | 04:52 | |
| *** markvoelker has joined #openstack-qa | 05:15 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/tempest master: DNM:testing legacy https://review.opendev.org/680233 | 05:19 |
| *** markvoelker has quit IRC | 05:20 | |
| *** pcaruana has joined #openstack-qa | 05:25 | |
| *** udesale has joined #openstack-qa | 05:54 | |
| *** mattw4 has quit IRC | 06:00 | |
| *** raukadah is now known as chandankumar | 06:03 | |
| *** surpatil has joined #openstack-qa | 06:03 | |
| *** markvoelker has joined #openstack-qa | 06:06 | |
| *** markvoelker has quit IRC | 06:10 | |
| *** brinzhang_ has quit IRC | 06:14 | |
| *** brinzhang_ has joined #openstack-qa | 06:15 | |
| *** brinzhang_ has quit IRC | 06:16 | |
| *** xinranwang has joined #openstack-qa | 06:24 | |
| *** markvoelker has joined #openstack-qa | 06:36 | |
| *** kopecmartin|off is now known as kopecmartin | 06:36 | |
| *** markvoelker has quit IRC | 06:41 | |
| *** trident has quit IRC | 06:53 | |
| *** haixin has joined #openstack-qa | 07:04 | |
| *** trident has joined #openstack-qa | 07:04 | |
| *** markvoelker has joined #openstack-qa | 07:06 | |
| *** rcernin|brb has quit IRC | 07:10 | |
| *** tesseract has joined #openstack-qa | 07:11 | |
| *** markvoelker has quit IRC | 07:11 | |
| *** markvoelker has joined #openstack-qa | 07:16 | |
| *** brinzhang has joined #openstack-qa | 07:17 | |
| *** ccamposr__ has joined #openstack-qa | 07:19 | |
| *** markvoelker has quit IRC | 07:20 | |
| *** ccamposr has quit IRC | 07:21 | |
| *** gfidente has joined #openstack-qa | 07:35 | |
| *** jpena|off is now known as jpena | 07:41 | |
| *** pcaruana has quit IRC | 08:08 | |
| *** pcaruana has joined #openstack-qa | 08:13 | |
| *** surpatil has quit IRC | 08:14 | |
| *** soniya29 has quit IRC | 08:15 | |
| *** e0ne has joined #openstack-qa | 08:24 | |
| *** trident has quit IRC | 08:40 | |
| *** xinranwang has quit IRC | 08:45 | |
| *** tosky has joined #openstack-qa | 08:49 | |
| *** trident has joined #openstack-qa | 08:51 | |
| *** zigo has quit IRC | 08:57 | |
| *** surpatil has joined #openstack-qa | 09:05 | |
| *** zigo has joined #openstack-qa | 09:06 | |
| *** slaweq has quit IRC | 09:06 | |
| *** rfolco has joined #openstack-qa | 09:07 | |
| *** markvoelker has joined #openstack-qa | 09:10 | |
| *** markvoelker has quit IRC | 09:20 | |
| *** slaweq has joined #openstack-qa | 09:36 | |
| *** dtantsur|afk is now known as dtantsur | 09:37 | |
| *** gcheresh has joined #openstack-qa | 09:59 | |
| *** artom has joined #openstack-qa | 10:07 | |
| *** gcheresh has quit IRC | 10:08 | |
| *** gcheresh has joined #openstack-qa | 10:16 | |
| *** haixin has quit IRC | 10:19 | |
| *** gcheresh has quit IRC | 10:53 | |
| *** ccamposr__ has quit IRC | 10:57 | |
| *** ccamposr has joined #openstack-qa | 10:58 | |
| *** ccamposr__ has joined #openstack-qa | 11:19 | |
| *** brinzhang has quit IRC | 11:19 | |
| *** ccamposr has quit IRC | 11:22 | |
| *** jpena is now known as jpena|lunch | 11:36 | |
| *** gcheresh has joined #openstack-qa | 11:40 | |
| *** surpatil has quit IRC | 11:40 | |
| *** surpatil has joined #openstack-qa | 11:42 | |
| *** rh-jelabarre has joined #openstack-qa | 11:46 | |
| *** ccamposr__ has quit IRC | 11:53 | |
| *** johnsom has quit IRC | 11:53 | |
| *** jpena|lunch has quit IRC | 11:54 | |
| *** johnsom has joined #openstack-qa | 11:55 | |
| *** jpena has joined #openstack-qa | 11:56 | |
| *** rcernin|brb has joined #openstack-qa | 12:03 | |
| *** larainema has quit IRC | 12:17 | |
| *** spsurya has quit IRC | 12:26 | |
| *** gcheresh has quit IRC | 12:27 | |
| *** dave-mccowan has joined #openstack-qa | 12:29 | |
| *** rcernin|brb has quit IRC | 12:30 | |
| *** dave-mccowan has quit IRC | 12:31 | |
| *** gcheresh has joined #openstack-qa | 12:34 | |
| *** gcheresh has quit IRC | 12:39 | |
| *** markvoelker has joined #openstack-qa | 12:45 | |
| *** mriedem has joined #openstack-qa | 12:46 | |
| *** ccamposr has joined #openstack-qa | 13:02 | |
| *** nweinber_ has joined #openstack-qa | 13:15 | |
| *** gcheresh has joined #openstack-qa | 13:16 | |
| *** nweinber_ has quit IRC | 13:19 | |
| *** nweinber has joined #openstack-qa | 13:20 | |
| *** yamamoto has quit IRC | 13:26 | |
| *** yamamoto has joined #openstack-qa | 13:27 | |
| *** surpatil has quit IRC | 13:30 | |
| *** gcheresh has quit IRC | 13:31 | |
| *** nweinber has quit IRC | 13:35 | |
| *** nweinber has joined #openstack-qa | 13:35 | |
| *** gfidente has quit IRC | 13:46 | |
| *** udesale has quit IRC | 13:56 | |
| *** udesale has joined #openstack-qa | 13:57 | |
| *** Luzi has quit IRC | 13:59 | |
| *** lbragstad has quit IRC | 14:04 | |
| *** lbragstad has joined #openstack-qa | 14:07 | |
| *** markvoelker has quit IRC | 14:07 | |
| mtreinish | aspiers: there is a bug with stestr <2.5.0 around duplicate id checking on python 3 (because of testtools) for inherited classes | 14:24 |
| aspiers | mtreinish: ah thanks! wow, that was a pretty niche bug I managed to hit ... | 14:24 |
| aspiers | mtreinish: I'm not inheriting scenarios any more though - realised I didn't need to | 14:24 |
| aspiers | mtreinish: does it make sense to bump test-requirements.txt to stestr>=2.5.0 for projects now? | 14:25 |
| mtreinish | aspiers: it does, and I've been pushing for it. But tempest is blocked from doing that because of: https://github.com/testing-cabal/testtools/issues/272 | 14:28 |
| aspiers | mtreinish: ah right, does that affect skipUnless too? | 14:29 |
| mtreinish | it doesn't typically effect decorators (depending on how they're implemented) because the decorator normally sets a attr on the test method instead of raising an exception | 14:31 |
| aspiers | OK | 14:31 |
| aspiers | mtreinish: Is it considered good/bad practice for tempest tests to check the message string of exceptions returned by assertRaises? | 14:33 |
| aspiers | I'm thinking that if e.g. nova devs wanted to reword an exception's message string, this could break tempest | 14:33 |
| aspiers | and then you'd need a circular Depends-On across repos to fix it | 14:33 |
| aspiers | or something | 14:33 |
| aspiers | OTOH, just checking that it's a BadRequest or whatever is maybe too vague? | 14:34 |
| mtreinish | aspiers: it depends, normally inspecting a body from a response is fair game because those are supposed to be consistent for a given microversion. | 14:35 |
| mtreinish | It depends on what the particular contract and expectations are from the service side are for a given api's error response though | 14:35 |
| mtreinish | because the error space for a particular api isn't always well defined | 14:36 |
| aspiers | mtreinish: Thanks. Asking in #openstack-nova too in case there is a Nova-specific answer | 14:38 |
| *** mattw4 has joined #openstack-qa | 14:42 | |
| *** mattw4 has quit IRC | 14:49 | |
| *** mattw4 has joined #openstack-qa | 14:49 | |
| *** markvoelker has joined #openstack-qa | 14:51 | |
| *** chandankumar is now known as raukadah | 14:54 | |
| *** markvoelker has quit IRC | 14:55 | |
| *** mattw4 has quit IRC | 14:57 | |
| *** yamamoto has quit IRC | 15:01 | |
| *** yamamoto has joined #openstack-qa | 15:02 | |
| *** yamamoto has quit IRC | 15:02 | |
| *** yamamoto has joined #openstack-qa | 15:03 | |
| *** yamamoto has quit IRC | 15:07 | |
| *** jdwidari has joined #openstack-qa | 15:07 | |
| *** gfidente has joined #openstack-qa | 15:15 | |
| openstackgerrit | Clark Boylan proposed openstack/devstack master: DNM: Debug worlddump output collection https://review.opendev.org/680340 | 15:15 |
| clarkb | frickler: ^ I think the last patchset failed too early for /opt/stack/logs to exist? | 15:15 |
| clarkb | I want to see if the file copy happens if we error at the end of stack.sh (then we can work backward and fix problems with early fails if necessary) | 15:15 |
| *** trident has quit IRC | 15:37 | |
| *** yamamoto has joined #openstack-qa | 15:38 | |
| *** yamamoto has quit IRC | 15:43 | |
| *** dtantsur is now known as dtantsur|afk | 15:44 | |
| *** trident has joined #openstack-qa | 15:46 | |
| *** mattw4 has joined #openstack-qa | 15:51 | |
| *** tesseract has quit IRC | 15:52 | |
| *** mriedem is now known as mriedem_lunch | 16:11 | |
| *** kopecmartin is now known as kopecmartin|off | 16:36 | |
| *** pcaruana has quit IRC | 16:37 | |
| *** e0ne has quit IRC | 16:39 | |
| *** jpena is now known as jpena|off | 16:48 | |
| *** gfidente has quit IRC | 16:50 | |
| *** pcaruana has joined #openstack-qa | 16:51 | |
| *** tosky has quit IRC | 16:58 | |
| *** markvoelker has joined #openstack-qa | 17:25 | |
| *** yamamoto has joined #openstack-qa | 17:27 | |
| *** udesale has quit IRC | 17:27 | |
| *** ramishra has quit IRC | 17:31 | |
| *** yamamoto has quit IRC | 17:32 | |
| *** mriedem_lunch is now known as mriedem | 17:38 | |
| *** mvkr has quit IRC | 17:55 | |
| *** markvoelker has quit IRC | 17:57 | |
| *** e0ne has joined #openstack-qa | 17:59 | |
| *** markvoelker has joined #openstack-qa | 18:03 | |
| *** yamamoto has joined #openstack-qa | 18:04 | |
| *** yamamoto has quit IRC | 18:09 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/tempest master: Add response schema validation for volume transfer https://review.opendev.org/608898 | 18:11 |
| *** markvoelker has quit IRC | 18:12 | |
| *** e0ne has quit IRC | 18:15 | |
| *** markvoelker has joined #openstack-qa | 18:15 | |
| *** markvoelker has quit IRC | 18:26 | |
| *** markvoelker has joined #openstack-qa | 18:28 | |
| *** markvoelker has quit IRC | 18:38 | |
| *** igordc has joined #openstack-qa | 18:53 | |
| *** markvoelker has joined #openstack-qa | 19:11 | |
| *** markvoelker has quit IRC | 19:15 | |
| *** markvoelker has joined #openstack-qa | 19:41 | |
| *** markvoelker has quit IRC | 19:45 | |
| *** yamamoto has joined #openstack-qa | 19:53 | |
| *** yamamoto has quit IRC | 19:59 | |
| *** nweinber has quit IRC | 20:00 | |
| *** markvoelker has joined #openstack-qa | 20:19 | |
| *** markvoelker has quit IRC | 20:29 | |
| *** rfolco has quit IRC | 20:50 | |
| *** markvoelker has joined #openstack-qa | 20:50 | |
| *** markvoelker has quit IRC | 20:54 | |
| openstackgerrit | Merged openstack/tempest master: Add response schema validation for volume quota_set https://review.opendev.org/603339 | 21:02 |
| *** rcernin|brb has joined #openstack-qa | 21:19 | |
| *** rcernin|brb has quit IRC | 21:33 | |
| *** mriedem has quit IRC | 21:41 | |
| *** yamamoto has joined #openstack-qa | 21:50 | |
| openstackgerrit | Adam Spiers proposed openstack/tempest master: Add tests for basic server operations on AMD SEV compute hosts https://review.opendev.org/680777 | 21:50 |
| *** yamamoto has quit IRC | 21:55 | |
| *** e0ne has joined #openstack-qa | 22:02 | |
| *** markvoelker has joined #openstack-qa | 22:15 | |
| *** markvoelker has quit IRC | 22:20 | |
| *** e0ne has quit IRC | 22:34 | |
| *** rfolco has joined #openstack-qa | 22:38 | |
| *** yamamoto has joined #openstack-qa | 23:02 | |
| *** mattw4 has quit IRC | 23:05 | |
| *** yamamoto has quit IRC | 23:07 | |
| *** yamamoto has joined #openstack-qa | 23:40 | |
| *** yamamoto has quit IRC | 23:45 | |
| openstackgerrit | Clark Boylan proposed openstack/devstack master: DNM: Debug worlddump output collection https://review.opendev.org/680340 | 23:46 |
| clarkb | frickler: ^ now testing without the regex | 23:46 |
| *** mtreinish has quit IRC | 23:49 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!