Thursday, 2019-10-10

« Wednesday, 2019-10-09 Index Friday, 2019-10-11 »
*** slaweq has quit IRC00:01
*** brinzhang_ has quit IRC00:06
*** brinzhang_ has joined #openstack-qa00:06
*** brinzhang has quit IRC00:07
*** brinzhang has joined #openstack-qa00:08
*** bigdogstl has quit IRC00:10
*** markvoelker has joined #openstack-qa00:19
*** markvoelker has quit IRC00:30
*** brinzhang has quit IRC00:30
*** brinzhang_ has quit IRC00:30
*** brinzhang has joined #openstack-qa00:30
*** brinzhang_ has joined #openstack-qa00:30
*** brinzhang_ has quit IRC00:41
*** brinzhang has quit IRC00:41
*** brinzhang has joined #openstack-qa00:42
*** brinzhang_ has joined #openstack-qa00:42
*** hongbin has joined #openstack-qa00:52
*** brinzhang has quit IRC00:52
*** brinzhang_ has quit IRC00:53
*** brinzhang has joined #openstack-qa00:53
*** brinzhang_ has joined #openstack-qa00:53
*** brinzhang_ has quit IRC01:02
*** brinzhang_ has joined #openstack-qa01:02
*** brinzhang has quit IRC01:02
*** brinzhang has joined #openstack-qa01:03
*** slaweq has joined #openstack-qa01:11
*** yamamoto has quit IRC01:12
*** slaweq has quit IRC01:15
*** brinzhang has quit IRC01:15
*** brinzhang has joined #openstack-qa01:16
*** brinzhang_ has quit IRC01:16
*** brinzhang_ has joined #openstack-qa01:17
*** yamamoto has joined #openstack-qa01:17
*** brinzhang_ has quit IRC01:18
*** brinzhang_ has joined #openstack-qa01:18
*** brinzhang has quit IRC01:25
*** brinzhang has joined #openstack-qa01:25
*** brinzhang_ has quit IRC01:26
*** brinzhang_ has joined #openstack-qa01:26
*** markvoelker has joined #openstack-qa01:33
openstackgerritwanglbj proposed openstack/tempest master: Modify the fake date  https://review.opendev.org/68281101:33
*** brinzhang_ has quit IRC01:40
*** brinzhang has quit IRC01:40
openstackgerritwangzhiguang proposed openstack/tempest master: add access rule api and add unit test  https://review.opendev.org/68746701:40
*** brinzhang has joined #openstack-qa01:41
*** brinzhang_ has joined #openstack-qa01:41
*** brinzhang_ has quit IRC01:45
*** brinzhang has quit IRC01:45
*** brinzhang has joined #openstack-qa01:46
*** brinzhang_ has joined #openstack-qa01:46
*** brinzhang_ has quit IRC01:53
*** brinzhang has quit IRC01:53
*** brinzhang has joined #openstack-qa01:54
*** brinzhang_ has joined #openstack-qa01:54
*** markvoelker has quit IRC02:40
*** ramishra has joined #openstack-qa02:53
*** larainema has joined #openstack-qa02:53
*** xinranwang has joined #openstack-qa02:57
*** slaweq has joined #openstack-qa03:11
*** rh-jelabarre has joined #openstack-qa03:11
*** yamamoto has quit IRC03:14
*** yamamoto has joined #openstack-qa03:15
*** slaweq has quit IRC03:15
*** yamamoto has quit IRC03:20
*** hongbin has quit IRC03:23
*** brinzhang_ has quit IRC03:34
*** brinzhang has quit IRC03:34
*** brinzhang has joined #openstack-qa03:35
*** brinzhang_ has joined #openstack-qa03:35
*** brinzhang has quit IRC03:44
*** brinzhang_ has quit IRC03:44
*** brinzhang has joined #openstack-qa03:44
*** brinzhang_ has joined #openstack-qa03:45
*** hongbin has joined #openstack-qa03:49
*** brinzhang has quit IRC03:54
*** brinzhang has joined #openstack-qa03:54
*** udesale has joined #openstack-qa04:00
*** ramishra has quit IRC04:00
*** slaweq has joined #openstack-qa04:11
*** rh-jelabarre has quit IRC04:14
*** slaweq has quit IRC04:16
*** ramishra has joined #openstack-qa04:17
*** yamamoto has joined #openstack-qa04:21
*** brinzhang_ has quit IRC04:31
*** brinzhang_ has joined #openstack-qa04:32
*** hongbin has quit IRC04:41
*** markvoelker has joined #openstack-qa04:41
*** markvoelker has quit IRC04:46
*** dave-mccowan has quit IRC04:51
*** brinzhang_ has quit IRC04:56
*** brinzhang_ has joined #openstack-qa04:57
*** brinzhang has quit IRC05:06
*** brinzhang has joined #openstack-qa05:06
*** pcaruana has joined #openstack-qa05:07
*** slaweq has joined #openstack-qa05:11
*** slaweq has quit IRC05:15
*** yamamoto has quit IRC05:16
*** yamamoto has joined #openstack-qa05:17
*** gcheresh_ has joined #openstack-qa05:25
*** pcaruana has quit IRC05:35
*** brinzhang_ has quit IRC06:19
*** brinzhang has quit IRC06:20
*** brinzhang_ has joined #openstack-qa06:20
*** brinzhang has joined #openstack-qa06:20
*** surpatil has joined #openstack-qa06:21
*** brinzhang has quit IRC06:21
*** brinzhang has joined #openstack-qa06:22
*** yamamoto has quit IRC06:22
*** yamamoto has joined #openstack-qa06:25
*** brinzhang has quit IRC06:27
*** brinzhang has joined #openstack-qa06:28
*** brinzhang_ has quit IRC06:28
*** brinzhang_ has joined #openstack-qa06:28
*** iurygregory has joined #openstack-qa06:38
*** brinzhang has quit IRC06:38
*** brinzhang has joined #openstack-qa06:38
*** ccamposr has joined #openstack-qa06:45
*** pcaruana has joined #openstack-qa06:51
*** yamamoto has quit IRC06:53
*** yamamoto has joined #openstack-qa06:58
*** tesseract has joined #openstack-qa06:59
*** brinzhang_ has quit IRC07:01
*** brinzhang_ has joined #openstack-qa07:01
*** kopecmartin|off is now known as kopecmartin07:02
*** slaweq has joined #openstack-qa07:02
*** gfidente has joined #openstack-qa07:02
*** brinzhang has quit IRC07:05
*** brinzhang has joined #openstack-qa07:06
*** xinranwang has quit IRC07:07
*** rcernin has quit IRC07:07
*** brinzhang has quit IRC07:12
*** tosky has joined #openstack-qa07:12
*** jpena|off is now known as jpena07:13
*** brinzhang has joined #openstack-qa07:13
*** brinzhang_ has quit IRC07:22
*** brinzhang_ has joined #openstack-qa07:23
*** brinzhang has quit IRC07:23
*** brinzhang has joined #openstack-qa07:23
*** yamamoto has quit IRC07:25
*** yamamoto has joined #openstack-qa07:33
*** brinzhang_ has quit IRC07:34
*** brinzhang has quit IRC07:34
*** brinzhang has joined #openstack-qa07:35
*** brinzhang_ has joined #openstack-qa07:35
*** vishakha has joined #openstack-qa07:50
*** trident has quit IRC07:58
*** trident has joined #openstack-qa08:01
*** lucasagomes has joined #openstack-qa08:04
*** arxcruz|rover is now known as arxcruz08:11
*** rpittau|afk is now known as rpittau08:13
*** brinzhang has quit IRC08:22
*** brinzhang has joined #openstack-qa08:23
*** yamamoto has quit IRC08:29
*** yamamoto has joined #openstack-qa08:31
*** brinzhang has quit IRC08:33
*** brinzhang_ has quit IRC08:33
*** brinzhang has joined #openstack-qa08:34
*** brinzhang_ has joined #openstack-qa08:34
*** brinzhang_ has quit IRC08:43
*** brinzhang has quit IRC08:43
*** brinzhang has joined #openstack-qa08:44
*** brinzhang_ has joined #openstack-qa08:44
*** markvoelker has joined #openstack-qa08:44
*** yamamoto has quit IRC08:48
*** markvoelker has quit IRC08:50
*** brinzhang has quit IRC08:53
*** brinzhang_ has quit IRC08:53
*** lennyb has quit IRC08:57
*** lennyb has joined #openstack-qa08:57
*** dtantsur|afk is now known as dtantsur09:01
*** e0ne has joined #openstack-qa09:06
*** soniya29 has joined #openstack-qa09:26
*** yamamoto has joined #openstack-qa09:29
*** gfidente has quit IRC09:33
*** gfidente has joined #openstack-qa09:42
*** udesale has quit IRC09:52
*** udesale has joined #openstack-qa09:53
*** udesale has quit IRC10:00
*** udesale has joined #openstack-qa10:01
*** slaweq_ has joined #openstack-qa10:57
*** slaweq has quit IRC10:59
*** jpena is now known as jpena|lunch11:04
*** udesale has quit IRC11:09
*** brinzhang has joined #openstack-qa11:13
*** brinzhang_ has joined #openstack-qa11:19
*** brinzhang has quit IRC11:23
*** raildo has joined #openstack-qa11:23
*** yamamoto has quit IRC11:24
*** jhesketh has quit IRC11:29
*** larainema has quit IRC11:34
*** jhesketh has joined #openstack-qa11:43
*** yamamoto has joined #openstack-qa11:50
*** jpena|lunch is now known as jpena11:58
*** brinzhang has joined #openstack-qa12:02
*** rh-jelabarre has joined #openstack-qa12:02
*** brinzhang_ has quit IRC12:05
*** rfolco has joined #openstack-qa12:05
*** rfolco is now known as rfolco|ruck12:07
*** nweinber_ has joined #openstack-qa12:08
*** brinzhang_ has joined #openstack-qa12:11
*** brinzhang has quit IRC12:14
*** markvoelker has joined #openstack-qa12:21
*** mriedem has joined #openstack-qa12:50
*** markvoelker has quit IRC12:51
*** udesale has joined #openstack-qa12:55
*** dtantsur is now known as dtantsur|afk12:57
*** ccamposr has quit IRC13:06
*** soniya29 has quit IRC13:12
*** trident has quit IRC13:14
*** trident has joined #openstack-qa13:15
openstackgerritMartin Kopec proposed openstack/tempest master: Add RadosGW gate  https://review.opendev.org/68641313:16
*** ccamposr has joined #openstack-qa13:18
*** dave-mccowan has joined #openstack-qa13:39
openstackgerritMerged openstack/tempest master: Modify the create user fake data  https://review.opendev.org/68303713:43
*** tosky has quit IRC13:55
*** yamamoto has quit IRC13:56
*** spsurya has joined #openstack-qa13:57
*** surpatil has quit IRC14:00
*** mriedem has quit IRC14:04
*** mriedem has joined #openstack-qa14:05
*** nweinber__ has joined #openstack-qa14:14
*** markvoelker has joined #openstack-qa14:15
*** nweinber_ has quit IRC14:17
*** jdwidari has joined #openstack-qa14:17
*** adriant has quit IRC14:29
*** iokiwi has quit IRC14:29
*** adriant has joined #openstack-qa14:31
*** iokiwi has joined #openstack-qa14:31
*** yamamoto has joined #openstack-qa14:36
*** jpena is now known as jpena|off14:39
*** pcaruana has quit IRC14:39
*** yamamoto has quit IRC14:41
*** dave-mccowan has quit IRC14:41
*** chandankumar is now known as raukadah14:43
*** yamamoto has joined #openstack-qa14:55
*** jgrosso has joined #openstack-qa14:57
*** nweinber_ has joined #openstack-qa15:00
*** pcaruana has joined #openstack-qa15:01
*** nweinber__ has quit IRC15:03
*** gcheresh_ has quit IRC15:06
openstackgerritLajos Katona proposed openstack/tempest master: Scenario test for routed provider networks  https://review.opendev.org/66515515:13
*** pcaruana has quit IRC15:26
*** yamamoto has quit IRC15:34
*** slaweq_ is now known as slaweq15:34
*** dave-mccowan has joined #openstack-qa15:40
*** lucasagomes has quit IRC15:45
*** rpittau is now known as rpittau|afk15:47
*** vkmc has joined #openstack-qa16:07
vkmco/16:07
vkmchey folks, I'm being affected by the testtool bug that is workarounded in here https://review.opendev.org/#/c/681340/16:08
*** yamamoto has joined #openstack-qa16:08
vkmcI'm wondering why you stick this to stestr < 2.5.016:08
vkmcI'm trying to unblock the python-manilaclient gate which uses stestr 2.5.116:08
vkmcI would prefer not to pin stestr to 2.5.0 to fix this16:09
vkmcmaybe you can help me out?16:09
vkmcgmann, ^16:09
*** vhari has joined #openstack-qa16:10
*** artom has joined #openstack-qa16:12
*** mriedem is now known as mriedem_lunch16:13
*** yamamoto has quit IRC16:15
gmannvkmc:  hi16:18
*** udesale has quit IRC16:19
*** jpena|off is now known as jpena16:19
gmannvkmc: what error you are getting?16:19
*** igordc has joined #openstack-qa16:20
vkmchttps://review.opendev.org/#/c/686142/16:20
vkmcgmann, skip instructions are being treated as errors16:20
gmannTempest 22.0.0 is being used on that job which has the workaround16:23
gmannah it is from test case16:23
vkmcI thought it was because we are using a newer version for stestr16:25
vkmcbut now I'm not sure16:25
gmannyes, it is with newer stestr but due to teststool bug. basically unittestt.SkipTest and unittestt2.SkipTest exception not handled in same way16:28
gmannteststool is not so active so we need to go with workaround. let me check the manila case and propose the workaround.16:28
vkmcgmann, k, thanks16:31
*** kopecmartin is now known as kopecmartin|off16:31
vkmcwanted to fix it myself but I'm not seeing the issue... so I appreciate you looking into this16:31
*** pcaruana has joined #openstack-qa16:40
mtreinishvkmc: the fix will be to add the workaround from 681340 to the tempest lib base test class too: https://github.com/openstack/tempest/blob/master/tempest/lib/base.py#L2216:41
mtreinishthe cli tests in tempest lib use a different base test class because the full tempest base class has a lot of things which aren't appropriate in a library (like reading from tempest's config file)16:42
gmannmtreinish: exception are raised from test case (not setUpClass) which we did not handle.16:45
gmannhttps://github.com/openstack/python-manilaclient/blob/106c2753c65038f0d7fc6a3621eabc3d2d568c9d/manilaclient/tests/functional/test_share_access.py#L13316:46
mtreinishah ok, well that too then. :) You'll have to do both then I guess16:48
gmannyeah.16:49
gmannpatrole is also facing the case of raising exception from test.16:50
*** dviroel has joined #openstack-qa16:51
gmannany generic idea to handle that ? instead of doing case by case.16:52
gmannoverride onException ? - https://github.com/testing-cabal/testtools/blob/master/testtools/testcase.py#L61716:54
*** e0ne has quit IRC16:56
mtreinishgmann: yeah probably either that or just set self.skipException to be unittest's skipTest if the conditions are right16:59
*** gfidente has quit IRC17:07
*** mriedem_lunch is now known as mriedem17:34
*** ramishra has quit IRC17:51
*** jpena is now known as jpena|off17:57
*** igordc has quit IRC18:19
*** yamamoto has joined #openstack-qa18:35
*** e0ne has joined #openstack-qa18:37
*** yamamoto has quit IRC18:40
*** e0ne has quit IRC18:41
*** mvkr has quit IRC18:55
*** yamamoto has joined #openstack-qa19:07
*** mvkr has joined #openstack-qa19:08
*** yamamoto has quit IRC19:12
*** yamamoto has joined #openstack-qa19:43
*** yamamoto has quit IRC19:48
*** artom has quit IRC19:50
*** nweinber_ has quit IRC20:00
*** dviroel has quit IRC20:01
*** jdwidari has quit IRC20:02
*** igordc has joined #openstack-qa20:03
*** vhari has quit IRC20:06
*** yamamoto has joined #openstack-qa20:14
*** pcaruana has quit IRC20:15
*** yamamoto has quit IRC20:19
*** e0ne has joined #openstack-qa20:28
*** spsurya has quit IRC20:28
*** e0ne has quit IRC20:48
*** dviroel has joined #openstack-qa20:49
*** jgrosso has quit IRC20:50
*** tesseract has quit IRC20:53
*** slaweq has quit IRC21:01
*** raildo has quit IRC21:06
*** markvoelker has quit IRC21:09
*** slaweq has joined #openstack-qa21:11
*** rfolco|ruck has quit IRC21:13
*** slaweq has quit IRC21:17
*** e0ne has joined #openstack-qa21:34
gmannmtreinish: we are good on skipException from test code. that is handled by self.exception_handlers - https://github.com/testing-cabal/testtools/blob/f51ce5f934153e80d3e8a95b52e1464daeb30c14/testtools/testcase.py#L27521:49
gmannmapped handler _report_skip() will add it to skip tests21:49
gmanni tested that and no issue on those21:49
gmannonly left case if CLI base class and that has challenge to add same workaround in base class because base class does not control the setUpClass of derived test classes- https://github.com/openstack/tempest/blob/master/tempest/lib/base.py#L3221:51
gmannsetUpClass is directly called from CLI test class - https://github.com/openstack/python-manilaclient/blob/106c2753c65038f0d7fc6a3621eabc3d2d568c9d/manilaclient/tests/functional/test_share_access.py#L3421:52
mtreinishgmann: it should, there is a check there that super() is called in any baseTestClass. As long as a skip exception isn't raised prior to the super call any workaround should be set before any subclass code gets a chance to raise22:01
*** yamamoto has joined #openstack-qa22:03
*** trident has quit IRC22:03
gmann'any workaround' ? current workaround is try catch and re-raise appropriate skip exception which cannot be applied in cli test case.22:03
*** mriedem has quit IRC22:04
*** trident has joined #openstack-qa22:05
mtreinishby any workaround I meant whatever you put in setupclass to change the behavior, just sloppy typing by me22:07
mtreinishlike copy the code from tempest.test into tempest.lib.base22:07
*** yamamoto has quit IRC22:08
gmannbut that would not catch the exception in superclass setUpClass which is raised from subclass. in test.py we control all class level setup in base class SetUpClass.22:10
mtreinishgmann: I don't understand: https://github.com/openstack/tempest/blob/master/tempest/lib/base.py#L32 is the base test class for https://github.com/openstack/tempest/blob/master/tempest/lib/cli/base.py#L40422:11
mtreinishthe tempest.lib.base has a check to enforce that all subclasses have called super() meaning whatever you put anything in tempest.lib.base's superclass it will get called in the subclass22:12
mtreinishwhat am I missing?22:12
gmannyeah but skip exception is called after superclass setUpClass  - https://github.com/openstack/python-manilaclient/blob/106c2753c65038f0d7fc6a3621eabc3d2d568c9d/manilaclient/tests/functional/test_share_access.py#L4922:13
mtreinishoh, you wrote the workaround in tempest.test to catch exceptions raised by the tempest setupclass phases, not as a general thing22:15
gmannyeah.22:16
mtreinishthat's what I was missing :)22:16
gmanni remember i tried general things but did not work :) let me try again22:16
*** e0ne has quit IRC22:24
*** yamamoto has joined #openstack-qa22:30
openstackgerritGhanshyam Mann proposed openstack/tempest master: Add workaround to handle the testtool skip exception in CLI test  https://review.opendev.org/68799922:30
*** igordc has quit IRC22:36
*** rcernin has joined #openstack-qa22:46
*** markvoelker has joined #openstack-qa23:10
*** slaweq has joined #openstack-qa23:11
*** markvoelker has quit IRC23:15
*** slaweq has quit IRC23:16
*** camelCaser has quit IRC23:28
*** camelCaser has joined #openstack-qa23:33
« Wednesday, 2019-10-09 Index Friday, 2019-10-11 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!