*** paras333 has quit IRC | 00:09 | |
*** rm_work has quit IRC | 00:42 | |
*** rm_work has joined #openstack-qa | 00:45 | |
*** yamamoto has joined #openstack-qa | 01:01 | |
*** brinzhang has joined #openstack-qa | 01:05 | |
*** rh-jelabarre has joined #openstack-qa | 01:53 | |
*** yamamoto has quit IRC | 02:00 | |
*** yamamoto has joined #openstack-qa | 02:00 | |
*** rh-jelabarre has quit IRC | 02:05 | |
*** yamamoto has quit IRC | 02:10 | |
*** yamamoto has joined #openstack-qa | 02:14 | |
*** yamamoto has quit IRC | 02:20 | |
*** yamamoto has joined #openstack-qa | 02:25 | |
*** yamamoto has quit IRC | 03:55 | |
*** yamamoto has joined #openstack-qa | 04:00 | |
*** yamamoto has quit IRC | 04:05 | |
*** yamamoto has joined #openstack-qa | 04:16 | |
*** yamamoto has quit IRC | 04:21 | |
*** igordc has quit IRC | 04:23 | |
*** evrardjp has quit IRC | 04:36 | |
*** evrardjp has joined #openstack-qa | 04:37 | |
*** rfolco has quit IRC | 04:53 | |
*** yamamoto has joined #openstack-qa | 05:13 | |
*** yamamoto has quit IRC | 05:25 | |
*** slaweq has joined #openstack-qa | 06:16 | |
*** gcheresh has joined #openstack-qa | 06:45 | |
*** slaweq has quit IRC | 07:02 | |
*** gcheresh has quit IRC | 07:17 | |
*** gcheresh has joined #openstack-qa | 07:18 | |
*** gcheresh has quit IRC | 07:57 | |
*** gcheresh has joined #openstack-qa | 08:18 | |
openstackgerrit | Andreas Jaeger proposed openstack/tempest master: Update hacking for Python3 https://review.opendev.org/715682 | 08:34 |
---|---|---|
openstackgerrit | Andreas Jaeger proposed openstack/hacking master: Small cleanups https://review.opendev.org/717441 | 08:44 |
*** brinzhang has quit IRC | 08:55 | |
openstackgerrit | Andreas Jaeger proposed openstack/hacking master: Small cleanups https://review.opendev.org/717441 | 08:56 |
openstackgerrit | Andreas Jaeger proposed openstack/hacking master: Remove usage of six https://review.opendev.org/717442 | 08:56 |
*** gcheresh has quit IRC | 10:09 | |
*** ramishra has quit IRC | 10:22 | |
*** tosky has joined #openstack-qa | 10:48 | |
yoctozepto | AJaeger: no idea if you will get my comment from a merged change, so: https://docs.openstack.org/hacking/latest/user/usage.html - still advocates local-check-factory usage | 11:09 |
*** redrobot has quit IRC | 11:15 | |
*** yamamoto has joined #openstack-qa | 11:38 | |
AJaeger | yoctozepto: yes, I know - https://review.opendev.org/715894 | 11:57 |
*** yamamoto has quit IRC | 12:26 | |
*** yamamoto has joined #openstack-qa | 12:34 | |
*** yamamoto has quit IRC | 12:39 | |
*** yamamoto has joined #openstack-qa | 12:57 | |
*** yamamoto has quit IRC | 13:03 | |
*** yamamoto has joined #openstack-qa | 13:07 | |
*** stephenfin has quit IRC | 13:25 | |
*** yamamoto has quit IRC | 14:02 | |
*** yamamoto has joined #openstack-qa | 14:03 | |
yoctozepto | AJaeger: thanks, I commented on your patches (not core [yet] there) | 14:08 |
*** yamamoto has quit IRC | 14:08 | |
yoctozepto | AJaeger: I have a question regarding https://review.opendev.org/717382 - I did not see it failing on any - could you cross check? | 14:08 |
openstackgerrit | Andreas Jaeger proposed openstack/hacking master: Document new way of registering local plugins https://review.opendev.org/715894 | 14:21 |
openstackgerrit | Andreas Jaeger proposed openstack/hacking master: Small cleanups https://review.opendev.org/717441 | 14:22 |
openstackgerrit | Radosław Piliszek proposed openstack/hacking master: Remove usage of six https://review.opendev.org/717442 | 14:22 |
AJaeger | yoctozepto: answered - removing "ignore" gives you the default ignore list ;( | 14:25 |
yoctozepto | AJaeger: ack! then the recommendation was missing in kolla... | 14:25 |
yoctozepto | AJaeger: I did not know that, thanks! | 14:25 |
AJaeger | yoctozepto: learned it only recently - some repo had it as comment ;) | 14:26 |
yoctozepto | AJaeger: haha, good one; definitely against python way but what can one do? :-) | 14:27 |
AJaeger | gmann: could you review core group of hacking, please? Most of the direct members of https://review.opendev.org/#/admin/groups/153,members have left the community. I just pinged the infra team for review and they told me that they in there more as "insurance". Still, got some reviews... | 14:29 |
AJaeger | clarkb: FYI ^ | 14:30 |
AJaeger | gmann: I think we should merge those open changes and release a 3.0.1 | 14:30 |
*** slaweq has joined #openstack-qa | 14:30 | |
* yoctozepto would not mind being able to +2 in hacking | 14:31 | |
AJaeger | yoctozepto: will you fix kolla-ansible further? I propose to revert to my version and do an update on top of it. But if you want to take over, fine for me as well. | 14:33 |
yoctozepto | AJaeger: yeah, I'm precisely doing that; just need to choose new style to pursue | 14:34 |
openstackgerrit | Merged openstack/hacking master: Clean up "is" conditionals https://review.opendev.org/678607 | 14:34 |
AJaeger | thanks, yoctozepto ! | 14:36 |
yoctozepto | AJaeger: np, I changed the comment to make me remember | 14:37 |
AJaeger | yoctozepto: good ideae | 14:38 |
AJaeger | yoctozepto: strange, I thought there were errors - seems I enabled in any case ;( Not my usual way of doing it. You seemed to have caught the one odd case :( Thanks! | 14:41 |
yoctozepto | AJaeger: thanks to you too for handling these matters | 14:44 |
yoctozepto | hmm, hacking reports to both channels | 14:44 |
yoctozepto | AJaeger: for the gods of lolz - it fails in CI but passes here locally... so you were right with using them both | 14:53 |
yoctozepto | now why it does not see the problem... | 14:53 |
yoctozepto | let's regenerate pep8 | 14:54 |
yoctozepto | well, that made it show them | 14:56 |
yoctozepto | so need to decide on one hmm hmm | 14:56 |
yoctozepto | ended up reverting to yours and adding comment 😂 | 15:01 |
yoctozepto | too many non-trivial reformat to satisfy either rule | 15:02 |
yoctozepto | best to merge early and follow up when time allows | 15:02 |
yoctozepto | last week is oh so much fire fighting... | 15:03 |
AJaeger | yeah, can be done later - but going to hacking 3 is nice to take in IMHO for python 3 support | 15:10 |
*** mordred has quit IRC | 15:20 | |
*** stephenfin has joined #openstack-qa | 15:20 | |
*** mordred has joined #openstack-qa | 15:21 | |
*** stephenfin has quit IRC | 15:22 | |
*** slaweq has quit IRC | 15:22 | |
*** stephenfin has joined #openstack-qa | 15:23 | |
yoctozepto | AJaeger: agreed; weeding out old (usually bad) practice | 15:27 |
*** camelCaser has quit IRC | 15:29 | |
*** stephenfin has quit IRC | 15:32 | |
*** stephenfin has joined #openstack-qa | 15:33 | |
openstackgerrit | Andreas Jaeger proposed openstack/tempest master: Remove universal wheel building https://review.opendev.org/717490 | 15:36 |
*** rfolco has joined #openstack-qa | 15:59 | |
*** rfolco has quit IRC | 16:04 | |
*** evrardjp has quit IRC | 16:36 | |
*** evrardjp has joined #openstack-qa | 16:37 | |
*** yamamoto has joined #openstack-qa | 16:44 | |
*** yamamoto has quit IRC | 16:49 | |
AJaeger | gmann: FYI, I pushed a couple of py27 cleanups with topic:cleanup-py27-support | 17:21 |
*** igordc has joined #openstack-qa | 18:09 | |
*** camelCaser has joined #openstack-qa | 18:30 | |
*** camelCaser has quit IRC | 18:30 | |
*** camelCaser has joined #openstack-qa | 18:31 | |
*** slaweq has joined #openstack-qa | 19:24 | |
*** slaweq_ has joined #openstack-qa | 19:37 | |
*** slaweq has quit IRC | 19:39 | |
*** slaweq_ has quit IRC | 20:51 | |
gmann | AJaeger: sure, review done. I will wait for final U release and then cut the release for hacking. I will review the core list too. | 22:53 |
openstackgerrit | Merged openstack/hacking master: Stop building universal wheels https://review.opendev.org/717390 | 22:56 |
openstackgerrit | Merged openstack/hacking master: Small cleanups https://review.opendev.org/717441 | 22:56 |
openstackgerrit | Merged openstack/hacking master: Remove usage of six https://review.opendev.org/717442 | 22:56 |
openstackgerrit | Merged openstack/hacking master: Document new way of registering local plugins https://review.opendev.org/715894 | 22:57 |
*** tosky has quit IRC | 23:00 | |
*** slaweq_ has joined #openstack-qa | 23:01 | |
*** slaweq_ has quit IRC | 23:07 | |
openstackgerrit | Artom Lifshitz proposed openstack/tempest master: Pass clients to compute base's create_test_server https://review.opendev.org/717355 | 23:43 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!