*** rcernin has quit IRC | 00:06 | |
*** rcernin has joined #openstack-qa | 00:25 | |
*** paras333 has quit IRC | 00:31 | |
*** hongbin_ has joined #openstack-qa | 00:52 | |
*** hongbin has quit IRC | 00:52 | |
*** Liang__ has joined #openstack-qa | 01:01 | |
openstackgerrit | zhufl proposed openstack/tempest master: Add response schema validation for volumes https://review.opendev.org/616783 | 01:37 |
---|---|---|
*** paras333 has joined #openstack-qa | 02:17 | |
*** paras333 has quit IRC | 02:34 | |
*** jcmdln has joined #openstack-qa | 03:18 | |
*** evrardjp has quit IRC | 04:33 | |
*** evrardjp has joined #openstack-qa | 04:33 | |
openstackgerrit | Merged openstack/tempest master: [Trivial]Do not use self in class method https://review.opendev.org/729846 | 04:59 |
*** hongbin_ has quit IRC | 05:16 | |
*** gcheresh has joined #openstack-qa | 05:17 | |
*** nightmare_unreal has joined #openstack-qa | 05:32 | |
*** gcheresh has quit IRC | 06:28 | |
*** tosky has joined #openstack-qa | 06:30 | |
*** maciejjozefczyk has joined #openstack-qa | 06:38 | |
*** udesale has joined #openstack-qa | 06:40 | |
*** slaweq has joined #openstack-qa | 06:46 | |
openstackgerrit | zhufl proposed openstack/tempest master: Adding description for testcases - compute part4 https://review.opendev.org/730565 | 07:03 |
*** jhesketh has quit IRC | 07:03 | |
*** jhesketh has joined #openstack-qa | 07:05 | |
*** rpittau|afk is now known as rpittau | 07:21 | |
*** jhesketh has quit IRC | 07:25 | |
*** jhesketh has joined #openstack-qa | 07:25 | |
*** ralonsoh has joined #openstack-qa | 07:26 | |
*** arxcruz|off is now known as arxcruzz | 07:37 | |
*** arxcruzz is now known as arxcruz | 07:37 | |
*** lucasagomes has joined #openstack-qa | 07:55 | |
*** jpena|off is now known as jpena | 07:58 | |
*** tkajinam has quit IRC | 08:01 | |
*** gkadam has joined #openstack-qa | 08:03 | |
*** gkadam has quit IRC | 08:03 | |
rpittau | morning everyone, any chance I can get a second review on this please? https://review.opendev.org/727997 | 08:07 |
openstackgerrit | Riccardo Pittau proposed openstack/devstack master: Move supported distros to variable https://review.opendev.org/718939 | 08:11 |
*** dtantsur|afk is now known as dtantsur | 08:12 | |
*** gfidente has joined #openstack-qa | 08:40 | |
*** gcheresh has joined #openstack-qa | 09:43 | |
*** jhesketh has quit IRC | 09:48 | |
*** jhesketh has joined #openstack-qa | 09:49 | |
openstackgerrit | Riccardo Pittau proposed openstack/devstack master: Remove sgabios.bin workaround https://review.opendev.org/727997 | 09:53 |
*** rpittau is now known as rpittau|bbl | 10:12 | |
*** Liang__ has quit IRC | 10:19 | |
*** udesale_ has joined #openstack-qa | 11:06 | |
*** udesale has quit IRC | 11:09 | |
*** ccamposr has joined #openstack-qa | 11:17 | |
*** ccamposr__ has quit IRC | 11:20 | |
*** jpena is now known as jpena|lunch | 11:31 | |
*** ccamposr has quit IRC | 11:33 | |
*** rfolco has joined #openstack-qa | 11:51 | |
*** rfolco is now known as rfolco|rover | 12:02 | |
*** raildo has joined #openstack-qa | 12:10 | |
*** rpittau|bbl is now known as rpittau | 12:11 | |
*** ramishra has quit IRC | 12:13 | |
*** rfolco|rover has quit IRC | 12:19 | |
*** rfolco|rover has joined #openstack-qa | 12:19 | |
*** artom has joined #openstack-qa | 12:28 | |
*** jpena|lunch is now known as jpena | 12:33 | |
*** ccamposr has joined #openstack-qa | 13:45 | |
gmann | whoami-rajat: from 3.1 patch and api-ref it seems they were added in 3.1 as new fields in response. | 13:50 |
whoami-rajat | gmann, could you give me links? | 13:52 |
gmann | whoami-rajat: commented also, this one - https://review.opendev.org/#/c/230617/40/cinder/volume/api.py | 13:52 |
gmann | api ref- https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded=upload-volume-to-image-detail#volume-actions-volumes-action | 13:52 |
*** rpittau is now known as rpittau|brb | 13:56 | |
whoami-rajat | gmann, hmm, i think they expected the parameters in response only when we send it | 14:02 |
gmann | whoami-rajat: they? you mean glance ? | 14:03 |
whoami-rajat | gmann, the author and the reviewers of patch | 14:03 |
whoami-rajat | and i overlooked this file | 14:03 |
gmann | ohk, yeah that is what i commented on review. check should be for 'metadata' not 'recv_metadata' right ? to have explicit control in cinder side | 14:04 |
gmann | whoami-rajat: anyways, i will file bug so that it can be at least corrected in api-ref to mention clearly that those two fields are always returned not new in 3.1 as code cannot be fixed now. | 14:06 |
gmann | whoami-rajat: thanks for the checking and review. | 14:10 |
whoami-rajat | gmann, yeah, it should be on metadata but there are variable response parameters in certain cases where we allow such thing, i'm suspicious if they missed it or it's intentional | 14:12 |
whoami-rajat | i feel it's missed | 14:12 |
whoami-rajat | gmann, thanks for looking into it | 14:13 |
gmann | whoami-rajat: yeah, i remember the debate on 'adding new fields in response is ok without microversion bump' and from interop side which I still feel not ok. or at least be consistent on new fields 'never' need version bump or always. inconsistent APIs are the issue, consistently correct or consistently incorrect are both ok. | 14:15 |
whoami-rajat | gmann++ | 14:20 |
gmann | whoami-rajat: https://bugs.launchpad.net/cinder/+bug/1880566 | 14:23 |
openstack | Launchpad bug 1880566 in Cinder "microversion 3.1 new fields 'visibility' and 'protected' are returned in older API microversion also" [Undecided,New] | 14:23 |
*** rpittau|brb is now known as rpittau | 14:30 | |
*** gcheresh has quit IRC | 15:17 | |
*** elod has quit IRC | 15:59 | |
*** elod has joined #openstack-qa | 16:01 | |
*** lucasagomes has quit IRC | 16:13 | |
*** udesale_ has quit IRC | 16:14 | |
*** dtantsur is now known as dtantsur|afk | 16:36 | |
*** rpittau is now known as rpittau|afk | 16:48 | |
*** jpena is now known as jpena|off | 17:01 | |
*** gfidente is now known as gfidente|afk | 17:09 | |
*** ccamposr__ has joined #openstack-qa | 17:13 | |
*** ccamposr has quit IRC | 17:16 | |
*** jparker_ has joined #openstack-qa | 17:30 | |
*** nightmare_unreal has quit IRC | 18:31 | |
*** maciejjozefczyk has quit IRC | 18:41 | |
*** gcheresh has joined #openstack-qa | 19:04 | |
*** gcheresh has quit IRC | 19:27 | |
*** gcheresh has joined #openstack-qa | 20:11 | |
*** ralonsoh has quit IRC | 20:26 | |
*** gcheresh has quit IRC | 20:26 | |
*** rfolco|rover has quit IRC | 20:42 | |
*** maciejjozefczyk has joined #openstack-qa | 20:51 | |
*** maciejjozefczyk has quit IRC | 20:58 | |
*** raildo has quit IRC | 21:00 | |
openstackgerrit | Ghanshyam Mann proposed openstack/hacking master: Add in-tree upper-constraints for py35 job https://review.opendev.org/730686 | 21:48 |
openstackgerrit | Ghanshyam Mann proposed openstack/hacking master: Add in-tree upper-constraints for py35 job https://review.opendev.org/730686 | 21:54 |
*** slaweq has quit IRC | 21:54 | |
openstackgerrit | Ghanshyam Mann proposed openstack/hacking master: Add in-tree upper-constraints for py35 job https://review.opendev.org/730686 | 21:56 |
*** rcernin has quit IRC | 22:49 | |
*** rcernin has joined #openstack-qa | 22:50 | |
*** tkajinam has joined #openstack-qa | 22:53 | |
*** tosky has quit IRC | 23:18 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!