*** yamamoto has quit IRC | 00:03 | |
*** markvoelker has joined #openstack-qa | 00:19 | |
*** ricolin_ has joined #openstack-qa | 00:59 | |
*** yamamoto has joined #openstack-qa | 01:26 | |
openstackgerrit | zhufl proposed openstack/tempest master: Add response schema validation for volume backups https://review.opendev.org/616429 | 01:29 |
---|---|---|
*** yamamoto has quit IRC | 02:00 | |
*** markvoelker has quit IRC | 02:19 | |
*** rcernin has quit IRC | 02:56 | |
*** rcernin has joined #openstack-qa | 02:57 | |
*** ramishra has quit IRC | 03:13 | |
*** ramishra has joined #openstack-qa | 03:14 | |
*** rfolco has quit IRC | 03:14 | |
*** brinzhang0 has joined #openstack-qa | 03:15 | |
*** brinzhang_ has quit IRC | 03:18 | |
*** brinzhang has joined #openstack-qa | 03:19 | |
*** brinzhang0 has quit IRC | 03:22 | |
*** redrobot has quit IRC | 03:36 | |
*** brinzhang_ has joined #openstack-qa | 03:41 | |
*** brinzhang has quit IRC | 03:44 | |
*** rfolco has joined #openstack-qa | 03:52 | |
*** rfolco has quit IRC | 03:56 | |
*** yamamoto has joined #openstack-qa | 03:59 | |
*** yamamoto has quit IRC | 03:59 | |
*** yamamoto has joined #openstack-qa | 04:00 | |
*** brinzhang0 has joined #openstack-qa | 04:03 | |
*** brinzhang_ has quit IRC | 04:05 | |
*** markvoelker has joined #openstack-qa | 04:11 | |
*** markvoelker has quit IRC | 04:15 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/devstack master: dnm: debug https://review.opendev.org/741082 | 04:23 |
*** evrardjp has quit IRC | 04:33 | |
*** evrardjp has joined #openstack-qa | 04:33 | |
*** vishalmanchanda has joined #openstack-qa | 04:50 | |
*** markvoelker has joined #openstack-qa | 05:01 | |
*** markvoelker has quit IRC | 05:05 | |
*** brinzhang_ has joined #openstack-qa | 05:16 | |
*** abdysn has joined #openstack-qa | 05:16 | |
*** brinzhang0 has quit IRC | 05:18 | |
*** brinzhang0 has joined #openstack-qa | 05:21 | |
*** udesale has joined #openstack-qa | 05:22 | |
*** brinzhang_ has quit IRC | 05:24 | |
*** brinzhang_ has joined #openstack-qa | 05:40 | |
*** brinzhang0 has quit IRC | 05:43 | |
*** psahoo has joined #openstack-qa | 05:55 | |
*** gcheresh has joined #openstack-qa | 05:55 | |
*** udesale has quit IRC | 06:07 | |
*** lpiwowar has joined #openstack-qa | 06:14 | |
lpiwowar | Ahoj | 06:14 |
*** udesale has joined #openstack-qa | 06:20 | |
*** psahoo has quit IRC | 06:22 | |
*** psahoo has joined #openstack-qa | 06:40 | |
*** gcheresh has quit IRC | 06:42 | |
*** ralonsoh has joined #openstack-qa | 06:48 | |
*** soniya29 has joined #openstack-qa | 07:02 | |
*** rcernin has quit IRC | 07:07 | |
*** rcernin has joined #openstack-qa | 07:17 | |
*** gcheresh has joined #openstack-qa | 07:32 | |
openstackgerrit | Merged openstack/tempest master: Remove checking of Accept-Range header https://review.opendev.org/738629 | 07:32 |
*** nightmare_unreal has joined #openstack-qa | 07:35 | |
*** dtantsur|afk is now known as dtantsur | 07:45 | |
*** tosky has joined #openstack-qa | 07:46 | |
*** udesale has quit IRC | 07:47 | |
*** udesale has joined #openstack-qa | 07:47 | |
*** elod_off is now known as elod | 07:51 | |
*** markvoelker has joined #openstack-qa | 08:12 | |
*** lucasagomes has joined #openstack-qa | 08:15 | |
*** markvoelker has quit IRC | 08:17 | |
*** rcernin has quit IRC | 08:27 | |
*** bhagyashris is now known as bhagyashris|lunc | 08:43 | |
*** rcernin has joined #openstack-qa | 08:48 | |
*** yamamoto has quit IRC | 08:55 | |
*** yamamoto has joined #openstack-qa | 09:00 | |
*** yamamoto has quit IRC | 09:02 | |
*** yamamoto has joined #openstack-qa | 09:08 | |
*** markvoelker has joined #openstack-qa | 09:11 | |
*** psahoo has quit IRC | 09:14 | |
*** markvoelker has quit IRC | 09:15 | |
*** rcernin has quit IRC | 09:17 | |
*** soniya29 has quit IRC | 09:23 | |
*** psahoo has joined #openstack-qa | 09:30 | |
*** ricolin_ has quit IRC | 09:49 | |
yoctozepto | gmann: found them both fine and approved | 10:11 |
*** mvkr has quit IRC | 10:34 | |
*** bhagyashris|lunc is now known as bhagyashris | 10:37 | |
openstackgerrit | Gayathri Devi proposed openstack/tempest master: Add OpenStack-API-Version header to the show_version volume request https://review.opendev.org/740714 | 10:41 |
openstackgerrit | Gayathri Devi proposed openstack/tempest master: Add OpenStack-API-Version header to the show_version request https://review.opendev.org/740714 | 10:48 |
*** yamamoto has quit IRC | 11:01 | |
*** tosky has quit IRC | 11:05 | |
openstackgerrit | Soniya Murlidhar Vyas proposed openstack/tempest master: [WIP] Need to have stable tempest scenario manager https://review.opendev.org/724631 | 11:06 |
*** tosky has joined #openstack-qa | 11:10 | |
openstackgerrit | Merged openstack/tempest master: Unstable test_server_connectivity_cold_migration_revert https://review.opendev.org/737453 | 11:28 |
*** rcernin has joined #openstack-qa | 11:31 | |
*** udesale_ has joined #openstack-qa | 11:31 | |
*** udesale has quit IRC | 11:34 | |
*** yamamoto has joined #openstack-qa | 11:40 | |
*** rcernin has quit IRC | 11:47 | |
*** rfolco has joined #openstack-qa | 11:56 | |
*** paras333 has joined #openstack-qa | 12:05 | |
*** yamamoto has quit IRC | 12:06 | |
openstackgerrit | Victoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Add mgr caps to manila and cinder users https://review.opendev.org/741164 | 12:15 |
*** yamamoto has joined #openstack-qa | 12:23 | |
*** tkajinam has quit IRC | 12:24 | |
Open10K8S | Hi gouthamr: dansmith: | 12:25 |
Open10K8S | I appended the followings to the bindep to build the glance api image | 12:26 |
Open10K8S | python3-rados | 12:26 |
Open10K8S | python3-rbd | 12:26 |
Open10K8S | But same error, python3.7 sitepackage does not include rados and rbd package | 12:26 |
Open10K8S | https://review.opendev.org/#/c/739846/26/images/glance/Dockerfile | 12:27 |
Open10K8S | https://review.opendev.org/#/c/739846/26/images/glance/bindep.txt | 12:27 |
Open10K8S | How can i install rados and rbd python package? | 12:30 |
*** vapjes has joined #openstack-qa | 12:35 | |
*** yamamoto has quit IRC | 12:42 | |
*** soniya29 has joined #openstack-qa | 12:49 | |
*** brinzhang_ has quit IRC | 13:17 | |
*** yamamoto has joined #openstack-qa | 13:24 | |
*** artom has joined #openstack-qa | 13:31 | |
openstackgerrit | Luigi Toscano proposed openstack/tempest master: zuul: clean up some legacy jobs https://review.opendev.org/741197 | 13:40 |
*** Guest14648 has joined #openstack-qa | 13:43 | |
openstackgerrit | Soniya Murlidhar Vyas proposed openstack/tempest master: [WIP] Need to have stable tempest scenario manager https://review.opendev.org/724631 | 13:45 |
*** Guest14648 is now known as redrobot | 13:45 | |
*** yamamoto has quit IRC | 13:47 | |
openstackgerrit | Gayathri Devi proposed openstack/tempest master: Add OpenStack-API-Version header to the show_version request https://review.opendev.org/740714 | 13:54 |
*** ramishra has quit IRC | 13:59 | |
*** Liang__ has joined #openstack-qa | 13:59 | |
*** Liang__ is now known as LiangFang | 13:59 | |
openstackgerrit | Victoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Add mgr caps to manila and cinder users https://review.opendev.org/741164 | 14:17 |
*** ramishra has joined #openstack-qa | 14:19 | |
openstackgerrit | Hui Jiang proposed openstack/devstack master: [DNM] Replace all 'python' to 'python3' of shell script https://review.opendev.org/741220 | 14:22 |
*** abdysn has quit IRC | 14:26 | |
*** ramishra has quit IRC | 14:28 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/devstack master: DO NOT REVIEW: Change Neutron's default ML2 driver to OVN https://review.opendev.org/735097 | 14:36 |
*** dave-mccowan has quit IRC | 14:43 | |
*** ramishra has joined #openstack-qa | 14:48 | |
*** dave-mccowan has joined #openstack-qa | 14:48 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/devstack master: DO NOT REVIEW: [OVN] Do not fail if q-l3 or q-agt is enabled https://review.opendev.org/741232 | 14:54 |
openstackgerrit | Merged openstack/devstack master: Use glance import workflow for creating image https://review.opendev.org/735966 | 15:02 |
openstackgerrit | Merged openstack/devstack master: Make Glance standalone-ness a separate flag https://review.opendev.org/740322 | 15:02 |
*** LiangFang has quit IRC | 15:10 | |
*** ramishra has quit IRC | 15:46 | |
*** yamamoto has joined #openstack-qa | 15:46 | |
openstackgerrit | Dan Smith proposed openstack/devstack master: Default Glance to standalone mode https://review.opendev.org/741258 | 15:46 |
openstackgerrit | Julia Kreger proposed openstack/devstack master: Make ironic cross gating voting https://review.opendev.org/741265 | 16:00 |
*** soniya29 has quit IRC | 16:09 | |
*** lucasagomes has quit IRC | 16:15 | |
*** yamamoto has quit IRC | 16:24 | |
*** ramishra has joined #openstack-qa | 16:24 | |
*** lpiwowar has quit IRC | 16:37 | |
gmann | yoctozepto: thanks | 16:38 |
*** udesale_ has quit IRC | 16:38 | |
*** gcheresh has quit IRC | 16:44 | |
*** ccamposr has quit IRC | 17:02 | |
openstackgerrit | Victoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Add mgr caps to manila and cinder users https://review.opendev.org/741164 | 17:15 |
*** dtantsur is now known as dtantsur|afk | 17:18 | |
*** psahoo has quit IRC | 17:19 | |
openstackgerrit | Victoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Enable cephFS snapshots in manila https://review.opendev.org/741275 | 17:20 |
*** nightmare_unreal has quit IRC | 17:44 | |
abhishekk | any idea about cookiecutter.exceptions.UnknownRepoType ? | 17:53 |
abhishekk | I am trying to create tempest plugin as per https://docs.openstack.org/tempest/latest/plugins/plugin.html | 17:54 |
*** gcheresh has joined #openstack-qa | 17:55 | |
tosky | uhm, it's been a while since I last used it, so no | 18:06 |
tosky | do you have a more complete log of what you did up to the traceback? | 18:06 |
abhishekk | got it | 18:06 |
abhishekk | need to change url here, https://docs.openstack.org/tempest/latest/plugins/plugin.html#plugin-cookiecutter | 18:07 |
openstackgerrit | Victoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Add mgr caps to manila user https://review.opendev.org/741164 | 18:07 |
abhishekk | to https://github.com/openstack/tempest-plugin-cookiecutter.git | 18:07 |
tosky | why should it be changed to github? | 18:08 |
abhishekk | this either expects 'git' or 'bigbucket' in repo url | 18:08 |
gmann | abhishekk: it should work as mentioned in README -https://github.com/openstack/tempest-plugin-cookiecutter | 18:08 |
gmann | ok, you are referring the tempest doc | 18:09 |
abhishekk | gmann, http://paste.openstack.org/show/795952/ | 18:10 |
abhishekk | I am getting this error if I am not using github utl | 18:11 |
abhishekk | tosky, ^^ | 18:11 |
gmann | or https://opendev.org/openstack/tempest-plugin-cookiecutter.git | 18:11 |
gmann | we need to fix tempest doc, abhishekk you want to push quick patch? | 18:12 |
tosky | abhishekk: uhm, works for me; my cookicutter is py3-based though | 18:13 |
abhishekk | gmann, in middle of something | 18:14 |
abhishekk | tosky ack | 18:14 |
abhishekk | need 30-40 minutes to finish task in hand, then I can push the fix | 18:16 |
abhishekk | gmann, ^^ | 18:16 |
tosky | but which fix? | 18:16 |
tosky | abhishekk: it should work with opendev.org | 18:16 |
abhishekk | tosky i am not sure how it is working for you | 18:19 |
abhishekk | you might be using this url, https://opendev.org/openstack/tempest-plugin-cookiecutter.git | 18:19 |
abhishekk | but in doc at the end .git is not mentioned | 18:20 |
gmann | tosky: it does not work work cookiecutter https://opendev.org/openstack/tempest-plugin-cookiecutter | 18:20 |
*** vishalmanchanda has quit IRC | 18:20 | |
tosky | I see | 18:20 |
gmann | yeah as abhishekk mentioned. REAMDE is fine but tempest doc is not | 18:20 |
abhishekk | tosky, would you like to push a patch? | 18:21 |
*** yamamoto has joined #openstack-qa | 18:21 | |
*** slaweq has joined #openstack-qa | 18:22 | |
tosky | so, the final .git works just by accident, at leat by looking at the cookiecutter code | 18:22 |
tosky | because it looks for "git" in the URL, but the documentation of the identify_repo method says | 18:22 |
tosky | Repos can be identified by prepending "hg+" or "git+" to the repo URL. | 18:22 |
tosky | and then if falls back on finding 'git' in the URL, as you pointed out, but that's kind of a bit of a stretch | 18:23 |
tosky | what it works as proper path is | 18:24 |
tosky | cookiecutter git+https://opendev.org/openstack/tempest-plugin-cookiecutter | 18:24 |
*** tosky has quit IRC | 18:25 | |
abhishekk | yes | 18:25 |
*** tosky has joined #openstack-qa | 18:25 | |
abhishekk | tosky, it should | 18:25 |
*** paras333 has quit IRC | 18:25 | |
tosky | which syntax do you prefer for the doc patch? Rely on the .git or use the prefix? | 18:26 |
gmann | it is not correct, .git is not accidental working. identify_repo has else block to check it git in repo_url | 18:27 |
gmann | let's do .git same as README which is easy than prefix things | 18:28 |
tosky | fine, but it's still a stretch | 18:28 |
tosky | if you have mercurial repository extended-git-repo it is recognized as git | 18:29 |
tosky | oh, no, not that one | 18:29 |
tosky | but convert-from-bitbucket, that one would be identified as git | 18:29 |
gmann | https://opendev.org/openstack/tempest-plugin-cookiecutter has no hidden 'git' | 18:30 |
abhishekk | Also if I run above command as per mentioned in doc, it should create setup.cfg for me or not? | 18:33 |
*** gcheresh has quit IRC | 18:35 | |
gmann | abhishekk: no, it does not it create the required plugins things only and rest all setup.cfg, gitreview etc has to be there. | 18:36 |
abhishekk | gmann, ack | 18:37 |
gmann | they can be created if you do new project creation with cookicutter and then run tempest plugin cokkicutter | 18:37 |
abhishekk | gmann, got it | 18:37 |
openstackgerrit | Ghanshyam Mann proposed openstack/tempest master: Fix tempest plugin cookicutter repo path https://review.opendev.org/741305 | 18:42 |
gmann | abhishekk: tosky ^^ | 18:42 |
abhishekk | gmann, looking | 18:42 |
gmann | kopecmartin: masayukig quick one ^^ | 18:42 |
abhishekk | gmann, looks good, thank you | 18:44 |
tosky | thanks; too slow | 18:44 |
gmann | abhishekk: thanks for reporting, now a days it is very rare someone use plugin cookicutter so it worked for you was good updates for us :) | 18:45 |
abhishekk | gmann, :D | 18:46 |
*** paras333 has joined #openstack-qa | 18:52 | |
*** yamamoto has quit IRC | 19:01 | |
Open10K8S | Hi team, How can I change the dashboard_url in the tempest_horizon? | 19:13 |
Open10K8S | Now I am trying to test horizon on the docker container. the tempest_horizon is using localhost as a dashboard_url as the default value | 19:15 |
Open10K8S | https://opendev.org/openstack/tempest-horizon/src/branch/master/tempest_horizon/config.py#L19-L21 | 19:16 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/devstack master: dnm: debug https://review.opendev.org/741082 | 19:21 |
gouthamr | weirdly when i use "devstack-minimal" as a base for a tempest job, there're some awk errors in the last step of devstack: https://opendev.org/openstack/devstack/src/commit/c7c897ab0ab2ce8760ed8b5b721fb8bab3d8c1ec/stack.sh#L1441 that prevent the test-config from being copied over to tempest.conf ^ | 19:25 |
gouthamr | trying to isolate that, without wasting gate resources :) | 19:25 |
gmann | Open10K8S: you can configure the url as you pointed out the option | 19:42 |
*** ralonsoh has quit IRC | 19:49 | |
Open10K8S | gmann: how can i do? | 19:58 |
openstackgerrit | Lee Yarwood proposed openstack/tempest master: remote_client: Use blkid -L to find config drive by filesystem label https://review.opendev.org/710864 | 19:59 |
gmann | Open10K8S: you can edit tempest.conf present in tempest/etc/tempest.conf (by default config path) or whatever path you have config in | 20:00 |
Open10K8S | gmann: can you see this? https://review.opendev.org/#/c/740822/6/devstack/lib/horizon LN46 | 20:01 |
Open10K8S | I tried in the devstack to set the dashboard url | 20:02 |
Open10K8S | but the registration in the tempest_horizon plugin is overwriten? | 20:02 |
Open10K8S | or i missed something? | 20:03 |
gmann | Open10K8S: ohk, let me check what stage it is executing, it should be after devstack setup temepst.conf otherwise it will override | 20:03 |
Open10K8S | please check. that is setting in the start_horizon lib func in devstack | 20:04 |
*** gcheresh has joined #openstack-qa | 20:08 | |
openstackgerrit | Merged openstack/devstack-plugin-ceph master: Add mgr caps to manila user https://review.opendev.org/741164 | 20:09 |
*** raildo has quit IRC | 20:16 | |
*** raildo has joined #openstack-qa | 20:16 | |
gmann | Open10K8S: yeah, tempest script ran after your horizon script set the url - https://zuul.opendev.org/t/vexxhost/build/3b46d28f4d41479d85e3cbf29eee5fb7/log/controller/logs/devstacklog.txt#25316 | 20:16 |
Open10K8S | https://zuul.opendev.org/t/vexxhost/build/3b46d28f4d41479d85e3cbf29eee5fb7/log/controller/logs/devstacklog.txt#25483 | 20:20 |
Open10K8S | gmann: yeah, surely | 20:21 |
*** raildo has quit IRC | 20:22 | |
*** raildo has joined #openstack-qa | 20:24 | |
*** slaweq has quit IRC | 20:29 | |
gmann | Open10K8S: its tricky, tempest-horizon does not have devstack-plugin otherwise it could be easy to set | 20:29 |
Open10K8S | gmann: yes, | 20:30 |
*** raildo has quit IRC | 20:30 | |
gmann | and devstck does not allow any extra.d other than 80-tempest.sh otherwise i was thinking to write one | 20:30 |
Open10K8S | gmann: how about the devstack_localrc variable in devstack-tempest zuul job? | 20:32 |
Open10K8S | can we pass the param to the job? | 20:32 |
gmann | Open10K8S: sorry, checking.. | 20:42 |
gmann | Open10K8S: that is one way but if you want to handle that in clean way, you can add plugin.sh and add test-config phase to write/overwrite tempest.conf | 20:49 |
gmann | just commented on gerrit with example. that will be easy for maintenance and if you want to add more config changes. | 20:49 |
*** gcheresh has quit IRC | 20:49 | |
gmann | by test-config phase on devstack plugin, tempest is installed and configured properly. | 20:50 |
Open10K8S | ok, thank you gmann | 20:59 |
Open10K8S | if overwrite is the last resort, then I will redefine the configure_tempest func only | 20:59 |
*** yamamoto has joined #openstack-qa | 21:00 | |
Open10K8S | gmann: https://review.opendev.org/#/c/740822/8/devstack/plugin.sh | 21:10 |
Open10K8S | like this | 21:10 |
TheJulia | so I think https://review.opendev.org/#/c/735966/9/functions's changes have effectively blown up Ironic's ci | 21:13 |
gmann | Open10K8S: yeah, and you can check tempest is enabled or not before editing tempest.conf | 21:13 |
Open10K8S | gmann: super | 21:13 |
TheJulia | http://paste.openstack.org/show/795960/ | 21:14 |
TheJulia | dansmith: you around? | 21:19 |
dansmith | TheJulia: I am | 21:23 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/devstack master: dnm: debug https://review.opendev.org/741082 | 21:23 |
dansmith | TheJulia: hrm, link to job? | 21:23 |
TheJulia | https://etherpad.opendev.org/p/IronicWhiteBoard line 55 has all of the links | 21:27 |
TheJulia | I'm ripping out the property setting on kernels/ramdisks, that may be enoug | 21:27 |
TheJulia | enough | 21:27 |
gmann | dansmith: this one causing issue https://review.opendev.org/#/c/735966/9/functions@425 | 21:28 |
dansmith | gmann: ah I missed those were image creates | 21:29 |
dansmith | that use the property thing | 21:29 |
gmann | we missed the $img_property usage in other place than upload func | 21:29 |
dansmith | is this really for ironic? because they shouldn't be getting the rng model set to virtio anyway | 21:30 |
dansmith | I mean, we shouldn't foist that on them like we are | 21:30 |
openstackgerrit | Julia Kreger proposed openstack/devstack master: Fix glance image handling https://review.opendev.org/741322 | 21:31 |
dansmith | TheJulia: are you confident in the assertion that those properties should never be set on the kernel/ramdisk? | 21:33 |
TheJulia | dansmith: yeah, it is. Looks like it is set by default but of course it is not actually used by ironic | 21:33 |
TheJulia | and by it, I mean the rng property | 21:33 |
dansmith | surely you shouldn't have that property at all, | 21:34 |
TheJulia | dansmith: fairly confident, but not 100% | 21:34 |
TheJulia | https://review.opendev.org/#/c/741323/ uploaded to see if the above change worsk | 21:34 |
dansmith | but what I mean is... are you sure nova doesn't look at the kernel/ramdisk for those properties fo that image type? | 21:34 |
dansmith | I'm surprised you're using ami images for ironic at all.. is that normal? | 21:34 |
TheJulia | no idea, I just know I'm running on about a week of barely working CI for ironic :( | 21:34 |
TheJulia | Partition image testing | 21:34 |
TheJulia | We support both partition and whole disk images | 21:35 |
dansmith | huh okay | 21:35 |
*** yamamoto has quit IRC | 21:35 | |
dansmith | well, for the short-term fix, just not setting that one property is sure not to cause you trouble, since you don't need it anyway, I just dunno about other users of ami images where it may need to be set | 21:35 |
dansmith | but whatevs | 21:36 |
*** yamamoto has joined #openstack-qa | 21:36 | |
gmann | yeah, may be just correct those with --property to unblock the gate | 21:36 |
TheJulia | dansmith: it is not the existence of the property that matters | 21:37 |
dansmith | nobody in their right mind uses them for libvirt on nova, and most of the other drivers are bitrotting towards removal anyway so .. meh | 21:37 |
gmann | and removing them as separate patch if we know all users do not need it | 21:37 |
TheJulia | it is the fact the prepending --property was moved | 21:37 |
dansmith | TheJulia: I understand, your change avoids ever setting the property on those instead of just fixing it to use the arg properly, and I'm just saying that's more change instead of fixing the regression is all | 21:37 |
TheJulia | the image create commands flat out fail with the unknown parameter | 21:37 |
dansmith | I don't know anyone that cares, but it would be more safer to just make it act like it did last week | 21:38 |
TheJulia | dunno, on a plus side, we shhould have feedback from CI soon :) | 21:38 |
gmann | let's add --property there for now otherwise it is difficult to fast merge as gate fix | 21:38 |
dansmith | not really, because obviously nobody else is running CI against these changes, else we'd have noticed | 21:38 |
dansmith | gmann: I will put up a fix to make it act like before and you can decide which you want | 21:39 |
TheJulia | dansmith: my empty change can be re-used once we have some gate feedback | 21:39 |
TheJulia | Thanks guys! | 21:40 |
gmann | sure, I can fast merge the act like before and we can wait for TheJulia patch for CI results and other core feedback | 21:41 |
openstackgerrit | Dan Smith proposed openstack/devstack master: Fix ami/aki image create use of $img_property https://review.opendev.org/741326 | 21:42 |
TheJulia | so on a plus side, I did propose to make ironic voting earlier today, and in the last week a change DID merge so we run both wholedisk and partition image testing in the same integration test run.... | 21:42 |
dansmith | gmann: something like this ^ | 21:42 |
TheJulia | dansmith: i like! | 21:43 |
openstackgerrit | Dan Smith proposed openstack/devstack master: Fix ami/aki image create use of $img_property https://review.opendev.org/741326 | 21:44 |
dansmith | +usage comment | 21:44 |
gmann | TheJulia: this one ? but that job passed on 735966. you want to add partition image job also ?- https://review.opendev.org/#/c/741265/1 | 21:45 |
*** paras333 has quit IRC | 21:45 | |
dansmith | TheJulia: I have a nova change that was depending on this for a while and never saw an ironic failure, but I guess we only run your wholedisk variant | 21:47 |
dansmith | (for a while before merge, I mean) | 21:47 |
* TheJulia blinks | 21:48 | |
gmann | devstack also run wholedisk job which was passing there so we could not catch this | 21:48 |
dansmith | okay | 21:48 |
TheJulia | wow, okay, how in the world did 735966 pass... | 21:48 |
TheJulia | dansmith: it happens, digging into the zuul +1 vote on 735966 right now | 21:49 |
dansmith | if this is a common breakage then we could have both image types in the same job and just have at least one test that'll select for the other type, but if it's just an unfortunate one-off then you'll just have to accept my apologies I guess :) | 21:50 |
gmann | https://zuul.opendev.org/t/openstack/build/75fd399dc57f4d1aac59869f888fb473/log/controller/logs/devstacklog.txt#20520 | 21:50 |
TheJulia | under the hood, it looks like it didn't actually run the partition image based deploy, not sure why tempest says otherwise :\ | 21:53 |
TheJulia | dansmith: we've kind of been in flight in getting testing of both image types into the same job, so maybe just timing collission | 21:54 |
TheJulia | I didn't even mentally think that it had merged until I was on a team status sync earlier today and went "oh, cool!" | 21:54 |
openstackgerrit | Dan Smith proposed openstack/devstack master: Only set hw_rng_model by default if we're on libvirt https://review.opendev.org/741328 | 21:54 |
dansmith | amirite ^ ? | 21:54 |
TheJulia | iurygregory: you might find this entire discussion interesting, fwiw | 21:56 |
TheJulia | dansmith: lgtm | 21:56 |
*** rcernin has joined #openstack-qa | 22:19 | |
*** rcernin has quit IRC | 22:20 | |
*** rcernin has joined #openstack-qa | 22:21 | |
*** vapjes has quit IRC | 22:33 | |
*** tosky has quit IRC | 22:48 | |
*** ccamposr has joined #openstack-qa | 22:50 | |
*** tkajinam has joined #openstack-qa | 22:55 | |
*** tkajinam has quit IRC | 22:55 | |
*** tkajinam has joined #openstack-qa | 22:58 | |
*** yamamoto has quit IRC | 22:59 | |
*** markvoelker has joined #openstack-qa | 23:11 | |
*** markvoelker has quit IRC | 23:15 | |
*** yamamoto has joined #openstack-qa | 23:30 | |
*** yamamoto has quit IRC | 23:32 | |
*** yamamoto has joined #openstack-qa | 23:32 | |
*** ccamposr has quit IRC | 23:47 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!