| *** rcernin has joined #openstack-qa | 00:03 | |
| *** brinzhang has quit IRC | 00:05 | |
| *** yamamoto has quit IRC | 00:10 | |
| *** yamamoto has joined #openstack-qa | 00:11 | |
| *** yamamoto has quit IRC | 00:16 | |
| *** brinzhang has joined #openstack-qa | 00:17 | |
| *** rcernin has quit IRC | 00:24 | |
| *** yamamoto has joined #openstack-qa | 00:25 | |
| *** rcernin has joined #openstack-qa | 00:27 | |
| openstackgerrit | Merged openstack/patrole master: Restore test user's original roles during clean up https://review.opendev.org/c/openstack/patrole/+/770523 | 00:27 |
|---|---|---|
| lxkong | gmann, kopecmartin, so what else should I do to continue https://review.opendev.org/c/openstack/patrole/+/768771 please? | 01:18 |
| *** rcernin has quit IRC | 01:18 | |
| openstackgerrit | Akihiro Motoki proposed openstack/devstack stable/ussuri: Use a dedicated version of get-pip.py for python 2.7 https://review.opendev.org/c/openstack/devstack/+/772461 | 01:26 |
| openstackgerrit | Akihiro Motoki proposed openstack/devstack stable/train: Use a dedicated version of get-pip.py for python 2.7 https://review.opendev.org/c/openstack/devstack/+/772462 | 01:32 |
| *** rcernin has joined #openstack-qa | 01:55 | |
| *** rcernin has quit IRC | 02:02 | |
| *** rcernin has joined #openstack-qa | 02:15 | |
| *** rcernin has quit IRC | 02:20 | |
| *** rcernin has joined #openstack-qa | 02:23 | |
| openstackgerrit | Merged openstack/whitebox-tempest-plugin master: Add sanity nvdimm test https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/765380 | 02:31 |
| openstackgerrit | Merged openstack/patrole master: Reuse tempest to create admin client manager https://review.opendev.org/c/openstack/patrole/+/768771 | 02:32 |
| *** rcernin has quit IRC | 02:38 | |
| openstackgerrit | Merged openstack/whitebox-tempest-plugin master: Added SR-IOV numa affinity testcases https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/703662 | 03:14 |
| *** rcernin has joined #openstack-qa | 03:34 | |
| *** rcernin has quit IRC | 03:39 | |
| openstackgerrit | Merged openstack/tempest master: 1912117: Fix the IP URL for metadata service in fixed network scenario https://review.opendev.org/c/openstack/tempest/+/771156 | 03:52 |
| *** rcernin has joined #openstack-qa | 05:18 | |
| *** brinzhang has quit IRC | 05:20 | |
| *** brinzhang has joined #openstack-qa | 05:21 | |
| *** rcernin has quit IRC | 05:26 | |
| *** gcheresh has joined #openstack-qa | 05:39 | |
| *** rcernin has joined #openstack-qa | 05:40 | |
| *** rcernin has quit IRC | 05:45 | |
| *** rcernin has joined #openstack-qa | 06:09 | |
| *** rcernin has quit IRC | 06:49 | |
| *** spotz has quit IRC | 06:54 | |
| *** lpiwowar has joined #openstack-qa | 07:06 | |
| *** ccamposr__ has joined #openstack-qa | 07:21 | |
| *** ccamposr has quit IRC | 07:24 | |
| *** rcernin has joined #openstack-qa | 07:38 | |
| *** ralonsoh has joined #openstack-qa | 07:52 | |
| *** rpittau|afk_ is now known as rpittau | 07:57 | |
| *** slaweq has joined #openstack-qa | 07:59 | |
| *** sboyron has joined #openstack-qa | 08:05 | |
| *** rcernin has quit IRC | 08:17 | |
| *** rcernin has joined #openstack-qa | 08:42 | |
| *** tosky has joined #openstack-qa | 08:45 | |
| *** rcernin has quit IRC | 08:46 | |
| *** jpena|off is now known as jpena | 08:57 | |
| *** lucasagomes has joined #openstack-qa | 09:02 | |
| openstackgerrit | Merged openstack/tempest master: Make random_bytes() enforce sane size limits https://review.opendev.org/c/openstack/tempest/+/770852 | 09:10 |
| *** rcernin has joined #openstack-qa | 09:27 | |
| *** yamamoto has quit IRC | 09:29 | |
| *** rcernin has quit IRC | 09:45 | |
| openstackgerrit | Elod Illes proposed openstack/devstack stable/stein: Use a dedicated version of get-pip.py for python 2.7 https://review.opendev.org/c/openstack/devstack/+/772486 | 09:54 |
| openstackgerrit | Elod Illes proposed openstack/devstack stable/rocky: Use a dedicated version of get-pip.py for python 2.7 https://review.opendev.org/c/openstack/devstack/+/772487 | 09:55 |
| openstackgerrit | Elod Illes proposed openstack/devstack stable/queens: Use a dedicated version of get-pip.py for python 2.7 https://review.opendev.org/c/openstack/devstack/+/772488 | 09:56 |
| *** rcernin has joined #openstack-qa | 09:58 | |
| openstackgerrit | Elod Illes proposed openstack/devstack stable/pike: Use a dedicated version of get-pip.py for python 2.7 https://review.opendev.org/c/openstack/devstack/+/772489 | 09:58 |
| openstackgerrit | Elod Illes proposed openstack/devstack stable/queens: Use a dedicated version of get-pip.py for python 2.7 https://review.opendev.org/c/openstack/devstack/+/772488 | 09:59 |
| openstackgerrit | Elod Illes proposed openstack/devstack stable/rocky: Use a dedicated version of get-pip.py for python 2.7 https://review.opendev.org/c/openstack/devstack/+/772487 | 10:01 |
| openstackgerrit | Elod Illes proposed openstack/devstack stable/stein: Use a dedicated version of get-pip.py for python 2.7 https://review.opendev.org/c/openstack/devstack/+/772486 | 10:01 |
| openstackgerrit | Elod Illes proposed openstack/devstack stable/train: Use a dedicated version of get-pip.py for python 2.7 https://review.opendev.org/c/openstack/devstack/+/772462 | 10:03 |
| *** yamamoto has joined #openstack-qa | 10:04 | |
| *** brinzhang has quit IRC | 10:14 | |
| *** yamamoto has quit IRC | 10:15 | |
| *** dtantsur|afk is now known as dtantsur | 10:18 | |
| *** rcernin has quit IRC | 10:27 | |
| *** ricolin has quit IRC | 10:28 | |
| *** rcernin has joined #openstack-qa | 11:04 | |
| *** brinzhang has joined #openstack-qa | 11:04 | |
| *** rpittau is now known as rpittau|bbl | 11:09 | |
| *** rcernin has quit IRC | 11:35 | |
| *** yamamoto has joined #openstack-qa | 11:46 | |
| *** tbachman has quit IRC | 11:52 | |
| *** yamamoto has quit IRC | 12:23 | |
| *** jpena is now known as jpena|lunch | 12:25 | |
| *** ricolin has joined #openstack-qa | 12:34 | |
| *** lpiwowar has quit IRC | 12:43 | |
| *** lpiwowar has joined #openstack-qa | 12:43 | |
| *** rpittau|bbl is now known as rpittau | 12:59 | |
| *** yamamoto has joined #openstack-qa | 13:03 | |
| *** rh-jelabarre has joined #openstack-qa | 13:04 | |
| *** yamamoto has quit IRC | 13:09 | |
| openstackgerrit | Elod Illes proposed openstack/devstack stable/stein: Use a dedicated version of get-pip.py for python 2.7 https://review.opendev.org/c/openstack/devstack/+/772486 | 13:12 |
| *** jpena|lunch is now known as jpena | 13:17 | |
| openstackgerrit | Merged openstack/tempest master: test_encrypted_cinder_volumes: Do not create an image for this test https://review.opendev.org/c/openstack/tempest/+/771958 | 13:23 |
| *** tbachman has joined #openstack-qa | 13:30 | |
| *** vhari has quit IRC | 13:33 | |
| openstackgerrit | Elod Illes proposed openstack/devstack stable/stein: Use a dedicated version of get-pip.py for python 2.7 https://review.opendev.org/c/openstack/devstack/+/772486 | 13:34 |
| openstackgerrit | Elod Illes proposed openstack/devstack stable/rocky: Use a dedicated version of get-pip.py for python 2.7 https://review.opendev.org/c/openstack/devstack/+/772487 | 13:35 |
| openstackgerrit | Elod Illes proposed openstack/devstack stable/queens: Use a dedicated version of get-pip.py for python 2.7 https://review.opendev.org/c/openstack/devstack/+/772488 | 13:38 |
| gmann | amotoki: elod we should only do py2 fix for <=stable/train only https://review.opendev.org/q/I88ba370de8887a05c473fe7c19a61a319e8812d2 | 13:55 |
| *** paras333 has quit IRC | 13:59 | |
| *** paras333 has joined #openstack-qa | 13:59 | |
| elod | gmann: hmmm, you are right, py2 is not supported after train. I wonder if amotoki had seen errors @ ussuri despite that | 13:59 |
| gmann | elod: we (any project) should not have py2 job running on ussuri onwards(except swift/storlet) | 14:00 |
| masayukig | #startmeeting qa | 14:00 |
| openstack | Meeting started Tue Jan 26 14:00:30 2021 UTC and is due to finish in 60 minutes. The chair is masayukig. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| *** openstack changes topic to " (Meeting topic: qa)" | 14:00 | |
| openstack | The meeting name has been set to 'qa' | 14:00 |
| gmann | elod: may be we need to check with train fix only and other EM branch also if fix is already there | 14:01 |
| masayukig | Hi, who all here today? | 14:01 |
| masayukig | sorry for interrupt but it's the time anyway | 14:01 |
| kopecmartin | masayukig: hi | 14:01 |
| gmann | yeah | 14:01 |
| gmann | o/ | 14:01 |
| paras333 | o/ | 14:01 |
| masayukig | ok, let's start | 14:02 |
| masayukig | #link https://wiki.openstack.org/wiki/Meetings/QATeamMeeting | 14:02 |
| masayukig | Here's the agenda | 14:02 |
| masayukig | #topic Announcement and Action Item (Optional) | 14:02 |
| *** openstack changes topic to "Announcement and Action Item (Optional) (Meeting topic: qa)" | 14:02 | |
| masayukig | I have no announcement and I don't see any items on the agenda. | 14:03 |
| masayukig | So, let's skip | 14:03 |
| masayukig | #topic Wallaby Priority Items progress | 14:03 |
| *** openstack changes topic to "Wallaby Priority Items progress (Meeting topic: qa)" | 14:03 | |
| masayukig | #link https://etherpad.opendev.org/p/qa-wallaby-priority | 14:03 |
| masayukig | Any updates on the priority? | 14:03 |
| *** vhari has joined #openstack-qa | 14:03 | |
| gmann | I have some progress | 14:04 |
| masayukig | cool | 14:04 |
| paras333 | I need some feedback on the way I am doing the run_validation , Is this the best way #link https://review.opendev.org/c/openstack/tempest/+/763925 so if you guys can take a look that would be great | 14:04 |
| gmann | we have all the patches up for tempest-horizon test moving | 14:04 |
| gmann | #link https://review.opendev.org/q/topic:%22merge-horizon-test%22+(status:open%20OR%20status:merged) | 14:04 |
| gmann | tempest one is merged so dashbaord test run as part of tempest-full* job | 14:05 |
| masayukig | paras333: thanks. ack, I hope I have the time to look at it this week | 14:06 |
| paras333 | masayukig: yeah no rush | 14:06 |
| gmann | on RBAC testing, we have all the patches approved now | 14:06 |
| gmann | #link https://review.opendev.org/q/topic:%22admin-auth-system-scope%22+(status:open%20OR%20status:merged) | 14:07 |
| gmann | next we need to start moving test to new policy for compute and keystone | 14:07 |
| paras333 | gmann: masayukig: for creating the gate job, what would be the place to start, I have never created the gate jobs before so might need your help for guest image work? | 14:07 |
| masayukig | gmann: great. I'll check tempest-horizon ones. | 14:08 |
| paras333 | I am thinking to use windows image for the guest image and run sanity tests on it? | 14:08 |
| gmann | paras333: you can create in https://github.com/openstack/tempest/blob/master/zuul.d/tempest-specific.yaml | 14:08 |
| gmann | as they will be tempest specific | 14:08 |
| paras333 | gmann: ok I will take a look | 14:09 |
| gmann | paras333 or you are planning to run those in other project gate too ? | 14:09 |
| paras333 | gmann: no just on tempest for now | 14:09 |
| gmann | ok then tempest-specific.yaml is fine | 14:09 |
| paras333 | if we see value we can add this to others as well | 14:09 |
| gmann | sure, that time we can move in integrated file | 14:09 |
| paras333 | gmann: ack | 14:09 |
| amotoki | gmann: I didn't see errors in stable/ussuri as we specify USE_PYTHON3=True. stable/ussuri should fail if USE_PYTHON3=False though I am not sure we need to cover such case. It looks like during an office hour, so I don't comment more now. | 14:10 |
| gmann | amotoki: we will have that topic next so you are on perfect time :) | 14:11 |
| masayukig | ok, let's move on to the next topic if we have nothing else on this topic. | 14:11 |
| masayukig | #topic OpenStack Events Updates and Planning | 14:12 |
| *** openstack changes topic to "OpenStack Events Updates and Planning (Meeting topic: qa)" | 14:12 | |
| masayukig | let's skip this topic | 14:12 |
| masayukig | #topic Gate Status Checks | 14:12 |
| *** openstack changes topic to "Gate Status Checks (Meeting topic: qa)" | 14:12 | |
| masayukig | this is the topic | 14:12 |
| gmann | yeah | 14:12 |
| gmann | amotoki: i do not think we need to support USE_PYTHON3=False for ussuri onwards | 14:13 |
| gmann | and we have removed many py2 hack in ussuri onwards so supporting that case seems like reverting the plan of python-only | 14:13 |
| amotoki | gmann: I just proposed a fix for branches where python3_enabled() is conditional. | 14:13 |
| gmann | python3-only | 14:13 |
| gmann | may be we should remove that in ussuri. | 14:14 |
| masayukig | ++ | 14:14 |
| gmann | yoctozepto: frickler ^^? | 14:14 |
| amotoki | gmann: USE_PYTHON3 was dropped in victoria... | 14:14 |
| amotoki | i am okay with either. | 14:14 |
| gmann | yeah as we were transitioning to python3-only in ussuri so backporting 'USE_PYTHON3 drop' to ussuri make sense now | 14:15 |
| elod | i think the backport is not necessary | 14:16 |
| elod | simply ignore that | 14:16 |
| gmann | supporting fix in train I agree. other em branch is also fine if fix is there | 14:16 |
| elod | i mean the ussuri patch | 14:16 |
| gmann | elod: yeah that also work but sometime it come again | 14:16 |
| elod | yes, for train and older the patch is OK | 14:16 |
| gmann | amotoki: elod thanks for that, I will check those today | 14:17 |
| elod | gmann: py2 is not even used in ussuri, so it's not necessary, i think | 14:17 |
| amotoki | so should I drop my fix for ussuri? | 14:17 |
| elod | gmann: thanks too, and thanks amotoki for the patch, too! | 14:17 |
| gmann | amotoki: yeah, we can drop for ussuri and if anyone need py2 on ussuri thenj we say 'not supported' | 14:17 |
| elod | ++ | 14:18 |
| gmann | i mean drop fix | 14:18 |
| amotoki | okay, if so, we need to update the commit message from a train fix and other backports (i.e. to drop the cherry-picked line) | 14:18 |
| elod | amotoki: I can do that if you want | 14:18 |
| gmann | ah yeah. | 14:18 |
| amotoki | is it worht rerunning CIs for all fixes in train and older? | 14:18 |
| elod | good question :) maybe not? :) | 14:19 |
| amotoki | I think it is tricky if no corresponding cherry-picked commit is abandoned... | 14:19 |
| amotoki | s/no// | 14:19 |
| gmann | ok, i am fine for that and anyone can know by checking ussuri patch status | 14:19 |
| *** yamamoto has joined #openstack-qa | 14:19 | |
| gmann | amotoki: anything ok for me, fixing cmt msg is perfect but up to you | 14:20 |
| amotoki | gmann: okay, so I will keep the train fix as-is. and will abandon the ussuri fix. | 14:21 |
| gmann | ok | 14:22 |
| elod | one minor note: currently train patch requires stein patch to merge first (grenade) | 14:22 |
| elod | the others are not dependent on each other | 14:22 |
| gmann | elod: yeah we need to merge in reverse way | 14:22 |
| elod | ++ | 14:22 |
| masayukig | thanks | 14:23 |
| amotoki | granade job is non-voting. perhaps it allows us to land the fix in any order. | 14:23 |
| *** stand has quit IRC | 14:24 | |
| amotoki | anyway it is up to the qa team | 14:24 |
| elod | amotoki: except @ train :) strange, but that is how it is now :) | 14:24 |
| gmann | let's see gate result i think we made it voting in stein. or not yet n-v it | 14:24 |
| gmann | yeah and in train it is voting | 14:24 |
| *** yamamoto has quit IRC | 14:24 | |
| *** brinzhang has quit IRC | 14:25 | |
| gmann | tempest-full-train-py3 in periodic fail with same get-pip error - https://zuul.openstack.org/build/dac028e6585b410c8bc108390b614f5a | 14:25 |
| *** brinzhang has joined #openstack-qa | 14:25 | |
| gmann | this is python3 job | 14:25 |
| elod | I mean strangely in ussuri grenade is non-voting | 14:25 |
| gmann | elod: :) we forget to undo that may be | 14:25 |
| amotoki | ah. I did not notice elod added Depends-On to the train patch. | 14:26 |
| gmann | amotoki: elod tempest-full-train-py3 in periodic fail with same get-pip error - https://zuul.openstack.org/build/dac028e6585b410c8bc108390b614f5a | 14:26 |
| gmann | ? | 14:26 |
| elod | gmann: yes, the same error | 14:26 |
| *** stand has joined #openstack-qa | 14:26 | |
| amotoki | gmann: yes the same error | 14:26 |
| *** zenkuro has quit IRC | 14:26 | |
| gmann | but it is py3 path | 14:27 |
| *** zenkuro has joined #openstack-qa | 14:27 | |
| amotoki | in train, we always insatll pip for py27 | 14:27 |
| amotoki | and the error happens here. | 14:27 |
| elod | latest get-pip.py does not work with py35 either | 14:27 |
| gmann | ah right | 14:28 |
| gmann | py35 is until stable/rocky only afaik | 14:28 |
| gmann | ok. let's get those fix in and we will have stable/train gate back | 14:28 |
| elod | tempest-full-train-py3 fails in rocky and queens | 14:28 |
| gmann | elod: yeah they use py35 and stein onwards it is py36 due to bionic node migration | 14:29 |
| elod | exactly | 14:29 |
| masayukig | ok, anything else to discuss for this topic | 14:29 |
| masayukig | ? | 14:29 |
| gmann | nothing from me, may be we can move next | 14:30 |
| masayukig | ok | 14:30 |
| masayukig | #topic Periodic jobs Status Checks | 14:31 |
| *** openstack changes topic to "Periodic jobs Status Checks (Meeting topic: qa)" | 14:31 | |
| masayukig | This is the similar topic, though | 14:31 |
| gmann | we discussed it for train which is failing now | 14:31 |
| masayukig | yeah | 14:31 |
| gmann | for ussuri and victoria it is green | 14:31 |
| masayukig | tempest-all is failing on Periodic master | 14:32 |
| gmann | yeah that is still broken | 14:32 |
| gmann | same issue | 14:32 |
| paras333 | gmann: sorry, If i missed it. Is this job fixed https://zuul.opendev.org/t/openstack/build/fdb70e77db1e43a8b793d4058bb8b8b8 ? | 14:32 |
| paras333 | low-constraints one | 14:33 |
| gmann | paras333: no, we are still discussing in TC and ML if to drop the l-c or fix | 14:33 |
| paras333 | gmann: ack thanks | 14:33 |
| masayukig | gmann: ok, we need to fix the issue, anyway | 14:33 |
| gmann | paras333: we can make it n-v until than and unblock the gate | 14:33 |
| gmann | masayukig: yeah | 14:33 |
| masayukig | let's move on to the next topic if nothing | 14:34 |
| paras333 | gmann: yeah that make sense, I will add the patch for hacking then | 14:34 |
| gmann | someone need to debug it | 14:34 |
| gmann | paras333: cool. | 14:34 |
| masayukig | yeah | 14:34 |
| masayukig | paras333: ++ | 14:34 |
| masayukig | ok, let's move on to the next topic | 14:35 |
| masayukig | #topic Sub Teams highlights (Sub Teams means individual projects under QA program) | 14:35 |
| *** openstack changes topic to "Sub Teams highlights (Sub Teams means individual projects under QA program) (Meeting topic: qa)" | 14:35 | |
| masayukig | #link https://review.openstack.org/#/q/project:openstack/tempest+status:open | 14:35 |
| masayukig | #link https://review.openstack.org/#/q/project:openstack/patrole+status:open | 14:35 |
| masayukig | #link https://review.openstack.org/#/q/project:openstack/devstack+status:open | 14:35 |
| masayukig | #link https://review.openstack.org/#/q/project:openstack/grenade+status:open | 14:35 |
| masayukig | #link https://review.opendev.org/#/q/project:openstack/hacking+status:open | 14:35 |
| gmann | we still have slow rate for tempest reivew | 14:35 |
| kopecmartin | yeah, there are a lot of reviews missing second core vote :/ | 14:36 |
| gmann | yeah | 14:36 |
| gmann | one way is to change the policy to single core approval | 14:37 |
| gmann | also it is not 2nd core missing but many of them are not yet reviewed at all | 14:37 |
| gmann | *it is not only 2nd core... | 14:38 |
| masayukig | yeah.. | 14:38 |
| gmann | I feel it is time to go with single core approval and if we feel we need another core to have a look we can always have that | 14:39 |
| openstackgerrit | Artom Lifshitz proposed openstack/whitebox-tempest-plugin master: WIP: Different approach to TripleO job https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/762866 | 14:39 |
| masayukig | yeah, but I think we need to discuss to change the policy to single core approval, at least | 14:39 |
| masayukig | on IRC and/or ML | 14:39 |
| gmann | yeah, here we are doing :) | 14:40 |
| masayukig | or patch for the policy document | 14:40 |
| masayukig | yeah :) | 14:40 |
| gmann | I think we can discuss in IRC | 14:40 |
| gmann | as it is upto tempest team | 14:40 |
| gmann | if we decide then i can push patch | 14:40 |
| gmann | if all are ok with that | 14:40 |
| paras333 | gmann: masayukig: If I understand correctly we do need atleast one other reviewer as well right even though he/she was not the core reviewer? | 14:40 |
| paras333 | to merge the patch? | 14:41 |
| gmann | paras333: yeah at least one core review can merge it | 14:41 |
| gmann | paras333: currently it need two core | 14:41 |
| masayukig | yes | 14:41 |
| paras333 | correct | 14:42 |
| masayukig | we need two +2 to approve the patch basically | 14:42 |
| *** stand has quit IRC | 14:43 | |
| masayukig | There are some exceptions such as very urgent, very easy, etc., though | 14:43 |
| paras333 | yeah I know that I am just thinking , do we need one more reviewer to merge it even though they can just +1 ? | 14:43 |
| amotoki | single core + domain expert (including non-core) is an option if you don't have enough core review bandwidth. I am not sure it works for you casre | 14:43 |
| paras333 | so one +1 and one +2 basically | 14:43 |
| gmann | paras333: yeah with +1 we will still need at least one +2 | 14:43 |
| *** dave-mccowan has joined #openstack-qa | 14:44 | |
| paras333 | correct yeah I am totally onboard with this | 14:44 |
| gmann | amotoki: yeah that is issue, tempest team is facing review bandwidth (two core to merge) since an year or so | 14:44 |
| masayukig | amotoki: yeah, that's a good idea. | 14:44 |
| paras333 | as amotoki suggested this should be the great idea | 14:45 |
| gmann | amotoki: masayukig we can always ask domain expert review from tempest team or other team anyways | 14:45 |
| paras333 | to have one core expert reviewing as well | 14:45 |
| gmann | like sometime i ask neutron team to ask neutron test changes | 14:45 |
| masayukig | I haven't the bw recently.. :( | 14:45 |
| masayukig | gmann: yeah | 14:45 |
| gmann | mostly we stuck with kopecmartin and myself waiting for other +2 for our patches | 14:46 |
| *** nweinber has joined #openstack-qa | 14:46 | |
| *** dave-mccowan has quit IRC | 14:46 | |
| masayukig | sorry about that.. don't blame me :p | 14:47 |
| gmann | :) no its complete team i think not just you. you are doing already more than your current bw | 14:47 |
| *** brinzhang has quit IRC | 14:48 | |
| gmann | so if i propose the patch and then we can review it if any oppose in thay | 14:48 |
| gmann | that | 14:48 |
| gmann | and if we merge that then i can push it on ML as notification | 14:48 |
| gmann | is it fine? | 14:48 |
| kopecmartin | sure | 14:48 |
| amotoki | another idea is to apply some exception that a patch from a core reivewer can be approved by a single +2. | 14:48 |
| masayukig | gmann: thanks :) yeah, that's good for me | 14:48 |
| gmann | amotoki: i see but not sure if that sounds good and fair for non-core? any other project have such policy | 14:49 |
| gmann | that can solve the things at some extend for core patches but non-core patches still will face the issue | 14:50 |
| amotoki | gmann: that's just an idea. horizon stable has such policy that a backport from stable core can be approved by a single +2, but it is just about stable backports. | 14:50 |
| *** brinzhang has joined #openstack-qa | 14:51 | |
| gmann | ohk | 14:51 |
| *** brinzhang has quit IRC | 14:51 | |
| masayukig | intersting | 14:51 |
| gmann | few exception we still have for gate fix and trivial changes | 14:51 |
| masayukig | yeah #link https://docs.openstack.org/tempest/latest/REVIEWING.html#when-to-approve | 14:51 |
| *** brinzhang has joined #openstack-qa | 14:52 | |
| dansmith | gmann: we kinda have that policy for stable in nova | 14:52 |
| amotoki | in case of backport, a stalbe core is expected to be familiar with the stalbe policy, so such rule can be reaonable but it is not usually true for master changes. | 14:52 |
| dansmith | right ^ | 14:52 |
| dansmith | it's a little different than a review on master though because the patch isn't net-new | 14:53 |
| dansmith | but I think that it probably makes sense to do what gmann is suggesting, especially for smaller things that are unlikely to generate problems and can be validated by a SME | 14:53 |
| gmann | yeah for backport it might be easy as code changes already reviewed by two core on master | 14:53 |
| gmann | yeah | 14:53 |
| masayukig | #topic Open Discussion | 14:53 |
| *** openstack changes topic to "Open Discussion (Meeting topic: qa)" | 14:53 | |
| masayukig | we're in this topic | 14:54 |
| dansmith | can I bring up devstack things here? | 14:54 |
| masayukig | dansmith: yes | 14:54 |
| dansmith | so I have been working on this: https://review.opendev.org/c/openstack/devstack/+/771505 | 14:54 |
| dansmith | it makes devstack setup 25% faster in my local env | 14:55 |
| dansmith | it's really not very complicated and easy to disable to that it becomes exactly like the current code in terms of behavior | 14:55 |
| dansmith | there is a lot left to optimize to get it even faster I think, I've only really parallelized nova and some of the project setup | 14:55 |
| masayukig | 25% faster sounds great! | 14:56 |
| dansmith | there's a lot of serialized work we can squeeze out of the devstack process, which (a) could help the gate and (b) makes a quick devstack run locally much more palatable | 14:56 |
| dansmith | I would love to keep working on it, but I don't want this one patch to grow too large, and I don't want to put in the effort if people here aren't likely to accept it | 14:56 |
| gmann | dansmith: Thanks, I will be checking it sometime this week. so you change is enabling it by default but a way to disable too? | 14:57 |
| dansmith | so, I'm just hoping to get some reviews on it (I know, right after the discussion about review bandwidth :) | 14:57 |
| amodi | gmann: thanks for the reply re: devstack based barbican job | 14:57 |
| dansmith | https://review.opendev.org/c/openstack/devstack/+/771505/6/inc/async | 14:57 |
| gmann | dansmith: i see | 14:57 |
| dansmith | it's off by default, but I'd definitely like to enable it on some jobs and then flip to default at some point | 14:57 |
| gmann | dansmith: do you have some job with enable? | 14:58 |
| dansmith | gmann: it ran enabled by default before I added the toggle in the very last job | 14:58 |
| dansmith | gmann: I haven't seen it fail the devstack job yet, and the tempest jobs mostly have worked, but some failed for other unrelated reasons | 14:59 |
| dansmith | so there should be several logs | 14:59 |
| dansmith | but I can push a patch on top to change the devstack job config to async if you want just to make it obvious | 14:59 |
| gmann | dansmith: or may be a new devstack-platform job can be added in same patch to see the enable behaviors ? | 15:00 |
| gmann | devstack-platform-async | 15:00 |
| dansmith | sure, although you can't really compare the runtimes of two jobs to tell the improvement, you have to see it over many runs | 15:00 |
| masayukig | sorry, we're running out of the time for the office hour. So, I'm closing it. | 15:00 |
| openstackgerrit | Paras Babbar proposed openstack/hacking master: Updating lower-constarints job as non voting https://review.opendev.org/c/openstack/hacking/+/772556 | 15:01 |
| gmann | yeah we can close office hour and continue | 15:01 |
| dansmith | I was hoping to show those numbers, but the same worker will yield vastly different runtimes on the same job from minute to minute :) | 15:01 |
| masayukig | #endmeeting | 15:01 |
| *** openstack changes topic to "Discussion of OpenStack Quality Assurance Projects (tempest, devstack, grenade, and friends) | docs https://wiki.openstack.org/wiki/QA | specs https://review.openstack.org/#/q/project:openstack/qa-specs | channel logs http://eavesdrop.openstack.org/irclogs/%23openstack-qa/" | 15:01 | |
| openstack | Meeting ended Tue Jan 26 15:01:08 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:01 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/qa/2021/qa.2021-01-26-14.00.html | 15:01 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/qa/2021/qa.2021-01-26-14.00.txt | 15:01 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/qa/2021/qa.2021-01-26-14.00.log.html | 15:01 |
| gmann | dansmith: ah | 15:01 |
| masayukig | kopecmartin: I'm sorry for my bad time coordination. | 15:02 |
| dansmith | gmann: best thing to do is pull it down, run it once locally, then flip on the async and unstack/stack again | 15:02 |
| yoctozepto | gmann: I had an overlapping meeting, sorry :-( | 15:02 |
| kopecmartin | masayukig: np, there were a lot of important topic to cover today ;) | 15:02 |
| gmann | dansmith: ok, I can try that | 15:02 |
| masayukig | kopecmartin: thanks, yeah | 15:03 |
| amodi | lyarwood: artom https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/771283/5/whitebox_tempest_plugin/api/compute/test_volume_encryption.py#1 the user/project used to create the volumes is not the one deleting it, hence we get the secret:delete not allowed error, i can't find where does this happen, can u help me debug it? | 15:03 |
| openstackgerrit | Paras Babbar proposed openstack/hacking master: Updating lower-constarints job as non voting https://review.opendev.org/c/openstack/hacking/+/772556 | 15:03 |
| gmann | yoctozepto: one of the fix for devstack stable (py2 for <=stable/trsin) is https://review.opendev.org/q/I88ba370de8887a05c473fe7c19a61a319e8812d2 | 15:03 |
| amodi | or should i override the cleanup/teardown class | 15:04 |
| *** ralonsoh has quit IRC | 15:04 | |
| *** ralonsoh has joined #openstack-qa | 15:04 | |
| yoctozepto | uh-oh, let me see that utmost misery | 15:05 |
| lyarwood | amodi: it's likely due to the way in which the clients are being set up in your classes | 15:07 |
| lyarwood | amodi: BaseWhiteboxComputeTest is using the admin clients, I wonder if that's borking things for you | 15:08 |
| amodi | lyarwood: yeah so i inherit from manager.Encryption and whitebox base (prioritized), i thought the cleanup/teardown is being executed from a different class than the create volume one | 15:09 |
| amodi | lyarwood: yes, maybe :/ should i try to init all of the clients used in the test with setup_clients()? | 15:10 |
| amodi | with os_admin creds | 15:10 |
| amodi | the test creates 2 users and projects at the start of this test so i'd want it to create just one | 15:10 |
| lyarwood | amodi: yeah I assume both classes have the same eventual parent that's doing the user tenant creation? | 15:11 |
| amodi | lyarwood: yeah i think so too, so i;ll try to init all clients with admin creds | 15:12 |
| lyarwood | amodi: you could just drop the manager class and copy logic over into whitebox | 15:13 |
| lyarwood | amodi: you would only need limited stuff to create the encrypted volume type and volume | 15:13 |
| amodi | lyarwood: um, okay yes i have done that i'd need 2 methods | 15:13 |
| amodi | okay let me try that then | 15:13 |
| paras333 | gmann: masayukig: nv for low-constraint job https://review.opendev.org/c/openstack/hacking/+/772556 | 15:21 |
| paras333 | can you all review it:) | 15:21 |
| *** yamamoto has joined #openstack-qa | 15:33 | |
| *** jamespage_ is now known as jamespage | 15:33 | |
| erbarr | hello, so I'm running devstack in hardware, reconfigured neutron with ovs bridges i made and passed vlans as flat networks, the instances inside that cloud have access to the networks outside of the cloud, I then try to make an ovs bridge inside an instance through netplan and attach an interface to it but that bridge doesn't work. it gets made but doesn't get an ip address from the cloud dhcp. Have you guys seen | 15:37 |
| erbarr | something like this or have any ideas of what could be happening? | 15:37 |
| openstackgerrit | Artom Lifshitz proposed openstack/whitebox-tempest-plugin master: WIP: Different approach to TripleO job https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/762866 | 15:42 |
| slaweq | erbarr: if You have bridge inside the instance then You need to either disable port_security for the port of that vm or add bridge's mac/ip addresses to the allowed_address_pair in port | 15:46 |
| slaweq | erbarr: https://docs.openstack.org/api-ref/network/v2/index.html#allowed-address-pairs | 15:47 |
| erbarr | cool thanks, i'll take a look at that. What about if i disable port security in the networks? that should work, right? | 15:49 |
| mtreinish | gmann: ah, thanks. Yeah, I started with it as an upgrade note, but switched to a prelude and forgot to update the whitespace syntax after changing it | 15:51 |
| gmann | mtreinish: ohk, let me know once you release the tag. I can push changes on making it python3-only and latest hacking | 15:52 |
| *** yamamoto has quit IRC | 15:56 | |
| artom | amodi, lyarwood, sorry, was on a call with migi, did you figure out whatever there was to figure out? | 16:03 |
| *** ysirndjuro has joined #openstack-qa | 16:05 | |
| amodi | artom: yeah' | 16:08 |
| openstackgerrit | Merged openstack/tempest master: Add default RBAC personas to dynamic credentials https://review.opendev.org/c/openstack/tempest/+/686306 | 16:16 |
| openstackgerrit | Merged openstack/tempest master: Add default RBAC personas to pre-provisioned creds https://review.opendev.org/c/openstack/tempest/+/698397 | 16:17 |
| openstackgerrit | Merged openstack/tempest master: Add release note for new role client methods https://review.opendev.org/c/openstack/tempest/+/762940 | 16:18 |
| *** ccamposr has joined #openstack-qa | 16:18 | |
| *** ccamposr__ has quit IRC | 16:20 | |
| openstackgerrit | Ghanshyam proposed openstack/devstack stable/train: DNM: testing https://review.opendev.org/c/openstack/devstack/+/772569 | 16:25 |
| *** artom has quit IRC | 16:28 | |
| *** artom has joined #openstack-qa | 16:29 | |
| paras333 | gmann: It didn't count this lower-constraints job as Non voting at the time submitted gate job https://review.opendev.org/c/openstack/hacking/+/772556 | 16:36 |
| paras333 | should I remove it from the template?? .zuul.conf | 16:36 |
| *** ccamposr__ has joined #openstack-qa | 16:37 | |
| gmann | paras333: oh, yeah and add todo to add the template if we fix and keep l-c job | 16:37 |
| paras333 | sure | 16:37 |
| *** ccamposr has quit IRC | 16:39 | |
| openstackgerrit | Martin Kopec proposed openstack/tempest master: DNM: testing hypersivor with system scope https://review.opendev.org/c/openstack/tempest/+/770197 | 16:42 |
| *** zenkuro has quit IRC | 16:43 | |
| openstackgerrit | Paras Babbar proposed openstack/hacking master: Updating lower-constarints job as non voting https://review.opendev.org/c/openstack/hacking/+/772556 | 16:49 |
| *** lpiwowar has quit IRC | 16:50 | |
| paras333 | gmann: I think this should be working https://review.opendev.org/c/openstack/hacking/+/772556 | 16:50 |
| paras333 | without removing it from template | 16:50 |
| openstackgerrit | Radosław Piliszek proposed openstack/devstack stable/rocky: Use a dedicated version of get-pip.py for python 2.7 https://review.opendev.org/c/openstack/devstack/+/772487 | 16:51 |
| gmann | paras333: we need to remove the template, commentd in gerrit | 16:51 |
| paras333 | gmann: Umm ok , let me do that | 16:52 |
| openstackgerrit | Radosław Piliszek proposed openstack/devstack stable/queens: Use a dedicated version of get-pip.py for python 2.7 https://review.opendev.org/c/openstack/devstack/+/772488 | 16:53 |
| yoctozepto | elod, gmann: had to fix py35 branches to invalidate the CI cache | 16:54 |
| yoctozepto | otherwise gtg | 16:54 |
| openstackgerrit | Paras Babbar proposed openstack/hacking master: Updating lower-constarints job as non voting https://review.opendev.org/c/openstack/hacking/+/772556 | 16:55 |
| yoctozepto | I am also fine with merging in ussuri - it certainly will not hurt | 16:55 |
| paras333 | gmann: https://review.opendev.org/c/openstack/hacking/+/772556 done | 16:55 |
| amodi | lyarwood: there was progress in deleting the volume, but the security group traceback remains, now i think it's the only error http://paste.openstack.org/show/802005/ | 16:57 |
| amodi | can this be related to prepare_instance_network() ? | 16:58 |
| *** zenkuro has joined #openstack-qa | 16:58 | |
| lyarwood | amodi: you need to ensure the instance and any associated ports are cleaned up before the security group | 17:00 |
| amodi | lyarwood: okay so override cleanup/teardown or delete the instnace/ports within the test itself | 17:01 |
| *** lucasagomes has quit IRC | 17:02 | |
| lyarwood | amodi: are you creating resources directly in your test now? | 17:04 |
| lyarwood | amodi: you just need to order the cleanups, iirc they are FILO | 17:05 |
| *** rh-jelabarre has quit IRC | 17:06 | |
| lyarwood | amodi: LIFO* | 17:06 |
| amodi | lyarwood: yeah creating as i need to ssh into the instance | 17:07 |
| *** gfidente is now known as gfidente|afk | 17:22 | |
| *** rh-jelabarre has joined #openstack-qa | 17:22 | |
| *** rh-jelabarre has quit IRC | 17:23 | |
| *** rh-jelabarre has joined #openstack-qa | 17:23 | |
| *** rpittau is now known as rpittau|afk | 17:27 | |
| *** zenkuro has quit IRC | 17:52 | |
| *** yamamoto has joined #openstack-qa | 17:56 | |
| *** jpena is now known as jpena|off | 17:57 | |
| openstackgerrit | Artom Lifshitz proposed openstack/whitebox-tempest-plugin master: WIP: Different approach to TripleO job https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/762866 | 17:58 |
| openstackgerrit | Dan Smith proposed openstack/devstack master: WIP: Async task support https://review.opendev.org/c/openstack/devstack/+/771505 | 18:03 |
| *** yamamoto has quit IRC | 18:23 | |
| *** ianw_pto is now known as ianw | 18:59 | |
| *** ccamposr has joined #openstack-qa | 19:28 | |
| *** ccamposr__ has quit IRC | 19:32 | |
| *** hamalq has joined #openstack-qa | 19:36 | |
| openstackgerrit | Merged openstack/hacking master: Updating lower-constarints job as non voting https://review.opendev.org/c/openstack/hacking/+/772556 | 19:46 |
| *** simondodsley has quit IRC | 20:14 | |
| *** simondodsley has joined #openstack-qa | 20:16 | |
| *** yamamoto has joined #openstack-qa | 20:22 | |
| openstackgerrit | Merged openstack/hacking master: Add H216 to flag use of third party mock https://review.opendev.org/c/openstack/hacking/+/742475 | 20:37 |
| gmann | amotoki: elod yoctozepto i thought we removed but devstack stable/train still support xenial and it fail on get_pip.py fix - https://review.opendev.org/c/openstack/devstack/+/772462 | 20:39 |
| gmann | as we support xenial we can fix it for py3.5 also but as separate, I am +W on 772462 as this will unblock almost all the gate jobs on train | 20:40 |
| *** ralonsoh has quit IRC | 20:42 | |
| *** brinzhang_ has joined #openstack-qa | 20:44 | |
| gmann | xenial is supported version in stable/train https://github.com/openstack/devstack/blob/stable/train/stack.sh#L227 | 20:46 |
| *** brinzhang has quit IRC | 20:47 | |
| *** yamamoto has quit IRC | 20:53 | |
| amotoki | gmann: ah... get-pip.py now supports python>=3.6, so we need a same workaround as for python 2.7. | 20:54 |
| gmann | amotoki: yeah | 20:54 |
| amotoki | gmann: which brancehs are affected? only train or more? | 20:54 |
| gmann | amotoki: <=stable/train as they support xenial | 20:55 |
| amotoki | gmann: what in my mind is like http://paste.openstack.org/show/802025/ (on top of 772462 for stable/train). thought? | 20:55 |
| *** dtantsur is now known as dtantsur|afk | 20:55 | |
| gmann | amotoki: yeah doing that way on top of 772462 | 20:56 |
| amotoki | gmann: does stein need python3.5 support on xenial? if so, it looks better to update the current fixes for stein and train. | 20:57 |
| gmann | amotoki: yes stein too | 20:58 |
| gmann | amotoki: we can do in same also, I am with both. | 20:58 |
| gmann | rocky and lower are already taken care | 20:58 |
| amotoki | gmann: what do you mean for rocky and lower? do you mean they only requires py27? | 20:59 |
| gmann | amotoki: they require py3.5 and fix fetching it from py3.5 only https://review.opendev.org/c/openstack/devstack/+/772487/4/tools/install_pip.sh#40 | 21:00 |
| gmann | i mean there is only py3.5 version of python3 there | 21:00 |
| *** nweinber has quit IRC | 21:02 | |
| amotoki | gmann: got it. we already use a special get-pip.py for py35 in stable/rocky fix https://review.opendev.org/c/openstack/devstack/+/772487 I didn't notice it so far. | 21:04 |
| openstackgerrit | Ghanshyam proposed openstack/devstack stable/train: Fix get-pip for python 3.5 https://review.opendev.org/c/openstack/devstack/+/772601 | 21:06 |
| gmann | amotoki: ^^ | 21:07 |
| openstackgerrit | Ghanshyam proposed openstack/devstack stable/train: Fix get-pip for python 3.5 https://review.opendev.org/c/openstack/devstack/+/772601 | 21:07 |
| amotoki | gmann: is it better to update the proposed fixes now or do it later? a stein fix (recheck) is in the check queue and no jobs have started. | 21:07 |
| gmann | amotoki: separate is ok as existing one which fix gate for py2.7 have +A | 21:08 |
| amotoki | gmann: okay. | 21:08 |
| openstackgerrit | Ghanshyam proposed openstack/devstack stable/train: Fix get-pip for python 3.5 https://review.opendev.org/c/openstack/devstack/+/772601 | 21:13 |
| *** hamalq has quit IRC | 21:21 | |
| *** hamalq has joined #openstack-qa | 21:21 | |
| *** ajitha has quit IRC | 21:23 | |
| *** nweinber has joined #openstack-qa | 21:34 | |
| *** paras333 is now known as paras|done_for_t | 21:42 | |
| *** paras|done_for_t is now known as paras|time_to_le | 21:42 | |
| *** raildo has quit IRC | 21:47 | |
| *** nweinber has quit IRC | 22:02 | |
| *** nweinber has joined #openstack-qa | 22:05 | |
| *** gcheresh has quit IRC | 22:07 | |
| *** sboyron has quit IRC | 22:08 | |
| *** slaweq has quit IRC | 22:08 | |
| *** nweinber has quit IRC | 22:10 | |
| *** rcernin has joined #openstack-qa | 22:16 | |
| *** yamamoto has joined #openstack-qa | 22:19 | |
| *** rcernin has quit IRC | 22:24 | |
| *** rcernin has joined #openstack-qa | 22:24 | |
| *** tbachman_ has joined #openstack-qa | 22:56 | |
| *** tbachman has quit IRC | 22:58 | |
| *** tbachman_ is now known as tbachman | 22:58 | |
| *** early has quit IRC | 22:59 | |
| *** early has joined #openstack-qa | 23:16 | |
| *** tosky has quit IRC | 23:18 | |
| *** tbachman_ has joined #openstack-qa | 23:26 | |
| *** tbachman has quit IRC | 23:27 | |
| *** tbachman_ is now known as tbachman | 23:27 | |
| openstackgerrit | Artom Lifshitz proposed openstack/whitebox-tempest-plugin master: Unskip test_rx_tx_queue_size https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/767218 | 23:46 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!