| *** tosky has quit IRC | 00:11 | |
| *** adriant7 has joined #openstack-qa | 01:23 | |
| *** adriant has quit IRC | 01:25 | |
| *** adriant7 is now known as adriant | 01:25 | |
| *** brinzhang_ has joined #openstack-qa | 01:32 | |
| *** brinzhang has quit IRC | 01:35 | |
| openstackgerrit | Akihiro Motoki proposed openstack/devstack master: Allow to install os-ken from git repo https://review.opendev.org/c/openstack/devstack/+/778599 | 01:36 |
|---|---|---|
| *** rcernin has joined #openstack-qa | 01:53 | |
| *** rh-jelabarre has quit IRC | 02:13 | |
| *** Yarboa has quit IRC | 02:20 | |
| *** Yarboa has joined #openstack-qa | 02:21 | |
| *** hemanth_n has joined #openstack-qa | 02:51 | |
| *** hemanth_n has quit IRC | 02:53 | |
| *** hemanth_n has joined #openstack-qa | 02:54 | |
| *** rcernin has quit IRC | 03:06 | |
| *** rcernin has joined #openstack-qa | 03:24 | |
| *** rcernin has quit IRC | 03:26 | |
| *** rcernin has joined #openstack-qa | 03:27 | |
| *** vishalmanchanda has joined #openstack-qa | 03:34 | |
| *** whoami-rajat has joined #openstack-qa | 04:20 | |
| openstackgerrit | Merged openstack/tempest master: Add alt project persona in dynamic credential https://review.opendev.org/c/openstack/tempest/+/773177 | 04:51 |
| *** yoctozepto has quit IRC | 06:00 | |
| *** yoctozepto has joined #openstack-qa | 06:01 | |
| *** rcernin has quit IRC | 07:00 | |
| *** ccamposr has joined #openstack-qa | 07:13 | |
| *** rcernin has joined #openstack-qa | 07:14 | |
| *** ajitha has joined #openstack-qa | 07:15 | |
| *** slaweq has joined #openstack-qa | 07:17 | |
| *** sboyron has joined #openstack-qa | 07:29 | |
| *** rcernin has quit IRC | 07:30 | |
| *** ralonsoh has joined #openstack-qa | 07:37 | |
| *** hamalq has joined #openstack-qa | 07:45 | |
| *** eolivare has joined #openstack-qa | 07:46 | |
| *** jpena|off is now known as jpena | 07:52 | |
| *** rcernin has joined #openstack-qa | 07:55 | |
| *** rcernin has quit IRC | 08:00 | |
| *** rpittau|afk is now known as rpittau | 08:08 | |
| *** rcernin has joined #openstack-qa | 08:12 | |
| *** rcernin has quit IRC | 08:17 | |
| *** flaviof_ has joined #openstack-qa | 08:29 | |
| *** TheJulia_ has joined #openstack-qa | 08:29 | |
| *** johnsom_ has joined #openstack-qa | 08:30 | |
| *** mnasiadka_ has joined #openstack-qa | 08:33 | |
| *** rpittau_ has joined #openstack-qa | 08:33 | |
| *** jrollen has joined #openstack-qa | 08:34 | |
| *** tosky has joined #openstack-qa | 08:36 | |
| *** mnasiadka has quit IRC | 08:43 | |
| *** rpittau has quit IRC | 08:43 | |
| *** johnsom has quit IRC | 08:43 | |
| *** TheJulia has quit IRC | 08:43 | |
| *** flaviof has quit IRC | 08:43 | |
| *** jroll has quit IRC | 08:43 | |
| *** mnasiadka_ is now known as mnasiadka | 08:43 | |
| *** TheJulia_ is now known as TheJulia | 08:43 | |
| *** flaviof_ is now known as flaviof | 08:43 | |
| *** johnsom_ is now known as johnsom | 08:43 | |
| *** rpittau_ is now known as rpittau | 08:43 | |
| *** hamalq has quit IRC | 08:47 | |
| *** lucasagomes has joined #openstack-qa | 09:09 | |
| *** rcernin has joined #openstack-qa | 09:13 | |
| *** rcernin has quit IRC | 09:17 | |
| soniya29|ruck | kopecmartin, masayukig , Can a test be considered as feature? | 09:38 |
| soniya29|ruck | kopecmartin, masayukig, Like adding a test is equivalent to adding a feature? | 09:40 |
| kopecmartin | soniya29|ruck: I don't know ,why? .. maybe you can find an answer here https://docs.openstack.org/tempest/latest/write_tests.html | 09:56 |
| *** paras333 has joined #openstack-qa | 09:57 | |
| soniya29|ruck | kopecmartin, So while reviewing a patch I observed a test is mentioned in the feature section of release notes. How can a test be a feature? A feature is already added and testcase just test the feature | 10:00 |
| soniya29|ruck | kopecmartin, So in such case i dont think we require a reno or even if we require then it won't go in feature section of releasenotes, right? | 10:02 |
| soniya29|ruck | kopecmartin, here:- https://review.opendev.org/c/openstack/tempest/+/665155 | 10:02 |
| kopecmartin | well, i can image a test being a feature .. a feature is something new in the code, something related to the purpose of the code - tempest is a test framework so by this logic a test can be a feature in the context of tempest :D .. anyway, i understand your question, I need to check similar commits and see how it was handled in the past | 10:03 |
| masayukig | kopecmartin: soniya29|ruck yeah, I think a test case is a feature from tempest perspective. | 10:04 |
| kopecmartin | interesting, i quickly checked couple of commits adding new scenario tests and none of them had a reno | 10:10 |
| kopecmartin | https://opendev.org/openstack/tempest/commit/61f68ac39497e1d8622bab8465563c9f06372a70 | 10:10 |
| kopecmartin | https://opendev.org/openstack/tempest/commit/d101764a31d107983d4899e4436942193352f0dd | 10:10 |
| soniya29|ruck | masayukig, kopecmartin, I think the docs should clearly specify this so that in future its clear that a test case will require reno | 10:10 |
| soniya29|ruck | kopecmartin, that is why i was confused | 10:11 |
| kopecmartin | I always take it logically if to a reno is a must or not .. f.e. if a commit changes something very visible as an arg name, or test name I'd say a reno is a must so that the change is as transparent as possible | 10:12 |
| kopecmartin | the same for deprecations | 10:12 |
| kopecmartin | and removals | 10:12 |
| kopecmartin | in case of adding new things a reno is nice, so that we're transparent, but I wouldn't hold on a +A vote for the patch for that | 10:14 |
| soniya29|ruck | kopecmartin, yeah | 10:19 |
| soniya29|ruck | kopecmartin, I think one rule should go with all, if we mean test case being a feature needs a reno then it should hold for all the future test cases | 10:21 |
| soniya29|ruck | in past the changes have already got merged but in future at least we can take care of this | 10:22 |
| *** artom has quit IRC | 10:39 | |
| *** rcernin has joined #openstack-qa | 11:08 | |
| *** rcernin has quit IRC | 11:13 | |
| *** artom has joined #openstack-qa | 11:37 | |
| *** tkajinam has quit IRC | 11:56 | |
| *** paras333 has quit IRC | 12:12 | |
| *** paras333_ has joined #openstack-qa | 12:13 | |
| *** rcernin has joined #openstack-qa | 12:24 | |
| *** rcernin has quit IRC | 12:29 | |
| *** jpena is now known as jpena|lunch | 12:32 | |
| *** chaconpiza has joined #openstack-qa | 12:32 | |
| *** rcernin has joined #openstack-qa | 12:48 | |
| *** rcernin has quit IRC | 12:53 | |
| *** nweinber has joined #openstack-qa | 13:07 | |
| soniya29|ruck | gmann, kopecmartin, I have updated the patch:- https://review.opendev.org/c/openstack/tempest/+/776932, please have a look whenever you have time | 13:12 |
| lbragstad | gmann qq - i'm seeing this in the glance protection tests https://zuul.opendev.org/t/openstack/build/33ab00a6a7924c45b9054973a7d7bd5b | 13:26 |
| lbragstad | and it looks like https://review.opendev.org/c/openstack/tempest/+/773177 landed yesterday | 13:26 |
| lbragstad | those failures don't look transient | 13:26 |
| openstackgerrit | Soniya Murlidhar Vyas proposed openstack/tempest master: Make _create_empty_security_group() non-private https://review.opendev.org/c/openstack/tempest/+/778697 | 13:32 |
| *** rh-jelabarre has joined #openstack-qa | 13:33 | |
| *** jpena|lunch is now known as jpena | 13:33 | |
| openstackgerrit | Soniya Murlidhar Vyas proposed openstack/tempest master: Make _get_router() non-private https://review.opendev.org/c/openstack/tempest/+/778698 | 13:42 |
| *** paras333_ has quit IRC | 13:55 | |
| *** hemanth_n has quit IRC | 13:55 | |
| soniya29|ruck | kopecmartin, didn't get the nova network stuff mentioned in the https://etherpad.opendev.org/p/tempest-scenario-manager - line 358 | 14:03 |
| *** amodi has quit IRC | 14:04 | |
| *** amodi has joined #openstack-qa | 14:06 | |
| amodi | lyarwood: artom https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/778215 can we get this merged today? | 14:07 |
| gmann | soniya29|ruck: will check | 14:14 |
| gmann | lbragstad: ack, let me debug that | 14:15 |
| soniya29|ruck | gmann, ack | 14:15 |
| tosky | fyi the cinder-tempest-plugin patch has merged, no more dependency on the current tempest scenario manager | 14:18 |
| artom | amodi, just a quick question inline | 14:21 |
| amodi | artom: sure | 14:21 |
| dansmith | gmann: does it make sense to teach devstack how to collect /etc/glance-remote config for the log dump? I have it in my job as zuul_copy_output, but if it's better to put it in devstack, I can (figure out how) | 14:28 |
| dansmith | or is it even in devstack? maybe thats in ansible? | 14:28 |
| gmann | dansmith: yeah in devstack ansible playbook, let me check if it cover only default enable services or other too | 14:29 |
| dansmith | gmann: I added zuul_copy_output: /etc/glance-remote: logs, but that doesn't put it inside the etc/ directory in the log dump, but maybe it will if I use logs/etc | 14:29 |
| openstackgerrit | Archit Modi proposed openstack/whitebox-tempest-plugin master: Add skip check to volume encryption tests https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/778215 | 14:36 |
| lbragstad | gmann ok - so if the gtp tests are failing because we're using credentials = ['project_admin'...] - then i might need to check the keystone-protection-functional job | 14:37 |
| lbragstad | because that uses the same dynamic cred strategy | 14:37 |
| gmann | dansmith: yeah, its showing at top level now https://zuul.opendev.org/t/openstack/build/0e52681ba34c42208dd086cc37f02157/logs | 14:38 |
| gmann | https://zuul.opendev.org/t/openstack/build/0e52681ba34c42208dd086cc37f02157/console#6/0/35/controller | 14:39 |
| dansmith | gmann: yeah, is it best to just make my logs rule be logs/etc in my job def? | 14:39 |
| gmann | dansmith: in log/etc yes but let me check if we can do in devstack side or on job side | 14:39 |
| dansmith | okay | 14:40 |
| gmann | lbragstad: i think this is first time any test using system_admin or domain_admin ? did you use in keystoen tempest plugin ? | 14:40 |
| *** rcernin has joined #openstack-qa | 14:49 | |
| *** rcernin has quit IRC | 14:54 | |
| lbragstad | gmann yes - and we made it voting yesterday | 14:54 |
| lbragstad | so - i think, based on what i know right now, that means keystone's gate is probably broken | 14:54 |
| lbragstad | but i can test that | 14:54 |
| gmann | lbragstad: i think no need to test, from code itself we can see system_admin or domain_admin also try to assign project admin | 14:55 |
| gmann | I pointed that in original patch but did not realize this. let me fix that | 14:56 |
| lbragstad | https://review.opendev.org/c/openstack/keystone/+/778719 | 14:56 |
| openstackgerrit | Sampat Ponnaganti proposed openstack/patrole master: [2008683] Cleans up volume after test https://review.opendev.org/c/openstack/patrole/+/778573 | 14:56 |
| lbragstad | so - ^ that should fail because 1.) the policy regresses 2.) the secure-rbac protection gate running the keystone-tempest-plugin tests won't be able to setup credentials using tempest dynamic credentials | 14:57 |
| gmann | k | 14:57 |
| lbragstad | https://github.com/openstack/keystone/blob/master/.zuul.yaml#L240 | 14:57 |
| openstackgerrit | Sampat Ponnaganti proposed openstack/patrole master: [2008683] Cleans up volume after test https://review.opendev.org/c/openstack/patrole/+/778573 | 14:58 |
| gmann | lbragstad: and those use system/domain_admin ? | 14:59 |
| lbragstad | yes | 14:59 |
| lbragstad | but - the glance tests only use project | 14:59 |
| lbragstad | and it fails there, too | 14:59 |
| gmann | ok in that case it should be broken since stating? | 14:59 |
| lbragstad | well - my suspicion is that it broke with https://review.opendev.org/c/openstack/tempest/+/773177 | 15:01 |
| gmann | lbragstad: i think i un hide the bug with this https://review.opendev.org/c/openstack/tempest/+/773177/8/tempest/lib/common/dynamic_creds.py#382 | 15:02 |
| gmann | lbragstad: previously I think system admin was not assigned as admin? | 15:03 |
| gmann | need to debug it with keystone tempest plugin log i think, will do after TC meeting | 15:03 |
| lbragstad | ok | 15:04 |
| gmann | I think keystone tempest plugins tests are good one to test all these things | 15:04 |
| gmann | dansmith: hold on logs/etc change, need to check how you are setting up in devstack | 15:12 |
| gmann | will check after meeting | 15:12 |
| dansmith | gmann: rgr, thanks | 15:13 |
| openstackgerrit | Ghanshyam proposed openstack/tempest master: DNM: testing https://review.opendev.org/c/openstack/tempest/+/777839 | 15:37 |
| gmann | lbragstad: ^^ testing all those persona in my existing testing patch too | 15:38 |
| *** dmellado has quit IRC | 15:45 | |
| *** dmellado has joined #openstack-qa | 15:46 | |
| *** vishalmanchanda has quit IRC | 16:17 | |
| kopecmartin | soniya29|ruck: sorry, gmann wrote that spec - L358 at https://etherpad.opendev.org/p/tempest-scenario-manager | 16:18 |
| kopecmartin | gmann: I updated a very old (mostly) masayukig's doc patch: https://review.opendev.org/c/openstack/tempest/+/527577 | 16:18 |
| *** afazekas has joined #openstack-qa | 16:26 | |
| gmann | kopecmartin: +A thanks | 16:41 |
| gmann | dansmith: is not this should collect /etc/glance-remote/ too to logs/etc https://github.com/openstack/devstack/blob/556f84aea90c572873fc9834292635b41e590224/.zuul.yaml#L326 | 16:44 |
| dansmith | gmann: it wasn't getting glance-remote, so I added that special collection rule on my job | 16:44 |
| gmann | stage-output role should copy the entire /home/zuul/etc to logs | 16:44 |
| dansmith | gmann: well, it wasn't hence abhishekk's original ask in the review | 16:45 |
| gmann | yeah, i could not find the reason from logs | 16:45 |
| dansmith | gmann: okay, let me just change mine to logs/etc and see if that fixes it.. let's not waste time on it.. I'd rather get the tempest/devstack patches in so we can get testing on this | 16:45 |
| abhishekk | ++ | 16:46 |
| gmann | dansmith: ok that should work for now. and I will check later why stage-output role does not pick glance-remote | 16:46 |
| dansmith | gmann: cool, thanks | 16:47 |
| openstackgerrit | Sampat Ponnaganti proposed openstack/patrole master: [2008683] Cleans up volume after test https://review.opendev.org/c/openstack/patrole/+/778573 | 16:47 |
| dansmith | gmann: so can you be +2 on the devstack patch soonish? :D | 16:49 |
| dansmith | gmann: also I had a concern about region in tempest, and did not add it.. not sure if you saw that, but I don't think we can allow the main/alternate image endpoints to be in separate regions for this feature, as it doesn't make sense | 16:49 |
| *** rcernin has joined #openstack-qa | 16:50 | |
| *** rcernin has quit IRC | 16:55 | |
| *** jpena is now known as jpena|off | 17:02 | |
| *** lucasagomes has quit IRC | 17:05 | |
| lbragstad | gmann ok - i think the problem is that this was the path we were always taking when credentials = ['system_admin'] | 17:06 |
| openstackgerrit | Archit Modi proposed openstack/whitebox-tempest-plugin master: Change order of inheritance in TestQEMUVolumeEncrption class https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/778752 | 17:06 |
| lbragstad | https://github.com/openstack/tempest/blob/master/tempest/lib/common/dynamic_creds.py#L391-L393 | 17:07 |
| lbragstad | that case never called _create_creds with a scope parameter | 17:07 |
| lbragstad | self._create_creds(admin=is_admin) | 17:07 |
| lbragstad | but - now that we're bumping that up to this - https://github.com/openstack/tempest/blob/master/tempest/lib/common/dynamic_creds.py#L382-L384 | 17:07 |
| lbragstad | we're calling _create_creds with scope='system' | 17:08 |
| lbragstad | and that skips the project creation bits before it trips on https://github.com/openstack/tempest/blob/master/tempest/lib/common/dynamic_creds.py#L232 | 17:08 |
| lbragstad | so - do we add another conditional at 232 to only do that if scope = 'project' or? what do you think the appropriate action is in this case? | 17:09 |
| openstackgerrit | Lance Bragstad proposed openstack/tempest master: Update dynamic creds to properly handle types during creation https://review.opendev.org/c/openstack/tempest/+/778753 | 17:14 |
| lbragstad | ^ that fixes things for me locally, but i'm not sure if that's the approach you want | 17:14 |
| openstackgerrit | Archit Modi proposed openstack/whitebox-tempest-plugin master: WIP: Change order of inheritance in TestQEMUVolumeEncryption class https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/778752 | 17:16 |
| *** Yarboa has quit IRC | 17:21 | |
| *** Yarboa has joined #openstack-qa | 17:22 | |
| *** rpittau is now known as rpittau|afk | 17:27 | |
| *** slaweq has quit IRC | 17:49 | |
| *** slaweq has joined #openstack-qa | 17:51 | |
| *** paras333_ has joined #openstack-qa | 17:58 | |
| *** eolivare has quit IRC | 17:59 | |
| *** paras333_ has quit IRC | 18:03 | |
| *** ccamposr has quit IRC | 18:03 | |
| *** ralonsoh has quit IRC | 18:09 | |
| *** Yarboa has quit IRC | 18:20 | |
| *** iurygregory has quit IRC | 18:22 | |
| *** iurygregory has joined #openstack-qa | 18:22 | |
| *** Yarboa has joined #openstack-qa | 18:32 | |
| *** slaweq has quit IRC | 18:34 | |
| *** rcernin has joined #openstack-qa | 18:50 | |
| openstackgerrit | Merged openstack/whitebox-tempest-plugin master: Add skip check to volume encryption tests https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/778215 | 18:51 |
| *** rcernin has quit IRC | 18:56 | |
| *** mgagne has quit IRC | 18:56 | |
| *** mgagne has joined #openstack-qa | 18:57 | |
| openstackgerrit | Archit Modi proposed openstack/whitebox-tempest-plugin master: Change order of inheritance in TestQEMUVolumeEncryption class https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/778752 | 18:59 |
| *** whoami-rajat has quit IRC | 18:59 | |
| kopecmartin | gmann: https://review.opendev.org/c/openstack/tempest/+/778342 failed again, but before rechecking I wrote a comment there | 19:00 |
| kopecmartin | gmann: btw, there seems to be an issue with the previously merged patch https://review.opendev.org/c/openstack/tempest/+/773177/8 | 19:00 |
| *** rcernin has joined #openstack-qa | 19:12 | |
| *** rcernin has quit IRC | 19:17 | |
| dansmith | kopecmartin: would love to have your +2 on this, as the feature is merged and we want to be able to test it: https://review.opendev.org/c/openstack/tempest/+/770520 | 19:19 |
| dansmith | (you were previously almost-okay with it) | 19:19 |
| * kopecmartin is looking | 19:20 | |
| *** Yarboa has quit IRC | 19:20 | |
| *** Yarboa has joined #openstack-qa | 19:22 | |
| dansmith | kopecmartin: several recent test runs on this patch to enable it: https://review.opendev.org/c/openstack/glance/+/770629 | 19:22 |
| dansmith | the latest rev is just to tweak job log collection | 19:22 |
| *** hamalq has joined #openstack-qa | 19:41 | |
| *** gcheresh has quit IRC | 19:43 | |
| *** rcernin has joined #openstack-qa | 20:00 | |
| kopecmartin | dansmith: +2 , I'm sorry for the delay | 20:03 |
| dansmith | kopecmartin: no worries, thanks very much! | 20:04 |
| *** slaweq has joined #openstack-qa | 20:29 | |
| *** nweinber has quit IRC | 20:32 | |
| *** rcernin has quit IRC | 20:43 | |
| *** openstackgerrit has quit IRC | 21:05 | |
| *** rcernin has joined #openstack-qa | 21:09 | |
| *** rcernin has quit IRC | 21:49 | |
| *** ccamposr has joined #openstack-qa | 21:57 | |
| *** sboyron has quit IRC | 22:01 | |
| *** ajitha has quit IRC | 22:24 | |
| *** slaweq has quit IRC | 22:27 | |
| *** rcernin has joined #openstack-qa | 22:29 | |
| *** rcernin has quit IRC | 22:54 | |
| *** rcernin has joined #openstack-qa | 22:54 | |
| *** tkajinam has joined #openstack-qa | 22:57 | |
| *** ccamposr has quit IRC | 23:14 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!