| openstackgerrit | Ghanshyam proposed openstack/tempest master: Add 2 sec wait to check the import task status https://review.opendev.org/c/openstack/tempest/+/788856 | 00:49 |
|---|---|---|
| gmann | dansmith: I saw this race happening multiple times today in image import tests - https://review.opendev.org/c/openstack/tempest/+/788856 | 00:50 |
| *** rh-jelabarre has quit IRC | 01:05 | |
| *** hamalq has quit IRC | 01:30 | |
| openstackgerrit | Merged openstack/devstack master: Fix async race updating nova configs https://review.opendev.org/c/openstack/devstack/+/788820 | 02:24 |
| *** jparoly has quit IRC | 02:26 | |
| openstackgerrit | Hitesh Kumar proposed openstack/devstack-tools master: Migrate from testr to stestr https://review.opendev.org/c/openstack/devstack-tools/+/788735 | 02:46 |
| *** rcernin has quit IRC | 03:03 | |
| *** rcernin has joined #openstack-qa | 03:34 | |
| *** rcernin has quit IRC | 03:38 | |
| *** redrobot6 has joined #openstack-qa | 03:52 | |
| *** redrobot has quit IRC | 03:55 | |
| *** redrobot6 is now known as redrobot | 03:55 | |
| *** rcernin has joined #openstack-qa | 04:08 | |
| *** ajitha has joined #openstack-qa | 04:50 | |
| *** Yarboa has quit IRC | 05:03 | |
| *** Yarboa has joined #openstack-qa | 05:06 | |
| *** ysandeep|away is now known as ysandeep | 05:30 | |
| *** ralonsoh has joined #openstack-qa | 05:37 | |
| *** gcheresh_ has joined #openstack-qa | 05:53 | |
| *** slaweq has joined #openstack-qa | 06:00 | |
| *** gcheresh_ has quit IRC | 06:03 | |
| *** Yarboa has quit IRC | 06:04 | |
| *** Yarboa has joined #openstack-qa | 06:06 | |
| *** gcheresh_ has joined #openstack-qa | 06:12 | |
| openstackgerrit | Dr. Jens Harbott proposed openstack/devstack master: Keystone httpd stop listening on ports https://review.opendev.org/c/openstack/devstack/+/312230 | 06:20 |
| *** Yarboa has quit IRC | 07:04 | |
| *** Yarboa has joined #openstack-qa | 07:04 | |
| *** sboyron has joined #openstack-qa | 07:04 | |
| *** eolivare has joined #openstack-qa | 07:09 | |
| *** ricolin has quit IRC | 07:18 | |
| *** rpittau|afk is now known as rpittau | 07:24 | |
| *** jpena has joined #openstack-qa | 07:35 | |
| *** rcernin has quit IRC | 07:56 | |
| *** gcheresh_ has quit IRC | 08:03 | |
| *** Yarboa has quit IRC | 08:04 | |
| *** Yarboa has joined #openstack-qa | 08:06 | |
| *** lucasagomes has joined #openstack-qa | 08:12 | |
| *** tosky has joined #openstack-qa | 08:21 | |
| *** elod is now known as elod_afk | 08:47 | |
| *** gfidente|off is now known as gfidente | 08:53 | |
| *** sboyron has quit IRC | 09:37 | |
| *** dtantsur|afk is now known as dtantsur | 10:01 | |
| *** sboyron has joined #openstack-qa | 10:14 | |
| *** brinzhang has quit IRC | 10:21 | |
| *** bulvia has joined #openstack-qa | 10:25 | |
| *** gcheresh_ has joined #openstack-qa | 10:27 | |
| *** dasp has quit IRC | 10:31 | |
| frickler | yoctozepto: could you have a look at https://review.opendev.org/c/openstack/devstack/+/312230 again, pls? I intend to rebase the keystone-admin-endpoint stack on top of it so it won't conflict | 10:35 |
| *** dtantsur is now known as dtantsur|brb | 11:05 | |
| *** dviroel is now known as dviroel|away | 11:20 | |
| *** bulvia has quit IRC | 11:22 | |
| *** bulvia has joined #openstack-qa | 11:28 | |
| *** jpena is now known as jpena|lunch | 11:30 | |
| *** dasp has joined #openstack-qa | 11:57 | |
| *** rh-jelabarre has joined #openstack-qa | 12:04 | |
| *** dtantsur|brb is now known as dtantsur | 12:28 | |
| *** nweinber has joined #openstack-qa | 12:33 | |
| *** jpena|lunch is now known as jpena | 12:34 | |
| *** eliadcohen has quit IRC | 12:42 | |
| *** eliadcohen has joined #openstack-qa | 12:45 | |
| *** dviroel|away is now known as dviroel | 12:54 | |
| *** paras333 has joined #openstack-qa | 13:10 | |
| *** ysandeep is now known as ysandeep|away | 13:11 | |
| *** gcheresh_ has quit IRC | 13:39 | |
| openstackgerrit | Archit Modi proposed openstack/whitebox-tempest-plugin master: WIP: rbd direct download https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/786979 | 13:58 |
| *** bulvia has quit IRC | 14:02 | |
| *** whoami-rajat has joined #openstack-qa | 14:04 | |
| *** bulvia has joined #openstack-qa | 14:04 | |
| *** jparoly has joined #openstack-qa | 14:05 | |
| *** rpittau is now known as rpittau|afk | 14:10 | |
| dansmith | gmann: okay, I'd sure rather see it wait for the proper status than just sleep and hope it happens | 14:11 |
| dansmith | gmann: I saw some of that too before I left, but it looked like it was only on the cinder jobs .. did you see it on other ones? | 14:12 |
| yoctozepto | frickler: ack, looking now | 14:15 |
| yoctozepto | ah, independent | 14:15 |
| yoctozepto | makes sense | 14:15 |
| gmann | dansmith: i saw only in nova-ceph-multistore. | 14:24 |
| gmann | dansmith: i am fine for proper wait. i thought tasks status change is very next operation by glance after image active, so just sleep is fine. | 14:25 |
| gmann | let me update | 14:25 |
| dansmith | gmann: I can update it for you if you want | 14:26 |
| gmann | on it. | 14:26 |
| dansmith | okay :) | 14:27 |
| yoctozepto | frickler: done | 14:27 |
| *** rcernin has joined #openstack-qa | 14:48 | |
| *** rcernin has quit IRC | 14:52 | |
| openstackgerrit | Clark Boylan proposed openstack/devstack stable/wallaby: Fix async race updating nova configs https://review.opendev.org/c/openstack/devstack/+/788967 | 15:04 |
| clarkb | gmann: ^ that is a backport of the fix I made yesterday since the async stuff made it into wallaby (but doesn't seem to go further back) | 15:05 |
| clarkb | and it looks like a bunch of dib changes were finally able to land so seems to be working too | 15:06 |
| gmann | clarkb: thanks, +2. in wallaby, parallel mode is false by default but it is needed. | 15:06 |
| gmann | +1 | 15:06 |
| *** bulvia has quit IRC | 15:08 | |
| openstackgerrit | Ghanshyam proposed openstack/tempest master: Add wait to check the import task status https://review.opendev.org/c/openstack/tempest/+/788856 | 15:21 |
| openstackgerrit | Ghanshyam proposed openstack/tempest master: Add wait to check the import task status https://review.opendev.org/c/openstack/tempest/+/788856 | 15:23 |
| openstackgerrit | Ghanshyam proposed openstack/tempest master: Fix hacking check for service client https://review.opendev.org/c/openstack/tempest/+/788978 | 15:35 |
| openstackgerrit | Ghanshyam proposed openstack/tempest master: Add wait to check the import task status https://review.opendev.org/c/openstack/tempest/+/788856 | 15:40 |
| *** paras333 has quit IRC | 15:47 | |
| *** lucasagomes has quit IRC | 16:00 | |
| openstackgerrit | Ghanshyam proposed openstack/devstack master: DNM: testing https://review.opendev.org/c/openstack/devstack/+/788981 | 16:13 |
| *** dtantsur is now known as dtantsur|afk | 16:27 | |
| *** jpena is now known as jpena|off | 16:38 | |
| gmann | dansmith: for this - https://review.opendev.org/c/openstack/tempest/+/788856/4/tempest/api/image/v2/test_images.py | 17:05 |
| gmann | dansmith: there might be multiple tasks per image right? I am thinking to poll all. in our test case it can be just one. is that fine? | 17:06 |
| *** gcheresh_ has joined #openstack-qa | 17:08 | |
| dansmith | gmann: there could be, yeah, and image/$id/tasks returns a list of all tasks for that image, but there should only be one task for this image | 17:14 |
| dansmith | but yes, you can make the waiter wait for all tasks in the returned list to go to success, if that's what you mean | 17:15 |
| gmann | k | 17:15 |
| gmann | yeah | 17:15 |
| dansmith | gmann: so that whole tasks API is supposed to be gated on this: https://github.com/openstack/glance/blob/master/glance/policies/tasks.py#L84 | 17:16 |
| dansmith | gmann: which is admin-only | 17:16 |
| dansmith | I'm worried we might have regressed that in wallaby with the rbac stuff, I'm working on figuring out | 17:16 |
| dansmith | gmann: we have to keep those granular ones at rule:default because those policy elements get used internally and thus it's impossible to set them to anything other than default, otherwise complex operations like import won't work | 17:16 |
| dansmith | gmann: so the tasks api itself is supposed to be checking tasks_api_access | 17:17 |
| gmann | dansmith: humm, i did not that separate policy but why we need this as there are granular policy present for each task operation ? | 17:17 |
| dansmith | gmann: because policy in glance is enforced at the db layer in most cases.. since import needs to create/update tasks on behalf of the user, they have to be non-admin otherwise the internal usage of the task DB objects will fail | 17:18 |
| dansmith | gmann: so they had to add a _different_ global admin-only setting on the api itself | 17:19 |
| dansmith | gmann: https://github.com/openstack/glance/blob/922e544ca2556994450e6972403ba4313318c5e0/glance/api/v2/tasks.py#L127-L127 | 17:19 |
| dansmith | it's a giant mess and we discussed in PTG a whole policy re-write for xena to resolve this (and many other things) | 17:19 |
| *** hamalq has joined #openstack-qa | 17:19 | |
| gmann | yeah, also moving policy checks out of DB layer will make it clean, like we need to do for is_admin things in nova too | 17:20 |
| dansmith | what I'm not sure about is why you're not seeing that return 401 by default | 17:20 |
| dansmith | right | 17:20 |
| *** hamalq has quit IRC | 17:20 | |
| gmann | dansmith: I get :) - https://12d9c9014a31cd38106f-d99046410a2db92aeb18e96327c94fc0.ssl.cf1.rackcdn.com/788856/4/check/glance-multistore-cinder-import/885bb69/testr_results.html | 17:20 |
| dansmith | ahhh, okay good :D | 17:21 |
| *** hamalq has joined #openstack-qa | 17:21 | |
| *** gfidente is now known as gfidente|afk | 17:22 | |
| *** stephenfin is now known as stephenfin|PTOin | 17:27 | |
| *** stephenfin|PTOin is now known as stephenfin|PTO | 17:28 | |
| openstackgerrit | Ghanshyam proposed openstack/tempest master: Add wait to check the import task status https://review.opendev.org/c/openstack/tempest/+/788856 | 18:02 |
| *** eolivare has quit IRC | 18:04 | |
| *** lbragstad_ has quit IRC | 18:04 | |
| *** priteau has quit IRC | 18:04 | |
| *** stand has quit IRC | 18:04 | |
| *** elod_afk has quit IRC | 18:04 | |
| *** akahat|ruck has quit IRC | 18:04 | |
| *** icey has quit IRC | 18:04 | |
| *** eolivare has joined #openstack-qa | 18:07 | |
| *** lbragstad_ has joined #openstack-qa | 18:07 | |
| *** priteau has joined #openstack-qa | 18:07 | |
| *** stand has joined #openstack-qa | 18:07 | |
| *** elod_afk has joined #openstack-qa | 18:07 | |
| *** akahat|ruck has joined #openstack-qa | 18:07 | |
| *** icey has joined #openstack-qa | 18:07 | |
| *** gouthamr has quit IRC | 18:08 | |
| *** gouthamr has joined #openstack-qa | 18:10 | |
| *** sboyron has quit IRC | 18:39 | |
| *** eolivare has quit IRC | 18:40 | |
| *** dave-mccowan has quit IRC | 18:45 | |
| *** gcheresh_ has quit IRC | 18:48 | |
| *** rcernin has joined #openstack-qa | 18:48 | |
| *** rcernin has quit IRC | 18:53 | |
| *** slaweq has quit IRC | 19:18 | |
| *** jparoly has quit IRC | 19:34 | |
| *** dviroel is now known as dviroel|afk | 19:55 | |
| *** ralonsoh has quit IRC | 20:37 | |
| *** gcheresh_ has joined #openstack-qa | 20:42 | |
| *** rcernin has joined #openstack-qa | 20:48 | |
| *** nweinber has quit IRC | 20:52 | |
| *** jparker has quit IRC | 20:53 | |
| *** rcernin has quit IRC | 20:53 | |
| *** ajitha has quit IRC | 20:59 | |
| *** gcheresh_ has quit IRC | 21:00 | |
| openstackgerrit | Archit Modi proposed openstack/whitebox-tempest-plugin master: WIP: rbd direct download https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/786979 | 21:07 |
| *** ramishra has quit IRC | 21:07 | |
| *** paras333 has joined #openstack-qa | 21:29 | |
| *** paras333 has quit IRC | 21:34 | |
| *** erbarr has quit IRC | 21:37 | |
| *** erbarr has joined #openstack-qa | 21:40 | |
| *** paras333 has joined #openstack-qa | 22:27 | |
| *** paras333 has quit IRC | 22:57 | |
| *** tosky has quit IRC | 23:31 | |
| *** Yarboa has quit IRC | 23:44 | |
| *** Yarboa has joined #openstack-qa | 23:44 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!