| *** akekane_ is now known as abhishekk | 05:51 | |
| *** jpena|off is now known as jpena | 06:56 | |
| *** rpittau|afk is now known as rpittau | 07:07 | |
| *** bhagyashris_ is now known as bhagyashris | 08:27 | |
| opendevreview | Slawek Kaplonski proposed openstack/devstack master: Stop creating userrc_early https://review.opendev.org/c/openstack/devstack/+/780417 | 09:48 |
|---|---|---|
| opendevreview | Slawek Kaplonski proposed openstack/devstack master: Deploy Neutron with enforced new RBAC rules https://review.opendev.org/c/openstack/devstack/+/797450 | 09:48 |
| slaweq | frickler thx for link to Your patch yesterday | 09:49 |
| slaweq | I put mine https://review.opendev.org/c/openstack/devstack/+/797450 on top of Yours and devstack (almost) deployed for me | 09:49 |
| slaweq | now the issue is in the tempest | 09:49 |
| slaweq | I will open new LP for tempest for that right now | 09:50 |
| opendevreview | Lee Yarwood proposed openstack/tempest master: zuul: Add a full CentOS 8 stream job to the check and gate queues https://review.opendev.org/c/openstack/tempest/+/797614 | 09:50 |
| opendevreview | Lukas Piwowarski proposed openstack/tempest master: Fix test_network_quota_exceeding test https://review.opendev.org/c/openstack/tempest/+/797466 | 09:57 |
| opendevreview | Lee Yarwood proposed openstack/tempest master: zuul: Add a full CentOS 8 stream job to the check and gate queues https://review.opendev.org/c/openstack/tempest/+/797614 | 10:00 |
| slaweq | gmann kopecmartin yoctozepto maybe You will be interested to check https://bugs.launchpad.net/tempest/+bug/1933323 | 10:28 |
| *** pojadhav is now known as pojadhav|afk | 10:41 | |
| *** jpena is now known as jpena|lunch | 11:30 | |
| opendevreview | Rodolfo Alonso proposed openstack/tempest master: Use "resolvectl dns" to retrieve the DNS nameservers https://review.opendev.org/c/openstack/tempest/+/794776 | 11:31 |
| *** dviroel|out is now known as dviroel | 11:37 | |
| kopecmartin | slaweq: oh ... thanks for filling out the bug | 12:18 |
| opendevreview | Lukas Piwowarski proposed openstack/tempest master: Fix test_network_quota_exceeding test https://review.opendev.org/c/openstack/tempest/+/797466 | 12:30 |
| *** pojadhav|afk is now known as pojadhav | 12:32 | |
| *** jpena|lunch is now known as jpena | 12:33 | |
| opendevreview | Rodolfo Alonso proposed openstack/devstack master: Make explicit the network backend used in the CI jobs https://review.opendev.org/c/openstack/devstack/+/797638 | 13:05 |
| opendevreview | Rodolfo Alonso proposed openstack/tempest master: Make explicit the network backend used in the CI jobs https://review.opendev.org/c/openstack/tempest/+/797639 | 13:05 |
| *** sboyron is now known as Guest322 | 14:44 | |
| gmann | TheJulia: register_service_client is implemented in only few plugins like manila or sahara may be | 15:48 |
| gmann | TheJulia: this is designate-tempest-plugin exaple for os_admin https://github.com/openstack/designate-tempest-plugin/blob/b18605ab79647eeac2901ccbcb5d530bf26ca0af/designate_tempest_plugin/tests/scenario/v2/test_zones_transfer.py#L32 | 15:50 |
| gmann | slaweq: yeah, verify-config is not yet moved to new RBAC, I will check what all things needs to be done together | 15:53 |
| gmann | slaweq: I am trying those in my patches for other services also https://review.opendev.org/q/topic:%2522secure-rbac%2522+(status:open+OR+status:merged)+project:openstack/devstack+owner:gmann%2540ghanshyammann.com | 15:53 |
| TheJulia | gmann: looks like barbican is the most... proper | 15:54 |
| TheJulia | oddly, and maybe it is due to style, searching for some examples with codesearch has not been yeilding good results which has ment lots of digging :( | 15:55 |
| gmann | any one you can check. many plugins use that way | 15:55 |
| gmann | yeah codesearch sometime very specific on regex | 15:55 |
| TheJulia | it looks like there is just lots of inconsistent style | 15:56 |
| gmann | for consistency we recommended register_service_client style but only plugins did progress on that. this is something we need to do on plugin side | 15:57 |
| gmann | *only two plugins | 15:57 |
| TheJulia | out of curiosity when was that implemented as a style for tempest? | 15:59 |
| *** jpena is now known as jpena|off | 16:00 | |
| gmann | it is since very long, I think 3-4 years back or even more older | 16:03 |
| johnsom | TheJulia Not 100% sure what you are looking for, but Octavia has a fairly complete client setup: https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/tests/test_base.py#L165 | 16:03 |
| gmann | yes, ocyavia is also one example of doing it in legacy way | 16:05 |
| johnsom | lol, legacy. Ok, so I guess we missed a memo as well. What is the new way? | 16:05 |
| TheJulia | gmann: ahh, yeah, that would explain it since ironic... if memory serves... was one of the first since our entrance into tempest was refused | 16:06 |
| TheJulia | johnsom: I might have a decently clean example in a little bit | 16:07 |
| * TheJulia crosses fingers | 16:07 | |
| johnsom | Yeah, same for us. One of the first true plugins | 16:07 |
| gmann | johnsom: :) this is what we recommend via get_service_clientsway - https://github.com/openstack/tempest/blob/7e96c8e854386f43604ad098a6ec7606ee676145/tempest/test_discover/plugins.py#L121 | 16:07 |
| TheJulia | johnsom: https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/797521 is the direction I'm heading with ironic, although I've yet to get it to work, it feels very close | 16:08 |
| *** rpittau is now known as rpittau|afk | 16:08 | |
| gmann | johnsom: this way you just need to register the service client info in tempest and tempest take care of creating the credential manager etc and make if accessible from Tempest in plugins | 16:08 |
| gmann | otherwise plugins needs to override client_manager and take care of credential manager or so | 16:10 |
| johnsom | Hmm, we have this: https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/plugin.py#L54 | 16:10 |
| gmann | johnsom: ohk, i missed that, in that case you might not need this one https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/tests/test_base.py#L92 | 16:10 |
| johnsom | I think we are doing that. We set that up, then the os_admin.<client> things become available. | 16:11 |
| mtreinish | TheJulia: there used to be ironic tests in tempest. A really long time ago: https://opendev.org/openstack/tempest/commit/62b1ed19def65ecf34cdedf0a3b3439ebb7d1d09 | 16:11 |
| johnsom | Plus the other credentials we need | 16:11 |
| mtreinish | it was before the big tent and before we started doing plugins | 16:11 |
| mtreinish | it was removed here: https://opendev.org/openstack/tempest/commit/66cded2553a90ce2b29b4dae442e1bce95895f53 | 16:12 |
| gmann | johnsom: if get_service_clients registering all the octavia service client in tempest then you do not need to override client_manager . | 16:12 |
| TheJulia | mtreinish: I had no idea! | 16:12 |
| TheJulia | mtreinish: thanks! | 16:13 |
| gmann | johnsom: I can check sometime later by removing that and it should work. | 16:13 |
| johnsom | gmann lol, yeah, dead code, never referenced, at least from our code | 16:13 |
| mtreinish | hah, I mean it was 8yrs ago. I barely remember it. I more remember the baremetal config option in the tempest.conf than anything | 16:13 |
| gmann | johnsom: but good to know you are doing the new style. something I can ref to other plugins also and encourage to do that way | 16:14 |
| gmann | mtreinish: and lot of discussion while moving :) | 16:14 |
| TheJulia | I guess the unfortunate continuation of that was also the negative impact on anything plugin based getting picked up in interop test profiles since they had to be explicitly run the plugin AIUI | 16:14 |
| TheJulia | mtreinish: also o/, it has been a long time | 16:15 |
| gmann | we have designate and heat plugins tests running in interop certification tests | 16:15 |
| TheJulia | w/r/t ironic, I really don't care about interop or value, I just have someone that complains because ironic is not there | 16:16 |
| TheJulia | and when asked, nobody really knows the secret sauce required to bridge the gap short of I guess whatever designate and heat explicitly did | 16:16 |
| * TheJulia shrugs | 16:17 | |
| johnsom | gmann https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/797715 We will see if it's really dead code or there is another issue. | 16:18 |
| johnsom | My guess is that it's just old cruft | 16:18 |
| gmann | johnsom: ack, will monitor this. | 16:20 |
| gmann | johnsom: I think you need to pass the auth_provider also in get_service_clients so that octavia service clients are init with that auth_provider pointing to octavia endpoints. | 16:22 |
| gmann | let's see the result | 16:22 |
| gmann | ah you are passing octavia_config there. should be ok | 16:25 |
| gouthamr | gmann: i don't see register_service_client in manila-tempest-plugin, just get_service_clients: https://opendev.org/openstack/manila-tempest-plugin/src/branch/master/manila_tempest_tests/plugin.py#L59-L75 | 16:27 |
| gmann | gouthamr: in that case that patch might not be merged. let me check | 16:28 |
| gmann | gouthamr: oh, it is get_service_clients so all good. | 16:28 |
| gouthamr | awesome :) thought we needed something new here | 16:29 |
| gmann | gouthamr: no, I remember manila was first plugin we tried this new way of registering the service client from plugins | 16:30 |
| gouthamr | gmann: ah i see! :) | 16:33 |
| *** gfidente is now known as gfidente|afk | 16:34 | |
| TheJulia | gmann: do you have a decent example of the auth_provider that you were talking about to johnsom | 16:51 |
| gmann | TheJulia: you mean for get_service_clients case or client_manager overreidden case? | 16:54 |
| TheJulia | either, get_services_clients. Specifically I'm getting an exception | 16:56 |
| TheJulia | https://www.irccloud.com/pastebin/2DvQ9fay/ | 16:56 |
| gmann | are you passing all the param like this https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/plugin.py#L54 | 16:58 |
| TheJulia | gmann: explicitly https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/plugin.py#L55-L57 ? | 17:01 |
| TheJulia | I guess that has the params in it? | 17:01 |
| gmann | yeah that config param should have 'service' config option | 17:02 |
| TheJulia | so if I don't need nor want it configurable dynamically, it should just match the service plugin name right? | 17:04 |
| TheJulia | or... ?! | 17:04 |
| gmann | 'catalog_type' which is names as service in tempest | 17:04 |
| TheJulia | ahh, okay | 17:07 |
| johnsom | gmann Looks like we are missing something: https://cbff25b854b00bc0ff99-8ce5690b0835baabd00baac02d43f418.ssl.cf5.rackcdn.com/797715/1/check/octavia-v2-dsvm-scenario/7c7c774/job-output.txt | 18:17 |
| johnsom | AttributeError: 'Manager' object has no attribute 'loadbalancer_client' | 18:17 |
| TheJulia | johnsom: you might need to extend the path or you might have a mismatch, if you look at my ironic-tempest-plugin patch you can see I had to define the paths out and then have to also reconcile the name elsewhere. I've gotten pretty far, now hitting fun stuff like can't use scoepd admin to create a network | 20:03 |
| TheJulia | well, system scoped | 20:03 |
| gmann | no, its how octavia is accessing the client I think. johnsom you do register the client but you access the client from how you register in your client manager | 20:06 |
| gmann | let me update and try | 20:06 |
| gmann | johnsom: updated the patch, I think I covered all but let's see if anything else missing | 20:18 |
| johnsom | gmann Thank you! | 21:05 |
| johnsom | Hmmm, still a naming/path issue probably: AttributeError: 'Manager' object has no attribute 'load_balancer_v2' | 21:08 |
| gmann | johnsom: yeah, let me check | 21:09 |
| johnsom | I can pull that down now and do a little debug | 21:10 |
| johnsom | Oh, ok, if you have an idea I can hold on | 21:10 |
| gmann | johnsom: it should be available in name you are registering here https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/plugin.py#L60 | 21:11 |
| gmann | here tempest replace - and . with _ | 21:11 |
| *** dviroel is now known as dviroel|out | 21:13 | |
| johnsom | It appears to be 'load-balancer_v2' | 21:16 |
| gmann | yeah - should be replaced with _ | 21:17 |
| johnsom | So, changed that in the "name" field in the get_service_clients, got farther. Now: AttributeError: 'ClientsFactory' object has no attribute 'ListenerClient' | 21:19 |
| johnsom | I will interate on this and let you know if I hit another puzzling issue. | 21:19 |
| johnsom | iterate, sigh. | 21:19 |
| johnsom | I assume the client_names list needs updating | 21:20 |
| johnsom | Hmm, I think we need to import those in the __init__? | 21:25 |
| johnsom | testtools.runtest.MultipleExceptions: (<class 'AttributeError'>, AttributeError("Invalid class name, ListenerClient is not found in <module 'octavia_tempest_plugin.services.load_balancer.v2' from '/opt/stack/.local/lib/python3.8/site-packages/octavia_tempest_plugin/services/load_balancer/v2/__init__.py'>"), <traceback object at 0x7f2437041ec0>) | 21:25 |
| johnsom | Details: {'type': 'HTTPNotFound', 'message': 'The resource could not be found.', 'detail': ''} | 21:52 |
| johnsom | I think the params removed here are a problem: https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/797715/2/octavia_tempest_plugin/clients.py#b66 | 21:53 |
| gmann | these param should be loaded form here | 22:01 |
| gmann | https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/plugin.py#L55 | 22:01 |
| johnsom | auth_provider is missing I think | 22:01 |
| gmann | auth_provider will be prepared by Tempest. | 22:03 |
| gmann | johnsom: ah, we need to add those client in __init__ also https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/services/load_balancer/v2/__init__.py | 22:05 |
| johnsom | Yeah, I did that locally for this testing | 22:05 |
| gmann | add all the client in __all__ like done here https://github.com/openstack/tempest/blob/master/tempest/lib/services/compute/__init__.py#L68 | 22:05 |
| gmann | ohk | 22:05 |
| johnsom | I can post what I have.... | 22:05 |
| gmann | yeah that will help | 22:06 |
| johnsom | gmann https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/797715 | 22:18 |
| johnsom | Oh, forgot the - -> _ | 22:19 |
| johnsom | There we go | 22:20 |
| johnsom | Hmm, maybe my local test stack had an issue. It appears to be running in zuul. Let's see | 22:52 |
| gmann | it still not finding few clients | 22:59 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!