| gmann | kopecmartin: these two are ready https://review.opendev.org/c/openstack/tempest/+/624005 https://review.opendev.org/c/openstack/tempest/+/822054 | 02:20 |
|---|---|---|
| gmann | kopecmartin: and I am +2 on this now https://review.opendev.org/c/openstack/tempest/+/840112 | 02:26 |
| *** soniya29 is now known as soniya29|ruck | 02:50 | |
| *** elodilles is now known as elodilles_pto | 04:59 | |
| opendevreview | Merged openstack/tempest master: Allows to skip wait for volume create https://review.opendev.org/c/openstack/tempest/+/837603 | 05:10 |
| *** jpena|off is now known as jpena | 07:01 | |
| *** soniya29|ruck is now known as soniya29|ruck|lunch | 08:36 | |
| *** soniya29|ruck|lunch is now known as soniya29|ruck | 09:09 | |
| opendevreview | Merged openstack/tempest master: Add tempest-slow stable branch jobs on Tempest master gate https://review.opendev.org/c/openstack/tempest/+/624005 | 09:12 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Deploy with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/826484 | 09:15 |
| *** artom__ is now known as artom | 09:17 | |
| *** soniya29|ruck is now known as soniya29|ruck|afk | 11:49 | |
| *** soniya is now known as soniya|ruck|afk | 11:57 | |
| *** pojadhav is now known as pojadhav|break | 11:58 | |
| *** pojadhav|break is now known as pojadhav | 12:29 | |
| opendevreview | yatin proposed openstack/devstack master: Wait for OVN dbs also along with sockets https://review.opendev.org/c/openstack/devstack/+/840885 | 12:39 |
| opendevreview | yatin proposed openstack/devstack master: Add Ubuntu 22.04 LTS (jammy) platform job https://review.opendev.org/c/openstack/devstack/+/839359 | 12:40 |
| opendevreview | yatin proposed openstack/devstack master: DNM: Testing only jammy job https://review.opendev.org/c/openstack/devstack/+/839389 | 12:42 |
| opendevreview | yatin proposed openstack/devstack master: DNM: Testing only jammy job https://review.opendev.org/c/openstack/devstack/+/839389 | 12:44 |
| *** soniya|ruck|afk is now known as soniya|ruck | 13:43 | |
| *** pojadhav is now known as pojadhav|afk | 13:57 | |
| opendevreview | Merged openstack/tempest master: Remove compute api_extensions config option https://review.opendev.org/c/openstack/tempest/+/822054 | 14:45 |
| whoami-rajat__ | kopecmartin, hey, I had a patch in cinder-tempest-plugin which is dependent on a tempest patch (which is merged now) but we will require a tag of tempest to bump requirements in cinder-tempest-plugin for it | 15:36 |
| whoami-rajat__ | kopecmartin, so my question is, when do we tag tempest, is there a consistent way or we just do it when it's needed? | 15:36 |
| whoami-rajat__ | cinder-tempest-plugin patch: https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/795753 | 15:36 |
| whoami-rajat__ | tempest patch: https://review.opendev.org/c/openstack/tempest/+/837603 | 15:36 |
| gmann | whoami-rajat__: as we use master tempest in upstream it is all ok to test and does not need any tempest new tag. you should be able to use latest tempest things in plugin | 15:45 |
| gmann | whoami-rajat__: and when we tag new tempest then you can bump requirement also to match for downstream testing or so | 15:46 |
| gmann | whoami-rajat__: replied on the cinder-tempest-plugin patch. We should not use tempest.volume.base which we removed earlier | 15:52 |
| whoami-rajat__ | gmann, ack, thanks, that's very helpful | 16:00 |
| gmann | whoami-rajat__: check if you end up with lot of duplicate code in cinder-tempest-plugin and if so then we can create a stable class for plugin to use. | 16:01 |
| *** jpena is now known as jpena|off | 16:29 | |
| whoami-rajat__ | gmann, sure, there won't be much duplication since we only need 1 new method (which was already there in the initial patchsets) | 16:30 |
| whoami-rajat__ | but i think would be helpful if tempest api helper classes are also stable | 16:30 |
| gmann | whoami-rajat__: making stable need more effort and more than that we cannot change it in incompatible way so more improvement might be restricted and we may end up splitting it 1. stable things 2. wrapper on that to have incompatible changes things | 16:31 |
| gmann | whoami-rajat__: I will say if in future it increase (lot of duplicate code) then we can think of having stable in tempest which can be consumed by plugins. what you say? | 16:32 |
| gmann | bkopilov: I like the idea, commented about unit test https://review.opendev.org/c/openstack/tempest/+/840410 | 16:34 |
| whoami-rajat__ | gmann, sure, i understand it will be too much efforts and we need good examples of code duplication everywhere (like scenario manager in every tempest plugin) to make the tempest one stable | 16:35 |
| whoami-rajat__ | i will bring that discussion up if we have too many dependencies on the tempest api helper classes/methods | 16:36 |
| whoami-rajat__ | thanks | 16:36 |
| gmann | whoami-rajat__: sure, and it is not like code needs to be used in many plugins to have that stable in tempest. if it is just one plugin like cinder-tempest-plugin in this case we can still think of stable interface. | 16:37 |
| gmann | whoami-rajat__: so whatever cinder team think, let me know and I can work on that if stable interface needed and see how it goes | 16:39 |
| *** soniya|ruck is now known as soniya|out | 17:39 | |
| bkopilov | gmann, ack , thanks let me fix the failures | 17:54 |
| bkopilov | gmann, where should i add unit test ? | 18:19 |
| gmann | bkopilov: in this file https://github.com/openstack/tempest/blob/master/tempest/tests/lib/test_decorators.py | 18:20 |
| bkopilov | gmann, ack | 18:20 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!