Friday, 2022-06-10

*** pojadhav|afk is now known as pojadhav04:52
*** soniya29 is now known as soniya29|ruck05:09
*** jpena|off is now known as jpena07:14
opendevreviewMerged openstack/devstack stable/wallaby: Remove libvirt-python from upper-constraints  https://review.opendev.org/c/openstack/devstack/+/80582407:18
rpittauthanks gmann frickler :)07:42
opendevreviewDr. Jens Harbott proposed openstack/hacking master: Drop py36 and py37 support  https://review.opendev.org/c/openstack/hacking/+/84457007:49
*** soniya is now known as soniya|ruck08:18
opendevreviewRajat Dhasmana proposed openstack/tempest master: Add test to rebuild volume backed instance  https://review.opendev.org/c/openstack/tempest/+/83101809:01
*** soniya|ruck is now known as soniya|ruck|lunch09:01
opendevreviewDr. Jens Harbott proposed openstack/hacking master: Drop py36 and py37 support  https://review.opendev.org/c/openstack/hacking/+/84457009:19
fricklergmann: ^^ with that the releasenotes look fine, except that the "current" ones still include older releases, but I guess that that is acceptable. when this merges we could release 5.0.0 and add another section for that. and in the future get better at requiring releasenotes incorporated in important changes09:21
*** soniya|ruck|lunch is now known as soniya|ruck10:46
whoami-rajatdansmith, hey, I corrected the tempest test for rebuilding (there was another instance being created, not sure why other tests create it) but now I'm facing another issue with ssh which I'm not able to resolve, can you help me out with that? https://review.opendev.org/c/openstack/tempest/+/831018/16/tempest/api/compute/servers/test_server_actions.py#88311:43
gmannfrickler: yeah, +213:42
dansmithwhoami-rajat: the upstream run is complaining about a secgroup, so maybe that's related? but yeah, I'll stack  locally and see if I can figure it out13:44
whoami-rajatdansmith, ack, will take a look thanks14:12
opendevreviewGorka Eguileor proposed openstack/tempest master: Add LUKS v2 tests  https://review.opendev.org/c/openstack/tempest/+/83606514:21
*** soniya|ruck is now known as soniya|ruck|dinner14:45
dansmithwhoami-rajat: I'm not sure why you changed the ssh code, because it seems related.. it must be trying the wrong IP now or something14:56
dansmithI assume you did that for some reason, but I'm not sure why -- it was sshing successfully before14:56
whoami-rajatdansmith, it was but there was another instance there somehow affecting this one (maybe as a failover) which i removed and after that ssh stopped working 15:06
whoami-rajatI'm referring to this method https://paste.opendev.org/show/baMcaRPskZzPyE06Urt5/15:07
whoami-rajatdansmith, after removing this, ssh stopped working ^15:07
dansmithwhoami-rajat: but that's probably affecting the whole class15:07
dansmithwhoami-rajat: but why do you think that's affecting the volume rebuild?15:08
whoami-rajatdansmith, so when i put pdb in the test, i saw that the file was being created in one server and the other one was being rebuild so the file always existed because we're rebuilding the wrong one15:08
whoami-rajatdansmith, I'm not sure how any of that works but removing the other instance allowed rebuild to work correctly, (i tried with console, creating a file before rebuild and it wasn't there after the rebuild15:09
dansmithhmm, I don't see how that could be from the code, but okay15:09
dansmithwe're calling rebuild on the same server object we're using for the ssh15:10
dansmith(it seems)15:10
whoami-rajatyes we are, that's why I've no idea how the other instance comes into play15:11
dansmithI wouldn't think removing that function would change the ssh behavior, but the other changes you made (validation resources, etc) would be more likely15:12
dansmithwhoami-rajat: okay15:12
whoami-rajatin any case, we wouldn't need that secondary instance, we're just testing rebuild on one server15:12
dansmithwhoami-rajat: so to be clear, you don't think the other instance is affecting the rebuild, but that we're somehow calling rebuild on the wrong server as a result, is that right?15:12
whoami-rajatdansmith, i introduced those changes to make ssh work (taken reference from other tests) but you can try and revert back, it still won't work, i can push another PS showing that15:13
dansmithadding that function back in does not fix ssh for me locally, FWIW, so I think it must be related to the other changes in 15..1615:13
whoami-rajatdansmith, yes, we're creating file in server 1 and calling rebuild on server 2 and verifying on server 115:13
dansmithokay15:13
dansmithokay I may have fixed it15:16
whoami-rajatnice, what was it?15:18
dansmithI'm not telling15:18
whoami-rajat:D15:19
dansmithlemme do some more poking first15:19
whoami-rajatas long as the test gets fixed, i don't mind knowing the trick15:19
whoami-rajatack15:19
dansmithhah15:20
* whoami-rajat will be away for 1-2 hours15:20
whoami-rajatbut irc will be active15:20
dansmithwhoami-rajat: I'll comment on the patch15:20
whoami-rajatdansmith, Great, thanks for looking into it :)15:20
dansmithnp15:21
opendevreviewDan Smith proposed openstack/tempest master: Add test to rebuild volume backed instance  https://review.opendev.org/c/openstack/tempest/+/83101815:43
dansmithwhoami-rajat: ^15:43
*** soniya|ruck|dinner is now known as soniya|ruck15:49
opendevreviewDan Smith proposed openstack/tempest master: Add test to rebuild volume backed instance  https://review.opendev.org/c/openstack/tempest/+/83101815:50
dansmithgmann: kopecmartin seems like "StorPool" 3rd party CI is broken? complaining about missing infra nodepools and such'15:51
gmanndansmith: yeah, it has been like that since starting and not sure who own it16:30
dansmithgmann: ah okay I hadn't noticed it complaining about this type of thing before, but I know it fails a lot16:31
gmannyeah, I raised it many times but not sure if kopecmartin knows about iut16:31
gmannit16:31
gmannknows i mean owner of this CI or so16:31
dansmithah okay, sorry for the noise then16:31
dansmithit's been a while since I worked directly on a tempest patch I guess16:32
sean-k-mooneywould people object if i decoupled the useage of the controller inventory host name from being  """ when: inventory_hostname == 'controller'"" to say  """when: inventory_hostname == groups[controllers][0]"""16:39
sean-k-mooneyi have not looked into exactly what that woudl require16:40
sean-k-mooneybut currenlty if i want to reuse some of the roles from devstack my inventory host name must be contoller exactly or it wont work16:40
sean-k-mooneymy actual hostname can be anything16:40
sean-k-mooneybut in the invetory it mush be controller and then you can use ansible_host to map it to your actual hostname16:41
sean-k-mooneyactully i feel like that shoudl not need to be done the way im using the role but i get odd issue when i try to use other names that go away if i call it contoler i might have missed somehing but that not a thing to debug on a friday16:49
sean-k-mooneyoh its probably this https://github.com/SeanMooney/ansible_role_devstack/blob/16dce64c4b1ee9fc7f6d50eb85f9aafb407ae68e/ansible/roles/devstack_compute/defaults/main.yml#L32-L46=16:51
sean-k-mooneyim not consitnetly accessing the contoler via the group16:52
sean-k-mooneyif i fix that is houdl be able to rename the vms and generate the local config properly16:53
sean-k-mooneythat would actully expalin why this worked fine on the contollers and only failed for the subnodes/computes16:57
*** jpena is now known as jpena|off17:11
whoami-rajatdansmith, wow, the rebuild test passed, I remember seeing one instance containing the file and other one showing rebuild status but that could be unrelated to the failure, anyway thanks for fixing the test17:41
dansmithwhoami-rajat: yep, no problem :)17:41
whoami-rajat:)17:42
*** soniya|ruck is now known as soniya|ruck|out18:05
opendevreviewJames Parker proposed openstack/whitebox-tempest-plugin master: [WIP] Attach and detach an SR-IOV port  https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/84538219:50

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!