| opendevreview | Goutham Pacha Ravi proposed openstack/devstack-plugin-ceph master: [WIP] Disable msgrv2 compatibility https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/881767 | 00:09 |
|---|---|---|
| opendevreview | Goutham Pacha Ravi proposed openstack/devstack-plugin-ceph master: [WIP] Disable msgrv2 compatibility https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/881767 | 00:10 |
| opendevreview | Goutham Pacha Ravi proposed openstack/devstack-plugin-ceph master: [WIP] Disable msgrv2 compatibility https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/881767 | 00:28 |
| dansmith | gmann: I think get_server_ip() maybe doesn't work if network is already set up? seems like the sshable stuff makes that fail because it can't add another floating IP or something | 00:33 |
| dansmith | I'm exhausted for today, so I'll pick it up tomorrow | 00:33 |
| opendevreview | Goutham Pacha Ravi proposed openstack/devstack-plugin-ceph master: [WIP] Disable msgrv2 compatibility https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/881767 | 03:11 |
| *** gthiemon1e is now known as gthiemonge | 07:12 | |
| opendevreview | Luigi Dino Tamagnone proposed openstack/tempest master: Avoiding the clean of not tempest created resources https://review.opendev.org/c/openstack/tempest/+/879923 | 13:24 |
| opendevreview | Arx Cruz proposed openstack/tempest master: Update v3_endpoint_type to use public https://review.opendev.org/c/openstack/tempest/+/881825 | 13:36 |
| opendevreview | Arx Cruz proposed openstack/tempest master: Update v3_endpoint_type to use public https://review.opendev.org/c/openstack/tempest/+/881825 | 13:38 |
| opendevreview | Arx Cruz proposed openstack/tempest master: Update v3_endpoint_type to use public https://review.opendev.org/c/openstack/tempest/+/881825 | 13:44 |
| opendevreview | Arx Cruz proposed openstack/tempest master: Update v3_endpoint_type to use public https://review.opendev.org/c/openstack/tempest/+/881825 | 14:00 |
| opendevreview | Lukas Piwowarski proposed openstack/tempest master: [WIP] Catching broken tests in tempest-full-test-account-* jobs https://review.opendev.org/c/openstack/tempest/+/880630 | 15:21 |
| opendevreview | Dan Smith proposed openstack/tempest master: Allow wait_until=SSHABLE in scenario manager https://review.opendev.org/c/openstack/tempest/+/881675 | 16:19 |
| gmann | dansmith: hi | 17:14 |
| dansmith | gmann: mornin' | 17:14 |
| gmann | get_server_ip should get the fip from server but is validation_resource one is diff? | 17:14 |
| dansmith | gmann: get_server_ip() just blindly creates a new FIP, but then fails because we've already gotten one from the validation_resources | 17:15 |
| dansmith | gmann: I added a "get or create" logic to get_server_ip() which will try to find the existing one, if present before it creates | 17:15 |
| gmann | dansmith: right, scenario manager one seems not matching with validation one, I think we can use this https://github.com/openstack/tempest/blob/e64f4c2b07e048ea77d08a29b7afbd17448abc32/tempest/common/compute.py#L60 | 17:16 |
| dansmith | gmann: only if we pass validation_resources, which we don't get back from create_server() unless there's somewhere it's stored on self? | 17:18 |
| dansmith | gmann: so you don't want this? https://review.opendev.org/c/openstack/tempest/+/881675/10/tempest/scenario/manager.py#1189 | 17:18 |
| gmann | dansmith: this should also work. and validation resource FIP also get associated to server https://github.com/openstack/tempest/blob/master/tempest/common/compute.py#L87 | 17:21 |
| gmann | in case ssh one using from validation_resources | 17:21 |
| dansmith | gmann: the thing I added to that patch does work for me locally | 17:21 |
| gmann | ok | 17:21 |
| dansmith | and for the name of get_server_ip(), I expect it to get, not necessarily create, but this makes it "however you have to do it, get me an IP" | 17:21 |
| gmann | we do that from API tests but scneario tests were written differently and consuming validation_resources need these type of modifucation | 17:22 |
| dansmith | okay | 17:23 |
| gmann | we need to get it on same way as API test doing ssh with common ssh resources | 17:23 |
| gmann | i mean for later free time :) | 17:24 |
| dansmith | okay so I'm not sure if you're asking me to change what I have.. the compute.get_server_ip() only returns from validation_resources, it doesn't create if missing, so there's more needed than just using that | 17:24 |
| gmann | no, all ok in your change | 17:24 |
| dansmith | okay | 17:24 |
| dansmith | this: https://review.opendev.org/c/openstack/tempest/+/881675/10/tempest/scenario/test_server_basic_ops.py#137 | 17:25 |
| dansmith | used to fail because it would break the validation right below it, but with my change it now succeeds | 17:25 |
| dansmith | so that's not necessary to wait for sshable there, but it was a good test to make sure the get-or-create worked | 17:26 |
| gmann | k | 17:27 |
| dansmith | woohoo, got a clean run on the cinder test plugin | 18:11 |
| *** JayF is now known as Guest12444 | 18:27 | |
| *** JasonF is now known as JayF | 18:27 | |
| opendevreview | Dan Smith proposed openstack/tempest master: Allow wait_until=SSHABLE in scenario manager https://review.opendev.org/c/openstack/tempest/+/881675 | 19:55 |
| opendevreview | Dan Smith proposed openstack/tempest master: Wait until SSHABLE in volumes_extend test https://review.opendev.org/c/openstack/tempest/+/881888 | 19:55 |
| opendevreview | Merged openstack/tempest master: Update "test_list_migrations_in_flavor_resize_situation" to indicate the failing request on timeout. https://review.opendev.org/c/openstack/tempest/+/876953 | 20:42 |
| dansmith | gmann: okay, this fixes another volumes test that does not wait for sshable, at the bottom of my current stack: https://review.opendev.org/c/openstack/tempest/+/881888/1 | 21:14 |
| dansmith | it just passed in the nova job I'm watching, so should be good to merge | 21:14 |
| dansmith | that probably bites us in normal runs too, one of many volume detach fails | 21:14 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!