Thursday, 2023-07-20

opendevreviewMerged openstack/devstack master: Always set image_uuid_alt in configure_tempest()  https://review.opendev.org/c/openstack/devstack/+/88895302:34
opendevreviewMerged openstack/tempest master: Fix test_schedule_to_all_node to support installation with ironic  https://review.opendev.org/c/openstack/tempest/+/88749305:41
opendevreviewJakub Skunda proposed openstack/devstack master: git: git checkout for a commit hash combinated with depth argument  https://review.opendev.org/c/openstack/devstack/+/88901208:22
sean-k-mooneyhi o/11:03
sean-k-mooneyi have not really been following the "install devstack in a single venv" topic since last september11:03
sean-k-mooneybut i think i saw some comment in my email that its close to working end to end again?11:04
sean-k-mooneyi need to create a devstack env to test something but i was wondering if it was worth testing that while i was at it11:04
sean-k-mooneyhttps://review.opendev.org/c/openstack/devstack/+/55893011:07
sean-k-mooneybased on the zuul cofnig it looks liek its disabeld on rpm distos but i can test it out on ubuntu 22.04 right11:07
fricklersean-k-mooney: yes, I didn't get it to work on rpm, if you want to look into that, that would be great. ubuntu and debian should work fine, see also https://review.opendev.org/c/openstack/devstack/+/88754711:25
sean-k-mooneyhonestly i dont really care about fedora/centos testing normally. i will ocationally fix things for coworkers that use them like this https://review.opendev.org/c/openstack/devstack/+/878718 review welcome :P but i use ubunut for almost all my dev11:28
sean-k-mooneynext time i deploy a rpm dev env i can give it a try but currenly installing 22.0411:29
fricklersean-k-mooney: ok, thx11:34
sean-k-mooneymy underdstandign is the intent of debian/ubuntu to break sudo pip install11:35
sean-k-mooneyis not yet something that fedora have looked at11:36
sean-k-mooneyso for now it not an issue11:36
fricklersean-k-mooney: well we could simplify some code if we stop supporting the non-venv variant, but I agree it is not urgent11:39
sean-k-mooneyyep i think we shoudl move in that direction11:40
sean-k-mooneybut that i think can wait till the C release or at least till after this inital path is merged11:40
fricklerack11:45
sean-k-mooneyhum11:55
sean-k-mooneyso it look like devstack is assuming that /opt/stack/logs or opt stack in general is owned by the current user11:56
sean-k-mooneywhich it almost always will be11:57
sean-k-mooneyi normally either use "sudo ./tools/create-stack-user.sh" or add the account i log in with with passwordless sudo in my devstack vms11:58
sean-k-mooneythis time i did both and it did not like it because my current user did not create /opt/stack as its the stack user home dir11:58
sean-k-mooneyill just swap to the stack user instead11:59
fricklerI always run devstack as the default user of the cloud image I'm using, that avoids any such issue. is there still any installer that only creates a root account? if not, we might drop some of this confusing extra user stuff12:09
sean-k-mooneyyep12:09
sean-k-mooneyand when i do that on my home openstack thats what i do12:09
sean-k-mooneyi installed the vm on my laptop form an iso this time12:10
sean-k-mooneyi dont think there is any disto that currently has an option to give passwordless sudo rights to the current user12:11
sean-k-mooney* to the new user at install time12:11
sean-k-mooneybut we could jsut add a script file to do that in devstack12:11
sean-k-mooneyand drop the stack user stuff12:11
* frickler likes that idea12:12
sean-k-mooneythat or move the stack users home dir to /home ...12:13
sean-k-mooneyand keep /opt/stack for devstack12:14
sean-k-mooneythat actully the root of the isuse i hit sharing /opt/stack as teh dest dir and home dir12:14
fricklermaybe the CI setup also gets simpler if we do everything as zuul user. I'll take a look at that12:20
sean-k-mooneyya possibly. do we currently use the stack user in ci12:21
sean-k-mooneyi assumed it was using the zuul user already12:21
sean-k-mooneyalso even with a password if you do sudo ls before you do ./stack.sh12:22
sean-k-mooneydevstack normally works fine12:22
sean-k-mooneyso as it stand today if you dont run the create stack user script12:22
sean-k-mooneyit works perfectly fine with any user with the right permissiosn12:23
fricklerhttps://opendev.org/openstack/devstack/src/branch/master/roles/setup-stack-user12:26
fricklerand a different tempest user12:26
sean-k-mooney=========================12:47
sean-k-mooneyDevStack Component Timing12:47
sean-k-mooney (times are in seconds)12:47
sean-k-mooney=========================12:47
sean-k-mooneywait_for_service      1312:47
sean-k-mooneyasync_wait           36412:47
sean-k-mooneyosc                  16712:47
sean-k-mooneyapt-get              20212:47
sean-k-mooneytest_with_retry        612:47
sean-k-mooneydbsync                2712:47
sean-k-mooneypip_install          12312:47
sean-k-mooneyapt-get-update         012:47
sean-k-mooneyrun_process           2712:47
sean-k-mooneygit_timed            11912:47
sean-k-mooney-------------------------12:47
sean-k-mooneyUnaccounted time     17312:47
sean-k-mooney=========================12:47
sean-k-mooneyTotal runtime        122112:48
sean-k-mooneyi have not done a normal install on this laptop12:48
sean-k-mooneybut that does not seam bad for a clean vm12:48
sean-k-mooneyso a.) 20 mins is about on par with what i expect so the venv didnt seam to slow anything down12:49
sean-k-mooneyb.) it mostly worked "first time" on a clean vm12:49
sean-k-mooneyim going to actully boot a vm and then ill reveiw the vnev patch but at first galnce its looking promising12:50
sean-k-mooneyhas this been tried with any devstack plugins?12:50
sean-k-mooneylike devstack-plugin-ceph12:50
fricklerI tested with neutron and designate, but not ceph I think, that's a good addition13:41
sean-k-mooneyif the devstack plugins were suing the helper furnciotn in function and functions-common form devstack13:54
sean-k-mooneythey likely dont need to do anything special13:55
sean-k-mooneyi.e. if they were using the pip helpers13:55
sean-k-mooneythings like cpeh proably are fine since they are configuring an external system13:55
sean-k-mooneybut a devstack pluging dat integrated a out of tree driver ectra would need to ensure its moduels were put in the venv13:56
yusufgungorHi everyone, our wallaby cluster has v2.88 nova api version. But tempest latest version tempest 35.0.1.dev17 does have v2.79. tempest.api.compute.admin.test_live_migration.LiveMigrationTest.test_volume_backed_live_migration test fails because of schema validation when listing migrations. Is it ok to set min_microversion = 2.79 on tempest and ignore this situation? In real life will our users still use v.288? Thanks14:32
yusufgungorfail error is14:32
yusufgungor validators.py", line 1292, in validate14:32
yusufgungor    raise error14:32
yusufgungor    jsonschema.exceptions.ValidationError: Additional properties are not allowed ('project_id', 'user_id' were unexpected)14:32
dansmithgmann: what would you think about trying to change the names of some of the tempest classes to distribute them amongst the workers better?14:33
dansmithAFAICT, tons of stuff starts with S(erver) and T(est) and that seems to pile it up in the middle14:34
dansmithCould we pick some meaty classes and just try making them ZServerRescueTest and ATestSnapshot ?14:34
dansmithI mean I know it's silly, but...14:34
opendevreviewRodolfo Alonso proposed openstack/tempest master: [WIP][DNM] Test fix for LP#2027605  https://review.opendev.org/c/openstack/tempest/+/88877015:21
dansmithor maybe we break up ServerActionsTest as that seems to be the single largest test and maybe breaking it in half would be worth the overhead15:25
dansmithhmm, I guess it's not partitioning based on class name but I thought that's how it worked15:26
opendevreviewDan Smith proposed openstack/tempest master: WIP: Try splitting up ServerActionsTestJSON  https://review.opendev.org/c/openstack/tempest/+/88910915:32
opendevreviewEric Harney proposed openstack/devstack-plugin-ceph master: Drop usage of python3_enabled  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/88911015:44
opendevreviewMerged openstack/devstack stable/2023.1: The AZ filter is deprecated and planned for removal this cycle  https://review.opendev.org/c/openstack/devstack/+/88864815:51
gmanndansmith: I am not sure class name will make any difference but splitting the long tests into separate class can be benefit. But we need to be careful on non-admin test class renaming as they break interop and other users. 16:14
gmannthis has all the checks/things we need to care when we refactor the tests https://docs.openstack.org/tempest/latest/REVIEWING.html#test-removal-and-refactoring16:15
gmannHonestly saying I am waiting for this and at least it will increase the worker and the load at some level- https://review.opendev.org/c/openstack/tempest/+/88722016:15
dansmithgmann: ugh okay I didn't know we couldn't move (some) tests :(16:46
dansmithI thought the uuid was the key there not the name/location16:46
gmannyeah, that was supposed to be that way use uuid as test name/location but it did not happen and interop still using test class/test name16:47
dansmiththat kinda keeps us stuck unfortunately16:47
dansmithgmann: where's the actual list of interop tests? will codesearch show them to me?16:50
dansmithah, in interop guidelines json I guess?16:51
gmanndansmith: yes, codesearch should show if that search in openinfra/ namespace also16:51
dansmithyeah, I see16:52
gmanndansmith: here are those guidliens including the test location/name https://opendev.org/openinfra/interop/src/branch/master/guidelines16:52
gmannnext.json and a few lalest one fo 2022/21 year we can care of16:52
gmannwe have a voting job in tempest gate verify that if location of test in tempest is changed form what interop has 16:53
gmanninterop-tempest-consistency16:53
dansmithokay I see it yeah17:05
opendevreviewDan Smith proposed openstack/tempest master: WIP: Try splitting up ServerActionsTestJSON  https://review.opendev.org/c/openstack/tempest/+/88910918:07
opendevreviewAshley Rodriguez proposed openstack/devstack-plugin-ceph master: [WIP][DNM] Remote Ceph with cephadm  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/87674718:12
dansmithgmann: I assume we don't run stackviz on failed/timedout runs because we don't get a clear subunit file, but we do have the partial one18:41
dansmithI wonder if it would still work and would show us that a worker got stuck on something useful?18:41
gmanndansmith: we run i think, it is not showing? 18:42
dansmithgmann: not that I see: https://zuul.opendev.org/t/openstack/build/3f40c45857ab409aaef1583c258727ac/logs18:43
gmanndansmith: ah for job timeout, yes we do not run as that does not proceed to that role except logs collection 18:45
gmannfor test failing/ test timeout we do run it18:45
dansmithah okay18:46
dansmithgmann: I think splitting the non-interop tests out of ServerActionTestJSON is working locally.. will look at the spread of time, but I think that's got to be worth doing based on the interleaving of tests among the workers that I'm seeing19:01
dansmithversus running that whole test always on one worker19:01
gmannok19:43
opendevreviewDan Smith proposed openstack/tempest master: WIP: Try splitting up ServerActionsTestJSON  https://review.opendev.org/c/openstack/tempest/+/88910920:25
dansmithgmann: this ^ runs in 1/3 the clock time locally20:37
dansmithobviously that's just running the one class, which perfectly distributes between the workers, which won't always happen in a full run, but I bet it will help20:38
dansmithit's almost 15 minutes worth of wall time when it's running sequentially20:38
dansmithand just over five when run in that split20:39
dansmithmelwitt: ^ since you were talking about worker distribution too20:39
dansmith....and doesn't fail the interop test \o/20:39
opendevreviewGhanshyam proposed openstack/tempest master: Run slow api tests in parallel  https://review.opendev.org/c/openstack/tempest/+/88912920:42
gmanndansmith: ack. 20:43
opendevreviewGhanshyam proposed openstack/tempest master: Do not set the concurrency for tempest run  https://review.opendev.org/c/openstack/tempest/+/88722020:43
dansmithman, 66% performance improvement and just an ack, huh? :P20:43
dansmithgmann: I left a comment on the tests that are moving that I see in skip lists according to codesearch, so I dunno what to do about those, but I left it WIP as a result20:44
gmanndansmith: :) sorry I need to check, I was busy in increasing the number of worker :)20:44
dansmithhaha, I'm just giving you a heard time :P20:45
gmannsplitting test at least in server action tests is definitely good idea20:45
dansmiththere are a couple others that are pretty chunky, but not sure they will be as much gain20:46
gmannskip list of tripleO ? or pther project20:46
dansmithI'll wait to see what the stackviz looks like on this20:46
dansmithI don't remember20:46
dansmithmostly this I think: https://opendev.org/x/trio2o/src/branch/master/trio2o/tempestplugin/tempest_compute.sh20:46
dansmithI dunno what that is20:46
dansmithopenstack-operators/tempest_skip.yml 20:48
gmannI think that is vexxhost one ?20:48
gmannI remember they have one such skip list20:48
dansmithokay20:49
gmannbut we can either puch a quick patch to them to modify the location but not to wait for them to merge20:49
gmannif it is openstack then we can wait in case we break any project CI20:50
dansmithack, if this looks good on stackviz I will revise to remove WIP and those comments and make a list of all the references20:50
gmanncool. I will check that. going out now but will be back in ~2 hrs20:56
dansmitho/20:56
opendevreviewAshley Rodriguez proposed openstack/devstack-plugin-ceph master: [WIP][DNM] Remote Ceph with cephadm  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/87674721:00
opendevreviewDan Smith proposed openstack/tempest master: WIP: Try splitting up ServerActionsTestJSON  https://review.opendev.org/c/openstack/tempest/+/88910921:04
melwittdansmith: cool idea 21:16
dansmithmelwitt: still around?22:51
melwittyes22:52
dansmithokay so, here's another tempest-py3 run from earlier today:22:52
dansmithhttps://5fb6cfbc0c5c1a5be079-29e820dbac3fa779e4aa716d6c5c5850.ssl.cf1.rackcdn.com/887857/5/check/tempest-full-py3/929ccbf/controller/logs/stackviz/index.html#/stdin/timeline?test=tempest.api.compute.servers.test_server_actions.ServerActionsTestJSON.test_shelve_paused_server22:52
dansmithhere's the one from the split:22:52
dansmithhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_113/889109/4/check/tempest-full-py3/113b3e8/controller/logs/stackviz/index.html#/stdin/timeline?test=tempest.scenario.test_security_groups_basic_ops.TestSecurityGroupsBasicOps.test_cross_tenant_traffic22:52
dansmithnow, notice the scenario tests are always going to be serial at the end I think,22:52
dansmithso the odd gap in worker0 there is because we finish all the base tests and then do scenario22:53
dansmithbut I think that looks like better packing22:53
melwittoh, huh. I've never seen this graph before22:53
melwittyeah it does look better22:53
dansmithI think it's actually better than it looks too,22:55
dansmithon the other one, the gaps between the tests appear shorter, because it's more zoomed out22:56
melwittthis will be sweet if we can get better load balancing on the workers22:57
dansmithyeah if you drag the window on the bottom overview to cover everything other than the scenario block at the end, it looks even more densely packed in the parallel section22:57
dansmithlike two of the workers end up doing nothing for half the time, and one for 1/3 the time22:57
melwittoh yeah, I see. this is cool22:58
dansmithbut with the broken up test, it's much more even22:58
melwittyeah. I never thought about it before to look at the size of the classes, but it makes sense22:59
dansmithyeah23:00
dansmithI occasionally have good ideas23:00
dansmithI'm also waiting for a nova DNM based on this to see the ceph job,23:01
dansmithbecause that one does only three workers23:01
melwittlol23:01
dansmithI'm not sure if that's going to be better or worse for this23:01
opendevreviewDan Smith proposed openstack/tempest master: Split up ServerActionsTestJSON for better mixing  https://review.opendev.org/c/openstack/tempest/+/88910923:05
dansmithde-WIP'd ^23:05
dansmithwell, the nova ceph job completed in 1.5 hours, which is pretty fast23:06
dansmithworker distribution doesn't look super awesome but I need to compare to another one: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_14a/889130/1/check/nova-ceph-multistore/14a078d/controller/logs/stackviz/index.html#/stdin/timeline23:07
dansmithyeah, about the same: https://23747c8ea869a495f1ca-a232ce3bdc50fca913ceba9a1c600c62.ssl.cf2.rackcdn.com/879499/10/check/nova-ceph-multistore/1d0369b/controller/logs/stackviz/index.html#/stdin/timeline23:07
dansmithactually, looks like most of these tests don't run under the ceph job anyway, so that makes sense23:08
opendevreviewGhanshyam proposed openstack/tempest master: Run test_port_security_macspoofing_port slow tests serially  https://review.opendev.org/c/openstack/tempest/+/88912923:35
opendevreviewGhanshyam proposed openstack/tempest master: Do not set the concurrency for tempest run  https://review.opendev.org/c/openstack/tempest/+/88722023:58
melwittdansmith: did you consider doing 'stestr run --concurrency N --random' rather than the class thing? I was just looking at this which says they're sorted alphabetically in the absence of historical timing data https://stestr.readthedocs.io/en/latest/MANUAL.html#test-scheduling23:58
melwittI don't think we have or keep historical timing data between job runs but maybe I'm wrong23:59

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!