Monday, 2023-08-07

opendevreviewMerged openstack/tempest master: Add test for assisted volume snapshot  https://review.opendev.org/c/openstack/tempest/+/86483900:21
opendevreviewMaxim Sava proposed openstack/tempest master: Revert "Add image task client and image tests task APIs."  https://review.opendev.org/c/openstack/tempest/+/89049810:11
opendevreviewAlfredo Moralejo proposed openstack/devstack master: Remove wget + rpm workaround to manage repos install in CentOS  https://review.opendev.org/c/openstack/devstack/+/89064412:16
opendevreviewMerged openstack/tempest master: Skip scenario tests early to avoid unnecessary setup  https://review.opendev.org/c/openstack/tempest/+/89057313:08
opendevreviewKatarina Strenkova proposed openstack/tempest master: Skip failing tests affected by minimum password age  https://review.opendev.org/c/openstack/tempest/+/89065313:30
opendevreviewKatarina Strenkova proposed openstack/tempest master: Skip failing tests affected by minimum password age  https://review.opendev.org/c/openstack/tempest/+/89065313:33
dansmithgmann: so I rechecked the concurrency revert all weekend. I hit *one* OOM in all of that, but the majority of them all passed, with only a few hitting known issues13:42
dansmithin comparison, I and others rechecked a few other patches and hit several OOMs over the same time period (but with fewer runs)13:42
dansmithif you still think it's too early to tell, would you be willing to drop concurrency on some specific jobs and see how that goes?13:43
dansmithalso, no timeouts, FWIW, but that could be because overall load was light being the weekend13:44
dansmithactually, the one OOM it did hit had 13 (!) qemu processes running13:47
dansmithso perhaps something went haywire and we created too many servers, or we got unlucky and ran four tests at the same time that create like three servers each somehow?13:48
opendevreviewDan Smith proposed openstack/tempest master: Skip test_image_tasks_create() for bug 2030527  https://review.opendev.org/c/openstack/tempest/+/89068716:31
dansmithgmann: kopecmartin: ^ per the skip decision.. I haven't seen any other bug or attempt to skip.. blocking nova's gate now16:32
gmanndansmith: thanks, I was asking author if they have filed any bug or not.16:39
gmannthis test passed in tempest-full job but not sure why it is failing in import job or other16:40
gmanndansmith: on concurrency, I agree with the idea of reducing it in some job. let me try on tempest full (integrated job) jobs which have the most parallel tests16:41
sean-k-mooneythat specific test does not appare to creating servers so i assuem the 13 are form somehting else?16:42
sean-k-mooneyoh i guess that  a diffent topic16:42
sean-k-mooneyi was looking at the test_image_tasks_create patch16:43
sean-k-mooneybut there was a sperate concurancy change ?16:43
dansmithgmann: ++ on concurrency16:43
dansmithgmann: I saw the query and no response and found no bug, so I figured I should do it quick since it's so bad16:44
gmanndansmith: ++, thanks, 1 comment on using skip-because16:46
dansmithI just saw16:47
sean-k-mooneyoh wow 'default_concurrency: "{{ num_cores|int - 2 }}"' ya that would break alot of job16:47
sean-k-mooneyit would go form 4 to 616:48
dansmithsean-k-mooney: it doesn't break everything, but it results in us ending up with a lot of qemu processes which OOMs mysql a lot16:48
dansmithright, it went to 6 as a result16:48
sean-k-mooneyright so most of the jobs are turned to expect 416:48
sean-k-mooneyand OOM is exaclty what i woudl expect16:48
sean-k-mooneyfor jobs that dont boot vms16:49
dansmithhttps://imgur.com/a/VNHnNNi16:49
sean-k-mooneythen sure 6 might work 16:49
sean-k-mooneyshould i be concern that imgur asked if it was over 18 :P16:49
dansmithit does that all the time for screenshots now, I have no idea why16:50
opendevreviewDan Smith proposed openstack/tempest master: Skip test_image_tasks_create() for bug 2030527  https://review.opendev.org/c/openstack/tempest/+/89068716:50
sean-k-mooneyi mean that graph is a bit spice you wanot wnat to offfend the ci gods16:50
dansmithgmann: sorry I should have known about skip_because ^16:50
gmanndansmith: +W, thanks16:51
dansmithgmann: thanks16:52
sean-k-mooneyfor what its worth increaseing the default concurancy is not nessiarly a bad idea16:52
sean-k-mooneyi think we just need to clamp some of the jobs in nova and perhaps other porjects first16:53
dansmithsean-k-mooney: we just did a bunch of work to pack the workers tighter so we make better use of the concurrency we have, which made a big difference for the timeouts16:53
dansmithsean-k-mooney: I suggested a tempest semaphore for server boots, so we can say "no more than 4 at a time" or something16:53
dansmithwithout dynamic worker loading in testr that will likely generate some long waits though16:53
sean-k-mooneyhum thats interesting it might work although it could also cause timeouts16:54
sean-k-mooneyunless we tagged the tests that create servers16:54
sean-k-mooneyi.e. dont allow the test to start until there is space16:54
dansmithyup, but that's really what we want.. to limit the number of servers in parallel.. test concurrency is just a guess/race/approximation16:54
dansmithand it results in us wasting time we could be using more cpus otherwise16:54
dansmithright, we'd need to say "this test needs 3 from the semaphore"16:55
sean-k-mooneyya which we could probaly do with a decorator16:55
dansmithbut still, that test will wait and not do any more useful work on that worker until it gets it without dynamic scheduling16:55
sean-k-mooneyalthough som times the creation happens in setup16:55
sean-k-mooneyso we might need to decorate the class in that case16:55
dansmithwe'd have to handle it in class setup16:55
sean-k-mooneyya16:55
sean-k-mooneythe test scheduling is static correct. i.e. we can tweak the allcoation to workser when we first invoke tempest but cant dynmaically schedule after that?16:57
sean-k-mooneyim kind of wondeiring if we could tag all tests that create vms and have them handled by a singel worker until the other works finish all the ohter test. and then only start allocating the vm test to them at that point16:58
dansmithmtreinish has an old PR to make it dynamic16:58
dansmithbut I think it's a ways off16:58
dansmithwe can also try upping the swap to 8G like the ceph job.. the ceph job is restricted to concurrency=3 and has swap=8G17:00
sean-k-mooneyya the memory pressure shoudl have reduced now that we are using the qemu cache size setting17:00
dansmithI worry about more swap taking more IO which we're also *definitely* hitting our limit on, but n=4 and swap=8G might be better than what we had before for the odd OOM17:00
sean-k-mooneybut more swap wont hurt17:00
sean-k-mooneywell on that front17:01
sean-k-mooneyi have been meaning to look into adding zswap or zram17:01
sean-k-mooneyto ci17:01
dansmithyeah, I was wondering about KSM too, since we boot a bunch of instances that are the exact same17:01
sean-k-mooneythats trading cpu for disk ioi but i thikn zswap could help mask that17:01
sean-k-mooneyksm is interesting in principal your  right we shoudl eb able to get good deduplicaiton17:02
sean-k-mooneyi have not used it personally17:02
sean-k-mooneyso in practice im not sure if we would see a noticibale effect17:02
dansmithit was designed for this sort of workload17:03
dansmithI think it didn't really pan out for general usage as much as expected, but I think that's because over time identical guests diverge too much17:03
sean-k-mooneyyes althouguh mainly on a host i dont knwo if the same works when we have nested virt17:03
dansmithbut our guests are short-lived and a lot less busy than normal17:03
sean-k-mooneyprovided we dont have ksm also on the host of the zuul vm17:03
sean-k-mooneyi would expect it to be worth a try17:04
dansmithKSM works independent of virtualization17:04
sean-k-mooneyit shoudl i would just be workied of the host and our vm both deduping and spliting the same page17:04
sean-k-mooneystill worth a try and see17:05
dansmithidk why that would matter so much really, but yeah17:05
sean-k-mooneyi had code for zswap somewhere in the past i started pocing it as part of https://review.opendev.org/c/openstack/devstack/+/828639. i can give that a try on thursday or next week and let you know when its up for review if you like17:08
sean-k-mooneywhen i got devstack running on my m1 macbook air i was using zswap on debian bookworm + the venv patches cobbled together locally17:10
opendevreviewGhanshyam proposed openstack/tempest master: Setting Tempest run concurrency to 4 for a few jobs  https://review.opendev.org/c/openstack/tempest/+/89068917:12
sean-k-mooneyi think i just did that by hand however rather then coding it up in devstack.17:12
gmanndansmith: sean-k-mooney ^^ setting it to 4 for highly loaded jobs17:12
dansmithkopecmartin: ^17:13
dansmithgmann: thanks17:13
dansmithvfat change is very close to merging17:14
dansmithjust running the last scenario tests in the scope test17:14
sean-k-mooneyvfat?17:14
sean-k-mooneyas in for configdrive?17:14
dansmithsean-k-mooney: for the stamp test thing, to try to work around mke2fs occasionally going off the rails17:14
sean-k-mooneyoh hehe ok17:15
sean-k-mooneyim not sure why vfat would be any faster but if it is cool17:16
dansmithmkfs.vfat writes a lot less to the disk to make it usable for us to write 32 bytes to for the test17:16
sean-k-mooneyi guess no journal 17:16
dansmithit's way faster17:16
dansmithand doesn't use any barriers for normal writes 17:16
dansmithyeah17:16
sean-k-mooneyya so like ext217:16
dansmithwe'll see .. if it doesn't help then meh, but if it does then cool17:16
dansmithI think it's substantially lighter weight than ext2 as well17:16
sean-k-mooneycool well we still use it optionally for config drive instead of iso17:17
dansmithI thought about not even using a filesystem and just writing some bytes to the block device ;)17:17
sean-k-mooneyso its not like vfat is going anywhere17:17
JayFfat is a filesystem built on hope so that's pretty close to the same thing Dan ;) 17:17
dansmithyup17:17
gmanndansmith: anything I have not reviewed the one we discussed last week. I might be online for another 1 hr only. its holiday here and I am not supposed to be working :)17:17
JayFjust mark on the sheet where you put the data and we'll trust you ;) 17:17
dansmithgmann: go away then!17:17
dansmithJayF: well, compared to zfs, ext4 isn't much better in that department :)17:18
sean-k-mooneysameish  but i arragend 2 meetign for today because i forgot so taking friday off instead.17:18
gmann:) finishing up a few downstream things17:18
dansmithgmann: sorry if my pings earlier drug you in. I didn't know you were supposed to be off17:19
gmannno, while doing that I thought of checking here and gate things. specially task test17:20
dansmithack17:20
dansmithI spent way too much time this weekend rechecking and looking at logs for sure17:22
sean-k-mooneydansmith: it looks liek ksm is ksmtuned on ubuntu, debian and centos 9 stream and its in the main/appstream repos17:24
sean-k-mooneyso i can  include isntalling that in my zswap patch 17:24
dansmithksm is a kernel function, but maybe enabled by those?17:24
opendevreviewMerged openstack/tempest master: Use vfat for timestamp  https://review.opendev.org/c/openstack/tempest/+/89035017:25
dansmithah yeah, enabled and managed by ksmtuned17:25
sean-k-mooneyya17:25
sean-k-mooneyi dont really know how to configre it so i assume its default will just work17:26
sean-k-mooneybut i can take a look17:26
dansmiththere are thresholds that control how much it tries I think17:26
sean-k-mooneyi assume like vm.swapieness17:26
dansmithenabling it is probably better than nothing, but we would likely benefit from some aggressive tunes17:26
dansmithyeah17:26
sean-k-mooneyso fro zswap ther is a great block on how they got ubuntu desktop to work on a 2G rasberry pi17:27
sean-k-mooneyhttps://www.omgubuntu.co.uk/2022/01/ubuntu-on-raspberry-pi-4-2gb-zswap and and https://ubuntu.com//blog/how-low-can-you-go-running-ubuntu-desktop-on-a-2gb-raspberry-pi-417:27
sean-k-mooneynot sure if tose still load but i was goign to use those as reffence for turnign zswap ill see if there is somehting simialr for ksm17:28
dansmithmaybe we should have zmem, zswap, and ksm all as separate knobs and spread out the testing a bit :)17:28
sean-k-mooneyi can add them as diffent commtis/nobs ya and then have some dnm patche on top that turns them on17:29
sean-k-mooneydansmith: truns out ksm is already partly enabled in devstack18:36
sean-k-mooneyhttps://github.com/openstack/devstack/commit/f85e0ba353c71fc5c8bacebe006e68bebf2af02418:36
sean-k-mooneythat enabels ksm but without the tuning deamon18:36
dansmithah, okay18:46
sean-k-mooneyif im reading the comment correclty it would only help if the ap mmaped the paages as mergabel18:46
sean-k-mooneyand i dont know if anything will do that by default18:46
sean-k-mooneywhich iassume is what ksmtuned can do18:47
dansmithidk, I didn't think you needed to do that.. any readonly (or not yet CoW'd) page should be a candidate I'd think18:50
sean-k-mooneyperhaps in any case its enabeld out of the box since 2017 with devstack18:51
dansmithack18:51
opendevreviewsean mooney proposed openstack/devstack master: [WIP] add support for zswap and ksmtuned  https://review.opendev.org/c/openstack/devstack/+/89069319:38
sean-k-mooneydansmith: ^ i still have that running locally but im going to finish for today.19:39
sean-k-mooneythat is based on top of the venv change just becasue that is what im using locally to deploy19:39
opendevreviewAshley Rodriguez proposed openstack/devstack-plugin-ceph master: Remote Ceph with cephadm  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/87674720:03
dansmithugh, that skip fix failed again20:36
opendevreviewMerged openstack/devstack-plugin-ceph master: [CI] Drop overrides in cephfs-nfs job  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/88262522:01
opendevreviewsean mooney proposed openstack/devstack master: [WIP] add support for zswap and ksmtuned  https://review.opendev.org/c/openstack/devstack/+/89069322:06
opendevreviewsean mooney proposed openstack/devstack master: [WIP] add support for zswap and ksmtuned  https://review.opendev.org/c/openstack/devstack/+/89069322:29
opendevreviewsean mooney proposed openstack/devstack master: [WIP] add support for zswap and ksmtuned  https://review.opendev.org/c/openstack/devstack/+/89069322:31

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!