yadnesh | Can someone please review https://review.opendev.org/c/openstack/devstack/+/896215 & https://review.opendev.org/c/openstack/devstack/+/896762 | 04:47 |
---|---|---|
*** kopecmartin|off is now known as kopecmartin | 07:04 | |
opendevreview | Merged openstack/devstack master: CI: Make bookworm platform job voting https://review.opendev.org/c/openstack/devstack/+/895871 | 10:43 |
opendevreview | Merged openstack/tempest master: Add Tempest gate job for stable/2023.2 https://review.opendev.org/c/openstack/tempest/+/896826 | 10:43 |
opendevreview | Lukas Piwowarski proposed openstack/tempest master: Revert "Revert "Fix cleanup for volume backup tests"" https://review.opendev.org/c/openstack/tempest/+/896011 | 11:23 |
opendevreview | Katarina Strenkova proposed openstack/tempest master: Add unit tests to increase coverage https://review.opendev.org/c/openstack/tempest/+/893080 | 13:11 |
opendevreview | Luigi Dino Tamagnone proposed openstack/tempest master: Adding a new config option in tempest.conf as the prefix for the random name resources https://review.opendev.org/c/openstack/tempest/+/897231 | 14:12 |
kopecmartin | #startmeeting qa | 15:00 |
opendevmeet | Meeting started Tue Oct 3 15:00:17 2023 UTC and is due to finish in 60 minutes. The chair is kopecmartin. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
opendevmeet | The meeting name has been set to 'qa' | 15:00 |
kopecmartin | #link https://wiki.openstack.org/wiki/Meetings/QATeamMeeting#Agenda_for_next_Office_hours | 15:00 |
kopecmartin | agenda ^^^^ | 15:00 |
lpiwowar | o/ | 15:01 |
kopecmartin | #topic Announcement and Action Item (Optional) | 15:01 |
kopecmartin | we're in the release time | 15:02 |
kopecmartin | patches proposed by gmann | 15:02 |
kopecmartin | #link https://review.opendev.org/q/topic:qa-2023-2-release+status:open | 15:02 |
kopecmartin | #link https://review.opendev.org/q/topic:qa-2023-2-release+ | 15:03 |
kopecmartin | https://review.opendev.org/q/topic:qa-2023-2-release | 15:03 |
kopecmartin | ah | 15:03 |
kopecmartin | #link https://review.opendev.org/q/topic:qa-2023-2-release+ | 15:03 |
kopecmartin | .... | 15:03 |
kopecmartin | we released tempest 36.0.0 last week | 15:03 |
kopecmartin | gmann, anything I should do related to release process? thank you for proposing all the patches btw | 15:04 |
kopecmartin | moving on | 15:05 |
kopecmartin | #topic Bobcat Priority Items progress | 15:05 |
kopecmartin | #link https://etherpad.opendev.org/p/qa-bobcat-priority | 15:05 |
kopecmartin | not many updates .. we'll triage that during PTG | 15:06 |
kopecmartin | #topic OpenStack Events Updates and Planning | 15:06 |
kopecmartin | the next PTG will be held virtually, October 23-27, 2023 | 15:06 |
kopecmartin | you can propose topics that we will discuss during PTG here | 15:07 |
kopecmartin | #link https://etherpad.opendev.org/p/oct2023-ptg-qa | 15:07 |
kopecmartin | don't forget to register .. | 15:07 |
kopecmartin | #link http://ptg2023.openinfra.dev/ | 15:07 |
kopecmartin | you may also influence dates of QA PTG sessions, just fill this: | 15:08 |
kopecmartin | #link https://framadate.org/f26R3EcZ2BOo7r8Q | 15:08 |
kopecmartin | #topic Gate Status Checks | 15:08 |
kopecmartin | #link https://review.opendev.org/q/label:Review-Priority%253D%252B2+status:open+(project:openstack/tempest+OR+project:openstack/patrole+OR+project:openstack/devstack+OR+project:openstack/grenade) | 15:09 |
kopecmartin | nothing there, anything urgent to review? | 15:09 |
lpiwowar | I know we discussed it already here. This change was reverted https://review.opendev.org/c/openstack/tempest/+/894269 because when ceph is used as a backup driver we can not use the "container" parameter in the API call. I was wondering whether it would be ok to create new config option that will indicate what backup_driver is used by cinder. | 15:09 |
lpiwowar | I just wanted to mention it here kopecmartin. | 15:09 |
kopecmartin | sure, why not? | 15:10 |
lpiwowar | Because last time we talked about it someone was against the new option. I do not remember who. | 15:11 |
lpiwowar | I can maybe check the logs. | 15:11 |
kopecmartin | me neither, i don't remember the discussion at all :D | 15:11 |
kopecmartin | yeah | 15:11 |
lpiwowar | I understand :D | 15:11 |
kopecmartin | check that and we can discuss that in Open Discussion | 15:12 |
kopecmartin | #topic Bare rechecks | 15:12 |
lpiwowar | kopecmartin: +1 | 15:12 |
kopecmartin | #link https://etherpad.opendev.org/p/recheck-weekly-summary | 15:12 |
kopecmartin | all good here .. although interesting number - the QA team has the biggest number of rechecks over the last 90 days | 15:13 |
kopecmartin | #topic Periodic jobs Status Checks | 15:13 |
kopecmartin | periodic stable full | 15:13 |
kopecmartin | #link https://zuul.openstack.org/builds?pipeline=periodic-stable&job_name=tempest-full-yoga&job_name=tempest-full-xena&job_name=tempest-full-zed&job_name=tempest-full-2023-1&job_name=tempest-full-2023-2 | 15:13 |
kopecmartin | periodic stable slow | 15:13 |
kopecmartin | #link https://zuul.openstack.org/builds?job_name=tempest-slow-2023-2&jjob_name=tempest-slow-2023-1&job_name=tempest-slow-zed&job_name=tempest-slow-yoga&job_name=tempest-slow-xena | 15:13 |
kopecmartin | periodic extra tests | 15:13 |
kopecmartin | #link https://zuul.openstack.org/builds?job_name=tempest-full-2023-2-extra-tests&job_name=tempest-full-2023-1-extra-tests&job_name=tempest-full-zed-extra-tests&job_name=tempest-full-yoga-extra-tests&job_name=tempest-full-xena-extra-tests | 15:13 |
kopecmartin | periodic master | 15:13 |
kopecmartin | #link https://zuul.openstack.org/builds?project=openstack%2Ftempest&project=openstack%2Fdevstack&pipeline=periodic | 15:13 |
kopecmartin | all seems as expected | 15:15 |
kopecmartin | #topic Distros check | 15:16 |
kopecmartin | cs-9 | 15:16 |
kopecmartin | #link https://zuul.openstack.org/builds?job_name=tempest-full-centos-9-stream&job_name=devstack-platform-centos-9-stream&skip=0 | 15:16 |
kopecmartin | debian | 15:16 |
kopecmartin | #link https://zuul.openstack.org/builds?job_name=devstack-platform-debian-bullseye&job_name=devstack-platform-debian-bookworm&skip=0 | 15:16 |
kopecmartin | rocky | 15:16 |
kopecmartin | #link https://zuul.openstack.org/builds?job_name=devstack-platform-rocky-blue-onyx | 15:16 |
kopecmartin | openEuler | 15:16 |
kopecmartin | #link https://zuul.openstack.org/builds?job_name=devstack-platform-openEuler-22.03-ovn-source&job_name=devstack-platform-openEuler-22.03-ovs&skip=0 | 15:16 |
kopecmartin | jammy | 15:16 |
kopecmartin | #link https://zuul.opendev.org/t/openstack/builds?job_name=devstack-platform-ubuntu-jammy-ovn-source&job_name=devstack-platform-ubuntu-jammy-ovs&skip=0 | 15:16 |
* kopecmartin still checking the results | 15:19 | |
kopecmartin | i see a few failures that happened last week but i vaguely remember there were known failures due to all the releases that are happening right now .. | 15:21 |
kopecmartin | seems like now it's all on track | 15:21 |
kopecmartin | #topic Sub Teams highlights | 15:21 |
kopecmartin | Changes with Review-Priority == +1 | 15:21 |
kopecmartin | #link https://review.opendev.org/q/label:Review-Priority%253D%252B1+status:open+(project:openstack/tempest+OR+project:openstack/patrole+OR+project:openstack/devstack+OR+project:openstack/grenade) | 15:21 |
kopecmartin | no patches | 15:21 |
kopecmartin | #topic Open Discussion | 15:21 |
kopecmartin | anything for the open discussion? | 15:22 |
lpiwowar | Nothing from my side:) | 15:23 |
kopecmartin | did you find who was objecting the approach in your patch? | 15:24 |
kopecmartin | #link https://meetings.opendev.org/meetings/qa/2023/ | 15:25 |
lpiwowar | Not yet ... | 15:25 |
kopecmartin | no idea when we could discuss that :/ | 15:25 |
lpiwowar | I'm not able to find the correct meeting. It was long time ago | 15:25 |
lpiwowar | yeah :/ | 15:25 |
kopecmartin | here | 15:28 |
kopecmartin | #link https://meetings.opendev.org/meetings/qa/2023/qa.2023-08-01-15.00.log.html | 15:28 |
lpiwowar | Thanks! I was searching for "config" | 15:29 |
lpiwowar | It looks like you were against it and dansmith. | 15:30 |
lpiwowar | But I remember that I agreed with you. | 15:30 |
dansmith | which patch was I against? | 15:30 |
lpiwowar | Against a new config option to tempest. The option would tell what backup driver is used by cinder. It would help us to do a proper clean up for volume backup tests. | 15:31 |
lpiwowar | We are talking about this patch: | 15:32 |
kopecmartin | the original LP: | 15:32 |
kopecmartin | #link https://bugs.launchpad.net/cinder/+bug/2028671 | 15:32 |
lpiwowar | #link https://review.opendev.org/c/openstack/tempest/+/890798 | 15:32 |
kopecmartin | .. but we had to revert that because of a new LP: | 15:33 |
kopecmartin | #link https://bugs.launchpad.net/tempest/+bug/2034913 | 15:33 |
kopecmartin | so we're practically at the beginning | 15:33 |
dansmith | okay I don't see me on any of that and don't recall any such conversation | 15:33 |
* kopecmartin still loads the context of the issue | 15:34 | |
kopecmartin | lpiwowar: please imlement it as you think is right, we'll discuss that during review, as always :) | 15:34 |
lpiwowar | The conversation is here: | 15:34 |
lpiwowar | #link https://meetings.opendev.org/meetings/qa/2023/qa.2023-08-01-15.00.log.html | 15:34 |
lpiwowar | kopecmartin: ok:) | 15:35 |
kopecmartin | it's always easier to discuss a specific solution if it is executed in the CI - we have a proof it works etc | 15:35 |
kopecmartin | ou, i'm starting to remember , lpiwowar you wanted to create a new opt just becuase of the cleanup, not a test | 15:36 |
kopecmartin | that's strange | 15:36 |
kopecmartin | and not a good approach | 15:37 |
lpiwowar | This is how it would look like: https://review.opendev.org/c/openstack/tempest/+/896011/8/tempest/api/volume/base.py | 15:37 |
lpiwowar | Yeah, I agree. It is strange. But currently I'm not sure how to do it without it. | 15:37 |
lpiwowar | The issue is line 197 (previous link). I want to add this option only when Swift is used as a backup driver. | 15:38 |
kopecmartin | does the patch only revert the previous patch or are there some modifications on top of that? | 15:39 |
kopecmartin | can't we add 2 addCleanups? .. one for when swift is used the other if it isn't .. one will always fail but we can ignore that failure | 15:39 |
lpiwowar | I'm little bit lost in the all patches. I do not know which one do you mean right now :D. | 15:40 |
kopecmartin | the one you shared | 15:40 |
lpiwowar | If I understand the issue correctly it will not work. | 15:40 |
lpiwowar | But the issue is not in the clean up but in the creation of the backup itself. | 15:41 |
lpiwowar | When Swift is used as a backup driver we want to be able to tell through the API that we want the backup to be stored in a specific container. | 15:42 |
lpiwowar | So that we can clean it up properly later. | 15:42 |
kopecmartin | oh, ok , i see it now | 15:42 |
lpiwowar | It works fine when Swift is enabled. But when Ceph is used as a backup driver we get an error because Ceph does not understand the concept of container. | 15:42 |
lpiwowar | ok:) | 15:43 |
kopecmartin | there is one danger in that, we will have 2 testing paths - when swift is enabled (or whatever) we create the container with different options | 15:43 |
kopecmartin | not saying it's an issue, it's just something that needs to be taken into account | 15:43 |
kopecmartin | ... in this case, it seems like another config opt makes sense | 15:44 |
kopecmartin | however | 15:44 |
kopecmartin | new config opt means new opt that needs to be set by the user as well as our jobs in the CI .. so, if we go that way, how many jobs will we need to edit? | 15:45 |
lpiwowar | Well I was thinking that we can set it by default to ceph. This should not influence any job because we will have a different behaviour only when Swift is used as a backup driver. | 15:46 |
lpiwowar | And for the jobs which use Swift as a backup driver I think we can update devstack/lib/tempest file so that it updates tempest.conf with the correct option (?)/ | 15:46 |
kopecmartin | sounds good, that would work | 15:47 |
lpiwowar | Ok, awesome:) | 15:47 |
kopecmartin | just avoid stating smth like this "adding new option to cleanup container properly" .. it's more like adding a new option so that we can create a resource properly and avoid cleanup issues | 15:48 |
lpiwowar | Ack, I understand | 15:49 |
kopecmartin | also address https://bugs.launchpad.net/tempest/+bug/2034913 in your patch https://review.opendev.org/c/openstack/tempest/+/896011 .. and maybe it would be better to change the title as it's not a pure revert | 15:50 |
kopecmartin | it's more like a second try to resolve the original LP | 15:50 |
kopecmartin | while taking the new LP into account | 15:51 |
kopecmartin | #topic Bug Triage | 15:51 |
lpiwowar | Ack | 15:51 |
kopecmartin | #link https://etherpad.openstack.org/p/qa-bug-triage-bobcat | 15:51 |
kopecmartin | numbers recorded, that's unfortunately all i had time for | 15:51 |
kopecmartin | that's all from my side | 15:51 |
kopecmartin | anything else? | 15:52 |
lpiwowar | Nothing from my side | 15:52 |
kopecmartin | cool, than we're done for today .. | 15:52 |
kopecmartin | thanks | 15:52 |
kopecmartin | #endmeeting | 15:52 |
opendevmeet | Meeting ended Tue Oct 3 15:52:56 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:52 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/qa/2023/qa.2023-10-03-15.00.html | 15:52 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/qa/2023/qa.2023-10-03-15.00.txt | 15:52 |
opendevmeet | Log: https://meetings.opendev.org/meetings/qa/2023/qa.2023-10-03-15.00.log.html | 15:52 |
lpiwowar | thanks kopecmartin | 15:54 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!