opendevreview | OpenStack Proposal Bot proposed openstack/devstack master: Updated from generate-devstack-plugins-list https://review.opendev.org/c/openstack/devstack/+/900388 | 03:04 |
---|---|---|
opendevreview | yatin proposed openstack/devstack master: [DNM] Debug osc keyring issue #2042943 https://review.opendev.org/c/openstack/devstack/+/900395 | 08:00 |
opendevreview | Luigi Dino Tamagnone proposed openstack/tempest master: Adding a new config option in tempest.conf as the prefix for the random name resources https://review.opendev.org/c/openstack/tempest/+/897231 | 09:18 |
opendevreview | sean mooney proposed openstack/devstack master: add support for zswap and ksmtuned https://review.opendev.org/c/openstack/devstack/+/890693 | 12:52 |
opendevreview | sean mooney proposed openstack/devstack master: add support for zswap and ksmtuned https://review.opendev.org/c/openstack/devstack/+/890693 | 12:56 |
opendevreview | Luigi Dino Tamagnone proposed openstack/tempest master: Adding a new config option in tempest.conf as the prefix for the random name resources https://review.opendev.org/c/openstack/tempest/+/897231 | 13:06 |
sean-k-mooney | clarkb: stephenfin .... | 13:08 |
sean-k-mooney | so | 13:09 |
sean-k-mooney | with the new pbr release we nolonge rseam to be gettign the warnign about not supportign editbale installs | 13:09 |
sean-k-mooney | but its also not producing the wsgi files | 13:10 |
sean-k-mooney | so the tox envs are now passing but tempest is now failing | 13:11 |
sean-k-mooney | if i do ../.venv-test/bin/python -m build --wheel ../ | 13:14 |
sean-k-mooney | form a temp build subdir in nova | 13:14 |
sean-k-mooney | with my pyproject.toml change | 13:14 |
sean-k-mooney | i see | 13:15 |
sean-k-mooney | adding 'nova-28.1.0.dev39.data/scripts/nova-api-wsgi' | 13:15 |
sean-k-mooney | adding 'nova-28.1.0.dev39.data/scripts/nova-metadata-wsgi' | 13:15 |
sean-k-mooney | so they are being added to the wheel | 13:15 |
sean-k-mooney | so im wondering if the location they are being installed into has changed or something like that | 13:16 |
sean-k-mooney | lib/python3.11/site-packages/nova-28.1.0.dev39.dist-info/RECORD in the vnev has the console scripts but not the wsgi scripts | 13:22 |
sean-k-mooney | https://termbin.com/7u64 | 13:22 |
stephenfin | In case it's useful, I added a debugging utility to the pyproject_api package, which is another implementation of the PEPs (used by tox) | 13:26 |
stephenfin | https://github.com/tox-dev/pyproject-api/commit/1a95eccb73940990fb058d76be9d2cf5019951e1 | 13:26 |
sean-k-mooney | im currently catureing verbose install logs ill post them shortly | 13:28 |
sean-k-mooney | the right versions of pbr are being used but its not cleare why the gap is | 13:28 |
sean-k-mooney | https://termbin.com/sp7a | 13:28 |
sean-k-mooney | hum that not very useful | 13:30 |
sean-k-mooney | i also apprently did not properly redirect all out put so ill try that agin | 13:31 |
sean-k-mooney | hum no i used 2>&1 | 13:31 |
stephenfin | sean-k-mooney: if I do `pip install --no-build-isolation -e .` from the nova repo with your change and a venv that already has the latest pbr, setuptools and pip, I see the wsgi scripts present in `.venv/bin` | 13:32 |
sean-k-mooney | im doing it in a clean venv | 13:32 |
stephenfin | actually, no I don't. damn | 13:32 |
stephenfin | nova-api- != nova-api-wsgi | 13:32 |
sean-k-mooney | yep | 13:33 |
sean-k-mooney | the first is the console script | 13:33 |
frickler | which distro is this? iirc kopecmartin once found the wsgi scripts in ~/.local somewhere instead of in the venv | 13:34 |
stephenfin | Debian for sean-k-mooney presumably. Fedora for me | 13:35 |
sean-k-mooney | debina sid ya currently | 13:35 |
sean-k-mooney | this is failing in the ubuntu 22.04 ci jobs | 13:35 |
stephenfin | This is all stemming from our attempts to add pyproject.toml files | 13:35 |
sean-k-mooney | although i think right now this might only be failingin on the patches adding pyproject.toml | 13:36 |
sean-k-mooney | ok redirect is working now i can give better logs | 13:36 |
sean-k-mooney | we are still showign some warnings | 13:36 |
sean-k-mooney | https://termbin.com/7oju | 13:37 |
sean-k-mooney | im wondiering if its related to the wsgi files being consider data files? | 13:38 |
stephenfin | :( https://github.com/pypa/setuptools/blob/main/setuptools/config/pyprojecttoml.py#L338-L339 | 13:40 |
sean-k-mooney | dont we override that | 13:42 |
stephenfin | So setuptools has special code to handle console_scripts. My random guess is the old stuff where we wrap distutils methods is no longer used with the pyproject stuff | 13:42 |
stephenfin | i.e. this https://opendev.org/openstack/pbr/src/branch/master/pbr/packaging.py#L458 | 13:43 |
sean-k-mooney | right i dont think dist utils is used any more | 13:43 |
sean-k-mooney | yes | 13:43 |
sean-k-mooney | that is why we went down the the pyproject.toml approch | 13:43 |
stephenfin | This is starting to feel like a lot of work to fix | 13:43 |
sean-k-mooney | that was the first ting if found. i.e. that was not being called | 13:44 |
sean-k-mooney | its not being installed because we are now buildign the wheel | 13:44 |
sean-k-mooney | and then installign that wheel instead of doing a local install | 13:44 |
stephenfin | well we're building an editable wheel, which is different | 13:45 |
sean-k-mooney | i orgianlly tried to fix it by removign this if https://opendev.org/openstack/pbr/src/branch/master/pbr/packaging.py#L493 | 13:45 |
sean-k-mooney | so before the editibale patch | 13:45 |
sean-k-mooney | the wheel we were building was being installe in editbale mode properly | 13:45 |
sean-k-mooney | on most envs | 13:45 |
sean-k-mooney | just not when using a non default python version | 13:46 |
sean-k-mooney | we likely need to exiplictly loop over the wsgi_scripts | 13:46 |
sean-k-mooney | and install them ourselves in pbr | 13:46 |
sean-k-mooney | 13:49 | |
sean-k-mooney | can we overriede _obtain_entry_points | 13:49 |
stephenfin | We can, but they have a big warning at the top of the file indicating that it's private | 13:51 |
stephenfin | which means that's not going to be a stable target | 13:51 |
stephenfin | don't fancy building our house on sand | 13:51 |
sean-k-mooney | well wsgi_scripts is a pbr extention | 13:51 |
sean-k-mooney | not a facilaty provided by setup tools | 13:51 |
sean-k-mooney | so we need to figure out how we want to supprot that | 13:52 |
sean-k-mooney | its understandable that setup tools woudl not handel somethign we are suporting as a feature of pbr | 13:53 |
sean-k-mooney | but im not sure if the issue is with the wheel buildign or the wheel install | 13:54 |
sean-k-mooney | so the editable wheel that is built by pip just has https://termbin.com/eqsf | 14:25 |
sean-k-mooney | which is fine but the issue is that nothing is actully generating and installing the wsgi_scripts in that case | 14:26 |
sean-k-mooney | where as without the editable support we were buildign a normal wheel and then the fall back was installing that and overlaying the editable whel fiels after | 14:26 |
opendevreview | Ashley Rodriguez proposed openstack/devstack-plugin-ceph master: [WIP] Add ingress deamon https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/900348 | 14:26 |
sean-k-mooney | frickler: clarkb any ideas how to make pbr do that or any suggestings as to how to adress this? | 14:27 |
sean-k-mooney | i think that is what https://opendev.org/openstack/pbr/src/branch/master/pbr/packaging.py#L493-L498 was prehasp trying to do before | 14:28 |
sean-k-mooney | ya it is | 14:29 |
sean-k-mooney | https://opendev.org/openstack/pbr/src/branch/master/pbr/packaging.py#L462-L472 | 14:29 |
opendevreview | James Parker proposed openstack/whitebox-tempest-plugin master: [WIP] Add global nodes variable https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/884903 | 14:34 |
dansmith | kopecmartin: gmann: frickler: this fixes a sporadic failure in one of our grenade jobs due to one node not having all the services we actually need: https://review.opendev.org/c/openstack/grenade/+/900257 | 14:37 |
sean-k-mooney | perhaps we need to implement https://github.com/abravalheri/setuptools/blob/main/setuptools/_distutils/command/build_scripts.py | 14:46 |
opendevreview | Luigi Dino Tamagnone proposed openstack/tempest master: Adding a new config option in tempest.conf as the prefix for the random name resources https://review.opendev.org/c/openstack/tempest/+/897231 | 15:49 |
opendevreview | Jakub Skunda proposed openstack/tempest master: Add scenario test: test instances with cinder volumes https://review.opendev.org/c/openstack/tempest/+/898732 | 16:56 |
kopecmartin | #startmeeting qa | 17:00 |
opendevmeet | Meeting started Wed Nov 8 17:00:16 2023 UTC and is due to finish in 60 minutes. The chair is kopecmartin. Information about MeetBot at http://wiki.debian.org/MeetBot. | 17:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 17:00 |
opendevmeet | The meeting name has been set to 'qa' | 17:00 |
kopecmartin | #link https://wiki.openstack.org/wiki/Meetings/QATeamMeeting#Agenda_for_next_Office_hours | 17:00 |
lpiwowar | o/ | 17:01 |
kopecmartin | o/ | 17:01 |
kopecmartin | #topic Announcement and Action Item (Optional) | 17:01 |
kopecmartin | we have a new schedule of office hour | 17:01 |
kopecmartin | it's gonna alternate, odd weeks Wednesdays at 17:00 UTC (like today) | 17:02 |
kopecmartin | even weeks Tuesdays at 15:00 UTC (practically as before) | 17:02 |
kopecmartin | the reason is to accommodate multiple time zones | 17:02 |
lpiwowar | +1 | 17:02 |
kopecmartin | #topic Caracal Priority Items progress | 17:03 |
kopecmartin | #link https://etherpad.opendev.org/p/qa-caracal-priority | 17:03 |
kopecmartin | ^^ the priority etherpad for this cycle | 17:03 |
kopecmartin | all unfinished items from previous etherpad were copied to this one | 17:03 |
kopecmartin | #topic OpenStack Events Updates and Planning | 17:04 |
kopecmartin | we had a virtual PTG 2 weeks ago | 17:04 |
kopecmartin | agenda: | 17:04 |
kopecmartin | #link https://etherpad.opendev.org/p/oct2023-ptg-qa | 17:04 |
kopecmartin | a summary was also sent to the ML | 17:06 |
kopecmartin | #link https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/message/WTWU6N77AQS7QHAI6EDD5SHNRNZE4VH6/ | 17:06 |
kopecmartin | #topic Gate Status Checks | 17:07 |
kopecmartin | #link https://review.opendev.org/q/label:Review-Priority%253D%252B2+status:open+(project:openstack/tempest+OR+project:openstack/patrole+OR+project:openstack/devstack+OR+project:openstack/grenade) | 17:07 |
kopecmartin | any urgent reviews? | 17:07 |
kopecmartin | #topic Sub Teams highlights | 17:08 |
kopecmartin | Changes with Review-Priority == +1 | 17:08 |
kopecmartin | #link https://review.opendev.org/q/label:Review-Priority%253D%252B1+status:open+(project:openstack/tempest+OR+project:openstack/patrole+OR+project:openstack/devstack+OR+project:openstack/grenade) | 17:08 |
kopecmartin | one priority patch | 17:08 |
kopecmartin | already workflowed | 17:08 |
kopecmartin | let's get to usual, jobs status | 17:09 |
kopecmartin | #topic Periodic jobs Status Checks | 17:09 |
kopecmartin | periodic stable full | 17:09 |
kopecmartin | #link https://zuul.openstack.org/builds?pipeline=periodic-stable&job_name=tempest-full-yoga&job_name=tempest-full-xena&job_name=tempest-full-zed&job_name=tempest-full-2023-1&job_name=tempest-full-2023-2 | 17:09 |
kopecmartin | periodic stable slow | 17:09 |
kopecmartin | #link https://zuul.openstack.org/builds?job_name=tempest-slow-2023-2&jjob_name=tempest-slow-2023-1&job_name=tempest-slow-zed&job_name=tempest-slow-yoga&job_name=tempest-slow-xena | 17:09 |
kopecmartin | periodic extra tests | 17:09 |
kopecmartin | #link https://zuul.openstack.org/builds?job_name=tempest-full-2023-2-extra-tests&job_name=tempest-full-2023-1-extra-tests&job_name=tempest-full-zed-extra-tests&job_name=tempest-full-yoga-extra-tests&job_name=tempest-full-xena-extra-tests | 17:09 |
kopecmartin | periodic master | 17:09 |
kopecmartin | #link https://zuul.openstack.org/builds?project=openstack%2Ftempest&project=openstack%2Fdevstack&pipeline=periodic | 17:09 |
kopecmartin | I wonder if we need to update these links (i'm copy pasting them from the agenda) | 17:09 |
gmann | o/ | 17:10 |
gmann | sorry little late | 17:10 |
kopecmartin | np, i'm going through the usual | 17:10 |
kopecmartin | periodic jobs seem fine , well tempest-full-test-account-no-admin-py3 doesn't :/ | 17:12 |
kopecmartin | lot's of weird errors: | 17:13 |
kopecmartin | https://577c7db1b7d82ddde14e-e0bdf3ad49ea8c697978dcccacccf379.ssl.cf2.rackcdn.com/periodic/opendev.org/openstack/tempest/master/tempest-full-test-account-no-admin-py3/831b2e8/testr_results.html | 17:13 |
kopecmartin | Forbidden, Exceeded quota | 17:13 |
lpiwowar | That looks strange ... I'm taking a look. | 17:14 |
kopecmartin | some of the failures look similar as in | 17:15 |
kopecmartin | #link https://bugs.launchpad.net/tempest/+bug/2020860 | 17:15 |
gmann | 403 one seems valid one and policy changes to new defaults might have caused them. | 17:16 |
gmann | do we have bug for that? | 17:16 |
kopecmartin | maybe cause by this? | 17:16 |
lpiwowar | rule:create_network is disallowed by policy | 17:16 |
kopecmartin | #link https://review.opendev.org/c/openstack/tempest/+/899310 | 17:16 |
kopecmartin | no bug apart from the one i shared above (2020860) | 17:16 |
gmann | ok, can you create one and I will fix sometime this or next week | 17:17 |
kopecmartin | sure, lpiwowar can you please create a new LP? :D | 17:17 |
kopecmartin | i'm gonna continue with the meeting :) | 17:18 |
lpiwowar | :D ok:) | 17:18 |
kopecmartin | btw, gmann can we consider this LP done? | 17:18 |
kopecmartin | #link https://bugs.launchpad.net/tempest/+bug/2020860 | 17:18 |
gmann | checking | 17:18 |
kopecmartin | oh, i've just noticed that the patch has "Related-bug" .. so maybe not | 17:19 |
kopecmartin | but it's couple of months old .. | 17:19 |
gmann | kopecmartin: no, we did disable the new defaults but we need to run pre-provisioned testing with new default | 17:20 |
gmann | this requires more changes in pre provisioned account things | 17:20 |
gmann | I am keeping this low priority for this cycle | 17:20 |
kopecmartin | ack | 17:20 |
gmann | currently pre provisioned job run on old defaults whihc is just a workaround | 17:20 |
kopecmartin | #topic Distros check | 17:21 |
kopecmartin | cs-9 | 17:21 |
kopecmartin | #link https://zuul.openstack.org/builds?job_name=tempest-full-centos-9-stream&job_name=devstack-platform-centos-9-stream&skip=0 | 17:21 |
kopecmartin | debian | 17:21 |
kopecmartin | #link https://zuul.openstack.org/builds?job_name=devstack-platform-debian-bullseye&job_name=devstack-platform-debian-bookworm&skip=0 | 17:21 |
kopecmartin | rocky | 17:21 |
kopecmartin | #link https://zuul.openstack.org/builds?job_name=devstack-platform-rocky-blue-onyx | 17:21 |
kopecmartin | openEuler | 17:21 |
kopecmartin | #link https://zuul.openstack.org/builds?job_name=devstack-platform-openEuler-22.03-ovn-source&job_name=devstack-platform-openEuler-22.03-ovs&skip=0 | 17:21 |
kopecmartin | jammy | 17:21 |
kopecmartin | #link https://zuul.opendev.org/t/openstack/builds?job_name=devstack-platform-ubuntu-jammy-ovn-source&job_name=devstack-platform-ubuntu-jammy-ovs&skip=0 | 17:21 |
kopecmartin | all seems good | 17:24 |
kopecmartin | i need to check where we're with openeuler in regards of this libvirt LP | 17:24 |
kopecmartin | #link https://bugs.launchpad.net/devstack/+bug/2035224 | 17:24 |
kopecmartin | #topic Open Discussion | 17:26 |
kopecmartin | anything for the open discussion? | 17:26 |
lpiwowar | Just FYI I'm writing the bug and this one seems to be similar => https://bugs.launchpad.net/tempest/+bug/2020860 . It appeared after NOVA_ENFORCE_SCOPE was changed in devstack. | 17:27 |
kopecmartin | that's what i thought too | 17:28 |
kopecmartin | the job was broken even before, maybe it has several issues | 17:28 |
gmann | ok, can you add those new failing tests also in that bug | 17:29 |
gmann | otherwise i will forgot those the one failing for 403 | 17:29 |
lpiwowar | gmann: ack, I will add it there | 17:30 |
gmann | lpiwowar: thanks | 17:30 |
kopecmartin | i have one question about this patch, also commented there | 17:31 |
kopecmartin | #link https://review.opendev.org/c/openstack/tempest/+/879923 | 17:31 |
kopecmartin | i think that the point 3 , gmann mentioned in the previous comment, is optional, well it depends on what we wanna achieve | 17:31 |
kopecmartin | my goal is to limit the cleanup tool by default so that it doesn't delete anything that isn't prefixed with tempest-test - in that case we can omit point 3 | 17:32 |
kopecmartin | however | 17:32 |
kopecmartin | if we wanna also allow users to customize the prefix, then we need the point 3 obviously | 17:32 |
kopecmartin | so my question is more like, do we want to allow users to customize the prefix? | 17:33 |
gmann | kopecmartin: replied | 17:33 |
gmann | if we do not make it configure then it seems it will have same issue as we have today | 17:33 |
gmann | configuration make it easy for users to use and detect the tempest created resource eaisly. that can help in our cleanup script or the one if they have any | 17:34 |
kopecmartin | ok, i just wanted to double check as that will require modification of quite a lot of files .. i didn't wanna commit anyone's time if we were't sure we want that | 17:34 |
gmann | if we are doing this effort, it is better to make it configurable also | 17:34 |
gmann | I think if we are fixing that then we should do it fully otherwise sometime later someone will come to make it configurable | 17:35 |
gmann | kopecmartin: if you think author scope of work or bandwidth is the issue to do this bug change then we can do it in two steps 1. hard coded value with tempest-test 2. make it confiugrable | 17:36 |
gmann | s/bug change/big change | 17:36 |
kopecmartin | right, i was thinking the same, the author has already 2 commits anyway, this is the other one | 17:37 |
kopecmartin | #link https://review.opendev.org/c/openstack/tempest/+/897231 | 17:37 |
gmann | ohk, did not see that | 17:37 |
gmann | can you ask them to make it in dependent so that it will be easy to review both. config one on top of hardcoded value | 17:38 |
kopecmartin | yep, absolutely | 17:38 |
gmann | cool, thanks | 17:38 |
gmann | I am adding both in my list | 17:38 |
kopecmartin | thanks | 17:39 |
kopecmartin | #topic Bug Triage | 17:39 |
kopecmartin | #link https://etherpad.openstack.org/p/qa-bug-triage-caracal | 17:39 |
lpiwowar | Link to the bug: | 17:39 |
lpiwowar | #link https://bugs.launchpad.net/tempest/+bug/2043038 | 17:40 |
kopecmartin | lpiwowar: +1 | 17:40 |
kopecmartin | anyway, the bug numbers are recorded | 17:41 |
kopecmartin | i don't have any bug to bring up this time | 17:41 |
kopecmartin | that's all from my side | 17:41 |
kopecmartin | anything else? | 17:41 |
gmann | nothing else from my side | 17:42 |
kopecmartin | ack, see you all around then :) | 17:42 |
kopecmartin | thanks everyone | 17:42 |
lpiwowar | nothing from my side | 17:42 |
lpiwowar | thanks kopecmartin | 17:42 |
kopecmartin | #endmeeting | 17:42 |
opendevmeet | Meeting ended Wed Nov 8 17:42:47 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 17:42 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/qa/2023/qa.2023-11-08-17.00.html | 17:42 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/qa/2023/qa.2023-11-08-17.00.txt | 17:42 |
opendevmeet | Log: https://meetings.opendev.org/meetings/qa/2023/qa.2023-11-08-17.00.log.html | 17:42 |
gmann | kopecmartin: thanks | 17:42 |
clarkb | stephenfin: sean-k-mooney off the top of my head I don't know how to fix the wsgi script and console scripts being missing. That said on the console scripts side of things the reason we have our own is the default is super inefficient (it does pkg_resources import iirc which as we all know is slow). Maybe that is no longer a problem and we can simplify? However that doesn't | 17:48 |
clarkb | help with wsgi | 17:48 |
opendevreview | yatin proposed openstack/devstack master: [DNM] repro 2 https://review.opendev.org/c/openstack/devstack/+/900443 | 17:52 |
opendevreview | Merged openstack/grenade master: Set NOVA_VNC_ENABLED: true for subnode in the grenade job https://review.opendev.org/c/openstack/grenade/+/900257 | 18:01 |
sean-k-mooney | clarkb: the console script are being cretated | 18:05 |
sean-k-mooney | clarkb: because that is supported by setup tools | 18:06 |
sean-k-mooney | its just the wsgi scripts | 18:06 |
sean-k-mooney | and i think its only for editable installs | 18:06 |
sean-k-mooney | clarkb: i unfortuanlly will need to take as step back form this for a bit as really fixing this was ment ot be a ptg hackaton thing to adress the devstack gloabl_venv supprot for centos | 18:07 |
sean-k-mooney | since people were complaining about it. | 18:07 |
opendevreview | Ashley Rodriguez proposed openstack/devstack-plugin-ceph stable/2023.1: Remote Ceph with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/897972 | 18:20 |
opendevreview | James Parker proposed openstack/whitebox-tempest-plugin master: Add global nodes variable https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/884903 | 18:25 |
*** JayF is now known as JasonF | 18:53 | |
*** JasonF is now known as JayF | 18:53 | |
opendevreview | Ashley Rodriguez proposed openstack/devstack-plugin-ceph stable/2023.1: Remote Ceph with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/897972 | 19:40 |
opendevreview | Ashley Rodriguez proposed openstack/devstack-plugin-ceph master: [WIP] Add ingress deamon https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/900348 | 20:30 |
opendevreview | Ashley Rodriguez proposed openstack/devstack-plugin-ceph master: [WIP] Add ingress deamon https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/900348 | 20:39 |
opendevreview | melanie witt proposed openstack/devstack master: DNM testing https://review.opendev.org/c/openstack/devstack/+/900262 | 21:35 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!