SumitGupta | Hi there, Is there a way to conditionally include a statement like this in requirements.txt, where a package's certain level is installed if python version is 3.x.y ? For example, install zuul-sphinx>=0.2.0 only when python version is greater than 3.8.0 | 07:10 |
---|---|---|
tkajinam | SumitGupta, that may be using python_version ... but afaik requirement check does not allow it now. | 07:44 |
tkajinam | that may be possible by using * | 07:44 |
tkajinam | https://review.opendev.org/c/openstack/oslo.utils/+/897623 | 07:44 |
SumitGupta | tkajinam, I am doing like this, is this supported format: cryptography>=41.0.3;python>=3.9 | 08:43 |
frickler | SumitGupta: see the linked patch: cryptography>=41.0.3;python_version>="3.9" | 08:47 |
tkajinam | SumitGupta, you need quotes around 3.9 | 08:48 |
tkajinam | as frickler pointed out | 08:48 |
tkajinam | https://review.opendev.org/c/openstack/requirements/+/901119 may be needed to get requirement check passing | 08:48 |
SumitGupta | sure. Thanks !! | 08:49 |
tkajinam | though I don't fully understand what's that for. If that is to pulling cytptography version broken in py 39 then I feel like that is not what we should maintain in our repos. | 08:52 |
* tkajinam has to leave now | 08:52 | |
SumitGupta | I need to put that because there are some security vulnerabilities in lower versions of 2-3 packages (ex. cryptography 40.x.x). They'll go away if package is at higher level. | 08:54 |
tkajinam | my concern is maintaining recommended package version of all dependent libraries sound like a huge task | 08:55 |
tkajinam | the version in requirements usually explain the minimum required version for functionality | 08:55 |
SumitGupta | I'd like to maintain a minimum non-vulnerable version if it is available on client's python version. If it is not available, then there is no choice. | 08:59 |
frickler | SumitGupta: about which project is this? I get the impression that this is not related to this channel | 08:59 |
SumitGupta | Furthermore, it is not for all libs, but for those which are vulnerable to security threats. This is about IBM's cinder driver code. | 09:00 |
frickler | I'm not convinced that requirements are the right place to handle this. like distro versions may get fixed without bumping the library version. also likely #openstack-requirements is a better place for discussion | 09:02 |
SumitGupta | Sure. I'll discuss there. | 09:11 |
opendevreview | Lajos Katona proposed openstack/devstack master: Option for SQLAlchemy and alembic git source https://review.opendev.org/c/openstack/devstack/+/901124 | 10:36 |
opendevreview | Lajos Katona proposed openstack/devstack master: Option for SQLAlchemy and alembic git source https://review.opendev.org/c/openstack/devstack/+/901124 | 10:37 |
opendevreview | Maxim Sava proposed openstack/tempest master: Add delete image from specific store API https://review.opendev.org/c/openstack/tempest/+/898544 | 13:32 |
opendevreview | yatin proposed openstack/devstack master: Option for SQLAlchemy and alembic git source https://review.opendev.org/c/openstack/devstack/+/901124 | 14:19 |
opendevreview | Merged openstack/whitebox-tempest-plugin master: Add global nodes variable https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/884903 | 16:53 |
opendevreview | Artom Lifshitz proposed openstack/whitebox-tempest-plugin master: WIP: Test resize with mem_page_size in flavor https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/824772 | 18:05 |
opendevreview | Artom Lifshitz proposed openstack/whitebox-tempest-plugin master: Remove unit tests https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/901197 | 18:05 |
opendevreview | Artom Lifshitz proposed openstack/whitebox-tempest-plugin master: Remove old huge pages tests and reverse dependencies https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/901198 | 18:05 |
opendevreview | Artom Lifshitz proposed openstack/whitebox-tempest-plugin master: WIP: Test resize with mem_page_size in flavor https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/824772 | 19:46 |
opendevreview | Merged openstack/devstack master: Option for SQLAlchemy and alembic git source https://review.opendev.org/c/openstack/devstack/+/901124 | 20:53 |
opendevreview | Merged openstack/whitebox-tempest-plugin master: Remove unit tests https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/901197 | 21:09 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!