| opendevreview | OpenStack Proposal Bot proposed openstack/devstack master: Updated from generate-devstack-plugins-list https://review.opendev.org/c/openstack/devstack/+/911393 | 03:13 |
|---|---|---|
| opendevreview | Merged openstack/tempest master: Add prefix to images created in *ImagesNegativeTest tests https://review.opendev.org/c/openstack/tempest/+/908358 | 03:46 |
| opendevreview | Merged openstack/devstack-plugin-ceph master: Set CephFS/NFS job to non-voting https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/911157 | 05:14 |
| opendevreview | Merged openstack/devstack master: Updated from generate-devstack-plugins-list https://review.opendev.org/c/openstack/devstack/+/911393 | 06:10 |
| abhishekk_ | frickler, gmann, fungi is there any way where I can say that grenade should always install 2023.2 as older version? | 12:18 |
| frickler | abhishekk_: grenade from master branch should do just that, maybe you can start with explaining what issue you have with it? | 12:24 |
| abhishekk_ | https://review.opendev.org/c/openstack/glance/+/901649/27/.zuul.yaml | 12:25 |
| abhishekk_ | I have added this new job to test upfrade, where I noticed that setting few variables in job definition actually does not work | 12:26 |
| abhishekk_ | the base here is 2023.2 and target is master (current release) | 12:26 |
| abhishekk_ | So at least couple more cycles I want this new job to install base devstack with 2023.2 to use sqlite as cache driver (unless the old variable in job definition works) | 12:27 |
| frickler | abhishekk_: iiuc you should use the zuul variable "grenade_from_branch" for that. but I'm also not sure how long this would actually keep working | 12:31 |
| frickler | see https://opendev.org/openstack/grenade/raw/branch/master/roles/configure-grenade-branches/README.rst | 12:32 |
| abhishekk_ | for 2 more cycles, till end of E release | 12:32 |
| frickler | well the other option would be to keep testing the upgrade from the default branch, but make the default db override work | 12:33 |
| abhishekk_ | and how to handle that | 12:34 |
| abhishekk_ | anyway, the job is done, but I wanted to have this visible via grenade job, I will discuss this internally and check whether we really need this or not | 12:36 |
| abhishekk_ | thank you for inputs! | 12:37 |
| *** tosky_ is now known as tosky | 13:57 | |
| *** dansmith_ is now known as dansmith | 15:02 | |
| opendevreview | Katarina Strenkova proposed openstack/tempest master: Allow tempest cleanup delete resources based on prefix https://review.opendev.org/c/openstack/tempest/+/879923 | 15:48 |
| opendevreview | Katarina Strenkova proposed openstack/tempest master: Implement purge list for tempest cleanup https://review.opendev.org/c/openstack/tempest/+/897847 | 15:48 |
| *** clarkb1 is now known as clarkb | 16:55 | |
| frickler | gmann: kopecmartin_: I'd say tempest eol cleanup is finally ready for reviews https://review.opendev.org/c/openstack/tempest/+/909973 | 18:00 |
| gmann | frickler: +2, thanks | 18:17 |
| gmann | abhishekk: for that you need to do the change in devstack stable/2023.2 configuration and that is what grenade will pickup the config from in installation. on upgrade grenade just update the code it does not install devstack on new | 18:20 |
| abhishekk | gmann, ack, I have done something like this, https://review.opendev.org/c/openstack/glance/+/901649 | 18:21 |
| gmann | abhishekk: centralized_db is the new default in this release right? | 18:23 |
| abhishekk | yes | 18:23 |
| gmann | abhishekk: all config setting you via job variable or so it set on old release where devstack is installed. grenade just make sure new code work on those old release config | 18:35 |
| gmann | abhishekk: there is no direct way to change the config for new release via job variable | 18:36 |
| abhishekk | ok, so here in my scenario I am installing 2023.2 as base (old) devstack, right? | 18:36 |
| abhishekk | SO it will have sqlite as default driver | 18:36 |
| gmann | yes with all default config of 2023.2 and what you override in job | 18:37 |
| gmann | yes | 18:37 |
| abhishekk | then grenade will upgrade code to master | 18:37 |
| abhishekk | where it will have centralized_db as default driver | 18:37 |
| abhishekk | and then it will run intended tests, correct? | 18:37 |
| gmann | yes for first but no for second. it will still have sqlite as driver but run new code | 18:38 |
| gmann | there is no config change happened when grenade update the code to new (bcz we do not run devstack again on new) | 18:38 |
| gmann | if we change config option it need restarting the service until config is mutable one | 18:39 |
| abhishekk | But the logs shows otherwise | 18:39 |
| gmann | that is what I am checking you can change the config before test are run on new via some script which can restart service aso | 18:39 |
| gmann | also | 18:39 |
| abhishekk | I can see cache driver is changed to centralized_db | 18:40 |
| gmann | abhishekk: is it? link please | 18:40 |
| abhishekk | yes | 18:40 |
| abhishekk | wait | 18:41 |
| abhishekk | https://1fb7ccba51a9a88ebc4b-183a764968d603a8e1bec46158333aa8.ssl.cf5.rackcdn.com/901649/28/check/glance-grenade-centralized-cache/814b06d/controller/logs/screen-g-api.txt | 18:42 |
| abhishekk | here at first you can see, Mar 06 15:19:22.851213 np0036976394 devstack@g-api.service[83003]: INFO glance.image_cache [None req-99809906-bffc-4689-8496-a079907f2cf8 None None] Image cache loaded driver 'sqlite'. | 18:43 |
| abhishekk | wait, something is missing | 18:44 |
| gmann | abhishekk: yes that is what old devstack set it but where it update to centralized_db | 18:44 |
| abhishekk | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_dd1/901649/28/check/glance-grenade-centralized-cache/dd1a6c1/controller/logs/screen-g-api.txt | 18:45 |
| abhishekk | here | 18:45 |
| abhishekk | Image cache loaded driver 'sqlite'. | 18:46 |
| abhishekk | Mar 06 13:32:17.675560 np0036975701 devstack@g-api.service[151811]: INFO glance.image_cache [None req-30001775-3847-4c9d-b43d-3eaf54fa34b0 None None] Image cache loaded driver 'centralized_db'. | 18:46 |
| gmann | ah i see | 18:48 |
| gmann | abhishekk: I am checking in the glance change log https://zuul.opendev.org/t/openstack/build/814b06db438e450094e095c296b10c3d/logs | 18:50 |
| abhishekk | don't check that one, that was failed | 18:50 |
| abhishekk | check the previous one | 18:50 |
| abhishekk | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_dd1/901649/28/check/glance-grenade-centralized-cache/dd1a6c1/controller/logs/screen-g-api.txt | 18:51 |
| abhishekk | this one | 18:51 |
| abhishekk | https://zuul.opendev.org/t/openstack/build/dd1a6c118e0c4cb2811af3d888c4d6a6 | 18:51 |
| gmann | abhishekk: i figured out, this is not coming from grenade it is glance db_migration script you have in master -https://github.com/openstack/glance/blob/master/glance/sqlite_migration.py | 18:58 |
| gmann | https://zuul.opendev.org/t/openstack/build/dd1a6c118e0c4cb2811af3d888c4d6a6/log/controller/logs/screen-g-api.txt#2224 | 18:58 |
| abhishekk | I don't understand | 18:59 |
| gmann | because grenade only run db migration script | 18:59 |
| abhishekk | https://zuul.opendev.org/t/openstack/build/dd1a6c118e0c4cb2811af3d888c4d6a6/log/controller/logs/screen-g-api.txt#2229 | 19:00 |
| gmann | so what you want to test 'do not change the driver and new code should run on sqlite' or 'upgrade driver from sqlite to centralized_db when grenade upgrade and run test' ? | 19:01 |
| abhishekk | upgrade from sqlite to centralized_db and run test | 19:01 |
| gmann | k so that is what happening in your current job right | 19:02 |
| abhishekk | yes | 19:03 |
| abhishekk | that is what I am saying it is changing from sqlite to centralized_db | 19:03 |
| abhishekk | but probably wrong in explaining it in terms of grenade | 19:03 |
| abhishekk | because the migration will only work if this condition passes, https://github.com/openstack/glance/blob/master/glance/sqlite_migration.py#L38 | 19:04 |
| gmann | yeah, just saw that. so question here is who is changing this image_cache config option before glance service is restarted on new | 19:06 |
| gmann | abhishekk: ah, you are setting it via devstack master. which is kind of same thing 1. override the config before glance service is restarted in new (upgrade.py) https://opendev.org/openstack/devstack/src/branch/master/lib/glance#L78 | 19:10 |
| abhishekk | :) | 19:10 |
| abhishekk | where is this upgrade.py, needs to understand that | 19:11 |
| abhishekk | So nothing voodoo, all logical :D | 19:11 |
| gmann | in grenade unless you are not appending in glance which is not there so this one only gets run https://github.com/openstack/grenade/blob/f1980a682ba072d694efa59a62cf68cef7ecb5ce/projects/40_glance/upgrade.sh | 19:12 |
| abhishekk | ack, I have abandoned that change | 19:34 |
| abhishekk | https://review.opendev.org/c/openstack/grenade/+/901678?usp=search | 19:34 |
| *** kopecmartin_ is now known as kopecmartin | 22:50 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!