*** dtantsur_ is now known as dtantsur | 02:24 | |
dansmith | frickler: clarkb: could one of you hit this? It's in front of three tempest patches for image acceptance testing, which we want to get in before we start cutting over to the oslo implementation to make sure things work and stay working: | 13:30 |
---|---|---|
dansmith | https://review.opendev.org/c/openstack/devstack/+/925425 | 13:30 |
clarkb | dansmith: does `if [[ "$image_conversion" ]]; then` need a [[/test expression operator like -n? | 15:32 |
* clarkb is about to do some quick local testing of that | 15:32 | |
dansmith | non-empty string is true, right? | 15:33 |
clarkb | yup seems to be | 15:33 |
dansmith | AFAIK, the opposite of -n is just no operator in [] and [[]] | 15:33 |
clarkb | oh I see now in the help output they list bit -n STRING and STRING as tests for that | 15:33 |
dansmith | yeah | 15:34 |
dansmith | clarkb: thanks! | 15:40 |
clarkb | you're welcome | 15:42 |
opendevreview | Eric Harney proposed openstack/devstack master: Fix get_default_host_ip ipv6 address parsing https://review.opendev.org/c/openstack/devstack/+/926151 | 17:18 |
opendevreview | Merged openstack/devstack master: Add os-test-images support in lib/tempest https://review.opendev.org/c/openstack/devstack/+/925425 | 18:49 |
opendevreview | Dan Smith proposed openstack/devstack master: Trivial fixes from review of os-test-images https://review.opendev.org/c/openstack/devstack/+/926157 | 18:52 |
opendevreview | Merged openstack/tempest master: Test image formats https://review.opendev.org/c/openstack/tempest/+/925431 | 19:01 |
opendevreview | Merged openstack/tempest master: Test image formats with import https://review.opendev.org/c/openstack/tempest/+/925490 | 19:10 |
opendevreview | Merged openstack/tempest master: Add compute image format test https://review.opendev.org/c/openstack/tempest/+/925617 | 19:10 |
dansmith | \o/ | 19:10 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!