| gmaan | tosky_: approved but I do not think the plugin error is related, they are failing for 'md5' from 'oslo_utils.secretutils' | 02:07 |
|---|---|---|
| opendevreview | Merged openstack/tempest master: Replace deprecated FormatChecker.cls_checks https://review.opendev.org/c/openstack/tempest/+/935737 | 04:29 |
| bbezak | gmaan: done ;) | 08:40 |
| opendevreview | Stephen Finucane proposed openstack/tempest master: Replace skip with skipTest https://review.opendev.org/c/openstack/tempest/+/977616 | 10:11 |
| stephenfin | gmaan: Fixed that failing test https://review.opendev.org/c/openstack/tempest/+/977616 | 10:11 |
| opendevreview | Eduardo Olivares proposed openstack/tempest master: DNM: did oslo.utils 10.0.0 break tempest? https://review.opendev.org/c/openstack/tempest/+/977801 | 13:41 |
| eolivare | hi there, tempest master is not broken with the release of oslo.utils-10.0.0, but tempest latest release, 46.0.0, is broken. Hence, we need a new tempest release including https://review.opendev.org/c/openstack/tempest/+/947714 | 13:52 |
| eolivare | for example, this job failed due to that issue: https://zuul.opendev.org/t/openstack/build/88f9020687b24e7595e31a3b00ac548c | 13:53 |
| eolivare | gmaan, tosky_ ^^ | 13:54 |
| tosky_ | eolivare: oh, the issue I've noticed yesterday about pep8 | 13:58 |
| tosky_ | thanks for double checking | 13:58 |
| tosky_ | I think gmaan was going to tag a new release anyway, but maybe let's speed up the process :) | 13:58 |
| eolivare | ok! | 13:59 |
| eolivare | tosky_, I just found this: https://review.opendev.org/c/openstack/releases/+/977624 | 14:03 |
| gmaan | tosky_: eolivare +1 on release. but I think we are missing some testing in requirement version bump which broke the things. let me think if we can add something for plugin side there | 16:19 |
| gmaan | i will find out how it broke the things and where we can add testing | 16:23 |
| opendevreview | Ivan Anfimov proposed openstack/devstack master: wip https://review.opendev.org/c/openstack/devstack/+/977835 | 16:24 |
| *** gmaan is now known as gmaan_afk | 16:29 | |
| opendevreview | Ivan Anfimov proposed openstack/devstack master: wip https://review.opendev.org/c/openstack/devstack/+/977835 | 16:46 |
| opendevreview | Ivan Anfimov proposed openstack/devstack master: Change tenant_network_types to project_network_types https://review.opendev.org/c/openstack/devstack/+/977835 | 16:46 |
| *** gmaan_afk is now known as gmaan | 17:37 | |
| opendevreview | Stephen Finucane proposed openstack/tempest master: hacking: Check for use of testtools.skipTest decorator https://review.opendev.org/c/openstack/tempest/+/977854 | 19:25 |
| stephenfin | gmaan: I did that as a follow-up ^ | 19:25 |
| gmaan | checking | 19:26 |
| stephenfin | actually, wait: testtools.skip (the decorator) hasn't been removedc | 19:26 |
| gmaan | stephenfin: +w on both | 19:26 |
| gmaan | stephenfin: you mean to keep both in hacking rule? | 19:26 |
| stephenfin | No, see my comment on the new patch. I've just abandoned it | 19:26 |
| gmaan | stephenfin: ok but we need to add SkipTest also in that rule and skip can be removed later once it is entirely gone | 19:28 |
| gmaan | bcz we do not want any test use SkipTest or Skip in as testr skip decorator | 19:28 |
| stephenfin | that rule checks for the @testtools.skip decorator | 19:28 |
| stephenfin | it sounds like you need a *new* rule to check for e.g. self.skip calls inside tests? | 19:28 |
| gmaan | stephenfin: oh, i see. i got confused with decorator. got it now. all good | 19:29 |
| stephenfin | sweet, thanks | 19:30 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!