Friday, 2018-04-27

openstackgerritLingxian Kong proposed openstack/qinling master: [WIP] Function version API: scale_up/scale_down/detach/get_workers  https://review.openstack.org/56420300:26
*** huntxu has joined #openstack-qinling01:14
*** caoyuan has joined #openstack-qinling01:19
*** caoyuan has quit IRC01:37
*** yufei has joined #openstack-qinling01:43
openstackgerritLingxian Kong proposed openstack/qinling master: [WIP] Function version API: scale_up/scale_down/detach/get_workers  https://review.openstack.org/56420302:21
*** caoyuan has joined #openstack-qinling02:24
openstackgerritLingxian Kong proposed openstack/qinling master: [WIP] Function version API: scale_up/scale_down/detach/get_workers  https://review.openstack.org/56420302:25
openstackgerritLingxian Kong proposed openstack/qinling master: [WIP] Function version API: scale_up/scale_down/detach/get_workers  https://review.openstack.org/56420303:23
openstackgerritLingxian Kong proposed openstack/qinling master: [WIP] Functional test for creating function version  https://review.openstack.org/56467304:44
openstackgerritLingxian Kong proposed openstack/qinling master: [WIP] Function version API: scale_up/scale_down/detach/get_workers  https://review.openstack.org/56420304:54
*** cctopusZhang has joined #openstack-qinling05:03
*** yufei has quit IRC05:03
*** cctopusZhang is now known as yufei05:03
*** blkart_ has quit IRC05:54
*** blkart_ has joined #openstack-qinling05:55
*** cctopusZhang has joined #openstack-qinling06:16
*** yufei has quit IRC06:19
*** cctopusZhang is now known as yufei06:19
*** caoyuan_ has joined #openstack-qinling06:51
openstackgerritLingxian Kong proposed openstack/qinling master: Function version API: scale_up/scale_down/detach/get_workers  https://review.openstack.org/56420306:51
*** caoyuan has quit IRC06:51
lxkonghuntxu: ping07:49
huntxulxkong: pong07:49
lxkongyou can revivew https://review.openstack.org/#/c/564203/ now, i rechecked several time, the current patchset will fix the potential unit test failure07:49
lxkongroot case is we start job handler for api testing07:50
lxkongit will affect db sessions when the actual tests are running07:50
lxkongthe coverage test failure is related to the previous commit07:50
openstackgerritLingxian Kong proposed openstack/qinling master: Functional test for creating function version  https://review.openstack.org/56467307:52
lxkonghuntxu: or we can wait for https://review.openstack.org/564673 to see the coverage test result07:52
lxkonghopefully it's gone :-)07:52
lxkongi just rebased07:52
huntxulxkong: that's cool, I'll check it later07:53
lxkonghuntxu: thanks07:53
*** cctopusZhang has joined #openstack-qinling08:26
*** yufei has quit IRC08:30
*** cctopusZhang is now known as yufei08:32
lxkonghuntxu: https://review.openstack.org/#/c/564673/ alll green!09:20
huntxuyeah I saw that09:20
huntxulxkong: one comment about https://review.openstack.org/#/c/564203/09:27
*** caoyuan_ has quit IRC09:35
lxkonghuntxu: look at the implemetation of both `_update_function_db` and `_update_function_version_db`function,  they are using conditional db update, don't need to be inside a transaction09:41
huntxugot it09:42
huntxuthen I'm going to land both 564203 and 56467309:43
*** caoyuan has joined #openstack-qinling09:43
lxkonghuntxu: go for it, i will add more functional tests09:43
*** caoyuan has quit IRC09:45
*** caoyuan has joined #openstack-qinling09:45
*** blkart_ has quit IRC09:55
*** blkart has joined #openstack-qinling09:58
*** caoyuan has quit IRC10:08
openstackgerritMerged openstack/qinling master: Function version API: scale_up/scale_down/detach/get_workers  https://review.openstack.org/56420310:10
openstackgerritMerged openstack/qinling master: Functional test for creating function version  https://review.openstack.org/56467310:10
openstackgerritLingxian Kong proposed openstack/qinling master: Functional test for creating execution with function version  https://review.openstack.org/56473010:51
openstackgerritLingxian Kong proposed openstack/qinling master: Functional test for creating execution with function version  https://review.openstack.org/56473011:43
openstackgerritLingxian Kong proposed openstack/qinling master: Functional test for creating execution with function version  https://review.openstack.org/56473012:17
*** caoyuan has joined #openstack-qinling12:36
*** huntxu has quit IRC13:00
*** caoyuan_ has joined #openstack-qinling15:45
*** caoyuan has quit IRC15:48
*** caoyuan_ has quit IRC15:59
*** rakhmerov has quit IRC21:25
*** rakhmerov has joined #openstack-qinling21:30
*** caoyuan has joined #openstack-qinling22:36
*** caoyuan has quit IRC22:48
*** caoyuan has joined #openstack-qinling22:49
*** caoyuan has quit IRC22:53
openstackgerritLingxian Kong proposed openstack/qinling master: Functional test for creating job/webhook with function version  https://review.openstack.org/56495223:52
openstackgerritLingxian Kong proposed openstack/qinling master: Functional test for creating job/webhook with function version  https://review.openstack.org/56495223:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!