openstackgerrit | Lingxian Kong proposed openstack/qinling master: [WIP] Function version API: scale_up/scale_down/detach/get_workers https://review.openstack.org/564203 | 00:26 |
---|---|---|
*** huntxu has joined #openstack-qinling | 01:14 | |
*** caoyuan has joined #openstack-qinling | 01:19 | |
*** caoyuan has quit IRC | 01:37 | |
*** yufei has joined #openstack-qinling | 01:43 | |
openstackgerrit | Lingxian Kong proposed openstack/qinling master: [WIP] Function version API: scale_up/scale_down/detach/get_workers https://review.openstack.org/564203 | 02:21 |
*** caoyuan has joined #openstack-qinling | 02:24 | |
openstackgerrit | Lingxian Kong proposed openstack/qinling master: [WIP] Function version API: scale_up/scale_down/detach/get_workers https://review.openstack.org/564203 | 02:25 |
openstackgerrit | Lingxian Kong proposed openstack/qinling master: [WIP] Function version API: scale_up/scale_down/detach/get_workers https://review.openstack.org/564203 | 03:23 |
openstackgerrit | Lingxian Kong proposed openstack/qinling master: [WIP] Functional test for creating function version https://review.openstack.org/564673 | 04:44 |
openstackgerrit | Lingxian Kong proposed openstack/qinling master: [WIP] Function version API: scale_up/scale_down/detach/get_workers https://review.openstack.org/564203 | 04:54 |
*** cctopusZhang has joined #openstack-qinling | 05:03 | |
*** yufei has quit IRC | 05:03 | |
*** cctopusZhang is now known as yufei | 05:03 | |
*** blkart_ has quit IRC | 05:54 | |
*** blkart_ has joined #openstack-qinling | 05:55 | |
*** cctopusZhang has joined #openstack-qinling | 06:16 | |
*** yufei has quit IRC | 06:19 | |
*** cctopusZhang is now known as yufei | 06:19 | |
*** caoyuan_ has joined #openstack-qinling | 06:51 | |
openstackgerrit | Lingxian Kong proposed openstack/qinling master: Function version API: scale_up/scale_down/detach/get_workers https://review.openstack.org/564203 | 06:51 |
*** caoyuan has quit IRC | 06:51 | |
lxkong | huntxu: ping | 07:49 |
huntxu | lxkong: pong | 07:49 |
lxkong | you can revivew https://review.openstack.org/#/c/564203/ now, i rechecked several time, the current patchset will fix the potential unit test failure | 07:49 |
lxkong | root case is we start job handler for api testing | 07:50 |
lxkong | it will affect db sessions when the actual tests are running | 07:50 |
lxkong | the coverage test failure is related to the previous commit | 07:50 |
openstackgerrit | Lingxian Kong proposed openstack/qinling master: Functional test for creating function version https://review.openstack.org/564673 | 07:52 |
lxkong | huntxu: or we can wait for https://review.openstack.org/564673 to see the coverage test result | 07:52 |
lxkong | hopefully it's gone :-) | 07:52 |
lxkong | i just rebased | 07:52 |
huntxu | lxkong: that's cool, I'll check it later | 07:53 |
lxkong | huntxu: thanks | 07:53 |
*** cctopusZhang has joined #openstack-qinling | 08:26 | |
*** yufei has quit IRC | 08:30 | |
*** cctopusZhang is now known as yufei | 08:32 | |
lxkong | huntxu: https://review.openstack.org/#/c/564673/ alll green! | 09:20 |
huntxu | yeah I saw that | 09:20 |
huntxu | lxkong: one comment about https://review.openstack.org/#/c/564203/ | 09:27 |
*** caoyuan_ has quit IRC | 09:35 | |
lxkong | huntxu: look at the implemetation of both `_update_function_db` and `_update_function_version_db`function, they are using conditional db update, don't need to be inside a transaction | 09:41 |
huntxu | got it | 09:42 |
huntxu | then I'm going to land both 564203 and 564673 | 09:43 |
*** caoyuan has joined #openstack-qinling | 09:43 | |
lxkong | huntxu: go for it, i will add more functional tests | 09:43 |
*** caoyuan has quit IRC | 09:45 | |
*** caoyuan has joined #openstack-qinling | 09:45 | |
*** blkart_ has quit IRC | 09:55 | |
*** blkart has joined #openstack-qinling | 09:58 | |
*** caoyuan has quit IRC | 10:08 | |
openstackgerrit | Merged openstack/qinling master: Function version API: scale_up/scale_down/detach/get_workers https://review.openstack.org/564203 | 10:10 |
openstackgerrit | Merged openstack/qinling master: Functional test for creating function version https://review.openstack.org/564673 | 10:10 |
openstackgerrit | Lingxian Kong proposed openstack/qinling master: Functional test for creating execution with function version https://review.openstack.org/564730 | 10:51 |
openstackgerrit | Lingxian Kong proposed openstack/qinling master: Functional test for creating execution with function version https://review.openstack.org/564730 | 11:43 |
openstackgerrit | Lingxian Kong proposed openstack/qinling master: Functional test for creating execution with function version https://review.openstack.org/564730 | 12:17 |
*** caoyuan has joined #openstack-qinling | 12:36 | |
*** huntxu has quit IRC | 13:00 | |
*** caoyuan_ has joined #openstack-qinling | 15:45 | |
*** caoyuan has quit IRC | 15:48 | |
*** caoyuan_ has quit IRC | 15:59 | |
*** rakhmerov has quit IRC | 21:25 | |
*** rakhmerov has joined #openstack-qinling | 21:30 | |
*** caoyuan has joined #openstack-qinling | 22:36 | |
*** caoyuan has quit IRC | 22:48 | |
*** caoyuan has joined #openstack-qinling | 22:49 | |
*** caoyuan has quit IRC | 22:53 | |
openstackgerrit | Lingxian Kong proposed openstack/qinling master: Functional test for creating job/webhook with function version https://review.openstack.org/564952 | 23:52 |
openstackgerrit | Lingxian Kong proposed openstack/qinling master: Functional test for creating job/webhook with function version https://review.openstack.org/564952 | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!