| *** caoyuan has joined #openstack-qinling | 00:38 | |
| *** caoyuan has quit IRC | 00:57 | |
| *** caoyuan has joined #openstack-qinling | 01:58 | |
| *** huntxu has joined #openstack-qinling | 02:15 | |
| *** caoyuan has quit IRC | 02:34 | |
| *** caoyuan has joined #openstack-qinling | 02:35 | |
| openstackgerrit | Hunt Xu proposed openstack/python-qinlingclient master: Allow specifying name of related resource when creation https://review.openstack.org/544243 | 02:39 |
|---|---|---|
| *** caoyuan has quit IRC | 02:40 | |
| *** caoyuan has joined #openstack-qinling | 02:40 | |
| lxkong | larainema: i reviewed you patch for function alias just now, please have a look | 02:51 |
| larainema | sure, thanks lxkong | 03:01 |
| larainema | lxkong, I also have a question with alias delete | 03:05 |
| larainema | about alias delete, i don't think we need to check the job and webhook, as delete alias only delete the alias point to the function and function version, what about your thought | 03:08 |
| larainema | but delete job and webhook need to check the alias | 03:08 |
| *** caoyuan has quit IRC | 03:55 | |
| *** caoyuan has joined #openstack-qinling | 03:55 | |
| *** caoyuan has quit IRC | 04:03 | |
| *** caoyuan has joined #openstack-qinling | 04:07 | |
| *** huntxu has quit IRC | 05:01 | |
| *** huntxu has joined #openstack-qinling | 05:03 | |
| lxkong | larainema: because we need to support alias for job/webhook | 05:18 |
| lxkong | which means, users can specify alias when creating job/webhook | 05:18 |
| larainema | yes, I understand here, what I thought is when user create job/webhook use alias, it will create it with the function and function version the alias point to | 05:19 |
| larainema | lxkong, I mean user can create job/webhook use alias, but it don't store alias in job/webhook table, job/webhook related function and function_version | 05:26 |
| lxkong | hmm...that's probably not a good design, how the end user knows that which alias he was using to create the job/webhook after creation? | 05:28 |
| lxkong | i need to think about that. But it won't affect your current patch, since you are doing get/create for now, right? | 05:28 |
| lxkong | probably we need to store the alias name in job/webhook but also the function_id and version. Internally, we only use function_id and version to invoke the actual function. | 05:31 |
| larainema | the alias is connect to the function_id and function_version | 05:35 |
| lxkong | yeah, i know. I mean, the user still has the requirement to check the alias for creating the job/webhook | 05:36 |
| larainema | user can check which alias connect to which function_id and function_version for creating job/webhook, if they want to know use which alias create the job/webhook, just from the function_id and function version, we can connect it | 05:40 |
| larainema | it's just my thought by implement the delete api, you can think about it | 05:40 |
| lxkong | or, we could provide the filtering api to get alias by function_id/function_version | 05:41 |
| larainema | filter api make sense for me | 05:43 |
| larainema | or we can provide a message when delete alias which point to the job/webhook | 05:45 |
| openstackgerrit | ShangXiao proposed openstack/python-qinlingclient master: Add release notes link to README https://review.openstack.org/576419 | 08:20 |
| *** caoyuan has quit IRC | 08:50 | |
| *** caoyuan has joined #openstack-qinling | 08:51 | |
| *** caoyuan has quit IRC | 08:58 | |
| *** caoyuan has joined #openstack-qinling | 08:59 | |
| *** caoyuan has quit IRC | 09:03 | |
| *** caoyuan has joined #openstack-qinling | 09:08 | |
| *** caoyuan has quit IRC | 09:12 | |
| *** caoyuan has joined #openstack-qinling | 09:22 | |
| *** huntxu has quit IRC | 09:53 | |
| *** huntxu has joined #openstack-qinling | 12:47 | |
| *** huntxu has quit IRC | 12:59 | |
| *** caoyuan has quit IRC | 13:00 | |
| openstackgerrit | Merged openstack/python-qinlingclient master: Add release notes link to README https://review.openstack.org/576419 | 13:42 |
| *** caoyuan has joined #openstack-qinling | 14:18 | |
| *** caoyuan has quit IRC | 15:28 | |
| *** caoyuan has joined #openstack-qinling | 15:29 | |
| *** caoyuan has quit IRC | 16:15 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!