kei-ichi | Hi, I have a few questions about function creation, especially about parameter dependency, for designing Horizon plugin. | 01:08 |
---|---|---|
kei-ichi | Question 1: | 01:08 |
kei-ichi | From help message of `openstack function create` , I guess there are following dependency. | 01:08 |
kei-ichi | In case you specify `package` as a `--code-type` value: | 01:08 |
kei-ichi | You can use --file or --package to specify acutual file or package which funciton is written. | 01:08 |
kei-ichi | In case you specify `swift` as a `--code-type` value: | 01:08 |
kei-ichi | You can use --container and --object to specify Swift Object, so both (--container/---object) are required. | 01:08 |
kei-ichi | In case you specify `image` as a `--code-type` value: | 01:08 |
kei-ichi | You can use --image. | 01:08 |
kei-ichi | 01:08 | |
kei-ichi | Is my understanding correct ? | 01:08 |
kei-ichi | Question 2: | 01:08 |
kei-ichi | In case you specify `image` , what does this mean ? | 01:08 |
kei-ichi | Is this mean Docker image path same as runtime creation ? | 01:08 |
*** huntxu has joined #openstack-qinling | 01:12 | |
*** caoyuan has joined #openstack-qinling | 01:16 | |
kei-ichi | Sorry... my understanding might be incorrect. | 01:40 |
kei-ichi | I alredy have created function according to Qinling documentation, and at that case I did not specify --code-type parameter.. | 01:40 |
kei-ichi | Are there no dependency ? | 01:40 |
kei-ichi | I'll read https://docs.openstack.org/qinling/latest/user/cookbook_function.html#create-python-function-with-libraries-in-a-package again. thanks o/ | 01:40 |
*** blkart has quit IRC | 01:57 | |
*** blkart has joined #openstack-qinling | 01:57 | |
lxkong | kei-ichi: hi, you are right for question 1. | 02:01 |
*** blkart has quit IRC | 02:01 | |
lxkong | for Q2, the image is a docker image that contains user's functions and its potential dependencies | 02:02 |
lxkong | we have limited support for image type function now | 02:02 |
kei-ichi | lxkong : I got it, thanks ! o/ | 02:02 |
lxkong | in CLI, you don't need to specify `--code-type` if you already specify `--file` or `--package` | 02:03 |
kei-ichi | About question 2, image parameter should be specified like openstackqinling/python-runtime (same as tutorial) ? | 02:04 |
lxkong | but you know, it's CLI params, sometimes user may specify --file and --container at the same time, in this case, speciying `--code-type` helps | 02:04 |
lxkong | kei-ichi: yeah, just like how you specify image when you run container in docker | 02:05 |
kei-ichi | OK, I got it. (about image parameter) | 02:05 |
kei-ichi | What will occur if user specify --file and --container witjout --code-type? Qinling validate those kind of request and return error status ? | 02:06 |
kei-ichi | s/witjout/without/ | 02:06 |
lxkong | the priority: package --> swift --> image | 02:07 |
kei-ichi | understood o/ | 02:07 |
lxkong | kei-ichi: maybe we should add more help message for the CLI params | 02:07 |
kei-ichi | that sounds nice ;) | 02:09 |
*** blkart has joined #openstack-qinling | 02:10 | |
lxkong | huntxu: i think we could remove the `--code-type` param when creating function | 02:11 |
lxkong | it could be deduced by other params given | 02:12 |
lxkong | huntxu: what do you think? | 02:12 |
huntxu | lxkong: I'd agree, in fact I seldom use that param | 02:12 |
lxkong | me neither :-) from the client code, it's really not needed | 02:13 |
lxkong | i will submit a patch | 02:13 |
openstackgerrit | Lingxian Kong proposed openstack/python-qinlingclient master: Remove --code-type for function creation CLI https://review.openstack.org/581933 | 02:20 |
*** yuxin_ has quit IRC | 02:20 | |
*** yuxin_ has joined #openstack-qinling | 02:21 | |
lxkong | huntxu: btw, please review https://review.openstack.org/#/c/581569/, i think part of your work related could be included there | 02:24 |
huntxu | ok, will do | 02:25 |
lxkong | thanks | 02:25 |
*** caoyuan has quit IRC | 02:27 | |
openstackgerrit | Hunt Xu proposed openstack/qinling master: Add a preliminary structure for admin security guide https://review.openstack.org/581569 | 02:29 |
openstackgerrit | Merged openstack/qinling master: Add a preliminary structure for admin security guide https://review.openstack.org/581569 | 02:52 |
larainema | lxkong, huntxu, have you faced this problem when run tempest tests? | 03:06 |
larainema | TypeError: the JSON object must be str, not 'bytes' | 03:06 |
huntxu | larainema: I haven't seen that error, do you run tempest with python3? | 03:07 |
larainema | yes | 03:07 |
huntxu | larainema: does it happen on your newly added tests, or the existing ones? | 03:08 |
larainema | on the existing tests | 03:09 |
*** caoyuan has joined #openstack-qinling | 03:11 | |
huntxu | larainema: I guess our test codes are still not compatible with python 3 | 03:11 |
huntxu | larainema: if possible, try python2 instead | 03:12 |
*** caoyuan_ has joined #openstack-qinling | 03:12 | |
larainema | huntxu, thanks, I am trying on python2 | 03:13 |
openstackgerrit | Lingxian Kong proposed openstack/python-qinlingclient master: Remove --code-type for function creation CLI https://review.openstack.org/581933 | 03:14 |
lxkong | huntxu: is it easy to add python3 support for tempest tests? | 03:15 |
lxkong | i thought we already supported but maybe not | 03:15 |
*** caoyuan has quit IRC | 03:16 | |
huntxu | lxkong: I guess that won't be a tough task, I'll try to take it down, btw thanks for the info larainema | 03:17 |
larainema | huntxu, np | 03:18 |
huntxu | lxkong: openstack zuul uses python2 to run tempest as well, but we should support python3 if possible | 03:18 |
lxkong | huntxu: yeah i am wondering it's as easy as adding some config in the zuul config? | 03:19 |
huntxu | lxkong: another zuul job to run tempest with Python3? | 03:22 |
lxkong | don't know, we need to take a look at how other projects do | 03:23 |
lxkong | zuul is like a blackbox to me :-( | 03:23 |
larainema | huntxu, python2 works with other errors on my side | 03:24 |
larainema | tenacity.RetryError: RetryError, have you met this error? | 03:24 |
huntxu | larainema: no, looks like something failed after several retries | 03:25 |
larainema | i thought it's something wrong in my configuration | 03:26 |
larainema | i will check it, thanks | 03:26 |
openstackgerrit | Hunt Xu proposed openstack/python-qinlingclient master: Remove --code-type for function creation CLI https://review.openstack.org/581933 | 03:29 |
*** caoyuan_ has quit IRC | 03:40 | |
openstackgerrit | Lingxian Kong proposed openstack/python-qinlingclient master: Remove --code-type for function creation CLI https://review.openstack.org/581933 | 03:50 |
*** caoyuan has joined #openstack-qinling | 03:56 | |
*** caoyuan has quit IRC | 04:04 | |
*** caoyuan has joined #openstack-qinling | 04:04 | |
openstackgerrit | Hunt Xu proposed openstack/qinling master: [DNM] make tempest work with python3 https://review.openstack.org/581947 | 04:13 |
lxkong | huntxu: hah, you found it | 04:13 |
huntxu | lxkong: not sure that's the right way, just a try | 04:14 |
openstackgerrit | Merged openstack/python-qinlingclient master: Remove --code-type for function creation CLI https://review.openstack.org/581933 | 04:15 |
openstackgerrit | Hunt Xu proposed openstack/qinling master: [DNM] make tempest work with python3 https://review.openstack.org/581947 | 04:16 |
*** caoyuan has quit IRC | 07:15 | |
*** caoyuan has joined #openstack-qinling | 07:16 | |
*** caoyuan has quit IRC | 07:25 | |
huntxu | larainema: the json.loads() error is solved by python 3.6, there is a upstream issue about this https://bugs.python.org/issue17909 and https://bugs.python.org/issue10976 | 07:25 |
*** caoyuan has joined #openstack-qinling | 07:42 | |
*** caoyuan has quit IRC | 07:46 | |
*** caoyuan has joined #openstack-qinling | 07:56 | |
*** caoyuan has quit IRC | 08:01 | |
openstackgerrit | Hunt Xu proposed openstack/qinling master: python2-runtime: limit cglimit listen on localhost only https://review.openstack.org/582083 | 08:09 |
*** caoyuan has joined #openstack-qinling | 08:29 | |
*** caoyuan has quit IRC | 08:38 | |
*** caoyuan has joined #openstack-qinling | 09:07 | |
openstackgerrit | Vu Cong Tuan proposed openstack/python-qinlingclient master: Switch to stestr https://review.openstack.org/582115 | 09:11 |
*** caoyuan has quit IRC | 09:14 | |
*** caoyuan has joined #openstack-qinling | 09:16 | |
*** caoyuan has quit IRC | 10:22 | |
openstackgerrit | Hunt Xu proposed openstack/qinling master: periodics: fix service of function version 0 not expiring issue https://review.openstack.org/582135 | 10:33 |
*** caoyuan has joined #openstack-qinling | 11:12 | |
*** huntxu has quit IRC | 11:13 | |
openstackgerrit | Hunt Xu proposed openstack/qinling master: [DNM] make tempest work with python3 https://review.openstack.org/581947 | 11:13 |
*** caoyuan has quit IRC | 11:16 | |
openstackgerrit | Vu Cong Tuan proposed openstack/python-qinlingclient master: Switch to stestr https://review.openstack.org/582115 | 11:18 |
*** caoyuan has joined #openstack-qinling | 12:44 | |
*** caoyuan has quit IRC | 17:01 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!