| lxkong | kei-ichi: the CLI example: `openstack runtime create openstackqinling/python3-runtime:0.0.2 --name python3` | 05:34 |
|---|---|---|
| lxkong | You are right about 'image"openstackqinling/python-runtime" should be passed by request body', the image name comes from user's input | 05:35 |
| kei-ichi | Yes, that's right. So What I want to say is how use can find "openstackqinling/python-runtime" is valid input as runtime creation. | 05:36 |
| lxkong | kei-ichi: don't need to valid in the dashboard, if the image is invalid, the runtime creation will fail | 05:36 |
| lxkong | kei-ichi: does that make sense to you? | 05:39 |
| kei-ichi | I got it. if it is okay to send invalid image name, it is not difficult to implement that. | 05:40 |
| kei-ichi | Let me confirm the operation you expect. | 05:40 |
| kei-ichi | 1. Open "runtime creation" button. | 05:40 |
| kei-ichi | 2. There is a text field for runtime creation input values. | 05:40 |
| kei-ichi | 3. Docker image input field is just a free text field. If Docker image name is invalid, Qinling API returns kind of 4XX error, so it is not the matter for user. | 05:40 |
| kei-ichi | Would that be okay? | 05:41 |
| lxkong | If docker image name is invalid, either the runtime creation fails or the runtime is not going to work properly, which is the issue the admin user should figure out. Let's make thing simple for now, but maybe in future Qinling should validate the image name and the image availability during the runtime creation. | 05:44 |
| lxkong | from the user's perspective, if the image is not correctly specified(wrong name or nonexisting name), either he will see the runtime creation failed after the runtime to be `creating` for a while, or the runtime is created successfully but the function can not be executed because of the flaw image. | 05:46 |
| kei-ichi | Would that be okay? | 05:50 |
| kei-ichi | Sorry.. I made mistake. | 05:51 |
| kei-ichi | I can handle this implementation. But let me confirm another thing. If I implement as you said, I wonder it becomes also possible to use system purpose Docker image in runtime creation like "k8s.gcr.io/kube-proxy-amd64" | 05:51 |
| kei-ichi | Will it be blocked by Qinling? If Qinling only allows Qinling relevant Docker images, that will not be a problem. | 05:51 |
| kei-ichi | This may cause kind of security issues. | 05:51 |
| lxkong | kei-ichi: because the runtime can only be created by admin user, so it's fine if they don't input the image correctly. In future we could do some validation on Qinling server side so the dashboard doesn't need to change. | 16:02 |
| *** irclogbot_2 has joined #openstack-qinling | 16:40 | |
| *** irclogbot_2 has quit IRC | 16:43 | |
| *** irclogbot_2 has joined #openstack-qinling | 19:10 | |
| *** irclogbot_2 has quit IRC | 20:11 | |
| *** irclogbot_2 has joined #openstack-qinling | 20:20 | |
| kei-ichi | lxkong Thanks! All things how to implement is now clarified. I think I can finish it by the end of this month at the latest. o/ | 23:53 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!