*** PrashantS has quit IRC | 00:38 | |
*** PrashantS has joined #openstack-rally | 00:38 | |
*** PrashantS has quit IRC | 00:43 | |
*** dmorita has joined #openstack-rally | 00:47 | |
*** kiran-r is now known as kiranr | 01:40 | |
openstackgerrit | Boris Pavlovic proposed openstack/rally: Optimize Rally imports to reduce start time https://review.openstack.org/196493 | 02:09 |
---|---|---|
openstackgerrit | Boris Pavlovic proposed openstack/rally: Optimize Rally imports to reduce start time https://review.openstack.org/196493 | 02:32 |
*** mwagner_afk has joined #openstack-rally | 02:43 | |
*** davideagnello has joined #openstack-rally | 03:51 | |
*** coolsvap|away is now known as coolsvap | 03:52 | |
*** davideagnello has quit IRC | 03:56 | |
*** rushiagr_away is now known as rushiagr | 03:57 | |
*** rushiagr is now known as rushiagr_away | 04:03 | |
*** kiran-r has joined #openstack-rally | 04:23 | |
*** kiranr has quit IRC | 04:30 | |
*** yfried_ has quit IRC | 04:36 | |
*** tfreger has joined #openstack-rally | 04:41 | |
*** yfried has joined #openstack-rally | 04:43 | |
*** nihilifer has joined #openstack-rally | 04:45 | |
*** yfried has quit IRC | 04:49 | |
kiran-r | kun_huang: Hi! | 04:53 |
*** davideagnello has joined #openstack-rally | 04:57 | |
*** davideagnello has quit IRC | 05:03 | |
*** davideagnello has joined #openstack-rally | 05:03 | |
*** davideagnello has quit IRC | 05:03 | |
*** kiran-r has quit IRC | 05:03 | |
*** klindgren_ has joined #openstack-rally | 05:04 | |
*** klindgren has quit IRC | 05:06 | |
*** rdas has joined #openstack-rally | 05:07 | |
*** yfried has joined #openstack-rally | 05:32 | |
*** yfried_ has joined #openstack-rally | 05:35 | |
*** yfried has quit IRC | 05:36 | |
*** rdas has quit IRC | 05:50 | |
*** adiantum has quit IRC | 06:09 | |
*** agarciam has joined #openstack-rally | 06:10 | |
*** adiantum has joined #openstack-rally | 06:34 | |
*** adiantum has quit IRC | 06:42 | |
*** davideagnello has joined #openstack-rally | 06:52 | |
*** yfried_ is now known as yfried|afk | 06:52 | |
*** yfried|afk is now known as yfried_ | 06:53 | |
*** anshul has joined #openstack-rally | 06:54 | |
*** rdas has joined #openstack-rally | 06:55 | |
*** davideagnello has quit IRC | 06:57 | |
*** anshul has quit IRC | 07:02 | |
*** anshul has joined #openstack-rally | 07:06 | |
*** nkhare has joined #openstack-rally | 07:07 | |
*** exploreshaifali has joined #openstack-rally | 07:08 | |
*** fhubik has joined #openstack-rally | 07:14 | |
*** arxcruz has joined #openstack-rally | 07:25 | |
*** albertw1 has joined #openstack-rally | 07:33 | |
*** cdent has joined #openstack-rally | 07:41 | |
*** kiran-r has joined #openstack-rally | 07:42 | |
*** neeti has joined #openstack-rally | 07:44 | |
kun_huang | kiran-r: hi | 07:47 |
kun_huang | kiran-r: I'm on bus this morning | 07:47 |
kun_huang | got your request now | 07:47 |
*** dmorita has quit IRC | 07:48 | |
kiran-r | kun_huang: Please check the 2 patches, dependent to each other | 07:49 |
kun_huang | these two are ready? https://review.openstack.org/#/c/193432/16 https://review.openstack.org/#/c/193527/ ? | 07:50 |
*** dmorita has joined #openstack-rally | 07:53 | |
kun_huang | kiran-r: | 07:54 |
kun_huang | ping | 07:54 |
kiran-r | kun_huang: Yes | 07:54 |
kun_huang | have test this line? supports_extension("lbaas") | 07:54 |
kun_huang | I remember that lbaas is an agent in neutron not extension | 07:54 |
openstackgerrit | Kiran proposed openstack/rally: Add ability to create pool in Neutron context https://review.openstack.org/193432 | 07:55 |
kiran-r | kun_huang: It also shows up in neutron ext-list http://paste.openstack.org/show/324508/ | 08:05 |
*** fhubik has quit IRC | 08:07 | |
*** fhubik has joined #openstack-rally | 08:08 | |
*** fhubik_afk has joined #openstack-rally | 08:09 | |
kiran-r | yfried_ : ping | 08:28 |
kun_huang | kiran-r: we are now facing new upstream issue: fixtures | 08:41 |
*** davideagnello has joined #openstack-rally | 08:41 | |
kun_huang | kiran-r: it is uploaded, TODAY | 08:41 |
kiran-r | kun_huang: Yes, like this one http://logs.openstack.org/32/193432/17/check/gate-rally-python26/5ec974d/console.html | 08:41 |
kun_huang | at least rally's unit tests are blocked | 08:41 |
kun_huang | let's see response of other community first | 08:42 |
*** davideagnello has quit IRC | 08:46 | |
*** kbyrne has quit IRC | 08:47 | |
*** kbyrne has joined #openstack-rally | 08:53 | |
*** kir_ has joined #openstack-rally | 08:54 | |
kir_ | redixin: https://review.openstack.org/#/c/188847/ still has hard time with mirantis CI | 08:55 |
*** albertw1 has quit IRC | 08:55 | |
kun_huang | ping kiran-r | 09:01 |
kiran-r | kun_huang: Yes | 09:02 |
kun_huang | find a workaround | 09:02 |
kun_huang | but I'm but sure... | 09:03 |
kiran-r | kun_huang: it is not a problem in the rally code. | 09:03 |
kun_huang | maybe | 09:04 |
kiran-r | yfried_: Please look into this ^ | 09:04 |
kun_huang | I need go home and have a test | 09:04 |
kun_huang | there is no openstack cloud on hand | 09:04 |
*** tab___ has joined #openstack-rally | 09:08 | |
*** igormarnat is now known as imarnat | 09:17 | |
kun_huang | https://github.com/openstack/rally/blob/master/tests/unit/plugins/openstack/scenarios/glance/test_utils.py#L50 | 09:17 |
kun_huang | https://github.com/openstack/rally/blob/master/tests/unit/plugins/openstack/scenarios/nova/test_utils.py#L54 | 09:17 |
kiran-r | kun_huang I filed a bug on this https://bugs.launchpad.net/rally/+bug/1469644 | 09:19 |
openstack | Launchpad bug 1469644 in Rally "Rally jenkins fails due to fixtures 1.3.0" [Undecided,New] | 09:19 |
*** tosky has joined #openstack-rally | 09:19 | |
*** kbaikov has quit IRC | 09:20 | |
yfried_ | kiran-r: look into what? | 09:22 |
*** fhubik has quit IRC | 09:24 | |
*** fhubik_afk has quit IRC | 09:24 | |
*** fhubik_afk has joined #openstack-rally | 09:24 | |
*** fhubik has joined #openstack-rally | 09:24 | |
*** fhubik_afk has quit IRC | 09:24 | |
*** fhubik has quit IRC | 09:24 | |
*** fhubik has joined #openstack-rally | 09:25 | |
*** dmorita has quit IRC | 09:25 | |
kiran-r | yfried_ : Jenkins is failing with fixtures 1.3.0 | 09:26 |
*** kbaikov has joined #openstack-rally | 09:27 | |
*** imarnat is now known as igormarnat | 09:28 | |
*** igormarnat is now known as imarnat | 09:29 | |
*** yfried_ is now known as yfried|afk | 09:52 | |
*** aix has joined #openstack-rally | 09:53 | |
*** openstackgerrit has quit IRC | 09:53 | |
*** openstackgerrit has joined #openstack-rally | 09:53 | |
*** yfried|afk is now known as yfried_ | 09:58 | |
*** karimb has joined #openstack-rally | 10:01 | |
*** imarnat is now known as igormarnat | 10:03 | |
*** uschreiber_ has joined #openstack-rally | 10:03 | |
*** uschreiber_ has quit IRC | 10:05 | |
*** igormarnat is now known as imarnat | 10:28 | |
*** imarnat is now known as igormarnat | 10:28 | |
*** davideagnello has joined #openstack-rally | 10:30 | |
*** davideagnello has quit IRC | 10:34 | |
*** exploreshaifali has quit IRC | 10:37 | |
openstackgerrit | Kiran proposed openstack/rally: Add the right version of fixture in requirements https://review.openstack.org/196623 | 10:38 |
*** igormarnat is now known as imarnat | 10:42 | |
kiran-r | kun_huang ^ | 10:42 |
kiran-r | kun_huang ping | 10:42 |
*** fhubik is now known as fhubik_afk | 10:45 | |
*** rdas has quit IRC | 10:46 | |
*** tosky_ has joined #openstack-rally | 10:49 | |
*** fhubik_lunch has joined #openstack-rally | 10:49 | |
*** acruz has joined #openstack-rally | 10:49 | |
*** fhubik_afk has quit IRC | 10:52 | |
*** tosky__ has joined #openstack-rally | 10:52 | |
*** karmatronic has joined #openstack-rally | 10:52 | |
*** karmatronic has quit IRC | 10:53 | |
*** arxcruz has quit IRC | 10:53 | |
*** karmatronic has joined #openstack-rally | 10:53 | |
*** tosky has quit IRC | 10:53 | |
*** fhubik_meeting has joined #openstack-rally | 10:54 | |
*** fhubik_meeting is now known as fhubik_afk | 10:54 | |
*** tosky_ has quit IRC | 10:54 | |
*** fhubik_lunch has quit IRC | 10:54 | |
*** karimb has quit IRC | 10:54 | |
*** acruz has quit IRC | 10:54 | |
*** tosky__ is now known as tosky | 10:54 | |
openstackgerrit | nayna-patel proposed openstack/rally: Add context for Designate Domains https://review.openstack.org/195039 | 10:57 |
*** acruz has joined #openstack-rally | 11:07 | |
*** coolsvap is now known as coolsvap|away | 11:10 | |
*** imarnat is now known as igormarnat | 11:29 | |
*** fhubik_afk is now known as fhubik_meeting | 11:41 | |
*** nkhare has quit IRC | 11:42 | |
*** yfried_ is now known as yfried|afk | 11:43 | |
*** yfried|afk is now known as yfried_ | 11:45 | |
*** fhubik_meeting is now known as fhubik_afk | 12:00 | |
*** MaxPC1 has joined #openstack-rally | 12:11 | |
*** igormarnat is now known as imarnat | 12:16 | |
*** yfried_ has quit IRC | 12:17 | |
*** davideagnello has joined #openstack-rally | 12:18 | |
*** davideagnello has quit IRC | 12:23 | |
*** yfried_ has joined #openstack-rally | 12:25 | |
*** yfried_ is now known as yfried|afk | 12:25 | |
*** yfried|afk has quit IRC | 12:25 | |
*** imarnat is now known as igormarnat | 12:26 | |
*** igormarnat is now known as imarnat | 12:32 | |
*** imarnat is now known as igormarnat | 12:33 | |
*** igormarnat is now known as imarnat | 12:36 | |
*** imarnat is now known as igormarnat | 12:38 | |
*** karmatronic has quit IRC | 12:43 | |
*** nihilifer has quit IRC | 12:43 | |
*** kiran-r has quit IRC | 12:44 | |
*** exploreshaifali has joined #openstack-rally | 12:52 | |
*** igormarnat is now known as imarnat | 13:03 | |
*** yfried|afk has joined #openstack-rally | 13:04 | |
*** imarnat is now known as igormarnat | 13:05 | |
*** yfried|afk has quit IRC | 13:05 | |
*** fhubik_afk is now known as fhubik_meeting | 13:05 | |
*** yfried|afk has joined #openstack-rally | 13:05 | |
yfried|afk | andreykurilin: mtg today? | 13:06 |
*** igormarnat is now known as imarnat | 13:12 | |
*** rvasilets_ has joined #openstack-rally | 13:18 | |
*** tfreger has quit IRC | 13:18 | |
openstackgerrit | Albert White proposed openstack/rally: find should use portable options https://review.openstack.org/196086 | 13:19 |
*** oanufriev has joined #openstack-rally | 13:22 | |
*** oanufriev has quit IRC | 13:38 | |
*** andreykurilin__ has joined #openstack-rally | 13:45 | |
*** acruz has quit IRC | 13:49 | |
kun_huang | kir_: pong | 13:50 |
*** imarnat is now known as igormarnat | 13:53 | |
*** igormarnat is now known as imarnat | 13:55 | |
*** stpierre has joined #openstack-rally | 13:57 | |
*** exploreshaifali has quit IRC | 13:57 | |
*** boris-42 has joined #openstack-rally | 13:59 | |
*** karimb has joined #openstack-rally | 13:59 | |
*** albertw has quit IRC | 14:00 | |
*** albertw has joined #openstack-rally | 14:01 | |
boris-42 | yfried|afk: ping | 14:02 |
boris-42 | kun_huang: ping | 14:02 |
kun_huang | boris-42: pong | 14:02 |
boris-42 | kun_huang: it's rally meeting time=) | 14:02 |
boris-42 | meteorfox: ping | 14:02 |
boris-42 | stpierre: ping | 14:02 |
*** davideagnello has joined #openstack-rally | 14:07 | |
*** fhubik_meeting is now known as fhubik_afk | 14:10 | |
*** davideagnello has quit IRC | 14:12 | |
*** fhubik_afk is now known as fhubik_meeting | 14:25 | |
kir_ | kun_huang: ping | 14:25 |
kun_huang | kir_: coming to #openstack-meeting | 14:26 |
kun_huang | if having any trouble, you could ask for help there | 14:26 |
kir_ | open #openstack-meeting | 14:29 |
*** fhubik_meeting is now known as fhubik_afk | 14:29 | |
*** kir_ has quit IRC | 14:29 | |
*** imarnat is now known as igormarnat | 14:29 | |
*** kir_ has joined #openstack-rally | 14:29 | |
*** igormarnat is now known as imarnat | 14:36 | |
*** imarnat is now known as igormarnat | 14:37 | |
*** igormarnat is now known as imarnat | 14:38 | |
*** gubouvier has joined #openstack-rally | 14:38 | |
*** imarnat is now known as igormarnat | 14:38 | |
*** nihilifer has joined #openstack-rally | 14:42 | |
*** igormarnat is now known as imarnat | 14:51 | |
*** imarnat is now known as igormarnat | 14:54 | |
*** igormarnat is now known as imarnat | 14:54 | |
*** imarnat is now known as igormarnat | 14:59 | |
boris-42 | kir_: hi | 15:00 |
*** kiran-r has joined #openstack-rally | 15:01 | |
kiran-r | boris-42: ping | 15:01 |
kiran-r | boris-42: Hi! :) | 15:01 |
*** taturn has joined #openstack-rally | 15:02 | |
taturn | hi | 15:02 |
andreykurilin__ | taturn: hi there_ | 15:02 |
*** igormarnat is now known as imarnat | 15:03 | |
taturn | cool | 15:04 |
stpierre | boris-42: i know the meeting's over, but i feel like we might be able to get a middle ground if our supported release policy a) guaranteed support on all upstream supported releases; b) discouraged breaking compatibility with unsupported releases without reason; and c) noted that unsupported releases do not undergo CI testing, so may have issues. that still means that we're testing four releases in gate (which will raise plenty of issues | 15:07 |
stpierre | as i'm sure you know), but our scope won't grow without bound, and we won't go out of our way to break crap. | 15:07 |
boris-42 | stpierre: So I am not saying | 15:07 |
boris-42 | stpierre: that we should gurantee that Rally will work against Diablo | 15:08 |
boris-42 | stpierre: I am saying that it will be nice if it will work against it | 15:08 |
stpierre | yes, i agree | 15:08 |
boris-42 | stpierre: or at least part of it | 15:08 |
stpierre | but if it doesn't, i don't think that should keep us awake at night | 15:08 |
boris-42 | stpierre: and we should extend our gates to support or stable releases | 15:08 |
stpierre | definitely | 15:08 |
boris-42 | stpierre: yep true but if somebody is proposing fixes we should review / merge | 15:09 |
*** fhubik_afk is now known as fhubik_meeting | 15:09 | |
*** imarnat is now known as igormarnat | 15:09 | |
stpierre | i'm not sure i agree with that universally. our willingness to merge should consider how much code complexity it adds. IMO it's sort of like albertw's find patch. that's a fine patch because it changes one line in a trivial way, and makes install_rally.sh better. a patch to make all of install_rally.sh work on old broken-ass Solaris 8 would probably be something terrible like -200, +600, and i think we should reject the hell out it. | 15:10 |
stpierre | we have to limit our scope, or go insane. those are the two options. | 15:10 |
stpierre | so if you have a minor tweak to a scenario and it works on grizzly, hey, great. but if you need to add a ton of abstraction in order to support a substantially different older API, then that's not so great. that reduces long-term code maintainability, and it's a fundamentally untestable change | 15:11 |
*** igormarnat is now known as imarnat | 15:11 | |
kir_ | boris-42: hi | 15:12 |
*** imarnat is now known as igormarnat | 15:13 | |
*** igormarnat is now known as imarnat | 15:21 | |
*** taturn has left #openstack-rally | 15:22 | |
*** kiran-r has quit IRC | 15:22 | |
*** e0ne has joined #openstack-rally | 15:23 | |
*** e0ne is now known as e0ne_ | 15:25 | |
*** e0ne_ is now known as e0ne | 15:25 | |
*** anshul has quit IRC | 15:27 | |
*** psd has joined #openstack-rally | 15:29 | |
*** davideagnello has joined #openstack-rally | 15:31 | |
*** cdent has quit IRC | 15:32 | |
*** imarnat is now known as igormarnat | 15:34 | |
*** kiran-r has joined #openstack-rally | 15:38 | |
*** davideagnello has quit IRC | 15:42 | |
*** PrashantS has joined #openstack-rally | 15:44 | |
*** PrashantS has quit IRC | 15:45 | |
*** PrashantS has joined #openstack-rally | 15:45 | |
*** e0ne has quit IRC | 15:46 | |
*** kiran-r has quit IRC | 15:47 | |
*** e0ne has joined #openstack-rally | 15:48 | |
boris-42 | stpierre: heh | 15:50 |
boris-42 | stpierre: agree | 15:50 |
*** e0ne is now known as e0ne_ | 15:53 | |
*** davideagnello has joined #openstack-rally | 15:53 | |
*** albertw1 has joined #openstack-rally | 15:54 | |
*** e0ne_ is now known as e0ne | 15:55 | |
*** davideagnello has quit IRC | 15:58 | |
kir_ | boris-42: plz review https://review.openstack.org/#/c/188847/ - I do understand that without cobbler server it's untestable, so not sure how to proceed | 16:03 |
*** kiran-r has joined #openstack-rally | 16:07 | |
openstackgerrit | Pavel Boldin proposed openstack/rally: Add command-dict option to specify command args https://review.openstack.org/177016 | 16:07 |
openstackgerrit | Pavel Boldin proposed openstack/rally: Add command_customizer context https://review.openstack.org/183227 | 16:07 |
openstackgerrit | Pavel Boldin proposed openstack/rally: Add boot_runcommand_delete_custom_image scenario https://review.openstack.org/183228 | 16:07 |
openstackgerrit | Pavel Boldin proposed openstack/rally: Make `boot_runcommand_delete' accept command-dict https://review.openstack.org/177014 | 16:07 |
openstackgerrit | Pavel Boldin proposed openstack/rally: Add command-dict option to upload a local command https://review.openstack.org/177015 | 16:07 |
boris-42 | kir_: so we have 2 ways to do the things | 16:08 |
boris-42 | kir_: *we* will belive you that it works | 16:08 |
boris-42 | kir_: and merge if it looks ok | 16:08 |
boris-42 | kir_: or you can help us to build CI for it | 16:08 |
*** fhubik_meeting has quit IRC | 16:09 | |
kir_ | boris-42: who provides hardware for this CI? | 16:10 |
boris-42 | kir_: so we have a bit | 16:11 |
boris-42 | kir_: just 2 servers | 16:11 |
*** kiran-r has quit IRC | 16:11 | |
kir_ | boris-42: it's enough for functional testing | 16:14 |
kir_ | boris-42: provided that servers are smtp-rebootable | 16:17 |
kir_ | boris-42: c/smpt/snmp | 16:18 |
*** kiran-r has joined #openstack-rally | 16:25 | |
boris-42 | kir_: we will need to talk with redixin | 16:26 |
boris-42 | kir_: unfortuntally today is holiday in Ukraine | 16:26 |
boris-42 | kir_: so I will review today your patch and we will ping tomorrow redixin and discuss functional testing of this patch | 16:27 |
kir_ | boris-42: ok | 16:27 |
*** kiran-r has quit IRC | 16:30 | |
*** kiran-r has joined #openstack-rally | 16:30 | |
*** _kiran_ has joined #openstack-rally | 16:35 | |
*** kiran-r has quit IRC | 16:36 | |
*** neeti has quit IRC | 16:41 | |
*** oanufriev has joined #openstack-rally | 16:45 | |
*** _kiran_ has quit IRC | 16:47 | |
*** e0ne has quit IRC | 16:59 | |
*** mwagner_afk has quit IRC | 17:06 | |
*** davideagnello has joined #openstack-rally | 17:07 | |
*** temujin_ has joined #openstack-rally | 17:14 | |
*** oanufriev has quit IRC | 17:15 | |
*** temujin_ has quit IRC | 17:15 | |
*** oanufriev has joined #openstack-rally | 17:15 | |
*** exploreshaifali has joined #openstack-rally | 17:16 | |
*** PrashantS has quit IRC | 17:17 | |
*** PrashantS has joined #openstack-rally | 17:18 | |
openstackgerrit | Kun Huang proposed openstack/rally: Fix gate: move test case to avoid latest fixtures https://review.openstack.org/196746 | 17:20 |
*** temujin has joined #openstack-rally | 17:20 | |
*** temujin has quit IRC | 17:21 | |
*** temujin has joined #openstack-rally | 17:22 | |
*** PrashantS has quit IRC | 17:23 | |
*** temujin has quit IRC | 17:26 | |
*** temujin has joined #openstack-rally | 17:30 | |
*** dontalton has joined #openstack-rally | 17:32 | |
*** temujin has quit IRC | 17:32 | |
kun_huang | boris-42: ping | 17:41 |
kun_huang | ping andreykurilin | 17:43 |
*** exploreshaifali has quit IRC | 17:45 | |
*** PrashantS has joined #openstack-rally | 17:49 | |
*** psd has quit IRC | 17:59 | |
*** mwagner_afk has joined #openstack-rally | 18:02 | |
*** exploreshaifali has joined #openstack-rally | 18:08 | |
andreykurilin__ | kun_huang: pong | 18:12 |
*** tosky has quit IRC | 18:15 | |
kun_huang | https://review.openstack.org/#/c/196746/ | 18:18 |
kun_huang | fixtures fixed andreykurilin__ | 18:18 |
kun_huang | bug coverage failed | 18:18 |
kun_huang | not about coverage itself | 18:18 |
kun_huang | andreykurilin__: | 18:19 |
kun_huang | coverage is to compare master and HEAD | 18:19 |
kun_huang | because of fixtures issue, any coverage test on master failed... | 18:19 |
kun_huang | so we need disable coverage first... | 18:19 |
andreykurilin__ | We can do it just modifying code in our repo | 18:21 |
*** temujin has joined #openstack-rally | 18:22 | |
kun_huang | andreykurilin__: push instead of git review? | 18:23 |
andreykurilin__ | kun_huang: No, I mean we can modify script tests/ci/coverage.sh and disable coverage check(return success) | 18:25 |
kun_huang | andreykurilin__: besides you, is another core reviewer online? | 18:28 |
*** openstackgerrit has quit IRC | 18:30 | |
*** openstackgerrit has joined #openstack-rally | 18:30 | |
andreykurilin__ | kun_huang: My internet connection is not stable now, so I can be offline in near future :( boris-42 should be online | 18:36 |
kun_huang | ok, I'll submit one and wait him | 18:38 |
openstackgerrit | Kun Huang proposed openstack/rally: disable coverage test temporarily https://review.openstack.org/196795 | 18:43 |
*** nihilifer has quit IRC | 18:46 | |
openstackgerrit | Kun Huang proposed openstack/rally: Fix gate: move test case to avoid latest fixtures https://review.openstack.org/196746 | 18:47 |
kun_huang | updated | 18:48 |
kun_huang | go to ben | 18:48 |
kun_huang | bed | 18:48 |
openstackgerrit | Chris St. Pierre proposed openstack/rally: Fix gate: move test case to avoid latest fixtures https://review.openstack.org/196746 | 18:57 |
openstackgerrit | Chris St. Pierre proposed openstack/rally: Revert "disable coverage test temporarily" https://review.openstack.org/196799 | 18:57 |
stpierre | kun_huang: i rebased your changes to be a series so that we merge these in order | 18:57 |
stpierre | and added a revert for the coverage test changes so we don't accidentally leave that disabled :) | 18:57 |
*** albertw1 has quit IRC | 19:06 | |
*** boris-42 has quit IRC | 19:12 | |
*** karimb has quit IRC | 19:28 | |
*** mwagner_afk has quit IRC | 19:39 | |
*** temujin has quit IRC | 19:53 | |
*** temujin has joined #openstack-rally | 19:54 | |
*** rvasilets_ has quit IRC | 20:04 | |
*** gubouvier has quit IRC | 20:17 | |
*** oanufriev__ has joined #openstack-rally | 20:20 | |
*** nihilifer has joined #openstack-rally | 20:20 | |
*** dontalton has quit IRC | 20:26 | |
*** boris-42 has joined #openstack-rally | 20:31 | |
*** Prashant_ has joined #openstack-rally | 20:33 | |
*** PrashantS has quit IRC | 20:36 | |
boris-42 | kun_huang: are you around? | 20:37 |
openstackgerrit | Chris St. Pierre proposed openstack/rally: Fix gate: move test case to avoid latest fixtures https://review.openstack.org/196746 | 20:39 |
openstackgerrit | Chris St. Pierre proposed openstack/rally: Revert "disable coverage test temporarily" https://review.openstack.org/196799 | 20:39 |
*** oanufriev__ has quit IRC | 20:39 | |
stpierre | boris-42: i squashed them together | 20:39 |
stpierre | so hopefully now it'll pass gate | 20:40 |
boris-42 | stpierre: btw https://review.openstack.org/#/c/196746/ | 20:40 |
boris-42 | stpierre: take a look at my comment | 20:41 |
stpierre | i don't understand the change well enough to know the answer to that | 20:41 |
stpierre | i assumed that the cleanUp was necessary because the class included the fixture objects | 20:41 |
stpierre | so you could get rid of it precisely because the test was moved into another class | 20:41 |
boris-42 | stpierre: not sure.. really not sure.. | 20:41 |
stpierre | but i guess i can TIAS | 20:41 |
stpierre | honestly, i think we can just get rid of these two tests completely. they don't test anything about nova or glance, they test rally.benchmark.utils.get_from_manager() | 20:48 |
stpierre | and it has its own unit tests | 20:48 |
*** echoingumesh has joined #openstack-rally | 20:49 | |
boris-42 | stpierre: +2 | 20:50 |
boris-42 | stpierre: let's just get rid of them | 20:50 |
*** temujin has quit IRC | 20:50 | |
*** exploreshaifali has quit IRC | 20:51 | |
openstackgerrit | Chris St. Pierre proposed openstack/rally: Remove extraneous failed server/image tests https://review.openstack.org/196855 | 20:52 |
boris-42 | stpierre: ^ not sure that this will work without disabling coverage job | 20:52 |
*** temujin has joined #openstack-rally | 20:52 | |
boris-42 | stpierre: ^ btw it will be nice to add kun as co-author | 20:53 |
stpierre | good call | 20:53 |
boris-42 | stpierre: he participate as well in fixing this=) | 20:53 |
openstackgerrit | Chris St. Pierre proposed openstack/rally: Remove extraneous failed server/image tests https://review.openstack.org/196855 | 20:54 |
stpierre | i missed the reasoning behind disabling coverage -- why can't we just add test(s) as necessary to restore the coverage? | 20:54 |
boris-42 | stpierre: so coverage will test old code that doesn't work | 20:56 |
boris-42 | stpierre: and it will fail | 20:56 |
boris-42 | stpierre: if you disable coverage it won't care that old (master) code is failing | 20:56 |
stpierre | oooooooooooooooooooh | 20:56 |
stpierre | i get it | 20:56 |
boris-42 | stpierre: ya it runs 2 times coverage job | 20:56 |
stpierre | so the coverage isn't changing, it's just that the coverage job expects tests against master to succeed | 20:56 |
boris-42 | stpierre: to understand did you change everything | 20:56 |
*** temujin has quit IRC | 20:57 | |
boris-42 | stpierre: master and master + yourpatch | 20:57 |
openstackgerrit | Chris St. Pierre proposed openstack/rally: Restore coverage test functionality https://review.openstack.org/196799 | 20:58 |
openstackgerrit | Chris St. Pierre proposed openstack/rally: Remove extraneous failed server/image tests https://review.openstack.org/196855 | 20:58 |
*** nihilifer has quit IRC | 21:02 | |
stpierre | i would shed no tears if fakes.py went the way of the dodo | 21:06 |
stpierre | maybe that'll be the next windmill i tilt at after my scenario fixture change gets merged | 21:07 |
*** Prashant_ has quit IRC | 21:09 | |
*** PrashantS has joined #openstack-rally | 21:10 | |
*** PrashantS has quit IRC | 21:14 | |
*** stpierre has quit IRC | 21:17 | |
*** mwagner_lap has joined #openstack-rally | 21:26 | |
*** kevinbenton has quit IRC | 21:31 | |
*** temujin has joined #openstack-rally | 21:33 | |
*** oanufriev__ has joined #openstack-rally | 21:39 | |
*** MaxPC1 has quit IRC | 22:11 | |
*** exploreshaifali has joined #openstack-rally | 22:23 | |
*** oanufriev__ has quit IRC | 22:26 | |
*** oanufriev__ has joined #openstack-rally | 22:27 | |
*** mwagner_lap has quit IRC | 22:32 | |
*** oanufriev__ has quit IRC | 22:33 | |
*** briandowns has joined #openstack-rally | 22:46 | |
*** briandowns has quit IRC | 22:48 | |
*** exploreshaifali has quit IRC | 22:56 | |
*** oanufriev__ has joined #openstack-rally | 23:04 | |
*** echoingumesh has quit IRC | 23:22 | |
*** echoingumesh has joined #openstack-rally | 23:22 | |
*** echoingumesh has quit IRC | 23:27 | |
*** boris-42 has quit IRC | 23:32 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!