Thursday, 2016-01-28

« Wednesday, 2016-01-27 Index Friday, 2016-01-29 »
*** MaxPC has joined #openstack-rally00:02
*** diogogmt has quit IRC00:17
*** tosky has quit IRC00:25
*** arnoldje has joined #openstack-rally00:49
openstackgerritli,chen proposed openstack/rally: Use new-style Python classes  https://review.openstack.org/26726600:50
*** chenli has joined #openstack-rally00:57
*** harshs has joined #openstack-rally01:00
*** yingjun has joined #openstack-rally01:00
*** jjmb has joined #openstack-rally01:02
*** Aish has quit IRC01:06
*** chenli has quit IRC01:08
*** Liuqing has joined #openstack-rally01:09
*** diogogmt has joined #openstack-rally01:14
*** pvaneck has quit IRC01:33
*** baker has joined #openstack-rally01:39
*** baker_ has joined #openstack-rally01:40
*** baker has quit IRC01:43
*** josdotso has quit IRC01:48
*** MaxPC has quit IRC01:55
*** bochi-michael has joined #openstack-rally02:10
*** madhu_ak has quit IRC02:13
*** baker_ has quit IRC02:15
*** baker has joined #openstack-rally02:21
*** chenli has joined #openstack-rally02:22
*** harshs has quit IRC02:29
*** e0ne has joined #openstack-rally02:41
*** e0ne has quit IRC02:48
*** e0ne has joined #openstack-rally02:50
openstackgerritLi Yingjun proposed openstack/rally: Remove the extra 'g' in description for plugin show  https://review.openstack.org/27332002:53
*** e0ne_ has joined #openstack-rally02:54
*** e0ne has quit IRC02:55
*** kjorgensen has quit IRC02:57
*** kjorgensen has joined #openstack-rally03:00
*** kjorgens_ has joined #openstack-rally03:02
*** kjorgensen has quit IRC03:04
*** kjorgens_ has quit IRC03:05
*** psuriset_ has quit IRC03:23
*** psuriset_ has joined #openstack-rally03:37
*** e0ne_ has quit IRC03:48
*** kjorgensen has joined #openstack-rally03:50
*** coolsvap|away is now known as coolsvap03:54
*** kjorgensen has quit IRC03:54
*** e0ne has joined #openstack-rally04:08
*** harshs has joined #openstack-rally04:18
*** Liuqing has quit IRC04:20
*** Liuqing has joined #openstack-rally04:21
*** e0ne has quit IRC04:44
*** coolsvap is now known as coolsvap|away04:51
*** coolsvap|away is now known as coolsvap04:59
*** harshs has quit IRC05:06
*** baker has quit IRC05:10
*** harshs has joined #openstack-rally05:15
*** baker has joined #openstack-rally05:22
*** Aish has joined #openstack-rally05:30
*** Aish has left #openstack-rally05:33
*** psuriset_ has quit IRC05:54
*** arnoldje has quit IRC05:57
*** psuriset_ has joined #openstack-rally06:07
*** tfreger has joined #openstack-rally06:13
*** yfried has quit IRC06:18
*** baker has quit IRC06:33
*** baker has joined #openstack-rally06:33
*** baker has quit IRC06:33
*** harshs has quit IRC06:40
*** bkopilov has quit IRC06:59
*** psd has joined #openstack-rally07:11
*** _lnk_ has joined #openstack-rally07:13
*** bkopilov has joined #openstack-rally07:16
*** boris-42 has joined #openstack-rally07:16
*** baker has joined #openstack-rally07:17
*** baker has quit IRC07:22
*** anshul has joined #openstack-rally07:30
*** coolsvap is now known as coolsvap|away08:00
*** arxcruz has joined #openstack-rally08:05
*** yfried has joined #openstack-rally08:13
*** neeti has joined #openstack-rally08:16
*** ikhudoshyn_ has joined #openstack-rally08:17
*** ikhudoshyn has quit IRC08:19
*** ikhudoshyn_ is now known as ikhudoshyn08:19
*** amaretskiy has joined #openstack-rally08:24
*** adiantum has joined #openstack-rally08:29
*** yfried_ has joined #openstack-rally08:36
*** yfried has quit IRC08:36
*** jaypipes has joined #openstack-rally09:01
*** baker has joined #openstack-rally09:06
*** baker has quit IRC09:12
*** yfried_ has quit IRC09:20
*** chenli has quit IRC09:30
openstackgerritSergey Skripnick proposed openstack/rally: Add heat siege workload scenario  https://review.openstack.org/27251009:32
*** yingjun has quit IRC09:34
*** yfried_ has joined #openstack-rally09:36
*** shausy has joined #openstack-rally09:47
*** baker has joined #openstack-rally10:00
*** jjmb has quit IRC10:02
*** jjmb has joined #openstack-rally10:02
*** baker has quit IRC10:05
*** Liuqing has quit IRC10:13
*** adiantum has quit IRC10:17
*** rcernin has joined #openstack-rally10:18
*** sverma has joined #openstack-rally10:22
*** kjorgensen has joined #openstack-rally10:25
*** kjorgensen has quit IRC10:29
openstackgerritSergey Skripnick proposed openstack/rally: Add heat siege workload scenario  https://review.openstack.org/27251010:30
openstackgerritSergey Skripnick proposed openstack/rally: Add heat siege workload scenario  https://review.openstack.org/27251010:31
*** tfreger has quit IRC10:35
*** aix has joined #openstack-rally10:42
openstackgerritSergey Skripnick proposed openstack/rally: Add heat siege workload scenario  https://review.openstack.org/27251010:42
*** bkopilov has quit IRC10:46
openstackgerritBo Chi proposed openstack/rally: Use dict and set comprehension instead of using dict() and set()  https://review.openstack.org/27344910:47
openstackgerritMerged openstack/rally: Remove the extra 'g' in description for plugin show  https://review.openstack.org/27332010:57
*** psd has quit IRC10:59
openstackgerritMerged openstack/rally: Default cinder to v2  https://review.openstack.org/27285310:59
*** bkopilov has joined #openstack-rally11:01
*** jaypipes has quit IRC11:06
*** bochi-michael has quit IRC11:09
*** yingjun has joined #openstack-rally11:11
*** tosky has joined #openstack-rally11:12
*** jaypipes has joined #openstack-rally11:14
openstackgerritSergey Skripnick proposed openstack/rally: Add heat siege workload scenario  https://review.openstack.org/27251011:22
redixinamaretskiy ikhudoshyn please take a look: https://review.openstack.org/#/c/272510/17/rally/plugins/openstack/scenarios/vm/vmtasks.py11:26
redixinwe need to merge this today -_-11:26
redixinplease please11:27
amaretskiyredixin: ok11:27
amaretskiyredixin: looking.....11:27
ikhudoshynredixin: will do)) gimme couple minutes11:27
redixinhere is results https://rally-ci.tk/logs/_rci_task_FCNBGVlOZW/mos-7.0/rally-plot/report.html#/VMTasks.runcommand_heat/output11:28
amaretskiyredixin: FYI patch https://review.openstack.org/#/c/272989/11:31
amaretskiyredixin: mentioned patch fixes overlapping (long) Y-values11:31
redixinamaretskiy: deal11:31
amaretskiyredixin: also it makes description field optional11:32
amaretskiyredixin: and has auto transformation grapth -> table if there is 1 iteration11:32
amaretskiyredixin: all your requirements are there implemented :)11:32
ikhudoshynredixin amaretskiy https://review.openstack.org/#/c/264701/ )))11:33
amaretskiyikhudoshyn: i know I know :) will review today!!!11:34
ikhudoshyntnx )11:34
ikhudoshynredixin amaretskiy https://review.openstack.org/#/c/263759 this one is much easier -- just a docstring11:35
amaretskiyikhudoshyn: -1 for https://review.openstack.org/#/c/263759/ but I can re-review this patch immediately when you submit new patch set11:40
*** aix has quit IRC11:46
*** baker has joined #openstack-rally11:49
ikhudoshynamaretskiy: I guess you are right)) will do smth11:50
openstackgerritIllia Khudoshyn proposed openstack/rally: Add note about the fact that Rally won't use testtools' assertions  https://review.openstack.org/26375911:52
ikhudoshynamaretskiy: ^^ check this out11:52
*** baker has quit IRC11:53
*** akrzos has quit IRC11:59
amaretskiyikhudoshyn: done12:00
ikhudoshyntnx12:00
*** e0ne has joined #openstack-rally12:06
*** aix has joined #openstack-rally12:17
*** e0ne has quit IRC12:27
*** e0ne has joined #openstack-rally12:27
*** akrzos has joined #openstack-rally12:35
*** baker has joined #openstack-rally12:43
*** baker has quit IRC12:47
*** psd has joined #openstack-rally13:00
*** asti has joined #openstack-rally13:17
*** _lnk_ has quit IRC13:19
*** neeti has quit IRC13:27
*** e0ne has quit IRC13:29
*** Liuqing has joined #openstack-rally13:32
*** stpierre has joined #openstack-rally13:43
*** Liuqing has quit IRC13:44
*** Liuqing has joined #openstack-rally13:47
openstackgerritSergey Skripnick proposed openstack/rally: Add heat siege workload scenario  https://review.openstack.org/27251013:50
*** Liuqing has quit IRC13:52
*** MaxPC has joined #openstack-rally14:00
*** shausy has quit IRC14:17
*** e0ne has joined #openstack-rally14:19
*** gubouvier has joined #openstack-rally14:28
*** diogogmt has quit IRC14:28
*** diogogmt has joined #openstack-rally14:32
openstackgerritSergey Skripnick proposed openstack/rally: Add heat siege workload scenario  https://review.openstack.org/27251014:48
*** diogogmt has quit IRC14:49
amaretskiyikhudoshyn ping14:50
ikhudoshynamaretskiy: sup14:50
amaretskiyikhudoshyn I'm trying to check rally db upgrade14:51
amaretskiyI recreate db14:51
ikhudoshynany issues?14:51
amaretskiythen change Deployment model (add extra field)14:51
amaretskiywhat should I do more to make a real upgrade to new model?14:52
boris-42amaretskiy: you need to generate a migration script14:52
ikhudoshynsee README: you should make a revision 'alembic --config .... revision' it will try to generate one ^^14:53
ikhudoshynrecheck that script14:53
ikhudoshynso that it makes sense what does14:53
ikhudoshynthen do rally-manage db upgrade14:53
amaretskiylooks working14:54
amaretskiythanks14:54
ikhudoshynwelcome14:54
*** harshs has joined #openstack-rally15:01
ikhudoshynandreykurilin boris-42: I'm about to move migrations README.rst to our doc and include it into source/index.rst. Any objections?15:02
*** baker has joined #openstack-rally15:02
*** jjmb has quit IRC15:04
boris-42ikhudoshyn: do just symlink15:07
openstackgerritIllia Khudoshyn proposed openstack/rally: Integrate Rally & Alembic  https://review.openstack.org/26470115:20
*** diogogmt has joined #openstack-rally15:21
*** dsandler has joined #openstack-rally15:22
*** diogogmt has quit IRC15:23
*** dsandler has quit IRC15:25
*** arnoldje has joined #openstack-rally15:32
openstackgerritIllia Khudoshyn proposed openstack/rally: Integrate Rally & Alembic  https://review.openstack.org/26470115:39
openstackgerritRoman Vasilets proposed openstack/rally: [WIP]Add Image content upload context  https://review.openstack.org/26653115:40
*** baker_ has joined #openstack-rally15:45
*** baker has quit IRC15:48
*** dspano has joined #openstack-rally15:52
*** ylobankov has joined #openstack-rally15:53
*** dspano has quit IRC15:54
*** dspano has joined #openstack-rally15:55
*** yingjun has quit IRC16:00
*** diogogmt has joined #openstack-rally16:02
*** baker has joined #openstack-rally16:03
*** baker_ has quit IRC16:07
*** aix has quit IRC16:08
*** ylobankov has quit IRC16:22
*** ylobankov has joined #openstack-rally16:23
*** ylobankov has quit IRC16:24
*** anshul has quit IRC16:25
*** sudhirverma has joined #openstack-rally16:43
*** kjorgensen has joined #openstack-rally16:58
*** kjorgensen has quit IRC16:58
*** kjorgensen has joined #openstack-rally16:58
openstackgerritSergey Skripnick proposed openstack/rally: Add heat siege workload scenario  https://review.openstack.org/27251017:05
*** jaypipes has quit IRC17:06
*** diogogmt has quit IRC17:06
openstackgerritJordan Pittier proposed openstack/rally: Revert "Use assertTrue/False instead of assertEqual(T/F)"  https://review.openstack.org/27366817:10
*** yfried_ has quit IRC17:14
*** e0ne has quit IRC17:15
*** diogogmt has joined #openstack-rally17:24
*** acruz has joined #openstack-rally17:31
*** arxcruz has quit IRC17:33
*** asti has quit IRC17:38
*** madhu_ak has joined #openstack-rally17:39
*** asti has joined #openstack-rally17:40
*** asti has left #openstack-rally17:40
*** harshs has quit IRC17:59
*** boris-42 has quit IRC18:13
*** baker has quit IRC18:31
*** e0ne has joined #openstack-rally18:34
openstackgerritKyle Jorgensen proposed openstack/rally: Ensure image['..'] does not throw KeyError  https://review.openstack.org/27286518:44
*** marcoceppi is now known as marcoceppi|airpl18:49
*** pvaneck has joined #openstack-rally18:55
*** baker has joined #openstack-rally18:55
*** harshs has joined #openstack-rally18:56
*** marcoceppi|airpl is now known as marcoc|airplane19:07
*** psuriset_ has quit IRC19:16
*** tosky has quit IRC19:17
*** Aish has joined #openstack-rally19:24
*** sudhirverma has quit IRC19:25
*** yfried_ has joined #openstack-rally19:25
*** psuriset_ has joined #openstack-rally19:30
*** josdotso has joined #openstack-rally19:50
*** josdotso has quit IRC19:59
*** psuriset_ has quit IRC20:02
*** yfried_ has quit IRC20:09
*** yfried_ has joined #openstack-rally20:09
*** ylobankov has joined #openstack-rally20:12
*** KimJ has joined #openstack-rally20:59
*** rcernin has quit IRC21:02
*** madhu_ak has quit IRC21:05
*** gubouvier has quit IRC21:09
*** MaxPC has quit IRC21:13
*** madhu_ak has joined #openstack-rally21:22
*** akrzos has quit IRC21:27
*** rcernin has joined #openstack-rally21:27
*** baker has quit IRC21:42
*** psd has quit IRC21:49
*** yfried_ has quit IRC22:08
*** yfried_ has joined #openstack-rally22:08
kjorgensenrvasilets: are you online?22:10
*** e0ne has quit IRC22:22
*** rvasilets___ has joined #openstack-rally22:37
*** rvasilets__ has joined #openstack-rally22:37
rvasilets__kjorgensen: Hi, why you decide to revert changes?)22:38
kjorgensenHi, I just added another comment on the review22:39
kjorgensenGoing through the code review process has helped me to fully understand the cause of the bug I am aiming to fix. The main change that is needed is to use the .get() method on 'image' variable to prevent KeyError. The 'or 0' is still needed for when the values are explicitly set to 'None'. I believe this is the simplest solution, without the need for changing the logic in any tests.22:39
kjorgensenI believe this will pass the CI now, it was failing on my previous patches22:40
rvasilets__I have wrote you above changes in tests)22:40
rvasilets__You are writing tests to the code)22:41
rvasilets__This is strange reason not to change code=)22:41
kjorgensenIt's my first contribution, I was just trying to make a simple fix :)22:42
rvasilets__okey22:42
kjorgensendidn't expect to need to change tests too22:42
rvasilets__but you was too close to the best solution)22:42
rvasilets__and then turn  back)22:43
kjorgensenDid you see my comment here? https://review.openstack.org/#/c/272865/3/tests/unit/task/test_validation.py@47922:43
kjorgensenI wasn't sure if it was best to change that or not? (with the solution you proposed)22:44
rvasilets__Yes I saw. I left you the code that you could just copy-paste-)22:45
rvasilets__Ok lets imagine 3th patchset22:45
rvasilets__the best solution is...22:46
rvasilets__https://review.openstack.org/#/c/272865/3/rally/task/validation.py delete line 25922:46
rvasilets__and https://review.openstack.org/#/c/272865/3/tests/unit/task/test_validation.py instead line 267 write...22:47
rvasilets__self.assertEqual({"image": "image_id", "min_disk": 0,"min_ram": 0, "size": 0}, result[1])22:47
rvasilets__thats all)22:47
rvasilets__Why the last is needed?22:47
*** harshs has quit IRC22:48
rvasilets__because in assertEqual first argument should be expected22:48
rvasilets__second - actual22:48
kjorgensenHowever on patch 3 I still had a CI failure http://logs.openstack.org/65/272865/3/check/gate-rally-python34/2064e1e/testr_results.html.gz22:49
rvasilets__And this would be shown in output of assertEqual in cause of assert22:49
kjorgensenbecause of line 478 in test_validation.py it sets it explicitly to None22:50
rvasilets__Yes and this should be changed22:50
rvasilets__because after you patch22:50
rvasilets__3th22:50
rvasilets__it can't be None22:51
rvasilets__and this is invalid  testcase22:51
kjorgensenOk, what should it be changed to?22:51
rvasilets__And you could remove 479-481 lines22:51
kjorgensenok, so just remove that validation test?22:53
rvasilets__line 479-48122:53
kjorgensenthanks for the clarification! I will submit "best" patch now :)22:55
rvasilets__ok)22:55
rvasilets__I'll try to give you my +2 as fast as I can)22:56
*** e0ne has joined #openstack-rally22:56
*** e0ne_ has joined #openstack-rally23:00
*** e0ne has quit IRC23:02
*** arnoldje has quit IRC23:11
openstackgerritKyle Jorgensen proposed openstack/rally: Ensure image['..'] does not throw KeyError  https://review.openstack.org/27286523:17
rvasilets__kjorgensen: ok, great. you first approve, from me)23:21
kjorgensenrvasilets__: thank you!23:21
*** jjmb has joined #openstack-rally23:26
*** e0ne_ has quit IRC23:27
*** dspano has quit IRC23:28
*** ylobankov has quit IRC23:36
*** harshs has joined #openstack-rally23:40
*** akrzos has joined #openstack-rally23:44
openstackgerritMerged openstack/rally: Add note about the fact that Rally won't use testtools' assertions  https://review.openstack.org/26375923:55
*** harshs has quit IRC23:59
« Wednesday, 2016-01-27 Index Friday, 2016-01-29 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!