*** sdake_ has quit IRC | 00:10 | |
*** bobh has joined #openstack-release | 00:36 | |
*** sdake has joined #openstack-release | 00:48 | |
*** sdake has quit IRC | 01:30 | |
*** sdake has joined #openstack-release | 01:32 | |
*** sdake has quit IRC | 01:33 | |
*** craigbr has joined #openstack-release | 02:02 | |
*** craigbr has quit IRC | 02:13 | |
*** bobh has quit IRC | 02:21 | |
*** dims has quit IRC | 02:43 | |
*** yanyanhu has joined #openstack-release | 03:19 | |
*** bobh has joined #openstack-release | 03:22 | |
*** bobh has quit IRC | 03:26 | |
*** bobh has joined #openstack-release | 05:23 | |
*** bobh has quit IRC | 05:28 | |
*** amotoki has joined #openstack-release | 05:31 | |
*** craigbr has joined #openstack-release | 05:33 | |
*** craigbr has quit IRC | 06:03 | |
*** hyakuhei has quit IRC | 06:04 | |
*** oanson has joined #openstack-release | 06:41 | |
*** oanson has quit IRC | 07:01 | |
*** oanson has joined #openstack-release | 07:02 | |
*** bobh has joined #openstack-release | 07:25 | |
*** bobh has quit IRC | 07:30 | |
*** frickler has quit IRC | 07:34 | |
*** ihrachys has joined #openstack-release | 07:49 | |
*** pcaruana has joined #openstack-release | 07:57 | |
*** shardy has joined #openstack-release | 07:58 | |
*** sdake has joined #openstack-release | 08:07 | |
*** jpich has joined #openstack-release | 08:48 | |
*** sdake has quit IRC | 09:05 | |
*** ihrachys has quit IRC | 09:07 | |
*** openstackgerrit has quit IRC | 09:47 | |
*** openstackgerrit has joined #openstack-release | 09:48 | |
*** ihrachys has joined #openstack-release | 09:49 | |
*** yanyanhu has quit IRC | 10:02 | |
*** dtantsur|afk is now known as dtantsur | 10:30 | |
*** electrofelix has joined #openstack-release | 10:53 | |
*** dave-mccowan has joined #openstack-release | 12:01 | |
*** shardy is now known as shardy_lunch | 12:09 | |
*** rtheis has joined #openstack-release | 12:17 | |
*** lucasagomes is now known as lucas-hungry | 12:30 | |
*** rhallisey has joined #openstack-release | 12:32 | |
openstackgerrit | Witold Bedyk proposed openstack/releases: Release monasca-grafana-datasource 1.0.0 for Newton https://review.openstack.org/395595 | 12:42 |
---|---|---|
*** bobh has joined #openstack-release | 13:00 | |
*** bobh has quit IRC | 13:00 | |
*** bobh has joined #openstack-release | 13:01 | |
openstackgerrit | Vitaly Gridnev proposed openstack/releases: [sahara] ocata-1 release https://review.openstack.org/397178 | 13:05 |
*** vgridnev has joined #openstack-release | 13:20 | |
*** gordc has joined #openstack-release | 13:23 | |
*** sdake has joined #openstack-release | 13:24 | |
*** bobh has quit IRC | 13:28 | |
*** shardy_lunch is now known as shardy | 13:31 | |
*** dims has joined #openstack-release | 13:35 | |
dims | good afternoon/morning ttx, dhellmann | 13:36 |
*** lucas-hungry is now known as lucasagomes | 13:43 | |
*** mriedem has joined #openstack-release | 13:58 | |
ttx | dims: o/ | 14:01 |
*** oanson has quit IRC | 14:05 | |
*** bobh has joined #openstack-release | 14:07 | |
*** pcaruana has quit IRC | 14:16 | |
*** craigbr has joined #openstack-release | 14:26 | |
*** craigbr has quit IRC | 14:26 | |
*** mriedem has quit IRC | 14:31 | |
*** bobh has quit IRC | 14:54 | |
*** mriedem has joined #openstack-release | 15:01 | |
*** craigbr has joined #openstack-release | 15:18 | |
*** oanson has joined #openstack-release | 15:23 | |
*** hongbin has joined #openstack-release | 15:32 | |
*** vgridnev has quit IRC | 15:33 | |
*** craigbr has left #openstack-release | 15:35 | |
*** oanson has quit IRC | 15:39 | |
dhellmann | dims, ttx: o/ | 15:40 |
*** dtantsur is now known as dtantsur|brb | 15:50 | |
*** cody-somerville has joined #openstack-release | 16:13 | |
*** cody-somerville has quit IRC | 16:13 | |
*** cody-somerville has joined #openstack-release | 16:13 | |
*** ramishra has quit IRC | 16:18 | |
*** ramishra has joined #openstack-release | 16:20 | |
*** pcaruana has joined #openstack-release | 16:24 | |
*** dtantsur|brb is now known as dtantsur | 16:27 | |
openstackgerrit | Sean McGinnis proposed openstack/releases: Release final Cinder Liberty 7.0.3 https://review.openstack.org/397282 | 16:31 |
*** Jeffrey4l has quit IRC | 16:33 | |
*** amotoki has quit IRC | 16:39 | |
*** beekneemech is now known as bnemec | 16:40 | |
*** hongbin has quit IRC | 16:43 | |
*** mriedem has quit IRC | 16:43 | |
*** mriedem has joined #openstack-release | 16:46 | |
*** weshay is now known as weshay_brb | 16:46 | |
*** shardy has quit IRC | 16:51 | |
openstackgerrit | Merged openstack/releases: 3.2.0 swiftclient release https://review.openstack.org/396418 | 16:58 |
openstackgerrit | Merged openstack/releases: Release os-client-config 1.23.0 https://review.openstack.org/396790 | 17:00 |
amrith | dhellmann, ttx, dims .. re: ocata.1 deadline this thursday. the trove gate has been broken by some recent neutron change and we're not able to get the things we want merged. I'm hoping we can get it unwedged and merge the things we want in time but it may be close, or we may be a bit late. heads-up ... | 17:05 |
dhellmann | amrith : the early milestones are really more time based than feature, so we don't do "late" so much as "missing a feature" | 17:06 |
openstackgerrit | Merged openstack/releases: Release XStatic-roboto-fontface 0.5.0.0 https://review.openstack.org/396674 | 17:06 |
amrith | dhellmann, yes. last time (newton) we had that distinction, I was hoping to not get the same distinction again ;) | 17:06 |
openstackgerrit | Merged openstack/releases: Release XStatic-font-awesome 4.7.0.0 https://review.openstack.org/396672 | 17:06 |
openstackgerrit | Merged openstack/releases: Release XStatic-Bootswatch 3.3.7.0 https://review.openstack.org/396680 | 17:06 |
openstackgerrit | Merged openstack/releases: Release of networking-sfc for Newton https://review.openstack.org/396380 | 17:07 |
amrith | but I can tag the branch by thursday, it just wouldn't be as far along as I'd have liked. | 17:07 |
amrith | thx dhellmann | 17:07 |
dhellmann | understood | 17:07 |
openstackgerrit | Merged openstack/releases: Release syntribos 0.3.0 https://review.openstack.org/395844 | 17:07 |
*** sdake has quit IRC | 17:10 | |
*** sdake has joined #openstack-release | 17:13 | |
*** weshay_brb is now known as weshay | 17:29 | |
*** ihrachys has quit IRC | 17:30 | |
*** sdake_ has joined #openstack-release | 17:34 | |
*** jpich has quit IRC | 17:36 | |
*** sdake has quit IRC | 17:37 | |
*** lucasagomes is now known as lucas-afk | 17:42 | |
*** armax has joined #openstack-release | 17:49 | |
*** devananda|away is now known as devananda | 17:52 | |
*** trown is now known as trown|lunch | 17:56 | |
*** BobBall is now known as BobBall_AWOL | 17:58 | |
*** electrofelix has quit IRC | 18:00 | |
*** dtantsur is now known as dtantsur|afk | 18:09 | |
*** bobh has joined #openstack-release | 18:24 | |
*** Jeffrey4l has joined #openstack-release | 18:31 | |
*** trown|lunch is now known as trown | 18:59 | |
*** bobh has quit IRC | 19:02 | |
*** myoung|afk is now known as myoung | 19:23 | |
openstackgerrit | Boris Bobrov proposed openstack/releases: Release python-keystoneclient 3.7.0 https://review.openstack.org/397344 | 19:24 |
dhellmann | stevemar : is 0bfd6251b674c998680ee0018fc95f47e1d26fe6 a backwards-incompatible change to python-keystoneclient? | 19:39 |
stevemar | dhellmann: i doubt it ever worked | 19:41 |
dhellmann | I don't even know what that's doing. Is that the request id chaining thing? | 19:41 |
stevemar | dhellmann: it was copy-pasta from the oslo-incubator apiclient https://github.com/openstack/python-keystoneclient/commit/16e834dd4597314d79cf4fb0bb98449e6552f804 | 19:42 |
stevemar | looking at blame | 19:43 |
dhellmann | well, yeah, that makes sense. that doesn't make it wrong. | 19:43 |
dhellmann | the folks that were doing request-id chaining started in the incubator | 19:43 |
stevemar | eh, maybe we removed if from self.manager.client.... | 19:43 |
dhellmann | it seems like we want to get to the bottom of the origin of that before releasing this version, because I'd hate to break a bunch of work those folks did | 19:44 |
stevemar | there was a bug related to it... https://bugs.launchpad.net/keystone/+bug/1637530 | 19:45 |
openstack | Launchpad bug 1637530 in python-keystoneclient "Python keystone client `users` method get() is not working" [Undecided,Fix released] - Assigned to Boris Bobrov (bbobrov) | 19:45 |
*** hongbin has joined #openstack-release | 19:45 | |
dims | dhellmann : stevemar : i believe it was abhishekk (https://launchpad.net/~abhishek-kekane) who was working on that | 19:48 |
*** breton has joined #openstack-release | 19:48 | |
breton | o/ | 19:48 |
dims | hey breton ! | 19:48 |
stevemar | breton: we're in trouble now | 19:49 |
breton | dhellmann: it has not worked for several releases, at least since the start of newton | 19:50 |
stevemar | breton: did we remove the "request_id" attribute from the manager/client somewhere? | 19:51 |
dhellmann | breton : what does "it has not worked" mean, though? it does nothing? it produces an error? | 19:52 |
breton | dhellmann: *** AttributeError: '_KeystoneAdapter' object has no attribute 'last_request_id' | 19:53 |
breton | dhellmann: https://bugs.launchpad.net/keystone/+bug/1637530 | 19:53 |
openstack | Launchpad bug 1637530 in python-keystoneclient "Python keystone client `users` method get() is not working" [Undecided,Fix released] - Assigned to Boris Bobrov (bbobrov) | 19:53 |
dhellmann | ok. so it sounds like you all broke your internal api and didn't have good test coverage for it | 19:53 |
dhellmann | I'm not sure the answer to that problem is removing the feature that relied on the thing that broke | 19:53 |
breton | i need to drop off, will be back in 2-3h | 19:54 |
stevemar | might be easier to remove it now and fix the immediate bug it created, and then try to get request_id back in | 19:54 |
stevemar | since, no one seemed to notice when we broke it interally the first time | 19:55 |
dhellmann | stevemar : I'll let you make the call, I guess. Either update the major version number to indicate that you're dropping the feature or hold the release and fix that internal issue. | 19:55 |
dhellmann | yes, I suspect this feature is either not fully implemented or not being used | 19:55 |
dhellmann | I wonder how much other client functionality we don't have test coverage for because we're not using the clients in OSC and therefore d-g any more | 19:56 |
stevemar | we still use the api bindings in osc | 19:57 |
stevemar | dhellmann: let me chat with breton some more on the matter | 19:57 |
stevemar | when he is back online | 19:57 |
dhellmann | stevemar : sounds good, I'll watch for an update on the review | 19:57 |
stevemar | thanks for keeping us honest | 19:57 |
*** sdake_ is now known as sdake | 20:11 | |
*** cody-somerville has quit IRC | 20:27 | |
*** ianychoi has quit IRC | 20:29 | |
*** pcaruana has quit IRC | 20:45 | |
openstackgerrit | Monty Taylor proposed openstack/releases: Release os-client-config 1.24.0 https://review.openstack.org/397369 | 20:51 |
*** rtheis has quit IRC | 20:56 | |
openstackgerrit | Merged openstack/releases: Release os-client-config 1.24.0 https://review.openstack.org/397369 | 21:04 |
*** Rockyg has joined #openstack-release | 21:04 | |
*** spzala has joined #openstack-release | 21:15 | |
*** cody-somerville has joined #openstack-release | 21:27 | |
*** cody-somerville has quit IRC | 21:27 | |
*** cody-somerville has joined #openstack-release | 21:27 | |
*** Jeffrey4l has quit IRC | 21:34 | |
*** trown is now known as trown|outtypewww | 21:53 | |
breton | why do we think that this last_request_id thing was ever working? | 21:57 |
breton | and why do we think that request_id chaining ever existed in keystoneclient? | 21:57 |
breton | stevemar: dhellmann: i think that the last_request_id thing didn't work at least since 2.0.0 | 22:05 |
breton | stevemar: dhellmann: i've asked to verify it for 3.0.0 | 22:07 |
breton | stevemar: dhellmann: and from reading the code i don't see how it could work for 2.0.0, because the only mention of last_request_id is in oslo-incubator's apiclient, and it the apiclient is not used anywhere. | 22:08 |
breton | s/it the apiclient/the apiclient/ | 22:09 |
*** hyakuhei has joined #openstack-release | 22:13 | |
*** gordc has quit IRC | 22:17 | |
*** dave-mccowan has quit IRC | 22:38 | |
*** hyakuhei has quit IRC | 22:42 | |
*** hyakuhei has joined #openstack-release | 22:42 | |
*** hyakuhei has quit IRC | 22:42 | |
*** hyakuhei has joined #openstack-release | 22:42 | |
*** spzala has quit IRC | 22:56 | |
*** hongbin has quit IRC | 23:05 | |
*** Jeffrey4l has joined #openstack-release | 23:31 | |
*** mriedem has quit IRC | 23:43 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!