*** kzaitsev_mb has joined #openstack-release | 00:39 | |
*** zhurong has joined #openstack-release | 00:45 | |
*** ricolin has joined #openstack-release | 00:45 | |
*** kzaitsev_mb has quit IRC | 00:53 | |
*** hongbin has quit IRC | 00:54 | |
*** inc0 has quit IRC | 01:11 | |
*** inc0 has joined #openstack-release | 01:11 | |
*** ianychoi has joined #openstack-release | 01:14 | |
*** zhurong has quit IRC | 01:33 | |
*** zhurong has joined #openstack-release | 01:35 | |
*** kzaitsev_mb has joined #openstack-release | 01:49 | |
*** kzaitsev_mb has quit IRC | 01:56 | |
*** mriedem has quit IRC | 01:56 | |
*** toabctl has quit IRC | 02:11 | |
*** toabctl has joined #openstack-release | 02:12 | |
*** ekcs_ has joined #openstack-release | 02:15 | |
*** yamahata has quit IRC | 02:18 | |
*** kzaitsev_mb has joined #openstack-release | 02:54 | |
*** kzaitsev_mb has quit IRC | 03:00 | |
*** ekcs_ has quit IRC | 03:08 | |
*** dave-mccowan has quit IRC | 03:31 | |
*** hongbin has joined #openstack-release | 03:51 | |
*** amotoki_away is now known as amotoki | 03:55 | |
*** kzaitsev_mb has joined #openstack-release | 03:57 | |
*** kzaitsev_mb has quit IRC | 04:08 | |
*** gcb has quit IRC | 04:24 | |
*** gcb has joined #openstack-release | 04:24 | |
*** zhurong has quit IRC | 04:28 | |
*** EmilienM has quit IRC | 04:30 | |
*** EmilienM has joined #openstack-release | 04:35 | |
*** zhurong has joined #openstack-release | 04:38 | |
*** qwertyco has joined #openstack-release | 04:58 | |
*** hongbin has quit IRC | 05:03 | |
*** kzaitsev_mb has joined #openstack-release | 05:04 | |
*** hongbin has joined #openstack-release | 05:07 | |
*** kzaitsev_mb has quit IRC | 05:09 | |
*** hyakuhei has quit IRC | 05:11 | |
*** yamahata has joined #openstack-release | 05:14 | |
*** zhurong has quit IRC | 05:17 | |
*** hongbin_ has joined #openstack-release | 05:19 | |
*** udesale has joined #openstack-release | 05:19 | |
*** hongbin has quit IRC | 05:20 | |
*** zhurong has joined #openstack-release | 05:21 | |
*** hongbin has joined #openstack-release | 05:23 | |
*** hongbin_ has quit IRC | 05:24 | |
*** hongbin_ has joined #openstack-release | 05:26 | |
*** hongbin has quit IRC | 05:27 | |
*** hongbin has joined #openstack-release | 05:28 | |
*** hongbin_ has quit IRC | 05:30 | |
*** hongbin_ has joined #openstack-release | 05:30 | |
*** hongbin__ has joined #openstack-release | 05:33 | |
*** hongbin has quit IRC | 05:33 | |
*** hongbin_ has quit IRC | 05:34 | |
*** hongbin has joined #openstack-release | 05:35 | |
*** hongbin__ has quit IRC | 05:37 | |
*** hongbin_ has joined #openstack-release | 05:38 | |
*** hongbin has quit IRC | 05:40 | |
*** hongbin has joined #openstack-release | 05:42 | |
*** hongbin_ has quit IRC | 05:43 | |
*** kzaitsev_mb has joined #openstack-release | 05:47 | |
*** kzaitsev_mb has quit IRC | 06:13 | |
*** yamahata has quit IRC | 06:45 | |
*** Guest11 has joined #openstack-release | 06:53 | |
*** Jeffrey4l has left #openstack-release | 06:55 | |
*** hongbin_ has joined #openstack-release | 06:59 | |
*** therve has joined #openstack-release | 07:01 | |
ttx | <therve> dhellmann, ttx: https://review.openstack.org/#/c/469966/ seems to be breaking heat release notes :/ | 07:01 |
---|---|---|
therve | ttx, Hey! | 07:01 |
ttx | therve: would you have an example of breakage ? | 07:01 |
therve | So looking into it, it may not be that change | 07:01 |
*** hongbin has quit IRC | 07:01 | |
therve | ttx, Heat master, but I have a CI link, one sec | 07:01 |
therve | http://logs.openstack.org/95/471595/3/check/gate-heat-releasenotes/51c9976/ | 07:01 |
therve | It loops forever | 07:01 |
therve | It's definitely reno 2.4 though | 07:02 |
ttx | Hmm, could be that "continue" on line 736 of http://git.openstack.org/cgit/openstack/reno/commit/?id=bd6fecc8587ee919eba78b9fd70a17e6a5ad510a | 07:05 |
ttx | I'll try to reproduce in a few | 07:07 |
*** hongbin has joined #openstack-release | 07:08 | |
therve | ttx, Replacing that by a break unblocks the situation indeed | 07:08 |
therve | Doesn't seem the right thing to do though :) | 07:09 |
*** hongbin_ has quit IRC | 07:11 | |
*** d0ugal has joined #openstack-release | 07:12 | |
*** hongbin has quit IRC | 07:13 | |
*** hongbin has joined #openstack-release | 07:18 | |
*** hongbin_ has joined #openstack-release | 07:21 | |
ttx | It's almost certainly not the right thing to do :) | 07:21 |
*** hongbin has quit IRC | 07:22 | |
*** hongbin has joined #openstack-release | 07:23 | |
*** jpich has joined #openstack-release | 07:24 | |
*** hongbin_ has quit IRC | 07:25 | |
*** Guest11 has quit IRC | 07:28 | |
therve | ttx, Replacing todo.appendleft by todo.append worked, though | 07:28 |
ttx | yeah that popleft/appendleft/continue combo looked promising | 07:29 |
therve | Fortunately this area has some tests :) | 07:30 |
ttx | no kidding | 07:30 |
ttx | therve: if you're feeling lucky you can propose it, dhellmann will review it anyway | 07:30 |
therve | ttx, I'll poke around trying to understand what's going on | 07:31 |
ttx | I'll have alook when I'm done with my morning sync | 07:31 |
ttx | and got my coffee | 07:31 |
*** Guest11 has joined #openstack-release | 07:32 | |
*** gcb has quit IRC | 07:34 | |
*** gcb has joined #openstack-release | 07:37 | |
*** kzaitsev_mb has joined #openstack-release | 07:39 | |
*** tmorin has joined #openstack-release | 07:40 | |
*** tmorin has left #openstack-release | 07:40 | |
gcb | ttx: is it okay to make a new release which only includes patches like "Updated from global requirements"? | 07:41 |
*** shardy has joined #openstack-release | 07:43 | |
ttx | gcb: It's ok, but a bit pointless imho | 07:44 |
gcb | ttx: yes, I never do that before, so just make meaningful release which includes fix | 07:46 |
*** hongbin_ has joined #openstack-release | 07:47 | |
ttx | By the end of the cycle we need to have at least one, but weekly global-req updates sound overkill | 07:47 |
*** hongbin has quit IRC | 07:48 | |
*** amoralej|off is now known as amoralej | 07:52 | |
*** kzaitsev_mb has quit IRC | 07:52 | |
*** hongbin has joined #openstack-release | 08:21 | |
*** hongbin__ has joined #openstack-release | 08:23 | |
*** hongbin_ has quit IRC | 08:24 | |
*** lucas-afk is now known as lucasagomes | 08:25 | |
*** hongbin has quit IRC | 08:26 | |
*** hongbin has joined #openstack-release | 08:26 | |
*** hongbin__ has quit IRC | 08:28 | |
*** hongbin_ has joined #openstack-release | 08:30 | |
*** hongbin has quit IRC | 08:31 | |
*** pbandark has joined #openstack-release | 08:31 | |
openstackgerrit | Merged openstack/releases master: add untagged release model for devstack and grenade https://review.openstack.org/473499 | 08:39 |
*** electrofelix has joined #openstack-release | 08:40 | |
openstackgerrit | Merged openstack/releases master: request P2 release of congress and dashboard https://review.openstack.org/472399 | 08:41 |
*** ianychoi has quit IRC | 08:43 | |
*** hongbin has joined #openstack-release | 08:44 | |
*** hongbin_ has quit IRC | 08:45 | |
openstackgerrit | Thierry Carrez proposed openstack/releases master: Correct Newton phase II support date https://review.openstack.org/464683 | 08:46 |
openstackgerrit | Thierry Carrez proposed openstack/releases master: Confirm stable/mitaka as fully retired https://review.openstack.org/474114 | 08:46 |
*** hongbin_ has joined #openstack-release | 08:46 | |
openstackgerrit | Thierry Carrez proposed openstack/releases master: Add a note about Mitaka EOL to the index page https://review.openstack.org/456119 | 08:48 |
*** hongbin has quit IRC | 08:48 | |
*** kzaitsev_mb has joined #openstack-release | 08:48 | |
*** hongbin has joined #openstack-release | 08:49 | |
*** hongbin_ has quit IRC | 08:51 | |
*** Guest11 has quit IRC | 08:52 | |
*** hongbin_ has joined #openstack-release | 08:53 | |
*** kzaitsev_mb has quit IRC | 08:53 | |
*** hongbin has quit IRC | 08:53 | |
*** dtantsur|afk is now known as dtantsur | 09:13 | |
ttx | therve: as far as I can tell that appendleft should not create a loop, unless the heat master git graph is really funky (i.e. entry.commit.parents[0] == entry) | 09:25 |
therve | ttx, There is no loop at that moment, it seems to happen later on | 09:25 |
ttx | ah | 09:26 |
ttx | We'll see what dhellmann thinks of it | 09:28 |
*** zhurong has quit IRC | 09:40 | |
*** ianychoi has joined #openstack-release | 09:49 | |
*** kzaitsev_mb has joined #openstack-release | 09:50 | |
*** kzaitsev_mb has quit IRC | 09:59 | |
*** sdague has joined #openstack-release | 10:03 | |
*** hongbin_ has quit IRC | 10:27 | |
*** lucasagomes has quit IRC | 10:41 | |
*** ghs39ghsggf has joined #openstack-release | 10:45 | |
*** hoangcx has quit IRC | 10:46 | |
*** lucasagomes has joined #openstack-release | 10:52 | |
*** wolverineav has joined #openstack-release | 11:01 | |
*** udesale has quit IRC | 11:05 | |
*** claudiub has joined #openstack-release | 11:08 | |
*** hoangcx has joined #openstack-release | 11:10 | |
*** hoangcx has quit IRC | 11:11 | |
*** qwertyco has quit IRC | 11:25 | |
*** lucasagomes is now known as lucas-hungry | 11:31 | |
*** dtantsur is now known as dtantsur|brb | 11:33 | |
*** bobh has joined #openstack-release | 11:39 | |
*** bobh has quit IRC | 11:46 | |
*** wolverineav has quit IRC | 11:52 | |
*** wolverineav has joined #openstack-release | 11:54 | |
*** qwertyco has joined #openstack-release | 12:01 | |
openstackgerrit | Doug Hellmann proposed openstack/reno master: fix an infinite loop in the topo traversal algorithm https://review.openstack.org/474175 | 12:05 |
dhellmann | ttx, therve : ^^ removes the infinite loop, would you test it locally to see if it produces the expected output on your stable/newton branch? | 12:05 |
therve | dhellmann, Sure, will do! | 12:05 |
openstackgerrit | Doug Hellmann proposed openstack/reno master: fix an infinite loop in the topo traversal algorithm https://review.openstack.org/474175 | 12:07 |
dhellmann | that update just includes the release note that I always forget to add in the first patch | 12:07 |
* dhellmann steps away to make breakfast | 12:08 | |
*** kornicameister has quit IRC | 12:22 | |
*** alexchadin has joined #openstack-release | 12:29 | |
*** lucas-hungry is now known as lucasagomes | 12:33 | |
therve | dhellmann, Tested with heat master, it fixes the issue, and the output is the same as reno 2.3.2, so it looks promising | 12:37 |
*** bobh has joined #openstack-release | 12:37 | |
dhellmann | therve : great, thanks for confirming | 12:38 |
*** amoralej is now known as amoralej|lunch | 12:42 | |
dims | dhellmann : ttx : o/ | 12:52 |
dhellmann | o/ | 12:54 |
*** mriedem has joined #openstack-release | 13:10 | |
*** gcb has quit IRC | 13:14 | |
*** openstackgerrit has quit IRC | 13:18 | |
*** dave-mccowan has joined #openstack-release | 13:18 | |
*** alexchadin has quit IRC | 13:20 | |
*** ghs39ghsggf has quit IRC | 13:20 | |
*** dtantsur|brb is now known as dtantsur | 13:26 | |
*** amoralej|lunch is now known as amoralej | 13:29 | |
*** alexchadin has joined #openstack-release | 13:36 | |
*** zhurong has joined #openstack-release | 13:43 | |
ttx | dhellmann: looking at your patch -- trying to wrap my head around the situation that would trigger this. that would happen if the parent happens to be shared by multiple entries ? | 13:45 |
dhellmann | we don't want any nodes emitted more than once | 13:45 |
dhellmann | the emitted set is the thing that lets us do that | 13:45 |
dhellmann | there's a comment in there near the bottom of the loop that talks about checking emitted at the top of the loop, but I'm afraid inserting things into the todo list and then skipping them will change the output ordering | 13:46 |
dhellmann | so I have taken the approach of trying not to have things end up in the list more than once | 13:46 |
*** eranrom has quit IRC | 13:46 | |
ttx | ok, that makes sense. I guess I just don't see how the git graph would end up processing multiple times the same node, but that's my git-foo failing | 13:47 |
*** eranrom has joined #openstack-release | 13:47 | |
dhellmann | the same node can be the parent of multiple other nodes | 13:47 |
dhellmann | so as those are processed, the parent can be added back to the todo list | 13:48 |
dhellmann | I have to run an errand, but I | 13:48 |
dhellmann | I'll be back shortly | 13:48 |
ttx | no I'm good, thanks for the explanation | 13:48 |
ttx | It's null-merges I don't raelly understand :) | 13:48 |
*** Guest11 has joined #openstack-release | 13:49 | |
*** rosmaita has quit IRC | 13:50 | |
dhellmann | a null merge joins the 2 branches, but doesn't take any file changes. so it's an empty merge commit that just creates a link that you have to deal with when traversing | 13:51 |
*** eranrom has quit IRC | 13:52 | |
*** tmorin has joined #openstack-release | 13:55 | |
*** yamahata has joined #openstack-release | 13:55 | |
*** amotoki is now known as amotoki_away | 13:59 | |
*** tmorin has quit IRC | 14:03 | |
*** qwertyco has quit IRC | 14:13 | |
*** qwertyco has joined #openstack-release | 14:13 | |
*** Guest11 has quit IRC | 14:20 | |
*** qwertyco has quit IRC | 14:22 | |
*** qwertyco has joined #openstack-release | 14:22 | |
*** armax has joined #openstack-release | 14:27 | |
*** hongbin has joined #openstack-release | 14:37 | |
*** zhurong has quit IRC | 14:49 | |
*** alexchadin has quit IRC | 15:02 | |
*** qwertyco has quit IRC | 15:03 | |
*** qwertyco has joined #openstack-release | 15:04 | |
*** qwertyco has quit IRC | 15:12 | |
*** yamahata has quit IRC | 15:39 | |
*** armax has quit IRC | 15:40 | |
*** armax has joined #openstack-release | 15:40 | |
*** armax has quit IRC | 15:42 | |
*** Rockyg has joined #openstack-release | 15:59 | |
*** openstackgerrit has joined #openstack-release | 16:01 | |
openstackgerrit | Matt Riedemann proposed openstack/releases master: ocata: release nova 15.0.6 https://review.openstack.org/474259 | 16:01 |
*** yamahata has joined #openstack-release | 16:13 | |
*** cody-somerville has joined #openstack-release | 16:17 | |
*** csomerville has joined #openstack-release | 16:18 | |
*** cody-somerville has quit IRC | 16:22 | |
*** ricolin has quit IRC | 16:29 | |
ttx | dhellmann: shall we fast-track your fix and release a point release to unblock Heat ? | 16:31 |
*** dtantsur is now known as dtantsur|afk | 16:32 | |
ttx | logging off, but consider me +2 on that if needed | 16:34 |
*** armax has joined #openstack-release | 16:46 | |
*** eranrom has joined #openstack-release | 16:48 | |
*** jpich has quit IRC | 16:56 | |
*** electrofelix has quit IRC | 17:09 | |
*** lucasagomes is now known as lucas-afk | 17:16 | |
*** ghs39ghsggf has joined #openstack-release | 17:21 | |
*** ghs39ghsggf has left #openstack-release | 17:21 | |
*** shardy has quit IRC | 17:24 | |
*** pcaruana has quit IRC | 17:29 | |
*** ekcs_ has joined #openstack-release | 17:35 | |
*** ekcs has quit IRC | 17:38 | |
*** ekcs__ has joined #openstack-release | 17:38 | |
*** electrofelix has joined #openstack-release | 17:46 | |
*** bobh has quit IRC | 17:53 | |
*** amoralej is now known as amoralej|off | 18:09 | |
*** qwertyco has joined #openstack-release | 18:16 | |
*** Rockyg has quit IRC | 18:20 | |
*** electrofelix has quit IRC | 18:29 | |
*** Rockyg has joined #openstack-release | 18:35 | |
*** Rockyg has quit IRC | 18:37 | |
*** Guest11 has joined #openstack-release | 18:37 | |
*** ekcs__ has quit IRC | 18:39 | |
*** qwertyco has quit IRC | 18:47 | |
*** csomerville has quit IRC | 18:50 | |
dhellmann | ttx: yeah | 18:51 |
*** cody-somerville has joined #openstack-release | 18:51 | |
*** cody-somerville has quit IRC | 18:51 | |
*** cody-somerville has joined #openstack-release | 18:51 | |
*** bobh has joined #openstack-release | 18:54 | |
openstackgerrit | Merged openstack/reno master: fix an infinite loop in the topo traversal algorithm https://review.openstack.org/474175 | 18:55 |
openstackgerrit | Doug Hellmann proposed openstack/releases master: reno 2.4.1 https://review.openstack.org/474320 | 19:02 |
dhellmann | ttx, dims: does one of you want to look over ^^ | 19:02 |
*** kzaitsev_mb has joined #openstack-release | 19:03 | |
*** kzaitsev_mb has quit IRC | 19:12 | |
smcginnis | dhellmann: I'm seeing some release notes jobs timeout. I don't suppose this is a known issue with reno? | 19:26 |
dhellmann | smcginnis : yeah, reno 2.4.1 will have the fix | 19:28 |
dhellmann | smcginnis : https://review.openstack.org/#/c/474320/1 | 19:28 |
smcginnis | dhellmann: Awesome, thank you. | 19:28 |
openstackgerrit | Merged openstack/releases master: reno 2.4.1 https://review.openstack.org/474320 | 19:33 |
*** Guest11 has quit IRC | 20:26 | |
*** Guest11 has joined #openstack-release | 20:27 | |
*** Guest11 has quit IRC | 20:29 | |
*** pbandark has quit IRC | 20:48 | |
*** Guest11 has joined #openstack-release | 20:48 | |
*** abramley has quit IRC | 21:14 | |
*** kzaitsev_pi has quit IRC | 21:18 | |
*** kzaitsev1pi has joined #openstack-release | 21:18 | |
*** dave-mccowan has quit IRC | 21:26 | |
*** Guest11 has quit IRC | 21:29 | |
*** dave-mcc_ has joined #openstack-release | 21:31 | |
*** kzaitsev1pi has quit IRC | 21:42 | |
*** kzaitsev_pi has joined #openstack-release | 21:48 | |
*** bobh has quit IRC | 21:53 | |
*** kzaitsev_pi has quit IRC | 21:56 | |
*** kzaitsev_pi has joined #openstack-release | 21:58 | |
*** rakhmerov has quit IRC | 22:07 | |
*** rakhmerov has joined #openstack-release | 22:07 | |
*** armax has quit IRC | 22:09 | |
*** armax has joined #openstack-release | 22:15 | |
*** ekcs has joined #openstack-release | 22:23 | |
*** bobh has joined #openstack-release | 22:51 | |
*** bobh has quit IRC | 22:54 | |
*** wolverineav has quit IRC | 23:05 | |
*** wolverineav has joined #openstack-release | 23:07 | |
*** csomerville has joined #openstack-release | 23:14 | |
*** cody-somerville has quit IRC | 23:14 | |
*** claudiub has quit IRC | 23:15 | |
*** wolverineav has quit IRC | 23:23 | |
*** wolverineav has joined #openstack-release | 23:24 | |
*** wolverineav has quit IRC | 23:29 | |
*** sdague has quit IRC | 23:30 | |
*** hongbin has quit IRC | 23:46 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!