| *** dave-mcc_ has joined #openstack-release | 00:05 | |
| *** dave-mccowan has quit IRC | 00:07 | |
| *** bobh has joined #openstack-release | 00:35 | |
| *** bobh has quit IRC | 00:40 | |
| *** hongbin has joined #openstack-release | 00:43 | |
| *** zhurong has joined #openstack-release | 00:44 | |
| *** deep-book-gk has joined #openstack-release | 01:02 | |
| *** deep-book-gk has left #openstack-release | 01:03 | |
| *** liujiong has joined #openstack-release | 01:09 | |
| *** sdague has joined #openstack-release | 01:16 | |
| *** thorst has joined #openstack-release | 01:37 | |
| *** thorst has quit IRC | 01:41 | |
| *** liujiong has quit IRC | 01:50 | |
| *** liujiong has joined #openstack-release | 01:51 | |
| *** liujiong has quit IRC | 01:53 | |
| *** thorst has joined #openstack-release | 02:42 | |
| *** liujiong has joined #openstack-release | 02:44 | |
| *** liujiong has quit IRC | 02:45 | |
| *** liujiong has joined #openstack-release | 02:45 | |
| *** thorst has quit IRC | 02:47 | |
| *** ricolin has joined #openstack-release | 03:02 | |
| *** thorst has joined #openstack-release | 03:43 | |
| *** udesale has joined #openstack-release | 03:47 | |
| *** thorst has quit IRC | 03:48 | |
| *** junbo has joined #openstack-release | 04:07 | |
| *** udesale__ has joined #openstack-release | 04:31 | |
| *** udesale has quit IRC | 04:33 | |
| *** yamamoto has joined #openstack-release | 04:38 | |
| *** udesale__ has quit IRC | 04:38 | |
| *** Dinesh_Bhor has joined #openstack-release | 04:43 | |
| *** ekcs has quit IRC | 04:50 | |
| *** hongbin has quit IRC | 05:01 | |
| *** udesale__ has joined #openstack-release | 05:07 | |
| *** GK1wmSU has joined #openstack-release | 05:25 | |
| *** GK1wmSU has left #openstack-release | 05:27 | |
| *** dhellmann has quit IRC | 05:28 | |
| *** dhellmann has joined #openstack-release | 05:28 | |
| *** zhurong has quit IRC | 05:29 | |
| *** kornicameister has joined #openstack-release | 05:32 | |
| *** _GK1wmSU has joined #openstack-release | 05:39 | |
| *** _GK1wmSU has left #openstack-release | 05:39 | |
| *** thorst has joined #openstack-release | 05:44 | |
| *** thorst has quit IRC | 05:49 | |
| *** pcaruana has joined #openstack-release | 06:19 | |
| *** amotoki__ is now known as amotoki | 06:33 | |
| *** zhurong has joined #openstack-release | 06:47 | |
| *** amoralej|off is now known as amoralej | 06:58 | |
| yamamoto | does a removal of a deprecated plugin require an FFE? | 07:05 |
|---|---|---|
| ttx | yamamoto: it's impacting functionality, so it's probably worth a discussion with the PTL, but I would consider it a pre-release clean-up | 07:12 |
| yamamoto | ttx: ok. thank you | 07:12 |
| *** dhellmann has quit IRC | 07:30 | |
| *** dhellmann has joined #openstack-release | 07:31 | |
| *** alexchadin has joined #openstack-release | 07:31 | |
| *** dtantsur|afk is now known as dtantsur | 07:41 | |
| *** thorst has joined #openstack-release | 07:45 | |
| *** thorst has quit IRC | 07:50 | |
| *** udesale has joined #openstack-release | 07:58 | |
| *** udesale__ has quit IRC | 08:00 | |
| *** alexchad_ has joined #openstack-release | 08:00 | |
| *** yamamoto has quit IRC | 08:02 | |
| *** alexchadin has quit IRC | 08:02 | |
| *** alexchadin has joined #openstack-release | 08:04 | |
| *** alexcha__ has joined #openstack-release | 08:06 | |
| *** alexchad_ has quit IRC | 08:06 | |
| *** alexchadin has quit IRC | 08:08 | |
| *** alexchadin has joined #openstack-release | 08:12 | |
| *** alexchadin has quit IRC | 08:13 | |
| *** alexchadin has joined #openstack-release | 08:14 | |
| *** alexcha__ has quit IRC | 08:15 | |
| *** bauwser is now known as bauzas | 08:28 | |
| *** udesale__ has joined #openstack-release | 08:31 | |
| *** udesale has quit IRC | 08:34 | |
| *** zhurong has quit IRC | 08:41 | |
| *** pbandark has joined #openstack-release | 08:54 | |
| *** gtrxcb has quit IRC | 08:57 | |
| *** yamamoto has joined #openstack-release | 09:02 | |
| *** yamamoto has quit IRC | 09:08 | |
| *** yamamoto has joined #openstack-release | 09:08 | |
| *** jtomasek has joined #openstack-release | 09:20 | |
| *** jtomasek has quit IRC | 09:20 | |
| *** jtomasek has joined #openstack-release | 09:21 | |
| *** tosky has joined #openstack-release | 09:21 | |
| *** yamamoto has quit IRC | 09:25 | |
| *** jtomasek has quit IRC | 09:27 | |
| *** claudiub has joined #openstack-release | 09:27 | |
| *** yamamoto has joined #openstack-release | 09:34 | |
| *** zhurong has joined #openstack-release | 09:37 | |
| *** yamamoto has quit IRC | 09:40 | |
| *** thorst has joined #openstack-release | 09:46 | |
| *** yamamoto has joined #openstack-release | 09:53 | |
| ttx | dhellmann: Good question @ http://lists.openstack.org/pipermail/openstack-dev/2017-July/120328.html | 09:54 |
| ttx | or dims ^ | 09:55 |
| *** jtomasek has joined #openstack-release | 09:55 | |
| ttx | My initial thought was "sure you can, since that would default to master until we cut requirements branch after the freeze" but then it returns "Invalid branch: stable/pike" | 09:56 |
| *** thorst has quit IRC | 09:58 | |
| *** alexchadin has quit IRC | 10:11 | |
| *** liujiong has quit IRC | 10:18 | |
| *** claudiub has quit IRC | 10:22 | |
| *** claudiub has joined #openstack-release | 10:30 | |
| *** wolverineav has joined #openstack-release | 10:32 | |
| *** zhurong has quit IRC | 10:40 | |
| *** claudiub has quit IRC | 10:46 | |
| *** zhurong has joined #openstack-release | 10:52 | |
| *** alexchadin has joined #openstack-release | 11:13 | |
| *** thorst has joined #openstack-release | 11:13 | |
| *** yamamoto has quit IRC | 11:31 | |
| *** pbandark1 has joined #openstack-release | 11:43 | |
| *** thorst has quit IRC | 11:43 | |
| *** pbandark has quit IRC | 11:44 | |
| *** pbandark1 is now known as pbandark | 11:44 | |
| dhellmann | ttx: those patches are passing tests for some projects in CI, but if we land the patch then devs on those branches will have trouble locally | 11:58 |
| dhellmann | I'll reply on list | 11:58 |
| dhellmann | ttx, tonyb : I wonder if it would be better for us to set up a redirect on releases.o.o for a url like /constraints/$series and update that when the branch is created? | 12:01 |
| dhellmann | seems like it would be less work than landing all of these patches, too | 12:01 |
| dhellmann | although I suppose we'd have to have a patch to update the series value anyway | 12:01 |
| *** yamamoto has joined #openstack-release | 12:01 | |
| *** yamamoto has quit IRC | 12:04 | |
| *** udesale__ has quit IRC | 12:19 | |
| *** yamamoto has joined #openstack-release | 12:20 | |
| dims | ttx : dhellmann : o/ | 12:25 |
| dims | sorry late start today :) kids are going to day camp, had to get them out the door | 12:25 |
| *** yamamoto has quit IRC | 12:32 | |
| *** yamamoto has joined #openstack-release | 12:33 | |
| ttx | dhellmann: yeah, a bit tricky | 12:33 |
| *** yamamoto has quit IRC | 12:33 | |
| *** yamamoto has joined #openstack-release | 12:33 | |
| ttx | I guess we could abandon them and repost once the requirements branch is created | 12:34 |
| *** bobh has joined #openstack-release | 12:52 | |
| ttx | also on our radar: python-tricircleclient issue @ http://lists.openstack.org/pipermail/openstack-dev/2017-July/120320.html | 12:55 |
| dhellmann | ttx: I wonder how they ended up with that branch? | 12:56 |
| ttx | dhellmann: I think we branched from their latest version, as we should | 12:56 |
| ttx | It's from April because their last version was in April | 12:56 |
| *** bobh has quit IRC | 12:57 | |
| dhellmann | ah | 12:57 |
| ttx | still looking into it | 12:57 |
| dhellmann | oh, so that patch I did last week created a branch at a really old point | 12:57 |
| ttx | not really really old | 12:57 |
| ttx | he missed the deadline and was caught by it | 12:58 |
| dhellmann | we had a few people confused about the thursday deadline again | 12:59 |
| ttx | I'm fine fast-forwarding stable/pike to 0.1.2 | 12:59 |
| dhellmann | maybe we should move those to monday | 12:59 |
| dhellmann | yeah, recreating the branch seems like the right thing to do | 12:59 |
| ttx | given that it's unlikely to break anyone, and he posted it Saturday 4am | 12:59 |
| dhellmann | though if they have features it's 0.2.0 :-) | 12:59 |
| *** thorst has joined #openstack-release | 13:00 | |
| smcginnis | I actually like the Thursday deadline. Not sure if moving to Monday would be any better for those that don't follow the posted deadlines anyway. | 13:00 |
| dhellmann | yeah, python-tricircleclient doesn't appear in requirements.txt | 13:00 |
| *** amoralej is now known as amoralej|lunch | 13:00 | |
| *** zhurong has quit IRC | 13:00 | |
| ttx | I'll compose an answer | 13:00 |
| dhellmann | smcginnis : yeah, I suggested monday because it's at one end of the week, and people seem to think in terms of the work week | 13:01 |
| dhellmann | friday would mean we'd have things to do on the weekend to deal with anyone being late | 13:01 |
| smcginnis | True. I suppose it could be slightly better. | 13:01 |
| smcginnis | Definitely not Friday. ;) | 13:01 |
| dhellmann | monday also addresses the dateline tz issue | 13:01 |
| dhellmann | yeah, seems worth discussing | 13:01 |
| dhellmann | that has always tripped folks up, and as we've gone on we've done less hand-holding so it causes more trouble | 13:02 |
| dhellmann | I suppose we could have waited to branch until today | 13:02 |
| smcginnis | I actually didn't realize we were going to do the branching automatically. | 13:03 |
| smcginnis | I was going to request the Cinder related lib branches closer to RC to try to avoid backports if anything came up. | 13:03 |
| smcginnis | Which it unfortunately has. I'll be sending a ML post shortly for one for os-brick. | 13:04 |
| ttx | OK, answer posted | 13:04 |
| ttx | I suspect he won't be the only one with that "oops" | 13:05 |
| ttx | so documenting why we give Joe a free pass is good | 13:05 |
| ttx | fungi: could use your help in removing a branch | 13:05 |
| fungi | was that the tricircle one? catching up on scrollback now | 13:08 |
| fungi | still sort of offline and entertaining guests until tomorrow, but i do a pretty terrible job of not looking at the computer i guess | 13:10 |
| fungi | okay, so python-tricircleclient | 13:11 |
| ttx | fungi: yes, just remove the branch so we can recreate it at 0.2.0 | 13:11 |
| fungi | to confirm, delete the stable/pike branch from it, right? | 13:12 |
| ttx | yes | 13:12 |
| fungi | i've now removed the stable/pike branch (previously at 6bccd8fbd9afdf79f7bd0262da7709609a143d1b) from the openstack/python-tricircleclient repository | 13:13 |
| *** openstackgerrit has joined #openstack-release | 13:14 | |
| openstackgerrit | Thierry Carrez proposed openstack/releases master: Add python-tricircle 0.2.0 release https://review.openstack.org/488903 | 13:14 |
| ttx | pushing a new branch creation at 0.2.0, let's see if it passes tests ^ | 13:15 |
| fungi | worth noting, any clients who previously pulled in that branch may be unable to fast-forward it (i didn't check whether its top appeared in the history of master or had additional commits landed in it after branching) | 13:17 |
| fungi | s/top/tip/ | 13:17 |
| ttx | yep, but in this precise case the risk is limited | 13:17 |
| ttx | dims, dhellmann: please review my patchset over https://review.openstack.org/#/c/488903/ | 13:26 |
| dims | +2 ttx | 13:28 |
| smcginnis | ttx, dims: Looks good to me. Should I break in my new +W ability? :) | 13:31 |
| *** Adri2000 has quit IRC | 13:35 | |
| openstackgerrit | Merged openstack/releases master: Add python-tricircle 0.2.0 release https://review.openstack.org/488903 | 13:37 |
| *** amoralej|lunch is now known as amoralej | 13:39 | |
| ttx | ack all set thanks | 13:39 |
| ttx | dhellmann: you might want to abandon/regenerate your patches against python-tricircleclient | 13:40 |
| dims | smcginnis : w00t! | 13:41 |
| smcginnis | dims: :) | 13:41 |
| *** Adri2000 has joined #openstack-release | 13:44 | |
| *** gcb has joined #openstack-release | 13:46 | |
| *** bobh has joined #openstack-release | 13:47 | |
| *** electrofelix has joined #openstack-release | 13:49 | |
| dhellmann | ttx: it looks like they approved those other patches from the bot, so it should be ok to just let them approve the new ones | 13:49 |
| ttx | ok cool | 13:50 |
| *** electrofelix has quit IRC | 13:51 | |
| *** mriedem has joined #openstack-release | 13:58 | |
| *** alexchadin has quit IRC | 14:03 | |
| smcginnis | I will post these details the ML soon, but wondering if I could get everyone's take on this. | 14:03 |
| smcginnis | We have an issue in os-brick that causes a cross Cinder/Nova feature to fail. | 14:04 |
| smcginnis | It's limited impact otherwise, so I believe the risk is low getting an update out there during freeze. | 14:04 |
| smcginnis | There's that change and one other that I know Red Hat is actually already backported into their packages for Pike. | 14:05 |
| smcginnis | Other than the two, there is just a global requirements update and a logging change. | 14:05 |
| smcginnis | I'm wondering if I should backport these to stable/pike and ask that we consider one more release, or that we just redo stable/pike and do another release from master, then cut it again. | 14:06 |
| smcginnis | Any thoughts, concerns, criticisms, etc appreciated. | 14:06 |
| dhellmann | are the issues holding up the cinder/nova release? | 14:06 |
| smcginnis | dhellmann: Not necessarily "holding them up", but we would be shipping a broken feature otherwise. | 14:07 |
| dhellmann | so you could release the fix after the freeze is lifted? | 14:07 |
| dims | immediately after we ship... | 14:07 |
| smcginnis | dhellmann: That is the other option. There would probably just be a short window of brokenness then. | 14:07 |
| dhellmann | the risk of either option seems low | 14:07 |
| dhellmann | yeah | 14:07 |
| smcginnis | mriedem: Discussing the extend problem. ^^ | 14:07 |
| dims | +1 to "the risk of either option seems low" | 14:08 |
| ttx | since os-brick is more common cinder/nova code than a general-purpose library, I think it makes sense to cut some slack, especially early post-FF, and consider it like a FFE | 14:09 |
| smcginnis | OK, I'll send a ML post with the details. | 14:09 |
| smcginnis | Does it make sense to backport? Or redo the branch? | 14:09 |
| ttx | I'd say backport | 14:10 |
| smcginnis | Got it, I'll get those through and send everything out. | 14:10 |
| dhellmann | oh, yeah, we definitely don't want to redo the branch | 14:10 |
| dhellmann | the question is whether to release from the branch now or later | 14:10 |
| ttx | redo the branch is the worst option, just happens to sometimes be teh only one | 14:10 |
| dhellmann | we only did that for tricircle because we force-created the branch for them | 14:11 |
| dhellmann | and the starting point was from april | 14:11 |
| smcginnis | Yeah... I agree. | 14:11 |
| fungi | and get the constraints list updated | 14:14 |
| fungi | requirements repo hasn't branched yet, right? | 14:14 |
| dhellmann | fungi : right, I think tonyb's email said soon but not yet | 14:15 |
| fungi | result would be testing master of projects against a point release of os-brick from a stable branch, but that's probably fine? | 14:15 |
| smcginnis | I suppose so. It just pulls the package from pypi, right? So it shouldn't really matter where it came from. | 14:16 |
| fungi | rigt | 14:17 |
| fungi | right | 14:17 |
| dhellmann | fungi : oh, the constraints update step in the release process might fail, or just skip. I'll have to keep an eye out (I don't remember what that does). So, yeah, we'd have to update the master constraint list. | 14:18 |
| fungi | dhellmann: as far as updating the docs jobs to no longer run when new releases are tagged, did projects stop including version numbers in their docs? i believe the reason it was done before was because otherwise a project which got tagged and then had no new patches for a while wouldn't have a "corresponding" document for the latest release | 14:18 |
| dhellmann | fungi : we're having a discussion of this in #openstack-docs right now | 14:18 |
| fungi | okay, heading there | 14:18 |
| smcginnis | mriedem: Are you OK landing the Nova side extend stuff if we hold until after lib freeze to do a fix release of os-brick? | 14:19 |
| smcginnis | mriedem: And by "after lib freeze" I mean immediately after the freeze is lifted. | 14:19 |
| *** electrofelix has joined #openstack-release | 14:19 | |
| mriedem | dhellmann: dims: smcginnis: one issue with waiting is releasing a fix in os-brick in stable and bumping minimum required os-brick to include the fix, otherwise we just assume people are going to pick up upper-constraints on stable? | 14:20 |
| mriedem | smcginnis: what is the nova side? | 14:20 |
| dhellmann | mriedem : yes, true, there would be some lag | 14:20 |
| smcginnis | mriedem: Maybe I missed it, but I thought you still had one patch in flight. | 14:20 |
| smcginnis | Maybe I'm wrong? | 14:21 |
| mriedem | no, there was only the os-brick bug fix | 14:21 |
| mriedem | exposed via my devstack/tempest patches for testing the feature | 14:21 |
| smcginnis | Ah, OK. | 14:21 |
| smcginnis | mriedem: So everything is landed, we would just be shipping a broken feature until we are able to update the lib and constraint. | 14:21 |
| mriedem | and no g-r bump? | 14:23 |
| smcginnis | mriedem: Err, yeah. We would have to do that too. | 14:24 |
| mriedem | ok, we don't really do minimum g-r bumps on stale | 14:24 |
| mriedem | *stable | 14:24 |
| mriedem | so if we're going to do that, we need to do it before releasing pike | 14:24 |
| mriedem | since it's a bug fix release i don't see a problem with that | 14:24 |
| smcginnis | OK, I'll get everything prep'd and let folks decided. | 14:25 |
| mriedem | aye aye | 14:26 |
| *** coolsvap has quit IRC | 14:31 | |
| dims | mriedem : was dhellmann said, both options are low risk | 14:31 |
| mriedem | ok then i'd vote for releasing now and bumping g-r | 14:31 |
| *** openstackgerrit has quit IRC | 14:33 | |
| dims | mriedem : sounds good to me | 14:33 |
| smcginnis | http://lists.openstack.org/pipermail/openstack-dev/2017-July/120358.html | 14:38 |
| *** yamamoto has quit IRC | 14:45 | |
| *** hongbin has joined #openstack-release | 14:52 | |
| *** pbandark has quit IRC | 14:53 | |
| *** pbandark has joined #openstack-release | 14:56 | |
| *** yamahata has quit IRC | 14:58 | |
| *** yamahata has joined #openstack-release | 14:59 | |
| *** pcaruana has quit IRC | 15:04 | |
| *** yamamoto has joined #openstack-release | 15:16 | |
| *** yamamoto has quit IRC | 15:21 | |
| *** gcb has quit IRC | 15:23 | |
| *** armax has joined #openstack-release | 15:29 | |
| *** raissa has left #openstack-release | 15:30 | |
| *** yamamoto has joined #openstack-release | 15:48 | |
| *** yamamoto has quit IRC | 15:58 | |
| *** openstackgerrit has joined #openstack-release | 16:03 | |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: update the release process steps related to documentation https://review.openstack.org/489265 | 16:03 |
| *** armax has quit IRC | 16:03 | |
| *** rajathagasthya has joined #openstack-release | 16:04 | |
| openstackgerrit | Thierry Carrez proposed openstack/releases master: Proposed release schedule for Queens https://review.openstack.org/489266 | 16:08 |
| ttx | Yes, it's that time of the year ^ | 16:08 |
| *** slashme has quit IRC | 16:10 | |
| *** rajathag_ has joined #openstack-release | 16:18 | |
| *** rajathagasthya has quit IRC | 16:21 | |
| dhellmann | ttx: do we know yet when the ptg will be at the start of rocky? | 16:26 |
| ttx | Not yet. Several dates/locations still floating | 16:28 |
| ttx | Let's say wit hthe current options, that would place PTG at R+0 or R+2 | 16:28 |
| ttx | so into known territory | 16:29 |
| clarkb | hello release team. I'd like to talk about upgrading gerrit to 2.13 in tomorrow's infra meeting at 1900UTC. If not too much trouble would be good to have the release team's input on schedulign that as well | 16:30 |
| clarkb | basically we've sorted out technical details now its just a matter of picking a day and doing it so your input will be valuable | 16:30 |
| *** bobh has quit IRC | 16:35 | |
| *** efried_zzz is now known as efried | 16:44 | |
| *** armax has joined #openstack-release | 16:56 | |
| dhellmann | clarkb: I added it to my calendar | 17:14 |
| *** ricolin has quit IRC | 17:15 | |
| dtroyer | Release team: can I get a 'feature/osc4' feature branch creation into your queue for python-openstackclient and osc-lib? | 17:21 |
| dhellmann | dtroyer : sure! file the patch to create the branches and I'll take a look at it | 17:22 |
| smcginnis | dhellmann: I haven't done feature branches yet. Is that still a matter of submitting a releases patch with the branch info in the project yaml file? | 17:23 |
| dtroyer | hmmm… what I was reading last week said to just ask you guys for the actual creation…did I miss something? | 17:23 |
| *** yamahata has quit IRC | 17:23 | |
| * dtroyer going to re-find that doc | 17:23 | |
| dhellmann | dtroyer : oh, maybe the docs are out of date? what were you looking at? | 17:23 |
| dhellmann | smcginnis : yes, that's right | 17:23 |
| * dhellmann goes to look for the right docs | 17:23 | |
| smcginnis | Probably some old docs out there yet somewhere. | 17:24 |
| dhellmann | dtroyer , smcginnis : the README in the releases repo has accurate info, including an example of a deliverable file with a feature branch | 17:24 |
| dtroyer | ok, will go there | 17:24 |
| dtroyer | https://docs.openstack.org/infra/manual/drivers.html#feature-branches was one | 17:25 |
| dhellmann | although it's somewhat less detailed than you might want for a tutorial | 17:25 |
| dtroyer | https://docs.openstack.org/project-team-guide/other-branches.html#creating-the-branch was the other | 17:25 |
| *** pbandark has quit IRC | 17:25 | |
| smcginnis | I can submit a patch to update those. | 17:25 |
| dhellmann | smcginnis : thanks | 17:25 |
| smcginnis | dhellmann: Would it be better to have those just point to the README? | 17:25 |
| dhellmann | smcginnis : probably, although we may want to give further thought to putting more directions in a published doc somewhere | 17:26 |
| dhellmann | we do have some reference material on releases.o.o, but mostly for interpreting the output not for how to use the repo | 17:27 |
| smcginnis | Ack, I'll come up with something and see what folks think. | 17:27 |
| *** electrofelix has quit IRC | 17:30 | |
| *** tosky has quit IRC | 17:32 | |
| openstackgerrit | Dean Troyer proposed openstack/releases master: Create feature/osc4 for python-openstackclient and osc-lib https://review.openstack.org/489285 | 17:39 |
| dtroyer | dhellmann: I think I sorted it out :) ^^^ | 17:39 |
| dhellmann | dtroyer : lgtm, I'll wait for the jobs to finish and give smcginnis a chance to look at it | 17:40 |
| dtroyer | cool, thanks | 17:42 |
| smcginnis | dhellmann: Done - looks good to me. | 17:42 |
| *** amoralej is now known as amoralej|off | 17:44 | |
| EmilienM | smcginnis: w00t - happy to know you're candidate :-) | 17:44 |
| smcginnis | EmilienM: Thanks! :) | 17:44 |
| * dhellmann has to step out to run an errand | 17:46 | |
| dhellmann | dtroyer, smcginnis : it looks like CI didn't like that patch for some reason | 17:47 |
| dhellmann | smcginnis : when the jobs are happy, it's safe to approve that with 1 reviewer | 17:47 |
| smcginnis | dtroyer: Ah, missed that. Wrong indentation on that. | 17:48 |
| smcginnis | dhellmann: OK, I'll push that through once it's cleaned up. | 17:48 |
| smcginnis | Hmm, odd that it's complaining about four spaces instead of two. Looks correct me actually. | 17:49 |
| dtroyer | that particular chunk doesn't match the examples or other branches: sections I saw…I maintained the no indentation before '-name' where there usually were 2 spaces | 17:50 |
| dtroyer | checking locally again | 17:50 |
| smcginnis | dtroyer: I honestly don't know if there is a reason, but some indent and some don't. | 17:50 |
| smcginnis | Guess this might be a reason. | 17:50 |
| dtroyer | I think so, it's the argument to location: being another map that is different from the stable branch location: value | 17:51 |
| *** yamahata has joined #openstack-release | 17:59 | |
| openstackgerrit | Dean Troyer proposed openstack/releases master: Create feature/osc4 for python-openstackclient and osc-lib https://review.openstack.org/489285 | 17:59 |
| *** dtantsur is now known as dtantsur|afk | 18:05 | |
| *** harlowja has joined #openstack-release | 18:11 | |
| * dims peeks | 18:22 | |
| dims | clarkb : thanks for the heads up on the upgrade | 18:23 |
| smcginnis | dims: Do you understand the format rules on the branch creation requests? | 18:24 |
| smcginnis | dims: dtroyer's first patch looked fine to me, but it doesn't like the indentation of the feature branch location. | 18:24 |
| smcginnis | And what's worse, the first format actually matches what we show in our examples. | 18:25 |
| dtroyer | something is odd here, I don't know all of the yaml rules, but I think I found one that passes the validate test, even though it looks to be wrong sematically | 18:25 |
| smcginnis | dtroyer: Unindent the repo:hash line? | 18:25 |
| dtroyer | yes, but that makes that not a map under location: | 18:25 |
| dtroyer | that's what I'm pushing up next, I can only rul a few of the tests locally | 18:26 |
| dims | smcginnis looking | 18:26 |
| smcginnis | dims: Thanks | 18:26 |
| smcginnis | I'm actually wondering if we have a problem in our yaml rules. | 18:26 |
| dims | dtroyer : smcginnis : compare with say http://git.openstack.org/cgit/openstack/releases/tree/deliverables/ocata/tacker.yaml ? | 18:28 |
| dtroyer | it may be a problem in validate, I have to run out for a bit, will try a couple of things when I get back | 18:28 |
| openstackgerrit | Dean Troyer proposed openstack/releases master: Create feature/osc4 for python-openstackclient and osc-lib https://review.openstack.org/489285 | 18:31 |
| *** bobh has joined #openstack-release | 18:35 | |
| dhellmann | smcginnis , dtroyer : the linter looks at other parts of the file and requires that you indent consistently | 18:37 |
| dhellmann | I have a patch up to fix that and force 2 spaces for lists everywhere | 18:37 |
| dhellmann | landing it will require touching all of the files in the "current" series, so I'm waiting until we set up the queens series to do it | 18:37 |
| smcginnis | dhellmann: I thought v1 of that patch was consistent. | 18:38 |
| smcginnis | dhellmann: Do you know how this should be reformatted correctly? https://review.openstack.org/#/c/489285/1/deliverables/pike/osc-lib.yaml | 18:38 |
| *** bobh has quit IRC | 18:39 | |
| *** bobh has joined #openstack-release | 18:39 | |
| dhellmann | hmm, no, that looks right to me | 18:39 |
| dhellmann | is that what failed? | 18:39 |
| dhellmann | let me see what I can do with it locally | 18:40 |
| dhellmann | I hate that linter | 18:40 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: Create feature/osc4 for python-openstackclient and osc-lib https://review.openstack.org/489285 | 18:46 |
| dhellmann | smcginnis, dtroyer : ^^ | 18:46 |
| smcginnis | dhellmann: Going with the full nuclear option I see. :) | 18:46 |
| dhellmann | you gotta do what you gotta do | 18:47 |
| smcginnis | I was wondering if it had something to do with it being the last line. I notice you moved name: after the location. | 18:47 |
| dhellmann | smcginnis : https://review.openstack.org/#/c/488607/ updates the linter to require 2 spaces everywhere | 18:48 |
| dhellmann | oh, yeah, switching the order of the lines didn't help | 18:49 |
| smcginnis | dhellmann: Yikes. Yeah, definitely some normalizing needed there first from the failed test output. | 18:49 |
| dhellmann | yeah | 18:50 |
| dhellmann | I was putting off doing the normalizing, but maybe it makes sense to do it before people start running into this issue creating branches | 18:51 |
| smcginnis | dhellmann: I think we could probably hold off a little while, but not sure when a really good time would be. | 19:00 |
| dhellmann | probably before we start doing lots of queens releases | 19:01 |
| smcginnis | Is that normalization scripted? | 19:02 |
| dhellmann | yeah, there's a command to read the yaml file and rewrite it. that patch includes a change to cause the indentation to be corrected during the rewriting | 19:04 |
| dhellmann | we have to batch the changes, because otherwise the validation job times out | 19:05 |
| openstackgerrit | Merged openstack/releases master: Create feature/osc4 for python-openstackclient and osc-lib https://review.openstack.org/489285 | 19:08 |
| *** ekcs has joined #openstack-release | 19:15 | |
| *** wolverineav has quit IRC | 19:18 | |
| smcginnis | dhellmann: When you have time - what is the feature branch creation process for projects not using the releases repo? They have ACLs to allow pushing branches directly? | 19:25 |
| dhellmann | smcginnis : they don't always have permission themselves. When they do, I usually point out the gerrit page for creating branches. When they don't, I either help them or direct them to the infra team for help | 19:26 |
| dhellmann | we should probably ensure they have permission to avoid overburdening either team | 19:26 |
| smcginnis | ++ | 19:27 |
| smcginnis | dhellmann: So this page is probably OK to just have the releases method since it is for governed projects: https://docs.openstack.org/project-team-guide/other-branches.html#creating-the-branch | 19:28 |
| smcginnis | dhellmann: But this one should have info for both: https://docs.openstack.org/infra/manual/drivers.html#feature-branches | 19:28 |
| smcginnis | dhellmann: Or do you think both should have all of it? | 19:28 |
| dhellmann | having different info on those pages makes sense | 19:28 |
| smcginnis | dhellmann: Great, I will update my patch then. Thank you sir. | 19:29 |
| smcginnis | dhellmann: Sorry, one more quick one. That gerrit page for creating branches is under Projects > Branches? | 19:32 |
| dhellmann | yeah, for example https://review.openstack.org/#/admin/projects/openstack/nova,branches | 19:33 |
| dhellmann | they can also use that page to figure out if they have permission to create the branch | 19:33 |
| smcginnis | dhellmann: Got it. OK, I'll point them to that, and note that they may need to go to infra if they do not have permissions. So at least they will hopefully try themselves first. | 19:34 |
| dhellmann | ++ | 19:35 |
| dhellmann | we could probably explain how to set the permissions so they could land the patch to give themselves permission | 19:35 |
| dhellmann | I don't know how far into that we want to go | 19:35 |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Release os-brick 1.15.2 https://review.openstack.org/489370 | 19:51 |
| dims | dhellmann : i have +2ed it ^^ | 20:03 |
| dhellmann | dims : ack, +2a | 20:04 |
| openstackgerrit | Merged openstack/releases master: Release os-brick 1.15.2 https://review.openstack.org/489370 | 20:08 |
| tonyb | dhellmann, ttx, dims: I'll read the thread. I'm not certain what that'd fix but that's probably lack of context | 20:21 |
| dhellmann | tonyb : instead of landing 1 patch per project, we just land 1 | 20:21 |
| dhellmann | that's assuming we could figure out the right series name in a given branch, of course | 20:22 |
| dhellmann | which we could if we had git around, but couldn't if we don't | 20:22 |
| tonyb | dhellmann: okay I see. I have no objection to that in theory as long as it's a) easy to do and b) easy to consume for other tools (like scripts/tox-insall in various repos) | 20:24 |
| tonyb | dhellmann: can we rely on / parse .gitreview? | 20:24 |
| dhellmann | yeah, the hard part is figuring out what branch you're on | 20:24 |
| dhellmann | we can, if that file is present | 20:24 |
| dhellmann | I don't know if it is present if you're building from an sdist | 20:25 |
| *** thorst is now known as thorst_afk | 20:25 | |
| dhellmann | something to play with | 20:25 |
| * tonyb checks nova | 20:25 | |
| tonyb | :( | 20:26 |
| dave-mcc_ | we found a bug in python-barbicanclient after we pushed the pike release 4.5.0, so we to release 4.5.1. is it as simple as adding the release number and hash to the releases repo? | 20:28 |
| dims | dave-mcc_ : i was just typing a message for you :) | 20:28 |
| dhellmann | dave-mcc_ : yes, modify deliverables/pike/python-barbicanclient.yaml | 20:28 |
| dims | yes | 20:29 |
| dave-mcc_ | dims dhellmann thanks | 20:29 |
| dtroyer | dhellmann, smcginnis: thanks for sorting that yaml validate stuff out | 20:29 |
| dhellmann | dtroyer : np | 20:30 |
| smcginnis | All thanks go to dhellmann. I was lost. :) | 20:30 |
| dhellmann | dave-mcc_ : any time | 20:30 |
| openstackgerrit | Dave McCowan proposed openstack/releases master: Release python-barbicanclient 4.5.1 https://review.openstack.org/489379 | 20:31 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: add linter rules for vertical whitespace https://review.openstack.org/488608 | 20:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: use yamlutils.dumps() in init-series https://review.openstack.org/488846 | 20:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: use yamlutils.dumps() in new-release command https://review.openstack.org/488845 | 20:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: fix format-yaml to work with python 3 https://review.openstack.org/488606 | 20:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: standardize indentation at 2 spaces https://review.openstack.org/488607 | 20:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: add wrapper for yamllint https://review.openstack.org/489380 | 20:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: ensure version numbers always have quotes https://review.openstack.org/489381 | 20:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: use yes/no for boolean values in reformatter https://review.openstack.org/489382 | 20:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: do not add line wraps to text when reformatting https://review.openstack.org/489383 | 20:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize independent deliverable files https://review.openstack.org/489384 | 20:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize oslo deliverable files https://review.openstack.org/489385 | 20:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize client deliverable files https://review.openstack.org/489386 | 20:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize tripleo deliverable files https://review.openstack.org/489387 | 20:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize puppet deliverable files https://review.openstack.org/489388 | 20:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize misc deliverable files https://review.openstack.org/489389 | 20:35 |
| dhellmann | smcginnis : ^^ | 20:35 |
| smcginnis | dhellmann: Nice, filled my irssi screen. :) | 20:37 |
| dhellmann | I managed to make it more code changes than data file changes | 20:37 |
| dhellmann | let's see if those time out though :-) | 20:37 |
| dims | shipping barbicanclient | 20:49 |
| dims | dave-mcc_ : thanks! | 20:49 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: ensure version numbers always have quotes https://review.openstack.org/489381 | 20:51 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: add wrapper for yamllint https://review.openstack.org/489380 | 20:51 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: do not add line wraps to text when reformatting https://review.openstack.org/489383 | 20:51 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: add linter rules for vertical whitespace https://review.openstack.org/488608 | 20:51 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: use yes/no for boolean values in reformatter https://review.openstack.org/489382 | 20:51 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize misc deliverable files https://review.openstack.org/489389 | 20:51 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize puppet deliverable files https://review.openstack.org/489388 | 20:51 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize oslo deliverable files https://review.openstack.org/489385 | 20:51 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize independent deliverable files https://review.openstack.org/489384 | 20:51 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: use yamlutils.dumps() in init-series https://review.openstack.org/488846 | 20:51 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize tripleo deliverable files https://review.openstack.org/489387 | 20:51 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize client deliverable files https://review.openstack.org/489386 | 20:51 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: standardize indentation at 2 spaces https://review.openstack.org/488607 | 20:52 |
| openstackgerrit | Merged openstack/releases master: Release python-barbicanclient 4.5.1 https://review.openstack.org/489379 | 20:54 |
| *** wolverineav has joined #openstack-release | 21:00 | |
| *** rajathag_ is now known as rajathagasthya | 21:00 | |
| *** jtomasek has quit IRC | 21:00 | |
| *** yamamoto_ has joined #openstack-release | 21:06 | |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: ensure version numbers always have quotes https://review.openstack.org/489381 | 21:13 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: add wrapper for yamllint https://review.openstack.org/489380 | 21:13 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: do not add line wraps to text when reformatting https://review.openstack.org/489383 | 21:13 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: use yes/no for boolean values in reformatter https://review.openstack.org/489382 | 21:13 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize misc deliverable files https://review.openstack.org/489389 | 21:13 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize puppet deliverable files https://review.openstack.org/489388 | 21:13 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize oslo deliverable files https://review.openstack.org/489385 | 21:13 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: use yamlutils.dumps() in init-series https://review.openstack.org/488846 | 21:13 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize independent deliverable files https://review.openstack.org/489384 | 21:13 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize tripleo deliverable files https://review.openstack.org/489387 | 21:13 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: fix format-yaml to work with python 3 https://review.openstack.org/488606 | 21:13 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: use yamlutils.dumps() in new-release command https://review.openstack.org/488845 | 21:13 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: standardize indentation at 2 spaces https://review.openstack.org/488607 | 21:13 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize client deliverable files https://review.openstack.org/489386 | 21:13 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: add linter rules for vertical whitespace https://review.openstack.org/488608 | 21:13 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: remove obsolete tool script for adding team names https://review.openstack.org/489400 | 21:13 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: add edit-deliverable command https://review.openstack.org/489401 | 21:13 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: use edit-deliverable in script to set the release notes URLs https://review.openstack.org/489402 | 21:13 |
| dhellmann | rebase hell :-( | 21:13 |
| tonyb | dhellmann: do we just fast merge them once they pass the gate? | 21:13 |
| dhellmann | tonyb : if we decide this is a good idea to do, yeah | 21:13 |
| dhellmann | we should probably have that conversation, though, and give ttx a chance to look | 21:14 |
| dhellmann | there's no *real* rush, and we shouldn't be having lots of updates this week | 21:14 |
| dhellmann | it's just that every update will cause at least one rebase | 21:14 |
| *** yamamoto_ has quit IRC | 21:15 | |
| tonyb | dhellmann: okay. FTR I'm happy to standardize them if we start to strict enforce them after that so we're not in the same state in ~12months | 21:16 |
| tonyb | dhellmann: but as you say ttx need to think about it | 21:16 |
| dhellmann | tonyb : yeah, one of those patches does exactly that by setting the linter to require 2 spaces for indentation | 21:17 |
| smcginnis | Should we wait until tomorrow morning US to give Thierry a chance to look, then push them all through? | 21:17 |
| dhellmann | a bunch of the others are updates to the tools to ensure they use the same rules when writing out edits to the files | 21:17 |
| tonyb | dhellmann: Cool. | 21:17 |
| dhellmann | smcginnis : yeah, definitely wait over night | 21:17 |
| dhellmann | I mean, go ahead with reviews in the mean time, but let's not land them yet | 21:18 |
| smcginnis | Sounds like a plan. I'll make a note to take a look tomorrow if someone else doesn't beat me to it. | 21:18 |
| tonyb | I can do it during my day which is kinda between US and EU | 21:18 |
| smcginnis | tonyb: Speaking of which, isn't it ridiculously early there right now? | 21:18 |
| tonyb | Nah ~7am | 21:18 |
| tonyb | On calls for work | 21:19 |
| dims | ++ to "don't land them yet" | 21:19 |
| smcginnis | Ah, that's not so bad then. | 21:19 |
| dims | good morning tonyb | 21:19 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: add new-release and edit-deliverable to helpers list in readme https://review.openstack.org/489405 | 21:20 |
| tonyb | dims: afternoon/evening :) | 21:20 |
| dhellmann | bah, one more time to get the ordering right | 21:27 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize misc deliverable files https://review.openstack.org/489389 | 21:27 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize puppet deliverable files https://review.openstack.org/489388 | 21:27 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize oslo deliverable files https://review.openstack.org/489385 | 21:27 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize independent deliverable files https://review.openstack.org/489384 | 21:27 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize tripleo deliverable files https://review.openstack.org/489387 | 21:27 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: normalize client deliverable files https://review.openstack.org/489386 | 21:27 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: standardize indentation at 2 spaces https://review.openstack.org/488607 | 21:27 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: add linter rules for vertical whitespace https://review.openstack.org/488608 | 21:27 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: add new-release and edit-deliverable to helpers list in readme https://review.openstack.org/489405 | 21:27 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: remove obsolete tool script for adding team names https://review.openstack.org/489400 | 21:27 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: add edit-deliverable command https://review.openstack.org/489401 | 21:27 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: use edit-deliverable in script to set the release notes URLs https://review.openstack.org/489402 | 21:27 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: add release-notes URLs for some pike deliverables https://review.openstack.org/489403 | 21:27 |
| dhellmann | I have to fix the files before I can turn the rule on. duh. | 21:27 |
| smcginnis | That might help. :) | 21:28 |
| dhellmann | and pep8 | 21:35 |
| dhellmann | gets me every time | 21:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: add new-release and edit-deliverable to helpers list in readme https://review.openstack.org/489405 | 21:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: add edit-deliverable command https://review.openstack.org/489401 | 21:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: use edit-deliverable in script to set the release notes URLs https://review.openstack.org/489402 | 21:35 |
| openstackgerrit | Doug Hellmann proposed openstack/releases master: add release-notes URLs for some pike deliverables https://review.openstack.org/489403 | 21:35 |
| *** wolverineav has quit IRC | 21:58 | |
| *** wolverineav has joined #openstack-release | 21:58 | |
| *** wolverineav has quit IRC | 22:02 | |
| *** bobh has quit IRC | 22:03 | |
| *** yamamoto has joined #openstack-release | 22:16 | |
| *** yamamoto has quit IRC | 22:23 | |
| *** yamamoto has joined #openstack-release | 22:28 | |
| *** thorst_afk has quit IRC | 22:38 | |
| *** bauzas has quit IRC | 22:52 | |
| *** hongbin has quit IRC | 23:11 | |
| *** bauzas has joined #openstack-release | 23:11 | |
| *** https_GK1wmSU has joined #openstack-release | 23:24 | |
| *** https_GK1wmSU has left #openstack-release | 23:25 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!