Tuesday, 2017-10-10

*** edmondsw has quit IRC00:04
*** mriedem1 is now known as mriedem00:04
*** yamahata has quit IRC00:07
*** ianychoi has joined #openstack-release00:14
*** cody-somerville has quit IRC00:19
*** cody-somerville has joined #openstack-release00:20
*** cody-somerville has quit IRC00:20
*** cody-somerville has joined #openstack-release00:20
*** mriedem has quit IRC00:40
*** sree has joined #openstack-release00:41
*** sree has quit IRC00:45
*** cody-somerville has quit IRC01:04
*** ekcs has quit IRC01:05
*** edmondsw has joined #openstack-release01:28
*** kumarmn has joined #openstack-release01:32
*** kumarmn has quit IRC01:43
*** cody-somerville has joined #openstack-release01:43
*** cody-somerville has quit IRC01:43
*** cody-somerville has joined #openstack-release01:43
*** kumarmn has joined #openstack-release01:43
*** cody-somerville has quit IRC01:46
*** kumarmn has quit IRC01:46
*** kumarmn has joined #openstack-release01:47
*** rosmaita has quit IRC01:55
openstackgerritMerged openstack/releases master: Final newton release of Octavia and neutron-lbaas  https://review.openstack.org/51062102:01
*** hongbin has quit IRC02:11
*** kumarmn has quit IRC02:19
*** thorst has quit IRC02:23
*** thorst has joined #openstack-release02:24
*** thorst has quit IRC02:28
*** dave-mccowan has quit IRC02:31
*** thorst has joined #openstack-release02:37
*** pkovar has quit IRC02:50
*** cody-somerville has joined #openstack-release02:58
*** csomerville has joined #openstack-release02:59
*** cody-somerville has quit IRC02:59
*** bobh has joined #openstack-release03:10
*** kumarmn has joined #openstack-release03:20
*** bobh has quit IRC03:20
*** ricolin has joined #openstack-release03:21
*** lukebrowning_ has joined #openstack-release03:23
*** edmondsw has quit IRC03:23
*** kumarmn has quit IRC03:24
*** lukebrowning has quit IRC03:26
*** hongbin has joined #openstack-release03:32
*** lukebrowning_ has quit IRC03:47
*** lukebrowning has joined #openstack-release03:48
*** cody-somerville has joined #openstack-release03:50
*** csomerville has quit IRC03:52
*** claudiub has joined #openstack-release04:07
*** coolsvap has joined #openstack-release04:08
*** kumarmn has joined #openstack-release04:20
*** edmondsw has joined #openstack-release04:21
*** kumarmn has quit IRC04:25
*** edmondsw has quit IRC04:26
*** lukebrowning_ has joined #openstack-release04:27
*** lukebrowning has quit IRC04:29
*** pcaruana has joined #openstack-release04:32
*** hongbin has quit IRC04:40
*** lukebrowning_ has quit IRC04:41
*** csomerville has joined #openstack-release04:42
*** lukebrowning has joined #openstack-release04:42
*** lukebrowning_ has joined #openstack-release04:45
*** cody-somerville has quit IRC04:45
*** lukebrowning has quit IRC04:47
*** udesale has joined #openstack-release04:57
*** pcaruana has quit IRC04:58
*** armax has quit IRC04:59
*** armax has joined #openstack-release05:00
*** armax has quit IRC05:04
*** jtomasek has joined #openstack-release05:04
*** csomerville has quit IRC05:07
*** yamahata has joined #openstack-release05:19
*** kumarmn has joined #openstack-release05:21
*** csomerville has joined #openstack-release05:25
*** kumarmn has quit IRC05:25
*** csomerville has quit IRC05:42
*** sree has joined #openstack-release05:54
*** udesale__ has joined #openstack-release05:55
*** udesale__ has quit IRC05:57
*** udesale__ has joined #openstack-release05:57
*** udesale has quit IRC05:57
*** jrist has quit IRC06:03
*** sree has quit IRC06:07
*** edmondsw has joined #openstack-release06:10
*** sree_ has joined #openstack-release06:11
*** sree_ is now known as Guest6217206:11
*** yamamoto has quit IRC06:11
*** edmondsw has quit IRC06:14
*** jrist has joined #openstack-release06:16
*** Guest62172 has quit IRC06:20
openstackgerritThomas Bechtold proposed openstack/releases master: Release renderspec 1.9.1 bugfix release  https://review.openstack.org/51076406:37
*** pcaruana has joined #openstack-release07:04
openstackgerritDeepthi V V proposed openstack/releases master: release neutron-lib 1.10.1  https://review.openstack.org/51077407:06
*** claudiub|2 has joined #openstack-release07:15
*** claudiub has quit IRC07:18
*** yamahata has quit IRC07:18
*** zen369 has joined #openstack-release07:20
*** kumarmn has joined #openstack-release07:23
*** kumarmn has quit IRC07:27
*** jpich has joined #openstack-release07:35
*** shardy has joined #openstack-release07:35
*** electrofelix has joined #openstack-release07:39
*** amoralej|off is now known as amoralej07:49
*** askb has quit IRC07:49
ttxThe release-post jobs for https://review.openstack.org/510621 failed. tonyb got them reenqueued but they failed with a different error. Should we revert the change or get them retriggered ?07:56
*** edmondsw has joined #openstack-release07:58
*** pbandark has joined #openstack-release08:00
*** edmondsw has quit IRC08:02
*** sree has joined #openstack-release08:15
*** sree has quit IRC08:20
*** kumarmn has joined #openstack-release08:23
*** lucas-afk is now known as lucasagomes08:25
tonybttx: Oh phooey I didn't notice they faileda second time.08:29
*** kumarmn has quit IRC08:29
ttxI'll check with fungi if we should reenqueue them from infra side or through revert/resubmit08:31
*** inc0 has quit IRC08:32
*** sree has joined #openstack-release08:34
*** askb has joined #openstack-release08:37
*** inc0 has joined #openstack-release08:39
tonybttx: Thanks.08:43
smcginnisWe had some out of space issue yesterday. If it's that again, we'll need to wait for his help.08:43
tonybttx: Looking at the error and considering the conversation I had with fungi I think revert/reapply shoudl work08:45
tonyband be safe08:46
smcginnistonyb: Failure on git fetch on that last one. Yeah, looks like it should be safe to revert/reapply.08:51
tonybsmcginnis: Yeah.08:51
*** witek has quit IRC09:28
*** sree has quit IRC09:29
*** thorst has joined #openstack-release09:41
*** edmondsw has joined #openstack-release09:46
*** thorst has quit IRC09:47
*** edmondsw has quit IRC09:51
*** dtantsur|afk is now known as dtantsur09:53
*** witek has joined #openstack-release09:53
*** alexchadin has joined #openstack-release09:54
*** ricolin has quit IRC09:54
*** wolverineav has joined #openstack-release09:55
*** tbarron|PTO is now known as tbarron10:04
*** wolverineav has quit IRC10:07
*** lukebrowning_ has quit IRC10:11
*** sdague has joined #openstack-release10:12
*** lukebrowning has joined #openstack-release10:22
*** kumarmn has joined #openstack-release10:26
*** lukebrowning has quit IRC10:27
*** wolverineav has joined #openstack-release10:30
*** kumarmn has quit IRC10:30
*** alexchadin has quit IRC10:46
*** alexchadin has joined #openstack-release10:47
*** dtantsur has quit IRC11:04
*** alexchadin has quit IRC11:07
*** dtantsur has joined #openstack-release11:08
*** dtantsur has quit IRC11:08
*** dtantsur has joined #openstack-release11:09
*** dtantsur has quit IRC11:09
*** dtantsur has joined #openstack-release11:13
*** lucasagomes is now known as lucas-hungry11:15
*** alexchadin has joined #openstack-release11:16
*** lukebrowning has joined #openstack-release11:23
*** rosmaita has joined #openstack-release11:24
*** kumarmn has joined #openstack-release11:27
*** sree has joined #openstack-release11:30
*** kumarmn has quit IRC11:31
*** sree has quit IRC11:34
*** ricolin has joined #openstack-release11:36
*** yamamoto has joined #openstack-release11:38
*** pkovar has joined #openstack-release11:41
*** yamamoto has quit IRC11:44
*** yamamoto has joined #openstack-release11:44
*** yamamoto has quit IRC11:47
*** yamamoto has joined #openstack-release11:48
*** yamamoto has quit IRC11:49
*** yamamoto has joined #openstack-release11:55
*** ricolin has quit IRC12:00
*** edmondsw has joined #openstack-release12:03
*** edmondsw has quit IRC12:04
*** edmondsw_ has joined #openstack-release12:05
*** pkovar has quit IRC12:06
*** sree has joined #openstack-release12:07
*** thorst has joined #openstack-release12:16
*** alexchadin has quit IRC12:17
ttxsmcginnis: ok let me propose that12:19
dhellmanno/12:20
openstackgerritThierry Carrez proposed openstack/releases master: Revert "Final newton release of Octavia and neutron-lbaas"  https://review.openstack.org/51086012:22
*** pkovar has joined #openstack-release12:23
openstackgerritThierry Carrez proposed openstack/releases master: Revert "Revert "Final newton release of Octavia and neutron-lbaas""  https://review.openstack.org/51086112:25
ttxsmcginnis: here you go ^12:25
*** lucas-hungry is now known as lucasagomes12:27
*** yamamoto has quit IRC12:27
*** kumarmn has joined #openstack-release12:27
*** yamamoto has joined #openstack-release12:29
*** kumarmn has quit IRC12:32
*** ricolin has joined #openstack-release12:32
*** yamamoto has quit IRC12:33
*** alexchadin has joined #openstack-release12:39
*** udesale__ has quit IRC12:44
*** thorst_ has joined #openstack-release12:49
*** thorst has quit IRC12:49
fungiwait, so that releases ref failed a second time after i reenqueued it?12:51
fungiwhen did we have an out of space issue yesterday (and where)?12:52
fungibut yeah, i agree http://logs.openstack.org/85/858c988956fce8ac8ed8a202fe91aadbc0387395/release-post/tag-releases/25848a5/console.html#_2017-10-10_02_22_54_676966 does look like a network connectivity problem (similar to why i reenqueued it to begin with)12:55
fungiand both the node and the merger are in the same region of rackspace, so either our git server farm was under extreme load or they're having internal network connectivity problems12:56
*** zhurong has joined #openstack-release12:58
*** shardy has quit IRC13:00
*** edmondsw_ is now known as edmondsw13:01
*** kzaitsev1pi has quit IRC13:05
*** pkovar has quit IRC13:05
*** pkovar has joined #openstack-release13:06
*** kzaitsev_pi has joined #openstack-release13:06
*** kumarmn has joined #openstack-release13:06
*** shardy has joined #openstack-release13:11
*** oanson has quit IRC13:14
*** oanson has joined #openstack-release13:15
*** mriedem has joined #openstack-release13:22
*** lbragstad has joined #openstack-release13:28
*** shardy has quit IRC13:29
*** bobh has joined #openstack-release13:33
*** dave-mccowan has joined #openstack-release13:33
*** kumarmn has quit IRC13:35
*** kumarmn has joined #openstack-release13:35
*** kumarmn has quit IRC13:35
*** kumarmn has joined #openstack-release13:36
*** kumarmn has quit IRC13:38
*** shardy has joined #openstack-release13:38
*** kumarmn has joined #openstack-release13:38
smcginnisfungi: Wasn't the tarball signing failure yesterday an out of space issue? Maybe i misunderstood.13:39
fungismcginnis: no, not out of space13:39
fungito save on quota in our control plane tenant, we replaced half our zuul v2 mergers (zm05-08) with v3 mergers13:40
fungihowever, the persistent v2 job nodes had git remotes cached from prior to that rejiggering13:40
fungiso you can see in the log zuul-cloner was told to use zm03 (a v2 merger) but then raised an error about zm07 (now a v3 merger)13:40
fungimore evidence that the (deprecated and replaced with a no-op shim in v3) zuul-cloner utility was designed to assume single-use node lifecycles13:40
fungi[resent from my input history for this channel]13:41
smcginnisAh, so not out of space. Wrong space. :)13:42
fungiindeed ;)13:43
fungithe fix was to just delete all the old workspaces so they'd get cloned anew when the job reran13:43
openstackgerritMerged openstack/releases master: Revert "Final newton release of Octavia and neutron-lbaas"  https://review.openstack.org/51086013:44
*** zhurong has quit IRC13:45
smcginnisfungi: Is this another one? http://logs.openstack.org/3d/3d5c1125a92cd90e739816ce01d72b9811c60521/release-post/tag-releases/6fe4bee/console.html#_2017-10-10_13_45_28_06569813:48
openstackgerritMerged openstack/releases master: Revert "Revert "Final newton release of Octavia and neutron-lbaas""  https://review.openstack.org/51086113:50
fungismcginnis: seems like it's failing consistently... i wonder if there's something wrong with the way the job is setting up the gerrit remote to be able to access the git notes13:51
fungii'll hop into that workspace and take a look13:51
fungiit's likely that some unexercised behavior change crept into that job because we had the remotes persisting with the workspace from a previous run13:51
smcginnisYeah, revert of the revert just hit the same thing: http://logs.openstack.org/b8/b8d320d6c94f8b1cc51a1336be3e574d10883b17/release-post/tag-releases/34a40b2/console.html13:52
fungiand so we didn't expose the problem until after i wiped the cached workspaces and it had to reset it from scratch13:52
fungiyeah, it has no gerrit remote at all and is, i think, trying to retrieve notes refs from the origin (in this case the zuul merger)13:54
*** hongbin has joined #openstack-release13:54
fungidid this job previously run git review -s or something maybe?13:55
fungiand perhaps that ended up getting dropped at some point?13:55
fungiif so, that would explain the behavior13:55
*** ricolin has quit IRC13:56
smcginnisNo remote? Guess that would explain why git fetch isn't happy.13:58
*** armax has joined #openstack-release13:58
fungiyeah, it gets normal refs from the zuul merger set as its origin, but that won't include git notes, which only gerrit serves up13:59
*** d0ugal has quit IRC14:00
*** d0ugal has joined #openstack-release14:00
*** d0ugal has quit IRC14:00
*** d0ugal has joined #openstack-release14:00
*** d0ugal has quit IRC14:01
*** d0ugal has joined #openstack-release14:02
*** d0ugal has joined #openstack-release14:02
ttxboo14:02
fungior maybe i'm mistaken and we do include the notes refs in replicas, but if so the logic here is wrong http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/scripts/release-tools/release_from_yaml.sh#n7114:02
ttxcan't wait until I revert the revert of the revert of the revert14:02
*** alexchadin has quit IRC14:03
fungiyeah, it works if i change the origin from zm03.o.o to git.o.o14:06
*** oanson has quit IRC14:06
fungiso we do replicate git notes to our push mirrors, but zuul mergers don't pull notes refs14:06
*** oanson has joined #openstack-release14:07
fungione working hack is to add a second remote to the git farm and then set that for the notes refs14:11
dhellmannfungi : I don't fully understand all of the differences in the way zuul is now setting up git repos, but it seems like the changes have broken a lot of assumptions in the release tools so I should probably look into it. Is there any documentation I can look at?14:11
fungione working hack is to add a second remote to the git farm and then set that for the notes refs14:12
fungier, up-arrow at the wrong moment14:12
fungidhellmann: what, you mean in zuul v2?14:12
fungithis is a v2 job problem14:12
dhellmannI don't really know what's changed, but this all *used* to work so something in the past couple of weeks is different.14:12
fungijust happened to be latent (likely for many months) exposed when i flushed the old copies of the workspaces on signing01.ci14:13
dhellmannso what was the change that was exposed when you did that flushing?14:13
dhellmannwas that a zuul-cloner change? or a change to our mirror setup? something else?14:13
dhellmannthe git portion of our infra is sort of a grey box to me :-/14:13
fungithe job is configured to clone the releases repo if it doesn't exist. at some point it managed to add a remote to its git config which provided git notes refs14:14
fungiwhich the job itself has been relying on14:14
dhellmannthat would have been a very very early thing -- we've always used the notes to get the info about who approved a release14:15
dhellmannI guess I also assumed that these jobs always cloned new copies of the repos every time14:15
fungihowever, since the repository was getting reused rather than completely deleted and recreated on every run, _something_ subsequently changed for the git config setup but since that was never exercised (due to reusing the copy on the persistent node it always runs on) we never noticed14:15
dhellmannyeah, I'm trying to understand that "_something_" :-)14:16
dhellmannit sounds like it may not be easy to tell exactly what it was14:16
dhellmanngiven the time that has passed14:16
*** alexchadin has joined #openstack-release14:16
fungimy guess is that the job originally did its own cloning, perhaps from git.openstack.org or review.openstack.org (which _do_ provide notes refs), then at a later date switched to using zuul-cloner which retrieves the ref from our zuul mergers (which don't pull notes refs), but since the origin was already set in .git/config under that job's workspace it kept working14:17
*** thorst_ has quit IRC14:18
dhellmannah14:19
fungiand this is simply the first time we've wiped workspaces on the signing01.ci.o.o node14:19
fungisince the job switched to using zuul-cloner14:19
dhellmannthat may be it; I remember a period where we had a bunch of raw git commands doing clones14:19
fungiso anyway, i've temporarily "fixed" the origin remote in that job's workspace such that it should go back to tits prior behavior for now14:20
dhellmannso, what's the solution? add notes to what we mirror? have the job add a separate remote that include the notes?14:20
dhellmannI thought the workspaces were cleared but zuul-cloner was pulling from a local mirror that was kept up to date. Is that incorrect?14:21
dhellmann*cleared automatically every time14:21
fungithe proper solution, if zuul v2 weren't basically frozen, would be to make sure zuul mergers also pull git notes refs and serve them, and improve zuul-cloner to be a bit more thorough on reused systems (it's designed more with single-use nodes and green-field workspaces in mind)14:22
fungifor v3, i mainly just need to double-check that zuul is actually pushing notes refs along with the repo state, or we need to look at altering the job to add a second remote explicitly for notes refs14:23
dhellmannand for zuul v3 I guess we get the workspace cleanup because we won't need to use a static node, but we'll have even more trouble with the notes because there's not even an origin remote (IIUC) so we're going to have to update this job for that case anyway14:23
fungier, well first remote in that case, but yes that's more or less the situation14:23
fungiso anyway, the job as it stands on v2 should work for now by way of me hacking the workspace back into some semblance of its prior latent configuration14:24
fungiand i'll be double-checking the v3 story around git notes14:25
dhellmannok. I would like to be involved in any fix for v3, since that sounds like a good opportunity to learn more about how these bits work under the new system.14:25
fungibut feel free to approve that re-re-revert at your convenience14:25
*** edmondsw has quit IRC14:25
dhellmannalso because, you know, I'll *help* with the fix :-)14:25
fungidhellmann: you bet, and help is appreciated!14:25
*** edmondsw has joined #openstack-release14:26
*** edmondsw_ has joined #openstack-release14:27
*** edmonds__ has joined #openstack-release14:28
*** edmondsw has quit IRC14:30
*** zen369 has quit IRC14:31
*** thorst has joined #openstack-release14:31
*** edmondsw_ has quit IRC14:31
*** claudiub|2 has quit IRC14:33
*** alexchadin has quit IRC14:37
smcginnisttx: Did you want the fun of reverting the revert of the reverting revert>14:37
ttxI'm in a meeting tunnel now14:38
ttxso... no14:38
smcginnisOK, I can take care of that.14:38
openstackgerritSean McGinnis proposed openstack/releases master: Revert "Revert "Revert "Final newton release of Octavia and neutron-lbaas"""  https://review.openstack.org/51090414:39
*** nikhil has joined #openstack-release14:44
*** ricolin has joined #openstack-release14:57
*** thorst has quit IRC15:01
*** kumarmn has quit IRC15:22
*** thorst has joined #openstack-release15:23
*** kumarmn has joined #openstack-release15:23
openstackgerritMerged openstack/releases master: Revert "Revert "Revert "Final newton release of Octavia and neutron-lbaas"""  https://review.openstack.org/51090415:26
*** kumarmn has quit IRC15:27
*** edmonds__ has quit IRC15:29
*** thorst has quit IRC15:30
openstackgerritSean McGinnis proposed openstack/releases master: Revert "Revert "Revert "Revert "Final newton release of Octavia and neutron-lbaas""""  https://review.openstack.org/51091615:31
*** udesale__ has joined #openstack-release15:31
johnsomlol15:31
*** shardy_ has joined #openstack-release15:32
*** edmondsw has joined #openstack-release15:32
*** udesale__ has quit IRC15:33
smcginnisjohnsom: Let's just hope we don't end up with more than 5 "revert"s in the commit message. ;)15:33
*** thorst has joined #openstack-release15:34
johnsomYep.  Thanks for tracking this down for us!  I still wonder if we should not have selected a canary as our mascot.15:34
smcginnisHaha, that would have been a good one.15:34
smcginnisLooks like the post-release jobs all passed on the last revert, so the redo revert should hopefully work this time.15:36
*** edmondsw_ has joined #openstack-release15:36
*** edmondsw has quit IRC15:37
*** thorst has quit IRC15:39
*** shardy_ has quit IRC15:40
*** edmondsw_ has quit IRC15:41
openstackgerritMerged openstack/releases master: Revert "Revert "Revert "Revert "Final newton release of Octavia and neutron-lbaas""""  https://review.openstack.org/51091615:42
*** thorst has joined #openstack-release15:43
*** yamahata has joined #openstack-release15:44
smcginnisWoot, tag-releases passed.15:44
*** thorst_ has joined #openstack-release15:46
*** thorst has quit IRC15:49
johnsom+115:50
*** edmondsw has joined #openstack-release15:50
smcginnisPost jobs complete. Looks like we are in the clear. For now.15:51
*** kumarmn has joined #openstack-release15:51
*** kumarmn_ has joined #openstack-release15:53
*** thorst has joined #openstack-release15:53
*** csomerville has joined #openstack-release15:53
*** thorst_ has quit IRC15:54
*** edmondsw has quit IRC15:55
*** kumarmn has quit IRC15:56
*** edmondsw has joined #openstack-release15:56
*** yamahata has quit IRC16:00
*** dave-mcc_ has joined #openstack-release16:01
*** dave-mccowan has quit IRC16:04
*** pcaruana has quit IRC16:07
*** lucasagomes is now known as lucas-afk16:08
*** spzala has joined #openstack-release16:13
*** spzala has quit IRC16:13
openstackgerritEmilien Macchi proposed openstack/releases master: TripleO Ocata release  https://review.openstack.org/51093116:21
*** kumarmn has joined #openstack-release16:24
openstackgerritEmilien Macchi proposed openstack/releases master: TripleO Pike release  https://review.openstack.org/51093316:25
*** kumarmn_ has quit IRC16:26
openstackgerritEmilien Macchi proposed openstack/releases master: TripleO Ocata release  https://review.openstack.org/51093116:32
*** kumarmn has quit IRC16:35
*** kumarmn has joined #openstack-release16:36
*** jpich has quit IRC16:39
*** csomerville has quit IRC16:41
*** kumarmn has quit IRC16:41
*** csomerville has joined #openstack-release16:41
*** kumarmn has joined #openstack-release16:41
*** shardy has quit IRC16:46
EmilienMrelease-managers: please review https://review.openstack.org/#/c/510933/ and https://review.openstack.org/#/c/510931/16:53
*** kumarmn has quit IRC16:56
toabctlsmcginnis, hey. could you merge https://review.openstack.org/#/c/510764/ please?16:56
*** kumarmn has joined #openstack-release16:56
smcginnistoabctl: On its way.16:56
toabctlsmcginnis, thanks!16:57
smcginnisEmilienM: I'll take a look at yours next.16:57
EmilienMsmcginnis: thanks16:57
dhellmannif things are working now, I can take a look at the queue16:57
dhellmannit is my review day...16:57
smcginnisdhellmann: Yep, we should be in the clear now.16:57
smcginnisdhellmann: If you wouldn't mind, I was just about to grab some lunch.16:57
dhellmannsure, I'm on it16:58
openstackgerritMerged openstack/releases master: Release renderspec 1.9.1 bugfix release  https://review.openstack.org/51076417:02
*** inc0 has quit IRC17:02
*** inc0 has joined #openstack-release17:03
*** lifeless has quit IRC17:03
*** kumarmn has quit IRC17:04
*** tellesnobrega has joined #openstack-release17:05
openstackgerritMerged openstack/releases master: TripleO Ocata release  https://review.openstack.org/51093117:10
openstackgerritMerged openstack/releases master: TripleO Pike release  https://review.openstack.org/51093317:12
openstackgerritDoug Hellmann proposed openstack/releases master: add release notes output to the list-changes job  https://review.openstack.org/50927817:14
*** lifeless has joined #openstack-release17:20
*** kumarmn has joined #openstack-release17:21
*** lukebrowning has quit IRC17:24
*** lukebrowning has joined #openstack-release17:24
*** kumarmn has quit IRC17:25
*** ricolin has quit IRC17:25
*** zen369 has joined #openstack-release17:34
*** dtantsur is now known as dtantsur|afk17:38
*** cody-somerville has joined #openstack-release17:52
*** kumarmn has joined #openstack-release17:52
*** csomerville has quit IRC17:54
*** sree has quit IRC17:59
*** sree has joined #openstack-release18:00
*** sree has quit IRC18:05
*** jtomasek has quit IRC18:09
*** amoralej is now known as amoralej|off18:13
*** pkovar has quit IRC18:15
*** coolsvap has quit IRC18:15
*** electrofelix has quit IRC18:21
*** kumarmn has quit IRC18:28
*** kumarmn has joined #openstack-release18:28
*** kumarmn has quit IRC18:33
*** cody-somerville has quit IRC18:53
*** cody-somerville has joined #openstack-release18:55
openstackgerritLance Bragstad proposed openstack/releases master: Add keystone deadlines to queens schedule  https://review.openstack.org/50983519:00
fungidhellmann:     https://review.openstack.org/510994 Use a separate git remote for release job notes19:11
fungithat's my suggestion for the workaround19:11
fungiwe can iterate from there19:11
fungii confirmed that zuul does not (in v2 nor v3) provide git notes refs (yet)19:11
fungifor the future, i found how i believe you're supposed to be able to access them from gitpython19:12
fungiso we can probably get them pushed into the prepared repos on the job nodes with a little bit of additional work in zuul19:13
*** armax has quit IRC19:14
dhellmannfungi : thanks, that looks good with 1 comment19:27
fungidhellmann: good call, thanks!19:29
fungiwill fix unless you want to do the honors19:29
dhellmanngo for it19:29
*** pkovar has joined #openstack-release19:41
*** thorst has quit IRC19:46
*** thorst has joined #openstack-release19:51
fungidhellmann: looks like the variable you're suggesting gets set to the full path on the filesystem: http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/jobs/release-jobs.yaml#n1919:53
dhellmannaw, bummer19:53
fungishould i attempt to parse the repository name out of that path?19:53
fungi(and can we assume local users will always set it to the same name?)19:53
dhellmannno, we probably can't make that assumption19:54
fungialternatively, it may make sense to just hard-code openstack/releases there in the script, with the expectation that we'll have to fix that (along with a bunch of other release stuff probably) when we flatten namespaces19:54
dhellmannwell, I know we can't, because I'd break it myself19:54
dhellmanndoes the local repo have any other remotes at all?19:54
dhellmannwould those match except for the hostname?19:55
dhellmannin the reno jobs we were finding that the repo didn't have a remote under v319:55
fungiin v2 it has an origin remote which is the zuul merger, but in v3 it has no remotes initially until we add one19:55
dhellmannright19:55
dhellmannok, so let's just hard-code it for now19:55
fungican do19:55
*** pkovar has quit IRC19:55
*** thorst has quit IRC19:56
dhellmannoh, I guess you could use ZUUL_PROJECT if it's set19:56
dhellmannfungi : ^^19:56
dhellmannthat way at least the CI system would keep working after the rename19:56
dhellmannit should be pretty clear what the error is when someone runs it locally19:56
clarkbthere is a compatibility role to have the ZUUL_* things added to your env but they aren't part of the v3 default api like they were in v219:56
dhellmannmaybe even throw in a warning "ZUUL_PROJECT is not set, defaulting releases repo to xxx"19:57
fungidhellmann: that could work19:57
dhellmannclarkb : the 2 cases we have for this script are running in CI and running on my local server (and possibly ttx's or smcginnis')19:57
fungiclarkb: yeah, i anticipate needing to tweak playbooks/release/tag.yaml to add $ZUUL_PROJECT19:58
dhellmannoh, I see what you mean now19:58
fungisince this was one of the release jobs mordred attempted to rewrite as a v3 native job and i'd rather not revert it to legacy just for one compatibility variable19:58
dhellmannyeah, we can also change ZUUL_PROJECT to some other name if there's a different variable19:59
smcginnisSo default it to work right locally but fix it to work right in the gate.19:59
mordredfungi, smcginnis, dhellmann: tl;dr me?19:59
fungismcginnis: yeah, that's what i expect we're ending up with19:59
dhellmannsmcginnis : right. although "work right locally" will stop working right when we flatten the git namespaces, but at that point attempting to update the repo will fail with an error that should make it clear the URL is bad19:59
fungimordred: https://review.openstack.org/51099420:00
fungicommit message is the tl;dr20:00
smcginnisdhellmann: I have a feeling there will be some pain when that happens anyway.20:00
dhellmannlikely20:01
mordredfungi: cool - that20:05
mordredfungi: what if we added the remote in the pre-playbook of the tag-releases job rather than updating that jenkins script?20:05
mordredfungi: that way we could actually use the canonical_name from the zuul variables20:06
dhellmannmordred : that wouldn't solve the local user case, would it?20:06
dhellmannI guess we could do both20:06
mordredsure it would - the local user already has an origin - so if we just leave it as origin ...20:07
smcginnisDon't we already have the remote locally?20:07
dhellmannmordred : oh, sure, that makes sense20:07
mordredand have tag-releaess just add an origin remote to every project that's in {{ zuul.projects }} using canonical name20:07
dhellmannthat works20:08
*** thorst has joined #openstack-release20:08
dhellmannis that a thing we just turn on, or is it a separate script?20:08
mordredsomething like this: http://paste.openstack.org/show/623275/20:10
dhellmannswanky20:10
fungimordred: the script itself is still going to break as-is because it explicitly calls `git remote update origin`20:14
mordredfungi, dhellmann, smcginnis: https://review.openstack.org/511004 Add an origin remote for tag-releases for notes <-- there is a sake-of-argument version20:14
fungimordred: oh, i see. you're adding a remote called origin20:14
mordredyah. mostly wanting to avoid mucking with that script during the interregnum20:15
fungimordred: the other incentive for my change was to correct the job under v2 in case we end up having to roll back again, since it's only working right now by way of manual surgery i performed to the workspace on signing01.ci20:15
mordredfungi: ah - gotcha - that makes sense to me20:16
fungibut i'm willing to acknowledge that's a low risk (if we roll back to v2 we just need to avoid blowing away the workspaces there again until we're finally on v3)20:16
dhellmannfungi : maybe we should do both things, and update the script to first check for an origin remote then check for the notes20:16
fungii think i'm in favor of mordred's change, since it's less fiddling with scripts which are basically working for now, and the risk of this breaking again even if we roll back to v2 is reasonably low now that we know why it broke20:18
mordredalso - as soon as we're happy that we're not going to rollback, this particular job is a GREAT example to work on to figure  out a good story for wanting both local execution and remote execution20:19
mordredsince part of the theory behind using ansible for job content is that theoretically one should be able use playbook content that you use for other things also in zuul jobs20:19
dhellmannfungi : ok, that makes sense20:19
mordredbut most of our content so far is content writen specifically for zuul jobs20:19
dhellmannfungi , mordred , smcginnis : were we going to be able to move the definition of the job into the releases repo? or does it need to stay in a more shared repo?20:20
mordredit seems there's a good opportunity to learn what 'run it locally' means here20:20
mordreddhellmann: we can totally move it to the releases repo - and I think we should20:20
fungidhellmann: one up-side to v3 is that it does allow us to keep the secrets these jobs need under infra control while letting the jobs which use them move wherever20:20
dhellmannI usually check out the releases repo to the commit with the stuff I want processed then run the script and point it at that directory. It figures out which deliverable files changed by using git commands.20:20
mordreddhellmann: there are no jobs that must be in project-config - the only thing thatmust go into project-config is assigning a job to another project20:21
fungidhellmann: the not-so-well-explained idea with zuul v3 is that you should be able to check out your repo and then run your jobs (by just calling ansible and telling it the job you want to run)20:21
mordredfungi: yah - that's a thing we need some better stories on20:22
smcginnisShould we prioritize moving in-repo? Or we can take time to move things over once things have settled, right?20:22
fungismcginnis: the latter, in my opinion20:22
smcginnisfungi: OK, that's what I thought.20:22
mordreddhellmann: so tag-releases can be in openstack/releases (or openstack/release-tools) - along with the secrets it needs - along with the project-template for  it20:23
mordredbut assigning that project-template to all of the official repos has to happen in project-config20:23
mordredit'll really be a question of whether the ssh key (needed to push tags to gerrit) and the launchpad api key are secrets that want to be owned by the release team or the infra team20:24
fungiyeah, i suppose we could always have an infra-root encrypt the secrets those jobs need and then submit changes to the releases repo or wherever containing the encrypted secret material20:24
mordred(the job using a secret must be in the repo where the secret is defined - so if infra owns the secret infra has to own the job)20:24
mordredfungi: nope - we can't20:24
fungiwe can't?20:24
dhellmannmordred : ideally we'll be able to stop using release-tool soon20:24
mordredfungi: oh - I see what you're saying - yes, we could do that20:25
dhellmannwe're already moving some of the other commands into the releases repo20:25
mordredfungi: but the release team would be able to see them by submitting a change to print the secret, so I tihnk we'd want to shift ownership of the secret20:25
fungimordred: agreed, that is a risk we have to take into account20:25
dhellmanndoes that mean anyone would be able to submit a patch and print the contents of the key?20:27
dhellmannor would we have special privileges because we have +2 on the repo?20:28
*** openstackgerrit has quit IRC20:33
*** sree has joined #openstack-release20:36
*** sree has quit IRC20:40
*** wolverineav has quit IRC20:59
*** zen369 has quit IRC21:01
fungidhellmann: secrets are scoped to post-review pipelines only21:13
fungiso a core reviewer would at least need to approve a change to the repo containing the secret to expose it21:14
dhellmannso someone would have to approve a patch21:14
dhellmanngot it21:14
*** claudiub|2 has joined #openstack-release21:15
*** thorst has quit IRC21:21
*** yamahata has joined #openstack-release21:26
*** edmondsw has quit IRC21:33
*** edmondsw_ has joined #openstack-release21:35
*** edmondsw_ has quit IRC21:39
*** edmondsw has joined #openstack-release22:08
*** bobh has quit IRC22:11
*** edmondsw has quit IRC22:13
*** pbandark has quit IRC22:17
*** yamamoto has joined #openstack-release22:19
*** sdague has quit IRC22:39
*** armax has joined #openstack-release22:48
*** sree has joined #openstack-release23:01
*** sree has quit IRC23:05
*** claudiub|2 has quit IRC23:15
*** thorst has joined #openstack-release23:22
*** hongbin has quit IRC23:22
*** thorst has quit IRC23:27
*** rosmaita has quit IRC23:34
*** mriedem has quit IRC23:38

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!