| *** kumarmn has quit IRC | 00:03 | |
| *** yamamoto has joined #openstack-release | 00:12 | |
| *** openstack has joined #openstack-release | 00:14 | |
| *** ChanServ sets mode: +o openstack | 00:14 | |
| *** yamamoto has quit IRC | 00:17 | |
| *** dave-mccowan has joined #openstack-release | 00:21 | |
| *** yamahata has joined #openstack-release | 00:38 | |
| *** yamamoto has joined #openstack-release | 00:38 | |
| *** yamamoto has quit IRC | 00:45 | |
| *** yamahata has quit IRC | 00:49 | |
| *** odyssey4me has quit IRC | 00:53 | |
| *** odyssey4me has joined #openstack-release | 00:53 | |
| *** yamamoto has joined #openstack-release | 00:56 | |
| *** annabelleB has joined #openstack-release | 00:57 | |
| *** bobh has joined #openstack-release | 01:05 | |
| *** gyankum has joined #openstack-release | 01:12 | |
| *** yamamoto has quit IRC | 01:14 | |
| *** prometheanfire has quit IRC | 01:15 | |
| *** gongysh has joined #openstack-release | 01:16 | |
| *** bobh has quit IRC | 01:17 | |
| *** notmyname has quit IRC | 01:17 | |
| *** annabelleB has quit IRC | 01:21 | |
| *** hongbin has joined #openstack-release | 01:22 | |
| *** prometheanfire has joined #openstack-release | 01:22 | |
| *** notmyname has joined #openstack-release | 01:22 | |
| *** prometheanfire has quit IRC | 01:29 | |
| *** sree has quit IRC | 01:36 | |
| *** sree has joined #openstack-release | 01:37 | |
| *** gongysh has quit IRC | 01:38 | |
| *** sree has quit IRC | 01:41 | |
| *** bobh has joined #openstack-release | 01:45 | |
| *** rosmaita has quit IRC | 01:50 | |
| *** bobh has quit IRC | 01:53 | |
| *** prometheanfire has joined #openstack-release | 01:55 | |
| *** ykarel|away has joined #openstack-release | 02:02 | |
| *** ykarel|away has quit IRC | 02:14 | |
| *** yamamoto has joined #openstack-release | 02:15 | |
| *** ykarel|away has joined #openstack-release | 02:16 | |
| *** yamamoto has quit IRC | 02:21 | |
| *** ekcs has quit IRC | 02:26 | |
| *** ekcs has joined #openstack-release | 02:27 | |
| *** ricolin has joined #openstack-release | 02:32 | |
| *** zhurong has joined #openstack-release | 02:32 | |
| *** ykarel|away has quit IRC | 02:34 | |
| *** gongysh has joined #openstack-release | 02:35 | |
| *** annabelleB has joined #openstack-release | 02:36 | |
| *** yamamoto has joined #openstack-release | 02:37 | |
| *** sree has joined #openstack-release | 02:39 | |
| *** sree has quit IRC | 02:39 | |
| *** sree has joined #openstack-release | 02:39 | |
| *** annabelleB has quit IRC | 03:07 | |
| *** annabelleB has joined #openstack-release | 03:13 | |
| *** yamamoto has quit IRC | 03:18 | |
| *** kumarmn has joined #openstack-release | 03:31 | |
| *** annabelleB has quit IRC | 03:37 | |
| *** hongbin has quit IRC | 03:43 | |
| *** kumarmn has quit IRC | 03:45 | |
| *** dave-mccowan has quit IRC | 03:55 | |
| *** udesale has joined #openstack-release | 03:57 | |
| *** ykarel|away has joined #openstack-release | 04:15 | |
| *** yamamoto has joined #openstack-release | 04:19 | |
| *** gongysh has quit IRC | 04:19 | |
| *** yamamoto has quit IRC | 04:25 | |
| *** udesale has quit IRC | 04:58 | |
| *** udesale has joined #openstack-release | 04:59 | |
| *** armax has quit IRC | 04:59 | |
| *** yamamoto has joined #openstack-release | 05:21 | |
| *** e0ne has joined #openstack-release | 05:26 | |
| *** yamamoto has quit IRC | 05:27 | |
| *** e0ne has quit IRC | 05:33 | |
| *** jtomasek has joined #openstack-release | 05:43 | |
| *** e0ne has joined #openstack-release | 05:50 | |
| *** claudiub|2 has joined #openstack-release | 05:59 | |
| *** gongysh has joined #openstack-release | 06:02 | |
| *** e0ne has quit IRC | 06:10 | |
| *** yamamoto has joined #openstack-release | 06:23 | |
| *** claudiub has joined #openstack-release | 06:26 | |
| *** udesale_ has joined #openstack-release | 06:28 | |
| *** yamamoto has quit IRC | 06:28 | |
| *** claudiub|2 has quit IRC | 06:29 | |
| *** ykarel_ has joined #openstack-release | 06:30 | |
| *** udesale has quit IRC | 06:30 | |
| *** udesale__ has joined #openstack-release | 06:30 | |
| *** jtomasek has quit IRC | 06:32 | |
| *** ykarel|away has quit IRC | 06:32 | |
| *** udesale_ has quit IRC | 06:33 | |
| *** pcaruana has joined #openstack-release | 06:38 | |
| *** alexchadin has joined #openstack-release | 06:39 | |
| *** ykarel__ has joined #openstack-release | 07:03 | |
| *** gongysh has quit IRC | 07:04 | |
| *** ykarel_ has quit IRC | 07:06 | |
| *** zhurong has quit IRC | 07:08 | |
| *** gongysh has joined #openstack-release | 07:10 | |
| *** ianychoi has quit IRC | 07:10 | |
| *** ykarel__ is now known as ykarel | 07:13 | |
| *** yamamoto has joined #openstack-release | 07:25 | |
| *** alexchadin has quit IRC | 07:26 | |
| *** electrofelix has joined #openstack-release | 07:27 | |
| *** yamamoto has quit IRC | 07:30 | |
| *** alexchadin has joined #openstack-release | 07:31 | |
| *** shardy has joined #openstack-release | 07:38 | |
| *** udesale__ is now known as udesale | 07:43 | |
| *** lucas-afk is now known as lucasagomes | 07:56 | |
| *** jpich has joined #openstack-release | 08:04 | |
| *** gongysh has quit IRC | 08:23 | |
| openstackgerrit | Merged openstack/releases master: Add Rocky TC Election Dates https://review.openstack.org/556610 | 08:25 |
|---|---|---|
| *** yamamoto has joined #openstack-release | 08:26 | |
| openstackgerrit | Merged openstack/releases master: add a validation rule to prevent pre-releases after finals https://review.openstack.org/556992 | 08:27 |
| *** e0ne has joined #openstack-release | 08:27 | |
| *** yamamoto has quit IRC | 08:30 | |
| openstackgerrit | Merged openstack/releases master: Release os-brick 2.3.1 for stable/queens https://review.openstack.org/555878 | 08:34 |
| *** oanson has quit IRC | 08:34 | |
| *** oanson has joined #openstack-release | 08:36 | |
| *** alexchadin has quit IRC | 08:57 | |
| *** udesale has quit IRC | 08:58 | |
| *** alexchadin has joined #openstack-release | 08:58 | |
| cmurphy | sorry to be a bother, looks like https://review.openstack.org/#/c/555194/ merged but the new tag never made it in http://git.openstack.org/cgit/openstack/django_openstack_auth/refs/ :( | 09:02 |
| *** udesale has joined #openstack-release | 09:05 | |
| *** shardy has quit IRC | 09:10 | |
| *** shardy has joined #openstack-release | 09:12 | |
| *** yamamoto has joined #openstack-release | 09:27 | |
| *** yamamoto has quit IRC | 09:32 | |
| *** alexchadin has quit IRC | 09:34 | |
| *** dtantsur|afk is now known as dtantsur | 09:46 | |
| *** ykarel is now known as ykarel|afk | 09:53 | |
| *** sree has quit IRC | 09:56 | |
| *** sree has joined #openstack-release | 09:57 | |
| *** sree has quit IRC | 10:02 | |
| ttx | hmm looking | 10:02 |
| *** ykarel|afk is now known as ykarel | 10:09 | |
| ttx | http://logs.openstack.org/1b/1b3550b2f705512063120e79a1bc8f8dbfc2672f/release-post/tag-releases/092f957/job-output.txt.gz#_2018-03-27_20_02_08_766353 shows tagging | 10:10 |
| ttx | digging deeper | 10:10 |
| *** ianychoi has joined #openstack-release | 10:15 | |
| ttx | The tagging script completed successfully. Wondering if there was a replication issue | 10:16 |
| ttx | cmurphy: ok so I don't really know what happened... On one hand the tagging script completed successfully but the tag was not created, and none of the tag-triggered jobs ran. | 10:24 |
| ttx | dhellmann: If you could have a look ^ -- it's a bit worrying since this clearly falls in a hole in our error detection logic | 10:25 |
| ttx | If it's a random fail we might need a "was the tag REALLY created" post-run task | 10:27 |
| *** yamamoto has joined #openstack-release | 10:29 | |
| cmurphy | thanks for looking ttx | 10:32 |
| *** yamamoto has quit IRC | 10:34 | |
| *** alexchadin has joined #openstack-release | 10:35 | |
| *** udesale_ has joined #openstack-release | 10:46 | |
| *** udesale has quit IRC | 10:49 | |
| *** udesale_ has quit IRC | 10:52 | |
| *** zhurong has joined #openstack-release | 10:55 | |
| *** gyankum has quit IRC | 10:56 | |
| *** ykarel_ has joined #openstack-release | 11:03 | |
| *** ykarel has quit IRC | 11:04 | |
| *** chandankumar has quit IRC | 11:04 | |
| *** ykarel__ has joined #openstack-release | 11:05 | |
| *** ykarel_ has quit IRC | 11:08 | |
| *** dave-mccowan has joined #openstack-release | 11:09 | |
| *** jtomasek has joined #openstack-release | 11:10 | |
| *** sree has joined #openstack-release | 11:14 | |
| *** pkovar has joined #openstack-release | 11:14 | |
| *** sree has quit IRC | 11:19 | |
| *** chkumar246 has joined #openstack-release | 11:20 | |
| *** pkovar has quit IRC | 11:24 | |
| *** shardy is now known as shardy_lunch | 11:24 | |
| *** pkovar has joined #openstack-release | 11:27 | |
| *** jtomasek has quit IRC | 11:28 | |
| *** sree has joined #openstack-release | 11:29 | |
| *** yamamoto has joined #openstack-release | 11:31 | |
| *** dtantsur is now known as dtantsur|brb | 11:31 | |
| *** sree_ has joined #openstack-release | 11:32 | |
| *** sree_ is now known as Guest40822 | 11:33 | |
| *** yamamoto has quit IRC | 11:35 | |
| *** sree has quit IRC | 11:35 | |
| *** ykarel__ is now known as ykarel | 11:49 | |
| *** lucasagomes is now known as lucas-hungry | 11:55 | |
| smcginnis | cmurphy: We may need to do a d-o-a release incrementing the bugfix version if the tag was applied. | 12:01 |
| smcginnis | cmurphy: Otherwise we can't get it to do the other release steps if it sees the tag is already there. | 12:02 |
| smcginnis | But still looking... | 12:02 |
| *** udesale has joined #openstack-release | 12:02 | |
| *** rosmaita has joined #openstack-release | 12:04 | |
| *** rosmaita has quit IRC | 12:04 | |
| *** bobh has joined #openstack-release | 12:06 | |
| *** edmondsw has joined #openstack-release | 12:06 | |
| smcginnis | ttx: Looks like we need to handle retired repos better here: "No '.gitreview' file found in this repository. We don't know where your gerrit is.." | 12:09 |
| smcginnis | That seems to be where things went off the rails. | 12:09 |
| smcginnis | So if we fix the tool to check out the right branch, we should then be able to just re-enqueue the release job and have it work. | 12:10 |
| smcginnis | No need to do another release (which wouldn't even help in this case). | 12:10 |
| *** rosmaita has joined #openstack-release | 12:12 | |
| *** odyssey4me has quit IRC | 12:22 | |
| *** odyssey4me has joined #openstack-release | 12:22 | |
| *** yamamoto has joined #openstack-release | 12:22 | |
| ttx | the issue seems to be that git review -s -v can fail and the script does not catch the failure | 12:31 |
| *** zhurong has quit IRC | 12:34 | |
| *** bobh has quit IRC | 12:34 | |
| *** chkumar246 is now known as chandankumar | 12:43 | |
| smcginnis | ttx: Well, the issue is we don't check out the stable branch. So since the repo is retired, there is no .gitreview file. | 12:46 |
| smcginnis | So I think we need to be a little more robust there. Right now we don't pass along anything saying which branch. | 12:47 |
| smcginnis | Not sure the best way, but we could make this "clone_repo $REPO stable/$SERIES || clone $REPO" - https://github.com/openstack-infra/project-config/blob/master/roles/copy-release-tools-scripts/files/release-tools/release.sh#L59 | 12:48 |
| smcginnis | Seems a little hacky, so I'm sure there's a better way than that. | 12:48 |
| smcginnis | Hmm, looks like clone_repo will fall back to master if the branch isn't found. So maybe we don't need the OR in there and can just try it. | 12:51 |
| smcginnis | bbiab | 12:51 |
| ttx | ha-hah. | 12:54 |
| ttx | smcginnis: I'm actually more concerned by the fact the issue escaped all our error detection logic | 12:54 |
| ttx | i.e. if cmurphy did not spot it we would not even know about it | 12:54 |
| *** lucas-hungry is now known as lucasagomes | 12:55 | |
| ttx | OK I think I got it | 12:57 |
| *** lbragstad has joined #openstack-release | 13:04 | |
| dhellmann | ttx, smcginnis : o/ | 13:06 |
| *** mriedem has joined #openstack-release | 13:06 | |
| dhellmann | ttx: are you working on the clone_repo fix, or should I? | 13:07 |
| dhellmann | I see an extra "return 0" in there and that seems suspect. | 13:07 |
| ttx | dhellmann: actually the error is deeper | 13:12 |
| ttx | I think | 13:12 |
| ttx | dhellmann: see https://review.openstack.org/557325 | 13:12 |
| *** ykarel_ has joined #openstack-release | 13:12 | |
| dhellmann | ah | 13:12 |
| ttx | I mean, yes that too | 13:12 |
| *** ykarel has quit IRC | 13:12 | |
| ttx | My main issue is that the error flies below radar. But then we also need to fix the real error :) | 13:13 |
| ttx | dhellmann: I haven't really tested my change, but it seems like an obvious issue | 13:14 |
| *** ykarel__ has joined #openstack-release | 13:14 | |
| dhellmann | yes | 13:14 |
| *** dtantsur|brb is now known as dtantsur | 13:15 | |
| ttx | dhellmann: I did not work on the "real" error | 13:15 |
| dhellmann | ok | 13:15 |
| dhellmann | let me see if I can do something there | 13:15 |
| dhellmann | it's unfortunate that we remove all of the metadata for a project when we retire it :-( | 13:16 |
| *** ykarel_ has quit IRC | 13:17 | |
| dhellmann | hmm | 13:17 |
| dhellmann | I'm not sure that passing the branch to clone_repo.sh is going to do what we want | 13:20 |
| dhellmann | I think if that branch doesn't exist it's going to fail | 13:20 |
| smcginnis | dhellmann: But then it falls back to master, if I was looking at the right place. | 13:24 |
| smcginnis | So even if we try to checkout stable/rocky, it should end up on master. | 13:24 |
| * dhellmann looks closer | 13:25 | |
| dhellmann | ah, that || | 13:25 |
| smcginnis | https://github.com/openstack-infra/project-config/blob/master/roles/copy-release-tools-scripts/files/release-tools/clone_repo.sh#L196 | 13:25 |
| dhellmann | yeah, I think you're right | 13:25 |
| dhellmann | ok, let's see about this then | 13:25 |
| *** Guest40822 has quit IRC | 13:27 | |
| *** sree has joined #openstack-release | 13:28 | |
| *** electrofelix has quit IRC | 13:29 | |
| *** ykarel__ is now known as ykarel | 13:31 | |
| *** udesale has quit IRC | 13:32 | |
| *** kumarmn has joined #openstack-release | 13:33 | |
| *** sree has quit IRC | 13:33 | |
| *** alexchadin has quit IRC | 13:37 | |
| *** alexchadin has joined #openstack-release | 13:39 | |
| *** annabelleB has joined #openstack-release | 13:53 | |
| *** rosmaita has quit IRC | 13:55 | |
| openstackgerrit | Merged openstack/releases master: Remove branch heat-tempest-plugin https://review.openstack.org/540269 | 13:59 |
| *** udesale has joined #openstack-release | 14:05 | |
| *** udesale has quit IRC | 14:05 | |
| *** udesale has joined #openstack-release | 14:05 | |
| *** esberglu has joined #openstack-release | 14:05 | |
| *** hongbin has joined #openstack-release | 14:06 | |
| *** jrist has quit IRC | 14:07 | |
| *** armax has joined #openstack-release | 14:17 | |
| *** mlavalle has joined #openstack-release | 14:18 | |
| *** ykarel has quit IRC | 14:20 | |
| *** alexchadin has quit IRC | 14:24 | |
| *** ricolin has quit IRC | 14:31 | |
| *** ricolin has joined #openstack-release | 14:32 | |
| *** jrist has joined #openstack-release | 14:33 | |
| *** jrist has quit IRC | 14:33 | |
| *** jrist has joined #openstack-release | 14:33 | |
| *** ianychoi_ has joined #openstack-release | 14:33 | |
| *** ianychoi has quit IRC | 14:36 | |
| *** ykarel has joined #openstack-release | 14:46 | |
| *** annabelleB has quit IRC | 14:50 | |
| *** udesale has quit IRC | 14:50 | |
| *** shardy_lunch is now known as shardy | 14:53 | |
| *** kevinbenton has quit IRC | 14:58 | |
| *** udesale has joined #openstack-release | 14:59 | |
| *** udesale has quit IRC | 15:03 | |
| *** kevinbenton has joined #openstack-release | 15:06 | |
| *** annabelleB has joined #openstack-release | 15:07 | |
| *** pcaruana has quit IRC | 15:09 | |
| *** gyankum has joined #openstack-release | 15:11 | |
| *** prometheanfire has quit IRC | 15:14 | |
| *** prometheanfire has joined #openstack-release | 15:28 | |
| *** bobh has joined #openstack-release | 15:31 | |
| *** bobh has quit IRC | 15:36 | |
| *** bobh has joined #openstack-release | 15:43 | |
| *** sree has joined #openstack-release | 15:44 | |
| *** bobh has quit IRC | 15:48 | |
| *** sree has quit IRC | 15:49 | |
| *** rosmaita has joined #openstack-release | 15:52 | |
| *** bobh has joined #openstack-release | 15:53 | |
| openstackgerrit | Jakub Libosvar proposed openstack/releases master: Neutron Queens 12.0.1 https://review.openstack.org/557383 | 15:54 |
| *** bobh has quit IRC | 15:58 | |
| *** bobh has joined #openstack-release | 16:00 | |
| *** bobh has quit IRC | 16:05 | |
| *** bobh has joined #openstack-release | 16:08 | |
| *** lucasagomes is now known as lucas-afk | 16:13 | |
| *** jpich has quit IRC | 16:29 | |
| *** annabelleB has quit IRC | 16:31 | |
| *** yamahata has joined #openstack-release | 16:40 | |
| *** annabelleB has joined #openstack-release | 16:42 | |
| *** ekcs has quit IRC | 16:55 | |
| *** pkovar has quit IRC | 16:57 | |
| *** e0ne has quit IRC | 17:01 | |
| *** dtantsur is now known as dtantsur|afk | 17:10 | |
| *** iyamahat has joined #openstack-release | 17:22 | |
| *** yamamoto has quit IRC | 17:29 | |
| *** ekcs has joined #openstack-release | 17:35 | |
| *** shardy has quit IRC | 17:35 | |
| *** iyamahat has quit IRC | 17:38 | |
| *** yamahata has quit IRC | 17:38 | |
| *** ricolin has quit IRC | 17:42 | |
| *** yamamoto has joined #openstack-release | 17:46 | |
| *** annabelleB has quit IRC | 18:03 | |
| *** lvdombrkr has joined #openstack-release | 18:05 | |
| *** annabelleB has joined #openstack-release | 18:06 | |
| *** yamamoto has quit IRC | 18:12 | |
| *** yamahata has joined #openstack-release | 18:16 | |
| annabelleB | Daily Stage 0 question…I’m reading through https://review.openstack.org/#/c/557383/ and there’s two warnings under the Release Notes in the list changes. I was trying to follow it through and understand what was going on (but without much success) | 18:18 |
| *** e0ne has joined #openstack-release | 18:19 | |
| *** yamamoto has joined #openstack-release | 18:21 | |
| dhellmann | annabelleB : looking... | 18:21 |
| *** lvdombrkr has quit IRC | 18:22 | |
| dhellmann | aha | 18:22 |
| dhellmann | so the release announce script tries to figure out the bug tracker and source code repo URLs by pulling values out of the readme file | 18:22 |
| dhellmann | that's pretty brittle | 18:22 |
| dhellmann | meaning it's easy for projects to break that | 18:22 |
| dhellmann | we usually just ignore those warnings | 18:22 |
| dhellmann | we have that information elsewhere, but it's not easy to pass to the announce script | 18:23 |
| annabelleB | ah okay, I can ignore things :) Any time when it *shouldn’t* be ignored you can think of? | 18:23 |
| dhellmann | as long as the release notes stuff doesn't throw an error and fail entirely you can ignore warnings | 18:23 |
| dhellmann | the point of having it there is to ensure the actual email sending won't fail | 18:23 |
| annabelleB | gotcha | 18:23 |
| dhellmann | any content issues are up to the project teams to fix | 18:24 |
| annabelleB | sounds good. thanks for looking! | 18:24 |
| dhellmann | annabelleB : thanks for asking these questions; it helps to know what sorts of guidelines we need to write down | 18:26 |
| dhellmann | too much of this is only in someone's head still | 18:26 |
| *** yamamoto has quit IRC | 18:26 | |
| annabelleB | dhellmann: we’re putting you in a safety bubble until this is all documented | 18:27 |
| dhellmann | a lot of the policy is in ttx's head | 18:29 |
| dhellmann | besides, my code is 'self documenting' ;-) | 18:30 |
| *** rosmaita has quit IRC | 18:33 | |
| *** gyankum has quit IRC | 18:36 | |
| *** yamamoto has joined #openstack-release | 18:36 | |
| *** gyankum has joined #openstack-release | 18:40 | |
| *** yamamoto has quit IRC | 18:41 | |
| *** corvus is now known as kermitf | 18:42 | |
| *** kermitf is now known as corvus | 18:42 | |
| *** gyankum has quit IRC | 18:48 | |
| *** yamamoto has joined #openstack-release | 18:52 | |
| openstackgerrit | Erno Kuvaja proposed openstack/releases master: Add feature/policy-refactor branch to glane repo https://review.openstack.org/557480 | 18:54 |
| openstackgerrit | Erno Kuvaja proposed openstack/releases master: Add feature/policy-refactor branch to glance repo https://review.openstack.org/557480 | 18:55 |
| *** yamamoto has quit IRC | 18:56 | |
| openstackgerrit | Emilien Macchi proposed openstack/releases master: Release a new Puppet OpenStack Queens https://review.openstack.org/557481 | 18:58 |
| *** yamahata has quit IRC | 19:11 | |
| *** yamahata has joined #openstack-release | 19:12 | |
| smcginnis | Hey dhellmann, were you working on that retired branch issue from this morning? | 19:16 |
| dhellmann | smcginnis : yeah, I posted a fix for that | 19:17 |
| *** yamamoto has joined #openstack-release | 19:17 | |
| *** yamamoto has quit IRC | 19:17 | |
| dhellmann | I think ttx merged it | 19:17 |
| smcginnis | dhellmann: I must have missed the actual fix. | 19:17 |
| dhellmann | wait | 19:17 |
| * smcginnis goes looking | 19:17 | |
| dhellmann | which project was that? django-openstack-auth? | 19:17 |
| dhellmann | you approved that | 19:17 |
| smcginnis | Yep | 19:17 |
| dhellmann | oh, hang on | 19:17 |
| dhellmann | no, the fix was in project-config | 19:18 |
| dhellmann | I'm looking in the wrong place let me find the right one | 19:18 |
| dhellmann | smcginnis : https://review.openstack.org/557332 | 19:18 |
| smcginnis | dhellmann: Excellent, thanks! | 19:19 |
| smcginnis | dhellmann: Has anyone asked fungi nicely to re-enqueue that release? | 19:19 |
| *** sree has joined #openstack-release | 19:19 | |
| dhellmann | I did not, I went offline for a while though so ttx might have | 19:19 |
| dhellmann | we could also do the revert-revert dance | 19:20 |
| fungi | nobody has asked me for anything. sort of paying attention to the storyboard meeting right now but can probably poke at it at the same time | 19:20 |
| fungi | have a link to the failed job? | 19:20 |
| dhellmann | annabelleB : the validation error on https://review.openstack.org/557480 may be of interest | 19:20 |
| dhellmann | fungi : http://logs.openstack.org/1b/1b3550b2f705512063120e79a1bc8f8dbfc2672f/release-post/tag-releases/092f957/job-output.txt.gz#_2018-03-27_20_02_08_766353 | 19:21 |
| dhellmann | fungi : note that the job passed erroneously | 19:21 |
| smcginnis | fungi: It was the release job for https://review.openstack.org/#/c/555194/. We can also revert/re-revert if you would rather we do that. | 19:21 |
| annabelleB | dhellmann: thanks! learning learning! | 19:21 |
| dhellmann | annabelleB : don't cheat by reading my comment | 19:21 |
| dhellmann | and let me know if the error message itself is detailed enough | 19:22 |
| dhellmann | feedback! feedback! | 19:22 |
| smcginnis | fungi: Here's the actual job: http://logs.openstack.org/1b/1b3550b2f705512063120e79a1bc8f8dbfc2672f/release-post/tag-releases/092f957/job-output.txt.gz#_2018-03-27_20_02_07_526077 | 19:22 |
| *** sree has quit IRC | 19:23 | |
| fungi | smcginnis: got it. so openstack/django_openstack_auth never did get a 3.6.0 tag pushed? | 19:25 |
| *** esberglu has quit IRC | 19:25 | |
| smcginnis | fungi: Correct, it silently failed before it got to tagging anything. | 19:26 |
| *** esberglu has joined #openstack-release | 19:26 | |
| fungi | so sounds like i can reenqueue that commit into release-post safely | 19:26 |
| dhellmann | I believe that is correct, yes | 19:27 |
| *** yamamoto has joined #openstack-release | 19:28 | |
| annabelleB | dhellmann: wrt your comment— looks like they swapped project and branch and put the hash as the location? is there a doc of that format to point them to? | 19:28 |
| dhellmann | annabelleB : the readme does contain docs but maybe not a good example | 19:29 |
| dhellmann | oh, there's an example on line 540 | 19:29 |
| dhellmann | the issue isn't that they swapped something; the yaml isn't structured in the expected way for this case | 19:30 |
| dhellmann | the type of "location" varies | 19:30 |
| dhellmann | based on the type of branch and the type of repo | 19:30 |
| *** esberglu has quit IRC | 19:31 | |
| dhellmann | in any case where a hash is used as the location id, we need to map repository to hash so we can support deliverables with more than one repository | 19:31 |
| dhellmann | if the location is a version we assume that all repos have that version tagged | 19:31 |
| dhellmann | (we might even validate that; I'm not sure) | 19:31 |
| *** yamamoto has quit IRC | 19:32 | |
| fungi | smcginnis: dhellmann: i've reenqueued that commit via: sudo zuul enqueue-ref --tenant=openstack --trigger=gerrit --pipeline=release-post --project=openstack/releases --ref=refs/heads/master --newrev=1b3550b2f705512063120e79a1bc8f8dbfc2672f | 19:33 |
| dhellmann | fungi : thanks | 19:33 |
| smcginnis | fungi: Thank you | 19:33 |
| fungi | yw! | 19:33 |
| *** annabelleB has quit IRC | 19:34 | |
| *** bobh has quit IRC | 19:37 | |
| *** esberglu has joined #openstack-release | 19:38 | |
| EmilienM | release-managers: https://review.openstack.org/#/c/557481/ is ready for review, thanks! | 19:39 |
| smcginnis | EmilienM: ack, will try to take a look soon. | 19:41 |
| EmilienM | thanks! | 19:41 |
| *** annabelleB has joined #openstack-release | 19:42 | |
| *** yamamoto has joined #openstack-release | 19:43 | |
| dhellmann | smcginnis , fungi : it looks like the tagging worked this time | 19:46 |
| smcginnis | \o/ | 19:46 |
| fungi | <mr_burns>exxxxxxxcellent</mr_burns> | 19:47 |
| *** yamamoto has quit IRC | 19:47 | |
| smcginnis | Different one? http://logs.openstack.org/1b/1b3550b2f705512063120e79a1bc8f8dbfc2672f/release-post/tag-releases/cc4e6d9/job-output.txt.gz#_2018-03-28_19_40_16_671672 | 19:48 |
| *** yamahata has quit IRC | 19:48 | |
| dhellmann | ugh | 19:49 |
| dhellmann | oh, that's where it's doing the branch work | 19:50 |
| dhellmann | hmm | 19:50 |
| dhellmann | in that case it won't make sense to check out the branch because we know it won't exist | 19:50 |
| dhellmann | I'm inclined to just put a .gitreview file back in that repo | 19:51 |
| smcginnis | dhellmann: Yeah, maybe we should add that to the retirement instructions to keep the .gitignore around. | 19:57 |
| *** yamamoto has joined #openstack-release | 19:57 | |
| *** yamamoto has quit IRC | 19:57 | |
| dhellmann | fungi : thoughts? ^ | 19:57 |
| *** ykarel is now known as ykarel|away | 19:57 | |
| smcginnis | I could see the case where a repo gets retired but later they decide to branch off of an earlier point. | 19:57 |
| *** jokke_ has joined #openstack-release | 19:57 | |
| dhellmann | well, having the metadata for automated tools to manipulate the repo doesn't seem like a bad thing | 19:57 |
| smcginnis | In this case the branch does exist. I thought we checked that first. | 19:57 |
| dhellmann | i think it's the code that's trying to check that that's failing | 19:58 |
| dhellmann | it checks out the repo, then looks at the branches in the repo | 19:58 |
| dhellmann | and here it's failing to checkout the repo | 19:58 |
| dhellmann | because git review -s doesn't work | 19:58 |
| openstackgerrit | Erno Kuvaja proposed openstack/releases master: Add feature/policy-refactor branch to glance repo https://review.openstack.org/557480 | 20:00 |
| smcginnis | I wonder if git review can be taught to assume reasonable defaults. Though reasonable for us wouldn't be reasonable for anyone else I suppose. | 20:00 |
| dhellmann | clone_repo.sh could be taught that | 20:00 |
| * smcginnis gets pulled into meeting vortex | 20:00 | |
| jokke_ | dhellmann: I hope I got it right this time ... thanks for the helpful comment there | 20:00 |
| *** kumarmn has quit IRC | 20:00 | |
| *** bobh has joined #openstack-release | 20:01 | |
| dhellmann | jokke_ : we'll help you get it fixed up if it's not | 20:01 |
| *** kumarmn has joined #openstack-release | 20:02 | |
| *** samP_ has quit IRC | 20:03 | |
| *** ykarel|away has quit IRC | 20:06 | |
| *** samP has joined #openstack-release | 20:07 | |
| *** kumarmn has quit IRC | 20:10 | |
| *** kumarmn has joined #openstack-release | 20:11 | |
| *** kumarmn has quit IRC | 20:15 | |
| dhellmann | smcginnis , fungi : https://review.openstack.org/557502 | 20:17 |
| *** kumarmn has joined #openstack-release | 20:18 | |
| fungi | dhellmann: i wonder if we don't instead want some means to determining that the branch is retired so scripts can just skip it? | 20:23 |
| dhellmann | fungi : well, just because master is retired doesn't mean we don't need to do things with that repo, right? | 20:25 |
| fungi | this is presumably a case where master has been retired but stable/something has not yet because we're waiting for it to age out, right? so we're unlikely to tag any new releases from that particular branch | 20:25 |
| fungi | from master in that case | 20:25 |
| dhellmann | the clone script is very dumb right now | 20:25 |
| dhellmann | it gets a branch and a repo as args | 20:25 |
| dhellmann | we fixed the tagging case by having it try to check out the branch | 20:25 |
| dhellmann | the case that is failing now is the one that would create the branch if that was the request | 20:26 |
| fungi | oh, i guess it's treating the master branch as a source of content | 20:26 |
| dhellmann | right | 20:26 |
| dhellmann | it just clones the repo, does git review -s, then may checkout different branches or do other things | 20:26 |
| dhellmann | in the case of the branch creation step, if we say "check out stable/foo" and the operation is "create stable/foo" it seems odd | 20:26 |
| fungi | what is it using the master branch .gitreview content for in that context? | 20:27 |
| dhellmann | the branch step needs a copy of the repo (there may not be any tags, so it doesn't assume a copy exists) | 20:27 |
| dhellmann | so it clones the repo, then prepares it with a gerrit remote with "git review -s" | 20:27 |
| dhellmann | that will let it push the branch up to the remote | 20:28 |
| dhellmann | what is the benefit of removing the .gitreview file? why not keep it? | 20:28 |
| fungi | ahh, i see, so it wants to know the gerrit remote for the repo, which will be consistent across branches anyway so it's defaulting to assuming there will be a .gitreview file on master | 20:29 |
| dhellmann | well, it doesn't do that, the git-review command does | 20:29 |
| dhellmann | I decided not to reimplement "git review -s" in our re-implementation of zuul-cloner :-) | 20:29 |
| fungi | sure, it's defaulting to running git review -s on master | 20:29 |
| dhellmann | right | 20:29 |
| dhellmann | because that's the one branch we always expect to have | 20:29 |
| fungi | yeah, i suppose leaving a .gitreview file behind is probably fine, just need to be aware that it can't be edited without taking the branch/project back out of a read-only state | 20:30 |
| fungi | so may involve an acl change dance to modify later | 20:31 |
| dhellmann | can anything else be edited without doing that? | 20:31 |
| dhellmann | is that file special? | 20:31 |
| dhellmann | I suppose the alternative is to not retire the repo until we're done with all of its stable branches, but under the new EM policy that may be never | 20:32 |
| dhellmann | or a very long time, at least | 20:32 |
| fungi | dhellmann: well, it'll be "special" in that it'll be one of only two files left in the branch | 20:32 |
| dhellmann | yeah | 20:32 |
| fungi | and yes, the em plan does make ever retiring a project tricky | 20:33 |
| dhellmann | I don't think we have any other project metadata files for which we aren't already coping with missing files | 20:33 |
| dhellmann | this one is tricky because fixing it would require putting lots of release smarts in a script that's supposed to be a thin wrapper around git clone | 20:33 |
| corvus | i'm not opposed to the infra-manual change; but an alternative might be to still convince git-review to do the setup -- whether that means writing (and then removing) a .gitreview file, or passing in the config some other way. | 20:40 |
| corvus | that's obviously an openstack-specific solution to embed in clone_repo.sh | 20:41 |
| corvus | but if you accept that, we pretty much know everything to put in the git-review config (gerrit hostname + project) | 20:41 |
| corvus | iow, it's still encoding our situation into clone_repo.sh, but it's at least not re-implementing git-review | 20:42 |
| corvus | i've +2d the infra-manual change; happy to +W if folks think we've got consensus on that | 20:43 |
| dhellmann | ok, I guess we could check for .gitreview and create a default one if it doesn't exist | 20:43 |
| *** kumarmn has quit IRC | 20:44 | |
| dhellmann | I'm a bit worried about whether there are other places we make this same assumption | 20:44 |
| dhellmann | I think we have a clone_repo.sh script in the releases repo, too, so that's at least 2 places to fix it | 20:44 |
| dhellmann | although that one may not do git review -s | 20:44 |
| *** kumarmn has joined #openstack-release | 20:44 | |
| dhellmann | since it didn't fail on d-o-a | 20:44 |
| corvus | i'm really ambivalent. was totally brainstorming. happy with either. :) | 20:48 |
| *** e0ne has quit IRC | 20:48 | |
| dhellmann | I tend to prefer instructions that make 1-time operations a little more complicated in exchange for allowing automation to make assumptions; but I admit to a certain amount of bias there | 20:48 |
| *** kumarmn has quit IRC | 20:49 | |
| *** kumarmn has joined #openstack-release | 20:51 | |
| *** iyamahat has joined #openstack-release | 20:52 | |
| *** yamamoto has joined #openstack-release | 20:57 | |
| *** yamahata has joined #openstack-release | 20:58 | |
| *** beisner is now known as beisner-afk | 20:59 | |
| *** yamahata has quit IRC | 21:03 | |
| *** yamamoto has quit IRC | 21:03 | |
| *** iyamahat has quit IRC | 21:22 | |
| *** yamahata has joined #openstack-release | 21:24 | |
| *** e0ne has joined #openstack-release | 21:29 | |
| *** edmondsw has quit IRC | 21:43 | |
| openstackgerrit | Merged openstack/releases master: Add feature/policy-refactor branch to glance repo https://review.openstack.org/557480 | 21:44 |
| *** sree has joined #openstack-release | 21:45 | |
| *** tellesnobrega has quit IRC | 21:47 | |
| *** tellesnobrega has joined #openstack-release | 21:48 | |
| *** sree has quit IRC | 21:51 | |
| -openstackstatus- NOTICE: the zuul web dashboard will experience a short downtime as we roll out some changes - no job execution should be affected | 21:52 | |
| *** harlowja has joined #openstack-release | 21:53 | |
| *** e0ne has quit IRC | 21:55 | |
| *** tellesnobrega has quit IRC | 21:55 | |
| *** yamamoto has joined #openstack-release | 21:59 | |
| *** yamamoto has quit IRC | 22:04 | |
| *** yamahata has quit IRC | 22:04 | |
| *** bobh has quit IRC | 22:17 | |
| *** mlavalle has quit IRC | 22:19 | |
| *** esberglu has quit IRC | 22:32 | |
| *** mriedem has quit IRC | 22:34 | |
| *** mriedem has joined #openstack-release | 22:36 | |
| *** iyamahat has joined #openstack-release | 22:38 | |
| *** iyamahat has quit IRC | 22:40 | |
| *** iyamahat has joined #openstack-release | 22:41 | |
| *** mriedem has quit IRC | 22:47 | |
| *** hongbin has quit IRC | 22:54 | |
| *** yamamoto has joined #openstack-release | 23:00 | |
| *** kumarmn has quit IRC | 23:01 | |
| *** yamamoto has quit IRC | 23:06 | |
| *** beisner-afk is now known as beisner | 23:14 | |
| *** bobh has joined #openstack-release | 23:16 | |
| *** kumarmn has joined #openstack-release | 23:19 | |
| *** iyamahat has quit IRC | 23:20 | |
| *** kumarmn has quit IRC | 23:23 | |
| *** tellesnobrega has joined #openstack-release | 23:45 | |
| *** claudiub has quit IRC | 23:52 | |
| *** iyamahat has joined #openstack-release | 23:55 | |
| -openstackstatus- NOTICE: Zuul has been restarted to update to the latest code; existing changes have been re-enqueued, you may need to recheck changes uploaded in the past 10 minutes | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!