*** ricolin has joined #openstack-release | 00:08 | |
*** mlavalle has quit IRC | 00:29 | |
*** kzaitsev1pi has quit IRC | 00:30 | |
*** kzaitsev_pi has joined #openstack-release | 00:37 | |
*** kzaitsev_pi has quit IRC | 00:42 | |
*** kzaitsev_pi has joined #openstack-release | 00:42 | |
*** edmondsw has joined #openstack-release | 01:02 | |
*** edmondsw has quit IRC | 01:07 | |
*** gyankum has joined #openstack-release | 01:17 | |
*** lifeless has quit IRC | 01:22 | |
*** lifeless has joined #openstack-release | 01:27 | |
*** lifeless has quit IRC | 01:46 | |
*** lifeless has joined #openstack-release | 01:53 | |
*** hongbin has joined #openstack-release | 02:02 | |
*** yamamoto has quit IRC | 02:04 | |
*** yamamoto has joined #openstack-release | 02:04 | |
*** e0ne has joined #openstack-release | 02:10 | |
*** e0ne_ has joined #openstack-release | 02:12 | |
*** e0ne has quit IRC | 02:15 | |
*** smcginnis[m] has quit IRC | 02:37 | |
*** jhesketh has quit IRC | 02:37 | |
*** smcginnis[m] has joined #openstack-release | 02:37 | |
*** jhesketh has joined #openstack-release | 02:37 | |
*** onovy has quit IRC | 02:40 | |
*** smcginnis[m] has quit IRC | 02:41 | |
*** lennyb has quit IRC | 02:41 | |
*** lennyb has joined #openstack-release | 02:42 | |
*** onovy has joined #openstack-release | 02:42 | |
*** notmyname has quit IRC | 02:44 | |
*** mtreinish has quit IRC | 02:44 | |
*** samP has quit IRC | 02:44 | |
*** oanson has quit IRC | 02:44 | |
*** zhongjun_ has quit IRC | 02:44 | |
*** adreznec has quit IRC | 02:44 | |
*** lxkong has quit IRC | 02:44 | |
*** spsurya has quit IRC | 02:44 | |
*** portdirect has quit IRC | 02:44 | |
*** lxkong has joined #openstack-release | 02:45 | |
*** spsurya has joined #openstack-release | 02:45 | |
*** portdirect has joined #openstack-release | 02:45 | |
*** mtreinish has joined #openstack-release | 02:45 | |
*** samP has joined #openstack-release | 02:45 | |
*** oanson has joined #openstack-release | 02:45 | |
*** zhongjun_ has joined #openstack-release | 02:45 | |
*** adreznec has joined #openstack-release | 02:45 | |
*** notmyname has joined #openstack-release | 02:46 | |
*** gyankum has quit IRC | 02:46 | |
*** evrardjp has quit IRC | 02:46 | |
*** tonyb has quit IRC | 02:46 | |
*** andreykurilin has quit IRC | 02:46 | |
*** yamamoto has quit IRC | 02:46 | |
*** gyankum has joined #openstack-release | 02:47 | |
*** evrardjp has joined #openstack-release | 02:47 | |
*** tonyb has joined #openstack-release | 02:47 | |
*** andreykurilin has joined #openstack-release | 02:47 | |
*** yamamoto has joined #openstack-release | 02:48 | |
*** freerunner has quit IRC | 02:50 | |
*** dtroyer has quit IRC | 02:50 | |
*** fanzhang has quit IRC | 02:50 | |
*** olivierbourdon38 has quit IRC | 02:50 | |
*** tobberydberg has quit IRC | 02:50 | |
*** tinwood has quit IRC | 02:50 | |
*** jroll has quit IRC | 02:50 | |
*** jrist has quit IRC | 02:50 | |
*** otherwiseguy has quit IRC | 02:50 | |
*** hongbin has quit IRC | 02:50 | |
*** lifeless has quit IRC | 02:50 | |
*** SergeyLukjanov has quit IRC | 02:50 | |
*** weshay_pto has quit IRC | 02:50 | |
*** ianychoi_ has quit IRC | 02:50 | |
*** electrofelix has quit IRC | 02:50 | |
*** strigazi has quit IRC | 02:50 | |
*** corvus has quit IRC | 02:50 | |
*** ltomasbo has quit IRC | 02:50 | |
*** freerunner has joined #openstack-release | 02:50 | |
*** dtroyer has joined #openstack-release | 02:50 | |
*** fanzhang has joined #openstack-release | 02:50 | |
*** olivierbourdon38 has joined #openstack-release | 02:50 | |
*** tobberydberg has joined #openstack-release | 02:50 | |
*** tinwood has joined #openstack-release | 02:50 | |
*** jroll has joined #openstack-release | 02:50 | |
*** jrist has joined #openstack-release | 02:50 | |
*** otherwiseguy has joined #openstack-release | 02:50 | |
*** edmondsw has joined #openstack-release | 02:51 | |
*** hongbin has joined #openstack-release | 02:51 | |
*** lifeless has joined #openstack-release | 02:51 | |
*** SergeyLukjanov has joined #openstack-release | 02:51 | |
*** weshay_pto has joined #openstack-release | 02:51 | |
*** ianychoi_ has joined #openstack-release | 02:51 | |
*** electrofelix has joined #openstack-release | 02:51 | |
*** strigazi has joined #openstack-release | 02:51 | |
*** corvus has joined #openstack-release | 02:51 | |
*** ltomasbo has joined #openstack-release | 02:51 | |
*** edmondsw has quit IRC | 02:55 | |
*** smcginnis[m] has joined #openstack-release | 03:13 | |
*** sree_ has joined #openstack-release | 03:45 | |
*** sree_ is now known as Guest35639 | 03:46 | |
*** ykarel|away has joined #openstack-release | 03:46 | |
*** hongbin has quit IRC | 03:50 | |
*** kzaitsev_pi has quit IRC | 03:52 | |
*** kzaitsev_pi has joined #openstack-release | 03:53 | |
*** kzaitsev_pi has quit IRC | 03:58 | |
*** kzaitsev1pi has joined #openstack-release | 03:58 | |
*** ykarel|away is now known as ykarel | 04:18 | |
*** udesale has joined #openstack-release | 04:26 | |
*** ykarel has quit IRC | 04:31 | |
*** e0ne_ has quit IRC | 04:38 | |
*** ykarel has joined #openstack-release | 04:46 | |
*** ifat_afek has joined #openstack-release | 05:01 | |
*** ifat_afek has left #openstack-release | 05:02 | |
*** CrayZee has joined #openstack-release | 05:31 | |
*** gongysh has joined #openstack-release | 06:08 | |
*** radeks has joined #openstack-release | 06:22 | |
*** pcaruana has joined #openstack-release | 06:37 | |
*** radek__ has joined #openstack-release | 06:39 | |
*** lifeless has quit IRC | 06:50 | |
*** lifeless has joined #openstack-release | 06:56 | |
*** sree has joined #openstack-release | 07:02 | |
*** Guest35639 has quit IRC | 07:04 | |
*** dmellado has joined #openstack-release | 07:12 | |
*** amoralej|off is now known as amoralej | 07:20 | |
*** jtomasek has joined #openstack-release | 07:39 | |
*** ykarel is now known as ykarel|lunch | 07:40 | |
*** lifeless has quit IRC | 07:54 | |
*** alexchadin has joined #openstack-release | 08:00 | |
*** dtantsur|afk is now known as dtantsur | 08:04 | |
*** ykarel|lunch is now known as ykarel | 08:35 | |
*** alexchadin has quit IRC | 08:39 | |
*** ianychoi_ is now known as ianychoi | 08:40 | |
*** alexchadin has joined #openstack-release | 08:42 | |
*** d0ugal has joined #openstack-release | 08:43 | |
*** ricolin has quit IRC | 09:04 | |
*** sree has quit IRC | 09:20 | |
*** pcaruana has quit IRC | 09:23 | |
*** lifeless has joined #openstack-release | 09:24 | |
*** pcaruana has joined #openstack-release | 09:27 | |
*** alexchadin has quit IRC | 09:42 | |
*** alexchadin has joined #openstack-release | 09:42 | |
*** pcaruana has quit IRC | 09:54 | |
*** yamamoto has quit IRC | 10:10 | |
*** pcaruana has joined #openstack-release | 10:10 | |
*** gyankum has quit IRC | 10:11 | |
*** gongysh has quit IRC | 10:16 | |
*** gongysh has joined #openstack-release | 10:21 | |
*** gongysh has quit IRC | 10:21 | |
*** alexchadin has quit IRC | 10:23 | |
*** pkovar has joined #openstack-release | 10:38 | |
*** yamamoto has joined #openstack-release | 11:11 | |
*** lucasagomes is now known as lucas-hungry | 11:11 | |
*** lucas-hungry is now known as lucasagomes | 11:11 | |
*** pkovar has quit IRC | 11:16 | |
*** yamamoto has quit IRC | 11:16 | |
*** gyankum has joined #openstack-release | 11:24 | |
*** openstackgerrit has joined #openstack-release | 11:29 | |
openstackgerrit | Merged openstack/releases master: Add aclfixer tool to generate ACL fixes patches https://review.openstack.org/559983 | 11:29 |
---|---|---|
openstackgerrit | Merged openstack/releases master: Add dib-utils to aclfixer.py exception list https://review.openstack.org/560326 | 11:29 |
*** sree_ has joined #openstack-release | 11:31 | |
*** sree_ is now known as Guest77906 | 11:32 | |
*** udesale_ has joined #openstack-release | 11:33 | |
*** udesale has quit IRC | 11:34 | |
*** yamamoto has joined #openstack-release | 11:36 | |
*** udesale_ has quit IRC | 11:37 | |
*** pcaruana has quit IRC | 11:42 | |
*** yamamoto has quit IRC | 11:47 | |
*** yamamoto has joined #openstack-release | 11:48 | |
*** pkovar has joined #openstack-release | 11:51 | |
*** amoralej is now known as amoralej|lunch | 11:55 | |
*** pcaruana has joined #openstack-release | 12:02 | |
*** rosmaita has joined #openstack-release | 12:03 | |
*** e0ne has joined #openstack-release | 12:06 | |
*** edmondsw_ has joined #openstack-release | 12:11 | |
*** udesale has joined #openstack-release | 12:11 | |
*** kumarmn has joined #openstack-release | 12:17 | |
*** udesale has quit IRC | 12:17 | |
*** udesale has joined #openstack-release | 12:34 | |
*** kumarmn has quit IRC | 12:48 | |
*** kumarmn has joined #openstack-release | 12:49 | |
*** kumarmn has quit IRC | 12:53 | |
*** kzaitsev1pi has quit IRC | 13:02 | |
*** kzaitsev_pi has joined #openstack-release | 13:02 | |
*** kumarmn has joined #openstack-release | 13:06 | |
*** esberglu has joined #openstack-release | 13:06 | |
*** ykarel is now known as ykarel|away | 13:06 | |
openstackgerrit | Merged openstack/releases master: Release Mistral Queens 6.0.3 https://review.openstack.org/568882 | 13:08 |
*** ykarel|away has quit IRC | 13:10 | |
*** kzaitsev_pi has quit IRC | 13:13 | |
*** kzaitsev_pi has joined #openstack-release | 13:13 | |
*** amoralej|lunch is now known as amoralej | 13:18 | |
*** esberglu has quit IRC | 13:20 | |
*** dave-mccowan has joined #openstack-release | 13:21 | |
*** mriedem has joined #openstack-release | 13:23 | |
*** dave-mcc_ has joined #openstack-release | 13:24 | |
*** dave-mccowan has quit IRC | 13:26 | |
*** esberglu has joined #openstack-release | 13:30 | |
*** dtantsur is now known as dtantsur|brb | 13:31 | |
*** lbragstad has joined #openstack-release | 13:32 | |
*** edmondsw_ is now known as edmondsw | 13:42 | |
openstackgerrit | Merged openstack/releases master: Release pymod2pkg 0.13.3 https://review.openstack.org/569953 | 13:51 |
*** ykarel|away has joined #openstack-release | 13:51 | |
*** dave-mcc_ has quit IRC | 13:54 | |
*** dave-mccowan has joined #openstack-release | 13:55 | |
*** ykarel|away is now known as ykarel | 13:55 | |
*** jroll has quit IRC | 14:01 | |
*** jroll has joined #openstack-release | 14:02 | |
*** armax has joined #openstack-release | 14:04 | |
*** mriedem is now known as mriedem_away | 14:13 | |
openstackgerrit | Merged openstack/releases master: TripleO pike release https://review.openstack.org/570113 | 14:17 |
*** dave-mcc_ has joined #openstack-release | 14:18 | |
*** mlavalle has joined #openstack-release | 14:18 | |
*** bnemec has joined #openstack-release | 14:20 | |
*** dave-mccowan has quit IRC | 14:21 | |
*** Guest77906 has quit IRC | 14:22 | |
*** lifeless_ has joined #openstack-release | 14:31 | |
*** lifeless has quit IRC | 14:32 | |
*** hongbin has joined #openstack-release | 14:42 | |
*** ykarel is now known as ykarel|away | 14:54 | |
rosmaita | smcginnis: let me know when you have a few minutes, think i found a problem with glance_store releases | 14:58 |
smcginnis | rosmaita: Uh oh, what's up? | 15:00 |
*** dtantsur|brb is now known as dtantsur | 15:00 | |
*** CrayZee has quit IRC | 15:02 | |
rosmaita | ok, the glance_store deliverable is named 'glance-store' because the file in deliverables/ is named 'glance-store.yaml' ... but the name in the metadata section of setup.cfg is 'glance_store' | 15:02 |
rosmaita | it's in pypi as 'glance_store' | 15:02 |
rosmaita | but there seems to be a redirect from 'glance-store' to 'glance_store' (i think) | 15:03 |
rosmaita | in u-c, it's glance-store | 15:03 |
rosmaita | and in pip freeze it shows up as glance-store | 15:03 |
rosmaita | so why is this a problem you ask? | 15:03 |
rosmaita | i'm setting up a periodic "tips" job to run the glance tests against glance_store master | 15:04 |
rosmaita | monty's code for the ansible task that processes the siblings gets the name of the package from the metadata in setup.cfg | 15:04 |
rosmaita | which seems like the correct thing to do | 15:04 |
smcginnis | The name is actually based on https://github.com/openstack/glance_store/blob/master/setup.cfg#L2 | 15:04 |
rosmaita | but as a result, it doesn't detect that glance_store matches the glance-store package | 15:05 |
rosmaita | smcginnis: from https://github.com/openstack/releases/blob/master/openstack_releases/deliverable.py it looks like it parses the path of the deliverable file to get the name | 15:05 |
rosmaita | https://github.com/openstack/releases/blob/master/openstack_releases/deliverable.py#L143 | 15:06 |
smcginnis | rosmaita: I think it would be difficult to change the name now. | 15:06 |
smcginnis | rosmaita: Yeah, we try to determine the name if it is not set explicitly in the deliverable file. | 15:06 |
smcginnis | rosmaita: To handle pypi naming constraints. | 15:06 |
smcginnis | Ideally it's just set in the deliverable with pypi-name | 15:07 |
rosmaita | so how much stuff will break if i change the metadata/name to 'glance-store', i wonder | 15:10 |
smcginnis | rosmaita: Unfortunately a lot I think based on when I've seen others try to change the name. :/ | 15:10 |
*** dave-mcc_ is now known as dave-mccowan | 15:13 | |
rosmaita | smcginnis is there any way to test this? the package is being installed correctly as glance_store, so that wouldn't change | 15:21 |
smcginnis | rosmaita: If you change the name then it wouldn't be glance_store anymore. | 15:22 |
smcginnis | rosmaita: Maybe I'm confused what part you're looking at. | 15:22 |
rosmaita | smcginnis: http://paste.openstack.org/show/722267/ | 15:24 |
*** lifeless_ has quit IRC | 15:24 | |
rosmaita | i can't figure out where the name is coming from, given https://github.com/openstack/glance_store/blob/master/setup.cfg#L2 | 15:24 |
smcginnis | rosmaita: Yeah, pip is smart about handling _ vs -. | 15:25 |
smcginnis | rosmaita: Whatever job that is needs to be better about handling it too. | 15:26 |
rosmaita | i guess my thought is that since pip already thinks the name is glance-store, maybe that's what should show up in the metadata in setup.cfg | 15:27 |
clarkb | the canonical name on pypi would be glance_store right? | 15:29 |
clarkb | fungi ^ had the rules paged in at one point and probably knows | 15:30 |
fungi | there's a function in pkg_resources to canonicalize package names | 15:31 |
openstackgerrit | Alex Schultz proposed openstack/releases master: TripleO queens release https://review.openstack.org/570114 | 15:31 |
fungi | https://pypi.org/project/glance-store/ redirects to https://pypi.org/project/glance_store/ | 15:32 |
smcginnis | mwhahaha: We have a problem with at least tripleo-validations right now. | 15:32 |
fungi | package files for it on pypi also seem to use _ | 15:32 |
rosmaita | fungi: yes, we want to keep the _ in the package name | 15:33 |
mwhahaha | smcginnis: ? | 15:33 |
smcginnis | mwhahaha: pypi appears to have started validation of the RST for package discriptions. | 15:33 |
*** e0ne has quit IRC | 15:33 | |
fungi | same with http://tarballs.openstack.org/glance_store/ too | 15:33 |
smcginnis | mwhahaha: And that one has some includes that don't exist, so it failues on upload. | 15:33 |
mwhahaha | smcginnis: lovely | 15:33 |
smcginnis | mwhahaha: Started to look at fixing it, but not sure where those includes actually are. | 15:33 |
rosmaita | fungi: it shows up in upper-constraints and requirements as 'glance-store' currently | 15:33 |
rosmaita | but the installed package is glance_store | 15:34 |
mwhahaha | smcginnis: probably bad files, let me take a look | 15:34 |
mwhahaha | smcginnis: can you file a basic bug for me? | 15:34 |
rosmaita | fungi: sort of like oslo.rootwrap being installed as oslo_rootwrap | 15:34 |
smcginnis | mwhahaha: Thanks, will do. | 15:34 |
rosmaita | fungi: what i mean is that it's olso.rootwrap in u-c, but the actual package installed is oslo_rootwrap | 15:35 |
fungi | rosmaita: yeah, we should probably try to make it consistent with the sdist/wheel and pypi | 15:35 |
fungi | seems like the requirements repo references could probably be safely corrected? we're not doing requirements synchronization to individual projects now though, not sure if they all need to be updated as well | 15:37 |
rosmaita | fungi in this case we are lucky, i think only glare and glance consume glance_store | 15:37 |
smcginnis | mwhahaha: https://bugs.launchpad.net/tripleo/+bug/1774001 | 15:38 |
openstack | Launchpad bug 1774001 in tripleo "tripleo-validations README has broken includes" [Undecided,New] | 15:38 |
smcginnis | mwhahaha: I won't be able to process any of the tripleo releases that include this repo until this one's resolved. | 15:38 |
mwhahaha | k i'll get it sorted this week | 15:38 |
rosmaita | fungi: on the other hand, i am thinking that if we change the metadata/name in glance_store/setup.cfg to have name = glance-store , everything should be fine & backward compatible? | 15:39 |
rosmaita | although maybe not on pypi since the redirect is from hyphen to underscore ? | 15:40 |
fungi | right | 15:40 |
fungi | and it has to be an underscore in wheel files too since they reserve hyphens for a version separator | 15:40 |
openstackgerrit | Frank Kloeker proposed openstack/releases master: Release openstackdocstheme 1.21 https://review.openstack.org/570951 | 15:41 |
fungi | sdist also uses hyphen as a version separator but made the mistake early on of not reserving it for that purpose so sdist filenames can include hyphens in the name too | 15:41 |
rosmaita | fungi : would the wheel and package names come from https://github.com/openstack/glance_store/blob/master/setup.cfg#L22-L24 ? | 15:41 |
fungi | the sdist name would, but the wheel filename will still end up translating - to _ | 15:42 |
rosmaita | that would be ok, i think that's what is happening now | 15:42 |
fungi | because of the aforementioned filename specification they enforced | 15:42 |
fungi | you can try locally making that edit and running `tox -e venv python setup.py bdist_wheel sdist` | 15:43 |
fungi | and look in the dist directory to see what that created | 15:44 |
rosmaita | doing that now | 15:44 |
*** claudiub has joined #openstack-release | 15:48 | |
rosmaita | fungi: you are correct, changing the metadata/name changes the wheel name to now have a hyphen instead of an underscore | 15:48 |
rosmaita | ok, so changing metadata/name is ruled out | 15:49 |
*** jtomasek has quit IRC | 15:52 | |
*** udesale_ has joined #openstack-release | 15:54 | |
*** jtomasek has joined #openstack-release | 15:54 | |
*** udesale has quit IRC | 15:57 | |
*** udesale__ has joined #openstack-release | 16:07 | |
rosmaita | fungi: i may have spoken too soon ... when i set [metadata]name=glance-store, what shows up in dist/ is: | 16:10 |
rosmaita | glance_store-0.23.1.dev25-py2.py3-none-any.whl glance-store-0.23.1.dev25.tar.gz | 16:10 |
*** udesale_ has quit IRC | 16:10 | |
*** mriedem_away is now known as mriedem | 16:11 | |
fungi | rosmaita: right, that's what i was saying. the sdist name changes because sdist (as an older packaging "standard" for python) lacked a provision to exclude its version separator (hyphen) from package names. the wheel specification does actively translate - to _ in package names to avoid ambiguity around its version separator | 16:12 |
rosmaita | fungi: so does that mean that "inside" the wheel, the stuff is stored in glance-store (not glance_store) ? | 16:12 |
rosmaita | which would be bad | 16:13 |
fungi | you can `unzip -l dist/glance_store-0.23.1.dev25-py2.py3-none-any.whl` and find out | 16:14 |
fungi | but i believe so, yes | 16:14 |
*** udesale__ has quit IRC | 16:14 | |
*** mriedem has quit IRC | 16:15 | |
rosmaita | [wheel-test] wha'ppen? unzip -l glance_store-0.23.1.dev25-py2.py3-none-any.whl | 16:15 |
rosmaita | Archive: glance_store-0.23.1.dev25-py2.py3-none-any.whl | 16:15 |
rosmaita | Length Date Time Name | 16:15 |
rosmaita | --------- ---------- ----- ---- | 16:15 |
rosmaita | 724 2018-05-02 15:48 glance_store/__init__.py | 16:15 |
rosmaita | etc | 16:15 |
rosmaita | fungi ^^ | 16:15 |
rosmaita | looks like it uses the underscore (what we want) | 16:16 |
*** claudiub has quit IRC | 16:19 | |
*** mriedem has joined #openstack-release | 16:20 | |
fungi | how does that compare to `tar tzf dist/glance-store-0.23.1.dev25.tar.gz` i wonder? | 16:22 |
rosmaita | [wheel-test] wha'ppen? tar -tvzf dist/glance-store-0.23.1.dev25.tar.gz | 16:23 |
rosmaita | drwxr-xr-x rosmabr/vzw 0 2018-05-29 11:48 glance-store-0.23.1.dev25/ | 16:23 |
rosmaita | -rw-r--r-- rosmabr/vzw 10143 2018-05-02 11:48 glance-store-0.23.1.dev25/LICENSE | 16:23 |
rosmaita | etc | 16:23 |
rosmaita | fungi ^^ | 16:23 |
rosmaita | that one has the hyphen, which we don't want | 16:23 |
fungi | yeah, though when pip installs the sdist it first builds a wheel from it | 16:25 |
fungi | so the end result on the filesystem will look like what's packaged in glance_store-0.23.1.dev25-py2.py3-none-any.whl | 16:26 |
*** claudiub has joined #openstack-release | 16:32 | |
*** claudiub has quit IRC | 16:37 | |
*** pcaruana has quit IRC | 16:39 | |
*** e0ne has joined #openstack-release | 16:42 | |
*** yamahata has joined #openstack-release | 17:14 | |
openstackgerrit | Jay Bryant proposed openstack/releases master: Release Cinder stable/queens 12.1.0 https://review.openstack.org/570982 | 17:28 |
*** pcaruana has joined #openstack-release | 17:43 | |
*** armax_ has joined #openstack-release | 17:46 | |
*** armax has quit IRC | 17:47 | |
*** armax_ is now known as armax | 17:47 | |
*** iyamahat has joined #openstack-release | 18:01 | |
*** gyankum has quit IRC | 18:02 | |
*** iyamahat has quit IRC | 18:05 | |
*** pkovar has quit IRC | 18:11 | |
*** iyamahat has joined #openstack-release | 18:12 | |
openstackgerrit | Eric Harney proposed openstack/releases master: Release os-brick queens 2.3.2 https://review.openstack.org/570994 | 18:21 |
*** dtantsur is now known as dtantsur|afk | 18:28 | |
*** amoralej is now known as amoralej|off | 18:38 | |
*** pcaruana has quit IRC | 18:39 | |
*** lbragstad has quit IRC | 18:39 | |
openstackgerrit | Doug Hellmann proposed openstack/releases master: add a validation step to check README.rst parsing for PyPI https://review.openstack.org/570999 | 18:42 |
*** radeks_ has joined #openstack-release | 18:44 | |
*** e0ne has quit IRC | 18:49 | |
smcginnis | dhellmann: Bah! Just finished up testing my own of that ^ | 18:50 |
*** SergeyLukjanov2 has joined #openstack-release | 18:51 | |
dhellmann | gah, if I'd known you were working on it I wouldn't have bothered | 18:52 |
dhellmann | were you able to get it to produce any useful messages? that "StringIO doesn't have an attribute startswith" error does indicate a parser problem but also a bug in the parser itself | 18:52 |
*** radeks has quit IRC | 18:52 | |
*** SergeyLukjanov has quit IRC | 18:52 | |
*** weshay_pto has quit IRC | 18:53 | |
*** SergeyLukjanov2 is now known as SergeyLukjanov | 18:53 | |
smcginnis | dhellmann: No, that's the best I think setup.py check provides. | 18:54 |
*** weshay has joined #openstack-release | 18:54 | |
smcginnis | dhellmann: I think if we really want useful output, we need to actually call doc8 on the file. | 18:54 |
dhellmann | I guess that error is bubbling up from docutils itself | 18:54 |
dhellmann | hmm, maybe we should? | 18:54 |
dhellmann | or maybe only if there's an error? | 18:55 |
smcginnis | We could. Or it might just be easier to say in the error message that doc8 can be used to get a detailed error report? | 18:55 |
dhellmann | will doc8 actually report errors like using sphinx-isms within the readme? | 18:56 |
smcginnis | dhellmann: I don't think the README files should have much sphinx-isms, since there is no conf.py to set up those types of things. | 18:57 |
smcginnis | dhellmann: They should be limited to pretty basic RST I think. | 18:57 |
dhellmann | right, that's why some of them fail | 18:57 |
dhellmann | but does doc8 report an error if they do use sphinx-isms? | 18:57 |
smcginnis | I only saw the tripleo failures, and the ones i checked were due to trying to include invalid files. | 18:57 |
dhellmann | ah | 18:57 |
smcginnis | But I think doc8 does handle a lot. | 18:58 |
smcginnis | Certainly more than pypi's description rendering is going to want to use. | 18:58 |
dhellmann | my concern is it would consider a file valid even if it uses a directive that isn't supported by pypi | 18:58 |
dhellmann | so that it wouldn't help diagnose an error | 18:58 |
smcginnis | My guess is we should be safe, but I don't have any emperical evidence to back that. | 18:58 |
dhellmann | maybe that's a follow-up then | 18:59 |
*** lbragstad has joined #openstack-release | 19:00 | |
smcginnis | ++ | 19:00 |
*** Guest32198 is now known as melwitt | 19:06 | |
*** radeks__ has joined #openstack-release | 19:07 | |
*** radek__ has quit IRC | 19:10 | |
*** radeks_ has quit IRC | 19:10 | |
*** dave-mccowan has quit IRC | 19:12 | |
*** lifeless has joined #openstack-release | 19:34 | |
*** harlowja has joined #openstack-release | 20:00 | |
*** ykarel|away has quit IRC | 20:14 | |
melwitt | smcginnis: we recently landed a change to osc on stable/queens that will enable novaclient 10.1.0 to work for queens. is there a way we can revive this patch https://review.openstack.org/538070 ? is there another review that is the "group update for delayed lib releases" you mentioned in your last comment? | 20:47 |
melwitt | having 10.1.0 be the default for queens will enable users to do volume multi-attach out of the box when they install queens | 20:47 |
melwitt | https://review.openstack.org/562840 is the recent change we landed on stable/queens for osc | 20:49 |
openstackgerrit | Frank Kloeker proposed openstack/releases master: Release openstackdocstheme 1.21 https://review.openstack.org/570951 | 20:58 |
*** radeks__ has quit IRC | 21:09 | |
*** edmondsw has quit IRC | 21:13 | |
dhellmann | melwitt : does osc need a new release on queens to make that work? a release would automatically trigger a new constraint update on the relevant branch in the requirements repo | 21:16 |
melwitt | dhellmann: oh, probably yeah | 21:16 |
dhellmann | as far as the "default", at this point we can't guarantee that. We don't update the minimum version of a dependency, only the constraint. usually that's "good enough" | 21:17 |
melwitt | right, okay | 21:17 |
dhellmann | of course the constraint update will only be for osc itself, so if we also need to update the constraint for novaclient we should do that separately. Is 10.1.0 part of the queens series? | 21:17 |
melwitt | yes. we got into a bind because osc for queens didn't mesh with novaclient for queens, so we had to use the previous version 9.1.x pike | 21:19 |
dhellmann | ok | 21:19 |
dhellmann | so, it sounds like the thing to do is release osc, land the constraint update for osc, then land a constraint update for novaclient | 21:19 |
dhellmann | that should let everything keep working as we push the changes through | 21:20 |
dhellmann | and for that novaclient constraint update I can anticipate the requirements team wanting lots of detail about why it's happening so "late" so be verbose in the commit message :-) | 21:20 |
melwitt | heh, k. thanks for the guidance | 21:21 |
*** sree has joined #openstack-release | 21:49 | |
*** sree has quit IRC | 21:53 | |
*** jtomasek has quit IRC | 21:53 | |
*** lifeless has quit IRC | 22:07 | |
*** esberglu has quit IRC | 22:10 | |
*** kumarmn has quit IRC | 22:22 | |
*** kumarmn has joined #openstack-release | 22:23 | |
*** kumarmn has quit IRC | 22:27 | |
*** kumarmn has joined #openstack-release | 22:41 | |
*** kumarmn has quit IRC | 22:46 | |
smcginnis | What he said. :) | 23:00 |
*** hongbin has quit IRC | 23:00 | |
*** mriedem has quit IRC | 23:06 | |
*** lifeless has joined #openstack-release | 23:10 | |
*** lifeless_ has joined #openstack-release | 23:23 | |
*** lifeless has quit IRC | 23:25 | |
*** mlavalle has quit IRC | 23:35 | |
*** kumarmn has joined #openstack-release | 23:36 | |
*** openstackstatus has joined #openstack-release | 23:43 | |
*** ChanServ sets mode: +v openstackstatus | 23:43 | |
*** kumarmn has quit IRC | 23:46 | |
*** kumarmn has joined #openstack-release | 23:48 | |
*** kumarmn has quit IRC | 23:49 | |
*** kumarmn has joined #openstack-release | 23:51 | |
*** kumarmn has quit IRC | 23:54 | |
*** kumarmn has joined #openstack-release | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!