*** timburke has joined #openstack-release | 00:00 | |
*** mgoddard has quit IRC | 00:06 | |
*** mgoddard has joined #openstack-release | 00:22 | |
*** hongbin has joined #openstack-release | 00:37 | |
*** dangtrinhnt has quit IRC | 01:24 | |
*** ricolin has joined #openstack-release | 01:29 | |
*** dangtrinhnt has joined #openstack-release | 01:31 | |
*** whoami-rajat has joined #openstack-release | 01:31 | |
*** ekcs has quit IRC | 01:46 | |
*** lbragstad has joined #openstack-release | 02:02 | |
*** bobh has joined #openstack-release | 02:07 | |
*** bobh has quit IRC | 02:17 | |
*** ekcs has joined #openstack-release | 02:30 | |
*** nhbinh_ has quit IRC | 02:49 | |
*** nhbinh_ has joined #openstack-release | 02:49 | |
*** hongbin has quit IRC | 02:57 | |
*** hongbin has joined #openstack-release | 02:58 | |
*** hongbin has quit IRC | 03:12 | |
*** hongbin has joined #openstack-release | 03:14 | |
*** samueldmq has quit IRC | 03:15 | |
*** ykarel|away has joined #openstack-release | 03:27 | |
*** hongbin has quit IRC | 03:31 | |
*** spsurya has joined #openstack-release | 03:31 | |
*** ekcs has quit IRC | 03:36 | |
*** ekcs has joined #openstack-release | 03:36 | |
*** ykarel|away is now known as ykarel | 03:40 | |
*** ekcs has quit IRC | 03:45 | |
*** ykarel has quit IRC | 04:11 | |
*** udesale has joined #openstack-release | 04:11 | |
*** ykarel has joined #openstack-release | 04:30 | |
*** lbragstad has quit IRC | 05:33 | |
*** pcaruana has joined #openstack-release | 05:35 | |
*** nhbinh_ has quit IRC | 05:42 | |
*** nhbinh_ has joined #openstack-release | 05:42 | |
*** ifat_afek has joined #openstack-release | 05:44 | |
*** jtomasek has joined #openstack-release | 06:29 | |
*** hberaud|gone is now known as hberaud | 07:01 | |
*** tesseract has joined #openstack-release | 07:02 | |
*** rakhmerov has joined #openstack-release | 07:08 | |
*** tosky has joined #openstack-release | 07:09 | |
*** e0ne has joined #openstack-release | 07:16 | |
*** jpich has joined #openstack-release | 07:38 | |
*** zul has quit IRC | 07:44 | |
*** ykarel is now known as ykarel|lunch | 07:58 | |
*** e0ne has quit IRC | 08:01 | |
*** e0ne has joined #openstack-release | 08:08 | |
*** openstackgerrit has joined #openstack-release | 08:15 | |
openstackgerrit | Ifat Afek proposed openstack/releases master: Release Vitrage deliverables for Stein https://review.openstack.org/648420 | 08:15 |
---|---|---|
*** zbr|pto is now known as zbr | 08:23 | |
*** cdent has joined #openstack-release | 08:29 | |
*** priteau has joined #openstack-release | 08:34 | |
*** ykarel|lunch is now known as ykarel | 08:50 | |
*** e0ne has quit IRC | 09:07 | |
*** e0ne has joined #openstack-release | 09:15 | |
*** dtantsur|afk is now known as dtantsur | 09:33 | |
*** electrofelix has joined #openstack-release | 09:34 | |
*** Sundar has joined #openstack-release | 09:43 | |
Sundar | clarkb and all: I followed https://docs.openstack.org/infra/manual/drivers.html#merge-commits to merge the master onto my feature branch. When I do 'git review -R feature/cyborg-nova-pilot', I get the error: "you are not allowed to upload merges". This seems like a permission issue. Who sets the permissions? | 09:48 |
Sundar | More details at: http://paste.openstack.org/show/748710/ | 09:48 |
Sundar | Previous discussion at: http://eavesdrop.openstack.org/irclogs/%23openstack-release/%23openstack-release.2019-04-01.log.html#t2019-04-01T17:07:26 | 09:50 |
*** e0ne has quit IRC | 09:51 | |
*** hberaud is now known as hberaud|school-r | 09:55 | |
*** zigo has joined #openstack-release | 10:04 | |
*** priteau has quit IRC | 10:07 | |
*** priteau has joined #openstack-release | 10:12 | |
*** e0ne has joined #openstack-release | 10:28 | |
*** e0ne has quit IRC | 10:45 | |
*** amoralej is now known as amoralej|lunch | 10:47 | |
*** diablo_rojo has joined #openstack-release | 10:51 | |
*** e0ne has joined #openstack-release | 10:52 | |
*** diablo_rojo has quit IRC | 11:10 | |
*** udesale has quit IRC | 11:10 | |
*** hberaud|school-r is now known as hberaud | 11:13 | |
*** amoralej|lunch is now known as amoralej | 11:29 | |
*** cdent has quit IRC | 11:36 | |
*** e0ne has quit IRC | 11:56 | |
dhellmann | Sundar : you'll have better luck contacting the infra team in #openstack-infra | 12:02 |
*** e0ne has joined #openstack-release | 12:03 | |
*** diablo_rojo has joined #openstack-release | 12:16 | |
*** e0ne has quit IRC | 12:31 | |
*** ifat_afek has quit IRC | 12:41 | |
*** e0ne has joined #openstack-release | 12:44 | |
*** mriedem has joined #openstack-release | 12:52 | |
*** cdent has joined #openstack-release | 12:55 | |
openstackgerrit | Luka Peschke proposed openstack/releases master: Release cloudkitty stein rc2 https://review.openstack.org/649313 | 13:07 |
*** mriedem has left #openstack-release | 13:08 | |
*** mriedem has joined #openstack-release | 13:09 | |
*** lbragstad has joined #openstack-release | 13:22 | |
openstackgerrit | Luka Peschke proposed openstack/releases master: Release cloudkitty stein rc2 https://review.openstack.org/649313 | 13:25 |
*** priteau has quit IRC | 13:28 | |
*** trident has quit IRC | 13:30 | |
*** trident has joined #openstack-release | 13:33 | |
*** e0ne has quit IRC | 13:36 | |
*** e0ne has joined #openstack-release | 13:42 | |
*** e0ne has quit IRC | 13:43 | |
*** dikonoor has joined #openstack-release | 13:59 | |
*** e0ne has joined #openstack-release | 14:10 | |
*** smcginnis_pto is now known as smcginnis | 14:16 | |
*** mlavalle has joined #openstack-release | 14:22 | |
*** hberaud is now known as hberaud|school-r | 14:24 | |
*** hberaud|school-r is now known as hberaud | 14:34 | |
*** cdent has quit IRC | 14:37 | |
Sundar | dhellman: Thanks | 14:41 |
openstackgerrit | Alex Schultz proposed openstack/releases master: Switch ansible-trole-container-registry to independant https://review.openstack.org/649349 | 14:42 |
openstackgerrit | Alex Schultz proposed openstack/releases master: Switch ansible-role-openstack-operations to independent https://review.openstack.org/649350 | 14:45 |
openstackgerrit | Alex Schultz proposed openstack/releases master: Switch ansible-role-container-registry to independent https://review.openstack.org/649349 | 14:47 |
openstackgerrit | Mohammed Naser proposed openstack/releases master: Branch Stein in OSA https://review.openstack.org/648947 | 14:54 |
*** e0ne has quit IRC | 15:11 | |
evrardjp | it seems we have issues with docs building with the new sphinx. I will have a look after my meetings of today | 15:14 |
smcginnis | evrardjp: Did you see the ML thread about the changes with sphinx 2.0? | 15:15 |
evrardjp | not yet, but I supposed that was it. | 15:15 |
evrardjp | I will have a look when $meeting ended I guess :) | 15:16 |
smcginnis | Looks like we need a new release of sphinxcontib.datatemplates. | 15:16 |
smcginnis | Or pin to sphinx < 2.0 | 15:16 |
smcginnis | I'm catching up yet, but I'll try to look into the status of that too. | 15:16 |
*** ykarel is now known as ykarel|away | 15:18 | |
*** ykarel|away has quit IRC | 15:23 | |
*** diablo_rojo has quit IRC | 15:26 | |
*** e0ne has joined #openstack-release | 15:38 | |
smcginnis | evrardjp, dhellmann: https://github.com/sphinx-contrib/datatemplates/issues/6 | 15:51 |
evrardjp | I think due to final release being very close it's maybe wise to pin <2 | 15:53 |
evrardjp | but I don't know yet the scale of the changes, so ignore this if not relevant | 15:53 |
evrardjp | smcginnis: aren't you on holidays though? | 15:53 |
smcginnis | evrardjp: No, just a long weekend. I was orginally going to take the whole week off, but decided to save it. | 15:53 |
smcginnis | evrardjp: We don't follow requirements contraints in our release jobs, so we can update that without an issue. | 15:54 |
smcginnis | Not sure how many other projects are impacted, so they may want to pin for now. But it's a fairly easy fix once you find out where it's coming from. | 15:54 |
evrardjp | oh I see | 15:54 |
evrardjp | I guess we can take popcorn and see if something happens in terms of pinning in the next days | 15:55 |
evrardjp | :) | 15:55 |
evrardjp | in the meantime it's good we are masters of our own destiny | 15:55 |
smcginnis | It does help in times like this. :) | 15:56 |
dhellmann | smcginnis , evrardjp : in the past we applied the cap for sphinx in the job definition | 16:05 |
smcginnis | dhellmann: Would you rather cap things? | 16:06 |
dhellmann | I'm doing a release right now, but we keep playing whack-a-mole with this | 16:07 |
dhellmann | they did at least signal the breaking changes this time with a 2.0 version number :-) | 16:07 |
smcginnis | Yeah, and it was deprecated for awhile. | 16:08 |
smcginnis | I had done a few cleanups in our (openstack) code, but I didn't think to look at some of the libs we use. | 16:08 |
dhellmann | nor i | 16:13 |
dhellmann | the datatemplates 0.2.0 release should deal with it | 16:13 |
dhellmann | thanks for the patch :-) | 16:13 |
smcginnis | Great, thanks dhellmann! | 16:13 |
*** ykarel|away has joined #openstack-release | 16:13 | |
evrardjp | thanks dhellmann -- what would we do without you! | 16:15 |
evrardjp | smcginnis: do you have a patch to change the requirements on which I can vote? | 16:15 |
evrardjp | OSA crew is very thrilled of making stein happen, as you acn see: https://review.openstack.org/#/c/648947/ :) | 16:16 |
evrardjp | it's amazing! | 16:16 |
*** dtantsur is now known as dtantsur|afk | 16:24 | |
*** e0ne has quit IRC | 16:28 | |
*** hberaud is now known as hberaud|gone | 16:46 | |
*** dikonoor has quit IRC | 16:55 | |
*** jpich has quit IRC | 16:58 | |
*** ricolin has quit IRC | 17:17 | |
*** amoralej is now known as amoralej|off | 17:28 | |
*** ekcs has joined #openstack-release | 17:45 | |
*** armax has joined #openstack-release | 17:53 | |
*** e0ne has joined #openstack-release | 18:04 | |
*** cdent has joined #openstack-release | 18:09 | |
*** electrofelix has quit IRC | 18:18 | |
*** cdent has quit IRC | 18:30 | |
*** spsurya has quit IRC | 18:32 | |
*** ykarel|away has quit IRC | 18:40 | |
*** gmann is now known as gmann_afk | 19:04 | |
*** tesseract has quit IRC | 19:04 | |
prometheanfire | https://pypi.org/project/PyECLib/ has not had 1.6.0 pushed to pypi | 19:12 |
prometheanfire | fyi | 19:12 |
prometheanfire | not sure if it's managed, bot doesn't show it I think | 19:13 |
smcginnis | prometheanfire: Who uses that? Swift? | 19:13 |
prometheanfire | ya | 19:13 |
prometheanfire | https://git.openstack.org/cgit/openstack/pyeclib/ tagged by tim burke | 19:14 |
prometheanfire | looks like unmanaged by releases | 19:14 |
smcginnis | Yeah, not listed in the official governance list. | 19:14 |
smcginnis | timburke: If you're around, friendly reminder in case you need that released. ^^ | 19:15 |
prometheanfire | I pined him in -swift | 19:15 |
smcginnis | Ah | 19:15 |
prometheanfire | didn't check for nick in here like I should have | 19:15 |
smcginnis | Too many places. | 19:15 |
prometheanfire | ya | 19:16 |
tdasilva | we noticed this issue with pyeclib: http://logs.openstack.org/54/54eaab52d4558a630da3aa32ab5a8439f9e56ce1/release/release-openstack-python/621e584/job-output.txt.gz#_2019-04-01_16_00_54_482423 | 19:16 |
tdasilva | I think that's the reason it is not being pused to pypi automatically?? but not sure yet how to get around the problem... | 19:17 |
tdasilva | s/pused/pushed | 19:17 |
smcginnis | tdasilva: Yeah, from that log it looks like pypi is rejecting it. | 19:17 |
smcginnis | Which is odd since that specific tag is an example in the pep: https://www.python.org/dev/peps/pep-0425/#overview | 19:18 |
*** e0ne has quit IRC | 19:20 | |
prometheanfire | I've tried to ping heat about missing releases but no response, email thread sound good as next step? | 19:22 |
smcginnis | Yeah, probably. | 19:23 |
prometheanfire | smcginnis: you said the heat issue was something to do with a rename somewhere? | 19:26 |
smcginnis | IIRC, the package name was changed in setup.cfg because it needed to be openstack-heat to be an available name on pypi. | 19:26 |
smcginnis | That was done in master (stein) but not in the older stable branches. | 19:26 |
prometheanfire | the tarball for 12.0.0-rc1 is missing too | 19:28 |
prometheanfire | which is stein | 19:28 |
smcginnis | Hmm, it uploaded to pypi: https://pypi.org/project/openstack-heat/ | 19:29 |
prometheanfire | mail sent | 19:30 |
smcginnis | Maybe once fungi is out of his meeting he can let us know if there were any known tarball upload issues. | 19:30 |
prometheanfire | ya, may be more limited to that | 19:30 |
prometheanfire | https://tarballs.openstack.org/openstack-heat doesn't exist | 19:31 |
prometheanfire | https://pypi.org/project/openstack-heat/#history doesn't have 11.0.1 either | 19:31 |
smcginnis | It just switched to that name for stein. | 19:31 |
smcginnis | Looks like the rc2.dev52 one listed there was probably them getting pypi set up for it. | 19:32 |
*** ianychoi has quit IRC | 19:32 | |
fungi | hopefully it was 12.0.0-0rc1 not 12.0.0-rc1 | 19:32 |
fungi | er, 12.0.0.0rc1 not 12.0.0-rc1 | 19:32 |
*** ianychoi has joined #openstack-release | 19:33 | |
prometheanfire | ya, I mistyped the dashes | 19:33 |
fungi | for pyeclib, we probably need some mechanism to avoid pushing wheels to pypi since it's not pure python | 19:35 |
smcginnis | Wouldn't that mechanism be not having publish-to-pypi set for that repo? | 19:36 |
fungi | we could come up with infrastructure to build "manylinux1" platform binary wheels if we want, but that'll take some effort | 19:36 |
fungi | well, we can publish sdists for it to pypi, just not wheels | 19:36 |
smcginnis | Ah | 19:36 |
smcginnis | tdasilva: ^ | 19:37 |
smcginnis | So probably need a publish-to-pypi-no-wheel or something? | 19:37 |
fungi | pypi expressly disallows things that look like binary wheels for linux, unless they're generic manylinux wheels built to handle linking against a known minimal set of c libraries common to most distros | 19:38 |
tdasilva | fungi: i guess i need to understand what changed between 1.5.0 and 1.6.0 that's breaking it being pushed to pypi...i don't think we have added non python code ?? | 19:39 |
fungi | tdasilva: ahh, i had assumed you built c extensions against eclib or something | 19:39 |
tdasilva | fungi: we do, but it's always been there | 19:39 |
fungi | was it possibly incorrectly marked as a "universal" wheel before? | 19:40 |
fungi | (that's pypiese for platform-independent) | 19:40 |
fungi | tdasilva: hrm, last release to pypi was june of 2017 | 19:41 |
fungi | so likely what changed in the intervening time was pypi itself | 19:41 |
smcginnis | pypi itself has made a lot of changes since then. | 19:41 |
fungi | so have we, i think | 19:42 |
fungi | at that time, we did not upload a wheel for pyeclib, only an sdist | 19:42 |
fungi | https://pypi.org/project/PyECLib/1.5.0/#files | 19:42 |
fungi | likely we still had separate sdist-only jobs back then | 19:42 |
smcginnis | So is it a new job? Or some flag that can be set to skip the wheel with the current one? | 19:42 |
smcginnis | I do seem to remember wheels being added fairly recently. | 19:43 |
fungi | good question, not sure what to suggest, it will need some discussion when i'm not in a meeting | 19:43 |
tdasilva | fungi, smcginnis: not sure yet what we can change on our side, where can I git around about skipping building a wheel? | 19:44 |
tdasilva | s/git/dig | 19:45 |
fungi | tdasilva: as smcginnis mentions, we probably need to modify or add to the existing release jobs, possibly even from zuul's standard library if they also similarly assume pure python packages | 19:45 |
tdasilva | fungi: gotcha. | 19:46 |
fungi | we've got 22 months of bitrot for handling releases of the one non-pure-python package in openstack, it looks like | 19:47 |
tdasilva | :/ sorry, that package has been widely used in swift deployments, but quite stable | 19:48 |
tdasilva | fungi, smcginnis: i haven't read the scrollback (just jumped in in here due to the swift mention) so I'm not sure if this discussion came in a meeting about stein release, but FWIW, we were not planning this 1.6.0 for Stein | 19:51 |
fungi | tdasilva: not your fault, i think we tend to just forget openstack's python packages aren't 100% pure python | 19:53 |
smcginnis | tdasilva: OK, thanks. prometheanfire just brought it to our attention. | 19:53 |
*** markmcclain has quit IRC | 20:01 | |
prometheanfire | tdasilva: fungi: my complaint is more about tarball publishing, but pypi maters too, I guess :P | 20:02 |
fungi | prometheanfire: yeah, i think the job currently tries to upload to pypi before uploading to tarballs.o.o | 20:03 |
prometheanfire | yep | 20:03 |
*** pcaruana has quit IRC | 20:30 | |
*** whoami-rajat has quit IRC | 20:30 | |
* timburke just got back from lunch | 21:03 | |
*** priteau has joined #openstack-release | 21:04 | |
timburke | so i'm guessing i ought to fix .zuul.yaml for pyeclib to *just* publish an sdist (which, looking at the history on pypi, seems to be the only way we've done that previously), then tag a 1.6.1? | 21:04 |
smcginnis | timburke: I think the issue is now the only publish-to-pypi job tries to build wheels by default. | 21:05 |
smcginnis | timburke: So may require some work in openstack-zuul-jobs and not just in the local .zuul.yaml. | 21:05 |
smcginnis | Or removal of the job I suppose and manual upload to pypi. | 21:06 |
fungi | that might not be the worst workaround if it's in service of a single package which releases once every two years | 21:19 |
fungi | in the spirit of https://xkcd.com/1205/ | 21:19 |
fungi | a robust solution would probably be to have the job spot wheel platforms which pypi doesn't support and then skip uploading those to it automatically | 21:22 |
fungi | which could in theory be handled with no changes to the interface, merely additional in-job logic | 21:23 |
fungi | timburke: did you write 649455 | 21:32 |
fungi | after i mentioned the above? | 21:32 |
fungi | or did you just read my mind? ;) | 21:32 |
fungi | because... that was really quick! | 21:33 |
timburke | yeah -- figured it'd be easier than (1) learning how to push to pypi and (2) making sure i'm allowed to push to pypi :-) | 21:33 |
timburke | i'd started looking into the jobs yesterday, so i had some idea of where to look | 21:33 |
fungi | well, thanks! | 21:33 |
fungi | timburke: tdasilva: smcginnis: once the zuul team merges 649455 i should be able to reenqueue the existing 1.6.0 tag for pyeclib and we'll get proper uploads | 21:49 |
timburke | thanks fungi! | 21:49 |
fungi | i went ahead and approved it just now. we can entertain options for building out a more thorough filter there in the future if it's warranted but odds are openstack will only be building its release artifacts on 64-bit x86 linux systems for the foreseeable future anyway so that ought to be plenty sufficient for us | 21:52 |
fungi | other users of that upload-pypi role outside openstack can always help improve it too | 21:53 |
smcginnis | Thanks fungi! | 21:56 |
timburke | the more i think about it, the more i wonder whether it should just ignore wheel upload results, and succeed/fail based on tar.gz upload | 21:58 |
timburke | seems weird to have to duplicate warehouse's whitelist in ansible; the next time they add a new supported tag, we'd have to change too | 21:59 |
timburke | *shrug* | 21:59 |
fungi | yeah, it's a weird scenario because twine fully expects you to just pass it a list of files you want uploaded, so the fact that we're doing them separately is already kinda weird | 22:14 |
*** priteau has quit IRC | 22:15 | |
fungi | though also, warehouse for the longest time (and may still) would only populate the json metadata for an entry of a wheel was the first artifact uploaded, which is why we try to upload the wheel before the sdist | 22:15 |
fungi | and then there's the pragmatic bit... by failing the job outright when we're unable to upload a given wheel, we make it more obvious if there's something causing us to build a malformed wheel pypi rejects whereas if we just ignored all wheel upload failures we might not know about missing ones (and might also run afoul of things like intermittent network problems or service disruptions which caused | 22:16 |
fungi | one to be omitted accidentally) | 22:17 |
fungi | reenqueued now via `sudo zuul enqueue-ref --tenant=openstack --trigger=gerrit --pipeline=release --project=openstack/pyeclib --ref=refs/tags/1.6.0 --newrev=54eaab52d4558a630da3aa32ab5a8439f9e56ce1` | 22:25 |
fungi | timburke: tdasilva: smcginnis: success! https://pypi.org/project/pyeclib/ | 22:30 |
timburke | whooo! thanks guys | 22:33 |
fungi | glad to help, thanks for improving the job! | 22:39 |
*** gmann_afk is now known as gmann | 23:11 | |
*** tosky has quit IRC | 23:24 | |
*** mlavalle has quit IRC | 23:33 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!