| *** tetsuro has joined #openstack-release | 00:16 | |
| *** e0ne has joined #openstack-release | 00:26 | |
| *** e0ne has quit IRC | 00:31 | |
| *** ricolin_ has joined #openstack-release | 01:54 | |
| *** ekcs has joined #openstack-release | 02:37 | |
| *** ekcs has quit IRC | 03:08 | |
| *** ekcs has joined #openstack-release | 03:09 | |
| openstackgerrit | Adrian Turjak proposed openstack/releases master: Update Adjutant version to 0.5.1 for bugfix https://review.opendev.org/726722 | 03:13 |
|---|---|---|
| *** slaweq has joined #openstack-release | 03:17 | |
| *** ekcs has quit IRC | 03:17 | |
| *** slaweq has quit IRC | 03:22 | |
| *** ricolin_ has quit IRC | 03:25 | |
| *** tetsuro has quit IRC | 03:28 | |
| *** tetsuro has joined #openstack-release | 04:16 | |
| *** evrardjp has quit IRC | 04:36 | |
| *** evrardjp has joined #openstack-release | 04:36 | |
| *** ykarel|away is now known as ykarel | 05:07 | |
| *** udesale has joined #openstack-release | 05:15 | |
| *** ricolin has quit IRC | 05:22 | |
| *** vishalmanchanda has joined #openstack-release | 05:29 | |
| *** ysandeep|away is now known as ysandeep | 05:42 | |
| *** slaweq has joined #openstack-release | 06:17 | |
| *** tinwood is now known as tinwood-afk | 07:06 | |
| *** tosky has joined #openstack-release | 07:34 | |
| *** rpittau|afk is now known as rpittau | 07:36 | |
| *** hberaud has quit IRC | 07:42 | |
| *** dtantsur|afk is now known as dtantsur | 08:04 | |
| *** tinwood-afk is now known as tinwood | 08:05 | |
| *** witek has joined #openstack-release | 08:09 | |
| *** EmilienM has quit IRC | 08:15 | |
| *** EmilienM has joined #openstack-release | 08:16 | |
| *** hberaud has joined #openstack-release | 08:26 | |
| *** ysandeep is now known as ysandeep|lunch | 08:27 | |
| *** huats_ has quit IRC | 08:27 | |
| *** ykarel is now known as ykarel|lunch | 08:27 | |
| *** huats has joined #openstack-release | 08:28 | |
| *** amoralej|off is now known as amoralej | 08:38 | |
| *** ykarel|lunch is now known as ykarel | 09:00 | |
| *** ysandeep|lunch is now known as ysandeep | 09:11 | |
| *** ykarel is now known as ykarel|mtg | 09:18 | |
| *** ricolin has joined #openstack-release | 09:20 | |
| ttx | smcginnis: See RCfreeze exception at https://review.opendev.org/#/c/726722/ | 09:22 |
| ttx | Regarding that validation error (Permission denied on bdist_wheel build)... could it come from https://review.opendev.org/#/c/726700/ ? Not sure what that patch fixes as it seemed to work just fine before | 09:33 |
| openstackgerrit | Merged openstack/releases master: Release rally-openstack 2.0.0 https://review.opendev.org/726482 | 09:42 |
| *** priteau has joined #openstack-release | 09:44 | |
| *** jbadiapa has joined #openstack-release | 09:48 | |
| *** ykarel|mtg is now known as ykarel | 10:05 | |
| *** rpittau is now known as rpittau|bbl | 10:15 | |
| *** tetsuro has quit IRC | 10:26 | |
| openstackgerrit | Merged openstack/releases master: Update add_reviewers to add to all open reviews https://review.opendev.org/726521 | 10:47 |
| openstackgerrit | Merged openstack/releases master: Increase validate job timeout to 3 hours https://review.opendev.org/726541 | 10:51 |
| openstackgerrit | Merged openstack/releases master: Install wheel in validate venv https://review.opendev.org/726700 | 10:53 |
| openstackgerrit | Merged openstack/releases master: Speed up sdist build https://review.opendev.org/726701 | 10:55 |
| *** ysandeep is now known as ysandeep|brb | 11:21 | |
| smcginnis | ttx: The wheel patch is really for local testing when calling "tox -e validate". I noticed on a system that did not have that installed that I would then get errors. | 11:31 |
| smcginnis | So I don't believe that has anything to do with the error. | 11:31 |
| smcginnis | ttx: Regarding the freeze exception, any reason why we should do that now and not just wait for a stable release? | 11:31 |
| smcginnis | ttx: I'm really reluctant to do that for a project that pretty much had to be remindeded at every step that there actually was such thing as a release cycle. | 11:31 |
| smcginnis | And the RC patch has most PTL acks already that would be wiped out if we had to update for a new release. | 11:32 |
| smcginnis | Not to mention setting a bad precendent that I was hoping we could avoid this time around. | 11:32 |
| ttx | smcginnis: it's a cycle-with-intermediary so it should not affect the final-release patch... Agree on the bad precedent. The only reason I'm considering it is that a migration bug is generally considered release-critical. that said it's the first release so we do not guarantee migrations will work... Your call | 11:34 |
| *** jovial[m1 has joined #openstack-release | 11:37 | |
| openstackgerrit | Thierry Carrez proposed openstack/releases master: [DNM] Test reproduce bdist_wheel error https://review.opendev.org/726785 | 11:38 |
| jovial[m1 | afternoon all, I've proposed to include ansible in the blacklist here: https://review.opendev.org/#/c/726768/. Just wondered if this idea had legs... Here is what I'm trying to do: https://review.opendev.org/#/c/726081/3 | 11:38 |
| ttx | jovial[m1: you might want to also ping #openstack-requirements on this | 11:40 |
| *** ysandeep|brb is now known as ysandeep | 11:40 | |
| smcginnis | ttx: Oh, true. c-w-i shouldn't have as much of an impact. | 11:41 |
| *** toabctl has quit IRC | 11:43 | |
| jovial[m1 | Thanks for pointing me to the correct channel. I've just posted the same message #openstack-requirements :-) | 11:45 |
| openstackgerrit | Thierry Carrez proposed openstack/releases master: [DNM] Test reproduce bdist_wheel error https://review.opendev.org/726785 | 11:48 |
| smcginnis | ttx: Hit the permission denied on that patch too. | 11:56 |
| smcginnis | Almost like an empty arg is being passed to subprocess. | 11:57 |
| *** rpittau|bbl is now known as rpittau | 11:58 | |
| smcginnis | Would be a lot easier to figure out if this would fail locally too. | 12:00 |
| *** amoralej is now known as amoralej|lunch | 12:09 | |
| ttx | hmm | 12:11 |
| openstackgerrit | Thierry Carrez proposed openstack/releases master: [DNM] Test reproduce bdist_wheel error https://review.opendev.org/726785 | 12:14 |
| *** priteau has quit IRC | 12:16 | |
| ttx | I don;t believe in coincidences | 12:24 |
| ttx | darn my 3rd test is blocked on a faulty test node | 12:28 |
| *** tkajinam has quit IRC | 12:31 | |
| smcginnis | Yeah, something in there. But I just tried on a fresh VM, and no luck getting it to fail locally again. | 12:31 |
| smcginnis | We may need to ask for a node to be held so we can do some local debugging. | 12:35 |
| ttx | ok, 2nd attempt | 12:37 |
| *** amoralej|lunch has quit IRC | 12:50 | |
| smcginnis | ttx: It seems like it must be something with the sdist speedup patch, but I've stared at that code a lot and can't figure out what would be causing an issue like this. | 12:51 |
| ttx | Yeah, been staring too | 12:52 |
| ttx | Last test results confirms that the speedup patch is tho blame | 12:52 |
| ttx | Maybe you can't alter the env of a child process in the sandbox we use to execute tests | 12:52 |
| ttx | I'll narrow it down to that | 12:53 |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Revert sdist rerun check https://review.opendev.org/726838 | 12:56 |
| *** zxiiro has joined #openstack-release | 12:57 | |
| *** amoralej has joined #openstack-release | 12:58 | |
| openstackgerrit | Thierry Carrez proposed openstack/releases master: [DNM] Test reproduce bdist_wheel error https://review.opendev.org/726785 | 13:01 |
| ttx | smcginnis: in this one I only remove the env set ^ | 13:01 |
| ttx | it's our most promising suspect, and you can keep the sdist cache | 13:02 |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Test limiting flags https://review.opendev.org/726839 | 13:02 |
| smcginnis | Trying the big one. | 13:02 |
| ttx | It actually fails when trying to run the command, so I think I'll win | 13:03 |
| *** ykarel is now known as ykarel|afk | 13:05 | |
| *** udesale_ has joined #openstack-release | 13:06 | |
| smcginnis | Yeah, but we still need to fix it. | 13:07 |
| smcginnis | I don't think we can stay in the timeout window for jobs otherwise. | 13:07 |
| ttx | we could increase timeout window | 13:08 |
| smcginnis | We're at the allowed max with the 3 hour window. Not sure if that is enough. | 13:09 |
| *** udesale has quit IRC | 13:09 | |
| smcginnis | It takes a loooong time to build nova's release notes. | 13:09 |
| smcginnis | And neutron, cinder, etc. | 13:09 |
| smcginnis | Otherwise we may need to break out the final taking into multiple patches. | 13:10 |
| smcginnis | Or temporarily disable validations. | 13:10 |
| ttx | we could increase the tenant limit | 13:10 |
| ttx | if that's the only way around it | 13:10 |
| ttx | In another meeting, need to pay attention | 13:11 |
| smcginnis | We may need to. But seems a shame since we don't need release notes to do our validation. | 13:11 |
| ttx | agreed. Once we narrow it down we should explore why it fails | 13:11 |
| *** amoralej has quit IRC | 13:19 | |
| smcginnis | I wonder if there is a bug in pbr when this flag is set. | 13:27 |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Revert sdist rerun check https://review.opendev.org/726838 | 13:29 |
| *** beekneemech is now known as bnemec | 13:47 | |
| *** diablo_rojo has joined #openstack-release | 13:56 | |
| *** ysandeep is now known as ysandeep|afk | 14:02 | |
| ttx | OK, that narrows it down to the env passing: https://review.opendev.org/#/c/726785/ | 14:04 |
| *** amoralej has joined #openstack-release | 14:10 | |
| *** dtantsur is now known as dtantsur|brb | 14:17 | |
| *** ykarel|afk is now known as ykarel | 14:19 | |
| ttx | still a bit of a mystery | 14:22 |
| *** jhesketh has quit IRC | 14:35 | |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Revert sdist rerun check https://review.opendev.org/726838 | 14:42 |
| *** dtantsur|brb is now known as dtantsur | 14:59 | |
| -openstackstatus- NOTICE: Our CI mirrors in OVH BHS1 and GRA1 regions were offline between 12:55 and 14:35 UTC, any failures there due to unreachable mirrors can safely be rechecked | 15:08 | |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Drop PBR environment flags from sdist build https://review.opendev.org/726879 | 15:12 |
| *** ykarel is now known as ykarel|away | 15:12 | |
| *** armax has joined #openstack-release | 15:22 | |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Drop PBR environment flags from sdist build https://review.opendev.org/726879 | 15:26 |
| *** weshay is now known as weshay|ruck | 15:28 | |
| *** ysandeep|afk is now known as ysandeep|away | 15:36 | |
| *** weshay|ruck is now known as weshay | 15:42 | |
| *** e0ne has joined #openstack-release | 15:45 | |
| *** weshay is now known as weshay|ruck | 15:45 | |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Revert sdist rerun check https://review.opendev.org/726838 | 15:48 |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Ussuri final releases for cycle-with-rc projects https://review.opendev.org/726484 | 15:51 |
| ttx | smcginnis: if you end up having to up the tenant limit, that is where that is defined: | 15:54 |
| ttx | https://zuul-ci.org/docs/zuul/reference/tenants.html#attr-tenant.max-job-timeout | 15:54 |
| ttx | https://opendev.org/openstack/project-config/src/branch/master/zuul/main.yaml#L103 | 15:55 |
| smcginnis | Thanks. It's looking more and more like that may be necessary. | 15:57 |
| ttx | smcginnis: so.... summary is you need to copy env before adding your flags | 16:02 |
| ttx | env = os.environ.copy() | 16:02 |
| smcginnis | I did that basically. Still fails. | 16:02 |
| ttx | hmmm where | 16:02 |
| smcginnis | https://review.opendev.org/#/c/726838/4/openstack_releases/processutils.py | 16:03 |
| ttx | ah, found it | 16:03 |
| openstackgerrit | Merged openstack/releases master: Drop PBR environment flags from sdist build https://review.opendev.org/726879 | 16:03 |
| ttx | smcginnis: in that file you do not pass env, right | 16:04 |
| ttx | only **kwargs | 16:04 |
| smcginnis | Right. It updates the existing env dict. | 16:05 |
| ttx | or does it pass the ref | 16:05 |
| ttx | hm | 16:05 |
| smcginnis | Should be passing the ref. | 16:05 |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Revert sdist rerun check https://review.opendev.org/726838 | 16:06 |
| ttx | Code examples I found use env = os.environ.copy() then env.update and then pass env explicitly, but I agree that should work | 16:06 |
| smcginnis | I'll try to be explicit. | 16:06 |
| smcginnis | I saw some things that indicated updating the environ used by subprocess may not be possible, and subprocess docs only refer to explicitly passing in an environment dictionary. But I could try that too. | 16:07 |
| *** rpittau is now known as rpittau|afk | 16:09 | |
| *** ianychoi_ is now known as ianychoi | 16:09 | |
| ttx | Your latest patchset will pass env= twice (one explicitly and one in kwargs), not sure that works | 16:12 |
| ttx | also it does not explain why this does not fail locally | 16:13 |
| ttx | I'll pick up the puzzle tomorrow morning if you haven't solved it by then | 16:13 |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Revert sdist rerun check https://review.opendev.org/726838 | 16:16 |
| clarkb | smcginnis: ttx what you do is copy the running processes environment then explicitly pass that in | 16:17 |
| *** witek has quit IRC | 16:17 | |
| clarkb | https://docs.python.org/3/library/os.html#os.environ <- make a copy of that object, then update it to include what you want and pass that updated copy into the subprocess | 16:18 |
| ttx | clarkb: yeah, that's what i suggested... smcginnis has a variant that looks like it should work though | 16:18 |
| smcginnis | clarkb: subprocess.run wants env to be a dict of string:sting values. Are you saying if it is in kwargs it will use it even though they have the separate env kwarg? | 16:18 |
| *** dtantsur is now known as dtantsur|afk | 16:19 | |
| clarkb | smcginnis: import os; env_copy = os.environ.copy(); env_copy['foo'] = 'bar'; processutils.check_call(env=env_copy) | 16:20 |
| ttx | Even if env is not provided. | 16:20 |
| smcginnis | OK, I can try that. | 16:20 |
| smcginnis | I suppose in the actual docs, it does not say explicitly that it wants a dict like I read elsewhere: "it must be a mapping that defines the environment variables" | 16:21 |
| ttx | ttyl! | 16:21 |
| smcginnis | o/ | 16:21 |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Pass full environ copy to sdist subprocess https://review.opendev.org/726838 | 16:31 |
| *** udesale_ has quit IRC | 16:34 | |
| *** evrardjp has quit IRC | 16:36 | |
| *** evrardjp has joined #openstack-release | 16:36 | |
| smcginnis | clarkb, fungi: Still fails with passing in a copy of os.environ. | 16:39 |
| clarkb | smcginnis: is that beacuse the kwargs.pop('env', None) should have a default of {} not None? | 16:43 |
| clarkb | oh wait you gaurd against that and you flip env aroung there so it should be ok | 16:43 |
| smcginnis | Yeah | 16:43 |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Pass full environ copy to sdist subprocess https://review.opendev.org/726838 | 16:52 |
| *** e0ne has quit IRC | 16:58 | |
| smcginnis | Well, that worked with getting the full path to the executable. | 17:53 |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Pass full environ copy to sdist subprocess https://review.opendev.org/726838 | 18:01 |
| *** jbadiapa has quit IRC | 18:08 | |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Ussuri final releases for cycle-with-rc projects https://review.opendev.org/726484 | 18:09 |
| *** witek has joined #openstack-release | 18:33 | |
| *** witek has quit IRC | 18:49 | |
| *** toabctl has joined #openstack-release | 18:57 | |
| openstackgerrit | Merged openstack/releases master: Update Adjutant version to 0.5.1 for bugfix https://review.opendev.org/726722 | 19:26 |
| *** diablo_rojo has quit IRC | 19:30 | |
| *** e0ne has joined #openstack-release | 19:50 | |
| *** e0ne has quit IRC | 20:13 | |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Test: debug sdist build environment https://review.opendev.org/726954 | 21:28 |
| openstackgerrit | Colleen Murphy proposed openstack/releases master: Release keystone for stein and train https://review.opendev.org/726955 | 21:35 |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Test: debug sdist build environment https://review.opendev.org/726954 | 21:43 |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Test: debug sdist build environment https://review.opendev.org/726954 | 22:04 |
| *** slaweq has quit IRC | 22:08 | |
| *** slaweq has joined #openstack-release | 22:08 | |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Pass full environ copy to sdist subprocess https://review.opendev.org/726838 | 22:09 |
| openstackgerrit | Sean McGinnis proposed openstack/releases master: Ussuri final releases for cycle-with-rc projects https://review.opendev.org/726484 | 22:10 |
| *** slaweq has quit IRC | 22:13 | |
| *** KeithMnemonic has joined #openstack-release | 22:14 | |
| *** tkajinam has joined #openstack-release | 22:55 | |
| *** tosky has quit IRC | 22:57 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!