*** tinwood has quit IRC | 02:10 | |
*** tinwood has joined #openstack-release | 02:13 | |
*** armax has quit IRC | 03:47 | |
*** rm_work has quit IRC | 04:58 | |
*** rm_work has joined #openstack-release | 04:58 | |
*** evrardjp has quit IRC | 05:33 | |
*** evrardjp has joined #openstack-release | 05:33 | |
*** tosky has joined #openstack-release | 06:24 | |
*** elod has joined #openstack-release | 06:45 | |
*** rpittau|afk is now known as rpittau | 07:20 | |
*** slaweq has joined #openstack-release | 07:25 | |
*** tkajinam has quit IRC | 08:08 | |
*** sboyron has joined #openstack-release | 08:11 | |
*** tkajinam has joined #openstack-release | 08:12 | |
hberaud | fungi: o/ FYI last evening we encoutered 3 failing failures with https://review.opendev.org/#/c/762549/. Indeed this patches released masakari is stable branches (stein, train, ussuri), and the upload to pypi failed for the three jobs (retry limit), I can see this error in the three logs "No package matching 'python-libvirt' is available" and after that many tasks are skipped as they are | 09:03 |
---|---|---|
hberaud | conditional tasks. | 09:03 |
hberaud | https://zuul.opendev.org/t/openstack/build/63539177d44b4ea48d3fbfe39a638275/log/job-output.txt#348 | 09:03 |
hberaud | https://zuul.opendev.org/t/openstack/build/778ace86ec8f4ef894d740d81e8f700f/log/job-output.txt#349 | 09:03 |
hberaud | rethttps://zuul.opendev.org/t/openstack/build/919cfc7df1e0408e9d6af4a9e8ef28ee/log/job-output.txt#347 | 09:04 |
hberaud | https://zuul.opendev.org/t/openstack/build/919cfc7df1e0408e9d6af4a9e8ef28ee/log/job-output.txt#347 | 09:04 |
ttx | hmm could be a mirror issue... probably better to hold on further releases until investigated | 09:04 |
hberaud | I agree | 09:04 |
ttx | ah hm | 09:05 |
ttx | I think it's linked to the move to focal. Focal has python3-libvirt | 09:06 |
hberaud | I was wondering if it could be a side effect of our move to focal | 09:06 |
hberaud | yeah agree | 09:07 |
ttx | no python-libvirt | 09:07 |
hberaud | but I can't find bindep in masakari's repo | 09:07 |
ttx | I'm a bit unclear why we do install the bindeps from those projects those | 09:07 |
hberaud | If I correctly understand python-libvirt is pulled from bindep, isn't? | 09:08 |
hberaud | (in this case) | 09:08 |
ttx | https://opendev.org/openstack/masakari-monitors/src/branch/master/bindep.txt | 09:08 |
hberaud | ah necessarily I wasn't looking in the right repo :) | 09:09 |
ttx | still unclear why it would pull python-libvirt | 09:09 |
hberaud | no idea | 09:09 |
hberaud | I agree it's a bit weird | 09:09 |
ttx | does not seem to come from libvirt-dev | 09:10 |
ttx | oh | 09:10 |
ttx | stable branches still have it | 09:11 |
ttx | https://opendev.org/openstack/masakari-monitors/src/branch/stable/ussuri/bindep.txt | 09:11 |
hberaud | yeap | 09:11 |
hberaud | https://opendev.org/openstack/masakari-monitors/src/branch/stable/stein/bindep.txt | 09:11 |
hberaud | so I think we just have to put a new line that correspond to focal | 09:12 |
ttx | https://opendev.org/openstack/masakari-monitors/commit/03ef3555888fdd0ea38b4edfdc093382071f1031 | 09:12 |
hberaud | but we also need to ensure that other repo doesn't have this kind of pkg that need to be pulled | 09:12 |
hberaud | ah good catch | 09:13 |
ttx | and it's a bit tricky to find as codesearch.o.o shows master branch | 09:13 |
hberaud | I need to dig on beagle to see if we can pass a branch, but I think it's similar to codesearch.o.o as it is based on it | 09:14 |
ttx | Yeah so we should probably hold on all stable releases | 09:15 |
ttx | victoria and wallaby should be fine as they were migrated to focal | 09:15 |
hberaud | yes | 09:15 |
ttx | others we should probably doublecheck their bindep before approving | 09:15 |
hberaud | yep I think we should only hold stein, train, ussuri | 09:15 |
hberaud | exact | 09:15 |
hberaud | so AFAIK beagle doesn't accept a branch param | 09:16 |
ttx | and we should find a way to inspect those stable bindeps and catch any other issue | 09:16 |
hberaud | it could be: 1. find projects that use bindep 2. clone them in a batch mode with a script 3. search on stein, train, ussuri for similar issue | 09:17 |
hberaud | it could be easy to code that | 09:17 |
hberaud | I think that 98% of projects that use bindep on master already had bindep on stable branches | 09:19 |
hberaud | and beagle could be used in 1 to generate the input list for 2 | 09:19 |
ttx | https://storyboard.openstack.org/#!/story/2007865 has all the tasks that gmann pushed to fix it in master, but I can't seem to be able to load it as it's too busy | 09:20 |
hberaud | I'll spend on it today | 09:20 |
hberaud | once their bindep will be fixed I suppose we should to bump to a new version, these failing versions will be lost for forever, isn't? | 09:23 |
ttx | TL;DR for people joining now: we have issues with now-focal release jobs on stable releases as they install old bindeps that may not be focal-compliant (example: masakari asking for python-libvirt instead of python3-libvirt in ussuri). We should hold on stable releases in ussuri and before | 09:23 |
ttx | hberaud: yes | 09:23 |
* hberaud afk | 09:24 | |
ttx | hberaud: i wonder if it's doable to fix the stable bindeps actually -- those branches are not using focal yet, so it might break them. Let's wait for fungi, see if he has suggestions | 09:32 |
hberaud | ack | 09:38 |
hberaud | within 1 hour I'll will send an email related to masakari's failure, to inform the project team about this | 09:40 |
*** whoami-rajat__ has quit IRC | 09:48 | |
*** brinzhang_ has quit IRC | 10:16 | |
*** icey has quit IRC | 10:30 | |
*** icey has joined #openstack-release | 10:36 | |
*** e0ne has joined #openstack-release | 11:35 | |
openstackgerrit | Radosław Piliszek proposed openstack/releases master: Re-release Masakari Monitors https://review.opendev.org/762648 | 12:45 |
openstackgerrit | Radosław Piliszek proposed openstack/releases master: [masakari] Transition Stein to EM https://review.opendev.org/762397 | 12:47 |
fungi | i half expected this, but wanted to see if it actually became a problem.... do we really need to install packages from bindep.txt just to build sdists/wheels? | 13:53 |
fungi | if so, zuul can now theoretically match tags to branches so we should be able to have branch matchers run point releases for older series on older nodesets | 13:54 |
fungi | but unless folks think we're likely to need additional distro packages just to make dists, then it might be easier to run those jobs without the bindep roles (or no-op/short-circuiting those roles somehow, maybe by specifying /dev/null as the package list) | 13:56 |
hberaud | AFAIK I don't think we need these packages (from bindep) | 14:02 |
*** rpittau is now known as rpittau|afk | 14:49 | |
gmann | hberaud: ttx stable branch before victoria run on Bionic (and xenial on <=rocky) so it should find it | 14:53 |
hberaud | gmann: but publish-openstack-artifacts was moved to focal few days ago => https://review.opendev.org/#/c/761776/ | 14:55 |
gmann | hberaud: we should run on Focal only for victoria onwards via brnahc variant like we do for all the common jobs used for stable and master | 14:57 |
gmann | fungi: ^^ | 14:57 |
fungi | gmann: yes, but these jobs are triggered by tags, not by changes on branches. tags aren't inherently tied to any particular branch | 15:03 |
fungi | zuul recently grew a feature to try and guess a relevant branch for a tag, but we haven't really tried it yet and it's never going to be perfect because a tag can point to an object which appears in multiple branches or even an object which appears on no branches | 15:04 |
fungi | we can give it a shot and see how it works out, but we need newer versions of some tools (recently the wheel package) because older versions don't necessarily work well with uploading things to pypi | 15:06 |
fungi | there are some things we can't really freeze when we make a stable branch, and the python packaging ecosystem is one of them | 15:07 |
gmann | fungi: ohk, I am not sure if running on Focal can bring up more issue than masakari one only. | 15:07 |
fungi | running on bionic brought up an issue, which is why we updated the ubuntu version for the release jobs | 15:08 |
fungi | but if the only issue from running on bionic is that we're trying to tell bindep to install old package names no longer available on focal, then it's probable we can just fix that by not using the bindep role. we shouldn't have to install project-specific distro packages just to create an sdist tarball or a wheel from them | 15:10 |
gmann | yeah that make sense. devstack does not install bindep package by default like for lib etc | 15:12 |
gmann | doing for release publish jobs will be good until asked by specific inherited job | 15:13 |
hberaud | notice that the root cause of all these things are the fact that some repo use a README at the markdown format rather than at the rst format, maybe that moving them to rst could be a straightforward path to follow. It could allow us to restore the `publish-openstack-artifacts` as before, thoughts? | 15:23 |
hberaud | s/are/was | 15:23 |
hberaud | and it could allow us to keep our envs aligned between the different kinds of jobs | 15:25 |
hberaud | and also allow us to align/standardize all our readme files | 15:26 |
*** ianychoi has joined #openstack-release | 15:30 | |
ttx | we need t move on to focal anyways, regardless of that README thing | 15:43 |
ttx | we should try to run that job without the bindep. i fear it's inherited from deep under though | 15:44 |
openstackgerrit | Jakub Libosvar proposed openstack/releases master: Release ovsdbapp 1.7.0 https://review.opendev.org/762676 | 15:48 |
ttx | could be as simple as removing line https://opendev.org/openstack/project-config/src/branch/master/playbooks/pti-python-tarball/pre.yaml#L3 | 15:50 |
ttx | will affect release-openstack-python test-release-openstack and publish-openstack-python-branch-tarball | 15:51 |
ttx | sounds reasonable, but not to test on a Friday | 15:52 |
gmann | +1 | 15:55 |
*** armax has joined #openstack-release | 15:57 | |
openstackgerrit | Merged openstack/releases master: [horizon] Transition Stein to EM https://review.opendev.org/762384 | 16:00 |
* smcginnis caught up | 16:00 | |
smcginnis | We could test with release-test, but it really will be a case of needing to be cautious with every release for a while to make sure there aren't any project specific gotchas that we aren't aware of. | 16:01 |
fungi | hberaud: if memory serves, the reason some projects use markdown readme files is for consistency with specific outside ecosystems they're used in | 16:09 |
smcginnis | That's my understand as well. Ansible Galaxy being one of them - https://galaxy.ansible.com/docs/contributing/creating_apb.html | 16:13 |
openstackgerrit | Daniel Bengtsson proposed openstack/releases master: New bugfix release for oslo.messaging for victoria. https://review.opendev.org/762680 | 16:13 |
clarkb | fungi: re bindep, I think you would need system packages if you have setup requires that build against them | 16:48 |
clarkb | chnaces of that seem slim, but it is theoretically possible | 16:48 |
fungi | right, i think a | 16:49 |
fungi | it's likely all our projects have only setuptools and pbr as setup-requires | 16:50 |
clarkb | yup extremely unlikely for openstack in particular due to use of pbr | 16:50 |
fungi | clarkb: i've replied on the ml thread as well, but looking through the logs of a release-openstack-python build i suspect we can drop the bindep and ensure-tox roles from playbooks/pti-python-tarball/pre.yaml | 17:22 |
fungi | we don't actually use tox nor install the project being packaged within the job | 17:23 |
clarkb | makes sense | 17:23 |
fungi | we probably need to keep ensure-pip because that makes sure we have wheel (sort of a side effect) | 17:23 |
fungi | i think those roles were just holdovers from back when we still used tox to invoke setup.py | 17:24 |
ttx | worst case scenario some corner case job fails | 17:34 |
fungi | i'll propose that cleanup as soon as i knock out the ovh log upload changes. just about caught up | 17:34 |
*** e0ne has quit IRC | 17:36 | |
*** bnemec is now known as beekneemech | 17:37 | |
hberaud | fungi: ack | 17:50 |
hberaud | ttx: +1 | 17:51 |
fungi | https://review.opendev.org/762699 Clean up pti-python-tarball python-branch-tarball | 18:14 |
fungi | hberaud: ttx: smcginnis: gmann: clarkb: ^ | 18:15 |
*** lifeless has quit IRC | 19:31 | |
*** lifeless has joined #openstack-release | 19:47 | |
*** slaweq has quit IRC | 20:03 | |
*** sboyron has quit IRC | 20:59 | |
*** sboyron has joined #openstack-release | 21:14 | |
*** sboyron has quit IRC | 22:49 | |
*** armax has quit IRC | 23:10 | |
*** armax has joined #openstack-release | 23:13 | |
*** corvus has quit IRC | 23:22 | |
*** jeblair has joined #openstack-release | 23:25 | |
*** jeblair is now known as corvus | 23:26 | |
*** tosky has quit IRC | 23:43 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!